blob: bbcd6a8e14c4faa97335458784074fca4f29f093 [file] [log] [blame]
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001//=- AnalysisBasedWarnings.cpp - Sema warnings based on libAnalysis -*- C++ -*-=//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines analysis_warnings::[Policy,Executor].
11// Together they are used by Sema to issue warnings based on inexpensive
12// static analysis algorithms in libAnalysis.
13//
14//===----------------------------------------------------------------------===//
15
Douglas Gregore737f502010-08-12 20:07:10 +000016#include "clang/Sema/AnalysisBasedWarnings.h"
John McCall2d887082010-08-25 22:03:47 +000017#include "clang/Sema/SemaInternal.h"
Ted Kremenek351ba912011-02-23 01:52:04 +000018#include "clang/Sema/ScopeInfo.h"
Ted Kremenekd068aab2010-03-20 21:11:09 +000019#include "clang/Basic/SourceManager.h"
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +000020#include "clang/Basic/SourceLocation.h"
Ted Kremenekfbb178a2011-01-21 19:41:46 +000021#include "clang/Lex/Preprocessor.h"
John McCall7cd088e2010-08-24 07:21:54 +000022#include "clang/AST/DeclObjC.h"
John McCall384aff82010-08-25 07:42:41 +000023#include "clang/AST/DeclCXX.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000024#include "clang/AST/ExprObjC.h"
25#include "clang/AST/ExprCXX.h"
26#include "clang/AST/StmtObjC.h"
27#include "clang/AST/StmtCXX.h"
Ted Kremenek6f417152011-04-04 20:56:00 +000028#include "clang/AST/EvaluatedExprVisitor.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000029#include "clang/AST/StmtVisitor.h"
Richard Smithe0d3b4c2012-05-03 18:27:39 +000030#include "clang/AST/RecursiveASTVisitor.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000031#include "clang/Analysis/AnalysisContext.h"
32#include "clang/Analysis/CFG.h"
33#include "clang/Analysis/Analyses/ReachableCode.h"
Ted Kremenek351ba912011-02-23 01:52:04 +000034#include "clang/Analysis/Analyses/CFGReachabilityAnalysis.h"
Caitlin Sadowski402aa062011-09-09 16:11:56 +000035#include "clang/Analysis/Analyses/ThreadSafety.h"
Ted Kremenek351ba912011-02-23 01:52:04 +000036#include "clang/Analysis/CFGStmtMap.h"
Ted Kremenek6f342132011-03-15 03:17:07 +000037#include "clang/Analysis/Analyses/UninitializedValues.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000038#include "llvm/ADT/BitVector.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000039#include "llvm/ADT/FoldingSet.h"
40#include "llvm/ADT/ImmutableMap.h"
41#include "llvm/ADT/PostOrderIterator.h"
42#include "llvm/ADT/SmallVector.h"
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +000043#include "llvm/ADT/StringRef.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000044#include "llvm/Support/Casting.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000045#include <algorithm>
Richard Smithe0d3b4c2012-05-03 18:27:39 +000046#include <iterator>
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000047#include <vector>
Richard Smithe0d3b4c2012-05-03 18:27:39 +000048#include <deque>
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000049
50using namespace clang;
51
52//===----------------------------------------------------------------------===//
53// Unreachable code analysis.
54//===----------------------------------------------------------------------===//
55
56namespace {
57 class UnreachableCodeHandler : public reachable_code::Callback {
58 Sema &S;
59 public:
60 UnreachableCodeHandler(Sema &s) : S(s) {}
61
62 void HandleUnreachable(SourceLocation L, SourceRange R1, SourceRange R2) {
63 S.Diag(L, diag::warn_unreachable) << R1 << R2;
64 }
65 };
66}
67
68/// CheckUnreachable - Check for unreachable code.
Ted Kremenek1d26f482011-10-24 01:32:45 +000069static void CheckUnreachable(Sema &S, AnalysisDeclContext &AC) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000070 UnreachableCodeHandler UC(S);
71 reachable_code::FindUnreachableCode(AC, UC);
72}
73
74//===----------------------------------------------------------------------===//
75// Check for missing return value.
76//===----------------------------------------------------------------------===//
77
John McCall16565aa2010-05-16 09:34:11 +000078enum ControlFlowKind {
79 UnknownFallThrough,
80 NeverFallThrough,
81 MaybeFallThrough,
82 AlwaysFallThrough,
83 NeverFallThroughOrReturn
84};
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000085
86/// CheckFallThrough - Check that we don't fall off the end of a
87/// Statement that should return a value.
88///
89/// \returns AlwaysFallThrough iff we always fall off the end of the statement,
90/// MaybeFallThrough iff we might or might not fall off the end,
91/// NeverFallThroughOrReturn iff we never fall off the end of the statement or
92/// return. We assume NeverFallThrough iff we never fall off the end of the
93/// statement but we may return. We assume that functions not marked noreturn
94/// will return.
Ted Kremenek1d26f482011-10-24 01:32:45 +000095static ControlFlowKind CheckFallThrough(AnalysisDeclContext &AC) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000096 CFG *cfg = AC.getCFG();
John McCall16565aa2010-05-16 09:34:11 +000097 if (cfg == 0) return UnknownFallThrough;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000098
99 // The CFG leaves in dead things, and we don't want the dead code paths to
100 // confuse us, so we mark all live things first.
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000101 llvm::BitVector live(cfg->getNumBlockIDs());
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +0000102 unsigned count = reachable_code::ScanReachableFromBlock(&cfg->getEntry(),
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000103 live);
104
105 bool AddEHEdges = AC.getAddEHEdges();
106 if (!AddEHEdges && count != cfg->getNumBlockIDs())
107 // When there are things remaining dead, and we didn't add EH edges
108 // from CallExprs to the catch clauses, we have to go back and
109 // mark them as live.
110 for (CFG::iterator I = cfg->begin(), E = cfg->end(); I != E; ++I) {
111 CFGBlock &b = **I;
112 if (!live[b.getBlockID()]) {
113 if (b.pred_begin() == b.pred_end()) {
114 if (b.getTerminator() && isa<CXXTryStmt>(b.getTerminator()))
115 // When not adding EH edges from calls, catch clauses
116 // can otherwise seem dead. Avoid noting them as dead.
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +0000117 count += reachable_code::ScanReachableFromBlock(&b, live);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000118 continue;
119 }
120 }
121 }
122
123 // Now we know what is live, we check the live precessors of the exit block
124 // and look for fall through paths, being careful to ignore normal returns,
125 // and exceptional paths.
126 bool HasLiveReturn = false;
127 bool HasFakeEdge = false;
128 bool HasPlainEdge = false;
129 bool HasAbnormalEdge = false;
Ted Kremenek90b828a2010-09-09 00:06:07 +0000130
131 // Ignore default cases that aren't likely to be reachable because all
132 // enums in a switch(X) have explicit case statements.
133 CFGBlock::FilterOptions FO;
134 FO.IgnoreDefaultsWithCoveredEnums = 1;
135
136 for (CFGBlock::filtered_pred_iterator
137 I = cfg->getExit().filtered_pred_start_end(FO); I.hasMore(); ++I) {
138 const CFGBlock& B = **I;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000139 if (!live[B.getBlockID()])
140 continue;
Ted Kremenek5811f592011-01-26 04:49:52 +0000141
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000142 // Skip blocks which contain an element marked as no-return. They don't
143 // represent actually viable edges into the exit block, so mark them as
144 // abnormal.
145 if (B.hasNoReturnElement()) {
146 HasAbnormalEdge = true;
147 continue;
148 }
149
Ted Kremenek5811f592011-01-26 04:49:52 +0000150 // Destructors can appear after the 'return' in the CFG. This is
151 // normal. We need to look pass the destructors for the return
152 // statement (if it exists).
153 CFGBlock::const_reverse_iterator ri = B.rbegin(), re = B.rend();
Ted Kremenekc9f8f5a2011-03-02 20:32:29 +0000154
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000155 for ( ; ri != re ; ++ri)
156 if (isa<CFGStmt>(*ri))
Ted Kremenek5811f592011-01-26 04:49:52 +0000157 break;
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000158
Ted Kremenek5811f592011-01-26 04:49:52 +0000159 // No more CFGElements in the block?
160 if (ri == re) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000161 if (B.getTerminator() && isa<CXXTryStmt>(B.getTerminator())) {
162 HasAbnormalEdge = true;
163 continue;
164 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000165 // A labeled empty statement, or the entry block...
166 HasPlainEdge = true;
167 continue;
168 }
Ted Kremenekf39e6a32011-01-25 22:50:47 +0000169
Ted Kremenek5811f592011-01-26 04:49:52 +0000170 CFGStmt CS = cast<CFGStmt>(*ri);
Ted Kremenekf1d10d92011-08-23 23:05:04 +0000171 const Stmt *S = CS.getStmt();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000172 if (isa<ReturnStmt>(S)) {
173 HasLiveReturn = true;
174 continue;
175 }
176 if (isa<ObjCAtThrowStmt>(S)) {
177 HasFakeEdge = true;
178 continue;
179 }
180 if (isa<CXXThrowExpr>(S)) {
181 HasFakeEdge = true;
182 continue;
183 }
184 if (const AsmStmt *AS = dyn_cast<AsmStmt>(S)) {
185 if (AS->isMSAsm()) {
186 HasFakeEdge = true;
187 HasLiveReturn = true;
188 continue;
189 }
190 }
191 if (isa<CXXTryStmt>(S)) {
192 HasAbnormalEdge = true;
193 continue;
194 }
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000195 if (std::find(B.succ_begin(), B.succ_end(), &cfg->getExit())
196 == B.succ_end()) {
197 HasAbnormalEdge = true;
198 continue;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000199 }
Chandler Carruthe05ee6d2011-09-13 09:53:58 +0000200
201 HasPlainEdge = true;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000202 }
203 if (!HasPlainEdge) {
204 if (HasLiveReturn)
205 return NeverFallThrough;
206 return NeverFallThroughOrReturn;
207 }
208 if (HasAbnormalEdge || HasFakeEdge || HasLiveReturn)
209 return MaybeFallThrough;
210 // This says AlwaysFallThrough for calls to functions that are not marked
211 // noreturn, that don't return. If people would like this warning to be more
212 // accurate, such functions should be marked as noreturn.
213 return AlwaysFallThrough;
214}
215
Dan Gohman3c46e8d2010-07-26 21:25:24 +0000216namespace {
217
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000218struct CheckFallThroughDiagnostics {
219 unsigned diag_MaybeFallThrough_HasNoReturn;
220 unsigned diag_MaybeFallThrough_ReturnsNonVoid;
221 unsigned diag_AlwaysFallThrough_HasNoReturn;
222 unsigned diag_AlwaysFallThrough_ReturnsNonVoid;
223 unsigned diag_NeverFallThroughOrReturn;
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000224 enum { Function, Block, Lambda } funMode;
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000225 SourceLocation FuncLoc;
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000226
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000227 static CheckFallThroughDiagnostics MakeForFunction(const Decl *Func) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000228 CheckFallThroughDiagnostics D;
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000229 D.FuncLoc = Func->getLocation();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000230 D.diag_MaybeFallThrough_HasNoReturn =
231 diag::warn_falloff_noreturn_function;
232 D.diag_MaybeFallThrough_ReturnsNonVoid =
233 diag::warn_maybe_falloff_nonvoid_function;
234 D.diag_AlwaysFallThrough_HasNoReturn =
235 diag::warn_falloff_noreturn_function;
236 D.diag_AlwaysFallThrough_ReturnsNonVoid =
237 diag::warn_falloff_nonvoid_function;
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000238
239 // Don't suggest that virtual functions be marked "noreturn", since they
240 // might be overridden by non-noreturn functions.
241 bool isVirtualMethod = false;
242 if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(Func))
243 isVirtualMethod = Method->isVirtual();
244
Douglas Gregorfcdd2cb2011-10-10 18:15:57 +0000245 // Don't suggest that template instantiations be marked "noreturn"
246 bool isTemplateInstantiation = false;
Ted Kremenek75df4ee2011-12-01 00:59:17 +0000247 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(Func))
248 isTemplateInstantiation = Function->isTemplateInstantiation();
Douglas Gregorfcdd2cb2011-10-10 18:15:57 +0000249
250 if (!isVirtualMethod && !isTemplateInstantiation)
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000251 D.diag_NeverFallThroughOrReturn =
252 diag::warn_suggest_noreturn_function;
253 else
254 D.diag_NeverFallThroughOrReturn = 0;
255
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000256 D.funMode = Function;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000257 return D;
258 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000259
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000260 static CheckFallThroughDiagnostics MakeForBlock() {
261 CheckFallThroughDiagnostics D;
262 D.diag_MaybeFallThrough_HasNoReturn =
263 diag::err_noreturn_block_has_return_expr;
264 D.diag_MaybeFallThrough_ReturnsNonVoid =
265 diag::err_maybe_falloff_nonvoid_block;
266 D.diag_AlwaysFallThrough_HasNoReturn =
267 diag::err_noreturn_block_has_return_expr;
268 D.diag_AlwaysFallThrough_ReturnsNonVoid =
269 diag::err_falloff_nonvoid_block;
270 D.diag_NeverFallThroughOrReturn =
271 diag::warn_suggest_noreturn_block;
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000272 D.funMode = Block;
273 return D;
274 }
275
276 static CheckFallThroughDiagnostics MakeForLambda() {
277 CheckFallThroughDiagnostics D;
278 D.diag_MaybeFallThrough_HasNoReturn =
279 diag::err_noreturn_lambda_has_return_expr;
280 D.diag_MaybeFallThrough_ReturnsNonVoid =
281 diag::warn_maybe_falloff_nonvoid_lambda;
282 D.diag_AlwaysFallThrough_HasNoReturn =
283 diag::err_noreturn_lambda_has_return_expr;
284 D.diag_AlwaysFallThrough_ReturnsNonVoid =
285 diag::warn_falloff_nonvoid_lambda;
286 D.diag_NeverFallThroughOrReturn = 0;
287 D.funMode = Lambda;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000288 return D;
289 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000290
David Blaikied6471f72011-09-25 23:23:43 +0000291 bool checkDiagnostics(DiagnosticsEngine &D, bool ReturnsVoid,
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000292 bool HasNoReturn) const {
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000293 if (funMode == Function) {
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000294 return (ReturnsVoid ||
295 D.getDiagnosticLevel(diag::warn_maybe_falloff_nonvoid_function,
David Blaikied6471f72011-09-25 23:23:43 +0000296 FuncLoc) == DiagnosticsEngine::Ignored)
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000297 && (!HasNoReturn ||
298 D.getDiagnosticLevel(diag::warn_noreturn_function_has_return_expr,
David Blaikied6471f72011-09-25 23:23:43 +0000299 FuncLoc) == DiagnosticsEngine::Ignored)
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000300 && (!ReturnsVoid ||
301 D.getDiagnosticLevel(diag::warn_suggest_noreturn_block, FuncLoc)
David Blaikied6471f72011-09-25 23:23:43 +0000302 == DiagnosticsEngine::Ignored);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000303 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000304
Douglas Gregor793cd1c2012-02-15 16:20:15 +0000305 // For blocks / lambdas.
306 return ReturnsVoid && !HasNoReturn
307 && ((funMode == Lambda) ||
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000308 D.getDiagnosticLevel(diag::warn_suggest_noreturn_block, FuncLoc)
David Blaikied6471f72011-09-25 23:23:43 +0000309 == DiagnosticsEngine::Ignored);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000310 }
311};
312
Dan Gohman3c46e8d2010-07-26 21:25:24 +0000313}
314
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000315/// CheckFallThroughForFunctionDef - Check that we don't fall off the end of a
316/// function that should return a value. Check that we don't fall off the end
317/// of a noreturn function. We assume that functions and blocks not marked
318/// noreturn will return.
319static void CheckFallThroughForBody(Sema &S, const Decl *D, const Stmt *Body,
Ted Kremenek3ed6fc02011-02-23 01:51:48 +0000320 const BlockExpr *blkExpr,
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000321 const CheckFallThroughDiagnostics& CD,
Ted Kremenek1d26f482011-10-24 01:32:45 +0000322 AnalysisDeclContext &AC) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000323
324 bool ReturnsVoid = false;
325 bool HasNoReturn = false;
326
327 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
328 ReturnsVoid = FD->getResultType()->isVoidType();
329 HasNoReturn = FD->hasAttr<NoReturnAttr>() ||
Rafael Espindola264ba482010-03-30 20:24:48 +0000330 FD->getType()->getAs<FunctionType>()->getNoReturnAttr();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000331 }
332 else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
333 ReturnsVoid = MD->getResultType()->isVoidType();
334 HasNoReturn = MD->hasAttr<NoReturnAttr>();
335 }
336 else if (isa<BlockDecl>(D)) {
Ted Kremenek3ed6fc02011-02-23 01:51:48 +0000337 QualType BlockTy = blkExpr->getType();
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000338 if (const FunctionType *FT =
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000339 BlockTy->getPointeeType()->getAs<FunctionType>()) {
340 if (FT->getResultType()->isVoidType())
341 ReturnsVoid = true;
342 if (FT->getNoReturnAttr())
343 HasNoReturn = true;
344 }
345 }
346
David Blaikied6471f72011-09-25 23:23:43 +0000347 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000348
349 // Short circuit for compilation speed.
350 if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
351 return;
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000352
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000353 // FIXME: Function try block
354 if (const CompoundStmt *Compound = dyn_cast<CompoundStmt>(Body)) {
355 switch (CheckFallThrough(AC)) {
John McCall16565aa2010-05-16 09:34:11 +0000356 case UnknownFallThrough:
357 break;
358
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000359 case MaybeFallThrough:
360 if (HasNoReturn)
361 S.Diag(Compound->getRBracLoc(),
362 CD.diag_MaybeFallThrough_HasNoReturn);
363 else if (!ReturnsVoid)
364 S.Diag(Compound->getRBracLoc(),
365 CD.diag_MaybeFallThrough_ReturnsNonVoid);
366 break;
367 case AlwaysFallThrough:
368 if (HasNoReturn)
369 S.Diag(Compound->getRBracLoc(),
370 CD.diag_AlwaysFallThrough_HasNoReturn);
371 else if (!ReturnsVoid)
372 S.Diag(Compound->getRBracLoc(),
373 CD.diag_AlwaysFallThrough_ReturnsNonVoid);
374 break;
375 case NeverFallThroughOrReturn:
Chandler Carruthb0656ec2011-08-31 09:01:53 +0000376 if (ReturnsVoid && !HasNoReturn && CD.diag_NeverFallThroughOrReturn) {
377 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
378 S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn)
Douglas Gregorb3321092011-09-10 00:56:20 +0000379 << 0 << FD;
380 } else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
381 S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn)
382 << 1 << MD;
Chandler Carruthb0656ec2011-08-31 09:01:53 +0000383 } else {
384 S.Diag(Compound->getLBracLoc(), CD.diag_NeverFallThroughOrReturn);
385 }
386 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000387 break;
388 case NeverFallThrough:
389 break;
390 }
391 }
392}
393
394//===----------------------------------------------------------------------===//
Ted Kremenek610068c2011-01-15 02:58:47 +0000395// -Wuninitialized
396//===----------------------------------------------------------------------===//
397
Ted Kremenek6f417152011-04-04 20:56:00 +0000398namespace {
Chandler Carruth9f649462011-04-05 06:48:00 +0000399/// ContainsReference - A visitor class to search for references to
400/// a particular declaration (the needle) within any evaluated component of an
401/// expression (recursively).
Ted Kremenek6f417152011-04-04 20:56:00 +0000402class ContainsReference : public EvaluatedExprVisitor<ContainsReference> {
Chandler Carruth9f649462011-04-05 06:48:00 +0000403 bool FoundReference;
404 const DeclRefExpr *Needle;
405
Ted Kremenek6f417152011-04-04 20:56:00 +0000406public:
Chandler Carruth9f649462011-04-05 06:48:00 +0000407 ContainsReference(ASTContext &Context, const DeclRefExpr *Needle)
408 : EvaluatedExprVisitor<ContainsReference>(Context),
409 FoundReference(false), Needle(Needle) {}
410
411 void VisitExpr(Expr *E) {
Ted Kremenek6f417152011-04-04 20:56:00 +0000412 // Stop evaluating if we already have a reference.
Chandler Carruth9f649462011-04-05 06:48:00 +0000413 if (FoundReference)
Ted Kremenek6f417152011-04-04 20:56:00 +0000414 return;
Chandler Carruth9f649462011-04-05 06:48:00 +0000415
416 EvaluatedExprVisitor<ContainsReference>::VisitExpr(E);
Ted Kremenek6f417152011-04-04 20:56:00 +0000417 }
Chandler Carruth9f649462011-04-05 06:48:00 +0000418
419 void VisitDeclRefExpr(DeclRefExpr *E) {
420 if (E == Needle)
421 FoundReference = true;
422 else
423 EvaluatedExprVisitor<ContainsReference>::VisitDeclRefExpr(E);
Ted Kremenek6f417152011-04-04 20:56:00 +0000424 }
Chandler Carruth9f649462011-04-05 06:48:00 +0000425
426 bool doesContainReference() const { return FoundReference; }
Ted Kremenek6f417152011-04-04 20:56:00 +0000427};
428}
429
David Blaikie4f4f3492011-09-10 05:35:08 +0000430static bool SuggestInitializationFixit(Sema &S, const VarDecl *VD) {
Fariborz Jahaniana34194f2012-03-08 00:22:50 +0000431 QualType VariableTy = VD->getType().getCanonicalType();
432 if (VariableTy->isBlockPointerType() &&
433 !VD->hasAttr<BlocksAttr>()) {
434 S.Diag(VD->getLocation(), diag::note_block_var_fixit_add_initialization) << VD->getDeclName()
435 << FixItHint::CreateInsertion(VD->getLocation(), "__block ");
436 return true;
437 }
438
David Blaikie4f4f3492011-09-10 05:35:08 +0000439 // Don't issue a fixit if there is already an initializer.
440 if (VD->getInit())
441 return false;
Fariborz Jahaniana34194f2012-03-08 00:22:50 +0000442
David Blaikie4f4f3492011-09-10 05:35:08 +0000443 // Suggest possible initialization (if any).
David Blaikie2c0abf42012-04-30 18:27:22 +0000444 std::string Init = S.getFixItZeroInitializerForType(VariableTy);
445 if (Init.empty())
David Blaikie4f4f3492011-09-10 05:35:08 +0000446 return false;
Richard Trieu7b0a3e32012-05-03 01:09:59 +0000447
448 // Don't suggest a fixit inside macros.
449 if (VD->getLocEnd().isMacroID())
450 return false;
451
Richard Smith7984de32012-01-12 23:53:29 +0000452 SourceLocation Loc = S.PP.getLocForEndOfToken(VD->getLocEnd());
Fariborz Jahaniana34194f2012-03-08 00:22:50 +0000453
Richard Smith7984de32012-01-12 23:53:29 +0000454 S.Diag(Loc, diag::note_var_fixit_add_initialization) << VD->getDeclName()
455 << FixItHint::CreateInsertion(Loc, Init);
456 return true;
David Blaikie4f4f3492011-09-10 05:35:08 +0000457}
458
Richard Smith2815e1a2012-05-25 02:17:09 +0000459/// NoteUninitBranches -- Helper function to produce notes for branches which
460/// inevitably lead to an uninitialized variable use.
461static void NoteUninitBranches(Sema &S, const UninitUse &Use) {
462 for (UninitUse::branch_iterator I = Use.branch_begin(), E = Use.branch_end();
463 I != E; ++I) {
464 const Stmt *Term = I->Terminator;
465 unsigned DiagKind;
466 SourceRange Range;
467 const char *Str;
468 switch (Term->getStmtClass()) {
469 default:
470 // Don't know how to report this.
471 continue;
472
473 // "condition is true / condition is false".
474 case Stmt::IfStmtClass:
475 DiagKind = 0;
476 Str = "if";
477 Range = cast<IfStmt>(Term)->getCond()->getSourceRange();
478 break;
479 case Stmt::ConditionalOperatorClass:
480 DiagKind = 0;
481 Str = "?:";
482 Range = cast<ConditionalOperator>(Term)->getCond()->getSourceRange();
483 break;
484 case Stmt::BinaryOperatorClass: {
485 const BinaryOperator *BO = cast<BinaryOperator>(Term);
486 if (!BO->isLogicalOp())
487 continue;
488 DiagKind = 0;
489 Str = BO->getOpcodeStr();
490 Range = BO->getLHS()->getSourceRange();
491 break;
492 }
493
494 // "loop is entered / loop is exited".
495 case Stmt::WhileStmtClass:
496 DiagKind = 1;
497 Str = "while";
498 Range = cast<WhileStmt>(Term)->getCond()->getSourceRange();
499 break;
500 case Stmt::ForStmtClass:
501 DiagKind = 1;
502 Str = "for";
503 Range = cast<ForStmt>(Term)->getCond()->getSourceRange();
504 break;
505 case Stmt::CXXForRangeStmtClass:
506 DiagKind = 1;
507 Str = "for";
508 Range = cast<CXXForRangeStmt>(Term)->getCond()->getSourceRange();
509 break;
510
511 // "condition is true / loop is exited".
512 case Stmt::DoStmtClass:
513 DiagKind = 2;
514 Str = "do";
515 Range = cast<DoStmt>(Term)->getCond()->getSourceRange();
516 break;
517
518 // "switch case is taken".
519 case Stmt::CaseStmtClass:
520 DiagKind = 3;
521 Str = "case";
522 Range = cast<CaseStmt>(Term)->getLHS()->getSourceRange();
523 break;
524 case Stmt::DefaultStmtClass:
525 DiagKind = 3;
526 Str = "default";
527 Range = cast<DefaultStmt>(Term)->getDefaultLoc();
528 break;
529 }
530
531 S.Diag(Range.getBegin(), diag::note_sometimes_uninit_var_branch)
532 << DiagKind << Str << I->Output << Range;
533 }
534}
535
Chandler Carruth262d50e2011-04-05 18:27:05 +0000536/// DiagnoseUninitializedUse -- Helper function for diagnosing uses of an
537/// uninitialized variable. This manages the different forms of diagnostic
538/// emitted for particular types of uses. Returns true if the use was diagnosed
Richard Smith2815e1a2012-05-25 02:17:09 +0000539/// as a warning. If a particular use is one we omit warnings for, returns
Chandler Carruth262d50e2011-04-05 18:27:05 +0000540/// false.
541static bool DiagnoseUninitializedUse(Sema &S, const VarDecl *VD,
Richard Smith2815e1a2012-05-25 02:17:09 +0000542 const UninitUse &Use,
Ted Kremenek9e761722011-10-13 18:50:06 +0000543 bool alwaysReportSelfInit = false) {
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000544
Richard Smith2815e1a2012-05-25 02:17:09 +0000545 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Use.getUser())) {
Richard Trieuf6278e52012-05-09 21:08:22 +0000546 // Inspect the initializer of the variable declaration which is
547 // being referenced prior to its initialization. We emit
548 // specialized diagnostics for self-initialization, and we
549 // specifically avoid warning about self references which take the
550 // form of:
551 //
552 // int x = x;
553 //
554 // This is used to indicate to GCC that 'x' is intentionally left
555 // uninitialized. Proven code paths which access 'x' in
556 // an uninitialized state after this will still warn.
557 if (const Expr *Initializer = VD->getInit()) {
558 if (!alwaysReportSelfInit && DRE == Initializer->IgnoreParenImpCasts())
559 return false;
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000560
Richard Trieuf6278e52012-05-09 21:08:22 +0000561 ContainsReference CR(S.Context, DRE);
562 CR.Visit(const_cast<Expr*>(Initializer));
563 if (CR.doesContainReference()) {
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000564 S.Diag(DRE->getLocStart(),
565 diag::warn_uninit_self_reference_in_init)
Richard Trieuf6278e52012-05-09 21:08:22 +0000566 << VD->getDeclName() << VD->getLocation() << DRE->getSourceRange();
567 return true;
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000568 }
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000569 }
Richard Trieuf6278e52012-05-09 21:08:22 +0000570
Richard Smith2815e1a2012-05-25 02:17:09 +0000571 unsigned DiagID = 0;
572 switch (Use.getKind()) {
573 case UninitUse::Always: DiagID = diag::warn_uninit_var; break;
574 case UninitUse::Sometimes: DiagID = diag::warn_sometimes_uninit_var; break;
575 case UninitUse::Maybe: DiagID = diag::warn_maybe_uninit_var; break;
576 }
577 S.Diag(DRE->getLocStart(), DiagID)
Richard Trieuf6278e52012-05-09 21:08:22 +0000578 << VD->getDeclName() << DRE->getSourceRange();
Richard Smith2815e1a2012-05-25 02:17:09 +0000579 NoteUninitBranches(S, Use);
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000580 } else {
Richard Smith2815e1a2012-05-25 02:17:09 +0000581 const BlockExpr *BE = cast<BlockExpr>(Use.getUser());
Fariborz Jahaniana34194f2012-03-08 00:22:50 +0000582 if (VD->getType()->isBlockPointerType() &&
583 !VD->hasAttr<BlocksAttr>())
584 S.Diag(BE->getLocStart(), diag::warn_uninit_byref_blockvar_captured_by_block)
585 << VD->getDeclName();
Richard Smith2815e1a2012-05-25 02:17:09 +0000586 else {
587 unsigned DiagID = 0;
588 switch (Use.getKind()) {
589 case UninitUse::Always:
590 DiagID = diag::warn_uninit_var_captured_by_block;
591 break;
592 case UninitUse::Sometimes:
593 DiagID = diag::warn_sometimes_uninit_var_captured_by_block;
594 break;
595 case UninitUse::Maybe:
596 DiagID = diag::warn_maybe_uninit_var_captured_by_block;
597 break;
598 }
599 S.Diag(BE->getLocStart(), DiagID) << VD->getDeclName();
600 NoteUninitBranches(S, Use);
601 }
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000602 }
603
604 // Report where the variable was declared when the use wasn't within
David Blaikie4f4f3492011-09-10 05:35:08 +0000605 // the initializer of that declaration & we didn't already suggest
606 // an initialization fixit.
Richard Trieuf6278e52012-05-09 21:08:22 +0000607 if (!SuggestInitializationFixit(S, VD))
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000608 S.Diag(VD->getLocStart(), diag::note_uninit_var_def)
609 << VD->getDeclName();
610
Chandler Carruth262d50e2011-04-05 18:27:05 +0000611 return true;
Chandler Carruth64fb9592011-04-05 18:18:08 +0000612}
613
Richard Smithe0d3b4c2012-05-03 18:27:39 +0000614namespace {
615 class FallthroughMapper : public RecursiveASTVisitor<FallthroughMapper> {
616 public:
617 FallthroughMapper(Sema &S)
618 : FoundSwitchStatements(false),
619 S(S) {
620 }
621
622 bool foundSwitchStatements() const { return FoundSwitchStatements; }
623
624 void markFallthroughVisited(const AttributedStmt *Stmt) {
625 bool Found = FallthroughStmts.erase(Stmt);
626 assert(Found);
Kaelyn Uhrain3bb29942012-05-03 19:46:38 +0000627 (void)Found;
Richard Smithe0d3b4c2012-05-03 18:27:39 +0000628 }
629
630 typedef llvm::SmallPtrSet<const AttributedStmt*, 8> AttrStmts;
631
632 const AttrStmts &getFallthroughStmts() const {
633 return FallthroughStmts;
634 }
635
636 bool checkFallThroughIntoBlock(const CFGBlock &B, int &AnnotatedCnt) {
637 int UnannotatedCnt = 0;
638 AnnotatedCnt = 0;
639
640 std::deque<const CFGBlock*> BlockQueue;
641
642 std::copy(B.pred_begin(), B.pred_end(), std::back_inserter(BlockQueue));
643
644 while (!BlockQueue.empty()) {
645 const CFGBlock *P = BlockQueue.front();
646 BlockQueue.pop_front();
647
648 const Stmt *Term = P->getTerminator();
649 if (Term && isa<SwitchStmt>(Term))
650 continue; // Switch statement, good.
651
652 const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(P->getLabel());
653 if (SW && SW->getSubStmt() == B.getLabel() && P->begin() == P->end())
654 continue; // Previous case label has no statements, good.
655
656 if (P->pred_begin() == P->pred_end()) { // The block is unreachable.
657 // This only catches trivially unreachable blocks.
658 for (CFGBlock::const_iterator ElIt = P->begin(), ElEnd = P->end();
659 ElIt != ElEnd; ++ElIt) {
660 if (const CFGStmt *CS = ElIt->getAs<CFGStmt>()){
661 if (const AttributedStmt *AS = asFallThroughAttr(CS->getStmt())) {
662 S.Diag(AS->getLocStart(),
663 diag::warn_fallthrough_attr_unreachable);
664 markFallthroughVisited(AS);
665 ++AnnotatedCnt;
666 }
667 // Don't care about other unreachable statements.
668 }
669 }
670 // If there are no unreachable statements, this may be a special
671 // case in CFG:
672 // case X: {
673 // A a; // A has a destructor.
674 // break;
675 // }
676 // // <<<< This place is represented by a 'hanging' CFG block.
677 // case Y:
678 continue;
679 }
680
681 const Stmt *LastStmt = getLastStmt(*P);
682 if (const AttributedStmt *AS = asFallThroughAttr(LastStmt)) {
683 markFallthroughVisited(AS);
684 ++AnnotatedCnt;
685 continue; // Fallthrough annotation, good.
686 }
687
688 if (!LastStmt) { // This block contains no executable statements.
689 // Traverse its predecessors.
690 std::copy(P->pred_begin(), P->pred_end(),
691 std::back_inserter(BlockQueue));
692 continue;
693 }
694
695 ++UnannotatedCnt;
696 }
697 return !!UnannotatedCnt;
698 }
699
700 // RecursiveASTVisitor setup.
701 bool shouldWalkTypesOfTypeLocs() const { return false; }
702
703 bool VisitAttributedStmt(AttributedStmt *S) {
704 if (asFallThroughAttr(S))
705 FallthroughStmts.insert(S);
706 return true;
707 }
708
709 bool VisitSwitchStmt(SwitchStmt *S) {
710 FoundSwitchStatements = true;
711 return true;
712 }
713
714 private:
715
716 static const AttributedStmt *asFallThroughAttr(const Stmt *S) {
717 if (const AttributedStmt *AS = dyn_cast_or_null<AttributedStmt>(S)) {
718 if (hasSpecificAttr<FallThroughAttr>(AS->getAttrs()))
719 return AS;
720 }
721 return 0;
722 }
723
724 static const Stmt *getLastStmt(const CFGBlock &B) {
725 if (const Stmt *Term = B.getTerminator())
726 return Term;
727 for (CFGBlock::const_reverse_iterator ElemIt = B.rbegin(),
728 ElemEnd = B.rend();
729 ElemIt != ElemEnd; ++ElemIt) {
730 if (const CFGStmt *CS = ElemIt->getAs<CFGStmt>())
731 return CS->getStmt();
732 }
733 // Workaround to detect a statement thrown out by CFGBuilder:
734 // case X: {} case Y:
735 // case X: ; case Y:
736 if (const SwitchCase *SW = dyn_cast_or_null<SwitchCase>(B.getLabel()))
737 if (!isa<SwitchCase>(SW->getSubStmt()))
738 return SW->getSubStmt();
739
740 return 0;
741 }
742
743 bool FoundSwitchStatements;
744 AttrStmts FallthroughStmts;
745 Sema &S;
746 };
747}
748
749static void DiagnoseSwitchLabelsFallthrough(Sema &S, AnalysisDeclContext &AC) {
750 FallthroughMapper FM(S);
751 FM.TraverseStmt(AC.getBody());
752
753 if (!FM.foundSwitchStatements())
754 return;
755
756 CFG *Cfg = AC.getCFG();
757
758 if (!Cfg)
759 return;
760
761 int AnnotatedCnt;
762
763 for (CFG::reverse_iterator I = Cfg->rbegin(), E = Cfg->rend(); I != E; ++I) {
764 const CFGBlock &B = **I;
765 const Stmt *Label = B.getLabel();
766
767 if (!Label || !isa<SwitchCase>(Label))
768 continue;
769
770 if (!FM.checkFallThroughIntoBlock(B, AnnotatedCnt))
771 continue;
772
773 S.Diag(Label->getLocStart(), diag::warn_unannotated_fallthrough);
774
775 if (!AnnotatedCnt) {
776 SourceLocation L = Label->getLocStart();
777 if (L.isMacroID())
778 continue;
779 if (S.getLangOpts().CPlusPlus0x) {
780 S.Diag(L, diag::note_insert_fallthrough_fixit) <<
781 FixItHint::CreateInsertion(L, "[[clang::fallthrough]]; ");
782 }
783 S.Diag(L, diag::note_insert_break_fixit) <<
784 FixItHint::CreateInsertion(L, "break; ");
785 }
786 }
787
788 const FallthroughMapper::AttrStmts &Fallthroughs = FM.getFallthroughStmts();
789 for (FallthroughMapper::AttrStmts::const_iterator I = Fallthroughs.begin(),
790 E = Fallthroughs.end();
791 I != E; ++I) {
792 S.Diag((*I)->getLocStart(), diag::warn_fallthrough_attr_invalid_placement);
793 }
794
795}
796
Ted Kremenek610068c2011-01-15 02:58:47 +0000797namespace {
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000798struct SLocSort {
Ted Kremenekf7bafc72011-03-15 04:57:38 +0000799 bool operator()(const UninitUse &a, const UninitUse &b) {
Richard Smith2815e1a2012-05-25 02:17:09 +0000800 // Prefer a more confident report over a less confident one.
801 if (a.getKind() != b.getKind())
802 return a.getKind() > b.getKind();
803 SourceLocation aLoc = a.getUser()->getLocStart();
804 SourceLocation bLoc = b.getUser()->getLocStart();
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000805 return aLoc.getRawEncoding() < bLoc.getRawEncoding();
806 }
807};
808
Ted Kremenek610068c2011-01-15 02:58:47 +0000809class UninitValsDiagReporter : public UninitVariablesHandler {
810 Sema &S;
Chris Lattner5f9e2722011-07-23 10:55:15 +0000811 typedef SmallVector<UninitUse, 2> UsesVec;
Ted Kremenek9e761722011-10-13 18:50:06 +0000812 typedef llvm::DenseMap<const VarDecl *, std::pair<UsesVec*, bool> > UsesMap;
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000813 UsesMap *uses;
814
Ted Kremenek610068c2011-01-15 02:58:47 +0000815public:
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000816 UninitValsDiagReporter(Sema &S) : S(S), uses(0) {}
817 ~UninitValsDiagReporter() {
818 flushDiagnostics();
819 }
Ted Kremenek9e761722011-10-13 18:50:06 +0000820
821 std::pair<UsesVec*, bool> &getUses(const VarDecl *vd) {
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000822 if (!uses)
823 uses = new UsesMap();
Ted Kremenek9e761722011-10-13 18:50:06 +0000824
825 UsesMap::mapped_type &V = (*uses)[vd];
826 UsesVec *&vec = V.first;
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000827 if (!vec)
828 vec = new UsesVec();
829
Ted Kremenek9e761722011-10-13 18:50:06 +0000830 return V;
831 }
832
Richard Smith2815e1a2012-05-25 02:17:09 +0000833 void handleUseOfUninitVariable(const VarDecl *vd, const UninitUse &use) {
834 getUses(vd).first->push_back(use);
Ted Kremenek9e761722011-10-13 18:50:06 +0000835 }
836
837 void handleSelfInit(const VarDecl *vd) {
838 getUses(vd).second = true;
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000839 }
840
841 void flushDiagnostics() {
842 if (!uses)
843 return;
Ted Kremenek609e3172011-02-02 23:35:53 +0000844
Richard Smith81891882012-05-24 23:45:35 +0000845 // FIXME: This iteration order, and thus the resulting diagnostic order,
846 // is nondeterministic.
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000847 for (UsesMap::iterator i = uses->begin(), e = uses->end(); i != e; ++i) {
848 const VarDecl *vd = i->first;
Ted Kremenek9e761722011-10-13 18:50:06 +0000849 const UsesMap::mapped_type &V = i->second;
Ted Kremenek609e3172011-02-02 23:35:53 +0000850
Ted Kremenek9e761722011-10-13 18:50:06 +0000851 UsesVec *vec = V.first;
852 bool hasSelfInit = V.second;
853
854 // Specially handle the case where we have uses of an uninitialized
855 // variable, but the root cause is an idiomatic self-init. We want
856 // to report the diagnostic at the self-init since that is the root cause.
Matt Beaumont-Gay0d381812011-10-19 18:53:03 +0000857 if (!vec->empty() && hasSelfInit && hasAlwaysUninitializedUse(vec))
Richard Smith2815e1a2012-05-25 02:17:09 +0000858 DiagnoseUninitializedUse(S, vd,
859 UninitUse(vd->getInit()->IgnoreParenCasts(),
860 /* isAlwaysUninit */ true),
Matt Beaumont-Gay0d381812011-10-19 18:53:03 +0000861 /* alwaysReportSelfInit */ true);
Ted Kremenek9e761722011-10-13 18:50:06 +0000862 else {
863 // Sort the uses by their SourceLocations. While not strictly
864 // guaranteed to produce them in line/column order, this will provide
865 // a stable ordering.
866 std::sort(vec->begin(), vec->end(), SLocSort());
867
868 for (UsesVec::iterator vi = vec->begin(), ve = vec->end(); vi != ve;
869 ++vi) {
Richard Smith2815e1a2012-05-25 02:17:09 +0000870 // If we have self-init, downgrade all uses to 'may be uninitialized'.
871 UninitUse Use = hasSelfInit ? UninitUse(vi->getUser(), false) : *vi;
872
873 if (DiagnoseUninitializedUse(S, vd, Use))
Ted Kremenek9e761722011-10-13 18:50:06 +0000874 // Skip further diagnostics for this variable. We try to warn only
875 // on the first point at which a variable is used uninitialized.
876 break;
877 }
Chandler Carruth64fb9592011-04-05 18:18:08 +0000878 }
Ted Kremenek9e761722011-10-13 18:50:06 +0000879
880 // Release the uses vector.
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000881 delete vec;
882 }
883 delete uses;
Ted Kremenek610068c2011-01-15 02:58:47 +0000884 }
Matt Beaumont-Gay0d381812011-10-19 18:53:03 +0000885
886private:
887 static bool hasAlwaysUninitializedUse(const UsesVec* vec) {
888 for (UsesVec::const_iterator i = vec->begin(), e = vec->end(); i != e; ++i) {
Richard Smith2815e1a2012-05-25 02:17:09 +0000889 if (i->getKind() == UninitUse::Always) {
Matt Beaumont-Gay0d381812011-10-19 18:53:03 +0000890 return true;
891 }
892 }
893 return false;
894}
Ted Kremenek610068c2011-01-15 02:58:47 +0000895};
896}
897
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000898
899//===----------------------------------------------------------------------===//
900// -Wthread-safety
901//===----------------------------------------------------------------------===//
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000902namespace clang {
903namespace thread_safety {
Richard Smith2e515622012-02-03 04:45:26 +0000904typedef llvm::SmallVector<PartialDiagnosticAt, 1> OptionalNotes;
905typedef std::pair<PartialDiagnosticAt, OptionalNotes> DelayedDiag;
Benjamin Kramerecafd302012-03-26 14:05:40 +0000906typedef std::list<DelayedDiag> DiagList;
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000907
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000908struct SortDiagBySourceLocation {
Benjamin Kramerecafd302012-03-26 14:05:40 +0000909 SourceManager &SM;
910 SortDiagBySourceLocation(SourceManager &SM) : SM(SM) {}
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000911
912 bool operator()(const DelayedDiag &left, const DelayedDiag &right) {
913 // Although this call will be slow, this is only called when outputting
914 // multiple warnings.
Benjamin Kramerecafd302012-03-26 14:05:40 +0000915 return SM.isBeforeInTranslationUnit(left.first.first, right.first.first);
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000916 }
917};
918
David Blaikie99ba9e32011-12-20 02:48:34 +0000919namespace {
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000920class ThreadSafetyReporter : public clang::thread_safety::ThreadSafetyHandler {
921 Sema &S;
922 DiagList Warnings;
Richard Smith2e515622012-02-03 04:45:26 +0000923 SourceLocation FunLocation, FunEndLocation;
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000924
925 // Helper functions
926 void warnLockMismatch(unsigned DiagID, Name LockName, SourceLocation Loc) {
DeLesley Hutchinsf1ac6372011-10-21 18:10:14 +0000927 // Gracefully handle rare cases when the analysis can't get a more
928 // precise source location.
929 if (!Loc.isValid())
930 Loc = FunLocation;
Richard Smith2e515622012-02-03 04:45:26 +0000931 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID) << LockName);
932 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000933 }
934
935 public:
Richard Smith2e515622012-02-03 04:45:26 +0000936 ThreadSafetyReporter(Sema &S, SourceLocation FL, SourceLocation FEL)
937 : S(S), FunLocation(FL), FunEndLocation(FEL) {}
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000938
939 /// \brief Emit all buffered diagnostics in order of sourcelocation.
940 /// We need to output diagnostics produced while iterating through
941 /// the lockset in deterministic order, so this function orders diagnostics
942 /// and outputs them.
943 void emitDiagnostics() {
Benjamin Kramerecafd302012-03-26 14:05:40 +0000944 Warnings.sort(SortDiagBySourceLocation(S.getSourceManager()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000945 for (DiagList::iterator I = Warnings.begin(), E = Warnings.end();
Richard Smith2e515622012-02-03 04:45:26 +0000946 I != E; ++I) {
947 S.Diag(I->first.first, I->first.second);
948 const OptionalNotes &Notes = I->second;
949 for (unsigned NoteI = 0, NoteN = Notes.size(); NoteI != NoteN; ++NoteI)
950 S.Diag(Notes[NoteI].first, Notes[NoteI].second);
951 }
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000952 }
953
Caitlin Sadowski99107eb2011-09-09 16:21:55 +0000954 void handleInvalidLockExp(SourceLocation Loc) {
Richard Smith2e515622012-02-03 04:45:26 +0000955 PartialDiagnosticAt Warning(Loc,
956 S.PDiag(diag::warn_cannot_resolve_lock) << Loc);
957 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski99107eb2011-09-09 16:21:55 +0000958 }
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000959 void handleUnmatchedUnlock(Name LockName, SourceLocation Loc) {
960 warnLockMismatch(diag::warn_unlock_but_no_lock, LockName, Loc);
961 }
962
963 void handleDoubleLock(Name LockName, SourceLocation Loc) {
964 warnLockMismatch(diag::warn_double_lock, LockName, Loc);
965 }
966
Richard Smith2e515622012-02-03 04:45:26 +0000967 void handleMutexHeldEndOfScope(Name LockName, SourceLocation LocLocked,
968 SourceLocation LocEndOfScope,
Caitlin Sadowski4e4bc752011-09-15 17:25:19 +0000969 LockErrorKind LEK){
970 unsigned DiagID = 0;
971 switch (LEK) {
972 case LEK_LockedSomePredecessors:
Richard Smith2e515622012-02-03 04:45:26 +0000973 DiagID = diag::warn_lock_some_predecessors;
Caitlin Sadowski4e4bc752011-09-15 17:25:19 +0000974 break;
975 case LEK_LockedSomeLoopIterations:
976 DiagID = diag::warn_expecting_lock_held_on_loop;
977 break;
978 case LEK_LockedAtEndOfFunction:
979 DiagID = diag::warn_no_unlock;
980 break;
981 }
Richard Smith2e515622012-02-03 04:45:26 +0000982 if (LocEndOfScope.isInvalid())
983 LocEndOfScope = FunEndLocation;
984
985 PartialDiagnosticAt Warning(LocEndOfScope, S.PDiag(DiagID) << LockName);
986 PartialDiagnosticAt Note(LocLocked, S.PDiag(diag::note_locked_here));
987 Warnings.push_back(DelayedDiag(Warning, OptionalNotes(1, Note)));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000988 }
989
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000990
991 void handleExclusiveAndShared(Name LockName, SourceLocation Loc1,
992 SourceLocation Loc2) {
Richard Smith2e515622012-02-03 04:45:26 +0000993 PartialDiagnosticAt Warning(
994 Loc1, S.PDiag(diag::warn_lock_exclusive_and_shared) << LockName);
995 PartialDiagnosticAt Note(
996 Loc2, S.PDiag(diag::note_lock_exclusive_and_shared) << LockName);
997 Warnings.push_back(DelayedDiag(Warning, OptionalNotes(1, Note)));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +0000998 }
999
1000 void handleNoMutexHeld(const NamedDecl *D, ProtectedOperationKind POK,
1001 AccessKind AK, SourceLocation Loc) {
Caitlin Sadowskidf8327c2011-09-14 20:09:09 +00001002 assert((POK == POK_VarAccess || POK == POK_VarDereference)
1003 && "Only works for variables");
1004 unsigned DiagID = POK == POK_VarAccess?
1005 diag::warn_variable_requires_any_lock:
1006 diag::warn_var_deref_requires_any_lock;
Richard Smith2e515622012-02-03 04:45:26 +00001007 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID)
1008 << D->getName() << getLockKindFromAccessKind(AK));
1009 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001010 }
1011
1012 void handleMutexNotHeld(const NamedDecl *D, ProtectedOperationKind POK,
1013 Name LockName, LockKind LK, SourceLocation Loc) {
Caitlin Sadowskie87158d2011-09-13 18:01:58 +00001014 unsigned DiagID = 0;
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001015 switch (POK) {
1016 case POK_VarAccess:
1017 DiagID = diag::warn_variable_requires_lock;
1018 break;
1019 case POK_VarDereference:
1020 DiagID = diag::warn_var_deref_requires_lock;
1021 break;
1022 case POK_FunctionCall:
1023 DiagID = diag::warn_fun_requires_lock;
1024 break;
1025 }
Richard Smith2e515622012-02-03 04:45:26 +00001026 PartialDiagnosticAt Warning(Loc, S.PDiag(DiagID)
1027 << D->getName() << LockName << LK);
1028 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001029 }
1030
1031 void handleFunExcludesLock(Name FunName, Name LockName, SourceLocation Loc) {
Richard Smith2e515622012-02-03 04:45:26 +00001032 PartialDiagnosticAt Warning(Loc,
1033 S.PDiag(diag::warn_fun_excludes_mutex) << FunName << LockName);
1034 Warnings.push_back(DelayedDiag(Warning, OptionalNotes()));
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001035 }
1036};
1037}
1038}
David Blaikie99ba9e32011-12-20 02:48:34 +00001039}
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001040
Ted Kremenek610068c2011-01-15 02:58:47 +00001041//===----------------------------------------------------------------------===//
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001042// AnalysisBasedWarnings - Worker object used by Sema to execute analysis-based
1043// warnings on a function, method, or block.
1044//===----------------------------------------------------------------------===//
1045
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001046clang::sema::AnalysisBasedWarnings::Policy::Policy() {
1047 enableCheckFallThrough = 1;
1048 enableCheckUnreachable = 0;
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001049 enableThreadSafetyAnalysis = 0;
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001050}
1051
Chandler Carruth5d989942011-07-06 16:21:37 +00001052clang::sema::AnalysisBasedWarnings::AnalysisBasedWarnings(Sema &s)
1053 : S(s),
1054 NumFunctionsAnalyzed(0),
Benjamin Kramer54cf3412011-07-08 20:38:53 +00001055 NumFunctionsWithBadCFGs(0),
Chandler Carruth5d989942011-07-06 16:21:37 +00001056 NumCFGBlocks(0),
Benjamin Kramer54cf3412011-07-08 20:38:53 +00001057 MaxCFGBlocksPerFunction(0),
1058 NumUninitAnalysisFunctions(0),
1059 NumUninitAnalysisVariables(0),
1060 MaxUninitAnalysisVariablesPerFunction(0),
1061 NumUninitAnalysisBlockVisits(0),
1062 MaxUninitAnalysisBlockVisitsPerFunction(0) {
David Blaikied6471f72011-09-25 23:23:43 +00001063 DiagnosticsEngine &D = S.getDiagnostics();
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001064 DefaultPolicy.enableCheckUnreachable = (unsigned)
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00001065 (D.getDiagnosticLevel(diag::warn_unreachable, SourceLocation()) !=
David Blaikied6471f72011-09-25 23:23:43 +00001066 DiagnosticsEngine::Ignored);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001067 DefaultPolicy.enableThreadSafetyAnalysis = (unsigned)
1068 (D.getDiagnosticLevel(diag::warn_double_lock, SourceLocation()) !=
David Blaikied6471f72011-09-25 23:23:43 +00001069 DiagnosticsEngine::Ignored);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001070
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001071}
1072
Ted Kremenek351ba912011-02-23 01:52:04 +00001073static void flushDiagnostics(Sema &S, sema::FunctionScopeInfo *fscope) {
Chris Lattner5f9e2722011-07-23 10:55:15 +00001074 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek351ba912011-02-23 01:52:04 +00001075 i = fscope->PossiblyUnreachableDiags.begin(),
1076 e = fscope->PossiblyUnreachableDiags.end();
1077 i != e; ++i) {
1078 const sema::PossiblyUnreachableDiag &D = *i;
1079 S.Diag(D.Loc, D.PD);
1080 }
1081}
1082
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001083void clang::sema::
1084AnalysisBasedWarnings::IssueWarnings(sema::AnalysisBasedWarnings::Policy P,
Ted Kremenek283a3582011-02-23 01:51:53 +00001085 sema::FunctionScopeInfo *fscope,
Ted Kremenek3ed6fc02011-02-23 01:51:48 +00001086 const Decl *D, const BlockExpr *blkExpr) {
Ted Kremenekd068aab2010-03-20 21:11:09 +00001087
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001088 // We avoid doing analysis-based warnings when there are errors for
1089 // two reasons:
1090 // (1) The CFGs often can't be constructed (if the body is invalid), so
1091 // don't bother trying.
1092 // (2) The code already has problems; running the analysis just takes more
1093 // time.
David Blaikied6471f72011-09-25 23:23:43 +00001094 DiagnosticsEngine &Diags = S.getDiagnostics();
Ted Kremenek99e81922010-04-30 21:49:25 +00001095
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001096 // Do not do any analysis for declarations in system headers if we are
1097 // going to just ignore them.
Ted Kremenek99e81922010-04-30 21:49:25 +00001098 if (Diags.getSuppressSystemWarnings() &&
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001099 S.SourceMgr.isInSystemHeader(D->getLocation()))
1100 return;
1101
John McCalle0054f62010-08-25 05:56:39 +00001102 // For code in dependent contexts, we'll do this at instantiation time.
David Blaikie23661d32012-01-24 04:51:48 +00001103 if (cast<DeclContext>(D)->isDependentContext())
1104 return;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001105
Ted Kremenek351ba912011-02-23 01:52:04 +00001106 if (Diags.hasErrorOccurred() || Diags.hasFatalErrorOccurred()) {
1107 // Flush out any possibly unreachable diagnostics.
1108 flushDiagnostics(S, fscope);
1109 return;
1110 }
1111
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001112 const Stmt *Body = D->getBody();
1113 assert(Body);
1114
Jordy Rosed2001872012-04-28 01:58:08 +00001115 AnalysisDeclContext AC(/* AnalysisDeclContextManager */ 0, D);
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001116
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001117 // Don't generate EH edges for CallExprs as we'd like to avoid the n^2
1118 // explosion for destrutors that can result and the compile time hit.
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001119 AC.getCFGBuildOptions().PruneTriviallyFalseEdges = true;
1120 AC.getCFGBuildOptions().AddEHEdges = false;
1121 AC.getCFGBuildOptions().AddInitializers = true;
1122 AC.getCFGBuildOptions().AddImplicitDtors = true;
Ted Kremenek0c8e5a02011-07-19 14:18:48 +00001123
1124 // Force that certain expressions appear as CFGElements in the CFG. This
1125 // is used to speed up various analyses.
1126 // FIXME: This isn't the right factoring. This is here for initial
1127 // prototyping, but we need a way for analyses to say what expressions they
1128 // expect to always be CFGElements and then fill in the BuildOptions
1129 // appropriately. This is essentially a layering violation.
DeLesley Hutchins1fa3c062011-12-08 20:23:06 +00001130 if (P.enableCheckUnreachable || P.enableThreadSafetyAnalysis) {
1131 // Unreachable code analysis and thread safety require a linearized CFG.
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +00001132 AC.getCFGBuildOptions().setAllAlwaysAdd();
1133 }
1134 else {
1135 AC.getCFGBuildOptions()
1136 .setAlwaysAdd(Stmt::BinaryOperatorClass)
1137 .setAlwaysAdd(Stmt::BlockExprClass)
1138 .setAlwaysAdd(Stmt::CStyleCastExprClass)
1139 .setAlwaysAdd(Stmt::DeclRefExprClass)
1140 .setAlwaysAdd(Stmt::ImplicitCastExprClass)
Richard Smithe0d3b4c2012-05-03 18:27:39 +00001141 .setAlwaysAdd(Stmt::UnaryOperatorClass)
1142 .setAlwaysAdd(Stmt::AttributedStmtClass);
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +00001143 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001144
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001145 // Construct the analysis context with the specified CFG build options.
1146
Ted Kremenek351ba912011-02-23 01:52:04 +00001147 // Emit delayed diagnostics.
David Blaikie23661d32012-01-24 04:51:48 +00001148 if (!fscope->PossiblyUnreachableDiags.empty()) {
Ted Kremenek351ba912011-02-23 01:52:04 +00001149 bool analyzed = false;
Ted Kremenek0d28d362011-03-10 03:50:34 +00001150
1151 // Register the expressions with the CFGBuilder.
Chris Lattner5f9e2722011-07-23 10:55:15 +00001152 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek0d28d362011-03-10 03:50:34 +00001153 i = fscope->PossiblyUnreachableDiags.begin(),
1154 e = fscope->PossiblyUnreachableDiags.end();
1155 i != e; ++i) {
1156 if (const Stmt *stmt = i->stmt)
1157 AC.registerForcedBlockExpression(stmt);
1158 }
1159
1160 if (AC.getCFG()) {
1161 analyzed = true;
Chris Lattner5f9e2722011-07-23 10:55:15 +00001162 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek0d28d362011-03-10 03:50:34 +00001163 i = fscope->PossiblyUnreachableDiags.begin(),
1164 e = fscope->PossiblyUnreachableDiags.end();
1165 i != e; ++i)
1166 {
1167 const sema::PossiblyUnreachableDiag &D = *i;
1168 bool processed = false;
1169 if (const Stmt *stmt = i->stmt) {
1170 const CFGBlock *block = AC.getBlockForRegisteredExpression(stmt);
Eli Friedman71b8fb52012-01-21 01:01:51 +00001171 CFGReverseBlockReachabilityAnalysis *cra =
1172 AC.getCFGReachablityAnalysis();
1173 // FIXME: We should be able to assert that block is non-null, but
1174 // the CFG analysis can skip potentially-evaluated expressions in
1175 // edge cases; see test/Sema/vla-2.c.
1176 if (block && cra) {
Ted Kremenek351ba912011-02-23 01:52:04 +00001177 // Can this block be reached from the entrance?
Ted Kremenek0d28d362011-03-10 03:50:34 +00001178 if (cra->isReachable(&AC.getCFG()->getEntry(), block))
Ted Kremenek351ba912011-02-23 01:52:04 +00001179 S.Diag(D.Loc, D.PD);
Ted Kremenek0d28d362011-03-10 03:50:34 +00001180 processed = true;
Ted Kremenek351ba912011-02-23 01:52:04 +00001181 }
1182 }
Ted Kremenek0d28d362011-03-10 03:50:34 +00001183 if (!processed) {
1184 // Emit the warning anyway if we cannot map to a basic block.
1185 S.Diag(D.Loc, D.PD);
1186 }
Ted Kremenek351ba912011-02-23 01:52:04 +00001187 }
Ted Kremenek0d28d362011-03-10 03:50:34 +00001188 }
Ted Kremenek351ba912011-02-23 01:52:04 +00001189
1190 if (!analyzed)
1191 flushDiagnostics(S, fscope);
1192 }
1193
1194
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001195 // Warning: check missing 'return'
David Blaikie23661d32012-01-24 04:51:48 +00001196 if (P.enableCheckFallThrough) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001197 const CheckFallThroughDiagnostics &CD =
1198 (isa<BlockDecl>(D) ? CheckFallThroughDiagnostics::MakeForBlock()
Douglas Gregor793cd1c2012-02-15 16:20:15 +00001199 : (isa<CXXMethodDecl>(D) &&
1200 cast<CXXMethodDecl>(D)->getOverloadedOperator() == OO_Call &&
1201 cast<CXXMethodDecl>(D)->getParent()->isLambda())
1202 ? CheckFallThroughDiagnostics::MakeForLambda()
1203 : CheckFallThroughDiagnostics::MakeForFunction(D));
Ted Kremenek3ed6fc02011-02-23 01:51:48 +00001204 CheckFallThroughForBody(S, D, Body, blkExpr, CD, AC);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001205 }
1206
1207 // Warning: check for unreachable code
Ted Kremenek5dfee062011-11-30 21:22:09 +00001208 if (P.enableCheckUnreachable) {
1209 // Only check for unreachable code on non-template instantiations.
1210 // Different template instantiations can effectively change the control-flow
1211 // and it is very difficult to prove that a snippet of code in a template
1212 // is unreachable for all instantiations.
Ted Kremenek75df4ee2011-12-01 00:59:17 +00001213 bool isTemplateInstantiation = false;
1214 if (const FunctionDecl *Function = dyn_cast<FunctionDecl>(D))
1215 isTemplateInstantiation = Function->isTemplateInstantiation();
1216 if (!isTemplateInstantiation)
Ted Kremenek5dfee062011-11-30 21:22:09 +00001217 CheckUnreachable(S, AC);
1218 }
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001219
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001220 // Check for thread safety violations
David Blaikie23661d32012-01-24 04:51:48 +00001221 if (P.enableThreadSafetyAnalysis) {
DeLesley Hutchinsf1ac6372011-10-21 18:10:14 +00001222 SourceLocation FL = AC.getDecl()->getLocation();
Richard Smith2e515622012-02-03 04:45:26 +00001223 SourceLocation FEL = AC.getDecl()->getLocEnd();
1224 thread_safety::ThreadSafetyReporter Reporter(S, FL, FEL);
Caitlin Sadowski75f23ae2011-09-09 16:04:02 +00001225 thread_safety::runThreadSafetyAnalysis(AC, Reporter);
1226 Reporter.emitDiagnostics();
1227 }
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001228
Ted Kremeneka8c17a52011-01-25 19:13:48 +00001229 if (Diags.getDiagnosticLevel(diag::warn_uninit_var, D->getLocStart())
David Blaikied6471f72011-09-25 23:23:43 +00001230 != DiagnosticsEngine::Ignored ||
Richard Smith2815e1a2012-05-25 02:17:09 +00001231 Diags.getDiagnosticLevel(diag::warn_sometimes_uninit_var,D->getLocStart())
1232 != DiagnosticsEngine::Ignored ||
Ted Kremenek76709bf2011-03-15 05:22:28 +00001233 Diags.getDiagnosticLevel(diag::warn_maybe_uninit_var, D->getLocStart())
David Blaikied6471f72011-09-25 23:23:43 +00001234 != DiagnosticsEngine::Ignored) {
Ted Kremenekc5e43c12011-03-17 05:29:57 +00001235 if (CFG *cfg = AC.getCFG()) {
Ted Kremenekc21fed32011-01-18 21:18:58 +00001236 UninitValsDiagReporter reporter(S);
Fariborz Jahanian57080fb2011-07-16 18:31:33 +00001237 UninitVariablesAnalysisStats stats;
Benjamin Kramer12efd572011-07-16 20:13:06 +00001238 std::memset(&stats, 0, sizeof(UninitVariablesAnalysisStats));
Ted Kremeneka8c17a52011-01-25 19:13:48 +00001239 runUninitializedVariablesAnalysis(*cast<DeclContext>(D), *cfg, AC,
Chandler Carruth5d989942011-07-06 16:21:37 +00001240 reporter, stats);
1241
1242 if (S.CollectStats && stats.NumVariablesAnalyzed > 0) {
1243 ++NumUninitAnalysisFunctions;
1244 NumUninitAnalysisVariables += stats.NumVariablesAnalyzed;
1245 NumUninitAnalysisBlockVisits += stats.NumBlockVisits;
1246 MaxUninitAnalysisVariablesPerFunction =
1247 std::max(MaxUninitAnalysisVariablesPerFunction,
1248 stats.NumVariablesAnalyzed);
1249 MaxUninitAnalysisBlockVisitsPerFunction =
1250 std::max(MaxUninitAnalysisBlockVisitsPerFunction,
1251 stats.NumBlockVisits);
1252 }
Ted Kremenek610068c2011-01-15 02:58:47 +00001253 }
1254 }
Chandler Carruth5d989942011-07-06 16:21:37 +00001255
Richard Smithe0d3b4c2012-05-03 18:27:39 +00001256 if (Diags.getDiagnosticLevel(diag::warn_unannotated_fallthrough,
1257 D->getLocStart()) != DiagnosticsEngine::Ignored) {
1258 DiagnoseSwitchLabelsFallthrough(S, AC);
1259 }
1260
Chandler Carruth5d989942011-07-06 16:21:37 +00001261 // Collect statistics about the CFG if it was built.
1262 if (S.CollectStats && AC.isCFGBuilt()) {
1263 ++NumFunctionsAnalyzed;
1264 if (CFG *cfg = AC.getCFG()) {
1265 // If we successfully built a CFG for this context, record some more
1266 // detail information about it.
Chandler Carruth3ea4c492011-07-06 22:21:45 +00001267 NumCFGBlocks += cfg->getNumBlockIDs();
Chandler Carruth5d989942011-07-06 16:21:37 +00001268 MaxCFGBlocksPerFunction = std::max(MaxCFGBlocksPerFunction,
Chandler Carruth3ea4c492011-07-06 22:21:45 +00001269 cfg->getNumBlockIDs());
Chandler Carruth5d989942011-07-06 16:21:37 +00001270 } else {
1271 ++NumFunctionsWithBadCFGs;
1272 }
1273 }
1274}
1275
1276void clang::sema::AnalysisBasedWarnings::PrintStats() const {
1277 llvm::errs() << "\n*** Analysis Based Warnings Stats:\n";
1278
1279 unsigned NumCFGsBuilt = NumFunctionsAnalyzed - NumFunctionsWithBadCFGs;
1280 unsigned AvgCFGBlocksPerFunction =
1281 !NumCFGsBuilt ? 0 : NumCFGBlocks/NumCFGsBuilt;
1282 llvm::errs() << NumFunctionsAnalyzed << " functions analyzed ("
1283 << NumFunctionsWithBadCFGs << " w/o CFGs).\n"
1284 << " " << NumCFGBlocks << " CFG blocks built.\n"
1285 << " " << AvgCFGBlocksPerFunction
1286 << " average CFG blocks per function.\n"
1287 << " " << MaxCFGBlocksPerFunction
1288 << " max CFG blocks per function.\n";
1289
1290 unsigned AvgUninitVariablesPerFunction = !NumUninitAnalysisFunctions ? 0
1291 : NumUninitAnalysisVariables/NumUninitAnalysisFunctions;
1292 unsigned AvgUninitBlockVisitsPerFunction = !NumUninitAnalysisFunctions ? 0
1293 : NumUninitAnalysisBlockVisits/NumUninitAnalysisFunctions;
1294 llvm::errs() << NumUninitAnalysisFunctions
1295 << " functions analyzed for uninitialiazed variables\n"
1296 << " " << NumUninitAnalysisVariables << " variables analyzed.\n"
1297 << " " << AvgUninitVariablesPerFunction
1298 << " average variables per function.\n"
1299 << " " << MaxUninitAnalysisVariablesPerFunction
1300 << " max variables per function.\n"
1301 << " " << NumUninitAnalysisBlockVisits << " block visits.\n"
1302 << " " << AvgUninitBlockVisitsPerFunction
1303 << " average block visits per function.\n"
1304 << " " << MaxUninitAnalysisBlockVisitsPerFunction
1305 << " max block visits per function.\n";
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001306}