blob: 6c074188b34700ce43a8fdc9b6f9bacb3c7b6b71 [file] [log] [blame]
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001//=- AnalysisBasedWarnings.cpp - Sema warnings based on libAnalysis -*- C++ -*-=//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines analysis_warnings::[Policy,Executor].
11// Together they are used by Sema to issue warnings based on inexpensive
12// static analysis algorithms in libAnalysis.
13//
14//===----------------------------------------------------------------------===//
15
Douglas Gregore737f502010-08-12 20:07:10 +000016#include "clang/Sema/AnalysisBasedWarnings.h"
John McCall2d887082010-08-25 22:03:47 +000017#include "clang/Sema/SemaInternal.h"
Ted Kremenek351ba912011-02-23 01:52:04 +000018#include "clang/Sema/ScopeInfo.h"
Ted Kremenekd068aab2010-03-20 21:11:09 +000019#include "clang/Basic/SourceManager.h"
Ted Kremenekfbb178a2011-01-21 19:41:46 +000020#include "clang/Lex/Preprocessor.h"
John McCall7cd088e2010-08-24 07:21:54 +000021#include "clang/AST/DeclObjC.h"
John McCall384aff82010-08-25 07:42:41 +000022#include "clang/AST/DeclCXX.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000023#include "clang/AST/ExprObjC.h"
24#include "clang/AST/ExprCXX.h"
25#include "clang/AST/StmtObjC.h"
26#include "clang/AST/StmtCXX.h"
Ted Kremenek6f417152011-04-04 20:56:00 +000027#include "clang/AST/EvaluatedExprVisitor.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000028#include "clang/AST/StmtVisitor.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000029#include "clang/Analysis/AnalysisContext.h"
30#include "clang/Analysis/CFG.h"
31#include "clang/Analysis/Analyses/ReachableCode.h"
Ted Kremenek351ba912011-02-23 01:52:04 +000032#include "clang/Analysis/Analyses/CFGReachabilityAnalysis.h"
33#include "clang/Analysis/CFGStmtMap.h"
Ted Kremenek6f342132011-03-15 03:17:07 +000034#include "clang/Analysis/Analyses/UninitializedValues.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000035#include "llvm/ADT/BitVector.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000036#include "llvm/ADT/FoldingSet.h"
37#include "llvm/ADT/ImmutableMap.h"
38#include "llvm/ADT/PostOrderIterator.h"
39#include "llvm/ADT/SmallVector.h"
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000040#include "llvm/Support/Casting.h"
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +000041#include <algorithm>
42#include <vector>
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000043
44using namespace clang;
45
46//===----------------------------------------------------------------------===//
47// Unreachable code analysis.
48//===----------------------------------------------------------------------===//
49
50namespace {
51 class UnreachableCodeHandler : public reachable_code::Callback {
52 Sema &S;
53 public:
54 UnreachableCodeHandler(Sema &s) : S(s) {}
55
56 void HandleUnreachable(SourceLocation L, SourceRange R1, SourceRange R2) {
57 S.Diag(L, diag::warn_unreachable) << R1 << R2;
58 }
59 };
60}
61
62/// CheckUnreachable - Check for unreachable code.
63static void CheckUnreachable(Sema &S, AnalysisContext &AC) {
64 UnreachableCodeHandler UC(S);
65 reachable_code::FindUnreachableCode(AC, UC);
66}
67
68//===----------------------------------------------------------------------===//
69// Check for missing return value.
70//===----------------------------------------------------------------------===//
71
John McCall16565aa2010-05-16 09:34:11 +000072enum ControlFlowKind {
73 UnknownFallThrough,
74 NeverFallThrough,
75 MaybeFallThrough,
76 AlwaysFallThrough,
77 NeverFallThroughOrReturn
78};
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000079
80/// CheckFallThrough - Check that we don't fall off the end of a
81/// Statement that should return a value.
82///
83/// \returns AlwaysFallThrough iff we always fall off the end of the statement,
84/// MaybeFallThrough iff we might or might not fall off the end,
85/// NeverFallThroughOrReturn iff we never fall off the end of the statement or
86/// return. We assume NeverFallThrough iff we never fall off the end of the
87/// statement but we may return. We assume that functions not marked noreturn
88/// will return.
89static ControlFlowKind CheckFallThrough(AnalysisContext &AC) {
90 CFG *cfg = AC.getCFG();
John McCall16565aa2010-05-16 09:34:11 +000091 if (cfg == 0) return UnknownFallThrough;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000092
93 // The CFG leaves in dead things, and we don't want the dead code paths to
94 // confuse us, so we mark all live things first.
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000095 llvm::BitVector live(cfg->getNumBlockIDs());
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +000096 unsigned count = reachable_code::ScanReachableFromBlock(&cfg->getEntry(),
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +000097 live);
98
99 bool AddEHEdges = AC.getAddEHEdges();
100 if (!AddEHEdges && count != cfg->getNumBlockIDs())
101 // When there are things remaining dead, and we didn't add EH edges
102 // from CallExprs to the catch clauses, we have to go back and
103 // mark them as live.
104 for (CFG::iterator I = cfg->begin(), E = cfg->end(); I != E; ++I) {
105 CFGBlock &b = **I;
106 if (!live[b.getBlockID()]) {
107 if (b.pred_begin() == b.pred_end()) {
108 if (b.getTerminator() && isa<CXXTryStmt>(b.getTerminator()))
109 // When not adding EH edges from calls, catch clauses
110 // can otherwise seem dead. Avoid noting them as dead.
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +0000111 count += reachable_code::ScanReachableFromBlock(&b, live);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000112 continue;
113 }
114 }
115 }
116
117 // Now we know what is live, we check the live precessors of the exit block
118 // and look for fall through paths, being careful to ignore normal returns,
119 // and exceptional paths.
120 bool HasLiveReturn = false;
121 bool HasFakeEdge = false;
122 bool HasPlainEdge = false;
123 bool HasAbnormalEdge = false;
Ted Kremenek90b828a2010-09-09 00:06:07 +0000124
125 // Ignore default cases that aren't likely to be reachable because all
126 // enums in a switch(X) have explicit case statements.
127 CFGBlock::FilterOptions FO;
128 FO.IgnoreDefaultsWithCoveredEnums = 1;
129
130 for (CFGBlock::filtered_pred_iterator
131 I = cfg->getExit().filtered_pred_start_end(FO); I.hasMore(); ++I) {
132 const CFGBlock& B = **I;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000133 if (!live[B.getBlockID()])
134 continue;
Ted Kremenek5811f592011-01-26 04:49:52 +0000135
136 // Destructors can appear after the 'return' in the CFG. This is
137 // normal. We need to look pass the destructors for the return
138 // statement (if it exists).
139 CFGBlock::const_reverse_iterator ri = B.rbegin(), re = B.rend();
Ted Kremenekc9f8f5a2011-03-02 20:32:29 +0000140 bool hasNoReturnDtor = false;
141
Ted Kremenek5811f592011-01-26 04:49:52 +0000142 for ( ; ri != re ; ++ri) {
143 CFGElement CE = *ri;
Ted Kremenekc9f8f5a2011-03-02 20:32:29 +0000144
145 // FIXME: The right solution is to just sever the edges in the
146 // CFG itself.
147 if (const CFGImplicitDtor *iDtor = ri->getAs<CFGImplicitDtor>())
Ted Kremenekc5aff442011-03-03 01:21:32 +0000148 if (iDtor->isNoReturn(AC.getASTContext())) {
Ted Kremenekc9f8f5a2011-03-02 20:32:29 +0000149 hasNoReturnDtor = true;
150 HasFakeEdge = true;
151 break;
152 }
153
Ted Kremenek5811f592011-01-26 04:49:52 +0000154 if (isa<CFGStmt>(CE))
155 break;
156 }
157
Ted Kremenekc9f8f5a2011-03-02 20:32:29 +0000158 if (hasNoReturnDtor)
159 continue;
160
Ted Kremenek5811f592011-01-26 04:49:52 +0000161 // No more CFGElements in the block?
162 if (ri == re) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000163 if (B.getTerminator() && isa<CXXTryStmt>(B.getTerminator())) {
164 HasAbnormalEdge = true;
165 continue;
166 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000167 // A labeled empty statement, or the entry block...
168 HasPlainEdge = true;
169 continue;
170 }
Ted Kremenekf39e6a32011-01-25 22:50:47 +0000171
Ted Kremenek5811f592011-01-26 04:49:52 +0000172 CFGStmt CS = cast<CFGStmt>(*ri);
Ted Kremenekf1d10d92011-08-23 23:05:04 +0000173 const Stmt *S = CS.getStmt();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000174 if (isa<ReturnStmt>(S)) {
175 HasLiveReturn = true;
176 continue;
177 }
178 if (isa<ObjCAtThrowStmt>(S)) {
179 HasFakeEdge = true;
180 continue;
181 }
182 if (isa<CXXThrowExpr>(S)) {
183 HasFakeEdge = true;
184 continue;
185 }
186 if (const AsmStmt *AS = dyn_cast<AsmStmt>(S)) {
187 if (AS->isMSAsm()) {
188 HasFakeEdge = true;
189 HasLiveReturn = true;
190 continue;
191 }
192 }
193 if (isa<CXXTryStmt>(S)) {
194 HasAbnormalEdge = true;
195 continue;
196 }
197
198 bool NoReturnEdge = false;
Ted Kremenekf1d10d92011-08-23 23:05:04 +0000199 if (const CallExpr *C = dyn_cast<CallExpr>(S)) {
John McCall259d48e2010-04-30 07:10:06 +0000200 if (std::find(B.succ_begin(), B.succ_end(), &cfg->getExit())
201 == B.succ_end()) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000202 HasAbnormalEdge = true;
203 continue;
204 }
Ted Kremenekf1d10d92011-08-23 23:05:04 +0000205 const Expr *CEE = C->getCallee()->IgnoreParenCasts();
John McCall1de85332011-05-11 07:19:11 +0000206 QualType calleeType = CEE->getType();
207 if (calleeType == AC.getASTContext().BoundMemberTy) {
208 calleeType = Expr::findBoundMemberType(CEE);
209 assert(!calleeType.isNull() && "analyzing unresolved call?");
210 }
211 if (getFunctionExtInfo(calleeType).getNoReturn()) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000212 NoReturnEdge = true;
213 HasFakeEdge = true;
Ted Kremenekf1d10d92011-08-23 23:05:04 +0000214 } else if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(CEE)) {
215 const ValueDecl *VD = DRE->getDecl();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000216 if (VD->hasAttr<NoReturnAttr>()) {
217 NoReturnEdge = true;
218 HasFakeEdge = true;
219 }
220 }
221 }
222 // FIXME: Add noreturn message sends.
223 if (NoReturnEdge == false)
224 HasPlainEdge = true;
225 }
226 if (!HasPlainEdge) {
227 if (HasLiveReturn)
228 return NeverFallThrough;
229 return NeverFallThroughOrReturn;
230 }
231 if (HasAbnormalEdge || HasFakeEdge || HasLiveReturn)
232 return MaybeFallThrough;
233 // This says AlwaysFallThrough for calls to functions that are not marked
234 // noreturn, that don't return. If people would like this warning to be more
235 // accurate, such functions should be marked as noreturn.
236 return AlwaysFallThrough;
237}
238
Dan Gohman3c46e8d2010-07-26 21:25:24 +0000239namespace {
240
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000241struct CheckFallThroughDiagnostics {
242 unsigned diag_MaybeFallThrough_HasNoReturn;
243 unsigned diag_MaybeFallThrough_ReturnsNonVoid;
244 unsigned diag_AlwaysFallThrough_HasNoReturn;
245 unsigned diag_AlwaysFallThrough_ReturnsNonVoid;
246 unsigned diag_NeverFallThroughOrReturn;
247 bool funMode;
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000248 SourceLocation FuncLoc;
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000249
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000250 static CheckFallThroughDiagnostics MakeForFunction(const Decl *Func) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000251 CheckFallThroughDiagnostics D;
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000252 D.FuncLoc = Func->getLocation();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000253 D.diag_MaybeFallThrough_HasNoReturn =
254 diag::warn_falloff_noreturn_function;
255 D.diag_MaybeFallThrough_ReturnsNonVoid =
256 diag::warn_maybe_falloff_nonvoid_function;
257 D.diag_AlwaysFallThrough_HasNoReturn =
258 diag::warn_falloff_noreturn_function;
259 D.diag_AlwaysFallThrough_ReturnsNonVoid =
260 diag::warn_falloff_nonvoid_function;
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000261
262 // Don't suggest that virtual functions be marked "noreturn", since they
263 // might be overridden by non-noreturn functions.
264 bool isVirtualMethod = false;
265 if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(Func))
266 isVirtualMethod = Method->isVirtual();
267
268 if (!isVirtualMethod)
269 D.diag_NeverFallThroughOrReturn =
270 diag::warn_suggest_noreturn_function;
271 else
272 D.diag_NeverFallThroughOrReturn = 0;
273
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000274 D.funMode = true;
275 return D;
276 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000277
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000278 static CheckFallThroughDiagnostics MakeForBlock() {
279 CheckFallThroughDiagnostics D;
280 D.diag_MaybeFallThrough_HasNoReturn =
281 diag::err_noreturn_block_has_return_expr;
282 D.diag_MaybeFallThrough_ReturnsNonVoid =
283 diag::err_maybe_falloff_nonvoid_block;
284 D.diag_AlwaysFallThrough_HasNoReturn =
285 diag::err_noreturn_block_has_return_expr;
286 D.diag_AlwaysFallThrough_ReturnsNonVoid =
287 diag::err_falloff_nonvoid_block;
288 D.diag_NeverFallThroughOrReturn =
289 diag::warn_suggest_noreturn_block;
290 D.funMode = false;
291 return D;
292 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000293
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000294 bool checkDiagnostics(Diagnostic &D, bool ReturnsVoid,
295 bool HasNoReturn) const {
296 if (funMode) {
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000297 return (ReturnsVoid ||
298 D.getDiagnosticLevel(diag::warn_maybe_falloff_nonvoid_function,
299 FuncLoc) == Diagnostic::Ignored)
300 && (!HasNoReturn ||
301 D.getDiagnosticLevel(diag::warn_noreturn_function_has_return_expr,
302 FuncLoc) == Diagnostic::Ignored)
303 && (!ReturnsVoid ||
304 D.getDiagnosticLevel(diag::warn_suggest_noreturn_block, FuncLoc)
305 == Diagnostic::Ignored);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000306 }
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000307
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000308 // For blocks.
309 return ReturnsVoid && !HasNoReturn
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +0000310 && (!ReturnsVoid ||
311 D.getDiagnosticLevel(diag::warn_suggest_noreturn_block, FuncLoc)
312 == Diagnostic::Ignored);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000313 }
314};
315
Dan Gohman3c46e8d2010-07-26 21:25:24 +0000316}
317
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000318/// CheckFallThroughForFunctionDef - Check that we don't fall off the end of a
319/// function that should return a value. Check that we don't fall off the end
320/// of a noreturn function. We assume that functions and blocks not marked
321/// noreturn will return.
322static void CheckFallThroughForBody(Sema &S, const Decl *D, const Stmt *Body,
Ted Kremenek3ed6fc02011-02-23 01:51:48 +0000323 const BlockExpr *blkExpr,
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000324 const CheckFallThroughDiagnostics& CD,
325 AnalysisContext &AC) {
326
327 bool ReturnsVoid = false;
328 bool HasNoReturn = false;
329
330 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
331 ReturnsVoid = FD->getResultType()->isVoidType();
332 HasNoReturn = FD->hasAttr<NoReturnAttr>() ||
Rafael Espindola264ba482010-03-30 20:24:48 +0000333 FD->getType()->getAs<FunctionType>()->getNoReturnAttr();
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000334 }
335 else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
336 ReturnsVoid = MD->getResultType()->isVoidType();
337 HasNoReturn = MD->hasAttr<NoReturnAttr>();
338 }
339 else if (isa<BlockDecl>(D)) {
Ted Kremenek3ed6fc02011-02-23 01:51:48 +0000340 QualType BlockTy = blkExpr->getType();
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000341 if (const FunctionType *FT =
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000342 BlockTy->getPointeeType()->getAs<FunctionType>()) {
343 if (FT->getResultType()->isVoidType())
344 ReturnsVoid = true;
345 if (FT->getNoReturnAttr())
346 HasNoReturn = true;
347 }
348 }
349
350 Diagnostic &Diags = S.getDiagnostics();
351
352 // Short circuit for compilation speed.
353 if (CD.checkDiagnostics(Diags, ReturnsVoid, HasNoReturn))
354 return;
Ted Kremenekd064fdc2010-03-23 00:13:23 +0000355
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000356 // FIXME: Function try block
357 if (const CompoundStmt *Compound = dyn_cast<CompoundStmt>(Body)) {
358 switch (CheckFallThrough(AC)) {
John McCall16565aa2010-05-16 09:34:11 +0000359 case UnknownFallThrough:
360 break;
361
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000362 case MaybeFallThrough:
363 if (HasNoReturn)
364 S.Diag(Compound->getRBracLoc(),
365 CD.diag_MaybeFallThrough_HasNoReturn);
366 else if (!ReturnsVoid)
367 S.Diag(Compound->getRBracLoc(),
368 CD.diag_MaybeFallThrough_ReturnsNonVoid);
369 break;
370 case AlwaysFallThrough:
371 if (HasNoReturn)
372 S.Diag(Compound->getRBracLoc(),
373 CD.diag_AlwaysFallThrough_HasNoReturn);
374 else if (!ReturnsVoid)
375 S.Diag(Compound->getRBracLoc(),
376 CD.diag_AlwaysFallThrough_ReturnsNonVoid);
377 break;
378 case NeverFallThroughOrReturn:
Douglas Gregorca7eaee2010-04-16 23:28:44 +0000379 if (ReturnsVoid && !HasNoReturn && CD.diag_NeverFallThroughOrReturn)
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +0000380 S.Diag(Compound->getLBracLoc(),
381 CD.diag_NeverFallThroughOrReturn);
382 break;
383 case NeverFallThrough:
384 break;
385 }
386 }
387}
388
389//===----------------------------------------------------------------------===//
Ted Kremenek610068c2011-01-15 02:58:47 +0000390// -Wuninitialized
391//===----------------------------------------------------------------------===//
392
Ted Kremenek6f417152011-04-04 20:56:00 +0000393namespace {
Chandler Carruth9f649462011-04-05 06:48:00 +0000394/// ContainsReference - A visitor class to search for references to
395/// a particular declaration (the needle) within any evaluated component of an
396/// expression (recursively).
Ted Kremenek6f417152011-04-04 20:56:00 +0000397class ContainsReference : public EvaluatedExprVisitor<ContainsReference> {
Chandler Carruth9f649462011-04-05 06:48:00 +0000398 bool FoundReference;
399 const DeclRefExpr *Needle;
400
Ted Kremenek6f417152011-04-04 20:56:00 +0000401public:
Chandler Carruth9f649462011-04-05 06:48:00 +0000402 ContainsReference(ASTContext &Context, const DeclRefExpr *Needle)
403 : EvaluatedExprVisitor<ContainsReference>(Context),
404 FoundReference(false), Needle(Needle) {}
405
406 void VisitExpr(Expr *E) {
Ted Kremenek6f417152011-04-04 20:56:00 +0000407 // Stop evaluating if we already have a reference.
Chandler Carruth9f649462011-04-05 06:48:00 +0000408 if (FoundReference)
Ted Kremenek6f417152011-04-04 20:56:00 +0000409 return;
Chandler Carruth9f649462011-04-05 06:48:00 +0000410
411 EvaluatedExprVisitor<ContainsReference>::VisitExpr(E);
Ted Kremenek6f417152011-04-04 20:56:00 +0000412 }
Chandler Carruth9f649462011-04-05 06:48:00 +0000413
414 void VisitDeclRefExpr(DeclRefExpr *E) {
415 if (E == Needle)
416 FoundReference = true;
417 else
418 EvaluatedExprVisitor<ContainsReference>::VisitDeclRefExpr(E);
Ted Kremenek6f417152011-04-04 20:56:00 +0000419 }
Chandler Carruth9f649462011-04-05 06:48:00 +0000420
421 bool doesContainReference() const { return FoundReference; }
Ted Kremenek6f417152011-04-04 20:56:00 +0000422};
423}
424
Chandler Carruth262d50e2011-04-05 18:27:05 +0000425/// DiagnoseUninitializedUse -- Helper function for diagnosing uses of an
426/// uninitialized variable. This manages the different forms of diagnostic
427/// emitted for particular types of uses. Returns true if the use was diagnosed
428/// as a warning. If a pariticular use is one we omit warnings for, returns
429/// false.
430static bool DiagnoseUninitializedUse(Sema &S, const VarDecl *VD,
Chandler Carruth64fb9592011-04-05 18:18:08 +0000431 const Expr *E, bool isAlwaysUninit) {
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000432 bool isSelfInit = false;
433
434 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) {
435 if (isAlwaysUninit) {
436 // Inspect the initializer of the variable declaration which is
437 // being referenced prior to its initialization. We emit
438 // specialized diagnostics for self-initialization, and we
439 // specifically avoid warning about self references which take the
440 // form of:
441 //
442 // int x = x;
443 //
444 // This is used to indicate to GCC that 'x' is intentionally left
445 // uninitialized. Proven code paths which access 'x' in
446 // an uninitialized state after this will still warn.
447 //
448 // TODO: Should we suppress maybe-uninitialized warnings for
449 // variables initialized in this way?
450 if (const Expr *Initializer = VD->getInit()) {
451 if (DRE == Initializer->IgnoreParenImpCasts())
Chandler Carruth262d50e2011-04-05 18:27:05 +0000452 return false;
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000453
454 ContainsReference CR(S.Context, DRE);
455 CR.Visit(const_cast<Expr*>(Initializer));
456 isSelfInit = CR.doesContainReference();
457 }
458 if (isSelfInit) {
459 S.Diag(DRE->getLocStart(),
460 diag::warn_uninit_self_reference_in_init)
461 << VD->getDeclName() << VD->getLocation() << DRE->getSourceRange();
462 } else {
463 S.Diag(DRE->getLocStart(), diag::warn_uninit_var)
464 << VD->getDeclName() << DRE->getSourceRange();
465 }
466 } else {
467 S.Diag(DRE->getLocStart(), diag::warn_maybe_uninit_var)
468 << VD->getDeclName() << DRE->getSourceRange();
469 }
470 } else {
471 const BlockExpr *BE = cast<BlockExpr>(E);
472 S.Diag(BE->getLocStart(),
473 isAlwaysUninit ? diag::warn_uninit_var_captured_by_block
474 : diag::warn_maybe_uninit_var_captured_by_block)
475 << VD->getDeclName();
476 }
477
478 // Report where the variable was declared when the use wasn't within
479 // the initializer of that declaration.
480 if (!isSelfInit)
481 S.Diag(VD->getLocStart(), diag::note_uninit_var_def)
482 << VD->getDeclName();
483
Chandler Carruth262d50e2011-04-05 18:27:05 +0000484 return true;
Chandler Carruth64fb9592011-04-05 18:18:08 +0000485}
486
Chandler Carruth262d50e2011-04-05 18:27:05 +0000487static void SuggestInitializationFixit(Sema &S, const VarDecl *VD) {
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000488 // Don't issue a fixit if there is already an initializer.
489 if (VD->getInit())
490 return;
491
492 // Suggest possible initialization (if any).
493 const char *initialization = 0;
494 QualType VariableTy = VD->getType().getCanonicalType();
495
Douglas Gregor8ba44262011-07-02 00:59:18 +0000496 if (VariableTy->isObjCObjectPointerType() ||
497 VariableTy->isBlockPointerType()) {
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000498 // Check if 'nil' is defined.
499 if (S.PP.getMacroInfo(&S.getASTContext().Idents.get("nil")))
500 initialization = " = nil";
501 else
502 initialization = " = 0";
503 }
504 else if (VariableTy->isRealFloatingType())
505 initialization = " = 0.0";
506 else if (VariableTy->isBooleanType() && S.Context.getLangOptions().CPlusPlus)
507 initialization = " = false";
508 else if (VariableTy->isEnumeralType())
509 return;
Douglas Gregor8ba44262011-07-02 00:59:18 +0000510 else if (VariableTy->isPointerType() || VariableTy->isMemberPointerType()) {
Douglas Gregorcc68c9b2011-08-27 00:18:50 +0000511 if (S.Context.getLangOptions().CPlusPlus0x)
512 initialization = " = nullptr";
Douglas Gregor8ba44262011-07-02 00:59:18 +0000513 // Check if 'NULL' is defined.
Douglas Gregorcc68c9b2011-08-27 00:18:50 +0000514 else if (S.PP.getMacroInfo(&S.getASTContext().Idents.get("NULL")))
Douglas Gregor8ba44262011-07-02 00:59:18 +0000515 initialization = " = NULL";
516 else
517 initialization = " = 0";
518 }
Chandler Carruth4c4983b2011-04-05 18:18:05 +0000519 else if (VariableTy->isScalarType())
520 initialization = " = 0";
521
522 if (initialization) {
523 SourceLocation loc = S.PP.getLocForEndOfToken(VD->getLocEnd());
524 S.Diag(loc, diag::note_var_fixit_add_initialization)
525 << FixItHint::CreateInsertion(loc, initialization);
526 }
527}
528
Ted Kremenekf7bafc72011-03-15 04:57:38 +0000529typedef std::pair<const Expr*, bool> UninitUse;
530
Ted Kremenek610068c2011-01-15 02:58:47 +0000531namespace {
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000532struct SLocSort {
Ted Kremenekf7bafc72011-03-15 04:57:38 +0000533 bool operator()(const UninitUse &a, const UninitUse &b) {
534 SourceLocation aLoc = a.first->getLocStart();
535 SourceLocation bLoc = b.first->getLocStart();
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000536 return aLoc.getRawEncoding() < bLoc.getRawEncoding();
537 }
538};
539
Ted Kremenek610068c2011-01-15 02:58:47 +0000540class UninitValsDiagReporter : public UninitVariablesHandler {
541 Sema &S;
Chris Lattner5f9e2722011-07-23 10:55:15 +0000542 typedef SmallVector<UninitUse, 2> UsesVec;
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000543 typedef llvm::DenseMap<const VarDecl *, UsesVec*> UsesMap;
544 UsesMap *uses;
545
Ted Kremenek610068c2011-01-15 02:58:47 +0000546public:
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000547 UninitValsDiagReporter(Sema &S) : S(S), uses(0) {}
548 ~UninitValsDiagReporter() {
549 flushDiagnostics();
550 }
Ted Kremenek610068c2011-01-15 02:58:47 +0000551
Ted Kremenekf7bafc72011-03-15 04:57:38 +0000552 void handleUseOfUninitVariable(const Expr *ex, const VarDecl *vd,
553 bool isAlwaysUninit) {
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000554 if (!uses)
555 uses = new UsesMap();
556
557 UsesVec *&vec = (*uses)[vd];
558 if (!vec)
559 vec = new UsesVec();
560
Ted Kremenekf7bafc72011-03-15 04:57:38 +0000561 vec->push_back(std::make_pair(ex, isAlwaysUninit));
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000562 }
563
564 void flushDiagnostics() {
565 if (!uses)
566 return;
Ted Kremenek609e3172011-02-02 23:35:53 +0000567
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000568 for (UsesMap::iterator i = uses->begin(), e = uses->end(); i != e; ++i) {
569 const VarDecl *vd = i->first;
570 UsesVec *vec = i->second;
Ted Kremenek609e3172011-02-02 23:35:53 +0000571
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000572 // Sort the uses by their SourceLocations. While not strictly
573 // guaranteed to produce them in line/column order, this will provide
574 // a stable ordering.
575 std::sort(vec->begin(), vec->end(), SLocSort());
576
Chandler Carruth64fb9592011-04-05 18:18:08 +0000577 for (UsesVec::iterator vi = vec->begin(), ve = vec->end(); vi != ve;
578 ++vi) {
Chandler Carruth262d50e2011-04-05 18:27:05 +0000579 if (!DiagnoseUninitializedUse(S, vd, vi->first,
580 /*isAlwaysUninit=*/vi->second))
581 continue;
582
Chandler Carruthd837c0d2011-07-22 05:27:52 +0000583 SuggestInitializationFixit(S, vd);
584
585 // Skip further diagnostics for this variable. We try to warn only on
586 // the first point at which a variable is used uninitialized.
587 break;
Chandler Carruth64fb9592011-04-05 18:18:08 +0000588 }
Ted Kremenekd40066b2011-04-04 23:29:12 +0000589
Ted Kremenek94b1b4d2011-01-21 19:41:41 +0000590 delete vec;
591 }
592 delete uses;
Ted Kremenek610068c2011-01-15 02:58:47 +0000593 }
594};
595}
596
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000597
598//===----------------------------------------------------------------------===//
599// -Wthread-safety
600//===----------------------------------------------------------------------===//
601
602namespace {
603/// \brief Implements a set of CFGBlocks using a BitVector.
604///
605/// This class contains a minimal interface, primarily dictated by the SetType
606/// template parameter of the llvm::po_iterator template, as used with external
607/// storage. We also use this set to keep track of which CFGBlocks we visit
608/// during the analysis.
609class CFGBlockSet {
610 llvm::BitVector VisitedBlockIDs;
611
612public:
613 // po_iterator requires this iterator, but the only interface needed is the
614 // value_type typedef.
615 struct iterator {
616 typedef const CFGBlock *value_type;
617 };
618
619 CFGBlockSet() {}
620 CFGBlockSet(const CFG *G) : VisitedBlockIDs(G->getNumBlockIDs(), false) {}
621
622 /// \brief Set the bit associated with a particular CFGBlock.
623 /// This is the important method for the SetType template parameter.
624 bool insert(const CFGBlock *Block) {
625 if (VisitedBlockIDs.test(Block->getBlockID()))
626 return false;
627 VisitedBlockIDs.set(Block->getBlockID());
628 return true;
629 }
630
631 /// \brief Check if the bit for a CFGBlock has been already set.
632 /// This mehtod is for tracking visited blocks in the main threadsafety loop.
633 bool alreadySet(const CFGBlock *Block) {
634 return VisitedBlockIDs.test(Block->getBlockID());
635 }
636};
637
638/// \brief We create a helper class which we use to iterate through CFGBlocks in
639/// the topological order.
640class TopologicallySortedCFG {
641 typedef llvm::po_iterator<const CFG*, CFGBlockSet, true> po_iterator;
642
643 std::vector<const CFGBlock*> Blocks;
644
645public:
646 typedef std::vector<const CFGBlock*>::reverse_iterator iterator;
647
648 TopologicallySortedCFG(const CFG *CFGraph) {
649 Blocks.reserve(CFGraph->getNumBlockIDs());
650 CFGBlockSet BSet(CFGraph);
651
652 for (po_iterator I = po_iterator::begin(CFGraph, BSet),
653 E = po_iterator::end(CFGraph, BSet); I != E; ++I) {
654 Blocks.push_back(*I);
655 }
656 }
657
658 iterator begin() {
659 return Blocks.rbegin();
660 }
661
662 iterator end() {
663 return Blocks.rend();
664 }
665};
666
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000667/// \brief A LockID object uniquely identifies a particular lock acquired, and
668/// is built from an Expr* (i.e. calling a lock function).
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000669///
670/// Thread-safety analysis works by comparing lock expressions. Within the
671/// body of a function, an expression such as "x->foo->bar.mu" will resolve to
672/// a particular lock object at run-time. Subsequent occurrences of the same
673/// expression (where "same" means syntactic equality) will refer to the same
674/// run-time object if three conditions hold:
675/// (1) Local variables in the expression, such as "x" have not changed.
676/// (2) Values on the heap that affect the expression have not changed.
677/// (3) The expression involves only pure function calls.
678/// The current implementation assumes, but does not verify, that multiple uses
679/// of the same lock expression satisfies these criteria.
680///
681/// Clang introduces an additional wrinkle, which is that it is difficult to
682/// derive canonical expressions, or compare expressions directly for equality.
683/// Thus, we identify a lock not by an Expr, but by the set of named
684/// declarations that are referenced by the Expr. In other words,
685/// x->foo->bar.mu will be a four element vector with the Decls for
686/// mu, bar, and foo, and x. The vector will uniquely identify the expression
687/// for all practical purposes.
688///
689/// Note we will need to perform substitution on "this" and function parameter
690/// names when constructing a lock expression.
691///
692/// For example:
693/// class C { Mutex Mu; void lock() EXCLUSIVE_LOCK_FUNCTION(this->Mu); };
694/// void myFunc(C *X) { ... X->lock() ... }
695/// The original expression for the lock acquired by myFunc is "this->Mu", but
696/// "X" is substituted for "this" so we get X->Mu();
697///
698/// For another example:
699/// foo(MyList *L) EXCLUSIVE_LOCKS_REQUIRED(L->Mu) { ... }
700/// MyList *MyL;
701/// foo(MyL); // requires lock MyL->Mu to be held
702///
703/// FIXME: In C++0x Mutexes are the objects that control access to shared
704/// variables, while Locks are the objects that acquire and release Mutexes. We
705/// may want to switch to this new terminology soon, in which case we should
706/// rename this class "Mutex" and rename "LockId" to "MutexId", as well as
707/// making sure that the terms Lock and Mutex throughout this code are
708/// consistent with C++0x
709///
710/// FIXME: We should also pick one and canonicalize all usage of lock vs acquire
711/// and unlock vs release as verbs.
712class LockID {
713 SmallVector<NamedDecl*, 2> DeclSeq;
714
715 /// Build a Decl sequence representing the lock from the given expression.
716 /// Recursive function that bottoms out when the final DeclRefExpr is reached.
717 void buildLock(Expr *Exp) {
718 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Exp)) {
719 NamedDecl *ND = cast<NamedDecl>(DRE->getDecl()->getCanonicalDecl());
720 DeclSeq.push_back(ND);
721 } else if (MemberExpr *ME = dyn_cast<MemberExpr>(Exp)) {
722 NamedDecl *ND = ME->getMemberDecl();
723 DeclSeq.push_back(ND);
724 buildLock(ME->getBase());
725 } else {
726 // FIXME: add diagnostic
727 llvm::report_fatal_error("Expected lock expression!");
728 }
729 }
730
731public:
732 LockID(Expr *LExpr) {
733 buildLock(LExpr);
734 assert(!DeclSeq.empty());
735 }
736
737 bool operator==(const LockID &other) const {
738 return DeclSeq == other.DeclSeq;
739 }
740
741 bool operator!=(const LockID &other) const {
742 return !(*this == other);
743 }
744
745 // SmallVector overloads Operator< to do lexicographic ordering. Note that
746 // we use pointer equality (and <) to compare NamedDecls. This means the order
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000747 // of LockIDs in a lockset is nondeterministic. In order to output
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000748 // diagnostics in a deterministic ordering, we must order all diagnostics to
749 // output by SourceLocation when iterating through this lockset.
750 bool operator<(const LockID &other) const {
751 return DeclSeq < other.DeclSeq;
752 }
753
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000754 /// \brief Returns the name of the first Decl in the list for a given LockID;
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000755 /// e.g. the lock expression foo.bar() has name "bar".
756 /// The caret will point unambiguously to the lock expression, so using this
757 /// name in diagnostics is a way to get simple, and consistent, lock names.
758 /// We do not want to output the entire expression text for security reasons.
759 StringRef getName() const {
760 return DeclSeq.front()->getName();
761 }
762
763 void Profile(llvm::FoldingSetNodeID &ID) const {
764 for (SmallVectorImpl<NamedDecl*>::const_iterator I = DeclSeq.begin(),
765 E = DeclSeq.end(); I != E; ++I) {
766 ID.AddPointer(*I);
767 }
768 }
769};
770
771/// \brief This is a helper class that stores info about the most recent
772/// accquire of a Lock.
773///
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000774/// The main body of the analysis maps LockIDs to LockDatas.
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000775struct LockData {
776 SourceLocation AcquireLoc;
777
778 LockData(SourceLocation Loc) : AcquireLoc(Loc) {}
779
780 bool operator==(const LockData &other) const {
781 return AcquireLoc == other.AcquireLoc;
782 }
783
784 bool operator!=(const LockData &other) const {
785 return !(*this == other);
786 }
787
788 void Profile(llvm::FoldingSetNodeID &ID) const {
789 ID.AddInteger(AcquireLoc.getRawEncoding());
790 }
791};
792
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000793/// A Lockset maps each LockID (defined above) to information about how it has
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000794/// been locked.
795typedef llvm::ImmutableMap<LockID, LockData> Lockset;
796
797/// \brief We use this class to visit different types of expressions in
798/// CFGBlocks, and build up the lockset.
799/// An expression may cause us to add or remove locks from the lockset, or else
800/// output error messages related to missing locks.
801/// FIXME: In future, we may be able to not inherit from a visitor.
802class BuildLockset : public StmtVisitor<BuildLockset> {
803 Sema &S;
804 Lockset LSet;
805 Lockset::Factory &LocksetFactory;
806
807 // Helper functions
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000808 void removeLock(SourceLocation UnlockLoc, Expr *LockExp);
809 void addLock(SourceLocation LockLoc, Expr *LockExp);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000810
811public:
812 BuildLockset(Sema &S, Lockset LS, Lockset::Factory &F)
813 : StmtVisitor<BuildLockset>(), S(S), LSet(LS),
814 LocksetFactory(F) {}
815
816 Lockset getLockset() {
817 return LSet;
818 }
819
820 void VisitDeclRefExpr(DeclRefExpr *Exp);
821 void VisitCXXMemberCallExpr(CXXMemberCallExpr *Exp);
822};
823
824/// \brief Add a new lock to the lockset, warning if the lock is already there.
825/// \param LockExp The lock expression corresponding to the lock to be added
826/// \param LockLoc The source location of the acquire
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000827void BuildLockset::addLock(SourceLocation LockLoc, Expr *LockExp) {
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000828 LockID Lock(LockExp);
829 LockData NewLockData(LockLoc);
830
831 if (LSet.contains(Lock))
832 S.Diag(LockLoc, diag::warn_double_lock) << Lock.getName();
833
834 LSet = LocksetFactory.add(LSet, Lock, NewLockData);
835}
836
837/// \brief Remove a lock from the lockset, warning if the lock is not there.
838/// \param LockExp The lock expression corresponding to the lock to be removed
839/// \param UnlockLoc The source location of the unlock (only used in error msg)
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000840void BuildLockset::removeLock(SourceLocation UnlockLoc, Expr *LockExp) {
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000841 LockID Lock(LockExp);
842
843 Lockset NewLSet = LocksetFactory.remove(LSet, Lock);
844 if(NewLSet == LSet)
845 S.Diag(UnlockLoc, diag::warn_unlock_but_no_acquire) << Lock.getName();
846
847 LSet = NewLSet;
848}
849
850void BuildLockset::VisitDeclRefExpr(DeclRefExpr *Exp) {
851 // FIXME: checking for guarded_by/var and pt_guarded_by/var
852}
853
854/// \brief When visiting CXXMemberCallExprs we need to examine the attributes on
855/// the method that is being called and add, remove or check locks in the
856/// lockset accordingly.
857void BuildLockset::VisitCXXMemberCallExpr(CXXMemberCallExpr *Exp) {
858 NamedDecl *D = dyn_cast<NamedDecl>(Exp->getCalleeDecl());
859 SourceLocation ExpLocation = Exp->getExprLoc();
860 Expr *Parent = Exp->getImplicitObjectArgument();
861
862 if(!D || !D->hasAttrs())
863 return;
864
865 AttrVec &ArgAttrs = D->getAttrs();
866 for(unsigned i = 0; i < ArgAttrs.size(); ++i) {
867 Attr *Attr = ArgAttrs[i];
868 switch (Attr->getKind()) {
869 // When we encounter an exclusive lock function, we need to add the lock
870 // to our lockset.
871 case attr::ExclusiveLockFunction: {
872 ExclusiveLockFunctionAttr *ELFAttr =
873 cast<ExclusiveLockFunctionAttr>(Attr);
874
875 if (ELFAttr->args_size() == 0) {// The lock held is the "this" object.
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000876 addLock(ExpLocation, Parent);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000877 break;
878 }
879
880 for (ExclusiveLockFunctionAttr::args_iterator I = ELFAttr->args_begin(),
881 E = ELFAttr->args_end(); I != E; ++I)
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000882 addLock(ExpLocation, *I);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000883 // FIXME: acquired_after/acquired_before annotations
884 break;
885 }
886
887 // When we encounter an unlock function, we need to remove unlocked locks
888 // from the lockset, and flag a warning if they are not there.
889 case attr::UnlockFunction: {
890 UnlockFunctionAttr *UFAttr = cast<UnlockFunctionAttr>(Attr);
891
892 if (UFAttr->args_size() == 0) { // The lock held is the "this" object.
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000893 removeLock(ExpLocation, Parent);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000894 break;
895 }
896
897 for (UnlockFunctionAttr::args_iterator I = UFAttr->args_begin(),
898 E = UFAttr->args_end(); I != E; ++I)
Caitlin Sadowski940b97f2011-08-24 18:46:20 +0000899 removeLock(ExpLocation, *I);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +0000900 break;
901 }
902
903 // Ignore other (non thread-safety) attributes
904 default:
905 break;
906 }
907 }
908}
909
910typedef std::pair<SourceLocation, PartialDiagnostic> DelayedDiag;
911typedef llvm::SmallVector<DelayedDiag, 4> DiagList;
912
913struct SortDiagBySourceLocation {
914 Sema &S;
915
916 SortDiagBySourceLocation(Sema &S) : S(S) {}
917
918 bool operator()(const DelayedDiag &left, const DelayedDiag &right) {
919 // Although this call will be slow, this is only called when outputting
920 // multiple warnings.
921 return S.getSourceManager().isBeforeInTranslationUnit(left.first,
922 right.first);
923 }
924};
925} // end anonymous namespace
926
927/// \brief Emit all buffered diagnostics in order of sourcelocation.
928/// We need to output diagnostics produced while iterating through
929/// the lockset in deterministic order, so this function orders diagnostics
930/// and outputs them.
931static void EmitDiagnostics(Sema &S, DiagList &D) {
932 SortDiagBySourceLocation SortDiagBySL(S);
933 sort(D.begin(), D.end(), SortDiagBySL);
934 for (DiagList::iterator I = D.begin(), E = D.end(); I != E; ++I)
935 S.Diag(I->first, I->second);
936}
937
938/// \brief Compute the intersection of two locksets and issue warnings for any
939/// locks in the symmetric difference.
940///
941/// This function is used at a merge point in the CFG when comparing the lockset
942/// of each branch being merged. For example, given the following sequence:
943/// A; if () then B; else C; D; we need to check that the lockset after B and C
944/// are the same. In the event of a difference, we use the intersection of these
945/// two locksets at the start of D.
946static Lockset intersectAndWarn(Sema &S, Lockset LSet1, Lockset LSet2,
947 Lockset::Factory &Fact) {
948 Lockset Intersection = LSet1;
949 DiagList Warnings;
950
951 for (Lockset::iterator I = LSet2.begin(), E = LSet2.end(); I != E; ++I) {
952 if (!LSet1.contains(I.getKey())) {
953 const LockID &MissingLock = I.getKey();
954 const LockData &MissingLockData = I.getData();
955 PartialDiagnostic Warning =
956 S.PDiag(diag::warn_lock_not_released_in_scope) << MissingLock.getName();
957 Warnings.push_back(DelayedDiag(MissingLockData.AcquireLoc, Warning));
958 }
959 }
960
961 for (Lockset::iterator I = LSet1.begin(), E = LSet1.end(); I != E; ++I) {
962 if (!LSet2.contains(I.getKey())) {
963 const LockID &MissingLock = I.getKey();
964 const LockData &MissingLockData = I.getData();
965 PartialDiagnostic Warning =
966 S.PDiag(diag::warn_lock_not_released_in_scope) << MissingLock.getName();
967 Warnings.push_back(DelayedDiag(MissingLockData.AcquireLoc, Warning));
968 Intersection = Fact.remove(Intersection, MissingLock);
969 }
970 }
971
972 EmitDiagnostics(S, Warnings);
973 return Intersection;
974}
975
976/// \brief Returns the location of the first Stmt in a Block.
977static SourceLocation getFirstStmtLocation(CFGBlock *Block) {
978 for (CFGBlock::const_iterator BI = Block->begin(), BE = Block->end();
979 BI != BE; ++BI) {
980 if (const CFGStmt *CfgStmt = dyn_cast<CFGStmt>(&(*BI)))
981 return CfgStmt->getStmt()->getLocStart();
982 }
983 return SourceLocation();
984}
985
986/// \brief Warn about different locksets along backedges of loops.
987/// This function is called when we encounter a back edge. At that point,
988/// we need to verify that the lockset before taking the backedge is the
989/// same as the lockset before entering the loop.
990///
991/// \param LoopEntrySet Locks held before starting the loop
992/// \param LoopReentrySet Locks held in the last CFG block of the loop
993static void warnBackEdgeUnequalLocksets(Sema &S, const Lockset LoopReentrySet,
994 const Lockset LoopEntrySet,
995 SourceLocation FirstLocInLoop) {
996 assert(FirstLocInLoop.isValid());
997 DiagList Warnings;
998
999 // Warn for locks held at the start of the loop, but not the end.
1000 for (Lockset::iterator I = LoopEntrySet.begin(), E = LoopEntrySet.end();
1001 I != E; ++I) {
1002 if (!LoopReentrySet.contains(I.getKey())) {
1003 const LockID &MissingLock = I.getKey();
1004 // We report this error at the location of the first statement in a loop
1005 PartialDiagnostic Warning =
1006 S.PDiag(diag::warn_expecting_lock_held_on_loop)
1007 << MissingLock.getName();
1008 Warnings.push_back(DelayedDiag(FirstLocInLoop, Warning));
1009 }
1010 }
1011
1012 // Warn for locks held at the end of the loop, but not at the start.
1013 for (Lockset::iterator I = LoopReentrySet.begin(), E = LoopReentrySet.end();
1014 I != E; ++I) {
1015 if (!LoopEntrySet.contains(I.getKey())) {
1016 const LockID &MissingLock = I.getKey();
1017 const LockData &MissingLockData = I.getData();
1018 PartialDiagnostic Warning =
1019 S.PDiag(diag::warn_lock_not_released_in_scope) << MissingLock.getName();
1020 Warnings.push_back(DelayedDiag(MissingLockData.AcquireLoc, Warning));
1021 }
1022 }
1023
1024 EmitDiagnostics(S, Warnings);
1025}
1026
1027/// \brief Check a function's CFG for thread-safety violations.
1028///
1029/// We traverse the blocks in the CFG, compute the set of locks that are held
1030/// at the end of each block, and issue warnings for thread safety violations.
1031/// Each block in the CFG is traversed exactly once.
1032static void checkThreadSafety(Sema &S, AnalysisContext &AC) {
1033 CFG *CFGraph = AC.getCFG();
1034 if (!CFGraph) return;
1035
1036 StringRef FunName;
1037 if (const NamedDecl *ContextDecl = dyn_cast<NamedDecl>(AC.getDecl()))
1038 FunName = ContextDecl->getName();
1039
1040 Lockset::Factory LocksetFactory;
1041
1042 // FIXME: Swith to SmallVector? Otherwise improve performance impact?
1043 std::vector<Lockset> EntryLocksets(CFGraph->getNumBlockIDs(),
1044 LocksetFactory.getEmptyMap());
1045 std::vector<Lockset> ExitLocksets(CFGraph->getNumBlockIDs(),
1046 LocksetFactory.getEmptyMap());
1047
1048 // We need to explore the CFG via a "topological" ordering.
1049 // That way, we will be guaranteed to have information about required
1050 // predecessor locksets when exploring a new block.
1051 TopologicallySortedCFG SortedGraph(CFGraph);
1052 CFGBlockSet VisitedBlocks(CFGraph);
1053
1054 for (TopologicallySortedCFG::iterator I = SortedGraph.begin(),
1055 E = SortedGraph.end(); I!= E; ++I) {
1056 const CFGBlock *CurrBlock = *I;
1057 int CurrBlockID = CurrBlock->getBlockID();
1058
1059 VisitedBlocks.insert(CurrBlock);
1060
1061 // Use the default initial lockset in case there are no predecessors.
1062 Lockset &Entryset = EntryLocksets[CurrBlockID];
1063 Lockset &Exitset = ExitLocksets[CurrBlockID];
1064
1065 // Iterate through the predecessor blocks and warn if the lockset for all
1066 // predecessors is not the same. We take the entry lockset of the current
1067 // block to be the intersection of all previous locksets.
1068 // FIXME: By keeping the intersection, we may output more errors in future
1069 // for a lock which is not in the intersection, but was in the union. We
1070 // may want to also keep the union in future. As an example, let's say
1071 // the intersection contains Lock L, and the union contains L and M.
1072 // Later we unlock M. At this point, we would output an error because we
1073 // never locked M; although the real error is probably that we forgot to
1074 // lock M on all code paths. Conversely, let's say that later we lock M.
1075 // In this case, we should compare against the intersection instead of the
1076 // union because the real error is probably that we forgot to unlock M on
1077 // all code paths.
1078 bool LocksetInitialized = false;
1079 for (CFGBlock::const_pred_iterator PI = CurrBlock->pred_begin(),
1080 PE = CurrBlock->pred_end(); PI != PE; ++PI) {
1081
1082 // if *PI -> CurrBlock is a back edge
1083 if (!VisitedBlocks.alreadySet(*PI))
1084 continue;
1085
1086 int PrevBlockID = (*PI)->getBlockID();
1087 if (!LocksetInitialized) {
1088 Entryset = ExitLocksets[PrevBlockID];
1089 LocksetInitialized = true;
1090 } else {
1091 Entryset = intersectAndWarn(S, Entryset, ExitLocksets[PrevBlockID],
1092 LocksetFactory);
1093 }
1094 }
1095
1096 BuildLockset LocksetBuilder(S, Entryset, LocksetFactory);
1097 for (CFGBlock::const_iterator BI = CurrBlock->begin(),
1098 BE = CurrBlock->end(); BI != BE; ++BI) {
1099 if (const CFGStmt *CfgStmt = dyn_cast<CFGStmt>(&*BI)) {
Ted Kremenekf1d10d92011-08-23 23:05:04 +00001100 LocksetBuilder.Visit(const_cast<Stmt*>(CfgStmt->getStmt()));
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001101 }
1102 }
1103 Exitset = LocksetBuilder.getLockset();
1104
1105 // For every back edge from CurrBlock (the end of the loop) to another block
1106 // (FirstLoopBlock) we need to check that the Lockset of Block is equal to
1107 // the one held at the beginning of FirstLoopBlock. We can look up the
1108 // Lockset held at the beginning of FirstLoopBlock in the EntryLockSets map.
1109 for (CFGBlock::const_succ_iterator SI = CurrBlock->succ_begin(),
1110 SE = CurrBlock->succ_end(); SI != SE; ++SI) {
1111
1112 // if CurrBlock -> *SI is *not* a back edge
1113 if (!VisitedBlocks.alreadySet(*SI))
1114 continue;
1115
1116 CFGBlock *FirstLoopBlock = *SI;
1117 SourceLocation FirstLoopLocation = getFirstStmtLocation(FirstLoopBlock);
1118
1119 Lockset PreLoop = EntryLocksets[FirstLoopBlock->getBlockID()];
1120 Lockset LoopEnd = ExitLocksets[CurrBlockID];
1121 warnBackEdgeUnequalLocksets(S, LoopEnd, PreLoop, FirstLoopLocation);
1122 }
1123 }
1124
1125 Lockset FinalLockset = ExitLocksets[CFGraph->getExit().getBlockID()];
1126 if (!FinalLockset.isEmpty()) {
1127 DiagList Warnings;
1128 for (Lockset::iterator I=FinalLockset.begin(), E=FinalLockset.end();
1129 I != E; ++I) {
1130 const LockID &MissingLock = I.getKey();
1131 const LockData &MissingLockData = I.getData();
1132 PartialDiagnostic Warning =
1133 S.PDiag(diag::warn_locks_not_released)
1134 << MissingLock.getName() << FunName;
1135 Warnings.push_back(DelayedDiag(MissingLockData.AcquireLoc, Warning));
1136 }
1137 EmitDiagnostics(S, Warnings);
1138 }
1139}
1140
1141
Ted Kremenek610068c2011-01-15 02:58:47 +00001142//===----------------------------------------------------------------------===//
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001143// AnalysisBasedWarnings - Worker object used by Sema to execute analysis-based
1144// warnings on a function, method, or block.
1145//===----------------------------------------------------------------------===//
1146
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001147clang::sema::AnalysisBasedWarnings::Policy::Policy() {
1148 enableCheckFallThrough = 1;
1149 enableCheckUnreachable = 0;
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001150 enableThreadSafetyAnalysis = 0;
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001151}
1152
Chandler Carruth5d989942011-07-06 16:21:37 +00001153clang::sema::AnalysisBasedWarnings::AnalysisBasedWarnings(Sema &s)
1154 : S(s),
1155 NumFunctionsAnalyzed(0),
Benjamin Kramer54cf3412011-07-08 20:38:53 +00001156 NumFunctionsWithBadCFGs(0),
Chandler Carruth5d989942011-07-06 16:21:37 +00001157 NumCFGBlocks(0),
Benjamin Kramer54cf3412011-07-08 20:38:53 +00001158 MaxCFGBlocksPerFunction(0),
1159 NumUninitAnalysisFunctions(0),
1160 NumUninitAnalysisVariables(0),
1161 MaxUninitAnalysisVariablesPerFunction(0),
1162 NumUninitAnalysisBlockVisits(0),
1163 MaxUninitAnalysisBlockVisitsPerFunction(0) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001164 Diagnostic &D = S.getDiagnostics();
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001165 DefaultPolicy.enableCheckUnreachable = (unsigned)
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00001166 (D.getDiagnosticLevel(diag::warn_unreachable, SourceLocation()) !=
1167 Diagnostic::Ignored);
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001168 DefaultPolicy.enableThreadSafetyAnalysis = (unsigned)
1169 (D.getDiagnosticLevel(diag::warn_double_lock, SourceLocation()) !=
1170 Diagnostic::Ignored);
1171
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001172}
1173
Ted Kremenek351ba912011-02-23 01:52:04 +00001174static void flushDiagnostics(Sema &S, sema::FunctionScopeInfo *fscope) {
Chris Lattner5f9e2722011-07-23 10:55:15 +00001175 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek351ba912011-02-23 01:52:04 +00001176 i = fscope->PossiblyUnreachableDiags.begin(),
1177 e = fscope->PossiblyUnreachableDiags.end();
1178 i != e; ++i) {
1179 const sema::PossiblyUnreachableDiag &D = *i;
1180 S.Diag(D.Loc, D.PD);
1181 }
1182}
1183
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001184void clang::sema::
1185AnalysisBasedWarnings::IssueWarnings(sema::AnalysisBasedWarnings::Policy P,
Ted Kremenek283a3582011-02-23 01:51:53 +00001186 sema::FunctionScopeInfo *fscope,
Ted Kremenek3ed6fc02011-02-23 01:51:48 +00001187 const Decl *D, const BlockExpr *blkExpr) {
Ted Kremenekd068aab2010-03-20 21:11:09 +00001188
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001189 // We avoid doing analysis-based warnings when there are errors for
1190 // two reasons:
1191 // (1) The CFGs often can't be constructed (if the body is invalid), so
1192 // don't bother trying.
1193 // (2) The code already has problems; running the analysis just takes more
1194 // time.
Ted Kremenek99e81922010-04-30 21:49:25 +00001195 Diagnostic &Diags = S.getDiagnostics();
1196
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001197 // Do not do any analysis for declarations in system headers if we are
1198 // going to just ignore them.
Ted Kremenek99e81922010-04-30 21:49:25 +00001199 if (Diags.getSuppressSystemWarnings() &&
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001200 S.SourceMgr.isInSystemHeader(D->getLocation()))
1201 return;
1202
John McCalle0054f62010-08-25 05:56:39 +00001203 // For code in dependent contexts, we'll do this at instantiation time.
1204 if (cast<DeclContext>(D)->isDependentContext())
1205 return;
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001206
Ted Kremenek351ba912011-02-23 01:52:04 +00001207 if (Diags.hasErrorOccurred() || Diags.hasFatalErrorOccurred()) {
1208 // Flush out any possibly unreachable diagnostics.
1209 flushDiagnostics(S, fscope);
1210 return;
1211 }
1212
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001213 const Stmt *Body = D->getBody();
1214 assert(Body);
1215
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001216 AnalysisContext AC(D, 0);
1217
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001218 // Don't generate EH edges for CallExprs as we'd like to avoid the n^2
1219 // explosion for destrutors that can result and the compile time hit.
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001220 AC.getCFGBuildOptions().PruneTriviallyFalseEdges = true;
1221 AC.getCFGBuildOptions().AddEHEdges = false;
1222 AC.getCFGBuildOptions().AddInitializers = true;
1223 AC.getCFGBuildOptions().AddImplicitDtors = true;
Ted Kremenek0c8e5a02011-07-19 14:18:48 +00001224
1225 // Force that certain expressions appear as CFGElements in the CFG. This
1226 // is used to speed up various analyses.
1227 // FIXME: This isn't the right factoring. This is here for initial
1228 // prototyping, but we need a way for analyses to say what expressions they
1229 // expect to always be CFGElements and then fill in the BuildOptions
1230 // appropriately. This is essentially a layering violation.
Ted Kremenek0f3b4ca2011-08-23 23:05:11 +00001231 if (P.enableCheckUnreachable) {
1232 // Unreachable code analysis requires a linearized CFG.
1233 AC.getCFGBuildOptions().setAllAlwaysAdd();
1234 }
1235 else {
1236 AC.getCFGBuildOptions()
1237 .setAlwaysAdd(Stmt::BinaryOperatorClass)
1238 .setAlwaysAdd(Stmt::BlockExprClass)
1239 .setAlwaysAdd(Stmt::CStyleCastExprClass)
1240 .setAlwaysAdd(Stmt::DeclRefExprClass)
1241 .setAlwaysAdd(Stmt::ImplicitCastExprClass)
1242 .setAlwaysAdd(Stmt::UnaryOperatorClass);
1243 }
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001244
Ted Kremenekbc5cb8a2011-07-21 05:22:47 +00001245 // Construct the analysis context with the specified CFG build options.
1246
Ted Kremenek351ba912011-02-23 01:52:04 +00001247 // Emit delayed diagnostics.
1248 if (!fscope->PossiblyUnreachableDiags.empty()) {
1249 bool analyzed = false;
Ted Kremenek0d28d362011-03-10 03:50:34 +00001250
1251 // Register the expressions with the CFGBuilder.
Chris Lattner5f9e2722011-07-23 10:55:15 +00001252 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek0d28d362011-03-10 03:50:34 +00001253 i = fscope->PossiblyUnreachableDiags.begin(),
1254 e = fscope->PossiblyUnreachableDiags.end();
1255 i != e; ++i) {
1256 if (const Stmt *stmt = i->stmt)
1257 AC.registerForcedBlockExpression(stmt);
1258 }
1259
1260 if (AC.getCFG()) {
1261 analyzed = true;
Chris Lattner5f9e2722011-07-23 10:55:15 +00001262 for (SmallVectorImpl<sema::PossiblyUnreachableDiag>::iterator
Ted Kremenek0d28d362011-03-10 03:50:34 +00001263 i = fscope->PossiblyUnreachableDiags.begin(),
1264 e = fscope->PossiblyUnreachableDiags.end();
1265 i != e; ++i)
1266 {
1267 const sema::PossiblyUnreachableDiag &D = *i;
1268 bool processed = false;
1269 if (const Stmt *stmt = i->stmt) {
1270 const CFGBlock *block = AC.getBlockForRegisteredExpression(stmt);
1271 assert(block);
Ted Kremenekaf13d5b2011-03-19 01:00:33 +00001272 if (CFGReverseBlockReachabilityAnalysis *cra = AC.getCFGReachablityAnalysis()) {
Ted Kremenek351ba912011-02-23 01:52:04 +00001273 // Can this block be reached from the entrance?
Ted Kremenek0d28d362011-03-10 03:50:34 +00001274 if (cra->isReachable(&AC.getCFG()->getEntry(), block))
Ted Kremenek351ba912011-02-23 01:52:04 +00001275 S.Diag(D.Loc, D.PD);
Ted Kremenek0d28d362011-03-10 03:50:34 +00001276 processed = true;
Ted Kremenek351ba912011-02-23 01:52:04 +00001277 }
1278 }
Ted Kremenek0d28d362011-03-10 03:50:34 +00001279 if (!processed) {
1280 // Emit the warning anyway if we cannot map to a basic block.
1281 S.Diag(D.Loc, D.PD);
1282 }
Ted Kremenek351ba912011-02-23 01:52:04 +00001283 }
Ted Kremenek0d28d362011-03-10 03:50:34 +00001284 }
Ted Kremenek351ba912011-02-23 01:52:04 +00001285
1286 if (!analyzed)
1287 flushDiagnostics(S, fscope);
1288 }
1289
1290
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001291 // Warning: check missing 'return'
Ted Kremenekd064fdc2010-03-23 00:13:23 +00001292 if (P.enableCheckFallThrough) {
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001293 const CheckFallThroughDiagnostics &CD =
1294 (isa<BlockDecl>(D) ? CheckFallThroughDiagnostics::MakeForBlock()
Douglas Gregorca7eaee2010-04-16 23:28:44 +00001295 : CheckFallThroughDiagnostics::MakeForFunction(D));
Ted Kremenek3ed6fc02011-02-23 01:51:48 +00001296 CheckFallThroughForBody(S, D, Body, blkExpr, CD, AC);
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001297 }
1298
1299 // Warning: check for unreachable code
Ted Kremenekb7e5f142010-04-08 18:51:44 +00001300 if (P.enableCheckUnreachable)
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001301 CheckUnreachable(S, AC);
Ted Kremenek610068c2011-01-15 02:58:47 +00001302
Caitlin Sadowski3ac1fbc2011-08-23 18:46:34 +00001303 // Check for thread safety violations
1304 if (P.enableThreadSafetyAnalysis)
1305 checkThreadSafety(S, AC);
1306
Ted Kremeneka8c17a52011-01-25 19:13:48 +00001307 if (Diags.getDiagnosticLevel(diag::warn_uninit_var, D->getLocStart())
Ted Kremenek76709bf2011-03-15 05:22:28 +00001308 != Diagnostic::Ignored ||
1309 Diags.getDiagnosticLevel(diag::warn_maybe_uninit_var, D->getLocStart())
Ted Kremenek610068c2011-01-15 02:58:47 +00001310 != Diagnostic::Ignored) {
Ted Kremenekc5e43c12011-03-17 05:29:57 +00001311 if (CFG *cfg = AC.getCFG()) {
Ted Kremenekc21fed32011-01-18 21:18:58 +00001312 UninitValsDiagReporter reporter(S);
Fariborz Jahanian57080fb2011-07-16 18:31:33 +00001313 UninitVariablesAnalysisStats stats;
Benjamin Kramer12efd572011-07-16 20:13:06 +00001314 std::memset(&stats, 0, sizeof(UninitVariablesAnalysisStats));
Ted Kremeneka8c17a52011-01-25 19:13:48 +00001315 runUninitializedVariablesAnalysis(*cast<DeclContext>(D), *cfg, AC,
Chandler Carruth5d989942011-07-06 16:21:37 +00001316 reporter, stats);
1317
1318 if (S.CollectStats && stats.NumVariablesAnalyzed > 0) {
1319 ++NumUninitAnalysisFunctions;
1320 NumUninitAnalysisVariables += stats.NumVariablesAnalyzed;
1321 NumUninitAnalysisBlockVisits += stats.NumBlockVisits;
1322 MaxUninitAnalysisVariablesPerFunction =
1323 std::max(MaxUninitAnalysisVariablesPerFunction,
1324 stats.NumVariablesAnalyzed);
1325 MaxUninitAnalysisBlockVisitsPerFunction =
1326 std::max(MaxUninitAnalysisBlockVisitsPerFunction,
1327 stats.NumBlockVisits);
1328 }
Ted Kremenek610068c2011-01-15 02:58:47 +00001329 }
1330 }
Chandler Carruth5d989942011-07-06 16:21:37 +00001331
1332 // Collect statistics about the CFG if it was built.
1333 if (S.CollectStats && AC.isCFGBuilt()) {
1334 ++NumFunctionsAnalyzed;
1335 if (CFG *cfg = AC.getCFG()) {
1336 // If we successfully built a CFG for this context, record some more
1337 // detail information about it.
Chandler Carruth3ea4c492011-07-06 22:21:45 +00001338 NumCFGBlocks += cfg->getNumBlockIDs();
Chandler Carruth5d989942011-07-06 16:21:37 +00001339 MaxCFGBlocksPerFunction = std::max(MaxCFGBlocksPerFunction,
Chandler Carruth3ea4c492011-07-06 22:21:45 +00001340 cfg->getNumBlockIDs());
Chandler Carruth5d989942011-07-06 16:21:37 +00001341 } else {
1342 ++NumFunctionsWithBadCFGs;
1343 }
1344 }
1345}
1346
1347void clang::sema::AnalysisBasedWarnings::PrintStats() const {
1348 llvm::errs() << "\n*** Analysis Based Warnings Stats:\n";
1349
1350 unsigned NumCFGsBuilt = NumFunctionsAnalyzed - NumFunctionsWithBadCFGs;
1351 unsigned AvgCFGBlocksPerFunction =
1352 !NumCFGsBuilt ? 0 : NumCFGBlocks/NumCFGsBuilt;
1353 llvm::errs() << NumFunctionsAnalyzed << " functions analyzed ("
1354 << NumFunctionsWithBadCFGs << " w/o CFGs).\n"
1355 << " " << NumCFGBlocks << " CFG blocks built.\n"
1356 << " " << AvgCFGBlocksPerFunction
1357 << " average CFG blocks per function.\n"
1358 << " " << MaxCFGBlocksPerFunction
1359 << " max CFG blocks per function.\n";
1360
1361 unsigned AvgUninitVariablesPerFunction = !NumUninitAnalysisFunctions ? 0
1362 : NumUninitAnalysisVariables/NumUninitAnalysisFunctions;
1363 unsigned AvgUninitBlockVisitsPerFunction = !NumUninitAnalysisFunctions ? 0
1364 : NumUninitAnalysisBlockVisits/NumUninitAnalysisFunctions;
1365 llvm::errs() << NumUninitAnalysisFunctions
1366 << " functions analyzed for uninitialiazed variables\n"
1367 << " " << NumUninitAnalysisVariables << " variables analyzed.\n"
1368 << " " << AvgUninitVariablesPerFunction
1369 << " average variables per function.\n"
1370 << " " << MaxUninitAnalysisVariablesPerFunction
1371 << " max variables per function.\n"
1372 << " " << NumUninitAnalysisBlockVisits << " block visits.\n"
1373 << " " << AvgUninitBlockVisitsPerFunction
1374 << " average block visits per function.\n"
1375 << " " << MaxUninitAnalysisBlockVisitsPerFunction
1376 << " max block visits per function.\n";
Ted Kremenekdbdbaaf2010-03-20 21:06:02 +00001377}