Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 1 | //== NullDerefChecker.cpp - Null dereference checker ------------*- C++ -*--==// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This defines NullDerefChecker, a builtin check in GRExprEngine that performs |
| 11 | // checks for null pointers at loads and stores. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Benjamin Kramer | 5e2d2c2 | 2010-03-27 21:19:47 +0000 | [diff] [blame] | 15 | #include "GRExprEngineInternalChecks.h" |
Argyrios Kyrtzidis | 98cabba | 2010-12-22 18:51:49 +0000 | [diff] [blame] | 16 | #include "clang/GR/BugReporter/BugType.h" |
| 17 | #include "clang/GR/Checkers/DereferenceChecker.h" |
| 18 | #include "clang/GR/PathSensitive/Checker.h" |
| 19 | #include "clang/GR/PathSensitive/GRExprEngine.h" |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 20 | |
| 21 | using namespace clang; |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame^] | 22 | using namespace GR; |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 23 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 24 | namespace { |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 25 | class DereferenceChecker : public Checker { |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 26 | BuiltinBug *BT_null; |
| 27 | BuiltinBug *BT_undef; |
| 28 | llvm::SmallVector<ExplodedNode*, 2> ImplicitNullDerefNodes; |
| 29 | public: |
| 30 | DereferenceChecker() : BT_null(0), BT_undef(0) {} |
| 31 | static void *getTag() { static int tag = 0; return &tag; } |
Ted Kremenek | 342e907 | 2010-12-20 21:22:47 +0000 | [diff] [blame] | 32 | void visitLocation(CheckerContext &C, const Stmt *S, SVal location); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 33 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 34 | std::pair<ExplodedNode * const*, ExplodedNode * const*> |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 35 | getImplicitNodes() const { |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 36 | return std::make_pair(ImplicitNullDerefNodes.data(), |
| 37 | ImplicitNullDerefNodes.data() + |
| 38 | ImplicitNullDerefNodes.size()); |
| 39 | } |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 40 | void AddDerefSource(llvm::raw_ostream &os, |
| 41 | llvm::SmallVectorImpl<SourceRange> &Ranges, |
| 42 | const Expr *Ex, bool loadedFrom = false); |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 43 | }; |
| 44 | } // end anonymous namespace |
| 45 | |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame^] | 46 | void GR::RegisterDereferenceChecker(GRExprEngine &Eng) { |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 47 | Eng.registerCheck(new DereferenceChecker()); |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 48 | } |
| 49 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 50 | std::pair<ExplodedNode * const *, ExplodedNode * const *> |
Argyrios Kyrtzidis | 5a4f98f | 2010-12-22 18:53:20 +0000 | [diff] [blame^] | 51 | GR::GetImplicitNullDereferences(GRExprEngine &Eng) { |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 52 | DereferenceChecker *checker = Eng.getChecker<DereferenceChecker>(); |
| 53 | if (!checker) |
| 54 | return std::make_pair((ExplodedNode * const *) 0, |
| 55 | (ExplodedNode * const *) 0); |
| 56 | return checker->getImplicitNodes(); |
| 57 | } |
| 58 | |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 59 | void DereferenceChecker::AddDerefSource(llvm::raw_ostream &os, |
| 60 | llvm::SmallVectorImpl<SourceRange> &Ranges, |
| 61 | const Expr *Ex, |
| 62 | bool loadedFrom) { |
John McCall | f6a1648 | 2010-12-04 03:47:34 +0000 | [diff] [blame] | 63 | Ex = Ex->IgnoreParenLValueCasts(); |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 64 | switch (Ex->getStmtClass()) { |
| 65 | default: |
| 66 | return; |
| 67 | case Stmt::DeclRefExprClass: { |
| 68 | const DeclRefExpr *DR = cast<DeclRefExpr>(Ex); |
| 69 | if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { |
| 70 | os << " (" << (loadedFrom ? "loaded from" : "from") |
| 71 | << " variable '" << VD->getName() << "')"; |
| 72 | Ranges.push_back(DR->getSourceRange()); |
| 73 | } |
| 74 | return; |
| 75 | } |
| 76 | case Stmt::MemberExprClass: { |
| 77 | const MemberExpr *ME = cast<MemberExpr>(Ex); |
| 78 | os << " (" << (loadedFrom ? "loaded from" : "via") |
| 79 | << " field '" << ME->getMemberNameInfo() << "')"; |
| 80 | SourceLocation L = ME->getMemberLoc(); |
| 81 | Ranges.push_back(SourceRange(L, L)); |
| 82 | break; |
| 83 | } |
| 84 | } |
| 85 | } |
| 86 | |
Ted Kremenek | 342e907 | 2010-12-20 21:22:47 +0000 | [diff] [blame] | 87 | void DereferenceChecker::visitLocation(CheckerContext &C, const Stmt *S, |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 88 | SVal l) { |
| 89 | // Check for dereference of an undefined value. |
| 90 | if (l.isUndef()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 91 | if (ExplodedNode *N = C.generateSink()) { |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 92 | if (!BT_undef) |
| 93 | BT_undef = new BuiltinBug("Dereference of undefined pointer value"); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 94 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 95 | EnhancedBugReport *report = |
Benjamin Kramer | d02e232 | 2009-11-14 12:08:24 +0000 | [diff] [blame] | 96 | new EnhancedBugReport(*BT_undef, BT_undef->getDescription(), N); |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 97 | report->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue, |
| 98 | bugreporter::GetDerefExpr(N)); |
| 99 | C.EmitReport(report); |
| 100 | } |
| 101 | return; |
| 102 | } |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 103 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 104 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(l); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 105 | |
| 106 | // Check for null dereferences. |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 107 | if (!isa<Loc>(location)) |
| 108 | return; |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 109 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 110 | const GRState *state = C.getState(); |
| 111 | const GRState *notNullState, *nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 112 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 113 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 114 | // The explicit NULL case. |
| 115 | if (nullState) { |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 116 | if (!notNullState) { |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 117 | // Generate an error node. |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 118 | ExplodedNode *N = C.generateSink(nullState); |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 119 | if (!N) |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 120 | return; |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 121 | |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 122 | // We know that 'location' cannot be non-null. This is what |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 123 | // we call an "explicit" null dereference. |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 124 | if (!BT_null) |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 125 | BT_null = new BuiltinBug("Dereference of null pointer"); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 126 | |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 127 | llvm::SmallString<100> buf; |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 128 | llvm::SmallVector<SourceRange, 2> Ranges; |
Ted Kremenek | 892697d | 2010-12-16 07:46:53 +0000 | [diff] [blame] | 129 | |
| 130 | // Walk through lvalue casts to get the original expression |
| 131 | // that syntactically caused the load. |
| 132 | if (const Expr *expr = dyn_cast<Expr>(S)) |
| 133 | S = expr->IgnoreParenLValueCasts(); |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 134 | |
| 135 | switch (S->getStmtClass()) { |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 136 | case Stmt::ArraySubscriptExprClass: { |
| 137 | llvm::raw_svector_ostream os(buf); |
| 138 | os << "Array access"; |
| 139 | const ArraySubscriptExpr *AE = cast<ArraySubscriptExpr>(S); |
| 140 | AddDerefSource(os, Ranges, AE->getBase()->IgnoreParenCasts()); |
| 141 | os << " results in a null pointer dereference"; |
| 142 | break; |
| 143 | } |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 144 | case Stmt::UnaryOperatorClass: { |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 145 | llvm::raw_svector_ostream os(buf); |
| 146 | os << "Dereference of null pointer"; |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 147 | const UnaryOperator *U = cast<UnaryOperator>(S); |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 148 | AddDerefSource(os, Ranges, U->getSubExpr()->IgnoreParens(), true); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 149 | break; |
| 150 | } |
| 151 | case Stmt::MemberExprClass: { |
| 152 | const MemberExpr *M = cast<MemberExpr>(S); |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 153 | if (M->isArrow()) { |
| 154 | llvm::raw_svector_ostream os(buf); |
| 155 | os << "Access to field '" << M->getMemberNameInfo() |
| 156 | << "' results in a dereference of a null pointer"; |
| 157 | AddDerefSource(os, Ranges, M->getBase()->IgnoreParenCasts(), true); |
| 158 | } |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 159 | break; |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 160 | } |
Ted Kremenek | 0853c7f | 2010-09-10 20:20:49 +0000 | [diff] [blame] | 161 | case Stmt::ObjCIvarRefExprClass: { |
| 162 | const ObjCIvarRefExpr *IV = cast<ObjCIvarRefExpr>(S); |
| 163 | if (const DeclRefExpr *DR = |
| 164 | dyn_cast<DeclRefExpr>(IV->getBase()->IgnoreParenCasts())) { |
| 165 | if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { |
| 166 | llvm::raw_svector_ostream os(buf); |
| 167 | os << "Instance variable access (via '" << VD->getName() |
| 168 | << "') results in a null pointer dereference"; |
| 169 | } |
| 170 | } |
| 171 | Ranges.push_back(IV->getSourceRange()); |
| 172 | break; |
| 173 | } |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 174 | default: |
| 175 | break; |
| 176 | } |
Ted Kremenek | 2c791bd | 2009-11-06 00:44:32 +0000 | [diff] [blame] | 177 | |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 178 | EnhancedBugReport *report = |
Ted Kremenek | e576af2 | 2009-11-24 01:33:10 +0000 | [diff] [blame] | 179 | new EnhancedBugReport(*BT_null, |
| 180 | buf.empty() ? BT_null->getDescription():buf.str(), |
| 181 | N); |
| 182 | |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 183 | report->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue, |
| 184 | bugreporter::GetDerefExpr(N)); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 185 | |
| 186 | for (llvm::SmallVectorImpl<SourceRange>::iterator |
| 187 | I = Ranges.begin(), E = Ranges.end(); I!=E; ++I) |
| 188 | report->addRange(*I); |
| 189 | |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 190 | C.EmitReport(report); |
| 191 | return; |
| 192 | } |
| 193 | else { |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 194 | // Otherwise, we have the case where the location could either be |
| 195 | // null or not-null. Record the error node as an "implicit" null |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 196 | // dereference. |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 197 | if (ExplodedNode *N = C.generateSink(nullState)) |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 198 | ImplicitNullDerefNodes.push_back(N); |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 199 | } |
| 200 | } |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 201 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 202 | // From this point forward, we know that the location is not null. |
Ted Kremenek | 19d67b5 | 2009-11-23 22:22:01 +0000 | [diff] [blame] | 203 | C.addTransition(notNullState); |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 204 | } |