blob: 0e6b5ec9a39b1696380eb7ec4488b25f68397ed8 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
John McCall5f8d6042011-08-27 01:09:30 +000015#include "clang/Sema/Initialization.h"
Douglas Gregore737f502010-08-12 20:07:10 +000016#include "clang/Sema/Sema.h"
John McCall2d887082010-08-25 22:03:47 +000017#include "clang/Sema/SemaInternal.h"
Eli Friedman276b0612011-10-11 02:20:01 +000018#include "clang/Sema/Initialization.h"
Richard Smith831421f2012-06-25 20:30:08 +000019#include "clang/Sema/Lookup.h"
John McCall781472f2010-08-25 08:40:02 +000020#include "clang/Sema/ScopeInfo.h"
Ted Kremenek826a3452010-07-16 02:11:22 +000021#include "clang/Analysis/Analyses/FormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000022#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000023#include "clang/AST/CharUnits.h"
John McCall384aff82010-08-25 07:42:41 +000024#include "clang/AST/DeclCXX.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000025#include "clang/AST/DeclObjC.h"
David Blaikiebe0ee872012-05-15 16:56:36 +000026#include "clang/AST/Expr.h"
Ted Kremenek23245122007-08-20 16:18:38 +000027#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000028#include "clang/AST/ExprObjC.h"
John McCallf85e1932011-06-15 23:02:42 +000029#include "clang/AST/EvaluatedExprVisitor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000030#include "clang/AST/DeclObjC.h"
31#include "clang/AST/StmtCXX.h"
32#include "clang/AST/StmtObjC.h"
Chris Lattner59907c42007-08-10 20:18:51 +000033#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000034#include "llvm/ADT/BitVector.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000035#include "llvm/ADT/SmallString.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000036#include "llvm/ADT/STLExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000037#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000038#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000039#include "clang/Basic/TargetInfo.h"
Fariborz Jahanian7da71022010-09-07 19:38:13 +000040#include "clang/Basic/ConvertUTF.h"
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000041#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000042using namespace clang;
John McCall781472f2010-08-25 08:40:02 +000043using namespace sema;
Chris Lattner59907c42007-08-10 20:18:51 +000044
Chris Lattner60800082009-02-18 17:49:48 +000045SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
46 unsigned ByteNo) const {
Chris Lattner08f92e32010-11-17 07:37:15 +000047 return SL->getLocationOfByte(ByteNo, PP.getSourceManager(),
David Blaikie4e4d0842012-03-11 07:00:24 +000048 PP.getLangOpts(), PP.getTargetInfo());
Chris Lattner60800082009-02-18 17:49:48 +000049}
50
John McCall8e10f3b2011-02-26 05:39:39 +000051/// Checks that a call expression's argument count is the desired number.
52/// This is useful when doing custom type-checking. Returns true on error.
53static bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
54 unsigned argCount = call->getNumArgs();
55 if (argCount == desiredArgCount) return false;
56
57 if (argCount < desiredArgCount)
58 return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
59 << 0 /*function call*/ << desiredArgCount << argCount
60 << call->getSourceRange();
61
62 // Highlight all the excess arguments.
63 SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
64 call->getArg(argCount - 1)->getLocEnd());
65
66 return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
67 << 0 /*function call*/ << desiredArgCount << argCount
68 << call->getArg(1)->getSourceRange();
69}
70
Julien Lerougee5939212012-04-28 17:39:16 +000071/// Check that the first argument to __builtin_annotation is an integer
72/// and the second argument is a non-wide string literal.
73static bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) {
74 if (checkArgCount(S, TheCall, 2))
75 return true;
76
77 // First argument should be an integer.
78 Expr *ValArg = TheCall->getArg(0);
79 QualType Ty = ValArg->getType();
80 if (!Ty->isIntegerType()) {
81 S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg)
82 << ValArg->getSourceRange();
Julien Lerouge77f68bb2011-09-09 22:41:49 +000083 return true;
84 }
Julien Lerougee5939212012-04-28 17:39:16 +000085
86 // Second argument should be a constant string.
87 Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts();
88 StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg);
89 if (!Literal || !Literal->isAscii()) {
90 S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg)
91 << StrArg->getSourceRange();
92 return true;
93 }
94
95 TheCall->setType(Ty);
Julien Lerouge77f68bb2011-09-09 22:41:49 +000096 return false;
97}
98
John McCall60d7b3a2010-08-24 06:29:42 +000099ExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +0000100Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
John McCall60d7b3a2010-08-24 06:29:42 +0000101 ExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +0000102
Chris Lattner946928f2010-10-01 23:23:24 +0000103 // Find out if any arguments are required to be integer constant expressions.
104 unsigned ICEArguments = 0;
105 ASTContext::GetBuiltinTypeError Error;
106 Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
107 if (Error != ASTContext::GE_None)
108 ICEArguments = 0; // Don't diagnose previously diagnosed errors.
109
110 // If any arguments are required to be ICE's, check and diagnose.
111 for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
112 // Skip arguments not required to be ICE's.
113 if ((ICEArguments & (1 << ArgNo)) == 0) continue;
114
115 llvm::APSInt Result;
116 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
117 return true;
118 ICEArguments &= ~(1 << ArgNo);
119 }
120
Anders Carlssond406bf02009-08-16 01:56:34 +0000121 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000122 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000123 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000124 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000125 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000126 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000127 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000128 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000129 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000130 if (SemaBuiltinVAStart(TheCall))
131 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000132 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000133 case Builtin::BI__builtin_isgreater:
134 case Builtin::BI__builtin_isgreaterequal:
135 case Builtin::BI__builtin_isless:
136 case Builtin::BI__builtin_islessequal:
137 case Builtin::BI__builtin_islessgreater:
138 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000139 if (SemaBuiltinUnorderedCompare(TheCall))
140 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000141 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000142 case Builtin::BI__builtin_fpclassify:
143 if (SemaBuiltinFPClassification(TheCall, 6))
144 return ExprError();
145 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000146 case Builtin::BI__builtin_isfinite:
147 case Builtin::BI__builtin_isinf:
148 case Builtin::BI__builtin_isinf_sign:
149 case Builtin::BI__builtin_isnan:
150 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000151 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000152 return ExprError();
153 break;
Eli Friedmand38617c2008-05-14 19:38:39 +0000154 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000155 return SemaBuiltinShuffleVector(TheCall);
156 // TheCall will be freed by the smart pointer here, but that's fine, since
157 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000158 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000159 if (SemaBuiltinPrefetch(TheCall))
160 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000161 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000162 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000163 if (SemaBuiltinObjectSize(TheCall))
164 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000165 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000166 case Builtin::BI__builtin_longjmp:
167 if (SemaBuiltinLongjmp(TheCall))
168 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000169 break;
John McCall8e10f3b2011-02-26 05:39:39 +0000170
171 case Builtin::BI__builtin_classify_type:
172 if (checkArgCount(*this, TheCall, 1)) return true;
173 TheCall->setType(Context.IntTy);
174 break;
Chris Lattner75c29a02010-10-12 17:47:42 +0000175 case Builtin::BI__builtin_constant_p:
John McCall8e10f3b2011-02-26 05:39:39 +0000176 if (checkArgCount(*this, TheCall, 1)) return true;
177 TheCall->setType(Context.IntTy);
Chris Lattner75c29a02010-10-12 17:47:42 +0000178 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000179 case Builtin::BI__sync_fetch_and_add:
Douglas Gregora9766412011-11-28 16:30:08 +0000180 case Builtin::BI__sync_fetch_and_add_1:
181 case Builtin::BI__sync_fetch_and_add_2:
182 case Builtin::BI__sync_fetch_and_add_4:
183 case Builtin::BI__sync_fetch_and_add_8:
184 case Builtin::BI__sync_fetch_and_add_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000185 case Builtin::BI__sync_fetch_and_sub:
Douglas Gregora9766412011-11-28 16:30:08 +0000186 case Builtin::BI__sync_fetch_and_sub_1:
187 case Builtin::BI__sync_fetch_and_sub_2:
188 case Builtin::BI__sync_fetch_and_sub_4:
189 case Builtin::BI__sync_fetch_and_sub_8:
190 case Builtin::BI__sync_fetch_and_sub_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000191 case Builtin::BI__sync_fetch_and_or:
Douglas Gregora9766412011-11-28 16:30:08 +0000192 case Builtin::BI__sync_fetch_and_or_1:
193 case Builtin::BI__sync_fetch_and_or_2:
194 case Builtin::BI__sync_fetch_and_or_4:
195 case Builtin::BI__sync_fetch_and_or_8:
196 case Builtin::BI__sync_fetch_and_or_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000197 case Builtin::BI__sync_fetch_and_and:
Douglas Gregora9766412011-11-28 16:30:08 +0000198 case Builtin::BI__sync_fetch_and_and_1:
199 case Builtin::BI__sync_fetch_and_and_2:
200 case Builtin::BI__sync_fetch_and_and_4:
201 case Builtin::BI__sync_fetch_and_and_8:
202 case Builtin::BI__sync_fetch_and_and_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000203 case Builtin::BI__sync_fetch_and_xor:
Douglas Gregora9766412011-11-28 16:30:08 +0000204 case Builtin::BI__sync_fetch_and_xor_1:
205 case Builtin::BI__sync_fetch_and_xor_2:
206 case Builtin::BI__sync_fetch_and_xor_4:
207 case Builtin::BI__sync_fetch_and_xor_8:
208 case Builtin::BI__sync_fetch_and_xor_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000209 case Builtin::BI__sync_add_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000210 case Builtin::BI__sync_add_and_fetch_1:
211 case Builtin::BI__sync_add_and_fetch_2:
212 case Builtin::BI__sync_add_and_fetch_4:
213 case Builtin::BI__sync_add_and_fetch_8:
214 case Builtin::BI__sync_add_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000215 case Builtin::BI__sync_sub_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000216 case Builtin::BI__sync_sub_and_fetch_1:
217 case Builtin::BI__sync_sub_and_fetch_2:
218 case Builtin::BI__sync_sub_and_fetch_4:
219 case Builtin::BI__sync_sub_and_fetch_8:
220 case Builtin::BI__sync_sub_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000221 case Builtin::BI__sync_and_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000222 case Builtin::BI__sync_and_and_fetch_1:
223 case Builtin::BI__sync_and_and_fetch_2:
224 case Builtin::BI__sync_and_and_fetch_4:
225 case Builtin::BI__sync_and_and_fetch_8:
226 case Builtin::BI__sync_and_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000227 case Builtin::BI__sync_or_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000228 case Builtin::BI__sync_or_and_fetch_1:
229 case Builtin::BI__sync_or_and_fetch_2:
230 case Builtin::BI__sync_or_and_fetch_4:
231 case Builtin::BI__sync_or_and_fetch_8:
232 case Builtin::BI__sync_or_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000233 case Builtin::BI__sync_xor_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000234 case Builtin::BI__sync_xor_and_fetch_1:
235 case Builtin::BI__sync_xor_and_fetch_2:
236 case Builtin::BI__sync_xor_and_fetch_4:
237 case Builtin::BI__sync_xor_and_fetch_8:
238 case Builtin::BI__sync_xor_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000239 case Builtin::BI__sync_val_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000240 case Builtin::BI__sync_val_compare_and_swap_1:
241 case Builtin::BI__sync_val_compare_and_swap_2:
242 case Builtin::BI__sync_val_compare_and_swap_4:
243 case Builtin::BI__sync_val_compare_and_swap_8:
244 case Builtin::BI__sync_val_compare_and_swap_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000245 case Builtin::BI__sync_bool_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000246 case Builtin::BI__sync_bool_compare_and_swap_1:
247 case Builtin::BI__sync_bool_compare_and_swap_2:
248 case Builtin::BI__sync_bool_compare_and_swap_4:
249 case Builtin::BI__sync_bool_compare_and_swap_8:
250 case Builtin::BI__sync_bool_compare_and_swap_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000251 case Builtin::BI__sync_lock_test_and_set:
Douglas Gregora9766412011-11-28 16:30:08 +0000252 case Builtin::BI__sync_lock_test_and_set_1:
253 case Builtin::BI__sync_lock_test_and_set_2:
254 case Builtin::BI__sync_lock_test_and_set_4:
255 case Builtin::BI__sync_lock_test_and_set_8:
256 case Builtin::BI__sync_lock_test_and_set_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000257 case Builtin::BI__sync_lock_release:
Douglas Gregora9766412011-11-28 16:30:08 +0000258 case Builtin::BI__sync_lock_release_1:
259 case Builtin::BI__sync_lock_release_2:
260 case Builtin::BI__sync_lock_release_4:
261 case Builtin::BI__sync_lock_release_8:
262 case Builtin::BI__sync_lock_release_16:
Chris Lattner23aa9c82011-04-09 03:57:26 +0000263 case Builtin::BI__sync_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000264 case Builtin::BI__sync_swap_1:
265 case Builtin::BI__sync_swap_2:
266 case Builtin::BI__sync_swap_4:
267 case Builtin::BI__sync_swap_8:
268 case Builtin::BI__sync_swap_16:
Benjamin Kramer3fe198b2012-08-23 21:35:17 +0000269 return SemaBuiltinAtomicOverloaded(TheCallResult);
Richard Smithff34d402012-04-12 05:08:17 +0000270#define BUILTIN(ID, TYPE, ATTRS)
271#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \
272 case Builtin::BI##ID: \
Benjamin Kramer3fe198b2012-08-23 21:35:17 +0000273 return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID);
Richard Smithff34d402012-04-12 05:08:17 +0000274#include "clang/Basic/Builtins.def"
Julien Lerouge77f68bb2011-09-09 22:41:49 +0000275 case Builtin::BI__builtin_annotation:
Julien Lerougee5939212012-04-28 17:39:16 +0000276 if (SemaBuiltinAnnotation(*this, TheCall))
Julien Lerouge77f68bb2011-09-09 22:41:49 +0000277 return ExprError();
278 break;
Nate Begeman26a31422010-06-08 02:47:44 +0000279 }
280
281 // Since the target specific builtins for each arch overlap, only check those
282 // of the arch we are compiling for.
283 if (BuiltinID >= Builtin::FirstTSBuiltin) {
Douglas Gregorbcfd1f52011-09-02 00:18:52 +0000284 switch (Context.getTargetInfo().getTriple().getArch()) {
Nate Begeman26a31422010-06-08 02:47:44 +0000285 case llvm::Triple::arm:
286 case llvm::Triple::thumb:
287 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
288 return ExprError();
289 break;
Simon Atanasyanfad0a322012-07-08 09:30:00 +0000290 case llvm::Triple::mips:
291 case llvm::Triple::mipsel:
292 case llvm::Triple::mips64:
293 case llvm::Triple::mips64el:
294 if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall))
295 return ExprError();
296 break;
Nate Begeman26a31422010-06-08 02:47:44 +0000297 default:
298 break;
299 }
300 }
301
Benjamin Kramer3fe198b2012-08-23 21:35:17 +0000302 return TheCallResult;
Nate Begeman26a31422010-06-08 02:47:44 +0000303}
304
Nate Begeman61eecf52010-06-14 05:21:25 +0000305// Get the valid immediate range for the specified NEON type code.
306static unsigned RFT(unsigned t, bool shift = false) {
Bob Wilsonda95f732011-11-08 01:16:11 +0000307 NeonTypeFlags Type(t);
308 int IsQuad = Type.isQuad();
309 switch (Type.getEltType()) {
310 case NeonTypeFlags::Int8:
311 case NeonTypeFlags::Poly8:
312 return shift ? 7 : (8 << IsQuad) - 1;
313 case NeonTypeFlags::Int16:
314 case NeonTypeFlags::Poly16:
315 return shift ? 15 : (4 << IsQuad) - 1;
316 case NeonTypeFlags::Int32:
317 return shift ? 31 : (2 << IsQuad) - 1;
318 case NeonTypeFlags::Int64:
319 return shift ? 63 : (1 << IsQuad) - 1;
320 case NeonTypeFlags::Float16:
321 assert(!shift && "cannot shift float types!");
322 return (4 << IsQuad) - 1;
323 case NeonTypeFlags::Float32:
324 assert(!shift && "cannot shift float types!");
325 return (2 << IsQuad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000326 }
David Blaikie7530c032012-01-17 06:56:22 +0000327 llvm_unreachable("Invalid NeonTypeFlag!");
Nate Begeman61eecf52010-06-14 05:21:25 +0000328}
329
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000330/// getNeonEltType - Return the QualType corresponding to the elements of
331/// the vector type specified by the NeonTypeFlags. This is used to check
332/// the pointer arguments for Neon load/store intrinsics.
333static QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) {
334 switch (Flags.getEltType()) {
335 case NeonTypeFlags::Int8:
336 return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
337 case NeonTypeFlags::Int16:
338 return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
339 case NeonTypeFlags::Int32:
340 return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
341 case NeonTypeFlags::Int64:
342 return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy;
343 case NeonTypeFlags::Poly8:
344 return Context.SignedCharTy;
345 case NeonTypeFlags::Poly16:
346 return Context.ShortTy;
347 case NeonTypeFlags::Float16:
348 return Context.UnsignedShortTy;
349 case NeonTypeFlags::Float32:
350 return Context.FloatTy;
351 }
David Blaikie7530c032012-01-17 06:56:22 +0000352 llvm_unreachable("Invalid NeonTypeFlag!");
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000353}
354
Nate Begeman26a31422010-06-08 02:47:44 +0000355bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000356 llvm::APSInt Result;
357
Richard Smithf8ee6bc2012-08-14 01:28:02 +0000358 uint64_t mask = 0;
Nate Begeman61eecf52010-06-14 05:21:25 +0000359 unsigned TV = 0;
Bob Wilson46482552011-11-16 21:32:23 +0000360 int PtrArgNum = -1;
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000361 bool HasConstPtr = false;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000362 switch (BuiltinID) {
Nate Begemana23326b2010-06-17 04:17:01 +0000363#define GET_NEON_OVERLOAD_CHECK
364#include "clang/Basic/arm_neon.inc"
365#undef GET_NEON_OVERLOAD_CHECK
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000366 }
367
Nate Begeman0d15c532010-06-13 04:47:52 +0000368 // For NEON intrinsics which are overloaded on vector element type, validate
369 // the immediate which specifies which variant to emit.
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000370 unsigned ImmArg = TheCall->getNumArgs()-1;
Nate Begeman0d15c532010-06-13 04:47:52 +0000371 if (mask) {
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000372 if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
Nate Begeman0d15c532010-06-13 04:47:52 +0000373 return true;
374
Bob Wilsonda95f732011-11-08 01:16:11 +0000375 TV = Result.getLimitedValue(64);
Richard Smithf8ee6bc2012-08-14 01:28:02 +0000376 if ((TV > 63) || (mask & (1ULL << TV)) == 0)
Nate Begeman0d15c532010-06-13 04:47:52 +0000377 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000378 << TheCall->getArg(ImmArg)->getSourceRange();
379 }
380
Bob Wilson46482552011-11-16 21:32:23 +0000381 if (PtrArgNum >= 0) {
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000382 // Check that pointer arguments have the specified type.
Bob Wilson46482552011-11-16 21:32:23 +0000383 Expr *Arg = TheCall->getArg(PtrArgNum);
384 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
385 Arg = ICE->getSubExpr();
386 ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
387 QualType RHSTy = RHS.get()->getType();
388 QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context);
389 if (HasConstPtr)
390 EltTy = EltTy.withConst();
391 QualType LHSTy = Context.getPointerType(EltTy);
392 AssignConvertType ConvTy;
393 ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
394 if (RHS.isInvalid())
395 return true;
396 if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
397 RHS.get(), AA_Assigning))
398 return true;
Nate Begeman0d15c532010-06-13 04:47:52 +0000399 }
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000400
Nate Begeman0d15c532010-06-13 04:47:52 +0000401 // For NEON intrinsics which take an immediate value as part of the
402 // instruction, range check them here.
Nate Begeman61eecf52010-06-14 05:21:25 +0000403 unsigned i = 0, l = 0, u = 0;
Nate Begeman0d15c532010-06-13 04:47:52 +0000404 switch (BuiltinID) {
405 default: return false;
Nate Begemanbb37f502010-07-29 22:48:34 +0000406 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
407 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
Nate Begeman99c40bb2010-08-03 21:32:34 +0000408 case ARM::BI__builtin_arm_vcvtr_f:
409 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
Nate Begemana23326b2010-06-17 04:17:01 +0000410#define GET_NEON_IMMEDIATE_CHECK
411#include "clang/Basic/arm_neon.inc"
412#undef GET_NEON_IMMEDIATE_CHECK
Nate Begeman0d15c532010-06-13 04:47:52 +0000413 };
414
Douglas Gregor592a4232012-06-29 01:05:22 +0000415 // We can't check the value of a dependent argument.
416 if (TheCall->getArg(i)->isTypeDependent() ||
417 TheCall->getArg(i)->isValueDependent())
418 return false;
419
Nate Begeman61eecf52010-06-14 05:21:25 +0000420 // Check that the immediate argument is actually a constant.
Nate Begeman0d15c532010-06-13 04:47:52 +0000421 if (SemaBuiltinConstantArg(TheCall, i, Result))
422 return true;
423
Nate Begeman61eecf52010-06-14 05:21:25 +0000424 // Range check against the upper/lower values for this isntruction.
Nate Begeman0d15c532010-06-13 04:47:52 +0000425 unsigned Val = Result.getZExtValue();
Nate Begeman61eecf52010-06-14 05:21:25 +0000426 if (Val < l || Val > (u + l))
Nate Begeman0d15c532010-06-13 04:47:52 +0000427 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Benjamin Kramer476d8b82010-08-11 14:47:12 +0000428 << l << u+l << TheCall->getArg(i)->getSourceRange();
Nate Begeman0d15c532010-06-13 04:47:52 +0000429
Nate Begeman99c40bb2010-08-03 21:32:34 +0000430 // FIXME: VFP Intrinsics should error if VFP not present.
Nate Begeman26a31422010-06-08 02:47:44 +0000431 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000432}
Daniel Dunbarde454282008-10-02 18:44:07 +0000433
Simon Atanasyanfad0a322012-07-08 09:30:00 +0000434bool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
435 unsigned i = 0, l = 0, u = 0;
436 switch (BuiltinID) {
437 default: return false;
438 case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break;
439 case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break;
Simon Atanasyanbe22cb82012-08-27 12:29:20 +0000440 case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break;
441 case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break;
442 case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break;
443 case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break;
444 case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break;
Simon Atanasyanfad0a322012-07-08 09:30:00 +0000445 };
446
447 // We can't check the value of a dependent argument.
448 if (TheCall->getArg(i)->isTypeDependent() ||
449 TheCall->getArg(i)->isValueDependent())
450 return false;
451
452 // Check that the immediate argument is actually a constant.
453 llvm::APSInt Result;
454 if (SemaBuiltinConstantArg(TheCall, i, Result))
455 return true;
456
457 // Range check against the upper/lower values for this instruction.
458 unsigned Val = Result.getZExtValue();
459 if (Val < l || Val > u)
460 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
461 << l << u << TheCall->getArg(i)->getSourceRange();
462
463 return false;
464}
465
Richard Smith831421f2012-06-25 20:30:08 +0000466/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo
467/// parameter with the FormatAttr's correct format_idx and firstDataArg.
468/// Returns true when the format fits the function and the FormatStringInfo has
469/// been populated.
470bool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember,
471 FormatStringInfo *FSI) {
472 FSI->HasVAListArg = Format->getFirstArg() == 0;
473 FSI->FormatIdx = Format->getFormatIdx() - 1;
474 FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1;
Anders Carlssond406bf02009-08-16 01:56:34 +0000475
Richard Smith831421f2012-06-25 20:30:08 +0000476 // The way the format attribute works in GCC, the implicit this argument
477 // of member functions is counted. However, it doesn't appear in our own
478 // lists, so decrement format_idx in that case.
479 if (IsCXXMember) {
480 if(FSI->FormatIdx == 0)
481 return false;
482 --FSI->FormatIdx;
483 if (FSI->FirstDataArg != 0)
484 --FSI->FirstDataArg;
485 }
486 return true;
487}
Mike Stump1eb44332009-09-09 15:08:12 +0000488
Richard Smith831421f2012-06-25 20:30:08 +0000489/// Handles the checks for format strings, non-POD arguments to vararg
490/// functions, and NULL arguments passed to non-NULL parameters.
491void Sema::checkCall(NamedDecl *FDecl, Expr **Args,
492 unsigned NumArgs,
493 unsigned NumProtoArgs,
494 bool IsMemberFunction,
495 SourceLocation Loc,
496 SourceRange Range,
497 VariadicCallType CallType) {
Daniel Dunbarde454282008-10-02 18:44:07 +0000498 // FIXME: This mechanism should be abstracted to be less fragile and
499 // more efficient. For example, just map function ids to custom
500 // handlers.
501
Ted Kremenekc82faca2010-09-09 04:33:05 +0000502 // Printf and scanf checking.
Richard Smith831421f2012-06-25 20:30:08 +0000503 bool HandledFormatString = false;
Ted Kremenekc82faca2010-09-09 04:33:05 +0000504 for (specific_attr_iterator<FormatAttr>
Richard Smith831421f2012-06-25 20:30:08 +0000505 I = FDecl->specific_attr_begin<FormatAttr>(),
506 E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I)
Jordan Roseddcfbc92012-07-19 18:10:23 +0000507 if (CheckFormatArguments(*I, Args, NumArgs, IsMemberFunction, CallType,
508 Loc, Range))
Richard Smith831421f2012-06-25 20:30:08 +0000509 HandledFormatString = true;
510
511 // Refuse POD arguments that weren't caught by the format string
512 // checks above.
513 if (!HandledFormatString && CallType != VariadicDoesNotApply)
514 for (unsigned ArgIdx = NumProtoArgs; ArgIdx < NumArgs; ++ArgIdx)
515 variadicArgumentPODCheck(Args[ArgIdx], CallType);
Mike Stump1eb44332009-09-09 15:08:12 +0000516
Ted Kremenekc82faca2010-09-09 04:33:05 +0000517 for (specific_attr_iterator<NonNullAttr>
Richard Smith831421f2012-06-25 20:30:08 +0000518 I = FDecl->specific_attr_begin<NonNullAttr>(),
519 E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I)
520 CheckNonNullArguments(*I, Args, Loc);
Dmitri Gribenko0d5a0692012-08-17 00:08:38 +0000521
522 // Type safety checking.
523 for (specific_attr_iterator<ArgumentWithTypeTagAttr>
524 i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(),
525 e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); i != e; ++i) {
526 CheckArgumentWithTypeTag(*i, Args);
527 }
Richard Smith831421f2012-06-25 20:30:08 +0000528}
529
530/// CheckConstructorCall - Check a constructor call for correctness and safety
531/// properties not enforced by the C type system.
532void Sema::CheckConstructorCall(FunctionDecl *FDecl, Expr **Args,
533 unsigned NumArgs,
534 const FunctionProtoType *Proto,
535 SourceLocation Loc) {
536 VariadicCallType CallType =
537 Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply;
538 checkCall(FDecl, Args, NumArgs, Proto->getNumArgs(),
539 /*IsMemberFunction=*/true, Loc, SourceRange(), CallType);
540}
541
542/// CheckFunctionCall - Check a direct function call for various correctness
543/// and safety properties not strictly enforced by the C type system.
544bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall,
545 const FunctionProtoType *Proto) {
546 bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall);
547 VariadicCallType CallType = getVariadicCallType(FDecl, Proto,
548 TheCall->getCallee());
549 unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
550 checkCall(FDecl, TheCall->getArgs(), TheCall->getNumArgs(), NumProtoArgs,
551 IsMemberFunction, TheCall->getRParenLoc(),
552 TheCall->getCallee()->getSourceRange(), CallType);
553
554 IdentifierInfo *FnInfo = FDecl->getIdentifier();
555 // None of the checks below are needed for functions that don't have
556 // simple names (e.g., C++ conversion functions).
557 if (!FnInfo)
558 return false;
Sebastian Redl0eb23302009-01-19 00:08:26 +0000559
Anna Zaks0a151a12012-01-17 00:37:07 +0000560 unsigned CMId = FDecl->getMemoryFunctionKind();
561 if (CMId == 0)
Anna Zaksd9b859a2012-01-13 21:52:01 +0000562 return false;
Ted Kremenekbd5da9d2011-08-18 20:55:45 +0000563
Anna Zaksd9b859a2012-01-13 21:52:01 +0000564 // Handle memory setting and copying functions.
Anna Zaks0a151a12012-01-17 00:37:07 +0000565 if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
Ted Kremenekbd5da9d2011-08-18 20:55:45 +0000566 CheckStrlcpycatArguments(TheCall, FnInfo);
Anna Zaksc36bedc2012-02-01 19:08:57 +0000567 else if (CMId == Builtin::BIstrncat)
568 CheckStrncatArguments(TheCall, FnInfo);
Anna Zaksd9b859a2012-01-13 21:52:01 +0000569 else
Anna Zaks0a151a12012-01-17 00:37:07 +0000570 CheckMemaccessArguments(TheCall, CMId, FnInfo);
Chandler Carruth7ccc95b2011-04-27 07:05:31 +0000571
Anders Carlssond406bf02009-08-16 01:56:34 +0000572 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000573}
574
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +0000575bool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
576 Expr **Args, unsigned NumArgs) {
Richard Smith831421f2012-06-25 20:30:08 +0000577 VariadicCallType CallType =
578 Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply;
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +0000579
Richard Smith831421f2012-06-25 20:30:08 +0000580 checkCall(Method, Args, NumArgs, Method->param_size(),
581 /*IsMemberFunction=*/false,
582 lbrac, Method->getSourceRange(), CallType);
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +0000583
584 return false;
585}
586
Richard Smith831421f2012-06-25 20:30:08 +0000587bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall,
588 const FunctionProtoType *Proto) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000589 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
590 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000591 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000592
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000593 QualType Ty = V->getType();
594 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000595 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000596
Richard Smith831421f2012-06-25 20:30:08 +0000597 VariadicCallType CallType =
598 Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ;
599 unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
Anders Carlssond406bf02009-08-16 01:56:34 +0000600
Richard Smith831421f2012-06-25 20:30:08 +0000601 checkCall(NDecl, TheCall->getArgs(), TheCall->getNumArgs(),
602 NumProtoArgs, /*IsMemberFunction=*/false,
603 TheCall->getRParenLoc(),
604 TheCall->getCallee()->getSourceRange(), CallType);
605
Anders Carlssond406bf02009-08-16 01:56:34 +0000606 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000607}
608
Richard Smithff34d402012-04-12 05:08:17 +0000609ExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult,
610 AtomicExpr::AtomicOp Op) {
Eli Friedman276b0612011-10-11 02:20:01 +0000611 CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
612 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
Eli Friedman276b0612011-10-11 02:20:01 +0000613
Richard Smithff34d402012-04-12 05:08:17 +0000614 // All these operations take one of the following forms:
615 enum {
616 // C __c11_atomic_init(A *, C)
617 Init,
618 // C __c11_atomic_load(A *, int)
619 Load,
620 // void __atomic_load(A *, CP, int)
621 Copy,
622 // C __c11_atomic_add(A *, M, int)
623 Arithmetic,
624 // C __atomic_exchange_n(A *, CP, int)
625 Xchg,
626 // void __atomic_exchange(A *, C *, CP, int)
627 GNUXchg,
628 // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int)
629 C11CmpXchg,
630 // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int)
631 GNUCmpXchg
632 } Form = Init;
633 const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 };
634 const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 };
635 // where:
636 // C is an appropriate type,
637 // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins,
638 // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise,
639 // M is C if C is an integer, and ptrdiff_t if C is a pointer, and
640 // the int parameters are for orderings.
Eli Friedman276b0612011-10-11 02:20:01 +0000641
Richard Smithff34d402012-04-12 05:08:17 +0000642 assert(AtomicExpr::AO__c11_atomic_init == 0 &&
643 AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load
644 && "need to update code for modified C11 atomics");
645 bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&
646 Op <= AtomicExpr::AO__c11_atomic_fetch_xor;
647 bool IsN = Op == AtomicExpr::AO__atomic_load_n ||
648 Op == AtomicExpr::AO__atomic_store_n ||
649 Op == AtomicExpr::AO__atomic_exchange_n ||
650 Op == AtomicExpr::AO__atomic_compare_exchange_n;
651 bool IsAddSub = false;
652
653 switch (Op) {
654 case AtomicExpr::AO__c11_atomic_init:
655 Form = Init;
656 break;
657
658 case AtomicExpr::AO__c11_atomic_load:
659 case AtomicExpr::AO__atomic_load_n:
660 Form = Load;
661 break;
662
663 case AtomicExpr::AO__c11_atomic_store:
664 case AtomicExpr::AO__atomic_load:
665 case AtomicExpr::AO__atomic_store:
666 case AtomicExpr::AO__atomic_store_n:
667 Form = Copy;
668 break;
669
670 case AtomicExpr::AO__c11_atomic_fetch_add:
671 case AtomicExpr::AO__c11_atomic_fetch_sub:
672 case AtomicExpr::AO__atomic_fetch_add:
673 case AtomicExpr::AO__atomic_fetch_sub:
674 case AtomicExpr::AO__atomic_add_fetch:
675 case AtomicExpr::AO__atomic_sub_fetch:
676 IsAddSub = true;
677 // Fall through.
678 case AtomicExpr::AO__c11_atomic_fetch_and:
679 case AtomicExpr::AO__c11_atomic_fetch_or:
680 case AtomicExpr::AO__c11_atomic_fetch_xor:
681 case AtomicExpr::AO__atomic_fetch_and:
682 case AtomicExpr::AO__atomic_fetch_or:
683 case AtomicExpr::AO__atomic_fetch_xor:
Richard Smith51b92402012-04-13 06:31:38 +0000684 case AtomicExpr::AO__atomic_fetch_nand:
Richard Smithff34d402012-04-12 05:08:17 +0000685 case AtomicExpr::AO__atomic_and_fetch:
686 case AtomicExpr::AO__atomic_or_fetch:
687 case AtomicExpr::AO__atomic_xor_fetch:
Richard Smith51b92402012-04-13 06:31:38 +0000688 case AtomicExpr::AO__atomic_nand_fetch:
Richard Smithff34d402012-04-12 05:08:17 +0000689 Form = Arithmetic;
690 break;
691
692 case AtomicExpr::AO__c11_atomic_exchange:
693 case AtomicExpr::AO__atomic_exchange_n:
694 Form = Xchg;
695 break;
696
697 case AtomicExpr::AO__atomic_exchange:
698 Form = GNUXchg;
699 break;
700
701 case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
702 case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
703 Form = C11CmpXchg;
704 break;
705
706 case AtomicExpr::AO__atomic_compare_exchange:
707 case AtomicExpr::AO__atomic_compare_exchange_n:
708 Form = GNUCmpXchg;
709 break;
710 }
711
712 // Check we have the right number of arguments.
713 if (TheCall->getNumArgs() < NumArgs[Form]) {
Eli Friedman276b0612011-10-11 02:20:01 +0000714 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Richard Smithff34d402012-04-12 05:08:17 +0000715 << 0 << NumArgs[Form] << TheCall->getNumArgs()
Eli Friedman276b0612011-10-11 02:20:01 +0000716 << TheCall->getCallee()->getSourceRange();
717 return ExprError();
Richard Smithff34d402012-04-12 05:08:17 +0000718 } else if (TheCall->getNumArgs() > NumArgs[Form]) {
719 Diag(TheCall->getArg(NumArgs[Form])->getLocStart(),
Eli Friedman276b0612011-10-11 02:20:01 +0000720 diag::err_typecheck_call_too_many_args)
Richard Smithff34d402012-04-12 05:08:17 +0000721 << 0 << NumArgs[Form] << TheCall->getNumArgs()
Eli Friedman276b0612011-10-11 02:20:01 +0000722 << TheCall->getCallee()->getSourceRange();
723 return ExprError();
724 }
725
Richard Smithff34d402012-04-12 05:08:17 +0000726 // Inspect the first argument of the atomic operation.
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000727 Expr *Ptr = TheCall->getArg(0);
Eli Friedman276b0612011-10-11 02:20:01 +0000728 Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get();
729 const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
730 if (!pointerType) {
Richard Smithff34d402012-04-12 05:08:17 +0000731 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
Eli Friedman276b0612011-10-11 02:20:01 +0000732 << Ptr->getType() << Ptr->getSourceRange();
733 return ExprError();
734 }
735
Richard Smithff34d402012-04-12 05:08:17 +0000736 // For a __c11 builtin, this should be a pointer to an _Atomic type.
737 QualType AtomTy = pointerType->getPointeeType(); // 'A'
738 QualType ValType = AtomTy; // 'C'
739 if (IsC11) {
740 if (!AtomTy->isAtomicType()) {
741 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
742 << Ptr->getType() << Ptr->getSourceRange();
743 return ExprError();
744 }
745 ValType = AtomTy->getAs<AtomicType>()->getValueType();
Eli Friedman276b0612011-10-11 02:20:01 +0000746 }
Eli Friedman276b0612011-10-11 02:20:01 +0000747
Richard Smithff34d402012-04-12 05:08:17 +0000748 // For an arithmetic operation, the implied arithmetic must be well-formed.
749 if (Form == Arithmetic) {
750 // gcc does not enforce these rules for GNU atomics, but we do so for sanity.
751 if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) {
752 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
753 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
754 return ExprError();
755 }
756 if (!IsAddSub && !ValType->isIntegerType()) {
757 Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int)
758 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
759 return ExprError();
760 }
761 } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) {
762 // For __atomic_*_n operations, the value type must be a scalar integral or
763 // pointer type which is 1, 2, 4, 8 or 16 bytes in length.
Eli Friedman276b0612011-10-11 02:20:01 +0000764 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
Richard Smithff34d402012-04-12 05:08:17 +0000765 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
766 return ExprError();
767 }
768
769 if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) {
770 // For GNU atomics, require a trivially-copyable type. This is not part of
771 // the GNU atomics specification, but we enforce it for sanity.
772 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy)
Eli Friedman276b0612011-10-11 02:20:01 +0000773 << Ptr->getType() << Ptr->getSourceRange();
774 return ExprError();
775 }
776
Richard Smithff34d402012-04-12 05:08:17 +0000777 // FIXME: For any builtin other than a load, the ValType must not be
778 // const-qualified.
Eli Friedman276b0612011-10-11 02:20:01 +0000779
780 switch (ValType.getObjCLifetime()) {
781 case Qualifiers::OCL_None:
782 case Qualifiers::OCL_ExplicitNone:
783 // okay
784 break;
785
786 case Qualifiers::OCL_Weak:
787 case Qualifiers::OCL_Strong:
788 case Qualifiers::OCL_Autoreleasing:
Richard Smithff34d402012-04-12 05:08:17 +0000789 // FIXME: Can this happen? By this point, ValType should be known
790 // to be trivially copyable.
Eli Friedman276b0612011-10-11 02:20:01 +0000791 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
792 << ValType << Ptr->getSourceRange();
793 return ExprError();
794 }
795
796 QualType ResultType = ValType;
Richard Smithff34d402012-04-12 05:08:17 +0000797 if (Form == Copy || Form == GNUXchg || Form == Init)
Eli Friedman276b0612011-10-11 02:20:01 +0000798 ResultType = Context.VoidTy;
Richard Smithff34d402012-04-12 05:08:17 +0000799 else if (Form == C11CmpXchg || Form == GNUCmpXchg)
Eli Friedman276b0612011-10-11 02:20:01 +0000800 ResultType = Context.BoolTy;
801
Richard Smithff34d402012-04-12 05:08:17 +0000802 // The type of a parameter passed 'by value'. In the GNU atomics, such
803 // arguments are actually passed as pointers.
804 QualType ByValType = ValType; // 'CP'
805 if (!IsC11 && !IsN)
806 ByValType = Ptr->getType();
807
Eli Friedman276b0612011-10-11 02:20:01 +0000808 // The first argument --- the pointer --- has a fixed type; we
809 // deduce the types of the rest of the arguments accordingly. Walk
810 // the remaining arguments, converting them to the deduced value type.
Richard Smithff34d402012-04-12 05:08:17 +0000811 for (unsigned i = 1; i != NumArgs[Form]; ++i) {
Eli Friedman276b0612011-10-11 02:20:01 +0000812 QualType Ty;
Richard Smithff34d402012-04-12 05:08:17 +0000813 if (i < NumVals[Form] + 1) {
814 switch (i) {
815 case 1:
816 // The second argument is the non-atomic operand. For arithmetic, this
817 // is always passed by value, and for a compare_exchange it is always
818 // passed by address. For the rest, GNU uses by-address and C11 uses
819 // by-value.
820 assert(Form != Load);
821 if (Form == Init || (Form == Arithmetic && ValType->isIntegerType()))
822 Ty = ValType;
823 else if (Form == Copy || Form == Xchg)
824 Ty = ByValType;
825 else if (Form == Arithmetic)
826 Ty = Context.getPointerDiffType();
827 else
828 Ty = Context.getPointerType(ValType.getUnqualifiedType());
829 break;
830 case 2:
831 // The third argument to compare_exchange / GNU exchange is a
832 // (pointer to a) desired value.
833 Ty = ByValType;
834 break;
835 case 3:
836 // The fourth argument to GNU compare_exchange is a 'weak' flag.
837 Ty = Context.BoolTy;
838 break;
839 }
Eli Friedman276b0612011-10-11 02:20:01 +0000840 } else {
841 // The order(s) are always converted to int.
842 Ty = Context.IntTy;
843 }
Richard Smithff34d402012-04-12 05:08:17 +0000844
Eli Friedman276b0612011-10-11 02:20:01 +0000845 InitializedEntity Entity =
846 InitializedEntity::InitializeParameter(Context, Ty, false);
Richard Smithff34d402012-04-12 05:08:17 +0000847 ExprResult Arg = TheCall->getArg(i);
Eli Friedman276b0612011-10-11 02:20:01 +0000848 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
849 if (Arg.isInvalid())
850 return true;
851 TheCall->setArg(i, Arg.get());
852 }
853
Richard Smithff34d402012-04-12 05:08:17 +0000854 // Permute the arguments into a 'consistent' order.
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000855 SmallVector<Expr*, 5> SubExprs;
856 SubExprs.push_back(Ptr);
Richard Smithff34d402012-04-12 05:08:17 +0000857 switch (Form) {
858 case Init:
859 // Note, AtomicExpr::getVal1() has a special case for this atomic.
David Chisnall7a7ee302012-01-16 17:27:18 +0000860 SubExprs.push_back(TheCall->getArg(1)); // Val1
Richard Smithff34d402012-04-12 05:08:17 +0000861 break;
862 case Load:
863 SubExprs.push_back(TheCall->getArg(1)); // Order
864 break;
865 case Copy:
866 case Arithmetic:
867 case Xchg:
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000868 SubExprs.push_back(TheCall->getArg(2)); // Order
869 SubExprs.push_back(TheCall->getArg(1)); // Val1
Richard Smithff34d402012-04-12 05:08:17 +0000870 break;
871 case GNUXchg:
872 // Note, AtomicExpr::getVal2() has a special case for this atomic.
873 SubExprs.push_back(TheCall->getArg(3)); // Order
874 SubExprs.push_back(TheCall->getArg(1)); // Val1
875 SubExprs.push_back(TheCall->getArg(2)); // Val2
876 break;
877 case C11CmpXchg:
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000878 SubExprs.push_back(TheCall->getArg(3)); // Order
879 SubExprs.push_back(TheCall->getArg(1)); // Val1
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000880 SubExprs.push_back(TheCall->getArg(4)); // OrderFail
David Chisnall2ebb98a2012-03-29 17:58:59 +0000881 SubExprs.push_back(TheCall->getArg(2)); // Val2
Richard Smithff34d402012-04-12 05:08:17 +0000882 break;
883 case GNUCmpXchg:
884 SubExprs.push_back(TheCall->getArg(4)); // Order
885 SubExprs.push_back(TheCall->getArg(1)); // Val1
886 SubExprs.push_back(TheCall->getArg(5)); // OrderFail
887 SubExprs.push_back(TheCall->getArg(2)); // Val2
888 SubExprs.push_back(TheCall->getArg(3)); // Weak
889 break;
Eli Friedman276b0612011-10-11 02:20:01 +0000890 }
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000891
892 return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
Benjamin Kramer3b6bef92012-08-24 11:54:20 +0000893 SubExprs, ResultType, Op,
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000894 TheCall->getRParenLoc()));
Eli Friedman276b0612011-10-11 02:20:01 +0000895}
896
897
John McCall5f8d6042011-08-27 01:09:30 +0000898/// checkBuiltinArgument - Given a call to a builtin function, perform
899/// normal type-checking on the given argument, updating the call in
900/// place. This is useful when a builtin function requires custom
901/// type-checking for some of its arguments but not necessarily all of
902/// them.
903///
904/// Returns true on error.
905static bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
906 FunctionDecl *Fn = E->getDirectCallee();
907 assert(Fn && "builtin call without direct callee!");
908
909 ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
910 InitializedEntity Entity =
911 InitializedEntity::InitializeParameter(S.Context, Param);
912
913 ExprResult Arg = E->getArg(0);
914 Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
915 if (Arg.isInvalid())
916 return true;
917
918 E->setArg(ArgIndex, Arg.take());
919 return false;
920}
921
Chris Lattner5caa3702009-05-08 06:58:22 +0000922/// SemaBuiltinAtomicOverloaded - We have a call to a function like
923/// __sync_fetch_and_add, which is an overloaded function based on the pointer
924/// type of its first argument. The main ActOnCallExpr routines have already
925/// promoted the types of arguments because all of these calls are prototyped as
926/// void(...).
927///
928/// This function goes through and does final semantic checking for these
929/// builtins,
John McCall60d7b3a2010-08-24 06:29:42 +0000930ExprResult
931Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
Chandler Carruthd2014572010-07-09 18:59:35 +0000932 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
Chris Lattner5caa3702009-05-08 06:58:22 +0000933 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
934 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
935
936 // Ensure that we have at least one argument to do type inference from.
Chandler Carruthd2014572010-07-09 18:59:35 +0000937 if (TheCall->getNumArgs() < 1) {
938 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
939 << 0 << 1 << TheCall->getNumArgs()
940 << TheCall->getCallee()->getSourceRange();
941 return ExprError();
942 }
Mike Stump1eb44332009-09-09 15:08:12 +0000943
Chris Lattner5caa3702009-05-08 06:58:22 +0000944 // Inspect the first argument of the atomic builtin. This should always be
945 // a pointer type, whose element is an integral scalar or pointer type.
946 // Because it is a pointer type, we don't have to worry about any implicit
947 // casts here.
Chandler Carruthd2014572010-07-09 18:59:35 +0000948 // FIXME: We don't allow floating point scalars as input.
Chris Lattner5caa3702009-05-08 06:58:22 +0000949 Expr *FirstArg = TheCall->getArg(0);
Eli Friedman8c382062012-01-23 02:35:22 +0000950 ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
951 if (FirstArgResult.isInvalid())
952 return ExprError();
953 FirstArg = FirstArgResult.take();
954 TheCall->setArg(0, FirstArg);
955
John McCallf85e1932011-06-15 23:02:42 +0000956 const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
957 if (!pointerType) {
Chandler Carruthd2014572010-07-09 18:59:35 +0000958 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
959 << FirstArg->getType() << FirstArg->getSourceRange();
960 return ExprError();
961 }
Mike Stump1eb44332009-09-09 15:08:12 +0000962
John McCallf85e1932011-06-15 23:02:42 +0000963 QualType ValType = pointerType->getPointeeType();
Chris Lattnerdd5fa7a2010-09-17 21:12:38 +0000964 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
Chandler Carruthd2014572010-07-09 18:59:35 +0000965 !ValType->isBlockPointerType()) {
966 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
967 << FirstArg->getType() << FirstArg->getSourceRange();
968 return ExprError();
969 }
Chris Lattner5caa3702009-05-08 06:58:22 +0000970
John McCallf85e1932011-06-15 23:02:42 +0000971 switch (ValType.getObjCLifetime()) {
972 case Qualifiers::OCL_None:
973 case Qualifiers::OCL_ExplicitNone:
974 // okay
975 break;
976
977 case Qualifiers::OCL_Weak:
978 case Qualifiers::OCL_Strong:
979 case Qualifiers::OCL_Autoreleasing:
Argyrios Kyrtzidisb8b03132011-06-24 00:08:59 +0000980 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
John McCallf85e1932011-06-15 23:02:42 +0000981 << ValType << FirstArg->getSourceRange();
982 return ExprError();
983 }
984
John McCallb45ae252011-10-05 07:41:44 +0000985 // Strip any qualifiers off ValType.
986 ValType = ValType.getUnqualifiedType();
987
Chandler Carruth8d13d222010-07-18 20:54:12 +0000988 // The majority of builtins return a value, but a few have special return
989 // types, so allow them to override appropriately below.
990 QualType ResultType = ValType;
991
Chris Lattner5caa3702009-05-08 06:58:22 +0000992 // We need to figure out which concrete builtin this maps onto. For example,
993 // __sync_fetch_and_add with a 2 byte object turns into
994 // __sync_fetch_and_add_2.
995#define BUILTIN_ROW(x) \
996 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
997 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000998
Chris Lattner5caa3702009-05-08 06:58:22 +0000999 static const unsigned BuiltinIndices[][5] = {
1000 BUILTIN_ROW(__sync_fetch_and_add),
1001 BUILTIN_ROW(__sync_fetch_and_sub),
1002 BUILTIN_ROW(__sync_fetch_and_or),
1003 BUILTIN_ROW(__sync_fetch_and_and),
1004 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +00001005
Chris Lattner5caa3702009-05-08 06:58:22 +00001006 BUILTIN_ROW(__sync_add_and_fetch),
1007 BUILTIN_ROW(__sync_sub_and_fetch),
1008 BUILTIN_ROW(__sync_and_and_fetch),
1009 BUILTIN_ROW(__sync_or_and_fetch),
1010 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +00001011
Chris Lattner5caa3702009-05-08 06:58:22 +00001012 BUILTIN_ROW(__sync_val_compare_and_swap),
1013 BUILTIN_ROW(__sync_bool_compare_and_swap),
1014 BUILTIN_ROW(__sync_lock_test_and_set),
Chris Lattner23aa9c82011-04-09 03:57:26 +00001015 BUILTIN_ROW(__sync_lock_release),
1016 BUILTIN_ROW(__sync_swap)
Chris Lattner5caa3702009-05-08 06:58:22 +00001017 };
Mike Stump1eb44332009-09-09 15:08:12 +00001018#undef BUILTIN_ROW
1019
Chris Lattner5caa3702009-05-08 06:58:22 +00001020 // Determine the index of the size.
1021 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +00001022 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +00001023 case 1: SizeIndex = 0; break;
1024 case 2: SizeIndex = 1; break;
1025 case 4: SizeIndex = 2; break;
1026 case 8: SizeIndex = 3; break;
1027 case 16: SizeIndex = 4; break;
1028 default:
Chandler Carruthd2014572010-07-09 18:59:35 +00001029 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
1030 << FirstArg->getType() << FirstArg->getSourceRange();
1031 return ExprError();
Chris Lattner5caa3702009-05-08 06:58:22 +00001032 }
Mike Stump1eb44332009-09-09 15:08:12 +00001033
Chris Lattner5caa3702009-05-08 06:58:22 +00001034 // Each of these builtins has one pointer argument, followed by some number of
1035 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
1036 // that we ignore. Find out which row of BuiltinIndices to read from as well
1037 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +00001038 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +00001039 unsigned BuiltinIndex, NumFixed = 1;
1040 switch (BuiltinID) {
David Blaikieb219cfc2011-09-23 05:06:16 +00001041 default: llvm_unreachable("Unknown overloaded atomic builtin!");
Douglas Gregora9766412011-11-28 16:30:08 +00001042 case Builtin::BI__sync_fetch_and_add:
1043 case Builtin::BI__sync_fetch_and_add_1:
1044 case Builtin::BI__sync_fetch_and_add_2:
1045 case Builtin::BI__sync_fetch_and_add_4:
1046 case Builtin::BI__sync_fetch_and_add_8:
1047 case Builtin::BI__sync_fetch_and_add_16:
1048 BuiltinIndex = 0;
1049 break;
1050
1051 case Builtin::BI__sync_fetch_and_sub:
1052 case Builtin::BI__sync_fetch_and_sub_1:
1053 case Builtin::BI__sync_fetch_and_sub_2:
1054 case Builtin::BI__sync_fetch_and_sub_4:
1055 case Builtin::BI__sync_fetch_and_sub_8:
1056 case Builtin::BI__sync_fetch_and_sub_16:
1057 BuiltinIndex = 1;
1058 break;
1059
1060 case Builtin::BI__sync_fetch_and_or:
1061 case Builtin::BI__sync_fetch_and_or_1:
1062 case Builtin::BI__sync_fetch_and_or_2:
1063 case Builtin::BI__sync_fetch_and_or_4:
1064 case Builtin::BI__sync_fetch_and_or_8:
1065 case Builtin::BI__sync_fetch_and_or_16:
1066 BuiltinIndex = 2;
1067 break;
1068
1069 case Builtin::BI__sync_fetch_and_and:
1070 case Builtin::BI__sync_fetch_and_and_1:
1071 case Builtin::BI__sync_fetch_and_and_2:
1072 case Builtin::BI__sync_fetch_and_and_4:
1073 case Builtin::BI__sync_fetch_and_and_8:
1074 case Builtin::BI__sync_fetch_and_and_16:
1075 BuiltinIndex = 3;
1076 break;
Mike Stump1eb44332009-09-09 15:08:12 +00001077
Douglas Gregora9766412011-11-28 16:30:08 +00001078 case Builtin::BI__sync_fetch_and_xor:
1079 case Builtin::BI__sync_fetch_and_xor_1:
1080 case Builtin::BI__sync_fetch_and_xor_2:
1081 case Builtin::BI__sync_fetch_and_xor_4:
1082 case Builtin::BI__sync_fetch_and_xor_8:
1083 case Builtin::BI__sync_fetch_and_xor_16:
1084 BuiltinIndex = 4;
1085 break;
1086
1087 case Builtin::BI__sync_add_and_fetch:
1088 case Builtin::BI__sync_add_and_fetch_1:
1089 case Builtin::BI__sync_add_and_fetch_2:
1090 case Builtin::BI__sync_add_and_fetch_4:
1091 case Builtin::BI__sync_add_and_fetch_8:
1092 case Builtin::BI__sync_add_and_fetch_16:
1093 BuiltinIndex = 5;
1094 break;
1095
1096 case Builtin::BI__sync_sub_and_fetch:
1097 case Builtin::BI__sync_sub_and_fetch_1:
1098 case Builtin::BI__sync_sub_and_fetch_2:
1099 case Builtin::BI__sync_sub_and_fetch_4:
1100 case Builtin::BI__sync_sub_and_fetch_8:
1101 case Builtin::BI__sync_sub_and_fetch_16:
1102 BuiltinIndex = 6;
1103 break;
1104
1105 case Builtin::BI__sync_and_and_fetch:
1106 case Builtin::BI__sync_and_and_fetch_1:
1107 case Builtin::BI__sync_and_and_fetch_2:
1108 case Builtin::BI__sync_and_and_fetch_4:
1109 case Builtin::BI__sync_and_and_fetch_8:
1110 case Builtin::BI__sync_and_and_fetch_16:
1111 BuiltinIndex = 7;
1112 break;
1113
1114 case Builtin::BI__sync_or_and_fetch:
1115 case Builtin::BI__sync_or_and_fetch_1:
1116 case Builtin::BI__sync_or_and_fetch_2:
1117 case Builtin::BI__sync_or_and_fetch_4:
1118 case Builtin::BI__sync_or_and_fetch_8:
1119 case Builtin::BI__sync_or_and_fetch_16:
1120 BuiltinIndex = 8;
1121 break;
1122
1123 case Builtin::BI__sync_xor_and_fetch:
1124 case Builtin::BI__sync_xor_and_fetch_1:
1125 case Builtin::BI__sync_xor_and_fetch_2:
1126 case Builtin::BI__sync_xor_and_fetch_4:
1127 case Builtin::BI__sync_xor_and_fetch_8:
1128 case Builtin::BI__sync_xor_and_fetch_16:
1129 BuiltinIndex = 9;
1130 break;
Mike Stump1eb44332009-09-09 15:08:12 +00001131
Chris Lattner5caa3702009-05-08 06:58:22 +00001132 case Builtin::BI__sync_val_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +00001133 case Builtin::BI__sync_val_compare_and_swap_1:
1134 case Builtin::BI__sync_val_compare_and_swap_2:
1135 case Builtin::BI__sync_val_compare_and_swap_4:
1136 case Builtin::BI__sync_val_compare_and_swap_8:
1137 case Builtin::BI__sync_val_compare_and_swap_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +00001138 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +00001139 NumFixed = 2;
1140 break;
Douglas Gregora9766412011-11-28 16:30:08 +00001141
Chris Lattner5caa3702009-05-08 06:58:22 +00001142 case Builtin::BI__sync_bool_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +00001143 case Builtin::BI__sync_bool_compare_and_swap_1:
1144 case Builtin::BI__sync_bool_compare_and_swap_2:
1145 case Builtin::BI__sync_bool_compare_and_swap_4:
1146 case Builtin::BI__sync_bool_compare_and_swap_8:
1147 case Builtin::BI__sync_bool_compare_and_swap_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +00001148 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +00001149 NumFixed = 2;
Chandler Carruth8d13d222010-07-18 20:54:12 +00001150 ResultType = Context.BoolTy;
Chris Lattner5caa3702009-05-08 06:58:22 +00001151 break;
Douglas Gregora9766412011-11-28 16:30:08 +00001152
1153 case Builtin::BI__sync_lock_test_and_set:
1154 case Builtin::BI__sync_lock_test_and_set_1:
1155 case Builtin::BI__sync_lock_test_and_set_2:
1156 case Builtin::BI__sync_lock_test_and_set_4:
1157 case Builtin::BI__sync_lock_test_and_set_8:
1158 case Builtin::BI__sync_lock_test_and_set_16:
1159 BuiltinIndex = 12;
1160 break;
1161
Chris Lattner5caa3702009-05-08 06:58:22 +00001162 case Builtin::BI__sync_lock_release:
Douglas Gregora9766412011-11-28 16:30:08 +00001163 case Builtin::BI__sync_lock_release_1:
1164 case Builtin::BI__sync_lock_release_2:
1165 case Builtin::BI__sync_lock_release_4:
1166 case Builtin::BI__sync_lock_release_8:
1167 case Builtin::BI__sync_lock_release_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +00001168 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +00001169 NumFixed = 0;
Chandler Carruth8d13d222010-07-18 20:54:12 +00001170 ResultType = Context.VoidTy;
Chris Lattner5caa3702009-05-08 06:58:22 +00001171 break;
Douglas Gregora9766412011-11-28 16:30:08 +00001172
1173 case Builtin::BI__sync_swap:
1174 case Builtin::BI__sync_swap_1:
1175 case Builtin::BI__sync_swap_2:
1176 case Builtin::BI__sync_swap_4:
1177 case Builtin::BI__sync_swap_8:
1178 case Builtin::BI__sync_swap_16:
1179 BuiltinIndex = 14;
1180 break;
Chris Lattner5caa3702009-05-08 06:58:22 +00001181 }
Mike Stump1eb44332009-09-09 15:08:12 +00001182
Chris Lattner5caa3702009-05-08 06:58:22 +00001183 // Now that we know how many fixed arguments we expect, first check that we
1184 // have at least that many.
Chandler Carruthd2014572010-07-09 18:59:35 +00001185 if (TheCall->getNumArgs() < 1+NumFixed) {
1186 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
1187 << 0 << 1+NumFixed << TheCall->getNumArgs()
1188 << TheCall->getCallee()->getSourceRange();
1189 return ExprError();
1190 }
Mike Stump1eb44332009-09-09 15:08:12 +00001191
Chris Lattnere7ac0a92009-05-08 15:36:58 +00001192 // Get the decl for the concrete builtin from this, we can tell what the
1193 // concrete integer type we should convert to is.
1194 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
1195 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
1196 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +00001197 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +00001198 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
1199 TUScope, false, DRE->getLocStart()));
Chandler Carruthd2014572010-07-09 18:59:35 +00001200
John McCallf871d0c2010-08-07 06:22:56 +00001201 // The first argument --- the pointer --- has a fixed type; we
1202 // deduce the types of the rest of the arguments accordingly. Walk
1203 // the remaining arguments, converting them to the deduced value type.
Chris Lattner5caa3702009-05-08 06:58:22 +00001204 for (unsigned i = 0; i != NumFixed; ++i) {
John Wiegley429bb272011-04-08 18:41:53 +00001205 ExprResult Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +00001206
Chris Lattner5caa3702009-05-08 06:58:22 +00001207 // GCC does an implicit conversion to the pointer or integer ValType. This
1208 // can fail in some cases (1i -> int**), check for this error case now.
John McCallb45ae252011-10-05 07:41:44 +00001209 // Initialize the argument.
1210 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
1211 ValType, /*consume*/ false);
1212 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
John Wiegley429bb272011-04-08 18:41:53 +00001213 if (Arg.isInvalid())
Chandler Carruthd2014572010-07-09 18:59:35 +00001214 return ExprError();
Mike Stump1eb44332009-09-09 15:08:12 +00001215
Chris Lattner5caa3702009-05-08 06:58:22 +00001216 // Okay, we have something that *can* be converted to the right type. Check
1217 // to see if there is a potentially weird extension going on here. This can
1218 // happen when you do an atomic operation on something like an char* and
1219 // pass in 42. The 42 gets converted to char. This is even more strange
1220 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +00001221 // FIXME: Do this check.
John McCallb45ae252011-10-05 07:41:44 +00001222 TheCall->setArg(i+1, Arg.take());
Chris Lattner5caa3702009-05-08 06:58:22 +00001223 }
Mike Stump1eb44332009-09-09 15:08:12 +00001224
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +00001225 ASTContext& Context = this->getASTContext();
1226
1227 // Create a new DeclRefExpr to refer to the new decl.
1228 DeclRefExpr* NewDRE = DeclRefExpr::Create(
1229 Context,
1230 DRE->getQualifierLoc(),
Abramo Bagnarae4b92762012-01-27 09:46:47 +00001231 SourceLocation(),
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +00001232 NewBuiltinDecl,
John McCallf4b88a42012-03-10 09:33:50 +00001233 /*enclosing*/ false,
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +00001234 DRE->getLocation(),
Eli Friedmana6c66ce2012-08-31 00:14:07 +00001235 Context.BuiltinFnTy,
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +00001236 DRE->getValueKind());
Mike Stump1eb44332009-09-09 15:08:12 +00001237
Chris Lattner5caa3702009-05-08 06:58:22 +00001238 // Set the callee in the CallExpr.
Eli Friedmana6c66ce2012-08-31 00:14:07 +00001239 // FIXME: This loses syntactic information.
1240 QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType());
1241 ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy,
1242 CK_BuiltinFnToFnPtr);
John Wiegley429bb272011-04-08 18:41:53 +00001243 TheCall->setCallee(PromotedCall.take());
Mike Stump1eb44332009-09-09 15:08:12 +00001244
Chandler Carruthdb4325b2010-07-18 07:23:17 +00001245 // Change the result type of the call to match the original value type. This
1246 // is arbitrary, but the codegen for these builtins ins design to handle it
1247 // gracefully.
Chandler Carruth8d13d222010-07-18 20:54:12 +00001248 TheCall->setType(ResultType);
Chandler Carruthd2014572010-07-09 18:59:35 +00001249
Benjamin Kramer3fe198b2012-08-23 21:35:17 +00001250 return TheCallResult;
Chris Lattner5caa3702009-05-08 06:58:22 +00001251}
1252
Chris Lattner69039812009-02-18 06:01:06 +00001253/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +00001254/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +00001255/// Note: It might also make sense to do the UTF-16 conversion here (would
1256/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +00001257bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +00001258 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +00001259 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
1260
Douglas Gregor5cee1192011-07-27 05:40:30 +00001261 if (!Literal || !Literal->isAscii()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001262 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
1263 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +00001264 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +00001265 }
Mike Stump1eb44332009-09-09 15:08:12 +00001266
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001267 if (Literal->containsNonAsciiOrNull()) {
Chris Lattner5f9e2722011-07-23 10:55:15 +00001268 StringRef String = Literal->getString();
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001269 unsigned NumBytes = String.size();
Chris Lattner5f9e2722011-07-23 10:55:15 +00001270 SmallVector<UTF16, 128> ToBuf(NumBytes);
Roman Divacky31ba6132012-09-06 15:59:27 +00001271 const UTF8 *FromPtr = (const UTF8 *)String.data();
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001272 UTF16 *ToPtr = &ToBuf[0];
1273
1274 ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
1275 &ToPtr, ToPtr + NumBytes,
1276 strictConversion);
1277 // Check for conversion failure.
1278 if (Result != conversionOK)
1279 Diag(Arg->getLocStart(),
1280 diag::warn_cfstring_truncated) << Arg->getSourceRange();
1281 }
Anders Carlsson9cdc4d32007-08-17 15:44:17 +00001282 return false;
Chris Lattner59907c42007-08-10 20:18:51 +00001283}
1284
Chris Lattnerc27c6652007-12-20 00:05:45 +00001285/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
1286/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +00001287bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
1288 Expr *Fn = TheCall->getCallee();
1289 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +00001290 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001291 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001292 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1293 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +00001294 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001295 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +00001296 return true;
1297 }
Eli Friedman56f20ae2008-12-15 22:05:35 +00001298
1299 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +00001300 return Diag(TheCall->getLocEnd(),
1301 diag::err_typecheck_call_too_few_args_at_least)
1302 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +00001303 }
1304
John McCall5f8d6042011-08-27 01:09:30 +00001305 // Type-check the first argument normally.
1306 if (checkBuiltinArgument(*this, TheCall, 0))
1307 return true;
1308
Chris Lattnerc27c6652007-12-20 00:05:45 +00001309 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +00001310 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +00001311 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +00001312 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +00001313 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +00001314 else if (FunctionDecl *FD = getCurFunctionDecl())
1315 isVariadic = FD->isVariadic();
1316 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +00001317 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +00001318
Chris Lattnerc27c6652007-12-20 00:05:45 +00001319 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +00001320 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
1321 return true;
1322 }
Mike Stump1eb44332009-09-09 15:08:12 +00001323
Chris Lattner30ce3442007-12-19 23:59:04 +00001324 // Verify that the second argument to the builtin is the last argument of the
1325 // current function or method.
1326 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +00001327 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001328
Anders Carlsson88cf2262008-02-11 04:20:54 +00001329 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
1330 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +00001331 // FIXME: This isn't correct for methods (results in bogus warning).
1332 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +00001333 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +00001334 if (CurBlock)
1335 LastArg = *(CurBlock->TheDecl->param_end()-1);
1336 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +00001337 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +00001338 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +00001339 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +00001340 SecondArgIsLastNamedArgument = PV == LastArg;
1341 }
1342 }
Mike Stump1eb44332009-09-09 15:08:12 +00001343
Chris Lattner30ce3442007-12-19 23:59:04 +00001344 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +00001345 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +00001346 diag::warn_second_parameter_of_va_start_not_last_named_argument);
1347 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +00001348}
Chris Lattner30ce3442007-12-19 23:59:04 +00001349
Chris Lattner1b9a0792007-12-20 00:26:33 +00001350/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
1351/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +00001352bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
1353 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +00001354 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +00001355 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +00001356 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +00001357 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001358 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001359 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001360 << SourceRange(TheCall->getArg(2)->getLocStart(),
1361 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +00001362
John Wiegley429bb272011-04-08 18:41:53 +00001363 ExprResult OrigArg0 = TheCall->getArg(0);
1364 ExprResult OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +00001365
Chris Lattner1b9a0792007-12-20 00:26:33 +00001366 // Do standard promotions between the two arguments, returning their common
1367 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +00001368 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
John Wiegley429bb272011-04-08 18:41:53 +00001369 if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
1370 return true;
Daniel Dunbar403bc2b2009-02-19 19:28:43 +00001371
1372 // Make sure any conversions are pushed back into the call; this is
1373 // type safe since unordered compare builtins are declared as "_Bool
1374 // foo(...)".
John Wiegley429bb272011-04-08 18:41:53 +00001375 TheCall->setArg(0, OrigArg0.get());
1376 TheCall->setArg(1, OrigArg1.get());
Mike Stump1eb44332009-09-09 15:08:12 +00001377
John Wiegley429bb272011-04-08 18:41:53 +00001378 if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
Douglas Gregorcde01732009-05-19 22:10:17 +00001379 return false;
1380
Chris Lattner1b9a0792007-12-20 00:26:33 +00001381 // If the common type isn't a real floating type, then the arguments were
1382 // invalid for this operation.
Eli Friedman860a3192012-06-16 02:19:17 +00001383 if (Res.isNull() || !Res->isRealFloatingType())
John Wiegley429bb272011-04-08 18:41:53 +00001384 return Diag(OrigArg0.get()->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001385 diag::err_typecheck_call_invalid_ordered_compare)
John Wiegley429bb272011-04-08 18:41:53 +00001386 << OrigArg0.get()->getType() << OrigArg1.get()->getType()
1387 << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +00001388
Chris Lattner1b9a0792007-12-20 00:26:33 +00001389 return false;
1390}
1391
Benjamin Kramere771a7a2010-02-15 22:42:31 +00001392/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
1393/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001394/// to check everything. We expect the last argument to be a floating point
1395/// value.
1396bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
1397 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +00001398 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +00001399 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001400 if (TheCall->getNumArgs() > NumArgs)
1401 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001402 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001403 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001404 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001405 (*(TheCall->arg_end()-1))->getLocEnd());
1406
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001407 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +00001408
Eli Friedman9ac6f622009-08-31 20:06:00 +00001409 if (OrigArg->isTypeDependent())
1410 return false;
1411
Chris Lattner81368fb2010-05-06 05:50:07 +00001412 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +00001413 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +00001414 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001415 diag::err_typecheck_call_invalid_unary_fp)
1416 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001417
Chris Lattner81368fb2010-05-06 05:50:07 +00001418 // If this is an implicit conversion from float -> double, remove it.
1419 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
1420 Expr *CastArg = Cast->getSubExpr();
1421 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
1422 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
1423 "promotion from float to double is the only expected cast here");
1424 Cast->setSubExpr(0);
Chris Lattner81368fb2010-05-06 05:50:07 +00001425 TheCall->setArg(NumArgs-1, CastArg);
Chris Lattner81368fb2010-05-06 05:50:07 +00001426 }
1427 }
1428
Eli Friedman9ac6f622009-08-31 20:06:00 +00001429 return false;
1430}
1431
Eli Friedmand38617c2008-05-14 19:38:39 +00001432/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
1433// This is declared to take (...), so we have to check everything.
John McCall60d7b3a2010-08-24 06:29:42 +00001434ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +00001435 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001436 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +00001437 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +00001438 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +00001439 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +00001440
Nate Begeman37b6a572010-06-08 00:16:34 +00001441 // Determine which of the following types of shufflevector we're checking:
1442 // 1) unary, vector mask: (lhs, mask)
1443 // 2) binary, vector mask: (lhs, rhs, mask)
1444 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
1445 QualType resType = TheCall->getArg(0)->getType();
1446 unsigned numElements = 0;
1447
Douglas Gregorcde01732009-05-19 22:10:17 +00001448 if (!TheCall->getArg(0)->isTypeDependent() &&
1449 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +00001450 QualType LHSType = TheCall->getArg(0)->getType();
1451 QualType RHSType = TheCall->getArg(1)->getType();
1452
1453 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001454 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +00001455 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +00001456 TheCall->getArg(1)->getLocEnd());
1457 return ExprError();
1458 }
Nate Begeman37b6a572010-06-08 00:16:34 +00001459
1460 numElements = LHSType->getAs<VectorType>()->getNumElements();
1461 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +00001462
Nate Begeman37b6a572010-06-08 00:16:34 +00001463 // Check to see if we have a call with 2 vector arguments, the unary shuffle
1464 // with mask. If so, verify that RHS is an integer vector type with the
1465 // same number of elts as lhs.
1466 if (TheCall->getNumArgs() == 2) {
Douglas Gregorf6094622010-07-23 15:58:24 +00001467 if (!RHSType->hasIntegerRepresentation() ||
Nate Begeman37b6a572010-06-08 00:16:34 +00001468 RHSType->getAs<VectorType>()->getNumElements() != numElements)
1469 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
1470 << SourceRange(TheCall->getArg(1)->getLocStart(),
1471 TheCall->getArg(1)->getLocEnd());
1472 numResElements = numElements;
1473 }
1474 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001475 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +00001476 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +00001477 TheCall->getArg(1)->getLocEnd());
1478 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +00001479 } else if (numElements != numResElements) {
1480 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
Chris Lattner788b0fd2010-06-23 06:00:24 +00001481 resType = Context.getVectorType(eltType, numResElements,
Bob Wilsone86d78c2010-11-10 21:56:12 +00001482 VectorType::GenericVector);
Douglas Gregorcde01732009-05-19 22:10:17 +00001483 }
Eli Friedmand38617c2008-05-14 19:38:39 +00001484 }
1485
1486 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001487 if (TheCall->getArg(i)->isTypeDependent() ||
1488 TheCall->getArg(i)->isValueDependent())
1489 continue;
1490
Nate Begeman37b6a572010-06-08 00:16:34 +00001491 llvm::APSInt Result(32);
1492 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
1493 return ExprError(Diag(TheCall->getLocStart(),
1494 diag::err_shufflevector_nonconstant_argument)
1495 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +00001496
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +00001497 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001498 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001499 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001500 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +00001501 }
1502
Chris Lattner5f9e2722011-07-23 10:55:15 +00001503 SmallVector<Expr*, 32> exprs;
Eli Friedmand38617c2008-05-14 19:38:39 +00001504
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +00001505 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +00001506 exprs.push_back(TheCall->getArg(i));
1507 TheCall->setArg(i, 0);
1508 }
1509
Benjamin Kramer3b6bef92012-08-24 11:54:20 +00001510 return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +00001511 TheCall->getCallee()->getLocStart(),
1512 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +00001513}
Chris Lattner30ce3442007-12-19 23:59:04 +00001514
Daniel Dunbar4493f792008-07-21 22:59:13 +00001515/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
1516// This is declared to take (const void*, ...) and can take two
1517// optional constant int args.
1518bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001519 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001520
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001521 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +00001522 return Diag(TheCall->getLocEnd(),
1523 diag::err_typecheck_call_too_many_args_at_most)
1524 << 0 /*function call*/ << 3 << NumArgs
1525 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001526
1527 // Argument 0 is checked for us and the remaining arguments must be
1528 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001529 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +00001530 Expr *Arg = TheCall->getArg(i);
Douglas Gregor592a4232012-06-29 01:05:22 +00001531
1532 // We can't check the value of a dependent argument.
1533 if (Arg->isTypeDependent() || Arg->isValueDependent())
1534 continue;
1535
Eli Friedman9aef7262009-12-04 00:30:06 +00001536 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +00001537 if (SemaBuiltinConstantArg(TheCall, i, Result))
1538 return true;
Mike Stump1eb44332009-09-09 15:08:12 +00001539
Daniel Dunbar4493f792008-07-21 22:59:13 +00001540 // FIXME: gcc issues a warning and rewrites these to 0. These
1541 // seems especially odd for the third argument since the default
1542 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001543 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +00001544 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001545 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +00001546 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001547 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +00001548 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001549 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +00001550 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001551 }
1552 }
1553
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001554 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +00001555}
1556
Eric Christopher691ebc32010-04-17 02:26:23 +00001557/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
1558/// TheCall is a constant expression.
1559bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
1560 llvm::APSInt &Result) {
1561 Expr *Arg = TheCall->getArg(ArgNum);
1562 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1563 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1564
1565 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
1566
1567 if (!Arg->isIntegerConstantExpr(Result, Context))
1568 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +00001569 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +00001570
Chris Lattner21fb98e2009-09-23 06:06:36 +00001571 return false;
1572}
1573
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001574/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
1575/// int type). This simply type checks that type is one of the defined
1576/// constants (0-3).
Chris Lattnerfc8f0e12011-04-15 05:22:18 +00001577// For compatibility check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001578bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +00001579 llvm::APSInt Result;
Douglas Gregor592a4232012-06-29 01:05:22 +00001580
1581 // We can't check the value of a dependent argument.
1582 if (TheCall->getArg(1)->isTypeDependent() ||
1583 TheCall->getArg(1)->isValueDependent())
1584 return false;
1585
Eric Christopher691ebc32010-04-17 02:26:23 +00001586 // Check constant-ness first.
1587 if (SemaBuiltinConstantArg(TheCall, 1, Result))
1588 return true;
1589
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001590 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001591 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001592 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
1593 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001594 }
1595
1596 return false;
1597}
1598
Eli Friedman586d6a82009-05-03 06:04:26 +00001599/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +00001600/// This checks that val is a constant 1.
1601bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
1602 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +00001603 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +00001604
Eric Christopher691ebc32010-04-17 02:26:23 +00001605 // TODO: This is less than ideal. Overload this to take a value.
1606 if (SemaBuiltinConstantArg(TheCall, 1, Result))
1607 return true;
1608
1609 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +00001610 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
1611 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1612
1613 return false;
1614}
1615
Richard Smith831421f2012-06-25 20:30:08 +00001616// Determine if an expression is a string literal or constant string.
1617// If this function returns false on the arguments to a function expecting a
1618// format string, we will usually need to emit a warning.
1619// True string literals are then checked by CheckFormatString.
1620Sema::StringLiteralCheckType
1621Sema::checkFormatStringExpr(const Expr *E, Expr **Args,
1622 unsigned NumArgs, bool HasVAListArg,
1623 unsigned format_idx, unsigned firstDataArg,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001624 FormatStringType Type, VariadicCallType CallType,
1625 bool inFunctionCall) {
Ted Kremenek4fe64412010-09-09 03:51:39 +00001626 tryAgain:
Douglas Gregorcde01732009-05-19 22:10:17 +00001627 if (E->isTypeDependent() || E->isValueDependent())
Richard Smith831421f2012-06-25 20:30:08 +00001628 return SLCT_NotALiteral;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001629
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001630 E = E->IgnoreParenCasts();
Peter Collingbournef111d932011-04-15 00:35:48 +00001631
David Blaikiea73cdcb2012-02-10 21:07:25 +00001632 if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull))
1633 // Technically -Wformat-nonliteral does not warn about this case.
1634 // The behavior of printf and friends in this case is implementation
1635 // dependent. Ideally if the format string cannot be null then
1636 // it should have a 'nonnull' attribute in the function prototype.
Richard Smith831421f2012-06-25 20:30:08 +00001637 return SLCT_CheckedLiteral;
David Blaikiea73cdcb2012-02-10 21:07:25 +00001638
Ted Kremenekd30ef872009-01-12 23:09:09 +00001639 switch (E->getStmtClass()) {
John McCall56ca35d2011-02-17 10:25:35 +00001640 case Stmt::BinaryConditionalOperatorClass:
Ted Kremenekd30ef872009-01-12 23:09:09 +00001641 case Stmt::ConditionalOperatorClass: {
Richard Smith831421f2012-06-25 20:30:08 +00001642 // The expression is a literal if both sub-expressions were, and it was
1643 // completely checked only if both sub-expressions were checked.
1644 const AbstractConditionalOperator *C =
1645 cast<AbstractConditionalOperator>(E);
1646 StringLiteralCheckType Left =
1647 checkFormatStringExpr(C->getTrueExpr(), Args, NumArgs,
1648 HasVAListArg, format_idx, firstDataArg,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001649 Type, CallType, inFunctionCall);
Richard Smith831421f2012-06-25 20:30:08 +00001650 if (Left == SLCT_NotALiteral)
1651 return SLCT_NotALiteral;
1652 StringLiteralCheckType Right =
1653 checkFormatStringExpr(C->getFalseExpr(), Args, NumArgs,
1654 HasVAListArg, format_idx, firstDataArg,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001655 Type, CallType, inFunctionCall);
Richard Smith831421f2012-06-25 20:30:08 +00001656 return Left < Right ? Left : Right;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001657 }
1658
1659 case Stmt::ImplicitCastExprClass: {
Ted Kremenek4fe64412010-09-09 03:51:39 +00001660 E = cast<ImplicitCastExpr>(E)->getSubExpr();
1661 goto tryAgain;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001662 }
1663
John McCall56ca35d2011-02-17 10:25:35 +00001664 case Stmt::OpaqueValueExprClass:
1665 if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
1666 E = src;
1667 goto tryAgain;
1668 }
Richard Smith831421f2012-06-25 20:30:08 +00001669 return SLCT_NotALiteral;
John McCall56ca35d2011-02-17 10:25:35 +00001670
Ted Kremenekb43e8ad2011-02-24 23:03:04 +00001671 case Stmt::PredefinedExprClass:
1672 // While __func__, etc., are technically not string literals, they
1673 // cannot contain format specifiers and thus are not a security
1674 // liability.
Richard Smith831421f2012-06-25 20:30:08 +00001675 return SLCT_UncheckedLiteral;
Ted Kremenekb43e8ad2011-02-24 23:03:04 +00001676
Ted Kremenek082d9362009-03-20 21:35:28 +00001677 case Stmt::DeclRefExprClass: {
1678 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001679
Ted Kremenek082d9362009-03-20 21:35:28 +00001680 // As an exception, do not flag errors for variables binding to
1681 // const string literals.
1682 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1683 bool isConstant = false;
1684 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001685
Ted Kremenek082d9362009-03-20 21:35:28 +00001686 if (const ArrayType *AT = Context.getAsArrayType(T)) {
1687 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001688 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +00001689 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +00001690 PT->getPointeeType().isConstant(Context);
Jean-Daniel Dupase98e5b52012-01-25 10:35:33 +00001691 } else if (T->isObjCObjectPointerType()) {
1692 // In ObjC, there is usually no "const ObjectPointer" type,
1693 // so don't check if the pointee type is constant.
1694 isConstant = T.isConstant(Context);
Ted Kremenek082d9362009-03-20 21:35:28 +00001695 }
Mike Stump1eb44332009-09-09 15:08:12 +00001696
Ted Kremenek082d9362009-03-20 21:35:28 +00001697 if (isConstant) {
Matt Beaumont-Gaye2c60662012-05-11 22:10:59 +00001698 if (const Expr *Init = VD->getAnyInitializer()) {
1699 // Look through initializers like const char c[] = { "foo" }
1700 if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) {
1701 if (InitList->isStringLiteralInit())
1702 Init = InitList->getInit(0)->IgnoreParenImpCasts();
1703 }
Richard Smith831421f2012-06-25 20:30:08 +00001704 return checkFormatStringExpr(Init, Args, NumArgs,
1705 HasVAListArg, format_idx,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001706 firstDataArg, Type, CallType,
Richard Smith831421f2012-06-25 20:30:08 +00001707 /*inFunctionCall*/false);
Matt Beaumont-Gaye2c60662012-05-11 22:10:59 +00001708 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001709 }
Mike Stump1eb44332009-09-09 15:08:12 +00001710
Anders Carlssond966a552009-06-28 19:55:58 +00001711 // For vprintf* functions (i.e., HasVAListArg==true), we add a
1712 // special check to see if the format string is a function parameter
1713 // of the function calling the printf function. If the function
1714 // has an attribute indicating it is a printf-like function, then we
1715 // should suppress warnings concerning non-literals being used in a call
1716 // to a vprintf function. For example:
1717 //
1718 // void
1719 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1720 // va_list ap;
1721 // va_start(ap, fmt);
1722 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
1723 // ...
1724 //
Jean-Daniel Dupasf57c4132012-02-21 20:00:53 +00001725 if (HasVAListArg) {
1726 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) {
1727 if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) {
1728 int PVIndex = PV->getFunctionScopeIndex() + 1;
1729 for (specific_attr_iterator<FormatAttr>
1730 i = ND->specific_attr_begin<FormatAttr>(),
1731 e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) {
1732 FormatAttr *PVFormat = *i;
1733 // adjust for implicit parameter
1734 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
1735 if (MD->isInstance())
1736 ++PVIndex;
1737 // We also check if the formats are compatible.
1738 // We can't pass a 'scanf' string to a 'printf' function.
1739 if (PVIndex == PVFormat->getFormatIdx() &&
1740 Type == GetFormatStringType(PVFormat))
Richard Smith831421f2012-06-25 20:30:08 +00001741 return SLCT_UncheckedLiteral;
Jean-Daniel Dupasf57c4132012-02-21 20:00:53 +00001742 }
1743 }
1744 }
1745 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001746 }
Mike Stump1eb44332009-09-09 15:08:12 +00001747
Richard Smith831421f2012-06-25 20:30:08 +00001748 return SLCT_NotALiteral;
Ted Kremenek082d9362009-03-20 21:35:28 +00001749 }
Ted Kremenekd30ef872009-01-12 23:09:09 +00001750
Jean-Daniel Dupas52aabaf2012-02-07 19:01:42 +00001751 case Stmt::CallExprClass:
1752 case Stmt::CXXMemberCallExprClass: {
Anders Carlsson8f031b32009-06-27 04:05:33 +00001753 const CallExpr *CE = cast<CallExpr>(E);
Jean-Daniel Dupas52aabaf2012-02-07 19:01:42 +00001754 if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) {
1755 if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {
1756 unsigned ArgIndex = FA->getFormatIdx();
1757 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
1758 if (MD->isInstance())
1759 --ArgIndex;
1760 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +00001761
Richard Smith831421f2012-06-25 20:30:08 +00001762 return checkFormatStringExpr(Arg, Args, NumArgs,
1763 HasVAListArg, format_idx, firstDataArg,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001764 Type, CallType, inFunctionCall);
Jordan Rose50687312012-06-04 23:52:23 +00001765 } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
1766 unsigned BuiltinID = FD->getBuiltinID();
1767 if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString ||
1768 BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) {
1769 const Expr *Arg = CE->getArg(0);
Richard Smith831421f2012-06-25 20:30:08 +00001770 return checkFormatStringExpr(Arg, Args, NumArgs,
1771 HasVAListArg, format_idx,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001772 firstDataArg, Type, CallType,
1773 inFunctionCall);
Jordan Rose50687312012-06-04 23:52:23 +00001774 }
Anders Carlsson8f031b32009-06-27 04:05:33 +00001775 }
1776 }
Mike Stump1eb44332009-09-09 15:08:12 +00001777
Richard Smith831421f2012-06-25 20:30:08 +00001778 return SLCT_NotALiteral;
Anders Carlsson8f031b32009-06-27 04:05:33 +00001779 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001780 case Stmt::ObjCStringLiteralClass:
1781 case Stmt::StringLiteralClass: {
1782 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001783
Ted Kremenek082d9362009-03-20 21:35:28 +00001784 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +00001785 StrE = ObjCFExpr->getString();
1786 else
Ted Kremenek082d9362009-03-20 21:35:28 +00001787 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001788
Ted Kremenekd30ef872009-01-12 23:09:09 +00001789 if (StrE) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001790 CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001791 firstDataArg, Type, inFunctionCall, CallType);
Richard Smith831421f2012-06-25 20:30:08 +00001792 return SLCT_CheckedLiteral;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001793 }
Mike Stump1eb44332009-09-09 15:08:12 +00001794
Richard Smith831421f2012-06-25 20:30:08 +00001795 return SLCT_NotALiteral;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001796 }
Mike Stump1eb44332009-09-09 15:08:12 +00001797
Ted Kremenek082d9362009-03-20 21:35:28 +00001798 default:
Richard Smith831421f2012-06-25 20:30:08 +00001799 return SLCT_NotALiteral;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001800 }
1801}
1802
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001803void
Mike Stump1eb44332009-09-09 15:08:12 +00001804Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
Nick Lewycky909a70d2011-03-25 01:44:32 +00001805 const Expr * const *ExprArgs,
1806 SourceLocation CallSiteLoc) {
Sean Huntcf807c42010-08-18 23:23:40 +00001807 for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1808 e = NonNull->args_end();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001809 i != e; ++i) {
Nick Lewycky909a70d2011-03-25 01:44:32 +00001810 const Expr *ArgExpr = ExprArgs[*i];
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001811 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +00001812 Expr::NPC_ValueDependentIsNotNull))
Nick Lewycky909a70d2011-03-25 01:44:32 +00001813 Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001814 }
1815}
Ted Kremenekd30ef872009-01-12 23:09:09 +00001816
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001817Sema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
1818 return llvm::StringSwitch<FormatStringType>(Format->getType())
1819 .Case("scanf", FST_Scanf)
1820 .Cases("printf", "printf0", FST_Printf)
1821 .Cases("NSString", "CFString", FST_NSString)
1822 .Case("strftime", FST_Strftime)
1823 .Case("strfmon", FST_Strfmon)
1824 .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
1825 .Default(FST_Unknown);
1826}
1827
Jordan Roseddcfbc92012-07-19 18:10:23 +00001828/// CheckFormatArguments - Check calls to printf and scanf (and similar
Ted Kremenek826a3452010-07-16 02:11:22 +00001829/// functions) for correct use of format strings.
Richard Smith831421f2012-06-25 20:30:08 +00001830/// Returns true if a format string has been fully checked.
Richard Smith831421f2012-06-25 20:30:08 +00001831bool Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001832 unsigned NumArgs, bool IsCXXMember,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001833 VariadicCallType CallType,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001834 SourceLocation Loc, SourceRange Range) {
Richard Smith831421f2012-06-25 20:30:08 +00001835 FormatStringInfo FSI;
1836 if (getFormatStringInfo(Format, IsCXXMember, &FSI))
1837 return CheckFormatArguments(Args, NumArgs, FSI.HasVAListArg, FSI.FormatIdx,
1838 FSI.FirstDataArg, GetFormatStringType(Format),
Jordan Roseddcfbc92012-07-19 18:10:23 +00001839 CallType, Loc, Range);
Richard Smith831421f2012-06-25 20:30:08 +00001840 return false;
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001841}
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001842
Richard Smith831421f2012-06-25 20:30:08 +00001843bool Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001844 bool HasVAListArg, unsigned format_idx,
1845 unsigned firstDataArg, FormatStringType Type,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001846 VariadicCallType CallType,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001847 SourceLocation Loc, SourceRange Range) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001848 // CHECK: printf/scanf-like function is called with no format string.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001849 if (format_idx >= NumArgs) {
1850 Diag(Loc, diag::warn_missing_format_string) << Range;
Richard Smith831421f2012-06-25 20:30:08 +00001851 return false;
Ted Kremenek71895b92007-08-14 17:39:48 +00001852 }
Mike Stump1eb44332009-09-09 15:08:12 +00001853
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001854 const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001855
Chris Lattner59907c42007-08-10 20:18:51 +00001856 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001857 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001858 // Dynamically generated format strings are difficult to
1859 // automatically vet at compile time. Requiring that format strings
1860 // are string literals: (1) permits the checking of format strings by
1861 // the compiler and thereby (2) can practically remove the source of
1862 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001863
Mike Stump1eb44332009-09-09 15:08:12 +00001864 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001865 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001866 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001867 // the same format string checking logic for both ObjC and C strings.
Richard Smith831421f2012-06-25 20:30:08 +00001868 StringLiteralCheckType CT =
1869 checkFormatStringExpr(OrigFormatExpr, Args, NumArgs, HasVAListArg,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001870 format_idx, firstDataArg, Type, CallType);
Richard Smith831421f2012-06-25 20:30:08 +00001871 if (CT != SLCT_NotALiteral)
1872 // Literal format string found, check done!
1873 return CT == SLCT_CheckedLiteral;
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001874
Jean-Daniel Dupas2837a2f2012-02-07 23:10:53 +00001875 // Strftime is particular as it always uses a single 'time' argument,
1876 // so it is safe to pass a non-literal string.
1877 if (Type == FST_Strftime)
Richard Smith831421f2012-06-25 20:30:08 +00001878 return false;
Jean-Daniel Dupas2837a2f2012-02-07 23:10:53 +00001879
Jean-Daniel Dupasce3aa392012-01-30 19:46:17 +00001880 // Do not emit diag when the string param is a macro expansion and the
1881 // format is either NSString or CFString. This is a hack to prevent
1882 // diag when using the NSLocalizedString and CFCopyLocalizedString macros
1883 // which are usually used in place of NS and CF string literals.
Jean-Daniel Dupasdc170202012-05-04 21:08:08 +00001884 if (Type == FST_NSString &&
1885 SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart()))
Richard Smith831421f2012-06-25 20:30:08 +00001886 return false;
Jean-Daniel Dupasce3aa392012-01-30 19:46:17 +00001887
Chris Lattner655f1412009-04-29 04:59:47 +00001888 // If there are no arguments specified, warn with -Wformat-security, otherwise
1889 // warn only with -Wformat-nonliteral.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001890 if (NumArgs == format_idx+1)
1891 Diag(Args[format_idx]->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001892 diag::warn_format_nonliteral_noargs)
Chris Lattner655f1412009-04-29 04:59:47 +00001893 << OrigFormatExpr->getSourceRange();
1894 else
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001895 Diag(Args[format_idx]->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001896 diag::warn_format_nonliteral)
Chris Lattner655f1412009-04-29 04:59:47 +00001897 << OrigFormatExpr->getSourceRange();
Richard Smith831421f2012-06-25 20:30:08 +00001898 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001899}
Ted Kremenek71895b92007-08-14 17:39:48 +00001900
Ted Kremeneke0e53132010-01-28 23:39:18 +00001901namespace {
Ted Kremenek826a3452010-07-16 02:11:22 +00001902class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1903protected:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001904 Sema &S;
1905 const StringLiteral *FExpr;
1906 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001907 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001908 const unsigned NumDataArgs;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001909 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001910 const bool HasVAListArg;
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001911 const Expr * const *Args;
1912 const unsigned NumArgs;
Ted Kremenek0d277352010-01-29 01:06:55 +00001913 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001914 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001915 bool usesPositionalArgs;
1916 bool atFirstArg;
Richard Trieu55733de2011-10-28 00:41:25 +00001917 bool inFunctionCall;
Jordan Roseddcfbc92012-07-19 18:10:23 +00001918 Sema::VariadicCallType CallType;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001919public:
Ted Kremenek826a3452010-07-16 02:11:22 +00001920 CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001921 const Expr *origFormatExpr, unsigned firstDataArg,
Jordan Rose50687312012-06-04 23:52:23 +00001922 unsigned numDataArgs, const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001923 Expr **args, unsigned numArgs,
Jordan Roseddcfbc92012-07-19 18:10:23 +00001924 unsigned formatIdx, bool inFunctionCall,
1925 Sema::VariadicCallType callType)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001926 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Jordan Rose50687312012-06-04 23:52:23 +00001927 FirstDataArg(firstDataArg), NumDataArgs(numDataArgs),
1928 Beg(beg), HasVAListArg(hasVAListArg),
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001929 Args(args), NumArgs(numArgs), FormatIdx(formatIdx),
Richard Trieu55733de2011-10-28 00:41:25 +00001930 usesPositionalArgs(false), atFirstArg(true),
Jordan Roseddcfbc92012-07-19 18:10:23 +00001931 inFunctionCall(inFunctionCall), CallType(callType) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001932 CoveredArgs.resize(numDataArgs);
1933 CoveredArgs.reset();
1934 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001935
Ted Kremenek07d161f2010-01-29 01:50:07 +00001936 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001937
Ted Kremenek826a3452010-07-16 02:11:22 +00001938 void HandleIncompleteSpecifier(const char *startSpecifier,
1939 unsigned specifierLen);
Hans Wennborg76517422012-02-22 10:17:01 +00001940
Jordan Rosebbb6bb42012-09-08 04:00:03 +00001941 void HandleInvalidLengthModifier(
1942 const analyze_format_string::FormatSpecifier &FS,
1943 const analyze_format_string::ConversionSpecifier &CS,
Jordan Rose8be066e2012-09-08 04:00:12 +00001944 const char *startSpecifier, unsigned specifierLen, unsigned DiagID);
Jordan Rosebbb6bb42012-09-08 04:00:03 +00001945
Hans Wennborg76517422012-02-22 10:17:01 +00001946 void HandleNonStandardLengthModifier(
Jordan Rose8be066e2012-09-08 04:00:12 +00001947 const analyze_format_string::FormatSpecifier &FS,
Hans Wennborg76517422012-02-22 10:17:01 +00001948 const char *startSpecifier, unsigned specifierLen);
1949
1950 void HandleNonStandardConversionSpecifier(
1951 const analyze_format_string::ConversionSpecifier &CS,
1952 const char *startSpecifier, unsigned specifierLen);
1953
Hans Wennborgf8562642012-03-09 10:10:54 +00001954 virtual void HandlePosition(const char *startPos, unsigned posLen);
1955
Ted Kremenekefaff192010-02-27 01:41:03 +00001956 virtual void HandleInvalidPosition(const char *startSpecifier,
1957 unsigned specifierLen,
Ted Kremenek826a3452010-07-16 02:11:22 +00001958 analyze_format_string::PositionContext p);
Ted Kremenekefaff192010-02-27 01:41:03 +00001959
1960 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1961
Ted Kremeneke0e53132010-01-28 23:39:18 +00001962 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001963
Richard Trieu55733de2011-10-28 00:41:25 +00001964 template <typename Range>
1965 static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall,
1966 const Expr *ArgumentExpr,
1967 PartialDiagnostic PDiag,
1968 SourceLocation StringLoc,
1969 bool IsStringLocation, Range StringRange,
Jordan Roseec087352012-09-05 22:56:26 +00001970 ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>());
Richard Trieu55733de2011-10-28 00:41:25 +00001971
Ted Kremenek826a3452010-07-16 02:11:22 +00001972protected:
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001973 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
1974 const char *startSpec,
1975 unsigned specifierLen,
1976 const char *csStart, unsigned csLen);
Richard Trieu55733de2011-10-28 00:41:25 +00001977
1978 void HandlePositionalNonpositionalArgs(SourceLocation Loc,
1979 const char *startSpec,
1980 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001981
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001982 SourceRange getFormatStringRange();
Ted Kremenek826a3452010-07-16 02:11:22 +00001983 CharSourceRange getSpecifierRange(const char *startSpecifier,
1984 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001985 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001986
Ted Kremenek0d277352010-01-29 01:06:55 +00001987 const Expr *getDataArg(unsigned i) const;
Ted Kremenek666a1972010-07-26 19:45:42 +00001988
1989 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
1990 const analyze_format_string::ConversionSpecifier &CS,
1991 const char *startSpecifier, unsigned specifierLen,
1992 unsigned argIndex);
Richard Trieu55733de2011-10-28 00:41:25 +00001993
1994 template <typename Range>
1995 void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
1996 bool IsStringLocation, Range StringRange,
Jordan Roseec087352012-09-05 22:56:26 +00001997 ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>());
Richard Trieu55733de2011-10-28 00:41:25 +00001998
1999 void CheckPositionalAndNonpositionalArgs(
2000 const analyze_format_string::FormatSpecifier *FS);
Ted Kremeneke0e53132010-01-28 23:39:18 +00002001};
2002}
2003
Ted Kremenek826a3452010-07-16 02:11:22 +00002004SourceRange CheckFormatHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00002005 return OrigFormatExpr->getSourceRange();
2006}
2007
Ted Kremenek826a3452010-07-16 02:11:22 +00002008CharSourceRange CheckFormatHandler::
2009getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
Tom Care45f9b7e2010-06-21 21:21:01 +00002010 SourceLocation Start = getLocationOfByte(startSpecifier);
2011 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
2012
2013 // Advance the end SourceLocation by one due to half-open ranges.
Argyrios Kyrtzidisa64ccef2011-09-19 20:40:19 +00002014 End = End.getLocWithOffset(1);
Tom Care45f9b7e2010-06-21 21:21:01 +00002015
2016 return CharSourceRange::getCharRange(Start, End);
Ted Kremenekf88c8e02010-01-29 20:55:36 +00002017}
2018
Ted Kremenek826a3452010-07-16 02:11:22 +00002019SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002020 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00002021}
2022
Ted Kremenek826a3452010-07-16 02:11:22 +00002023void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
2024 unsigned specifierLen){
Richard Trieu55733de2011-10-28 00:41:25 +00002025 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
2026 getLocationOfByte(startSpecifier),
2027 /*IsStringLocation*/true,
2028 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek808015a2010-01-29 03:16:21 +00002029}
2030
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002031void CheckFormatHandler::HandleInvalidLengthModifier(
2032 const analyze_format_string::FormatSpecifier &FS,
2033 const analyze_format_string::ConversionSpecifier &CS,
Jordan Rose8be066e2012-09-08 04:00:12 +00002034 const char *startSpecifier, unsigned specifierLen, unsigned DiagID) {
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002035 using namespace analyze_format_string;
2036
2037 const LengthModifier &LM = FS.getLengthModifier();
2038 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
2039
2040 // See if we know how to fix this length modifier.
2041 llvm::Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
2042 if (FixedLM) {
Jordan Rose8be066e2012-09-08 04:00:12 +00002043 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002044 getLocationOfByte(LM.getStart()),
2045 /*IsStringLocation*/true,
2046 getSpecifierRange(startSpecifier, specifierLen));
2047
2048 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
2049 << FixedLM->toString()
2050 << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
2051
2052 } else {
Jordan Rose8be066e2012-09-08 04:00:12 +00002053 FixItHint Hint;
2054 if (DiagID == diag::warn_format_nonsensical_length)
2055 Hint = FixItHint::CreateRemoval(LMRange);
2056
2057 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002058 getLocationOfByte(LM.getStart()),
2059 /*IsStringLocation*/true,
2060 getSpecifierRange(startSpecifier, specifierLen),
Jordan Rose8be066e2012-09-08 04:00:12 +00002061 Hint);
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002062 }
2063}
2064
Hans Wennborg76517422012-02-22 10:17:01 +00002065void CheckFormatHandler::HandleNonStandardLengthModifier(
Jordan Rose8be066e2012-09-08 04:00:12 +00002066 const analyze_format_string::FormatSpecifier &FS,
Hans Wennborg76517422012-02-22 10:17:01 +00002067 const char *startSpecifier, unsigned specifierLen) {
Jordan Rose8be066e2012-09-08 04:00:12 +00002068 using namespace analyze_format_string;
2069
2070 const LengthModifier &LM = FS.getLengthModifier();
2071 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
2072
2073 // See if we know how to fix this length modifier.
2074 llvm::Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
2075 if (FixedLM) {
2076 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
2077 << LM.toString() << 0,
2078 getLocationOfByte(LM.getStart()),
2079 /*IsStringLocation*/true,
2080 getSpecifierRange(startSpecifier, specifierLen));
2081
2082 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
2083 << FixedLM->toString()
2084 << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
2085
2086 } else {
2087 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
2088 << LM.toString() << 0,
2089 getLocationOfByte(LM.getStart()),
2090 /*IsStringLocation*/true,
2091 getSpecifierRange(startSpecifier, specifierLen));
2092 }
Hans Wennborg76517422012-02-22 10:17:01 +00002093}
2094
2095void CheckFormatHandler::HandleNonStandardConversionSpecifier(
2096 const analyze_format_string::ConversionSpecifier &CS,
2097 const char *startSpecifier, unsigned specifierLen) {
Jordan Rose670941c2012-09-13 02:11:15 +00002098 using namespace analyze_format_string;
2099
2100 // See if we know how to fix this conversion specifier.
2101 llvm::Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier();
2102 if (FixedCS) {
2103 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
2104 << CS.toString() << /*conversion specifier*/1,
2105 getLocationOfByte(CS.getStart()),
2106 /*IsStringLocation*/true,
2107 getSpecifierRange(startSpecifier, specifierLen));
2108
2109 CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength());
2110 S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier)
2111 << FixedCS->toString()
2112 << FixItHint::CreateReplacement(CSRange, FixedCS->toString());
2113 } else {
2114 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
2115 << CS.toString() << /*conversion specifier*/1,
2116 getLocationOfByte(CS.getStart()),
2117 /*IsStringLocation*/true,
2118 getSpecifierRange(startSpecifier, specifierLen));
2119 }
Hans Wennborg76517422012-02-22 10:17:01 +00002120}
2121
Hans Wennborgf8562642012-03-09 10:10:54 +00002122void CheckFormatHandler::HandlePosition(const char *startPos,
2123 unsigned posLen) {
2124 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg),
2125 getLocationOfByte(startPos),
2126 /*IsStringLocation*/true,
2127 getSpecifierRange(startPos, posLen));
2128}
2129
Ted Kremenekefaff192010-02-27 01:41:03 +00002130void
Ted Kremenek826a3452010-07-16 02:11:22 +00002131CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
2132 analyze_format_string::PositionContext p) {
Richard Trieu55733de2011-10-28 00:41:25 +00002133 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
2134 << (unsigned) p,
2135 getLocationOfByte(startPos), /*IsStringLocation*/true,
2136 getSpecifierRange(startPos, posLen));
Ted Kremenekefaff192010-02-27 01:41:03 +00002137}
2138
Ted Kremenek826a3452010-07-16 02:11:22 +00002139void CheckFormatHandler::HandleZeroPosition(const char *startPos,
Ted Kremenekefaff192010-02-27 01:41:03 +00002140 unsigned posLen) {
Richard Trieu55733de2011-10-28 00:41:25 +00002141 EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
2142 getLocationOfByte(startPos),
2143 /*IsStringLocation*/true,
2144 getSpecifierRange(startPos, posLen));
Ted Kremenekefaff192010-02-27 01:41:03 +00002145}
2146
Ted Kremenek826a3452010-07-16 02:11:22 +00002147void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
Jordan Rose50687312012-06-04 23:52:23 +00002148 if (!isa<ObjCStringLiteral>(OrigFormatExpr)) {
Ted Kremenek0c069442011-03-15 21:18:48 +00002149 // The presence of a null character is likely an error.
Richard Trieu55733de2011-10-28 00:41:25 +00002150 EmitFormatDiagnostic(
2151 S.PDiag(diag::warn_printf_format_string_contains_null_char),
2152 getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
2153 getFormatStringRange());
Ted Kremenek0c069442011-03-15 21:18:48 +00002154 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002155}
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002156
Jordan Rose48716662012-07-19 18:10:08 +00002157// Note that this may return NULL if there was an error parsing or building
2158// one of the argument expressions.
Ted Kremenek826a3452010-07-16 02:11:22 +00002159const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002160 return Args[FirstDataArg + i];
Ted Kremenek826a3452010-07-16 02:11:22 +00002161}
2162
2163void CheckFormatHandler::DoneProcessing() {
2164 // Does the number of data arguments exceed the number of
2165 // format conversions in the format string?
2166 if (!HasVAListArg) {
2167 // Find any arguments that weren't covered.
2168 CoveredArgs.flip();
2169 signed notCoveredArg = CoveredArgs.find_first();
2170 if (notCoveredArg >= 0) {
2171 assert((unsigned)notCoveredArg < NumDataArgs);
Jordan Rose48716662012-07-19 18:10:08 +00002172 if (const Expr *E = getDataArg((unsigned) notCoveredArg)) {
2173 SourceLocation Loc = E->getLocStart();
2174 if (!S.getSourceManager().isInSystemMacro(Loc)) {
2175 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used),
2176 Loc, /*IsStringLocation*/false,
2177 getFormatStringRange());
2178 }
Bob Wilsonc03f2df2012-05-03 19:47:19 +00002179 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002180 }
2181 }
2182}
2183
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002184bool
2185CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
2186 SourceLocation Loc,
2187 const char *startSpec,
2188 unsigned specifierLen,
2189 const char *csStart,
2190 unsigned csLen) {
2191
2192 bool keepGoing = true;
2193 if (argIndex < NumDataArgs) {
2194 // Consider the argument coverered, even though the specifier doesn't
2195 // make sense.
2196 CoveredArgs.set(argIndex);
2197 }
2198 else {
2199 // If argIndex exceeds the number of data arguments we
2200 // don't issue a warning because that is just a cascade of warnings (and
2201 // they may have intended '%%' anyway). We don't want to continue processing
2202 // the format string after this point, however, as we will like just get
2203 // gibberish when trying to match arguments.
2204 keepGoing = false;
2205 }
2206
Richard Trieu55733de2011-10-28 00:41:25 +00002207 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion)
2208 << StringRef(csStart, csLen),
2209 Loc, /*IsStringLocation*/true,
2210 getSpecifierRange(startSpec, specifierLen));
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002211
2212 return keepGoing;
2213}
2214
Richard Trieu55733de2011-10-28 00:41:25 +00002215void
2216CheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
2217 const char *startSpec,
2218 unsigned specifierLen) {
2219 EmitFormatDiagnostic(
2220 S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
2221 Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
2222}
2223
Ted Kremenek666a1972010-07-26 19:45:42 +00002224bool
2225CheckFormatHandler::CheckNumArgs(
2226 const analyze_format_string::FormatSpecifier &FS,
2227 const analyze_format_string::ConversionSpecifier &CS,
2228 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
2229
2230 if (argIndex >= NumDataArgs) {
Richard Trieu55733de2011-10-28 00:41:25 +00002231 PartialDiagnostic PDiag = FS.usesPositionalArg()
2232 ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
2233 << (argIndex+1) << NumDataArgs)
2234 : S.PDiag(diag::warn_printf_insufficient_data_args);
2235 EmitFormatDiagnostic(
2236 PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
2237 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek666a1972010-07-26 19:45:42 +00002238 return false;
2239 }
2240 return true;
2241}
2242
Richard Trieu55733de2011-10-28 00:41:25 +00002243template<typename Range>
2244void CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
2245 SourceLocation Loc,
2246 bool IsStringLocation,
2247 Range StringRange,
Jordan Roseec087352012-09-05 22:56:26 +00002248 ArrayRef<FixItHint> FixIt) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002249 EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
Richard Trieu55733de2011-10-28 00:41:25 +00002250 Loc, IsStringLocation, StringRange, FixIt);
2251}
2252
2253/// \brief If the format string is not within the funcion call, emit a note
2254/// so that the function call and string are in diagnostic messages.
2255///
Dmitri Gribenko70517ca2012-08-23 17:58:28 +00002256/// \param InFunctionCall if true, the format string is within the function
Richard Trieu55733de2011-10-28 00:41:25 +00002257/// call and only one diagnostic message will be produced. Otherwise, an
2258/// extra note will be emitted pointing to location of the format string.
2259///
2260/// \param ArgumentExpr the expression that is passed as the format string
2261/// argument in the function call. Used for getting locations when two
2262/// diagnostics are emitted.
2263///
2264/// \param PDiag the callee should already have provided any strings for the
2265/// diagnostic message. This function only adds locations and fixits
2266/// to diagnostics.
2267///
2268/// \param Loc primary location for diagnostic. If two diagnostics are
2269/// required, one will be at Loc and a new SourceLocation will be created for
2270/// the other one.
2271///
2272/// \param IsStringLocation if true, Loc points to the format string should be
2273/// used for the note. Otherwise, Loc points to the argument list and will
2274/// be used with PDiag.
2275///
2276/// \param StringRange some or all of the string to highlight. This is
2277/// templated so it can accept either a CharSourceRange or a SourceRange.
2278///
Dmitri Gribenko70517ca2012-08-23 17:58:28 +00002279/// \param FixIt optional fix it hint for the format string.
Richard Trieu55733de2011-10-28 00:41:25 +00002280template<typename Range>
2281void CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall,
2282 const Expr *ArgumentExpr,
2283 PartialDiagnostic PDiag,
2284 SourceLocation Loc,
2285 bool IsStringLocation,
2286 Range StringRange,
Jordan Roseec087352012-09-05 22:56:26 +00002287 ArrayRef<FixItHint> FixIt) {
2288 if (InFunctionCall) {
2289 const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag);
2290 D << StringRange;
2291 for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end();
2292 I != E; ++I) {
2293 D << *I;
2294 }
2295 } else {
Richard Trieu55733de2011-10-28 00:41:25 +00002296 S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
2297 << ArgumentExpr->getSourceRange();
Jordan Roseec087352012-09-05 22:56:26 +00002298
2299 const Sema::SemaDiagnosticBuilder &Note =
2300 S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
2301 diag::note_format_string_defined);
2302
2303 Note << StringRange;
2304 for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end();
2305 I != E; ++I) {
2306 Note << *I;
2307 }
Richard Trieu55733de2011-10-28 00:41:25 +00002308 }
2309}
2310
Ted Kremenek826a3452010-07-16 02:11:22 +00002311//===--- CHECK: Printf format string checking ------------------------------===//
2312
2313namespace {
2314class CheckPrintfHandler : public CheckFormatHandler {
Jordan Rose50687312012-06-04 23:52:23 +00002315 bool ObjCContext;
Ted Kremenek826a3452010-07-16 02:11:22 +00002316public:
2317 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
2318 const Expr *origFormatExpr, unsigned firstDataArg,
Jordan Rose50687312012-06-04 23:52:23 +00002319 unsigned numDataArgs, bool isObjC,
Ted Kremenek826a3452010-07-16 02:11:22 +00002320 const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002321 Expr **Args, unsigned NumArgs,
Jordan Roseddcfbc92012-07-19 18:10:23 +00002322 unsigned formatIdx, bool inFunctionCall,
2323 Sema::VariadicCallType CallType)
Ted Kremenek826a3452010-07-16 02:11:22 +00002324 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
Jordan Rose50687312012-06-04 23:52:23 +00002325 numDataArgs, beg, hasVAListArg, Args, NumArgs,
Jordan Roseddcfbc92012-07-19 18:10:23 +00002326 formatIdx, inFunctionCall, CallType), ObjCContext(isObjC)
2327 {}
2328
Ted Kremenek826a3452010-07-16 02:11:22 +00002329
2330 bool HandleInvalidPrintfConversionSpecifier(
2331 const analyze_printf::PrintfSpecifier &FS,
2332 const char *startSpecifier,
2333 unsigned specifierLen);
2334
2335 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
2336 const char *startSpecifier,
2337 unsigned specifierLen);
Richard Smith831421f2012-06-25 20:30:08 +00002338 bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2339 const char *StartSpecifier,
2340 unsigned SpecifierLen,
2341 const Expr *E);
2342
Ted Kremenek826a3452010-07-16 02:11:22 +00002343 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
2344 const char *startSpecifier, unsigned specifierLen);
2345 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
2346 const analyze_printf::OptionalAmount &Amt,
2347 unsigned type,
2348 const char *startSpecifier, unsigned specifierLen);
2349 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2350 const analyze_printf::OptionalFlag &flag,
2351 const char *startSpecifier, unsigned specifierLen);
2352 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
2353 const analyze_printf::OptionalFlag &ignoredFlag,
2354 const analyze_printf::OptionalFlag &flag,
2355 const char *startSpecifier, unsigned specifierLen);
Hans Wennborgf3749f42012-08-07 08:11:26 +00002356 bool checkForCStrMembers(const analyze_printf::ArgType &AT,
Richard Smith831421f2012-06-25 20:30:08 +00002357 const Expr *E, const CharSourceRange &CSR);
2358
Ted Kremenek826a3452010-07-16 02:11:22 +00002359};
2360}
2361
2362bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
2363 const analyze_printf::PrintfSpecifier &FS,
2364 const char *startSpecifier,
2365 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002366 const analyze_printf::PrintfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002367 FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00002368
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002369 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2370 getLocationOfByte(CS.getStart()),
2371 startSpecifier, specifierLen,
2372 CS.getStart(), CS.getLength());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00002373}
2374
Ted Kremenek826a3452010-07-16 02:11:22 +00002375bool CheckPrintfHandler::HandleAmount(
2376 const analyze_format_string::OptionalAmount &Amt,
2377 unsigned k, const char *startSpecifier,
2378 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00002379
2380 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00002381 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002382 unsigned argIndex = Amt.getArgIndex();
2383 if (argIndex >= NumDataArgs) {
Richard Trieu55733de2011-10-28 00:41:25 +00002384 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
2385 << k,
2386 getLocationOfByte(Amt.getStart()),
2387 /*IsStringLocation*/true,
2388 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek0d277352010-01-29 01:06:55 +00002389 // Don't do any more checking. We will just emit
2390 // spurious errors.
2391 return false;
2392 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002393
Ted Kremenek0d277352010-01-29 01:06:55 +00002394 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00002395 // Although not in conformance with C99, we also allow the argument to be
2396 // an 'unsigned int' as that is a reasonably safe case. GCC also
2397 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002398 CoveredArgs.set(argIndex);
2399 const Expr *Arg = getDataArg(argIndex);
Jordan Rose48716662012-07-19 18:10:08 +00002400 if (!Arg)
2401 return false;
2402
Ted Kremenek0d277352010-01-29 01:06:55 +00002403 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002404
Hans Wennborgf3749f42012-08-07 08:11:26 +00002405 const analyze_printf::ArgType &AT = Amt.getArgType(S.Context);
2406 assert(AT.isValid());
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002407
Hans Wennborgf3749f42012-08-07 08:11:26 +00002408 if (!AT.matchesType(S.Context, T)) {
Richard Trieu55733de2011-10-28 00:41:25 +00002409 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
Hans Wennborgf3749f42012-08-07 08:11:26 +00002410 << k << AT.getRepresentativeTypeName(S.Context)
Richard Trieu55733de2011-10-28 00:41:25 +00002411 << T << Arg->getSourceRange(),
2412 getLocationOfByte(Amt.getStart()),
2413 /*IsStringLocation*/true,
2414 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek0d277352010-01-29 01:06:55 +00002415 // Don't do any more checking. We will just emit
2416 // spurious errors.
2417 return false;
2418 }
2419 }
2420 }
2421 return true;
2422}
Ted Kremenek0d277352010-01-29 01:06:55 +00002423
Tom Caree4ee9662010-06-17 19:00:27 +00002424void CheckPrintfHandler::HandleInvalidAmount(
Ted Kremenek826a3452010-07-16 02:11:22 +00002425 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00002426 const analyze_printf::OptionalAmount &Amt,
2427 unsigned type,
2428 const char *startSpecifier,
2429 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002430 const analyze_printf::PrintfConversionSpecifier &CS =
2431 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00002432
Richard Trieu55733de2011-10-28 00:41:25 +00002433 FixItHint fixit =
2434 Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
2435 ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
2436 Amt.getConstantLength()))
2437 : FixItHint();
2438
2439 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
2440 << type << CS.toString(),
2441 getLocationOfByte(Amt.getStart()),
2442 /*IsStringLocation*/true,
2443 getSpecifierRange(startSpecifier, specifierLen),
2444 fixit);
Tom Caree4ee9662010-06-17 19:00:27 +00002445}
2446
Ted Kremenek826a3452010-07-16 02:11:22 +00002447void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00002448 const analyze_printf::OptionalFlag &flag,
2449 const char *startSpecifier,
2450 unsigned specifierLen) {
2451 // Warn about pointless flag with a fixit removal.
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002452 const analyze_printf::PrintfConversionSpecifier &CS =
2453 FS.getConversionSpecifier();
Richard Trieu55733de2011-10-28 00:41:25 +00002454 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
2455 << flag.toString() << CS.toString(),
2456 getLocationOfByte(flag.getPosition()),
2457 /*IsStringLocation*/true,
2458 getSpecifierRange(startSpecifier, specifierLen),
2459 FixItHint::CreateRemoval(
2460 getSpecifierRange(flag.getPosition(), 1)));
Tom Caree4ee9662010-06-17 19:00:27 +00002461}
2462
2463void CheckPrintfHandler::HandleIgnoredFlag(
Ted Kremenek826a3452010-07-16 02:11:22 +00002464 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00002465 const analyze_printf::OptionalFlag &ignoredFlag,
2466 const analyze_printf::OptionalFlag &flag,
2467 const char *startSpecifier,
2468 unsigned specifierLen) {
2469 // Warn about ignored flag with a fixit removal.
Richard Trieu55733de2011-10-28 00:41:25 +00002470 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
2471 << ignoredFlag.toString() << flag.toString(),
2472 getLocationOfByte(ignoredFlag.getPosition()),
2473 /*IsStringLocation*/true,
2474 getSpecifierRange(startSpecifier, specifierLen),
2475 FixItHint::CreateRemoval(
2476 getSpecifierRange(ignoredFlag.getPosition(), 1)));
Tom Caree4ee9662010-06-17 19:00:27 +00002477}
2478
Richard Smith831421f2012-06-25 20:30:08 +00002479// Determines if the specified is a C++ class or struct containing
2480// a member with the specified name and kind (e.g. a CXXMethodDecl named
2481// "c_str()").
2482template<typename MemberKind>
2483static llvm::SmallPtrSet<MemberKind*, 1>
2484CXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) {
2485 const RecordType *RT = Ty->getAs<RecordType>();
2486 llvm::SmallPtrSet<MemberKind*, 1> Results;
2487
2488 if (!RT)
2489 return Results;
2490 const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl());
2491 if (!RD)
2492 return Results;
2493
2494 LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(),
2495 Sema::LookupMemberName);
2496
2497 // We just need to include all members of the right kind turned up by the
2498 // filter, at this point.
2499 if (S.LookupQualifiedName(R, RT->getDecl()))
2500 for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
2501 NamedDecl *decl = (*I)->getUnderlyingDecl();
2502 if (MemberKind *FK = dyn_cast<MemberKind>(decl))
2503 Results.insert(FK);
2504 }
2505 return Results;
2506}
2507
2508// Check if a (w)string was passed when a (w)char* was needed, and offer a
Hans Wennborgf3749f42012-08-07 08:11:26 +00002509// better diagnostic if so. AT is assumed to be valid.
Richard Smith831421f2012-06-25 20:30:08 +00002510// Returns true when a c_str() conversion method is found.
2511bool CheckPrintfHandler::checkForCStrMembers(
Hans Wennborgf3749f42012-08-07 08:11:26 +00002512 const analyze_printf::ArgType &AT, const Expr *E,
Richard Smith831421f2012-06-25 20:30:08 +00002513 const CharSourceRange &CSR) {
2514 typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
2515
2516 MethodSet Results =
2517 CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType());
2518
2519 for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
2520 MI != ME; ++MI) {
2521 const CXXMethodDecl *Method = *MI;
2522 if (Method->getNumParams() == 0 &&
Hans Wennborgf3749f42012-08-07 08:11:26 +00002523 AT.matchesType(S.Context, Method->getResultType())) {
Richard Smith831421f2012-06-25 20:30:08 +00002524 // FIXME: Suggest parens if the expression needs them.
2525 SourceLocation EndLoc =
2526 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd());
2527 S.Diag(E->getLocStart(), diag::note_printf_c_str)
2528 << "c_str()"
2529 << FixItHint::CreateInsertion(EndLoc, ".c_str()");
2530 return true;
2531 }
2532 }
2533
2534 return false;
2535}
2536
Ted Kremeneke0e53132010-01-28 23:39:18 +00002537bool
Ted Kremenek826a3452010-07-16 02:11:22 +00002538CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
Ted Kremenek5c41ee82010-02-11 09:27:41 +00002539 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00002540 const char *startSpecifier,
2541 unsigned specifierLen) {
2542
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002543 using namespace analyze_format_string;
Ted Kremenekefaff192010-02-27 01:41:03 +00002544 using namespace analyze_printf;
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002545 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremeneke0e53132010-01-28 23:39:18 +00002546
Ted Kremenekbaa40062010-07-19 22:01:06 +00002547 if (FS.consumesDataArgument()) {
2548 if (atFirstArg) {
2549 atFirstArg = false;
2550 usesPositionalArgs = FS.usesPositionalArg();
2551 }
2552 else if (usesPositionalArgs != FS.usesPositionalArg()) {
Richard Trieu55733de2011-10-28 00:41:25 +00002553 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
2554 startSpecifier, specifierLen);
Ted Kremenekbaa40062010-07-19 22:01:06 +00002555 return false;
2556 }
Ted Kremenek0d277352010-01-29 01:06:55 +00002557 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002558
Ted Kremenekefaff192010-02-27 01:41:03 +00002559 // First check if the field width, precision, and conversion specifier
2560 // have matching data arguments.
2561 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
2562 startSpecifier, specifierLen)) {
2563 return false;
2564 }
2565
2566 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
2567 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00002568 return false;
2569 }
2570
Ted Kremenekf88c8e02010-01-29 20:55:36 +00002571 if (!CS.consumesDataArgument()) {
2572 // FIXME: Technically specifying a precision or field width here
2573 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00002574 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00002575 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002576
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002577 // Consume the argument.
2578 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00002579 if (argIndex < NumDataArgs) {
2580 // The check to see if the argIndex is valid will come later.
2581 // We set the bit here because we may exit early from this
2582 // function if we encounter some other error.
2583 CoveredArgs.set(argIndex);
2584 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002585
2586 // Check for using an Objective-C specific conversion specifier
2587 // in a non-ObjC literal.
Jordan Rose50687312012-06-04 23:52:23 +00002588 if (!ObjCContext && CS.isObjCArg()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002589 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
2590 specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002591 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002592
Tom Caree4ee9662010-06-17 19:00:27 +00002593 // Check for invalid use of field width
2594 if (!FS.hasValidFieldWidth()) {
Tom Care45f9b7e2010-06-21 21:21:01 +00002595 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
Tom Caree4ee9662010-06-17 19:00:27 +00002596 startSpecifier, specifierLen);
2597 }
2598
2599 // Check for invalid use of precision
2600 if (!FS.hasValidPrecision()) {
2601 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
2602 startSpecifier, specifierLen);
2603 }
2604
2605 // Check each flag does not conflict with any other component.
Ted Kremenek65197b42011-01-08 05:28:46 +00002606 if (!FS.hasValidThousandsGroupingPrefix())
2607 HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002608 if (!FS.hasValidLeadingZeros())
2609 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
2610 if (!FS.hasValidPlusPrefix())
2611 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
Tom Care45f9b7e2010-06-21 21:21:01 +00002612 if (!FS.hasValidSpacePrefix())
2613 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002614 if (!FS.hasValidAlternativeForm())
2615 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
2616 if (!FS.hasValidLeftJustified())
2617 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
2618
2619 // Check that flags are not ignored by another flag
Tom Care45f9b7e2010-06-21 21:21:01 +00002620 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
2621 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
2622 startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002623 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
2624 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
2625 startSpecifier, specifierLen);
2626
2627 // Check the length modifier is valid with the given conversion specifier.
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002628 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
Jordan Rose8be066e2012-09-08 04:00:12 +00002629 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
2630 diag::warn_format_nonsensical_length);
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002631 else if (!FS.hasStandardLengthModifier())
Jordan Rose8be066e2012-09-08 04:00:12 +00002632 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002633 else if (!FS.hasStandardLengthConversionCombination())
Jordan Rose8be066e2012-09-08 04:00:12 +00002634 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
2635 diag::warn_format_non_standard_conversion_spec);
Tom Caree4ee9662010-06-17 19:00:27 +00002636
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002637 if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
2638 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2639
Ted Kremenekda51f0d2010-01-29 01:43:31 +00002640 // The remaining checks depend on the data arguments.
2641 if (HasVAListArg)
2642 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002643
Ted Kremenek666a1972010-07-26 19:45:42 +00002644 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenekda51f0d2010-01-29 01:43:31 +00002645 return false;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002646
Jordan Rose48716662012-07-19 18:10:08 +00002647 const Expr *Arg = getDataArg(argIndex);
2648 if (!Arg)
2649 return true;
2650
2651 return checkFormatExpr(FS, startSpecifier, specifierLen, Arg);
Richard Smith831421f2012-06-25 20:30:08 +00002652}
2653
Jordan Roseec087352012-09-05 22:56:26 +00002654static bool requiresParensToAddCast(const Expr *E) {
2655 // FIXME: We should have a general way to reason about operator
2656 // precedence and whether parens are actually needed here.
2657 // Take care of a few common cases where they aren't.
2658 const Expr *Inside = E->IgnoreImpCasts();
2659 if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside))
2660 Inside = POE->getSyntacticForm()->IgnoreImpCasts();
2661
2662 switch (Inside->getStmtClass()) {
2663 case Stmt::ArraySubscriptExprClass:
2664 case Stmt::CallExprClass:
2665 case Stmt::DeclRefExprClass:
2666 case Stmt::MemberExprClass:
2667 case Stmt::ObjCIvarRefExprClass:
2668 case Stmt::ObjCMessageExprClass:
2669 case Stmt::ObjCPropertyRefExprClass:
2670 case Stmt::ParenExprClass:
2671 case Stmt::UnaryOperatorClass:
2672 return false;
2673 default:
2674 return true;
2675 }
2676}
2677
Richard Smith831421f2012-06-25 20:30:08 +00002678bool
2679CheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2680 const char *StartSpecifier,
2681 unsigned SpecifierLen,
2682 const Expr *E) {
2683 using namespace analyze_format_string;
2684 using namespace analyze_printf;
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002685 // Now type check the data expression that matches the
2686 // format specifier.
Hans Wennborgf3749f42012-08-07 08:11:26 +00002687 const analyze_printf::ArgType &AT = FS.getArgType(S.Context,
2688 ObjCContext);
Jordan Rose614a8652012-09-05 22:56:19 +00002689 if (!AT.isValid())
2690 return true;
Jordan Roseec087352012-09-05 22:56:26 +00002691
2692 QualType IntendedTy = E->getType();
2693 if (AT.matchesType(S.Context, IntendedTy))
Jordan Rose614a8652012-09-05 22:56:19 +00002694 return true;
Jordan Roseee0259d2012-06-04 22:48:57 +00002695
Jordan Rose614a8652012-09-05 22:56:19 +00002696 // Look through argument promotions for our error message's reported type.
2697 // This includes the integral and floating promotions, but excludes array
2698 // and function pointer decay; seeing that an argument intended to be a
2699 // string has type 'char [6]' is probably more confusing than 'char *'.
2700 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
2701 if (ICE->getCastKind() == CK_IntegralCast ||
2702 ICE->getCastKind() == CK_FloatingCast) {
2703 E = ICE->getSubExpr();
Jordan Roseec087352012-09-05 22:56:26 +00002704 IntendedTy = E->getType();
Jordan Rose614a8652012-09-05 22:56:19 +00002705
2706 // Check if we didn't match because of an implicit cast from a 'char'
2707 // or 'short' to an 'int'. This is done because printf is a varargs
2708 // function.
2709 if (ICE->getType() == S.Context.IntTy ||
2710 ICE->getType() == S.Context.UnsignedIntTy) {
2711 // All further checking is done on the subexpression.
Jordan Roseec087352012-09-05 22:56:26 +00002712 if (AT.matchesType(S.Context, IntendedTy))
Jordan Rose614a8652012-09-05 22:56:19 +00002713 return true;
Ted Kremenek4d8ae4d2010-10-21 04:00:58 +00002714 }
Jordan Roseee0259d2012-06-04 22:48:57 +00002715 }
Jordan Rose614a8652012-09-05 22:56:19 +00002716 }
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002717
Jordan Roseec087352012-09-05 22:56:26 +00002718 if (S.Context.getTargetInfo().getTriple().isOSDarwin()) {
2719 // Special-case some of Darwin's platform-independence types.
2720 if (const TypedefType *UserTy = IntendedTy->getAs<TypedefType>()) {
2721 StringRef Name = UserTy->getDecl()->getName();
2722 IntendedTy = llvm::StringSwitch<QualType>(Name)
2723 .Case("NSInteger", S.Context.LongTy)
2724 .Case("NSUInteger", S.Context.UnsignedLongTy)
2725 .Case("SInt32", S.Context.IntTy)
2726 .Case("UInt32", S.Context.UnsignedIntTy)
2727 .Default(IntendedTy);
2728 }
2729 }
2730
Jordan Rose614a8652012-09-05 22:56:19 +00002731 // We may be able to offer a FixItHint if it is a supported type.
2732 PrintfSpecifier fixedFS = FS;
Jordan Roseec087352012-09-05 22:56:26 +00002733 bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(),
Jordan Rose614a8652012-09-05 22:56:19 +00002734 S.Context, ObjCContext);
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002735
Jordan Rose614a8652012-09-05 22:56:19 +00002736 if (success) {
2737 // Get the fix string from the fixed format specifier
2738 SmallString<16> buf;
2739 llvm::raw_svector_ostream os(buf);
2740 fixedFS.toString(os);
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002741
Jordan Roseec087352012-09-05 22:56:26 +00002742 CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen);
2743
2744 if (IntendedTy != E->getType()) {
2745 // The canonical type for formatting this value is different from the
2746 // actual type of the expression. (This occurs, for example, with Darwin's
2747 // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but
2748 // should be printed as 'long' for 64-bit compatibility.)
2749 // Rather than emitting a normal format/argument mismatch, we want to
2750 // add a cast to the recommended type (and correct the format string
2751 // if necessary).
2752 SmallString<16> CastBuf;
2753 llvm::raw_svector_ostream CastFix(CastBuf);
2754 CastFix << "(";
2755 IntendedTy.print(CastFix, S.Context.getPrintingPolicy());
2756 CastFix << ")";
2757
2758 SmallVector<FixItHint,4> Hints;
2759 if (!AT.matchesType(S.Context, IntendedTy))
2760 Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str()));
2761
2762 if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) {
2763 // If there's already a cast present, just replace it.
2764 SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc());
2765 Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str()));
2766
2767 } else if (!requiresParensToAddCast(E)) {
2768 // If the expression has high enough precedence,
2769 // just write the C-style cast.
2770 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
2771 CastFix.str()));
2772 } else {
2773 // Otherwise, add parens around the expression as well as the cast.
2774 CastFix << "(";
2775 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
2776 CastFix.str()));
2777
2778 SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd());
2779 Hints.push_back(FixItHint::CreateInsertion(After, ")"));
2780 }
2781
2782 // We extract the name from the typedef because we don't want to show
2783 // the underlying type in the diagnostic.
2784 const TypedefType *UserTy = cast<TypedefType>(E->getType());
2785 StringRef Name = UserTy->getDecl()->getName();
2786
2787 // Finally, emit the diagnostic.
2788 EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast)
2789 << Name << IntendedTy
2790 << E->getSourceRange(),
2791 E->getLocStart(), /*IsStringLocation=*/false,
2792 SpecRange, Hints);
2793 } else {
2794 EmitFormatDiagnostic(
2795 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2796 << AT.getRepresentativeTypeName(S.Context) << IntendedTy
2797 << E->getSourceRange(),
2798 E->getLocStart(),
2799 /*IsStringLocation*/false,
2800 SpecRange,
2801 FixItHint::CreateReplacement(SpecRange, os.str()));
2802 }
Jordan Rose614a8652012-09-05 22:56:19 +00002803 } else {
2804 const CharSourceRange &CSR = getSpecifierRange(StartSpecifier,
2805 SpecifierLen);
2806 // Since the warning for passing non-POD types to variadic functions
2807 // was deferred until now, we emit a warning for non-POD
2808 // arguments here.
2809 if (S.isValidVarArgType(E->getType()) == Sema::VAK_Invalid) {
2810 unsigned DiagKind;
2811 if (E->getType()->isObjCObjectType())
2812 DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format;
2813 else
2814 DiagKind = diag::warn_non_pod_vararg_with_format_string;
2815
2816 EmitFormatDiagnostic(
2817 S.PDiag(DiagKind)
2818 << S.getLangOpts().CPlusPlus0x
2819 << E->getType()
2820 << CallType
2821 << AT.getRepresentativeTypeName(S.Context)
2822 << CSR
2823 << E->getSourceRange(),
2824 E->getLocStart(), /*IsStringLocation*/false, CSR);
2825
2826 checkForCStrMembers(AT, E, CSR);
2827 } else
Richard Trieu55733de2011-10-28 00:41:25 +00002828 EmitFormatDiagnostic(
2829 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
Hans Wennborgf3749f42012-08-07 08:11:26 +00002830 << AT.getRepresentativeTypeName(S.Context) << E->getType()
Jordan Rose614a8652012-09-05 22:56:19 +00002831 << CSR
Richard Smith831421f2012-06-25 20:30:08 +00002832 << E->getSourceRange(),
Jordan Rose614a8652012-09-05 22:56:19 +00002833 E->getLocStart(), /*IsStringLocation*/false, CSR);
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002834 }
2835
Ted Kremeneke0e53132010-01-28 23:39:18 +00002836 return true;
2837}
2838
Ted Kremenek826a3452010-07-16 02:11:22 +00002839//===--- CHECK: Scanf format string checking ------------------------------===//
2840
2841namespace {
2842class CheckScanfHandler : public CheckFormatHandler {
2843public:
2844 CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
2845 const Expr *origFormatExpr, unsigned firstDataArg,
Jordan Rose50687312012-06-04 23:52:23 +00002846 unsigned numDataArgs, const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002847 Expr **Args, unsigned NumArgs,
Jordan Roseddcfbc92012-07-19 18:10:23 +00002848 unsigned formatIdx, bool inFunctionCall,
2849 Sema::VariadicCallType CallType)
Ted Kremenek826a3452010-07-16 02:11:22 +00002850 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
Jordan Rose50687312012-06-04 23:52:23 +00002851 numDataArgs, beg, hasVAListArg,
Jordan Roseddcfbc92012-07-19 18:10:23 +00002852 Args, NumArgs, formatIdx, inFunctionCall, CallType)
2853 {}
Ted Kremenek826a3452010-07-16 02:11:22 +00002854
2855 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
2856 const char *startSpecifier,
2857 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002858
2859 bool HandleInvalidScanfConversionSpecifier(
2860 const analyze_scanf::ScanfSpecifier &FS,
2861 const char *startSpecifier,
2862 unsigned specifierLen);
Ted Kremenekb7c21012010-07-16 18:28:03 +00002863
2864 void HandleIncompleteScanList(const char *start, const char *end);
Ted Kremenek826a3452010-07-16 02:11:22 +00002865};
Ted Kremenek07d161f2010-01-29 01:50:07 +00002866}
Ted Kremeneke0e53132010-01-28 23:39:18 +00002867
Ted Kremenekb7c21012010-07-16 18:28:03 +00002868void CheckScanfHandler::HandleIncompleteScanList(const char *start,
2869 const char *end) {
Richard Trieu55733de2011-10-28 00:41:25 +00002870 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
2871 getLocationOfByte(end), /*IsStringLocation*/true,
2872 getSpecifierRange(start, end - start));
Ted Kremenekb7c21012010-07-16 18:28:03 +00002873}
2874
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002875bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
2876 const analyze_scanf::ScanfSpecifier &FS,
2877 const char *startSpecifier,
2878 unsigned specifierLen) {
2879
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002880 const analyze_scanf::ScanfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002881 FS.getConversionSpecifier();
2882
2883 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2884 getLocationOfByte(CS.getStart()),
2885 startSpecifier, specifierLen,
2886 CS.getStart(), CS.getLength());
2887}
2888
Ted Kremenek826a3452010-07-16 02:11:22 +00002889bool CheckScanfHandler::HandleScanfSpecifier(
2890 const analyze_scanf::ScanfSpecifier &FS,
2891 const char *startSpecifier,
2892 unsigned specifierLen) {
2893
2894 using namespace analyze_scanf;
2895 using namespace analyze_format_string;
2896
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002897 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00002898
Ted Kremenekbaa40062010-07-19 22:01:06 +00002899 // Handle case where '%' and '*' don't consume an argument. These shouldn't
2900 // be used to decide if we are using positional arguments consistently.
2901 if (FS.consumesDataArgument()) {
2902 if (atFirstArg) {
2903 atFirstArg = false;
2904 usesPositionalArgs = FS.usesPositionalArg();
2905 }
2906 else if (usesPositionalArgs != FS.usesPositionalArg()) {
Richard Trieu55733de2011-10-28 00:41:25 +00002907 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
2908 startSpecifier, specifierLen);
Ted Kremenekbaa40062010-07-19 22:01:06 +00002909 return false;
2910 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002911 }
2912
2913 // Check if the field with is non-zero.
2914 const OptionalAmount &Amt = FS.getFieldWidth();
2915 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
2916 if (Amt.getConstantAmount() == 0) {
2917 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
2918 Amt.getConstantLength());
Richard Trieu55733de2011-10-28 00:41:25 +00002919 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
2920 getLocationOfByte(Amt.getStart()),
2921 /*IsStringLocation*/true, R,
2922 FixItHint::CreateRemoval(R));
Ted Kremenek826a3452010-07-16 02:11:22 +00002923 }
2924 }
2925
2926 if (!FS.consumesDataArgument()) {
2927 // FIXME: Technically specifying a precision or field width here
2928 // makes no sense. Worth issuing a warning at some point.
2929 return true;
2930 }
2931
2932 // Consume the argument.
2933 unsigned argIndex = FS.getArgIndex();
2934 if (argIndex < NumDataArgs) {
2935 // The check to see if the argIndex is valid will come later.
2936 // We set the bit here because we may exit early from this
2937 // function if we encounter some other error.
2938 CoveredArgs.set(argIndex);
2939 }
2940
Ted Kremenek1e51c202010-07-20 20:04:47 +00002941 // Check the length modifier is valid with the given conversion specifier.
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002942 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
Jordan Rose8be066e2012-09-08 04:00:12 +00002943 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
2944 diag::warn_format_nonsensical_length);
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002945 else if (!FS.hasStandardLengthModifier())
Jordan Rose8be066e2012-09-08 04:00:12 +00002946 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002947 else if (!FS.hasStandardLengthConversionCombination())
Jordan Rose8be066e2012-09-08 04:00:12 +00002948 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
2949 diag::warn_format_non_standard_conversion_spec);
Hans Wennborg76517422012-02-22 10:17:01 +00002950
Jordan Rosebbb6bb42012-09-08 04:00:03 +00002951 if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
2952 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2953
Ted Kremenek826a3452010-07-16 02:11:22 +00002954 // The remaining checks depend on the data arguments.
2955 if (HasVAListArg)
2956 return true;
2957
Ted Kremenek666a1972010-07-26 19:45:42 +00002958 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenek826a3452010-07-16 02:11:22 +00002959 return false;
Ted Kremenek826a3452010-07-16 02:11:22 +00002960
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002961 // Check that the argument type matches the format specifier.
2962 const Expr *Ex = getDataArg(argIndex);
Jordan Rose48716662012-07-19 18:10:08 +00002963 if (!Ex)
2964 return true;
2965
Hans Wennborg58e1e542012-08-07 08:59:46 +00002966 const analyze_format_string::ArgType &AT = FS.getArgType(S.Context);
2967 if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) {
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002968 ScanfSpecifier fixedFS = FS;
David Blaikie4e4d0842012-03-11 07:00:24 +00002969 bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(),
Hans Wennborgbe6126a2012-02-15 09:59:46 +00002970 S.Context);
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002971
2972 if (success) {
2973 // Get the fix string from the fixed format specifier.
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00002974 SmallString<128> buf;
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002975 llvm::raw_svector_ostream os(buf);
2976 fixedFS.toString(os);
2977
2978 EmitFormatDiagnostic(
2979 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
Hans Wennborg58e1e542012-08-07 08:59:46 +00002980 << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002981 << Ex->getSourceRange(),
Matt Beaumont-Gayabf145a2012-05-17 00:03:16 +00002982 Ex->getLocStart(),
2983 /*IsStringLocation*/false,
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002984 getSpecifierRange(startSpecifier, specifierLen),
2985 FixItHint::CreateReplacement(
2986 getSpecifierRange(startSpecifier, specifierLen),
2987 os.str()));
2988 } else {
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002989 EmitFormatDiagnostic(
2990 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
Hans Wennborg58e1e542012-08-07 08:59:46 +00002991 << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002992 << Ex->getSourceRange(),
Matt Beaumont-Gayabf145a2012-05-17 00:03:16 +00002993 Ex->getLocStart(),
2994 /*IsStringLocation*/false,
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002995 getSpecifierRange(startSpecifier, specifierLen));
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002996 }
2997 }
2998
Ted Kremenek826a3452010-07-16 02:11:22 +00002999 return true;
3000}
3001
3002void Sema::CheckFormatString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00003003 const Expr *OrigFormatExpr,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00003004 Expr **Args, unsigned NumArgs,
3005 bool HasVAListArg, unsigned format_idx,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00003006 unsigned firstDataArg, FormatStringType Type,
Jordan Roseddcfbc92012-07-19 18:10:23 +00003007 bool inFunctionCall, VariadicCallType CallType) {
Ted Kremenek826a3452010-07-16 02:11:22 +00003008
Ted Kremeneke0e53132010-01-28 23:39:18 +00003009 // CHECK: is the format string a wide literal?
Richard Smithdf9ef1b2012-06-13 05:37:23 +00003010 if (!FExpr->isAscii() && !FExpr->isUTF8()) {
Richard Trieu55733de2011-10-28 00:41:25 +00003011 CheckFormatHandler::EmitFormatDiagnostic(
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00003012 *this, inFunctionCall, Args[format_idx],
Richard Trieu55733de2011-10-28 00:41:25 +00003013 PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
3014 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
Ted Kremeneke0e53132010-01-28 23:39:18 +00003015 return;
3016 }
Ted Kremenek826a3452010-07-16 02:11:22 +00003017
Ted Kremeneke0e53132010-01-28 23:39:18 +00003018 // Str - The format string. NOTE: this is NOT null-terminated!
Chris Lattner5f9e2722011-07-23 10:55:15 +00003019 StringRef StrRef = FExpr->getString();
Benjamin Kramer2f4eaef2010-08-17 12:54:38 +00003020 const char *Str = StrRef.data();
3021 unsigned StrLen = StrRef.size();
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00003022 const unsigned numDataArgs = NumArgs - firstDataArg;
Ted Kremenek826a3452010-07-16 02:11:22 +00003023
Ted Kremeneke0e53132010-01-28 23:39:18 +00003024 // CHECK: empty format string?
Ted Kremenek4cd57912011-09-29 05:52:16 +00003025 if (StrLen == 0 && numDataArgs > 0) {
Richard Trieu55733de2011-10-28 00:41:25 +00003026 CheckFormatHandler::EmitFormatDiagnostic(
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00003027 *this, inFunctionCall, Args[format_idx],
Richard Trieu55733de2011-10-28 00:41:25 +00003028 PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
3029 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
Ted Kremeneke0e53132010-01-28 23:39:18 +00003030 return;
3031 }
Ted Kremenek826a3452010-07-16 02:11:22 +00003032
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00003033 if (Type == FST_Printf || Type == FST_NSString) {
Ted Kremenek826a3452010-07-16 02:11:22 +00003034 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
Jordan Rose50687312012-06-04 23:52:23 +00003035 numDataArgs, (Type == FST_NSString),
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00003036 Str, HasVAListArg, Args, NumArgs, format_idx,
Jordan Roseddcfbc92012-07-19 18:10:23 +00003037 inFunctionCall, CallType);
Ted Kremenek826a3452010-07-16 02:11:22 +00003038
Hans Wennborgd02deeb2011-12-15 10:25:47 +00003039 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
Jordan Rose275b6f52012-09-13 02:11:03 +00003040 getLangOpts(),
3041 Context.getTargetInfo()))
Ted Kremenek826a3452010-07-16 02:11:22 +00003042 H.DoneProcessing();
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00003043 } else if (Type == FST_Scanf) {
Jordan Rose50687312012-06-04 23:52:23 +00003044 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00003045 Str, HasVAListArg, Args, NumArgs, format_idx,
Jordan Roseddcfbc92012-07-19 18:10:23 +00003046 inFunctionCall, CallType);
Ted Kremenek826a3452010-07-16 02:11:22 +00003047
Hans Wennborgd02deeb2011-12-15 10:25:47 +00003048 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
Jordan Rose275b6f52012-09-13 02:11:03 +00003049 getLangOpts(),
3050 Context.getTargetInfo()))
Ted Kremenek826a3452010-07-16 02:11:22 +00003051 H.DoneProcessing();
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00003052 } // TODO: handle other formats
Ted Kremenekce7024e2010-01-28 01:18:22 +00003053}
3054
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00003055//===--- CHECK: Standard memory functions ---------------------------------===//
3056
Douglas Gregor2a053a32011-05-03 20:05:22 +00003057/// \brief Determine whether the given type is a dynamic class type (e.g.,
3058/// whether it has a vtable).
3059static bool isDynamicClassType(QualType T) {
3060 if (CXXRecordDecl *Record = T->getAsCXXRecordDecl())
3061 if (CXXRecordDecl *Definition = Record->getDefinition())
3062 if (Definition->isDynamicClass())
3063 return true;
3064
3065 return false;
3066}
3067
Chandler Carrutha72a12f2011-06-21 23:04:20 +00003068/// \brief If E is a sizeof expression, returns its argument expression,
Chandler Carruth000d4282011-06-16 09:09:40 +00003069/// otherwise returns NULL.
3070static const Expr *getSizeOfExprArg(const Expr* E) {
Nico Webere4a1c642011-06-14 16:14:58 +00003071 if (const UnaryExprOrTypeTraitExpr *SizeOf =
Chandler Carruth000d4282011-06-16 09:09:40 +00003072 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
3073 if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
3074 return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
Nico Webere4a1c642011-06-14 16:14:58 +00003075
Chandler Carruth000d4282011-06-16 09:09:40 +00003076 return 0;
3077}
3078
Chandler Carrutha72a12f2011-06-21 23:04:20 +00003079/// \brief If E is a sizeof expression, returns its argument type.
Chandler Carruth000d4282011-06-16 09:09:40 +00003080static QualType getSizeOfArgType(const Expr* E) {
3081 if (const UnaryExprOrTypeTraitExpr *SizeOf =
3082 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
3083 if (SizeOf->getKind() == clang::UETT_SizeOf)
3084 return SizeOf->getTypeOfArgument();
3085
3086 return QualType();
Nico Webere4a1c642011-06-14 16:14:58 +00003087}
3088
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00003089/// \brief Check for dangerous or invalid arguments to memset().
3090///
Chandler Carruth929f0132011-06-03 06:23:57 +00003091/// This issues warnings on known problematic, dangerous or unspecified
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00003092/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
3093/// function calls.
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00003094///
3095/// \param Call The call expression to diagnose.
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00003096void Sema::CheckMemaccessArguments(const CallExpr *Call,
Anna Zaks0a151a12012-01-17 00:37:07 +00003097 unsigned BId,
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00003098 IdentifierInfo *FnName) {
Anna Zaks0a151a12012-01-17 00:37:07 +00003099 assert(BId != 0);
3100
Ted Kremenek1d59f7f2011-04-28 01:38:02 +00003101 // It is possible to have a non-standard definition of memset. Validate
Douglas Gregor707a23e2011-06-16 17:56:04 +00003102 // we have enough arguments, and if not, abort further checking.
Anna Zaks0a151a12012-01-17 00:37:07 +00003103 unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3);
Nico Webercda57822011-10-13 22:30:23 +00003104 if (Call->getNumArgs() < ExpectedNumArgs)
Ted Kremenek1d59f7f2011-04-28 01:38:02 +00003105 return;
3106
Anna Zaks0a151a12012-01-17 00:37:07 +00003107 unsigned LastArg = (BId == Builtin::BImemset ||
3108 BId == Builtin::BIstrndup ? 1 : 2);
3109 unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2);
Nico Webercda57822011-10-13 22:30:23 +00003110 const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
Chandler Carruth000d4282011-06-16 09:09:40 +00003111
3112 // We have special checking when the length is a sizeof expression.
3113 QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
3114 const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
3115 llvm::FoldingSetNodeID SizeOfArgID;
3116
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00003117 for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
3118 const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
Nico Webere4a1c642011-06-14 16:14:58 +00003119 SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00003120
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00003121 QualType DestTy = Dest->getType();
3122 if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
3123 QualType PointeeTy = DestPtrTy->getPointeeType();
John McCallf85e1932011-06-15 23:02:42 +00003124
Chandler Carruth000d4282011-06-16 09:09:40 +00003125 // Never warn about void type pointers. This can be used to suppress
3126 // false positives.
3127 if (PointeeTy->isVoidType())
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00003128 continue;
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00003129
Chandler Carruth000d4282011-06-16 09:09:40 +00003130 // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
3131 // actually comparing the expressions for equality. Because computing the
3132 // expression IDs can be expensive, we only do this if the diagnostic is
3133 // enabled.
3134 if (SizeOfArg &&
3135 Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess,
3136 SizeOfArg->getExprLoc())) {
3137 // We only compute IDs for expressions if the warning is enabled, and
3138 // cache the sizeof arg's ID.
3139 if (SizeOfArgID == llvm::FoldingSetNodeID())
3140 SizeOfArg->Profile(SizeOfArgID, Context, true);
3141 llvm::FoldingSetNodeID DestID;
3142 Dest->Profile(DestID, Context, true);
3143 if (DestID == SizeOfArgID) {
Nico Webercda57822011-10-13 22:30:23 +00003144 // TODO: For strncpy() and friends, this could suggest sizeof(dst)
3145 // over sizeof(src) as well.
Chandler Carruth000d4282011-06-16 09:09:40 +00003146 unsigned ActionIdx = 0; // Default is to suggest dereferencing.
Anna Zaks6fcb3722012-05-30 00:34:21 +00003147 StringRef ReadableName = FnName->getName();
3148
Chandler Carruth000d4282011-06-16 09:09:40 +00003149 if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
Anna Zaks90c78322012-05-30 23:14:52 +00003150 if (UnaryOp->getOpcode() == UO_AddrOf)
Chandler Carruth000d4282011-06-16 09:09:40 +00003151 ActionIdx = 1; // If its an address-of operator, just remove it.
3152 if (Context.getTypeSize(PointeeTy) == Context.getCharWidth())
3153 ActionIdx = 2; // If the pointee's size is sizeof(char),
3154 // suggest an explicit length.
Anna Zaks6fcb3722012-05-30 00:34:21 +00003155
3156 // If the function is defined as a builtin macro, do not show macro
3157 // expansion.
3158 SourceLocation SL = SizeOfArg->getExprLoc();
3159 SourceRange DSR = Dest->getSourceRange();
3160 SourceRange SSR = SizeOfArg->getSourceRange();
3161 SourceManager &SM = PP.getSourceManager();
3162
3163 if (SM.isMacroArgExpansion(SL)) {
3164 ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts);
3165 SL = SM.getSpellingLoc(SL);
3166 DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()),
3167 SM.getSpellingLoc(DSR.getEnd()));
3168 SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()),
3169 SM.getSpellingLoc(SSR.getEnd()));
3170 }
3171
Anna Zaks90c78322012-05-30 23:14:52 +00003172 DiagRuntimeBehavior(SL, SizeOfArg,
Chandler Carruth000d4282011-06-16 09:09:40 +00003173 PDiag(diag::warn_sizeof_pointer_expr_memaccess)
Anna Zaks6fcb3722012-05-30 00:34:21 +00003174 << ReadableName
Anna Zaks90c78322012-05-30 23:14:52 +00003175 << PointeeTy
3176 << DestTy
Anna Zaks6fcb3722012-05-30 00:34:21 +00003177 << DSR
Anna Zaks90c78322012-05-30 23:14:52 +00003178 << SSR);
3179 DiagRuntimeBehavior(SL, SizeOfArg,
3180 PDiag(diag::warn_sizeof_pointer_expr_memaccess_note)
3181 << ActionIdx
3182 << SSR);
3183
Chandler Carruth000d4282011-06-16 09:09:40 +00003184 break;
3185 }
3186 }
3187
3188 // Also check for cases where the sizeof argument is the exact same
3189 // type as the memory argument, and where it points to a user-defined
3190 // record type.
3191 if (SizeOfArgTy != QualType()) {
3192 if (PointeeTy->isRecordType() &&
3193 Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
3194 DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
3195 PDiag(diag::warn_sizeof_pointer_type_memaccess)
3196 << FnName << SizeOfArgTy << ArgIdx
3197 << PointeeTy << Dest->getSourceRange()
3198 << LenExpr->getSourceRange());
3199 break;
3200 }
Nico Webere4a1c642011-06-14 16:14:58 +00003201 }
3202
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00003203 // Always complain about dynamic classes.
Anna Zaks0a151a12012-01-17 00:37:07 +00003204 if (isDynamicClassType(PointeeTy)) {
3205
3206 unsigned OperationType = 0;
3207 // "overwritten" if we're warning about the destination for any call
3208 // but memcmp; otherwise a verb appropriate to the call.
3209 if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
3210 if (BId == Builtin::BImemcpy)
3211 OperationType = 1;
3212 else if(BId == Builtin::BImemmove)
3213 OperationType = 2;
3214 else if (BId == Builtin::BImemcmp)
3215 OperationType = 3;
3216 }
3217
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00003218 DiagRuntimeBehavior(
3219 Dest->getExprLoc(), Dest,
3220 PDiag(diag::warn_dyn_class_memaccess)
Anna Zaks0a151a12012-01-17 00:37:07 +00003221 << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
Anna Zaksd9b859a2012-01-13 21:52:01 +00003222 << FnName << PointeeTy
Anna Zaks0a151a12012-01-17 00:37:07 +00003223 << OperationType
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00003224 << Call->getCallee()->getSourceRange());
Anna Zaks0a151a12012-01-17 00:37:07 +00003225 } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
3226 BId != Builtin::BImemset)
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00003227 DiagRuntimeBehavior(
3228 Dest->getExprLoc(), Dest,
3229 PDiag(diag::warn_arc_object_memaccess)
3230 << ArgIdx << FnName << PointeeTy
3231 << Call->getCallee()->getSourceRange());
John McCallf85e1932011-06-15 23:02:42 +00003232 else
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00003233 continue;
John McCallf85e1932011-06-15 23:02:42 +00003234
3235 DiagRuntimeBehavior(
3236 Dest->getExprLoc(), Dest,
Chandler Carruth929f0132011-06-03 06:23:57 +00003237 PDiag(diag::note_bad_memaccess_silence)
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00003238 << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
3239 break;
3240 }
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00003241 }
3242}
3243
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00003244// A little helper routine: ignore addition and subtraction of integer literals.
3245// This intentionally does not ignore all integer constant expressions because
3246// we don't want to remove sizeof().
3247static const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
3248 Ex = Ex->IgnoreParenCasts();
3249
3250 for (;;) {
3251 const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
3252 if (!BO || !BO->isAdditiveOp())
3253 break;
3254
3255 const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
3256 const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
3257
3258 if (isa<IntegerLiteral>(RHS))
3259 Ex = LHS;
3260 else if (isa<IntegerLiteral>(LHS))
3261 Ex = RHS;
3262 else
3263 break;
3264 }
3265
3266 return Ex;
3267}
3268
Anna Zaks0f38ace2012-08-08 21:42:23 +00003269static bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty,
3270 ASTContext &Context) {
3271 // Only handle constant-sized or VLAs, but not flexible members.
3272 if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) {
3273 // Only issue the FIXIT for arrays of size > 1.
3274 if (CAT->getSize().getSExtValue() <= 1)
3275 return false;
3276 } else if (!Ty->isVariableArrayType()) {
3277 return false;
3278 }
3279 return true;
3280}
3281
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00003282// Warn if the user has made the 'size' argument to strlcpy or strlcat
3283// be the size of the source, instead of the destination.
3284void Sema::CheckStrlcpycatArguments(const CallExpr *Call,
3285 IdentifierInfo *FnName) {
3286
3287 // Don't crash if the user has the wrong number of arguments
3288 if (Call->getNumArgs() != 3)
3289 return;
3290
3291 const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
3292 const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
3293 const Expr *CompareWithSrc = NULL;
3294
3295 // Look for 'strlcpy(dst, x, sizeof(x))'
3296 if (const Expr *Ex = getSizeOfExprArg(SizeArg))
3297 CompareWithSrc = Ex;
3298 else {
3299 // Look for 'strlcpy(dst, x, strlen(x))'
3300 if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
Richard Smith180f4792011-11-10 06:34:14 +00003301 if (SizeCall->isBuiltinCall() == Builtin::BIstrlen
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00003302 && SizeCall->getNumArgs() == 1)
3303 CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
3304 }
3305 }
3306
3307 if (!CompareWithSrc)
3308 return;
3309
3310 // Determine if the argument to sizeof/strlen is equal to the source
3311 // argument. In principle there's all kinds of things you could do
3312 // here, for instance creating an == expression and evaluating it with
3313 // EvaluateAsBooleanCondition, but this uses a more direct technique:
3314 const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
3315 if (!SrcArgDRE)
3316 return;
3317
3318 const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
3319 if (!CompareWithSrcDRE ||
3320 SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
3321 return;
3322
3323 const Expr *OriginalSizeArg = Call->getArg(2);
3324 Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
3325 << OriginalSizeArg->getSourceRange() << FnName;
3326
3327 // Output a FIXIT hint if the destination is an array (rather than a
3328 // pointer to an array). This could be enhanced to handle some
3329 // pointers if we know the actual size, like if DstArg is 'array+2'
3330 // we could say 'sizeof(array)-2'.
3331 const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
Anna Zaks0f38ace2012-08-08 21:42:23 +00003332 if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context))
Ted Kremenek8f746222011-08-18 22:48:41 +00003333 return;
Ted Kremenek8f746222011-08-18 22:48:41 +00003334
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00003335 SmallString<128> sizeString;
Ted Kremenek8f746222011-08-18 22:48:41 +00003336 llvm::raw_svector_ostream OS(sizeString);
3337 OS << "sizeof(";
Richard Smithd1420c62012-08-16 03:56:14 +00003338 DstArg->printPretty(OS, 0, getPrintingPolicy());
Ted Kremenek8f746222011-08-18 22:48:41 +00003339 OS << ")";
3340
3341 Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
3342 << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
3343 OS.str());
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00003344}
3345
Anna Zaksc36bedc2012-02-01 19:08:57 +00003346/// Check if two expressions refer to the same declaration.
3347static bool referToTheSameDecl(const Expr *E1, const Expr *E2) {
3348 if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1))
3349 if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2))
3350 return D1->getDecl() == D2->getDecl();
3351 return false;
3352}
3353
3354static const Expr *getStrlenExprArg(const Expr *E) {
3355 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
3356 const FunctionDecl *FD = CE->getDirectCallee();
3357 if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen)
3358 return 0;
3359 return CE->getArg(0)->IgnoreParenCasts();
3360 }
3361 return 0;
3362}
3363
3364// Warn on anti-patterns as the 'size' argument to strncat.
3365// The correct size argument should look like following:
3366// strncat(dst, src, sizeof(dst) - strlen(dest) - 1);
3367void Sema::CheckStrncatArguments(const CallExpr *CE,
3368 IdentifierInfo *FnName) {
3369 // Don't crash if the user has the wrong number of arguments.
3370 if (CE->getNumArgs() < 3)
3371 return;
3372 const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts();
3373 const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts();
3374 const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts();
3375
3376 // Identify common expressions, which are wrongly used as the size argument
3377 // to strncat and may lead to buffer overflows.
3378 unsigned PatternType = 0;
3379 if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) {
3380 // - sizeof(dst)
3381 if (referToTheSameDecl(SizeOfArg, DstArg))
3382 PatternType = 1;
3383 // - sizeof(src)
3384 else if (referToTheSameDecl(SizeOfArg, SrcArg))
3385 PatternType = 2;
3386 } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) {
3387 if (BE->getOpcode() == BO_Sub) {
3388 const Expr *L = BE->getLHS()->IgnoreParenCasts();
3389 const Expr *R = BE->getRHS()->IgnoreParenCasts();
3390 // - sizeof(dst) - strlen(dst)
3391 if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) &&
3392 referToTheSameDecl(DstArg, getStrlenExprArg(R)))
3393 PatternType = 1;
3394 // - sizeof(src) - (anything)
3395 else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L)))
3396 PatternType = 2;
3397 }
3398 }
3399
3400 if (PatternType == 0)
3401 return;
3402
Anna Zaksafdb0412012-02-03 01:27:37 +00003403 // Generate the diagnostic.
3404 SourceLocation SL = LenArg->getLocStart();
3405 SourceRange SR = LenArg->getSourceRange();
3406 SourceManager &SM = PP.getSourceManager();
3407
3408 // If the function is defined as a builtin macro, do not show macro expansion.
3409 if (SM.isMacroArgExpansion(SL)) {
3410 SL = SM.getSpellingLoc(SL);
3411 SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
3412 SM.getSpellingLoc(SR.getEnd()));
3413 }
3414
Anna Zaks0f38ace2012-08-08 21:42:23 +00003415 // Check if the destination is an array (rather than a pointer to an array).
3416 QualType DstTy = DstArg->getType();
3417 bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy,
3418 Context);
3419 if (!isKnownSizeArray) {
3420 if (PatternType == 1)
3421 Diag(SL, diag::warn_strncat_wrong_size) << SR;
3422 else
3423 Diag(SL, diag::warn_strncat_src_size) << SR;
3424 return;
3425 }
3426
Anna Zaksc36bedc2012-02-01 19:08:57 +00003427 if (PatternType == 1)
Anna Zaksafdb0412012-02-03 01:27:37 +00003428 Diag(SL, diag::warn_strncat_large_size) << SR;
Anna Zaksc36bedc2012-02-01 19:08:57 +00003429 else
Anna Zaksafdb0412012-02-03 01:27:37 +00003430 Diag(SL, diag::warn_strncat_src_size) << SR;
Anna Zaksc36bedc2012-02-01 19:08:57 +00003431
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00003432 SmallString<128> sizeString;
Anna Zaksc36bedc2012-02-01 19:08:57 +00003433 llvm::raw_svector_ostream OS(sizeString);
3434 OS << "sizeof(";
Richard Smithd1420c62012-08-16 03:56:14 +00003435 DstArg->printPretty(OS, 0, getPrintingPolicy());
Anna Zaksc36bedc2012-02-01 19:08:57 +00003436 OS << ") - ";
3437 OS << "strlen(";
Richard Smithd1420c62012-08-16 03:56:14 +00003438 DstArg->printPretty(OS, 0, getPrintingPolicy());
Anna Zaksc36bedc2012-02-01 19:08:57 +00003439 OS << ") - 1";
3440
Anna Zaksafdb0412012-02-03 01:27:37 +00003441 Diag(SL, diag::note_strncat_wrong_size)
3442 << FixItHint::CreateReplacement(SR, OS.str());
Anna Zaksc36bedc2012-02-01 19:08:57 +00003443}
3444
Ted Kremenek06de2762007-08-17 16:46:58 +00003445//===--- CHECK: Return Address of Stack Variable --------------------------===//
3446
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003447static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3448 Decl *ParentDecl);
3449static Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars,
3450 Decl *ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003451
3452/// CheckReturnStackAddr - Check if a return statement returns the address
3453/// of a stack variable.
3454void
3455Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
3456 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00003457
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003458 Expr *stackE = 0;
Chris Lattner5f9e2722011-07-23 10:55:15 +00003459 SmallVector<DeclRefExpr *, 8> refVars;
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003460
3461 // Perform checking for returned stack addresses, local blocks,
3462 // label addresses or references to temporaries.
John McCallf85e1932011-06-15 23:02:42 +00003463 if (lhsType->isPointerType() ||
David Blaikie4e4d0842012-03-11 07:00:24 +00003464 (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003465 stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0);
Mike Stumpac5fc7c2009-08-04 21:02:39 +00003466 } else if (lhsType->isReferenceType()) {
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003467 stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0);
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003468 }
3469
3470 if (stackE == 0)
3471 return; // Nothing suspicious was found.
3472
3473 SourceLocation diagLoc;
3474 SourceRange diagRange;
3475 if (refVars.empty()) {
3476 diagLoc = stackE->getLocStart();
3477 diagRange = stackE->getSourceRange();
3478 } else {
3479 // We followed through a reference variable. 'stackE' contains the
3480 // problematic expression but we will warn at the return statement pointing
3481 // at the reference variable. We will later display the "trail" of
3482 // reference variables using notes.
3483 diagLoc = refVars[0]->getLocStart();
3484 diagRange = refVars[0]->getSourceRange();
3485 }
3486
3487 if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var.
3488 Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref
3489 : diag::warn_ret_stack_addr)
3490 << DR->getDecl()->getDeclName() << diagRange;
3491 } else if (isa<BlockExpr>(stackE)) { // local block.
3492 Diag(diagLoc, diag::err_ret_local_block) << diagRange;
3493 } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
3494 Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
3495 } else { // local temporary.
3496 Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref
3497 : diag::warn_ret_local_temp_addr)
3498 << diagRange;
3499 }
3500
3501 // Display the "trail" of reference variables that we followed until we
3502 // found the problematic expression using notes.
3503 for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
3504 VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
3505 // If this var binds to another reference var, show the range of the next
3506 // var, otherwise the var binds to the problematic expression, in which case
3507 // show the range of the expression.
3508 SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange()
3509 : stackE->getSourceRange();
3510 Diag(VD->getLocation(), diag::note_ref_var_local_bind)
3511 << VD->getDeclName() << range;
Ted Kremenek06de2762007-08-17 16:46:58 +00003512 }
3513}
3514
3515/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
3516/// check if the expression in a return statement evaluates to an address
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003517/// to a location on the stack, a local block, an address of a label, or a
3518/// reference to local temporary. The recursion is used to traverse the
Ted Kremenek06de2762007-08-17 16:46:58 +00003519/// AST of the return expression, with recursion backtracking when we
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003520/// encounter a subexpression that (1) clearly does not lead to one of the
3521/// above problematic expressions (2) is something we cannot determine leads to
3522/// a problematic expression based on such local checking.
3523///
3524/// Both EvalAddr and EvalVal follow through reference variables to evaluate
3525/// the expression that they point to. Such variables are added to the
3526/// 'refVars' vector so that we know what the reference variable "trail" was.
Ted Kremenek06de2762007-08-17 16:46:58 +00003527///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00003528/// EvalAddr processes expressions that are pointers that are used as
3529/// references (and not L-values). EvalVal handles all other values.
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003530/// At the base case of the recursion is a check for the above problematic
3531/// expressions.
Ted Kremenek06de2762007-08-17 16:46:58 +00003532///
3533/// This implementation handles:
3534///
3535/// * pointer-to-pointer casts
3536/// * implicit conversions from array references to pointers
3537/// * taking the address of fields
3538/// * arbitrary interplay between "&" and "*" operators
3539/// * pointer arithmetic from an address of a stack variable
3540/// * taking the address of an array element where the array is on the stack
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003541static Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3542 Decl *ParentDecl) {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003543 if (E->isTypeDependent())
3544 return NULL;
3545
Ted Kremenek06de2762007-08-17 16:46:58 +00003546 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00003547 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00003548 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00003549 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003550 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00003551
Peter Collingbournef111d932011-04-15 00:35:48 +00003552 E = E->IgnoreParens();
3553
Ted Kremenek06de2762007-08-17 16:46:58 +00003554 // Our "symbolic interpreter" is just a dispatch off the currently
3555 // viewed AST node. We then recursively traverse the AST by calling
3556 // EvalAddr and EvalVal appropriately.
3557 switch (E->getStmtClass()) {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003558 case Stmt::DeclRefExprClass: {
3559 DeclRefExpr *DR = cast<DeclRefExpr>(E);
3560
3561 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
3562 // If this is a reference variable, follow through to the expression that
3563 // it points to.
3564 if (V->hasLocalStorage() &&
3565 V->getType()->isReferenceType() && V->hasInit()) {
3566 // Add the reference variable to the "trail".
3567 refVars.push_back(DR);
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003568 return EvalAddr(V->getInit(), refVars, ParentDecl);
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003569 }
3570
3571 return NULL;
3572 }
Ted Kremenek06de2762007-08-17 16:46:58 +00003573
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003574 case Stmt::UnaryOperatorClass: {
3575 // The only unary operator that make sense to handle here
3576 // is AddrOf. All others don't make sense as pointers.
3577 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003578
John McCall2de56d12010-08-25 11:45:40 +00003579 if (U->getOpcode() == UO_AddrOf)
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003580 return EvalVal(U->getSubExpr(), refVars, ParentDecl);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003581 else
Ted Kremenek06de2762007-08-17 16:46:58 +00003582 return NULL;
3583 }
Mike Stump1eb44332009-09-09 15:08:12 +00003584
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003585 case Stmt::BinaryOperatorClass: {
3586 // Handle pointer arithmetic. All other binary operators are not valid
3587 // in this context.
3588 BinaryOperator *B = cast<BinaryOperator>(E);
John McCall2de56d12010-08-25 11:45:40 +00003589 BinaryOperatorKind op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00003590
John McCall2de56d12010-08-25 11:45:40 +00003591 if (op != BO_Add && op != BO_Sub)
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003592 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00003593
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003594 Expr *Base = B->getLHS();
3595
3596 // Determine which argument is the real pointer base. It could be
3597 // the RHS argument instead of the LHS.
3598 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00003599
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003600 assert (Base->getType()->isPointerType());
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003601 return EvalAddr(Base, refVars, ParentDecl);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003602 }
Steve Naroff61f40a22008-09-10 19:17:48 +00003603
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003604 // For conditional operators we need to see if either the LHS or RHS are
3605 // valid DeclRefExpr*s. If one of them is valid, we return it.
3606 case Stmt::ConditionalOperatorClass: {
3607 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003608
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003609 // Handle the GNU extension for missing LHS.
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00003610 if (Expr *lhsExpr = C->getLHS()) {
3611 // In C++, we can have a throw-expression, which has 'void' type.
3612 if (!lhsExpr->getType()->isVoidType())
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003613 if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl))
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00003614 return LHS;
3615 }
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003616
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00003617 // In C++, we can have a throw-expression, which has 'void' type.
3618 if (C->getRHS()->getType()->isVoidType())
3619 return NULL;
3620
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003621 return EvalAddr(C->getRHS(), refVars, ParentDecl);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003622 }
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003623
3624 case Stmt::BlockExprClass:
John McCall469a1eb2011-02-02 13:00:07 +00003625 if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003626 return E; // local block.
3627 return NULL;
3628
3629 case Stmt::AddrLabelExprClass:
3630 return E; // address of label.
Mike Stump1eb44332009-09-09 15:08:12 +00003631
John McCall80ee6e82011-11-10 05:35:25 +00003632 case Stmt::ExprWithCleanupsClass:
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003633 return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
3634 ParentDecl);
John McCall80ee6e82011-11-10 05:35:25 +00003635
Ted Kremenek54b52742008-08-07 00:49:01 +00003636 // For casts, we need to handle conversions from arrays to
3637 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00003638 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00003639 case Stmt::CStyleCastExprClass:
John McCallf85e1932011-06-15 23:02:42 +00003640 case Stmt::CXXFunctionalCastExprClass:
Eli Friedman8b9414e2012-02-23 23:04:32 +00003641 case Stmt::ObjCBridgedCastExprClass:
Mike Stump1eb44332009-09-09 15:08:12 +00003642 case Stmt::CXXStaticCastExprClass:
3643 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00003644 case Stmt::CXXConstCastExprClass:
3645 case Stmt::CXXReinterpretCastExprClass: {
Eli Friedman8b9414e2012-02-23 23:04:32 +00003646 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
3647 switch (cast<CastExpr>(E)->getCastKind()) {
3648 case CK_BitCast:
3649 case CK_LValueToRValue:
3650 case CK_NoOp:
3651 case CK_BaseToDerived:
3652 case CK_DerivedToBase:
3653 case CK_UncheckedDerivedToBase:
3654 case CK_Dynamic:
3655 case CK_CPointerToObjCPointerCast:
3656 case CK_BlockPointerToObjCPointerCast:
3657 case CK_AnyPointerToBlockPointerCast:
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003658 return EvalAddr(SubExpr, refVars, ParentDecl);
Eli Friedman8b9414e2012-02-23 23:04:32 +00003659
3660 case CK_ArrayToPointerDecay:
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003661 return EvalVal(SubExpr, refVars, ParentDecl);
Eli Friedman8b9414e2012-02-23 23:04:32 +00003662
3663 default:
3664 return 0;
3665 }
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003666 }
Mike Stump1eb44332009-09-09 15:08:12 +00003667
Douglas Gregor03e80032011-06-21 17:03:29 +00003668 case Stmt::MaterializeTemporaryExprClass:
3669 if (Expr *Result = EvalAddr(
3670 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003671 refVars, ParentDecl))
Douglas Gregor03e80032011-06-21 17:03:29 +00003672 return Result;
3673
3674 return E;
3675
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003676 // Everything else: we simply don't reason about them.
3677 default:
3678 return NULL;
3679 }
Ted Kremenek06de2762007-08-17 16:46:58 +00003680}
Mike Stump1eb44332009-09-09 15:08:12 +00003681
Ted Kremenek06de2762007-08-17 16:46:58 +00003682
3683/// EvalVal - This function is complements EvalAddr in the mutual recursion.
3684/// See the comments for EvalAddr for more details.
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003685static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3686 Decl *ParentDecl) {
Ted Kremenek68957a92010-08-04 20:01:07 +00003687do {
Ted Kremeneke8c600f2007-08-28 17:02:55 +00003688 // We should only be called for evaluating non-pointer expressions, or
3689 // expressions with a pointer type that are not used as references but instead
3690 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00003691
Ted Kremenek06de2762007-08-17 16:46:58 +00003692 // Our "symbolic interpreter" is just a dispatch off the currently
3693 // viewed AST node. We then recursively traverse the AST by calling
3694 // EvalAddr and EvalVal appropriately.
Peter Collingbournef111d932011-04-15 00:35:48 +00003695
3696 E = E->IgnoreParens();
Ted Kremenek06de2762007-08-17 16:46:58 +00003697 switch (E->getStmtClass()) {
Ted Kremenek68957a92010-08-04 20:01:07 +00003698 case Stmt::ImplicitCastExprClass: {
3699 ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
John McCall5baba9d2010-08-25 10:28:54 +00003700 if (IE->getValueKind() == VK_LValue) {
Ted Kremenek68957a92010-08-04 20:01:07 +00003701 E = IE->getSubExpr();
3702 continue;
3703 }
3704 return NULL;
3705 }
3706
John McCall80ee6e82011-11-10 05:35:25 +00003707 case Stmt::ExprWithCleanupsClass:
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003708 return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl);
John McCall80ee6e82011-11-10 05:35:25 +00003709
Douglas Gregora2813ce2009-10-23 18:54:35 +00003710 case Stmt::DeclRefExprClass: {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003711 // When we hit a DeclRefExpr we are looking at code that refers to a
3712 // variable's name. If it's not a reference variable we check if it has
3713 // local storage within the function, and if so, return the expression.
Ted Kremenek06de2762007-08-17 16:46:58 +00003714 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003715
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003716 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) {
3717 // Check if it refers to itself, e.g. "int& i = i;".
3718 if (V == ParentDecl)
3719 return DR;
3720
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003721 if (V->hasLocalStorage()) {
3722 if (!V->getType()->isReferenceType())
3723 return DR;
3724
3725 // Reference variable, follow through to the expression that
3726 // it points to.
3727 if (V->hasInit()) {
3728 // Add the reference variable to the "trail".
3729 refVars.push_back(DR);
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003730 return EvalVal(V->getInit(), refVars, V);
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003731 }
3732 }
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003733 }
Mike Stump1eb44332009-09-09 15:08:12 +00003734
Ted Kremenek06de2762007-08-17 16:46:58 +00003735 return NULL;
3736 }
Mike Stump1eb44332009-09-09 15:08:12 +00003737
Ted Kremenek06de2762007-08-17 16:46:58 +00003738 case Stmt::UnaryOperatorClass: {
3739 // The only unary operator that make sense to handle here
3740 // is Deref. All others don't resolve to a "name." This includes
3741 // handling all sorts of rvalues passed to a unary operator.
3742 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003743
John McCall2de56d12010-08-25 11:45:40 +00003744 if (U->getOpcode() == UO_Deref)
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003745 return EvalAddr(U->getSubExpr(), refVars, ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003746
3747 return NULL;
3748 }
Mike Stump1eb44332009-09-09 15:08:12 +00003749
Ted Kremenek06de2762007-08-17 16:46:58 +00003750 case Stmt::ArraySubscriptExprClass: {
3751 // Array subscripts are potential references to data on the stack. We
3752 // retrieve the DeclRefExpr* for the array variable if it indeed
3753 // has local storage.
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003754 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003755 }
Mike Stump1eb44332009-09-09 15:08:12 +00003756
Ted Kremenek06de2762007-08-17 16:46:58 +00003757 case Stmt::ConditionalOperatorClass: {
3758 // For conditional operators we need to see if either the LHS or RHS are
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003759 // non-NULL Expr's. If one is non-NULL, we return it.
Ted Kremenek06de2762007-08-17 16:46:58 +00003760 ConditionalOperator *C = cast<ConditionalOperator>(E);
3761
Anders Carlsson39073232007-11-30 19:04:31 +00003762 // Handle the GNU extension for missing LHS.
3763 if (Expr *lhsExpr = C->getLHS())
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003764 if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl))
Anders Carlsson39073232007-11-30 19:04:31 +00003765 return LHS;
3766
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003767 return EvalVal(C->getRHS(), refVars, ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003768 }
Mike Stump1eb44332009-09-09 15:08:12 +00003769
Ted Kremenek06de2762007-08-17 16:46:58 +00003770 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00003771 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00003772 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003773
Ted Kremenek06de2762007-08-17 16:46:58 +00003774 // Check for indirect access. We only want direct field accesses.
Ted Kremeneka423e812010-09-02 01:12:13 +00003775 if (M->isArrow())
Ted Kremenek06de2762007-08-17 16:46:58 +00003776 return NULL;
Ted Kremeneka423e812010-09-02 01:12:13 +00003777
3778 // Check whether the member type is itself a reference, in which case
3779 // we're not going to refer to the member, but to what the member refers to.
3780 if (M->getMemberDecl()->getType()->isReferenceType())
3781 return NULL;
3782
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003783 return EvalVal(M->getBase(), refVars, ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003784 }
Mike Stump1eb44332009-09-09 15:08:12 +00003785
Douglas Gregor03e80032011-06-21 17:03:29 +00003786 case Stmt::MaterializeTemporaryExprClass:
3787 if (Expr *Result = EvalVal(
3788 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003789 refVars, ParentDecl))
Douglas Gregor03e80032011-06-21 17:03:29 +00003790 return Result;
3791
3792 return E;
3793
Ted Kremenek06de2762007-08-17 16:46:58 +00003794 default:
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003795 // Check that we don't return or take the address of a reference to a
3796 // temporary. This is only useful in C++.
3797 if (!E->isTypeDependent() && E->isRValue())
3798 return E;
3799
3800 // Everything else: we simply don't reason about them.
Ted Kremenek06de2762007-08-17 16:46:58 +00003801 return NULL;
3802 }
Ted Kremenek68957a92010-08-04 20:01:07 +00003803} while (true);
Ted Kremenek06de2762007-08-17 16:46:58 +00003804}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003805
3806//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
3807
3808/// Check for comparisons of floating point operands using != and ==.
3809/// Issue a warning if these are no self-comparisons, as they are not likely
3810/// to do what the programmer intended.
Richard Trieudd225092011-09-15 21:56:47 +00003811void Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
Richard Trieudd225092011-09-15 21:56:47 +00003812 Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
3813 Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003814
3815 // Special case: check for x == x (which is OK).
3816 // Do not emit warnings for such cases.
3817 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
3818 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
3819 if (DRL->getDecl() == DRR->getDecl())
David Blaikie980343b2012-07-16 20:47:22 +00003820 return;
Mike Stump1eb44332009-09-09 15:08:12 +00003821
3822
Ted Kremenek1b500bb2007-11-29 00:59:04 +00003823 // Special case: check for comparisons against literals that can be exactly
3824 // represented by APFloat. In such cases, do not emit a warning. This
3825 // is a heuristic: often comparison against such literals are used to
3826 // detect if a value in a variable has not changed. This clearly can
3827 // lead to false negatives.
David Blaikie980343b2012-07-16 20:47:22 +00003828 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
3829 if (FLL->isExact())
3830 return;
3831 } else
3832 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen))
3833 if (FLR->isExact())
3834 return;
Mike Stump1eb44332009-09-09 15:08:12 +00003835
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003836 // Check for comparisons with builtin types.
David Blaikie980343b2012-07-16 20:47:22 +00003837 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
3838 if (CL->isBuiltinCall())
3839 return;
Mike Stump1eb44332009-09-09 15:08:12 +00003840
David Blaikie980343b2012-07-16 20:47:22 +00003841 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
3842 if (CR->isBuiltinCall())
3843 return;
Mike Stump1eb44332009-09-09 15:08:12 +00003844
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003845 // Emit the diagnostic.
David Blaikie980343b2012-07-16 20:47:22 +00003846 Diag(Loc, diag::warn_floatingpoint_eq)
3847 << LHS->getSourceRange() << RHS->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003848}
John McCallba26e582010-01-04 23:21:16 +00003849
John McCallf2370c92010-01-06 05:24:50 +00003850//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
3851//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00003852
John McCallf2370c92010-01-06 05:24:50 +00003853namespace {
John McCallba26e582010-01-04 23:21:16 +00003854
John McCallf2370c92010-01-06 05:24:50 +00003855/// Structure recording the 'active' range of an integer-valued
3856/// expression.
3857struct IntRange {
3858 /// The number of bits active in the int.
3859 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00003860
John McCallf2370c92010-01-06 05:24:50 +00003861 /// True if the int is known not to have negative values.
3862 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00003863
John McCallf2370c92010-01-06 05:24:50 +00003864 IntRange(unsigned Width, bool NonNegative)
3865 : Width(Width), NonNegative(NonNegative)
3866 {}
John McCallba26e582010-01-04 23:21:16 +00003867
John McCall1844a6e2010-11-10 23:38:19 +00003868 /// Returns the range of the bool type.
John McCallf2370c92010-01-06 05:24:50 +00003869 static IntRange forBoolType() {
3870 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00003871 }
3872
John McCall1844a6e2010-11-10 23:38:19 +00003873 /// Returns the range of an opaque value of the given integral type.
3874 static IntRange forValueOfType(ASTContext &C, QualType T) {
3875 return forValueOfCanonicalType(C,
3876 T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00003877 }
3878
John McCall1844a6e2010-11-10 23:38:19 +00003879 /// Returns the range of an opaque value of a canonical integral type.
3880 static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
John McCallf2370c92010-01-06 05:24:50 +00003881 assert(T->isCanonicalUnqualified());
3882
3883 if (const VectorType *VT = dyn_cast<VectorType>(T))
3884 T = VT->getElementType().getTypePtr();
3885 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3886 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00003887
John McCall091f23f2010-11-09 22:22:12 +00003888 // For enum types, use the known bit width of the enumerators.
John McCall323ed742010-05-06 08:58:33 +00003889 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
3890 EnumDecl *Enum = ET->getDecl();
John McCall5e1cdac2011-10-07 06:10:15 +00003891 if (!Enum->isCompleteDefinition())
John McCall091f23f2010-11-09 22:22:12 +00003892 return IntRange(C.getIntWidth(QualType(T, 0)), false);
3893
John McCall323ed742010-05-06 08:58:33 +00003894 unsigned NumPositive = Enum->getNumPositiveBits();
3895 unsigned NumNegative = Enum->getNumNegativeBits();
3896
3897 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
3898 }
John McCallf2370c92010-01-06 05:24:50 +00003899
3900 const BuiltinType *BT = cast<BuiltinType>(T);
3901 assert(BT->isInteger());
3902
3903 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
3904 }
3905
John McCall1844a6e2010-11-10 23:38:19 +00003906 /// Returns the "target" range of a canonical integral type, i.e.
3907 /// the range of values expressible in the type.
3908 ///
3909 /// This matches forValueOfCanonicalType except that enums have the
3910 /// full range of their type, not the range of their enumerators.
3911 static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
3912 assert(T->isCanonicalUnqualified());
3913
3914 if (const VectorType *VT = dyn_cast<VectorType>(T))
3915 T = VT->getElementType().getTypePtr();
3916 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3917 T = CT->getElementType().getTypePtr();
3918 if (const EnumType *ET = dyn_cast<EnumType>(T))
Douglas Gregor69ff26b2011-09-08 23:29:05 +00003919 T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
John McCall1844a6e2010-11-10 23:38:19 +00003920
3921 const BuiltinType *BT = cast<BuiltinType>(T);
3922 assert(BT->isInteger());
3923
3924 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
3925 }
3926
3927 /// Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00003928 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00003929 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00003930 L.NonNegative && R.NonNegative);
3931 }
3932
John McCall1844a6e2010-11-10 23:38:19 +00003933 /// Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00003934 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00003935 return IntRange(std::min(L.Width, R.Width),
3936 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00003937 }
3938};
3939
Ted Kremenek0692a192012-01-31 05:37:37 +00003940static IntRange GetValueRange(ASTContext &C, llvm::APSInt &value,
3941 unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003942 if (value.isSigned() && value.isNegative())
3943 return IntRange(value.getMinSignedBits(), false);
3944
3945 if (value.getBitWidth() > MaxWidth)
Jay Foad9f71a8f2010-12-07 08:25:34 +00003946 value = value.trunc(MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00003947
3948 // isNonNegative() just checks the sign bit without considering
3949 // signedness.
3950 return IntRange(value.getActiveBits(), true);
3951}
3952
Ted Kremenek0692a192012-01-31 05:37:37 +00003953static IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
3954 unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003955 if (result.isInt())
3956 return GetValueRange(C, result.getInt(), MaxWidth);
3957
3958 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00003959 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
3960 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
3961 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
3962 R = IntRange::join(R, El);
3963 }
John McCallf2370c92010-01-06 05:24:50 +00003964 return R;
3965 }
3966
3967 if (result.isComplexInt()) {
3968 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
3969 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
3970 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00003971 }
3972
3973 // This can happen with lossless casts to intptr_t of "based" lvalues.
3974 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00003975 // FIXME: The only reason we need to pass the type in here is to get
3976 // the sign right on this one case. It would be nice if APValue
3977 // preserved this.
Eli Friedman65639282012-01-04 23:13:47 +00003978 assert(result.isLValue() || result.isAddrLabelDiff());
Douglas Gregor5e9ebb32011-05-21 16:28:01 +00003979 return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
John McCall51313c32010-01-04 23:31:57 +00003980}
John McCallf2370c92010-01-06 05:24:50 +00003981
3982/// Pseudo-evaluate the given integer expression, estimating the
3983/// range of values it might take.
3984///
3985/// \param MaxWidth - the width to which the value will be truncated
Ted Kremenek0692a192012-01-31 05:37:37 +00003986static IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003987 E = E->IgnoreParens();
3988
3989 // Try a full evaluation first.
3990 Expr::EvalResult result;
Richard Smith51f47082011-10-29 00:50:52 +00003991 if (E->EvaluateAsRValue(result, C))
John McCall0acc3112010-01-06 22:57:21 +00003992 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00003993
3994 // I think we only want to look through implicit casts here; if the
3995 // user has an explicit widening cast, we should treat the value as
3996 // being of the new, wider type.
3997 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
Eli Friedmanb17ee5b2011-12-15 02:41:52 +00003998 if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
John McCallf2370c92010-01-06 05:24:50 +00003999 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
4000
John McCall1844a6e2010-11-10 23:38:19 +00004001 IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType());
John McCallf2370c92010-01-06 05:24:50 +00004002
John McCall2de56d12010-08-25 11:45:40 +00004003 bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
John McCall60fad452010-01-06 22:07:33 +00004004
John McCallf2370c92010-01-06 05:24:50 +00004005 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00004006 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00004007 return OutputTypeRange;
4008
4009 IntRange SubRange
4010 = GetExprRange(C, CE->getSubExpr(),
4011 std::min(MaxWidth, OutputTypeRange.Width));
4012
4013 // Bail out if the subexpr's range is as wide as the cast type.
4014 if (SubRange.Width >= OutputTypeRange.Width)
4015 return OutputTypeRange;
4016
4017 // Otherwise, we take the smaller width, and we're non-negative if
4018 // either the output type or the subexpr is.
4019 return IntRange(SubRange.Width,
4020 SubRange.NonNegative || OutputTypeRange.NonNegative);
4021 }
4022
4023 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
4024 // If we can fold the condition, just take that operand.
4025 bool CondResult;
4026 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
4027 return GetExprRange(C, CondResult ? CO->getTrueExpr()
4028 : CO->getFalseExpr(),
4029 MaxWidth);
4030
4031 // Otherwise, conservatively merge.
4032 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
4033 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
4034 return IntRange::join(L, R);
4035 }
4036
4037 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
4038 switch (BO->getOpcode()) {
4039
4040 // Boolean-valued operations are single-bit and positive.
John McCall2de56d12010-08-25 11:45:40 +00004041 case BO_LAnd:
4042 case BO_LOr:
4043 case BO_LT:
4044 case BO_GT:
4045 case BO_LE:
4046 case BO_GE:
4047 case BO_EQ:
4048 case BO_NE:
John McCallf2370c92010-01-06 05:24:50 +00004049 return IntRange::forBoolType();
4050
John McCall862ff872011-07-13 06:35:24 +00004051 // The type of the assignments is the type of the LHS, so the RHS
4052 // is not necessarily the same type.
John McCall2de56d12010-08-25 11:45:40 +00004053 case BO_MulAssign:
4054 case BO_DivAssign:
4055 case BO_RemAssign:
4056 case BO_AddAssign:
4057 case BO_SubAssign:
John McCall862ff872011-07-13 06:35:24 +00004058 case BO_XorAssign:
4059 case BO_OrAssign:
4060 // TODO: bitfields?
John McCall1844a6e2010-11-10 23:38:19 +00004061 return IntRange::forValueOfType(C, E->getType());
John McCallc0cd21d2010-02-23 19:22:29 +00004062
John McCall862ff872011-07-13 06:35:24 +00004063 // Simple assignments just pass through the RHS, which will have
4064 // been coerced to the LHS type.
4065 case BO_Assign:
4066 // TODO: bitfields?
4067 return GetExprRange(C, BO->getRHS(), MaxWidth);
4068
John McCallf2370c92010-01-06 05:24:50 +00004069 // Operations with opaque sources are black-listed.
John McCall2de56d12010-08-25 11:45:40 +00004070 case BO_PtrMemD:
4071 case BO_PtrMemI:
John McCall1844a6e2010-11-10 23:38:19 +00004072 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00004073
John McCall60fad452010-01-06 22:07:33 +00004074 // Bitwise-and uses the *infinum* of the two source ranges.
John McCall2de56d12010-08-25 11:45:40 +00004075 case BO_And:
4076 case BO_AndAssign:
John McCall60fad452010-01-06 22:07:33 +00004077 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
4078 GetExprRange(C, BO->getRHS(), MaxWidth));
4079
John McCallf2370c92010-01-06 05:24:50 +00004080 // Left shift gets black-listed based on a judgement call.
John McCall2de56d12010-08-25 11:45:40 +00004081 case BO_Shl:
John McCall3aae6092010-04-07 01:14:35 +00004082 // ...except that we want to treat '1 << (blah)' as logically
4083 // positive. It's an important idiom.
4084 if (IntegerLiteral *I
4085 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
4086 if (I->getValue() == 1) {
John McCall1844a6e2010-11-10 23:38:19 +00004087 IntRange R = IntRange::forValueOfType(C, E->getType());
John McCall3aae6092010-04-07 01:14:35 +00004088 return IntRange(R.Width, /*NonNegative*/ true);
4089 }
4090 }
4091 // fallthrough
4092
John McCall2de56d12010-08-25 11:45:40 +00004093 case BO_ShlAssign:
John McCall1844a6e2010-11-10 23:38:19 +00004094 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00004095
John McCall60fad452010-01-06 22:07:33 +00004096 // Right shift by a constant can narrow its left argument.
John McCall2de56d12010-08-25 11:45:40 +00004097 case BO_Shr:
4098 case BO_ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00004099 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
4100
4101 // If the shift amount is a positive constant, drop the width by
4102 // that much.
4103 llvm::APSInt shift;
4104 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
4105 shift.isNonNegative()) {
4106 unsigned zext = shift.getZExtValue();
4107 if (zext >= L.Width)
4108 L.Width = (L.NonNegative ? 0 : 1);
4109 else
4110 L.Width -= zext;
4111 }
4112
4113 return L;
4114 }
4115
4116 // Comma acts as its right operand.
John McCall2de56d12010-08-25 11:45:40 +00004117 case BO_Comma:
John McCallf2370c92010-01-06 05:24:50 +00004118 return GetExprRange(C, BO->getRHS(), MaxWidth);
4119
John McCall60fad452010-01-06 22:07:33 +00004120 // Black-list pointer subtractions.
John McCall2de56d12010-08-25 11:45:40 +00004121 case BO_Sub:
John McCallf2370c92010-01-06 05:24:50 +00004122 if (BO->getLHS()->getType()->isPointerType())
John McCall1844a6e2010-11-10 23:38:19 +00004123 return IntRange::forValueOfType(C, E->getType());
John McCall00fe7612011-07-14 22:39:48 +00004124 break;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00004125
John McCall00fe7612011-07-14 22:39:48 +00004126 // The width of a division result is mostly determined by the size
4127 // of the LHS.
4128 case BO_Div: {
4129 // Don't 'pre-truncate' the operands.
4130 unsigned opWidth = C.getIntWidth(E->getType());
4131 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
4132
4133 // If the divisor is constant, use that.
4134 llvm::APSInt divisor;
4135 if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
4136 unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
4137 if (log2 >= L.Width)
4138 L.Width = (L.NonNegative ? 0 : 1);
4139 else
4140 L.Width = std::min(L.Width - log2, MaxWidth);
4141 return L;
4142 }
4143
4144 // Otherwise, just use the LHS's width.
4145 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
4146 return IntRange(L.Width, L.NonNegative && R.NonNegative);
4147 }
4148
4149 // The result of a remainder can't be larger than the result of
4150 // either side.
4151 case BO_Rem: {
4152 // Don't 'pre-truncate' the operands.
4153 unsigned opWidth = C.getIntWidth(E->getType());
4154 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
4155 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
4156
4157 IntRange meet = IntRange::meet(L, R);
4158 meet.Width = std::min(meet.Width, MaxWidth);
4159 return meet;
4160 }
4161
4162 // The default behavior is okay for these.
4163 case BO_Mul:
4164 case BO_Add:
4165 case BO_Xor:
4166 case BO_Or:
John McCallf2370c92010-01-06 05:24:50 +00004167 break;
4168 }
4169
John McCall00fe7612011-07-14 22:39:48 +00004170 // The default case is to treat the operation as if it were closed
4171 // on the narrowest type that encompasses both operands.
John McCallf2370c92010-01-06 05:24:50 +00004172 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
4173 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
4174 return IntRange::join(L, R);
4175 }
4176
4177 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
4178 switch (UO->getOpcode()) {
4179 // Boolean-valued operations are white-listed.
John McCall2de56d12010-08-25 11:45:40 +00004180 case UO_LNot:
John McCallf2370c92010-01-06 05:24:50 +00004181 return IntRange::forBoolType();
4182
4183 // Operations with opaque sources are black-listed.
John McCall2de56d12010-08-25 11:45:40 +00004184 case UO_Deref:
4185 case UO_AddrOf: // should be impossible
John McCall1844a6e2010-11-10 23:38:19 +00004186 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00004187
4188 default:
4189 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
4190 }
4191 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00004192
4193 if (dyn_cast<OffsetOfExpr>(E)) {
John McCall1844a6e2010-11-10 23:38:19 +00004194 IntRange::forValueOfType(C, E->getType());
Douglas Gregor8ecdb652010-04-28 22:16:22 +00004195 }
John McCallf2370c92010-01-06 05:24:50 +00004196
Richard Smitha6b8b2c2011-10-10 18:28:20 +00004197 if (FieldDecl *BitField = E->getBitField())
4198 return IntRange(BitField->getBitWidthValue(C),
Douglas Gregor5e9ebb32011-05-21 16:28:01 +00004199 BitField->getType()->isUnsignedIntegerOrEnumerationType());
John McCallf2370c92010-01-06 05:24:50 +00004200
John McCall1844a6e2010-11-10 23:38:19 +00004201 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00004202}
John McCall51313c32010-01-04 23:31:57 +00004203
Ted Kremenek0692a192012-01-31 05:37:37 +00004204static IntRange GetExprRange(ASTContext &C, Expr *E) {
John McCall323ed742010-05-06 08:58:33 +00004205 return GetExprRange(C, E, C.getIntWidth(E->getType()));
4206}
4207
John McCall51313c32010-01-04 23:31:57 +00004208/// Checks whether the given value, which currently has the given
4209/// source semantics, has the same value when coerced through the
4210/// target semantics.
Ted Kremenek0692a192012-01-31 05:37:37 +00004211static bool IsSameFloatAfterCast(const llvm::APFloat &value,
4212 const llvm::fltSemantics &Src,
4213 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00004214 llvm::APFloat truncated = value;
4215
4216 bool ignored;
4217 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
4218 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
4219
4220 return truncated.bitwiseIsEqual(value);
4221}
4222
4223/// Checks whether the given value, which currently has the given
4224/// source semantics, has the same value when coerced through the
4225/// target semantics.
4226///
4227/// The value might be a vector of floats (or a complex number).
Ted Kremenek0692a192012-01-31 05:37:37 +00004228static bool IsSameFloatAfterCast(const APValue &value,
4229 const llvm::fltSemantics &Src,
4230 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00004231 if (value.isFloat())
4232 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
4233
4234 if (value.isVector()) {
4235 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
4236 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
4237 return false;
4238 return true;
4239 }
4240
4241 assert(value.isComplexFloat());
4242 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
4243 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
4244}
4245
Ted Kremenek0692a192012-01-31 05:37:37 +00004246static void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
John McCall323ed742010-05-06 08:58:33 +00004247
Ted Kremeneke3b159c2010-09-23 21:43:44 +00004248static bool IsZero(Sema &S, Expr *E) {
4249 // Suppress cases where we are comparing against an enum constant.
4250 if (const DeclRefExpr *DR =
4251 dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
4252 if (isa<EnumConstantDecl>(DR->getDecl()))
4253 return false;
4254
4255 // Suppress cases where the '0' value is expanded from a macro.
4256 if (E->getLocStart().isMacroID())
4257 return false;
4258
John McCall323ed742010-05-06 08:58:33 +00004259 llvm::APSInt Value;
4260 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
4261}
4262
John McCall372e1032010-10-06 00:25:24 +00004263static bool HasEnumType(Expr *E) {
4264 // Strip off implicit integral promotions.
4265 while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
Argyrios Kyrtzidis63b57ae2010-10-07 21:52:18 +00004266 if (ICE->getCastKind() != CK_IntegralCast &&
4267 ICE->getCastKind() != CK_NoOp)
John McCall372e1032010-10-06 00:25:24 +00004268 break;
Argyrios Kyrtzidis63b57ae2010-10-07 21:52:18 +00004269 E = ICE->getSubExpr();
John McCall372e1032010-10-06 00:25:24 +00004270 }
4271
4272 return E->getType()->isEnumeralType();
4273}
4274
Ted Kremenek0692a192012-01-31 05:37:37 +00004275static void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
John McCall2de56d12010-08-25 11:45:40 +00004276 BinaryOperatorKind op = E->getOpcode();
Douglas Gregor14af91a2010-12-21 07:22:56 +00004277 if (E->isValueDependent())
4278 return;
4279
John McCall2de56d12010-08-25 11:45:40 +00004280 if (op == BO_LT && IsZero(S, E->getRHS())) {
John McCall323ed742010-05-06 08:58:33 +00004281 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00004282 << "< 0" << "false" << HasEnumType(E->getLHS())
John McCall323ed742010-05-06 08:58:33 +00004283 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00004284 } else if (op == BO_GE && IsZero(S, E->getRHS())) {
John McCall323ed742010-05-06 08:58:33 +00004285 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00004286 << ">= 0" << "true" << HasEnumType(E->getLHS())
John McCall323ed742010-05-06 08:58:33 +00004287 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00004288 } else if (op == BO_GT && IsZero(S, E->getLHS())) {
John McCall323ed742010-05-06 08:58:33 +00004289 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00004290 << "0 >" << "false" << HasEnumType(E->getRHS())
John McCall323ed742010-05-06 08:58:33 +00004291 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00004292 } else if (op == BO_LE && IsZero(S, E->getLHS())) {
John McCall323ed742010-05-06 08:58:33 +00004293 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00004294 << "0 <=" << "true" << HasEnumType(E->getRHS())
John McCall323ed742010-05-06 08:58:33 +00004295 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
4296 }
4297}
4298
4299/// Analyze the operands of the given comparison. Implements the
4300/// fallback case from AnalyzeComparison.
Ted Kremenek0692a192012-01-31 05:37:37 +00004301static void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
John McCallb4eb64d2010-10-08 02:01:28 +00004302 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4303 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
John McCall323ed742010-05-06 08:58:33 +00004304}
John McCall51313c32010-01-04 23:31:57 +00004305
John McCallba26e582010-01-04 23:21:16 +00004306/// \brief Implements -Wsign-compare.
4307///
Richard Trieudd225092011-09-15 21:56:47 +00004308/// \param E the binary operator to check for warnings
Ted Kremenek0692a192012-01-31 05:37:37 +00004309static void AnalyzeComparison(Sema &S, BinaryOperator *E) {
John McCall323ed742010-05-06 08:58:33 +00004310 // The type the comparison is being performed in.
4311 QualType T = E->getLHS()->getType();
4312 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
4313 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00004314
John McCall323ed742010-05-06 08:58:33 +00004315 // We don't do anything special if this isn't an unsigned integral
4316 // comparison: we're only interested in integral comparisons, and
4317 // signed comparisons only happen in cases we don't care to warn about.
Douglas Gregor3e026e32011-02-19 22:34:59 +00004318 //
4319 // We also don't care about value-dependent expressions or expressions
4320 // whose result is a constant.
4321 if (!T->hasUnsignedIntegerRepresentation()
4322 || E->isValueDependent() || E->isIntegerConstantExpr(S.Context))
John McCall323ed742010-05-06 08:58:33 +00004323 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00004324
Richard Trieudd225092011-09-15 21:56:47 +00004325 Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
4326 Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00004327
John McCall323ed742010-05-06 08:58:33 +00004328 // Check to see if one of the (unmodified) operands is of different
4329 // signedness.
4330 Expr *signedOperand, *unsignedOperand;
Richard Trieudd225092011-09-15 21:56:47 +00004331 if (LHS->getType()->hasSignedIntegerRepresentation()) {
4332 assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
John McCall323ed742010-05-06 08:58:33 +00004333 "unsigned comparison between two signed integer expressions?");
Richard Trieudd225092011-09-15 21:56:47 +00004334 signedOperand = LHS;
4335 unsignedOperand = RHS;
4336 } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
4337 signedOperand = RHS;
4338 unsignedOperand = LHS;
John McCallba26e582010-01-04 23:21:16 +00004339 } else {
John McCall323ed742010-05-06 08:58:33 +00004340 CheckTrivialUnsignedComparison(S, E);
4341 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00004342 }
4343
John McCall323ed742010-05-06 08:58:33 +00004344 // Otherwise, calculate the effective range of the signed operand.
4345 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00004346
John McCall323ed742010-05-06 08:58:33 +00004347 // Go ahead and analyze implicit conversions in the operands. Note
4348 // that we skip the implicit conversions on both sides.
Richard Trieudd225092011-09-15 21:56:47 +00004349 AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
4350 AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
John McCallba26e582010-01-04 23:21:16 +00004351
John McCall323ed742010-05-06 08:58:33 +00004352 // If the signed range is non-negative, -Wsign-compare won't fire,
4353 // but we should still check for comparisons which are always true
4354 // or false.
4355 if (signedRange.NonNegative)
4356 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00004357
4358 // For (in)equality comparisons, if the unsigned operand is a
4359 // constant which cannot collide with a overflowed signed operand,
4360 // then reinterpreting the signed operand as unsigned will not
4361 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00004362 if (E->isEqualityOp()) {
4363 unsigned comparisonWidth = S.Context.getIntWidth(T);
4364 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00004365
John McCall323ed742010-05-06 08:58:33 +00004366 // We should never be unable to prove that the unsigned operand is
4367 // non-negative.
4368 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
4369
4370 if (unsignedRange.Width < comparisonWidth)
4371 return;
4372 }
4373
Douglas Gregor6d3b93d2012-05-01 01:53:49 +00004374 S.DiagRuntimeBehavior(E->getOperatorLoc(), E,
4375 S.PDiag(diag::warn_mixed_sign_comparison)
4376 << LHS->getType() << RHS->getType()
4377 << LHS->getSourceRange() << RHS->getSourceRange());
John McCallba26e582010-01-04 23:21:16 +00004378}
4379
John McCall15d7d122010-11-11 03:21:53 +00004380/// Analyzes an attempt to assign the given value to a bitfield.
4381///
4382/// Returns true if there was something fishy about the attempt.
Ted Kremenek0692a192012-01-31 05:37:37 +00004383static bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
4384 SourceLocation InitLoc) {
John McCall15d7d122010-11-11 03:21:53 +00004385 assert(Bitfield->isBitField());
4386 if (Bitfield->isInvalidDecl())
4387 return false;
4388
John McCall91b60142010-11-11 05:33:51 +00004389 // White-list bool bitfields.
4390 if (Bitfield->getType()->isBooleanType())
4391 return false;
4392
Douglas Gregor46ff3032011-02-04 13:09:01 +00004393 // Ignore value- or type-dependent expressions.
4394 if (Bitfield->getBitWidth()->isValueDependent() ||
4395 Bitfield->getBitWidth()->isTypeDependent() ||
4396 Init->isValueDependent() ||
4397 Init->isTypeDependent())
4398 return false;
4399
John McCall15d7d122010-11-11 03:21:53 +00004400 Expr *OriginalInit = Init->IgnoreParenImpCasts();
4401
Richard Smith80d4b552011-12-28 19:48:30 +00004402 llvm::APSInt Value;
4403 if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects))
John McCall15d7d122010-11-11 03:21:53 +00004404 return false;
4405
John McCall15d7d122010-11-11 03:21:53 +00004406 unsigned OriginalWidth = Value.getBitWidth();
Richard Smitha6b8b2c2011-10-10 18:28:20 +00004407 unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
John McCall15d7d122010-11-11 03:21:53 +00004408
4409 if (OriginalWidth <= FieldWidth)
4410 return false;
4411
Eli Friedman3a643af2012-01-26 23:11:39 +00004412 // Compute the value which the bitfield will contain.
Jay Foad9f71a8f2010-12-07 08:25:34 +00004413 llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
Eli Friedman3a643af2012-01-26 23:11:39 +00004414 TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType());
John McCall15d7d122010-11-11 03:21:53 +00004415
Eli Friedman3a643af2012-01-26 23:11:39 +00004416 // Check whether the stored value is equal to the original value.
4417 TruncatedValue = TruncatedValue.extend(OriginalWidth);
Richard Trieue1ecdc12012-07-23 20:21:35 +00004418 if (llvm::APSInt::isSameValue(Value, TruncatedValue))
John McCall15d7d122010-11-11 03:21:53 +00004419 return false;
4420
Eli Friedman3a643af2012-01-26 23:11:39 +00004421 // Special-case bitfields of width 1: booleans are naturally 0/1, and
Eli Friedman34ff0622012-02-02 00:40:20 +00004422 // therefore don't strictly fit into a signed bitfield of width 1.
4423 if (FieldWidth == 1 && Value == 1)
Eli Friedman3a643af2012-01-26 23:11:39 +00004424 return false;
4425
John McCall15d7d122010-11-11 03:21:53 +00004426 std::string PrettyValue = Value.toString(10);
4427 std::string PrettyTrunc = TruncatedValue.toString(10);
4428
4429 S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
4430 << PrettyValue << PrettyTrunc << OriginalInit->getType()
4431 << Init->getSourceRange();
4432
4433 return true;
4434}
4435
John McCallbeb22aa2010-11-09 23:24:47 +00004436/// Analyze the given simple or compound assignment for warning-worthy
4437/// operations.
Ted Kremenek0692a192012-01-31 05:37:37 +00004438static void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
John McCallbeb22aa2010-11-09 23:24:47 +00004439 // Just recurse on the LHS.
4440 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4441
4442 // We want to recurse on the RHS as normal unless we're assigning to
4443 // a bitfield.
4444 if (FieldDecl *Bitfield = E->getLHS()->getBitField()) {
John McCall15d7d122010-11-11 03:21:53 +00004445 if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
4446 E->getOperatorLoc())) {
4447 // Recurse, ignoring any implicit conversions on the RHS.
4448 return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
4449 E->getOperatorLoc());
John McCallbeb22aa2010-11-09 23:24:47 +00004450 }
4451 }
4452
4453 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4454}
4455
John McCall51313c32010-01-04 23:31:57 +00004456/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
Ted Kremenek0692a192012-01-31 05:37:37 +00004457static void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
Anna Zaksc36bedc2012-02-01 19:08:57 +00004458 SourceLocation CContext, unsigned diag,
4459 bool pruneControlFlow = false) {
4460 if (pruneControlFlow) {
4461 S.DiagRuntimeBehavior(E->getExprLoc(), E,
4462 S.PDiag(diag)
4463 << SourceType << T << E->getSourceRange()
4464 << SourceRange(CContext));
4465 return;
4466 }
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00004467 S.Diag(E->getExprLoc(), diag)
4468 << SourceType << T << E->getSourceRange() << SourceRange(CContext);
4469}
4470
Chandler Carruthe1b02e02011-04-05 06:47:57 +00004471/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
Ted Kremenek0692a192012-01-31 05:37:37 +00004472static void DiagnoseImpCast(Sema &S, Expr *E, QualType T,
Anna Zaksc36bedc2012-02-01 19:08:57 +00004473 SourceLocation CContext, unsigned diag,
4474 bool pruneControlFlow = false) {
4475 DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
Chandler Carruthe1b02e02011-04-05 06:47:57 +00004476}
4477
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004478/// Diagnose an implicit cast from a literal expression. Does not warn when the
4479/// cast wouldn't lose information.
Chandler Carruthf65076e2011-04-10 08:36:24 +00004480void DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T,
4481 SourceLocation CContext) {
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004482 // Try to convert the literal exactly to an integer. If we can, don't warn.
Chandler Carruthf65076e2011-04-10 08:36:24 +00004483 bool isExact = false;
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004484 const llvm::APFloat &Value = FL->getValue();
Jeffrey Yasskin3e1ef782011-07-15 17:03:07 +00004485 llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
4486 T->hasUnsignedIntegerRepresentation());
4487 if (Value.convertToInteger(IntegerValue,
Chandler Carruthf65076e2011-04-10 08:36:24 +00004488 llvm::APFloat::rmTowardZero, &isExact)
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004489 == llvm::APFloat::opOK && isExact)
Chandler Carruthf65076e2011-04-10 08:36:24 +00004490 return;
4491
David Blaikiebe0ee872012-05-15 16:56:36 +00004492 SmallString<16> PrettySourceValue;
4493 Value.toString(PrettySourceValue);
David Blaikiede7e7b82012-05-15 17:18:27 +00004494 SmallString<16> PrettyTargetValue;
David Blaikiebe0ee872012-05-15 16:56:36 +00004495 if (T->isSpecificBuiltinType(BuiltinType::Bool))
4496 PrettyTargetValue = IntegerValue == 0 ? "false" : "true";
4497 else
David Blaikiede7e7b82012-05-15 17:18:27 +00004498 IntegerValue.toString(PrettyTargetValue);
David Blaikiebe0ee872012-05-15 16:56:36 +00004499
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004500 S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer)
David Blaikiebe0ee872012-05-15 16:56:36 +00004501 << FL->getType() << T.getUnqualifiedType() << PrettySourceValue
4502 << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext);
Chandler Carruthf65076e2011-04-10 08:36:24 +00004503}
4504
John McCall091f23f2010-11-09 22:22:12 +00004505std::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
4506 if (!Range.Width) return "0";
4507
4508 llvm::APSInt ValueInRange = Value;
4509 ValueInRange.setIsSigned(!Range.NonNegative);
Jay Foad9f71a8f2010-12-07 08:25:34 +00004510 ValueInRange = ValueInRange.trunc(Range.Width);
John McCall091f23f2010-11-09 22:22:12 +00004511 return ValueInRange.toString(10);
4512}
4513
Hans Wennborg88617a22012-08-28 15:44:30 +00004514static bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) {
4515 if (!isa<ImplicitCastExpr>(Ex))
4516 return false;
4517
4518 Expr *InnerE = Ex->IgnoreParenImpCasts();
4519 const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr();
4520 const Type *Source =
4521 S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
4522 if (Target->isDependentType())
4523 return false;
4524
4525 const BuiltinType *FloatCandidateBT =
4526 dyn_cast<BuiltinType>(ToBool ? Source : Target);
4527 const Type *BoolCandidateType = ToBool ? Target : Source;
4528
4529 return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) &&
4530 FloatCandidateBT && (FloatCandidateBT->isFloatingPoint()));
4531}
4532
4533void CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall,
4534 SourceLocation CC) {
4535 unsigned NumArgs = TheCall->getNumArgs();
4536 for (unsigned i = 0; i < NumArgs; ++i) {
4537 Expr *CurrA = TheCall->getArg(i);
4538 if (!IsImplicitBoolFloatConversion(S, CurrA, true))
4539 continue;
4540
4541 bool IsSwapped = ((i > 0) &&
4542 IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false));
4543 IsSwapped |= ((i < (NumArgs - 1)) &&
4544 IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false));
4545 if (IsSwapped) {
4546 // Warn on this floating-point to bool conversion.
4547 DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(),
4548 CurrA->getType(), CC,
4549 diag::warn_impcast_floating_point_to_bool);
4550 }
4551 }
4552}
4553
John McCall323ed742010-05-06 08:58:33 +00004554void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
John McCallb4eb64d2010-10-08 02:01:28 +00004555 SourceLocation CC, bool *ICContext = 0) {
John McCall323ed742010-05-06 08:58:33 +00004556 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00004557
John McCall323ed742010-05-06 08:58:33 +00004558 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
4559 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
4560 if (Source == Target) return;
4561 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00004562
Chandler Carruth108f7562011-07-26 05:40:03 +00004563 // If the conversion context location is invalid don't complain. We also
4564 // don't want to emit a warning if the issue occurs from the expansion of
4565 // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
4566 // delay this check as long as possible. Once we detect we are in that
4567 // scenario, we just return.
Ted Kremenekef9ff882011-03-10 20:03:42 +00004568 if (CC.isInvalid())
John McCallb4eb64d2010-10-08 02:01:28 +00004569 return;
4570
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004571 // Diagnose implicit casts to bool.
4572 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
4573 if (isa<StringLiteral>(E))
4574 // Warn on string literal to bool. Checks for string literals in logical
4575 // expressions, for instances, assert(0 && "error here"), is prevented
4576 // by a check in AnalyzeImplicitConversions().
4577 return DiagnoseImpCast(S, E, T, CC,
4578 diag::warn_impcast_string_literal_to_bool);
Lang Hamese14ca9f2011-12-05 20:49:50 +00004579 if (Source->isFunctionType()) {
4580 // Warn on function to bool. Checks free functions and static member
4581 // functions. Weakly imported functions are excluded from the check,
4582 // since it's common to test their value to check whether the linker
4583 // found a definition for them.
4584 ValueDecl *D = 0;
4585 if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) {
4586 D = R->getDecl();
4587 } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
4588 D = M->getMemberDecl();
4589 }
4590
4591 if (D && !D->isWeak()) {
Richard Trieu26b45d82011-12-06 04:48:01 +00004592 if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) {
4593 S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool)
4594 << F << E->getSourceRange() << SourceRange(CC);
David Blaikie2def7732011-12-09 21:42:37 +00004595 S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence)
4596 << FixItHint::CreateInsertion(E->getExprLoc(), "&");
4597 QualType ReturnType;
4598 UnresolvedSet<4> NonTemplateOverloads;
4599 S.isExprCallable(*E, ReturnType, NonTemplateOverloads);
4600 if (!ReturnType.isNull()
4601 && ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
4602 S.Diag(E->getExprLoc(), diag::note_function_to_bool_call)
4603 << FixItHint::CreateInsertion(
4604 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()");
Richard Trieu26b45d82011-12-06 04:48:01 +00004605 return;
4606 }
Lang Hamese14ca9f2011-12-05 20:49:50 +00004607 }
4608 }
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004609 }
John McCall51313c32010-01-04 23:31:57 +00004610
4611 // Strip vector types.
4612 if (isa<VectorType>(Source)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00004613 if (!isa<VectorType>(Target)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004614 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004615 return;
John McCallb4eb64d2010-10-08 02:01:28 +00004616 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
Ted Kremenekef9ff882011-03-10 20:03:42 +00004617 }
Chris Lattnerb792b302011-06-14 04:51:15 +00004618
4619 // If the vector cast is cast between two vectors of the same size, it is
4620 // a bitcast, not a conversion.
4621 if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
4622 return;
John McCall51313c32010-01-04 23:31:57 +00004623
4624 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
4625 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
4626 }
4627
4628 // Strip complex types.
4629 if (isa<ComplexType>(Source)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00004630 if (!isa<ComplexType>(Target)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004631 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004632 return;
4633
John McCallb4eb64d2010-10-08 02:01:28 +00004634 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
Ted Kremenekef9ff882011-03-10 20:03:42 +00004635 }
John McCall51313c32010-01-04 23:31:57 +00004636
4637 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
4638 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
4639 }
4640
4641 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
4642 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
4643
4644 // If the source is floating point...
4645 if (SourceBT && SourceBT->isFloatingPoint()) {
4646 // ...and the target is floating point...
4647 if (TargetBT && TargetBT->isFloatingPoint()) {
4648 // ...then warn if we're dropping FP rank.
4649
4650 // Builtin FP kinds are ordered by increasing FP rank.
4651 if (SourceBT->getKind() > TargetBT->getKind()) {
4652 // Don't warn about float constants that are precisely
4653 // representable in the target type.
4654 Expr::EvalResult result;
Richard Smith51f47082011-10-29 00:50:52 +00004655 if (E->EvaluateAsRValue(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00004656 // Value might be a float, a float vector, or a float complex.
4657 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00004658 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
4659 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00004660 return;
4661 }
4662
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004663 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004664 return;
4665
John McCallb4eb64d2010-10-08 02:01:28 +00004666 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00004667 }
4668 return;
4669 }
4670
Ted Kremenekef9ff882011-03-10 20:03:42 +00004671 // If the target is integral, always warn.
David Blaikiebe0ee872012-05-15 16:56:36 +00004672 if (TargetBT && TargetBT->isInteger()) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004673 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004674 return;
4675
Chandler Carrutha5b93322011-02-17 11:05:49 +00004676 Expr *InnerE = E->IgnoreParenImpCasts();
Matt Beaumont-Gay634c8af2011-09-08 22:30:47 +00004677 // We also want to warn on, e.g., "int i = -1.234"
4678 if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
4679 if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
4680 InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
4681
Chandler Carruthf65076e2011-04-10 08:36:24 +00004682 if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) {
4683 DiagnoseFloatingLiteralImpCast(S, FL, T, CC);
Chandler Carrutha5b93322011-02-17 11:05:49 +00004684 } else {
4685 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer);
4686 }
4687 }
John McCall51313c32010-01-04 23:31:57 +00004688
Hans Wennborg88617a22012-08-28 15:44:30 +00004689 // If the target is bool, warn if expr is a function or method call.
4690 if (Target->isSpecificBuiltinType(BuiltinType::Bool) &&
4691 isa<CallExpr>(E)) {
4692 // Check last argument of function call to see if it is an
4693 // implicit cast from a type matching the type the result
4694 // is being cast to.
4695 CallExpr *CEx = cast<CallExpr>(E);
4696 unsigned NumArgs = CEx->getNumArgs();
4697 if (NumArgs > 0) {
4698 Expr *LastA = CEx->getArg(NumArgs - 1);
4699 Expr *InnerE = LastA->IgnoreParenImpCasts();
4700 const Type *InnerType =
4701 S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
4702 if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) {
4703 // Warn on this floating-point to bool conversion
4704 DiagnoseImpCast(S, E, T, CC,
4705 diag::warn_impcast_floating_point_to_bool);
4706 }
4707 }
4708 }
John McCall51313c32010-01-04 23:31:57 +00004709 return;
4710 }
4711
Richard Trieu1838ca52011-05-29 19:59:02 +00004712 if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)
David Blaikieb26331b2012-06-19 21:19:06 +00004713 == Expr::NPCK_GNUNull) && !Target->isAnyPointerType()
David Blaikie28a5f0c2012-06-21 18:51:10 +00004714 && !Target->isBlockPointerType() && !Target->isMemberPointerType()) {
David Blaikieb1360492012-03-16 20:30:12 +00004715 SourceLocation Loc = E->getSourceRange().getBegin();
4716 if (Loc.isMacroID())
4717 Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first;
David Blaikie9fb1ac52012-05-15 21:57:38 +00004718 if (!Loc.isMacroID() || CC.isMacroID())
4719 S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer)
4720 << T << clang::SourceRange(CC)
4721 << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T));
Richard Trieu1838ca52011-05-29 19:59:02 +00004722 }
4723
David Blaikieb26331b2012-06-19 21:19:06 +00004724 if (!Source->isIntegerType() || !Target->isIntegerType())
4725 return;
4726
David Blaikiebe0ee872012-05-15 16:56:36 +00004727 // TODO: remove this early return once the false positives for constant->bool
4728 // in templates, macros, etc, are reduced or removed.
4729 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
4730 return;
4731
John McCall323ed742010-05-06 08:58:33 +00004732 IntRange SourceRange = GetExprRange(S.Context, E);
John McCall1844a6e2010-11-10 23:38:19 +00004733 IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00004734
4735 if (SourceRange.Width > TargetRange.Width) {
John McCall091f23f2010-11-09 22:22:12 +00004736 // If the source is a constant, use a default-on diagnostic.
4737 // TODO: this should happen for bitfield stores, too.
4738 llvm::APSInt Value(32);
4739 if (E->isIntegerConstantExpr(Value, S.Context)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004740 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004741 return;
4742
John McCall091f23f2010-11-09 22:22:12 +00004743 std::string PrettySourceValue = Value.toString(10);
4744 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
4745
Ted Kremenek5e745da2011-10-22 02:37:33 +00004746 S.DiagRuntimeBehavior(E->getExprLoc(), E,
4747 S.PDiag(diag::warn_impcast_integer_precision_constant)
4748 << PrettySourceValue << PrettyTargetValue
4749 << E->getType() << T << E->getSourceRange()
4750 << clang::SourceRange(CC));
John McCall091f23f2010-11-09 22:22:12 +00004751 return;
4752 }
4753
Chris Lattnerb792b302011-06-14 04:51:15 +00004754 // People want to build with -Wshorten-64-to-32 and not -Wconversion.
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004755 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004756 return;
4757
David Blaikie37050842012-04-12 22:40:54 +00004758 if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64)
Anna Zaksc36bedc2012-02-01 19:08:57 +00004759 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
4760 /* pruneControlFlow */ true);
John McCallb4eb64d2010-10-08 02:01:28 +00004761 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
John McCall323ed742010-05-06 08:58:33 +00004762 }
4763
4764 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
4765 (!TargetRange.NonNegative && SourceRange.NonNegative &&
4766 SourceRange.Width == TargetRange.Width)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00004767
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004768 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004769 return;
4770
John McCall323ed742010-05-06 08:58:33 +00004771 unsigned DiagID = diag::warn_impcast_integer_sign;
4772
4773 // Traditionally, gcc has warned about this under -Wsign-compare.
4774 // We also want to warn about it in -Wconversion.
4775 // So if -Wconversion is off, use a completely identical diagnostic
4776 // in the sign-compare group.
4777 // The conditional-checking code will
4778 if (ICContext) {
4779 DiagID = diag::warn_impcast_integer_sign_conditional;
4780 *ICContext = true;
4781 }
4782
John McCallb4eb64d2010-10-08 02:01:28 +00004783 return DiagnoseImpCast(S, E, T, CC, DiagID);
John McCall51313c32010-01-04 23:31:57 +00004784 }
4785
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004786 // Diagnose conversions between different enumeration types.
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00004787 // In C, we pretend that the type of an EnumConstantDecl is its enumeration
4788 // type, to give us better diagnostics.
4789 QualType SourceType = E->getType();
David Blaikie4e4d0842012-03-11 07:00:24 +00004790 if (!S.getLangOpts().CPlusPlus) {
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00004791 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
4792 if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
4793 EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
4794 SourceType = S.Context.getTypeDeclType(Enum);
4795 Source = S.Context.getCanonicalType(SourceType).getTypePtr();
4796 }
4797 }
4798
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004799 if (const EnumType *SourceEnum = Source->getAs<EnumType>())
4800 if (const EnumType *TargetEnum = Target->getAs<EnumType>())
4801 if ((SourceEnum->getDecl()->getIdentifier() ||
Richard Smith162e1c12011-04-15 14:24:37 +00004802 SourceEnum->getDecl()->getTypedefNameForAnonDecl()) &&
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004803 (TargetEnum->getDecl()->getIdentifier() ||
Richard Smith162e1c12011-04-15 14:24:37 +00004804 TargetEnum->getDecl()->getTypedefNameForAnonDecl()) &&
Ted Kremenekef9ff882011-03-10 20:03:42 +00004805 SourceEnum != TargetEnum) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004806 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004807 return;
4808
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00004809 return DiagnoseImpCast(S, E, SourceType, T, CC,
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004810 diag::warn_impcast_different_enum_types);
Ted Kremenekef9ff882011-03-10 20:03:42 +00004811 }
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004812
John McCall51313c32010-01-04 23:31:57 +00004813 return;
4814}
4815
David Blaikie9fb1ac52012-05-15 21:57:38 +00004816void CheckConditionalOperator(Sema &S, ConditionalOperator *E,
4817 SourceLocation CC, QualType T);
John McCall323ed742010-05-06 08:58:33 +00004818
4819void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
John McCallb4eb64d2010-10-08 02:01:28 +00004820 SourceLocation CC, bool &ICContext) {
John McCall323ed742010-05-06 08:58:33 +00004821 E = E->IgnoreParenImpCasts();
4822
4823 if (isa<ConditionalOperator>(E))
David Blaikie9fb1ac52012-05-15 21:57:38 +00004824 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T);
John McCall323ed742010-05-06 08:58:33 +00004825
John McCallb4eb64d2010-10-08 02:01:28 +00004826 AnalyzeImplicitConversions(S, E, CC);
John McCall323ed742010-05-06 08:58:33 +00004827 if (E->getType() != T)
John McCallb4eb64d2010-10-08 02:01:28 +00004828 return CheckImplicitConversion(S, E, T, CC, &ICContext);
John McCall323ed742010-05-06 08:58:33 +00004829 return;
4830}
4831
David Blaikie9fb1ac52012-05-15 21:57:38 +00004832void CheckConditionalOperator(Sema &S, ConditionalOperator *E,
4833 SourceLocation CC, QualType T) {
John McCallb4eb64d2010-10-08 02:01:28 +00004834 AnalyzeImplicitConversions(S, E->getCond(), CC);
John McCall323ed742010-05-06 08:58:33 +00004835
4836 bool Suspicious = false;
John McCallb4eb64d2010-10-08 02:01:28 +00004837 CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
4838 CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
John McCall323ed742010-05-06 08:58:33 +00004839
4840 // If -Wconversion would have warned about either of the candidates
4841 // for a signedness conversion to the context type...
4842 if (!Suspicious) return;
4843
4844 // ...but it's currently ignored...
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00004845 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional,
4846 CC))
John McCall323ed742010-05-06 08:58:33 +00004847 return;
4848
John McCall323ed742010-05-06 08:58:33 +00004849 // ...then check whether it would have warned about either of the
4850 // candidates for a signedness conversion to the condition type.
Richard Trieu52541612011-07-21 02:46:28 +00004851 if (E->getType() == T) return;
4852
4853 Suspicious = false;
4854 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
4855 E->getType(), CC, &Suspicious);
4856 if (!Suspicious)
4857 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
John McCallb4eb64d2010-10-08 02:01:28 +00004858 E->getType(), CC, &Suspicious);
John McCall323ed742010-05-06 08:58:33 +00004859}
4860
4861/// AnalyzeImplicitConversions - Find and report any interesting
4862/// implicit conversions in the given expression. There are a couple
4863/// of competing diagnostics here, -Wconversion and -Wsign-compare.
John McCallb4eb64d2010-10-08 02:01:28 +00004864void AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
John McCall323ed742010-05-06 08:58:33 +00004865 QualType T = OrigE->getType();
4866 Expr *E = OrigE->IgnoreParenImpCasts();
4867
Douglas Gregorf8b6e152011-10-10 17:38:18 +00004868 if (E->isTypeDependent() || E->isValueDependent())
4869 return;
4870
John McCall323ed742010-05-06 08:58:33 +00004871 // For conditional operators, we analyze the arguments as if they
4872 // were being fed directly into the output.
4873 if (isa<ConditionalOperator>(E)) {
4874 ConditionalOperator *CO = cast<ConditionalOperator>(E);
David Blaikie9fb1ac52012-05-15 21:57:38 +00004875 CheckConditionalOperator(S, CO, CC, T);
John McCall323ed742010-05-06 08:58:33 +00004876 return;
4877 }
4878
Hans Wennborg88617a22012-08-28 15:44:30 +00004879 // Check implicit argument conversions for function calls.
4880 if (CallExpr *Call = dyn_cast<CallExpr>(E))
4881 CheckImplicitArgumentConversions(S, Call, CC);
4882
John McCall323ed742010-05-06 08:58:33 +00004883 // Go ahead and check any implicit conversions we might have skipped.
4884 // The non-canonical typecheck is just an optimization;
4885 // CheckImplicitConversion will filter out dead implicit conversions.
4886 if (E->getType() != T)
John McCallb4eb64d2010-10-08 02:01:28 +00004887 CheckImplicitConversion(S, E, T, CC);
John McCall323ed742010-05-06 08:58:33 +00004888
4889 // Now continue drilling into this expression.
4890
4891 // Skip past explicit casts.
4892 if (isa<ExplicitCastExpr>(E)) {
4893 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
John McCallb4eb64d2010-10-08 02:01:28 +00004894 return AnalyzeImplicitConversions(S, E, CC);
John McCall323ed742010-05-06 08:58:33 +00004895 }
4896
John McCallbeb22aa2010-11-09 23:24:47 +00004897 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
4898 // Do a somewhat different check with comparison operators.
4899 if (BO->isComparisonOp())
4900 return AnalyzeComparison(S, BO);
4901
Eli Friedman0fa06382012-01-26 23:34:06 +00004902 // And with simple assignments.
4903 if (BO->getOpcode() == BO_Assign)
John McCallbeb22aa2010-11-09 23:24:47 +00004904 return AnalyzeAssignment(S, BO);
4905 }
John McCall323ed742010-05-06 08:58:33 +00004906
4907 // These break the otherwise-useful invariant below. Fortunately,
4908 // we don't really need to recurse into them, because any internal
4909 // expressions should have been analyzed already when they were
4910 // built into statements.
4911 if (isa<StmtExpr>(E)) return;
4912
4913 // Don't descend into unevaluated contexts.
Peter Collingbournef4e3cfb2011-03-11 19:24:49 +00004914 if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
John McCall323ed742010-05-06 08:58:33 +00004915
4916 // Now just recurse over the expression's children.
John McCallb4eb64d2010-10-08 02:01:28 +00004917 CC = E->getExprLoc();
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004918 BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
4919 bool IsLogicalOperator = BO && BO->isLogicalOp();
4920 for (Stmt::child_range I = E->children(); I; ++I) {
Douglas Gregor54042f12012-02-09 10:18:50 +00004921 Expr *ChildExpr = dyn_cast_or_null<Expr>(*I);
Douglas Gregor503384f2012-02-09 00:47:04 +00004922 if (!ChildExpr)
4923 continue;
4924
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004925 if (IsLogicalOperator &&
4926 isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
4927 // Ignore checking string literals that are in logical operators.
4928 continue;
4929 AnalyzeImplicitConversions(S, ChildExpr, CC);
4930 }
John McCall323ed742010-05-06 08:58:33 +00004931}
4932
4933} // end anonymous namespace
4934
4935/// Diagnoses "dangerous" implicit conversions within the given
4936/// expression (which is a full expression). Implements -Wconversion
4937/// and -Wsign-compare.
John McCallb4eb64d2010-10-08 02:01:28 +00004938///
4939/// \param CC the "context" location of the implicit conversion, i.e.
4940/// the most location of the syntactic entity requiring the implicit
4941/// conversion
4942void Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
John McCall323ed742010-05-06 08:58:33 +00004943 // Don't diagnose in unevaluated contexts.
David Blaikie71f55f72012-08-06 22:47:24 +00004944 if (isUnevaluatedContext())
John McCall323ed742010-05-06 08:58:33 +00004945 return;
4946
4947 // Don't diagnose for value- or type-dependent expressions.
4948 if (E->isTypeDependent() || E->isValueDependent())
4949 return;
4950
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004951 // Check for array bounds violations in cases where the check isn't triggered
4952 // elsewhere for other Expr types (like BinaryOperators), e.g. when an
4953 // ArraySubscriptExpr is on the RHS of a variable initialization.
4954 CheckArrayAccess(E);
4955
John McCallb4eb64d2010-10-08 02:01:28 +00004956 // This is not the right CC for (e.g.) a variable initialization.
4957 AnalyzeImplicitConversions(*this, E, CC);
John McCall323ed742010-05-06 08:58:33 +00004958}
4959
John McCall15d7d122010-11-11 03:21:53 +00004960void Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
4961 FieldDecl *BitField,
4962 Expr *Init) {
4963 (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
4964}
4965
Mike Stumpf8c49212010-01-21 03:59:47 +00004966/// CheckParmsForFunctionDef - Check that the parameters of the given
4967/// function are appropriate for the definition of a function. This
4968/// takes care of any checks that cannot be performed on the
4969/// declaration itself, e.g., that the types of each of the function
4970/// parameters are complete.
Douglas Gregor82aa7132010-11-01 18:37:59 +00004971bool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd,
4972 bool CheckParameterNames) {
Mike Stumpf8c49212010-01-21 03:59:47 +00004973 bool HasInvalidParm = false;
Douglas Gregor82aa7132010-11-01 18:37:59 +00004974 for (; P != PEnd; ++P) {
4975 ParmVarDecl *Param = *P;
4976
Mike Stumpf8c49212010-01-21 03:59:47 +00004977 // C99 6.7.5.3p4: the parameters in a parameter type list in a
4978 // function declarator that is part of a function definition of
4979 // that function shall not have incomplete type.
4980 //
4981 // This is also C++ [dcl.fct]p6.
4982 if (!Param->isInvalidDecl() &&
4983 RequireCompleteType(Param->getLocation(), Param->getType(),
Douglas Gregord10099e2012-05-04 16:32:21 +00004984 diag::err_typecheck_decl_incomplete_type)) {
Mike Stumpf8c49212010-01-21 03:59:47 +00004985 Param->setInvalidDecl();
4986 HasInvalidParm = true;
4987 }
4988
4989 // C99 6.9.1p5: If the declarator includes a parameter type list, the
4990 // declaration of each parameter shall include an identifier.
Douglas Gregor82aa7132010-11-01 18:37:59 +00004991 if (CheckParameterNames &&
4992 Param->getIdentifier() == 0 &&
Mike Stumpf8c49212010-01-21 03:59:47 +00004993 !Param->isImplicit() &&
David Blaikie4e4d0842012-03-11 07:00:24 +00004994 !getLangOpts().CPlusPlus)
Mike Stumpf8c49212010-01-21 03:59:47 +00004995 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00004996
4997 // C99 6.7.5.3p12:
4998 // If the function declarator is not part of a definition of that
4999 // function, parameters may have incomplete type and may use the [*]
5000 // notation in their sequences of declarator specifiers to specify
5001 // variable length array types.
5002 QualType PType = Param->getOriginalType();
5003 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
5004 if (AT->getSizeModifier() == ArrayType::Star) {
Sylvestre Ledrubed28ac2012-07-23 08:59:39 +00005005 // FIXME: This diagnosic should point the '[*]' if source-location
Sam Weinigd17e3402010-02-01 05:02:49 +00005006 // information is added for it.
5007 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
5008 }
5009 }
Mike Stumpf8c49212010-01-21 03:59:47 +00005010 }
5011
5012 return HasInvalidParm;
5013}
John McCallb7f4ffe2010-08-12 21:44:57 +00005014
5015/// CheckCastAlign - Implements -Wcast-align, which warns when a
5016/// pointer cast increases the alignment requirements.
5017void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
5018 // This is actually a lot of work to potentially be doing on every
5019 // cast; don't do it if we're ignoring -Wcast_align (as is the default).
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00005020 if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align,
5021 TRange.getBegin())
David Blaikied6471f72011-09-25 23:23:43 +00005022 == DiagnosticsEngine::Ignored)
John McCallb7f4ffe2010-08-12 21:44:57 +00005023 return;
5024
5025 // Ignore dependent types.
5026 if (T->isDependentType() || Op->getType()->isDependentType())
5027 return;
5028
5029 // Require that the destination be a pointer type.
5030 const PointerType *DestPtr = T->getAs<PointerType>();
5031 if (!DestPtr) return;
5032
5033 // If the destination has alignment 1, we're done.
5034 QualType DestPointee = DestPtr->getPointeeType();
5035 if (DestPointee->isIncompleteType()) return;
5036 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
5037 if (DestAlign.isOne()) return;
5038
5039 // Require that the source be a pointer type.
5040 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
5041 if (!SrcPtr) return;
5042 QualType SrcPointee = SrcPtr->getPointeeType();
5043
5044 // Whitelist casts from cv void*. We already implicitly
5045 // whitelisted casts to cv void*, since they have alignment 1.
5046 // Also whitelist casts involving incomplete types, which implicitly
5047 // includes 'void'.
5048 if (SrcPointee->isIncompleteType()) return;
5049
5050 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
5051 if (SrcAlign >= DestAlign) return;
5052
5053 Diag(TRange.getBegin(), diag::warn_cast_align)
5054 << Op->getType() << T
5055 << static_cast<unsigned>(SrcAlign.getQuantity())
5056 << static_cast<unsigned>(DestAlign.getQuantity())
5057 << TRange << Op->getSourceRange();
5058}
5059
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005060static const Type* getElementType(const Expr *BaseExpr) {
5061 const Type* EltType = BaseExpr->getType().getTypePtr();
5062 if (EltType->isAnyPointerType())
5063 return EltType->getPointeeType().getTypePtr();
5064 else if (EltType->isArrayType())
5065 return EltType->getBaseElementTypeUnsafe();
5066 return EltType;
5067}
5068
Chandler Carruthc2684342011-08-05 09:10:50 +00005069/// \brief Check whether this array fits the idiom of a size-one tail padded
5070/// array member of a struct.
5071///
5072/// We avoid emitting out-of-bounds access warnings for such arrays as they are
5073/// commonly used to emulate flexible arrays in C89 code.
5074static bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size,
5075 const NamedDecl *ND) {
5076 if (Size != 1 || !ND) return false;
5077
5078 const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
5079 if (!FD) return false;
5080
5081 // Don't consider sizes resulting from macro expansions or template argument
5082 // substitution to form C89 tail-padded arrays.
Sean Callanand2cf3482012-05-04 18:22:53 +00005083
5084 TypeSourceInfo *TInfo = FD->getTypeSourceInfo();
Ted Kremenek00e1f6f2012-05-09 05:35:08 +00005085 while (TInfo) {
5086 TypeLoc TL = TInfo->getTypeLoc();
5087 // Look through typedefs.
5088 const TypedefTypeLoc *TTL = dyn_cast<TypedefTypeLoc>(&TL);
5089 if (TTL) {
5090 const TypedefNameDecl *TDL = TTL->getTypedefNameDecl();
5091 TInfo = TDL->getTypeSourceInfo();
5092 continue;
5093 }
5094 ConstantArrayTypeLoc CTL = cast<ConstantArrayTypeLoc>(TL);
5095 const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr());
Sean Callanand2cf3482012-05-04 18:22:53 +00005096 if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
5097 return false;
Ted Kremenek00e1f6f2012-05-09 05:35:08 +00005098 break;
Sean Callanand2cf3482012-05-04 18:22:53 +00005099 }
Chandler Carruthc2684342011-08-05 09:10:50 +00005100
5101 const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
Matt Beaumont-Gay381711c2011-11-29 22:43:53 +00005102 if (!RD) return false;
5103 if (RD->isUnion()) return false;
5104 if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
5105 if (!CRD->isStandardLayout()) return false;
5106 }
Chandler Carruthc2684342011-08-05 09:10:50 +00005107
Benjamin Kramer22d4fed2011-08-06 03:04:42 +00005108 // See if this is the last field decl in the record.
5109 const Decl *D = FD;
5110 while ((D = D->getNextDeclInContext()))
5111 if (isa<FieldDecl>(D))
5112 return false;
5113 return true;
Chandler Carruthc2684342011-08-05 09:10:50 +00005114}
5115
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005116void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00005117 const ArraySubscriptExpr *ASE,
Richard Smith25b009a2011-12-16 19:31:14 +00005118 bool AllowOnePastEnd, bool IndexNegated) {
Eli Friedman92b670e2012-02-27 21:21:40 +00005119 IndexExpr = IndexExpr->IgnoreParenImpCasts();
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00005120 if (IndexExpr->isValueDependent())
5121 return;
5122
Matt Beaumont-Gay8ef8f432011-12-12 22:35:02 +00005123 const Type *EffectiveType = getElementType(BaseExpr);
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005124 BaseExpr = BaseExpr->IgnoreParenCasts();
Chandler Carruth34064582011-02-17 20:55:08 +00005125 const ConstantArrayType *ArrayTy =
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005126 Context.getAsConstantArrayType(BaseExpr->getType());
Chandler Carruth34064582011-02-17 20:55:08 +00005127 if (!ArrayTy)
Ted Kremeneka0125d82011-02-16 01:57:07 +00005128 return;
Chandler Carruth35001ca2011-02-17 21:10:52 +00005129
Chandler Carruth34064582011-02-17 20:55:08 +00005130 llvm::APSInt index;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00005131 if (!IndexExpr->EvaluateAsInt(index, Context))
Ted Kremeneka0125d82011-02-16 01:57:07 +00005132 return;
Richard Smith25b009a2011-12-16 19:31:14 +00005133 if (IndexNegated)
5134 index = -index;
Ted Kremenek8fd0a5d2011-02-16 04:01:44 +00005135
Chandler Carruthba447122011-08-05 08:07:29 +00005136 const NamedDecl *ND = NULL;
Chandler Carruthba447122011-08-05 08:07:29 +00005137 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
5138 ND = dyn_cast<NamedDecl>(DRE->getDecl());
Chandler Carruthc2684342011-08-05 09:10:50 +00005139 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
Chandler Carruthba447122011-08-05 08:07:29 +00005140 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
Chandler Carruthba447122011-08-05 08:07:29 +00005141
Ted Kremenek9e060ca2011-02-23 23:06:04 +00005142 if (index.isUnsigned() || !index.isNegative()) {
Ted Kremenek25b3b842011-02-18 02:27:00 +00005143 llvm::APInt size = ArrayTy->getSize();
Chandler Carruth35001ca2011-02-17 21:10:52 +00005144 if (!size.isStrictlyPositive())
5145 return;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005146
5147 const Type* BaseType = getElementType(BaseExpr);
Nico Weberde5998f2011-09-17 22:59:41 +00005148 if (BaseType != EffectiveType) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005149 // Make sure we're comparing apples to apples when comparing index to size
5150 uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
5151 uint64_t array_typesize = Context.getTypeSize(BaseType);
Kaelyn Uhraind10f4bc2011-08-10 19:47:25 +00005152 // Handle ptrarith_typesize being zero, such as when casting to void*
Kaelyn Uhrain18f16972011-08-10 18:49:28 +00005153 if (!ptrarith_typesize) ptrarith_typesize = 1;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005154 if (ptrarith_typesize != array_typesize) {
5155 // There's a cast to a different size type involved
5156 uint64_t ratio = array_typesize / ptrarith_typesize;
5157 // TODO: Be smarter about handling cases where array_typesize is not a
5158 // multiple of ptrarith_typesize
5159 if (ptrarith_typesize * ratio == array_typesize)
5160 size *= llvm::APInt(size.getBitWidth(), ratio);
5161 }
5162 }
5163
Chandler Carruth34064582011-02-17 20:55:08 +00005164 if (size.getBitWidth() > index.getBitWidth())
Eli Friedman92b670e2012-02-27 21:21:40 +00005165 index = index.zext(size.getBitWidth());
Ted Kremenek25b3b842011-02-18 02:27:00 +00005166 else if (size.getBitWidth() < index.getBitWidth())
Eli Friedman92b670e2012-02-27 21:21:40 +00005167 size = size.zext(index.getBitWidth());
Ted Kremenek25b3b842011-02-18 02:27:00 +00005168
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005169 // For array subscripting the index must be less than size, but for pointer
5170 // arithmetic also allow the index (offset) to be equal to size since
5171 // computing the next address after the end of the array is legal and
5172 // commonly done e.g. in C++ iterators and range-based for loops.
Eli Friedman92b670e2012-02-27 21:21:40 +00005173 if (AllowOnePastEnd ? index.ule(size) : index.ult(size))
Chandler Carruthba447122011-08-05 08:07:29 +00005174 return;
5175
5176 // Also don't warn for arrays of size 1 which are members of some
5177 // structure. These are often used to approximate flexible arrays in C89
5178 // code.
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005179 if (IsTailPaddedMemberArray(*this, size, ND))
Ted Kremenek8fd0a5d2011-02-16 04:01:44 +00005180 return;
Chandler Carruth34064582011-02-17 20:55:08 +00005181
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00005182 // Suppress the warning if the subscript expression (as identified by the
5183 // ']' location) and the index expression are both from macro expansions
5184 // within a system header.
5185 if (ASE) {
5186 SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
5187 ASE->getRBracketLoc());
5188 if (SourceMgr.isInSystemHeader(RBracketLoc)) {
5189 SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
5190 IndexExpr->getLocStart());
5191 if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc))
5192 return;
5193 }
5194 }
5195
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005196 unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00005197 if (ASE)
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005198 DiagID = diag::warn_array_index_exceeds_bounds;
5199
5200 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
5201 PDiag(DiagID) << index.toString(10, true)
5202 << size.toString(10, true)
5203 << (unsigned)size.getLimitedValue(~0U)
5204 << IndexExpr->getSourceRange());
Chandler Carruth34064582011-02-17 20:55:08 +00005205 } else {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005206 unsigned DiagID = diag::warn_array_index_precedes_bounds;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00005207 if (!ASE) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005208 DiagID = diag::warn_ptr_arith_precedes_bounds;
5209 if (index.isNegative()) index = -index;
5210 }
5211
5212 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
5213 PDiag(DiagID) << index.toString(10, true)
5214 << IndexExpr->getSourceRange());
Ted Kremeneka0125d82011-02-16 01:57:07 +00005215 }
Chandler Carruth35001ca2011-02-17 21:10:52 +00005216
Matt Beaumont-Gaycfbc5b52011-11-29 19:27:11 +00005217 if (!ND) {
5218 // Try harder to find a NamedDecl to point at in the note.
5219 while (const ArraySubscriptExpr *ASE =
5220 dyn_cast<ArraySubscriptExpr>(BaseExpr))
5221 BaseExpr = ASE->getBase()->IgnoreParenCasts();
5222 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
5223 ND = dyn_cast<NamedDecl>(DRE->getDecl());
5224 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
5225 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
5226 }
5227
Chandler Carruth35001ca2011-02-17 21:10:52 +00005228 if (ND)
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005229 DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
5230 PDiag(diag::note_array_index_out_of_bounds)
5231 << ND->getDeclName());
Ted Kremeneka0125d82011-02-16 01:57:07 +00005232}
5233
Ted Kremenek3aea4da2011-03-01 18:41:00 +00005234void Sema::CheckArrayAccess(const Expr *expr) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005235 int AllowOnePastEnd = 0;
5236 while (expr) {
5237 expr = expr->IgnoreParenImpCasts();
Ted Kremenek3aea4da2011-03-01 18:41:00 +00005238 switch (expr->getStmtClass()) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005239 case Stmt::ArraySubscriptExprClass: {
5240 const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00005241 CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005242 AllowOnePastEnd > 0);
Ted Kremenek3aea4da2011-03-01 18:41:00 +00005243 return;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00005244 }
5245 case Stmt::UnaryOperatorClass: {
5246 // Only unwrap the * and & unary operators
5247 const UnaryOperator *UO = cast<UnaryOperator>(expr);
5248 expr = UO->getSubExpr();
5249 switch (UO->getOpcode()) {
5250 case UO_AddrOf:
5251 AllowOnePastEnd++;
5252 break;
5253 case UO_Deref:
5254 AllowOnePastEnd--;
5255 break;
5256 default:
5257 return;
5258 }
5259 break;
5260 }
Ted Kremenek3aea4da2011-03-01 18:41:00 +00005261 case Stmt::ConditionalOperatorClass: {
5262 const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
5263 if (const Expr *lhs = cond->getLHS())
5264 CheckArrayAccess(lhs);
5265 if (const Expr *rhs = cond->getRHS())
5266 CheckArrayAccess(rhs);
5267 return;
5268 }
5269 default:
5270 return;
5271 }
Peter Collingbournef111d932011-04-15 00:35:48 +00005272 }
Ted Kremenek3aea4da2011-03-01 18:41:00 +00005273}
John McCallf85e1932011-06-15 23:02:42 +00005274
5275//===--- CHECK: Objective-C retain cycles ----------------------------------//
5276
5277namespace {
5278 struct RetainCycleOwner {
5279 RetainCycleOwner() : Variable(0), Indirect(false) {}
5280 VarDecl *Variable;
5281 SourceRange Range;
5282 SourceLocation Loc;
5283 bool Indirect;
5284
5285 void setLocsFrom(Expr *e) {
5286 Loc = e->getExprLoc();
5287 Range = e->getSourceRange();
5288 }
5289 };
5290}
5291
5292/// Consider whether capturing the given variable can possibly lead to
5293/// a retain cycle.
5294static bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
5295 // In ARC, it's captured strongly iff the variable has __strong
5296 // lifetime. In MRR, it's captured strongly if the variable is
5297 // __block and has an appropriate type.
5298 if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
5299 return false;
5300
5301 owner.Variable = var;
Jordan Rosee10f4d32012-09-15 02:48:31 +00005302 if (ref)
5303 owner.setLocsFrom(ref);
John McCallf85e1932011-06-15 23:02:42 +00005304 return true;
5305}
5306
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00005307static bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
John McCallf85e1932011-06-15 23:02:42 +00005308 while (true) {
5309 e = e->IgnoreParens();
5310 if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
5311 switch (cast->getCastKind()) {
5312 case CK_BitCast:
5313 case CK_LValueBitCast:
5314 case CK_LValueToRValue:
John McCall33e56f32011-09-10 06:18:15 +00005315 case CK_ARCReclaimReturnedObject:
John McCallf85e1932011-06-15 23:02:42 +00005316 e = cast->getSubExpr();
5317 continue;
5318
John McCallf85e1932011-06-15 23:02:42 +00005319 default:
5320 return false;
5321 }
5322 }
5323
5324 if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
5325 ObjCIvarDecl *ivar = ref->getDecl();
5326 if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
5327 return false;
5328
5329 // Try to find a retain cycle in the base.
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00005330 if (!findRetainCycleOwner(S, ref->getBase(), owner))
John McCallf85e1932011-06-15 23:02:42 +00005331 return false;
5332
5333 if (ref->isFreeIvar()) owner.setLocsFrom(ref);
5334 owner.Indirect = true;
5335 return true;
5336 }
5337
5338 if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
5339 VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
5340 if (!var) return false;
5341 return considerVariable(var, ref, owner);
5342 }
5343
John McCallf85e1932011-06-15 23:02:42 +00005344 if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
5345 if (member->isArrow()) return false;
5346
5347 // Don't count this as an indirect ownership.
5348 e = member->getBase();
5349 continue;
5350 }
5351
John McCall4b9c2d22011-11-06 09:01:30 +00005352 if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
5353 // Only pay attention to pseudo-objects on property references.
5354 ObjCPropertyRefExpr *pre
5355 = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
5356 ->IgnoreParens());
5357 if (!pre) return false;
5358 if (pre->isImplicitProperty()) return false;
5359 ObjCPropertyDecl *property = pre->getExplicitProperty();
5360 if (!property->isRetaining() &&
5361 !(property->getPropertyIvarDecl() &&
5362 property->getPropertyIvarDecl()->getType()
5363 .getObjCLifetime() == Qualifiers::OCL_Strong))
5364 return false;
5365
5366 owner.Indirect = true;
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00005367 if (pre->isSuperReceiver()) {
5368 owner.Variable = S.getCurMethodDecl()->getSelfDecl();
5369 if (!owner.Variable)
5370 return false;
5371 owner.Loc = pre->getLocation();
5372 owner.Range = pre->getSourceRange();
5373 return true;
5374 }
John McCall4b9c2d22011-11-06 09:01:30 +00005375 e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
5376 ->getSourceExpr());
5377 continue;
5378 }
5379
John McCallf85e1932011-06-15 23:02:42 +00005380 // Array ivars?
5381
5382 return false;
5383 }
5384}
5385
5386namespace {
5387 struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
5388 FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
5389 : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
5390 Variable(variable), Capturer(0) {}
5391
5392 VarDecl *Variable;
5393 Expr *Capturer;
5394
5395 void VisitDeclRefExpr(DeclRefExpr *ref) {
5396 if (ref->getDecl() == Variable && !Capturer)
5397 Capturer = ref;
5398 }
5399
John McCallf85e1932011-06-15 23:02:42 +00005400 void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
5401 if (Capturer) return;
5402 Visit(ref->getBase());
5403 if (Capturer && ref->isFreeIvar())
5404 Capturer = ref;
5405 }
5406
5407 void VisitBlockExpr(BlockExpr *block) {
5408 // Look inside nested blocks
5409 if (block->getBlockDecl()->capturesVariable(Variable))
5410 Visit(block->getBlockDecl()->getBody());
5411 }
Fariborz Jahanian7e2e4c32012-08-31 20:04:47 +00005412
5413 void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) {
5414 if (Capturer) return;
5415 if (OVE->getSourceExpr())
5416 Visit(OVE->getSourceExpr());
5417 }
John McCallf85e1932011-06-15 23:02:42 +00005418 };
5419}
5420
5421/// Check whether the given argument is a block which captures a
5422/// variable.
5423static Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
5424 assert(owner.Variable && owner.Loc.isValid());
5425
5426 e = e->IgnoreParenCasts();
5427 BlockExpr *block = dyn_cast<BlockExpr>(e);
5428 if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
5429 return 0;
5430
5431 FindCaptureVisitor visitor(S.Context, owner.Variable);
5432 visitor.Visit(block->getBlockDecl()->getBody());
5433 return visitor.Capturer;
5434}
5435
5436static void diagnoseRetainCycle(Sema &S, Expr *capturer,
5437 RetainCycleOwner &owner) {
5438 assert(capturer);
5439 assert(owner.Variable && owner.Loc.isValid());
5440
5441 S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
5442 << owner.Variable << capturer->getSourceRange();
5443 S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
5444 << owner.Indirect << owner.Range;
5445}
5446
5447/// Check for a keyword selector that starts with the word 'add' or
5448/// 'set'.
5449static bool isSetterLikeSelector(Selector sel) {
5450 if (sel.isUnarySelector()) return false;
5451
Chris Lattner5f9e2722011-07-23 10:55:15 +00005452 StringRef str = sel.getNameForSlot(0);
John McCallf85e1932011-06-15 23:02:42 +00005453 while (!str.empty() && str.front() == '_') str = str.substr(1);
Ted Kremenek968a0ee2011-12-01 00:59:21 +00005454 if (str.startswith("set"))
John McCallf85e1932011-06-15 23:02:42 +00005455 str = str.substr(3);
Ted Kremenek968a0ee2011-12-01 00:59:21 +00005456 else if (str.startswith("add")) {
5457 // Specially whitelist 'addOperationWithBlock:'.
5458 if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
5459 return false;
5460 str = str.substr(3);
5461 }
John McCallf85e1932011-06-15 23:02:42 +00005462 else
5463 return false;
5464
5465 if (str.empty()) return true;
5466 return !islower(str.front());
5467}
5468
5469/// Check a message send to see if it's likely to cause a retain cycle.
5470void Sema::checkRetainCycles(ObjCMessageExpr *msg) {
5471 // Only check instance methods whose selector looks like a setter.
5472 if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
5473 return;
5474
5475 // Try to find a variable that the receiver is strongly owned by.
5476 RetainCycleOwner owner;
5477 if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00005478 if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
John McCallf85e1932011-06-15 23:02:42 +00005479 return;
5480 } else {
5481 assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
5482 owner.Variable = getCurMethodDecl()->getSelfDecl();
5483 owner.Loc = msg->getSuperLoc();
5484 owner.Range = msg->getSuperLoc();
5485 }
5486
5487 // Check whether the receiver is captured by any of the arguments.
5488 for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
5489 if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
5490 return diagnoseRetainCycle(*this, capturer, owner);
5491}
5492
5493/// Check a property assign to see if it's likely to cause a retain cycle.
5494void Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
5495 RetainCycleOwner owner;
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00005496 if (!findRetainCycleOwner(*this, receiver, owner))
John McCallf85e1932011-06-15 23:02:42 +00005497 return;
5498
5499 if (Expr *capturer = findCapturingExpr(*this, argument, owner))
5500 diagnoseRetainCycle(*this, capturer, owner);
5501}
5502
Jordan Rosee10f4d32012-09-15 02:48:31 +00005503void Sema::checkRetainCycles(VarDecl *Var, Expr *Init) {
5504 RetainCycleOwner Owner;
5505 if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner))
5506 return;
5507
5508 // Because we don't have an expression for the variable, we have to set the
5509 // location explicitly here.
5510 Owner.Loc = Var->getLocation();
5511 Owner.Range = Var->getSourceRange();
5512
5513 if (Expr *Capturer = findCapturingExpr(*this, Init, Owner))
5514 diagnoseRetainCycle(*this, Capturer, Owner);
5515}
5516
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005517bool Sema::checkUnsafeAssigns(SourceLocation Loc,
John McCallf85e1932011-06-15 23:02:42 +00005518 QualType LHS, Expr *RHS) {
5519 Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
5520 if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005521 return false;
5522 // strip off any implicit cast added to get to the one arc-specific
5523 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
John McCall33e56f32011-09-10 06:18:15 +00005524 if (cast->getCastKind() == CK_ARCConsumeObject) {
John McCallf85e1932011-06-15 23:02:42 +00005525 Diag(Loc, diag::warn_arc_retained_assign)
Fariborz Jahanianbd2e27e2012-07-06 21:09:27 +00005526 << (LT == Qualifiers::OCL_ExplicitNone) << 1
John McCallf85e1932011-06-15 23:02:42 +00005527 << RHS->getSourceRange();
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005528 return true;
5529 }
5530 RHS = cast->getSubExpr();
5531 }
5532 return false;
John McCallf85e1932011-06-15 23:02:42 +00005533}
5534
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005535void Sema::checkUnsafeExprAssigns(SourceLocation Loc,
5536 Expr *LHS, Expr *RHS) {
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00005537 QualType LHSType;
5538 // PropertyRef on LHS type need be directly obtained from
5539 // its declaration as it has a PsuedoType.
5540 ObjCPropertyRefExpr *PRE
5541 = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
5542 if (PRE && !PRE->isImplicitProperty()) {
5543 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
5544 if (PD)
5545 LHSType = PD->getType();
5546 }
5547
5548 if (LHSType.isNull())
5549 LHSType = LHS->getType();
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005550 if (checkUnsafeAssigns(Loc, LHSType, RHS))
5551 return;
5552 Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
5553 // FIXME. Check for other life times.
5554 if (LT != Qualifiers::OCL_None)
5555 return;
5556
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00005557 if (PRE) {
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005558 if (PRE->isImplicitProperty())
5559 return;
5560 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
5561 if (!PD)
5562 return;
5563
5564 unsigned Attributes = PD->getPropertyAttributes();
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00005565 if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
5566 // when 'assign' attribute was not explicitly specified
5567 // by user, ignore it and rely on property type itself
5568 // for lifetime info.
5569 unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
5570 if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
5571 LHSType->isObjCRetainableType())
5572 return;
5573
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005574 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
John McCall33e56f32011-09-10 06:18:15 +00005575 if (cast->getCastKind() == CK_ARCConsumeObject) {
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005576 Diag(Loc, diag::warn_arc_retained_property_assign)
5577 << RHS->getSourceRange();
5578 return;
5579 }
5580 RHS = cast->getSubExpr();
5581 }
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00005582 }
Fariborz Jahanianbd2e27e2012-07-06 21:09:27 +00005583 else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) {
5584 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
5585 if (cast->getCastKind() == CK_ARCConsumeObject) {
5586 Diag(Loc, diag::warn_arc_retained_assign)
5587 << 0 << 0<< RHS->getSourceRange();
5588 return;
5589 }
5590 RHS = cast->getSubExpr();
5591 }
5592 }
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005593 }
5594}
Dmitri Gribenko625bb562012-02-14 22:14:32 +00005595
5596//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===//
5597
5598namespace {
5599bool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr,
5600 SourceLocation StmtLoc,
5601 const NullStmt *Body) {
5602 // Do not warn if the body is a macro that expands to nothing, e.g:
5603 //
5604 // #define CALL(x)
5605 // if (condition)
5606 // CALL(0);
5607 //
5608 if (Body->hasLeadingEmptyMacro())
5609 return false;
5610
5611 // Get line numbers of statement and body.
5612 bool StmtLineInvalid;
5613 unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc,
5614 &StmtLineInvalid);
5615 if (StmtLineInvalid)
5616 return false;
5617
5618 bool BodyLineInvalid;
5619 unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(),
5620 &BodyLineInvalid);
5621 if (BodyLineInvalid)
5622 return false;
5623
5624 // Warn if null statement and body are on the same line.
5625 if (StmtLine != BodyLine)
5626 return false;
5627
5628 return true;
5629}
5630} // Unnamed namespace
5631
5632void Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc,
5633 const Stmt *Body,
5634 unsigned DiagID) {
5635 // Since this is a syntactic check, don't emit diagnostic for template
5636 // instantiations, this just adds noise.
5637 if (CurrentInstantiationScope)
5638 return;
5639
5640 // The body should be a null statement.
5641 const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5642 if (!NBody)
5643 return;
5644
5645 // Do the usual checks.
5646 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5647 return;
5648
5649 Diag(NBody->getSemiLoc(), DiagID);
5650 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5651}
5652
5653void Sema::DiagnoseEmptyLoopBody(const Stmt *S,
5654 const Stmt *PossibleBody) {
5655 assert(!CurrentInstantiationScope); // Ensured by caller
5656
5657 SourceLocation StmtLoc;
5658 const Stmt *Body;
5659 unsigned DiagID;
5660 if (const ForStmt *FS = dyn_cast<ForStmt>(S)) {
5661 StmtLoc = FS->getRParenLoc();
5662 Body = FS->getBody();
5663 DiagID = diag::warn_empty_for_body;
5664 } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) {
5665 StmtLoc = WS->getCond()->getSourceRange().getEnd();
5666 Body = WS->getBody();
5667 DiagID = diag::warn_empty_while_body;
5668 } else
5669 return; // Neither `for' nor `while'.
5670
5671 // The body should be a null statement.
5672 const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5673 if (!NBody)
5674 return;
5675
5676 // Skip expensive checks if diagnostic is disabled.
5677 if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) ==
5678 DiagnosticsEngine::Ignored)
5679 return;
5680
5681 // Do the usual checks.
5682 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5683 return;
5684
5685 // `for(...);' and `while(...);' are popular idioms, so in order to keep
5686 // noise level low, emit diagnostics only if for/while is followed by a
5687 // CompoundStmt, e.g.:
5688 // for (int i = 0; i < n; i++);
5689 // {
5690 // a(i);
5691 // }
5692 // or if for/while is followed by a statement with more indentation
5693 // than for/while itself:
5694 // for (int i = 0; i < n; i++);
5695 // a(i);
5696 bool ProbableTypo = isa<CompoundStmt>(PossibleBody);
5697 if (!ProbableTypo) {
5698 bool BodyColInvalid;
5699 unsigned BodyCol = SourceMgr.getPresumedColumnNumber(
5700 PossibleBody->getLocStart(),
5701 &BodyColInvalid);
5702 if (BodyColInvalid)
5703 return;
5704
5705 bool StmtColInvalid;
5706 unsigned StmtCol = SourceMgr.getPresumedColumnNumber(
5707 S->getLocStart(),
5708 &StmtColInvalid);
5709 if (StmtColInvalid)
5710 return;
5711
5712 if (BodyCol > StmtCol)
5713 ProbableTypo = true;
5714 }
5715
5716 if (ProbableTypo) {
5717 Diag(NBody->getSemiLoc(), DiagID);
5718 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5719 }
5720}
Dmitri Gribenko0d5a0692012-08-17 00:08:38 +00005721
5722//===--- Layout compatibility ----------------------------------------------//
5723
5724namespace {
5725
5726bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2);
5727
5728/// \brief Check if two enumeration types are layout-compatible.
5729bool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) {
5730 // C++11 [dcl.enum] p8:
5731 // Two enumeration types are layout-compatible if they have the same
5732 // underlying type.
5733 return ED1->isComplete() && ED2->isComplete() &&
5734 C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType());
5735}
5736
5737/// \brief Check if two fields are layout-compatible.
5738bool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) {
5739 if (!isLayoutCompatible(C, Field1->getType(), Field2->getType()))
5740 return false;
5741
5742 if (Field1->isBitField() != Field2->isBitField())
5743 return false;
5744
5745 if (Field1->isBitField()) {
5746 // Make sure that the bit-fields are the same length.
5747 unsigned Bits1 = Field1->getBitWidthValue(C);
5748 unsigned Bits2 = Field2->getBitWidthValue(C);
5749
5750 if (Bits1 != Bits2)
5751 return false;
5752 }
5753
5754 return true;
5755}
5756
5757/// \brief Check if two standard-layout structs are layout-compatible.
5758/// (C++11 [class.mem] p17)
5759bool isLayoutCompatibleStruct(ASTContext &C,
5760 RecordDecl *RD1,
5761 RecordDecl *RD2) {
5762 // If both records are C++ classes, check that base classes match.
5763 if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) {
5764 // If one of records is a CXXRecordDecl we are in C++ mode,
5765 // thus the other one is a CXXRecordDecl, too.
5766 const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2);
5767 // Check number of base classes.
5768 if (D1CXX->getNumBases() != D2CXX->getNumBases())
5769 return false;
5770
5771 // Check the base classes.
5772 for (CXXRecordDecl::base_class_const_iterator
5773 Base1 = D1CXX->bases_begin(),
5774 BaseEnd1 = D1CXX->bases_end(),
5775 Base2 = D2CXX->bases_begin();
5776 Base1 != BaseEnd1;
5777 ++Base1, ++Base2) {
5778 if (!isLayoutCompatible(C, Base1->getType(), Base2->getType()))
5779 return false;
5780 }
5781 } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) {
5782 // If only RD2 is a C++ class, it should have zero base classes.
5783 if (D2CXX->getNumBases() > 0)
5784 return false;
5785 }
5786
5787 // Check the fields.
5788 RecordDecl::field_iterator Field2 = RD2->field_begin(),
5789 Field2End = RD2->field_end(),
5790 Field1 = RD1->field_begin(),
5791 Field1End = RD1->field_end();
5792 for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) {
5793 if (!isLayoutCompatible(C, *Field1, *Field2))
5794 return false;
5795 }
5796 if (Field1 != Field1End || Field2 != Field2End)
5797 return false;
5798
5799 return true;
5800}
5801
5802/// \brief Check if two standard-layout unions are layout-compatible.
5803/// (C++11 [class.mem] p18)
5804bool isLayoutCompatibleUnion(ASTContext &C,
5805 RecordDecl *RD1,
5806 RecordDecl *RD2) {
5807 llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields;
5808 for (RecordDecl::field_iterator Field2 = RD2->field_begin(),
5809 Field2End = RD2->field_end();
5810 Field2 != Field2End; ++Field2) {
5811 UnmatchedFields.insert(*Field2);
5812 }
5813
5814 for (RecordDecl::field_iterator Field1 = RD1->field_begin(),
5815 Field1End = RD1->field_end();
5816 Field1 != Field1End; ++Field1) {
5817 llvm::SmallPtrSet<FieldDecl *, 8>::iterator
5818 I = UnmatchedFields.begin(),
5819 E = UnmatchedFields.end();
5820
5821 for ( ; I != E; ++I) {
5822 if (isLayoutCompatible(C, *Field1, *I)) {
5823 bool Result = UnmatchedFields.erase(*I);
5824 (void) Result;
5825 assert(Result);
5826 break;
5827 }
5828 }
5829 if (I == E)
5830 return false;
5831 }
5832
5833 return UnmatchedFields.empty();
5834}
5835
5836bool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) {
5837 if (RD1->isUnion() != RD2->isUnion())
5838 return false;
5839
5840 if (RD1->isUnion())
5841 return isLayoutCompatibleUnion(C, RD1, RD2);
5842 else
5843 return isLayoutCompatibleStruct(C, RD1, RD2);
5844}
5845
5846/// \brief Check if two types are layout-compatible in C++11 sense.
5847bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) {
5848 if (T1.isNull() || T2.isNull())
5849 return false;
5850
5851 // C++11 [basic.types] p11:
5852 // If two types T1 and T2 are the same type, then T1 and T2 are
5853 // layout-compatible types.
5854 if (C.hasSameType(T1, T2))
5855 return true;
5856
5857 T1 = T1.getCanonicalType().getUnqualifiedType();
5858 T2 = T2.getCanonicalType().getUnqualifiedType();
5859
5860 const Type::TypeClass TC1 = T1->getTypeClass();
5861 const Type::TypeClass TC2 = T2->getTypeClass();
5862
5863 if (TC1 != TC2)
5864 return false;
5865
5866 if (TC1 == Type::Enum) {
5867 return isLayoutCompatible(C,
5868 cast<EnumType>(T1)->getDecl(),
5869 cast<EnumType>(T2)->getDecl());
5870 } else if (TC1 == Type::Record) {
5871 if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType())
5872 return false;
5873
5874 return isLayoutCompatible(C,
5875 cast<RecordType>(T1)->getDecl(),
5876 cast<RecordType>(T2)->getDecl());
5877 }
5878
5879 return false;
5880}
5881}
5882
5883//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----//
5884
5885namespace {
5886/// \brief Given a type tag expression find the type tag itself.
5887///
5888/// \param TypeExpr Type tag expression, as it appears in user's code.
5889///
5890/// \param VD Declaration of an identifier that appears in a type tag.
5891///
5892/// \param MagicValue Type tag magic value.
5893bool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx,
5894 const ValueDecl **VD, uint64_t *MagicValue) {
5895 while(true) {
5896 if (!TypeExpr)
5897 return false;
5898
5899 TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts();
5900
5901 switch (TypeExpr->getStmtClass()) {
5902 case Stmt::UnaryOperatorClass: {
5903 const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr);
5904 if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) {
5905 TypeExpr = UO->getSubExpr();
5906 continue;
5907 }
5908 return false;
5909 }
5910
5911 case Stmt::DeclRefExprClass: {
5912 const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr);
5913 *VD = DRE->getDecl();
5914 return true;
5915 }
5916
5917 case Stmt::IntegerLiteralClass: {
5918 const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr);
5919 llvm::APInt MagicValueAPInt = IL->getValue();
5920 if (MagicValueAPInt.getActiveBits() <= 64) {
5921 *MagicValue = MagicValueAPInt.getZExtValue();
5922 return true;
5923 } else
5924 return false;
5925 }
5926
5927 case Stmt::BinaryConditionalOperatorClass:
5928 case Stmt::ConditionalOperatorClass: {
5929 const AbstractConditionalOperator *ACO =
5930 cast<AbstractConditionalOperator>(TypeExpr);
5931 bool Result;
5932 if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) {
5933 if (Result)
5934 TypeExpr = ACO->getTrueExpr();
5935 else
5936 TypeExpr = ACO->getFalseExpr();
5937 continue;
5938 }
5939 return false;
5940 }
5941
5942 case Stmt::BinaryOperatorClass: {
5943 const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr);
5944 if (BO->getOpcode() == BO_Comma) {
5945 TypeExpr = BO->getRHS();
5946 continue;
5947 }
5948 return false;
5949 }
5950
5951 default:
5952 return false;
5953 }
5954 }
5955}
5956
5957/// \brief Retrieve the C type corresponding to type tag TypeExpr.
5958///
5959/// \param TypeExpr Expression that specifies a type tag.
5960///
5961/// \param MagicValues Registered magic values.
5962///
5963/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong
5964/// kind.
5965///
5966/// \param TypeInfo Information about the corresponding C type.
5967///
5968/// \returns true if the corresponding C type was found.
5969bool GetMatchingCType(
5970 const IdentifierInfo *ArgumentKind,
5971 const Expr *TypeExpr, const ASTContext &Ctx,
5972 const llvm::DenseMap<Sema::TypeTagMagicValue,
5973 Sema::TypeTagData> *MagicValues,
5974 bool &FoundWrongKind,
5975 Sema::TypeTagData &TypeInfo) {
5976 FoundWrongKind = false;
5977
5978 // Variable declaration that has type_tag_for_datatype attribute.
5979 const ValueDecl *VD = NULL;
5980
5981 uint64_t MagicValue;
5982
5983 if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue))
5984 return false;
5985
5986 if (VD) {
5987 for (specific_attr_iterator<TypeTagForDatatypeAttr>
5988 I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(),
5989 E = VD->specific_attr_end<TypeTagForDatatypeAttr>();
5990 I != E; ++I) {
5991 if (I->getArgumentKind() != ArgumentKind) {
5992 FoundWrongKind = true;
5993 return false;
5994 }
5995 TypeInfo.Type = I->getMatchingCType();
5996 TypeInfo.LayoutCompatible = I->getLayoutCompatible();
5997 TypeInfo.MustBeNull = I->getMustBeNull();
5998 return true;
5999 }
6000 return false;
6001 }
6002
6003 if (!MagicValues)
6004 return false;
6005
6006 llvm::DenseMap<Sema::TypeTagMagicValue,
6007 Sema::TypeTagData>::const_iterator I =
6008 MagicValues->find(std::make_pair(ArgumentKind, MagicValue));
6009 if (I == MagicValues->end())
6010 return false;
6011
6012 TypeInfo = I->second;
6013 return true;
6014}
6015} // unnamed namespace
6016
6017void Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind,
6018 uint64_t MagicValue, QualType Type,
6019 bool LayoutCompatible,
6020 bool MustBeNull) {
6021 if (!TypeTagForDatatypeMagicValues)
6022 TypeTagForDatatypeMagicValues.reset(
6023 new llvm::DenseMap<TypeTagMagicValue, TypeTagData>);
6024
6025 TypeTagMagicValue Magic(ArgumentKind, MagicValue);
6026 (*TypeTagForDatatypeMagicValues)[Magic] =
6027 TypeTagData(Type, LayoutCompatible, MustBeNull);
6028}
6029
6030namespace {
6031bool IsSameCharType(QualType T1, QualType T2) {
6032 const BuiltinType *BT1 = T1->getAs<BuiltinType>();
6033 if (!BT1)
6034 return false;
6035
6036 const BuiltinType *BT2 = T2->getAs<BuiltinType>();
6037 if (!BT2)
6038 return false;
6039
6040 BuiltinType::Kind T1Kind = BT1->getKind();
6041 BuiltinType::Kind T2Kind = BT2->getKind();
6042
6043 return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) ||
6044 (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) ||
6045 (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) ||
6046 (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar);
6047}
6048} // unnamed namespace
6049
6050void Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr,
6051 const Expr * const *ExprArgs) {
6052 const IdentifierInfo *ArgumentKind = Attr->getArgumentKind();
6053 bool IsPointerAttr = Attr->getIsPointer();
6054
6055 const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()];
6056 bool FoundWrongKind;
6057 TypeTagData TypeInfo;
6058 if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context,
6059 TypeTagForDatatypeMagicValues.get(),
6060 FoundWrongKind, TypeInfo)) {
6061 if (FoundWrongKind)
6062 Diag(TypeTagExpr->getExprLoc(),
6063 diag::warn_type_tag_for_datatype_wrong_kind)
6064 << TypeTagExpr->getSourceRange();
6065 return;
6066 }
6067
6068 const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()];
6069 if (IsPointerAttr) {
6070 // Skip implicit cast of pointer to `void *' (as a function argument).
6071 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr))
6072 if (ICE->getType()->isVoidPointerType())
6073 ArgumentExpr = ICE->getSubExpr();
6074 }
6075 QualType ArgumentType = ArgumentExpr->getType();
6076
6077 // Passing a `void*' pointer shouldn't trigger a warning.
6078 if (IsPointerAttr && ArgumentType->isVoidPointerType())
6079 return;
6080
6081 if (TypeInfo.MustBeNull) {
6082 // Type tag with matching void type requires a null pointer.
6083 if (!ArgumentExpr->isNullPointerConstant(Context,
6084 Expr::NPC_ValueDependentIsNotNull)) {
6085 Diag(ArgumentExpr->getExprLoc(),
6086 diag::warn_type_safety_null_pointer_required)
6087 << ArgumentKind->getName()
6088 << ArgumentExpr->getSourceRange()
6089 << TypeTagExpr->getSourceRange();
6090 }
6091 return;
6092 }
6093
6094 QualType RequiredType = TypeInfo.Type;
6095 if (IsPointerAttr)
6096 RequiredType = Context.getPointerType(RequiredType);
6097
6098 bool mismatch = false;
6099 if (!TypeInfo.LayoutCompatible) {
6100 mismatch = !Context.hasSameType(ArgumentType, RequiredType);
6101
6102 // C++11 [basic.fundamental] p1:
6103 // Plain char, signed char, and unsigned char are three distinct types.
6104 //
6105 // But we treat plain `char' as equivalent to `signed char' or `unsigned
6106 // char' depending on the current char signedness mode.
6107 if (mismatch)
6108 if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(),
6109 RequiredType->getPointeeType())) ||
6110 (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType)))
6111 mismatch = false;
6112 } else
6113 if (IsPointerAttr)
6114 mismatch = !isLayoutCompatible(Context,
6115 ArgumentType->getPointeeType(),
6116 RequiredType->getPointeeType());
6117 else
6118 mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType);
6119
6120 if (mismatch)
6121 Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch)
6122 << ArgumentType << ArgumentKind->getName()
6123 << TypeInfo.LayoutCompatible << RequiredType
6124 << ArgumentExpr->getSourceRange()
6125 << TypeTagExpr->getSourceRange();
6126}
6127