blob: 318be5bf107a88542cdef12160b8ab55d0b5d9e9 [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Chandler Carruth55fc8732012-12-04 09:13:33 +000017#include "clang/AST/Attr.h"
18#include "clang/Basic/SourceManager.h"
19#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000020#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000021#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Jordan Rosef540c542012-07-26 21:39:41 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Chandler Carruth55fc8732012-12-04 09:13:33 +000023#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
25#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000026#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000027#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Benjamin Kramer2fa67ef2012-12-01 15:09:41 +000029#include "llvm/ADT/SmallString.h"
Jordan Rose615a0922012-09-22 01:24:42 +000030#include "llvm/ADT/StringExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000031#include <climits>
32
Zhongxing Xu589c0f22009-11-12 08:38:56 +000033using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000034using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000035
36namespace {
37
Anton Yartsev849c7bf2013-03-28 17:05:19 +000038// Used to check correspondence between allocators and deallocators.
39enum AllocationFamily {
40 AF_None,
41 AF_Malloc,
42 AF_CXXNew,
43 AF_CXXNewArray
44};
45
Zhongxing Xu7fb14642009-12-11 00:55:44 +000046class RefState {
Anna Zaks050cdd72012-06-20 20:57:46 +000047 enum Kind { // Reference to allocated memory.
48 Allocated,
49 // Reference to released/freed memory.
50 Released,
Anna Zaks050cdd72012-06-20 20:57:46 +000051 // The responsibility for freeing resources has transfered from
52 // this reference. A relinquished symbol should not be freed.
Anton Yartsev849c7bf2013-03-28 17:05:19 +000053 Relinquished };
54
Zhongxing Xu243fde92009-11-17 07:54:15 +000055 const Stmt *S;
Anton Yartsev849c7bf2013-03-28 17:05:19 +000056 unsigned K : 2; // Kind enum, but stored as a bitfield.
57 unsigned Family : 30; // Rest of 32-bit word, currently just an allocation
58 // family.
Zhongxing Xu243fde92009-11-17 07:54:15 +000059
Anton Yartsev849c7bf2013-03-28 17:05:19 +000060 RefState(Kind k, const Stmt *s, unsigned family)
Eric Christopher03852c82013-03-28 18:22:58 +000061 : S(s), K(k), Family(family) {}
Zhongxing Xu7fb14642009-12-11 00:55:44 +000062public:
Anna Zaks050cdd72012-06-20 20:57:46 +000063 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000064 bool isReleased() const { return K == Released; }
Anna Zaks050cdd72012-06-20 20:57:46 +000065 bool isRelinquished() const { return K == Relinquished; }
Anton Yartsev849c7bf2013-03-28 17:05:19 +000066 AllocationFamily getAllocationFamily() const {
67 return (AllocationFamily)Family;
68 }
Anna Zaksc8bb3be2012-02-13 18:05:39 +000069 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000070
71 bool operator==(const RefState &X) const {
Anton Yartsev849c7bf2013-03-28 17:05:19 +000072 return K == X.K && S == X.S && Family == X.Family;
Zhongxing Xu243fde92009-11-17 07:54:15 +000073 }
74
Anton Yartsev849c7bf2013-03-28 17:05:19 +000075 static RefState getAllocated(unsigned family, const Stmt *s) {
76 return RefState(Allocated, s, family);
Zhongxing Xub94b81a2009-12-31 06:13:07 +000077 }
Anton Yartsev849c7bf2013-03-28 17:05:19 +000078 static RefState getReleased(unsigned family, const Stmt *s) {
79 return RefState(Released, s, family);
80 }
81 static RefState getRelinquished(unsigned family, const Stmt *s) {
82 return RefState(Relinquished, s, family);
Ted Kremenekdde201b2010-08-06 21:12:55 +000083 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000084
85 void Profile(llvm::FoldingSetNodeID &ID) const {
86 ID.AddInteger(K);
87 ID.AddPointer(S);
Anton Yartsev849c7bf2013-03-28 17:05:19 +000088 ID.AddInteger(Family);
Zhongxing Xu243fde92009-11-17 07:54:15 +000089 }
Ted Kremenekc37fad62013-01-03 01:30:12 +000090
Dmitri Gribenkocfa88f82013-01-12 19:30:44 +000091 void dump(raw_ostream &OS) const {
Ted Kremenekc37fad62013-01-03 01:30:12 +000092 static const char *Table[] = {
93 "Allocated",
94 "Released",
95 "Relinquished"
96 };
97 OS << Table[(unsigned) K];
98 }
99
100 LLVM_ATTRIBUTE_USED void dump() const {
101 dump(llvm::errs());
102 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000103};
104
Anna Zaks9dc298b2012-09-12 22:57:34 +0000105enum ReallocPairKind {
106 RPToBeFreedAfterFailure,
107 // The symbol has been freed when reallocation failed.
108 RPIsFreeOnFailure,
109 // The symbol does not need to be freed after reallocation fails.
110 RPDoNotTrackAfterFailure
111};
112
Anna Zaks55dd9562012-08-24 02:28:20 +0000113/// \class ReallocPair
114/// \brief Stores information about the symbol being reallocated by a call to
115/// 'realloc' to allow modeling failed reallocation later in the path.
Anna Zaks40add292012-02-15 00:11:25 +0000116struct ReallocPair {
Anna Zaks55dd9562012-08-24 02:28:20 +0000117 // \brief The symbol which realloc reallocated.
Anna Zaks40add292012-02-15 00:11:25 +0000118 SymbolRef ReallocatedSym;
Anna Zaks9dc298b2012-09-12 22:57:34 +0000119 ReallocPairKind Kind;
Anna Zaks55dd9562012-08-24 02:28:20 +0000120
Anna Zaks9dc298b2012-09-12 22:57:34 +0000121 ReallocPair(SymbolRef S, ReallocPairKind K) :
122 ReallocatedSym(S), Kind(K) {}
Anna Zaks40add292012-02-15 00:11:25 +0000123 void Profile(llvm::FoldingSetNodeID &ID) const {
Anna Zaks9dc298b2012-09-12 22:57:34 +0000124 ID.AddInteger(Kind);
Anna Zaks40add292012-02-15 00:11:25 +0000125 ID.AddPointer(ReallocatedSym);
126 }
127 bool operator==(const ReallocPair &X) const {
128 return ReallocatedSym == X.ReallocatedSym &&
Anna Zaks9dc298b2012-09-12 22:57:34 +0000129 Kind == X.Kind;
Anna Zaks40add292012-02-15 00:11:25 +0000130 }
131};
132
Anna Zaks97bfb552013-01-08 00:25:29 +0000133typedef std::pair<const ExplodedNode*, const MemRegion*> LeakInfo;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000134
Anna Zaksb319e022012-02-08 20:13:28 +0000135class MallocChecker : public Checker<check::DeadSymbols,
Anna Zaksbf53dfa2012-12-20 00:38:25 +0000136 check::PointerEscape,
Anna Zaks41988f32013-03-28 23:15:29 +0000137 check::ConstPointerEscape,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000138 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +0000139 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +0000140 check::PostStmt<CallExpr>,
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000141 check::PostStmt<CXXNewExpr>,
142 check::PreStmt<CXXDeleteExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000143 check::PostStmt<BlockExpr>,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000144 check::PostObjCMessage,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000145 check::Location,
Anna Zaksbf53dfa2012-12-20 00:38:25 +0000146 eval::Assume>
Ted Kremeneke3659a72012-01-04 23:48:37 +0000147{
Anna Zaksfebdc322012-02-16 22:26:12 +0000148 mutable OwningPtr<BugType> BT_DoubleFree;
149 mutable OwningPtr<BugType> BT_Leak;
150 mutable OwningPtr<BugType> BT_UseFree;
151 mutable OwningPtr<BugType> BT_BadFree;
Anton Yartsev648cb712013-04-04 23:46:29 +0000152 mutable OwningPtr<BugType> BT_MismatchedDealloc;
Anna Zaks118aa752013-02-07 23:05:47 +0000153 mutable OwningPtr<BugType> BT_OffsetFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000154 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000155 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
156
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000157public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000158 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000159 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000160
161 /// In pessimistic mode, the checker assumes that it does not know which
162 /// functions might free the memory.
163 struct ChecksFilter {
164 DefaultBool CMallocPessimistic;
165 DefaultBool CMallocOptimistic;
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000166 DefaultBool CNewDeleteChecker;
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000167 DefaultBool CMismatchedDeallocatorChecker;
Anna Zaks231361a2012-02-08 23:16:52 +0000168 };
169
170 ChecksFilter Filter;
171
Anna Zaks66c40402012-02-14 21:55:24 +0000172 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000173 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000174 void checkPostStmt(const CXXNewExpr *NE, CheckerContext &C) const;
175 void checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const;
Anna Zaks4141e4d2012-11-13 03:18:01 +0000176 void checkPostObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000177 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000178 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000179 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000180 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000181 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000182 void checkLocation(SVal l, bool isLoad, const Stmt *S,
183 CheckerContext &C) const;
Anna Zaksbf53dfa2012-12-20 00:38:25 +0000184
185 ProgramStateRef checkPointerEscape(ProgramStateRef State,
186 const InvalidatedSymbols &Escaped,
Anna Zaks233e26a2013-02-07 23:05:43 +0000187 const CallEvent *Call,
188 PointerEscapeKind Kind) const;
Anna Zaks41988f32013-03-28 23:15:29 +0000189 ProgramStateRef checkConstPointerEscape(ProgramStateRef State,
190 const InvalidatedSymbols &Escaped,
191 const CallEvent *Call,
192 PointerEscapeKind Kind) const;
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000193
Anna Zaks93c5a242012-05-02 00:05:20 +0000194 void printState(raw_ostream &Out, ProgramStateRef State,
195 const char *NL, const char *Sep) const;
196
Zhongxing Xu7b760962009-11-13 07:25:27 +0000197private:
Anna Zaks66c40402012-02-14 21:55:24 +0000198 void initIdentifierInfo(ASTContext &C) const;
199
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000200 /// \brief Determine family of a deallocation expression.
Anton Yartsev648cb712013-04-04 23:46:29 +0000201 AllocationFamily getAllocationFamily(CheckerContext &C, const Stmt *S) const;
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000202
203 /// \brief Print names of allocators and deallocators.
204 ///
205 /// \returns true on success.
206 bool printAllocDeallocName(raw_ostream &os, CheckerContext &C,
207 const Expr *E) const;
208
209 /// \brief Print expected name of an allocator based on the deallocator's
210 /// family derived from the DeallocExpr.
211 void printExpectedAllocName(raw_ostream &os, CheckerContext &C,
212 const Expr *DeallocExpr) const;
213 /// \brief Print expected name of a deallocator based on the allocator's
214 /// family.
215 void printExpectedDeallocName(raw_ostream &os, AllocationFamily Family) const;
216
Jordan Rose9fe09f32013-03-09 00:59:10 +0000217 ///@{
Anna Zaks66c40402012-02-14 21:55:24 +0000218 /// Check if this is one of the functions which can allocate/reallocate memory
219 /// pointed to by one of its arguments.
220 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks14345182012-05-18 01:16:10 +0000221 bool isFreeFunction(const FunctionDecl *FD, ASTContext &C) const;
222 bool isAllocationFunction(const FunctionDecl *FD, ASTContext &C) const;
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000223 bool isStandardNewDelete(const FunctionDecl *FD, ASTContext &C) const;
Jordan Rose9fe09f32013-03-09 00:59:10 +0000224 ///@}
Anna Zaks87cb5be2012-02-22 19:24:52 +0000225 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
226 const CallExpr *CE,
227 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000228 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000229 const Expr *SizeEx, SVal Init,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000230 ProgramStateRef State,
231 AllocationFamily Family = AF_Malloc) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000232 return MallocMemAux(C, CE,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000233 State->getSVal(SizeEx, C.getLocationContext()),
234 Init, State, Family);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000235 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000236
Ted Kremenek8bef8232012-01-26 21:29:00 +0000237 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000238 SVal SizeEx, SVal Init,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000239 ProgramStateRef State,
240 AllocationFamily Family = AF_Malloc);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000241
Anna Zaks87cb5be2012-02-22 19:24:52 +0000242 /// Update the RefState to reflect the new memory allocation.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000243 static ProgramStateRef
244 MallocUpdateRefState(CheckerContext &C, const Expr *E, ProgramStateRef State,
245 AllocationFamily Family = AF_Malloc);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000246
247 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
248 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000249 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000250 ProgramStateRef state, unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000251 bool Hold,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000252 bool &ReleasedAllocated,
253 bool ReturnsNullOnFailure = false) const;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000254 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
255 const Expr *ParentExpr,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000256 ProgramStateRef State,
Anna Zaks55dd9562012-08-24 02:28:20 +0000257 bool Hold,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000258 bool &ReleasedAllocated,
259 bool ReturnsNullOnFailure = false) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000260
Anna Zaks87cb5be2012-02-22 19:24:52 +0000261 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
262 bool FreesMemOnFailure) const;
263 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000264
Anna Zaks14345182012-05-18 01:16:10 +0000265 ///\brief Check if the memory associated with this symbol was released.
266 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
267
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000268 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, const Stmt *S) const;
Anna Zaks91c2a112012-02-08 23:16:56 +0000269
Jordan Rose9fe09f32013-03-09 00:59:10 +0000270 /// Check if the function is known not to free memory, or if it is
271 /// "interesting" and should be modeled explicitly.
272 ///
273 /// We assume that pointers do not escape through calls to system functions
274 /// not handled by this checker.
275 bool doesNotFreeMemOrInteresting(const CallEvent *Call,
276 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000277
Anna Zaks41988f32013-03-28 23:15:29 +0000278 // Implementation of the checkPointerEscape callabcks.
279 ProgramStateRef checkPointerEscapeAux(ProgramStateRef State,
280 const InvalidatedSymbols &Escaped,
281 const CallEvent *Call,
282 PointerEscapeKind Kind,
283 bool(*CheckRefState)(const RefState*)) const;
284
Anton Yartsev648cb712013-04-04 23:46:29 +0000285 // Used to suppress warnings if they are not related to the tracked family
286 // (derived from AllocDeallocStmt).
287 bool isTrackedFamily(AllocationFamily Family) const;
288 bool isTrackedFamily(CheckerContext &C, const Stmt *AllocDeallocStmt) const;
289 bool isTrackedFamily(CheckerContext &C, SymbolRef Sym) const;
290
Ted Kremenek9c378f72011-08-12 23:37:29 +0000291 static bool SummarizeValue(raw_ostream &os, SVal V);
292 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000293 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange Range,
294 const Expr *DeallocExpr) const;
Anton Yartsev648cb712013-04-04 23:46:29 +0000295 void ReportMismatchedDealloc(CheckerContext &C, SourceRange Range,
Anton Yartseva3ae9372013-04-05 11:25:10 +0000296 const Expr *DeallocExpr, const RefState *RS,
297 SymbolRef Sym) const;
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000298 void ReportOffsetFree(CheckerContext &C, SVal ArgVal, SourceRange Range,
299 const Expr *DeallocExpr,
300 const Expr *AllocExpr = 0) const;
Anton Yartsevbb369952013-03-13 14:39:10 +0000301 void ReportUseAfterFree(CheckerContext &C, SourceRange Range,
302 SymbolRef Sym) const;
303 void ReportDoubleFree(CheckerContext &C, SourceRange Range, bool Released,
Anton Yartsev3258d4b2013-03-13 17:07:32 +0000304 SymbolRef Sym, SymbolRef PrevSym) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000305
Anna Zaksca8e36e2012-02-23 21:38:21 +0000306 /// Find the location of the allocation for Sym on the path leading to the
307 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000308 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
309 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000310
Anna Zaksda046772012-02-11 21:02:40 +0000311 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
312
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000313 /// The bug visitor which allows us to print extra diagnostics along the
314 /// BugReport path. For example, showing the allocation site of the leaked
315 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000316 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000317 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000318 enum NotificationMode {
319 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000320 ReallocationFailed
321 };
322
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000323 // The allocated region symbol tracked by the main analysis.
324 SymbolRef Sym;
325
Anna Zaks88feba02012-05-10 01:37:40 +0000326 // The mode we are in, i.e. what kind of diagnostics will be emitted.
327 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000328
Anna Zaks88feba02012-05-10 01:37:40 +0000329 // A symbol from when the primary region should have been reallocated.
330 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000331
Anna Zaks88feba02012-05-10 01:37:40 +0000332 bool IsLeak;
333
334 public:
335 MallocBugVisitor(SymbolRef S, bool isLeak = false)
336 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000337
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000338 virtual ~MallocBugVisitor() {}
339
340 void Profile(llvm::FoldingSetNodeID &ID) const {
341 static int X = 0;
342 ID.AddPointer(&X);
343 ID.AddPointer(Sym);
344 }
345
Anna Zaksfe571602012-02-16 22:26:07 +0000346 inline bool isAllocated(const RefState *S, const RefState *SPrev,
347 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000348 // Did not track -> allocated. Other state (released) -> allocated.
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000349 return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXNewExpr>(Stmt)) &&
Anna Zaksfe571602012-02-16 22:26:07 +0000350 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000351 }
352
Anna Zaksfe571602012-02-16 22:26:07 +0000353 inline bool isReleased(const RefState *S, const RefState *SPrev,
354 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000355 // Did not track -> released. Other state (allocated) -> released.
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000356 return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXDeleteExpr>(Stmt)) &&
Anna Zaksfe571602012-02-16 22:26:07 +0000357 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
358 }
359
Anna Zaks5b7aa342012-06-22 02:04:31 +0000360 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
361 const Stmt *Stmt) {
362 // Did not track -> relinquished. Other state (allocated) -> relinquished.
363 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
364 isa<ObjCPropertyRefExpr>(Stmt)) &&
365 (S && S->isRelinquished()) &&
366 (!SPrev || !SPrev->isRelinquished()));
367 }
368
Anna Zaksfe571602012-02-16 22:26:07 +0000369 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
370 const Stmt *Stmt) {
371 // If the expression is not a call, and the state change is
372 // released -> allocated, it must be the realloc return value
373 // check. If we have to handle more cases here, it might be cleaner just
374 // to track this extra bit in the state itself.
375 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
376 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000377 }
378
379 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
380 const ExplodedNode *PrevN,
381 BugReporterContext &BRC,
382 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000383
384 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
385 const ExplodedNode *EndPathNode,
386 BugReport &BR) {
387 if (!IsLeak)
388 return 0;
389
390 PathDiagnosticLocation L =
391 PathDiagnosticLocation::createEndOfPath(EndPathNode,
392 BRC.getSourceManager());
393 // Do not add the statement itself as a range in case of leak.
394 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
395 }
396
Anna Zaks56a938f2012-03-16 23:24:20 +0000397 private:
398 class StackHintGeneratorForReallocationFailed
399 : public StackHintGeneratorForSymbol {
400 public:
401 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
402 : StackHintGeneratorForSymbol(S, M) {}
403
404 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
Jordan Rose615a0922012-09-22 01:24:42 +0000405 // Printed parameters start at 1, not 0.
406 ++ArgIndex;
407
Anna Zaks56a938f2012-03-16 23:24:20 +0000408 SmallString<200> buf;
409 llvm::raw_svector_ostream os(buf);
410
Jordan Rose615a0922012-09-22 01:24:42 +0000411 os << "Reallocation of " << ArgIndex << llvm::getOrdinalSuffix(ArgIndex)
412 << " parameter failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000413
414 return os.str();
415 }
416
417 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000418 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000419 }
420 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000421 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000422};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000423} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000424
Jordan Rose166d5022012-11-02 01:54:06 +0000425REGISTER_MAP_WITH_PROGRAMSTATE(RegionState, SymbolRef, RefState)
426REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair)
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000427
Anna Zaks4141e4d2012-11-13 03:18:01 +0000428// A map from the freed symbol to the symbol representing the return value of
429// the free function.
430REGISTER_MAP_WITH_PROGRAMSTATE(FreeReturnValue, SymbolRef, SymbolRef)
431
Anna Zaks4fb54872012-02-11 21:02:35 +0000432namespace {
433class StopTrackingCallback : public SymbolVisitor {
434 ProgramStateRef state;
435public:
436 StopTrackingCallback(ProgramStateRef st) : state(st) {}
437 ProgramStateRef getState() const { return state; }
438
439 bool VisitSymbol(SymbolRef sym) {
440 state = state->remove<RegionState>(sym);
441 return true;
442 }
443};
444} // end anonymous namespace
445
Anna Zaks66c40402012-02-14 21:55:24 +0000446void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksa38cb2c2012-05-18 22:47:40 +0000447 if (II_malloc)
448 return;
449 II_malloc = &Ctx.Idents.get("malloc");
450 II_free = &Ctx.Idents.get("free");
451 II_realloc = &Ctx.Idents.get("realloc");
452 II_reallocf = &Ctx.Idents.get("reallocf");
453 II_calloc = &Ctx.Idents.get("calloc");
454 II_valloc = &Ctx.Idents.get("valloc");
455 II_strdup = &Ctx.Idents.get("strdup");
456 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000457}
458
Anna Zaks66c40402012-02-14 21:55:24 +0000459bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +0000460 if (isFreeFunction(FD, C))
461 return true;
462
463 if (isAllocationFunction(FD, C))
464 return true;
465
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000466 if (isStandardNewDelete(FD, C))
467 return true;
468
Anna Zaks14345182012-05-18 01:16:10 +0000469 return false;
470}
471
472bool MallocChecker::isAllocationFunction(const FunctionDecl *FD,
473 ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000474 if (!FD)
475 return false;
Anna Zaks14345182012-05-18 01:16:10 +0000476
Jordan Rose5ef6e942012-07-10 23:13:01 +0000477 if (FD->getKind() == Decl::Function) {
478 IdentifierInfo *FunI = FD->getIdentifier();
479 initIdentifierInfo(C);
Anna Zaks66c40402012-02-14 21:55:24 +0000480
Jordan Rose5ef6e942012-07-10 23:13:01 +0000481 if (FunI == II_malloc || FunI == II_realloc ||
482 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
483 FunI == II_strdup || FunI == II_strndup)
484 return true;
485 }
Anna Zaks66c40402012-02-14 21:55:24 +0000486
Anna Zaks14345182012-05-18 01:16:10 +0000487 if (Filter.CMallocOptimistic && FD->hasAttrs())
488 for (specific_attr_iterator<OwnershipAttr>
489 i = FD->specific_attr_begin<OwnershipAttr>(),
490 e = FD->specific_attr_end<OwnershipAttr>();
491 i != e; ++i)
492 if ((*i)->getOwnKind() == OwnershipAttr::Returns)
493 return true;
494 return false;
495}
496
497bool MallocChecker::isFreeFunction(const FunctionDecl *FD, ASTContext &C) const {
498 if (!FD)
499 return false;
500
Jordan Rose5ef6e942012-07-10 23:13:01 +0000501 if (FD->getKind() == Decl::Function) {
502 IdentifierInfo *FunI = FD->getIdentifier();
503 initIdentifierInfo(C);
Anna Zaks14345182012-05-18 01:16:10 +0000504
Jordan Rose5ef6e942012-07-10 23:13:01 +0000505 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
506 return true;
507 }
Anna Zaks66c40402012-02-14 21:55:24 +0000508
Anna Zaks14345182012-05-18 01:16:10 +0000509 if (Filter.CMallocOptimistic && FD->hasAttrs())
510 for (specific_attr_iterator<OwnershipAttr>
511 i = FD->specific_attr_begin<OwnershipAttr>(),
512 e = FD->specific_attr_end<OwnershipAttr>();
513 i != e; ++i)
514 if ((*i)->getOwnKind() == OwnershipAttr::Takes ||
515 (*i)->getOwnKind() == OwnershipAttr::Holds)
516 return true;
Anna Zaks66c40402012-02-14 21:55:24 +0000517 return false;
518}
519
Anton Yartsev69746282013-03-28 16:10:38 +0000520// Tells if the callee is one of the following:
521// 1) A global non-placement new/delete operator function.
522// 2) A global placement operator function with the single placement argument
523// of type std::nothrow_t.
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000524bool MallocChecker::isStandardNewDelete(const FunctionDecl *FD,
525 ASTContext &C) const {
526 if (!FD)
527 return false;
528
529 OverloadedOperatorKind Kind = FD->getOverloadedOperator();
530 if (Kind != OO_New && Kind != OO_Array_New &&
531 Kind != OO_Delete && Kind != OO_Array_Delete)
532 return false;
533
Anton Yartsev69746282013-03-28 16:10:38 +0000534 // Skip all operator new/delete methods.
535 if (isa<CXXMethodDecl>(FD))
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000536 return false;
537
538 // Return true if tested operator is a standard placement nothrow operator.
539 if (FD->getNumParams() == 2) {
540 QualType T = FD->getParamDecl(1)->getType();
541 if (const IdentifierInfo *II = T.getBaseTypeIdentifier())
542 return II->getName().equals("nothrow_t");
543 }
544
545 // Skip placement operators.
546 if (FD->getNumParams() != 1 || FD->isVariadic())
547 return false;
548
549 // One of the standard new/new[]/delete/delete[] non-placement operators.
550 return true;
551}
552
Anna Zaksb319e022012-02-08 20:13:28 +0000553void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
Jordan Rosec20c7272012-09-20 01:55:32 +0000554 if (C.wasInlined)
555 return;
556
Anna Zaksb319e022012-02-08 20:13:28 +0000557 const FunctionDecl *FD = C.getCalleeDecl(CE);
558 if (!FD)
559 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000560
Anna Zaks87cb5be2012-02-22 19:24:52 +0000561 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000562 bool ReleasedAllocatedMemory = false;
Jordan Rose5ef6e942012-07-10 23:13:01 +0000563
564 if (FD->getKind() == Decl::Function) {
565 initIdentifierInfo(C.getASTContext());
566 IdentifierInfo *FunI = FD->getIdentifier();
567
Anton Yartsev648cb712013-04-04 23:46:29 +0000568 if (FunI == II_malloc || FunI == II_valloc) {
569 if (CE->getNumArgs() < 1)
570 return;
571 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
572 } else if (FunI == II_realloc) {
573 State = ReallocMem(C, CE, false);
574 } else if (FunI == II_reallocf) {
575 State = ReallocMem(C, CE, true);
576 } else if (FunI == II_calloc) {
577 State = CallocMem(C, CE);
578 } else if (FunI == II_free) {
579 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
580 } else if (FunI == II_strdup) {
581 State = MallocUpdateRefState(C, CE, State);
582 } else if (FunI == II_strndup) {
583 State = MallocUpdateRefState(C, CE, State);
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000584 }
Anton Yartsev648cb712013-04-04 23:46:29 +0000585 else if (isStandardNewDelete(FD, C.getASTContext())) {
586 // Process direct calls to operator new/new[]/delete/delete[] functions
587 // as distinct from new/new[]/delete/delete[] expressions that are
588 // processed by the checkPostStmt callbacks for CXXNewExpr and
589 // CXXDeleteExpr.
590 OverloadedOperatorKind K = FD->getOverloadedOperator();
591 if (K == OO_New)
592 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
593 AF_CXXNew);
594 else if (K == OO_Array_New)
595 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
596 AF_CXXNewArray);
597 else if (K == OO_Delete || K == OO_Array_Delete)
598 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
599 else
600 llvm_unreachable("not a new/delete operator");
Jordan Rose5ef6e942012-07-10 23:13:01 +0000601 }
602 }
603
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000604 if (Filter.CMallocOptimistic || Filter.CMismatchedDeallocatorChecker) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000605 // Check all the attributes, if there are any.
606 // There can be multiple of these attributes.
607 if (FD->hasAttrs())
608 for (specific_attr_iterator<OwnershipAttr>
609 i = FD->specific_attr_begin<OwnershipAttr>(),
610 e = FD->specific_attr_end<OwnershipAttr>();
611 i != e; ++i) {
612 switch ((*i)->getOwnKind()) {
613 case OwnershipAttr::Returns:
614 State = MallocMemReturnsAttr(C, CE, *i);
615 break;
616 case OwnershipAttr::Takes:
617 case OwnershipAttr::Holds:
618 State = FreeMemAttr(C, CE, *i);
619 break;
620 }
621 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000622 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000623 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000624}
625
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000626void MallocChecker::checkPostStmt(const CXXNewExpr *NE,
627 CheckerContext &C) const {
628
629 if (NE->getNumPlacementArgs())
630 for (CXXNewExpr::const_arg_iterator I = NE->placement_arg_begin(),
631 E = NE->placement_arg_end(); I != E; ++I)
632 if (SymbolRef Sym = C.getSVal(*I).getAsSymbol())
633 checkUseAfterFree(Sym, C, *I);
634
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000635 if (!isStandardNewDelete(NE->getOperatorNew(), C.getASTContext()))
636 return;
637
638 ProgramStateRef State = C.getState();
639 // The return value from operator new is bound to a specified initialization
640 // value (if any) and we don't want to loose this value. So we call
641 // MallocUpdateRefState() instead of MallocMemAux() which breakes the
642 // existing binding.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000643 State = MallocUpdateRefState(C, NE, State, NE->isArray() ? AF_CXXNewArray
644 : AF_CXXNew);
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000645 C.addTransition(State);
646}
647
648void MallocChecker::checkPreStmt(const CXXDeleteExpr *DE,
649 CheckerContext &C) const {
650
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000651 if (!Filter.CNewDeleteChecker)
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000652 if (SymbolRef Sym = C.getSVal(DE->getArgument()).getAsSymbol())
653 checkUseAfterFree(Sym, C, DE->getArgument());
654
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000655 if (!isStandardNewDelete(DE->getOperatorDelete(), C.getASTContext()))
656 return;
657
658 ProgramStateRef State = C.getState();
659 bool ReleasedAllocated;
660 State = FreeMemAux(C, DE->getArgument(), DE, State,
661 /*Hold*/false, ReleasedAllocated);
662
663 C.addTransition(State);
664}
665
Jordan Rose9fe09f32013-03-09 00:59:10 +0000666static bool isKnownDeallocObjCMethodName(const ObjCMethodCall &Call) {
667 // If the first selector piece is one of the names below, assume that the
668 // object takes ownership of the memory, promising to eventually deallocate it
669 // with free().
670 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
671 // (...unless a 'freeWhenDone' parameter is false, but that's checked later.)
672 StringRef FirstSlot = Call.getSelector().getNameForSlot(0);
673 if (FirstSlot == "dataWithBytesNoCopy" ||
674 FirstSlot == "initWithBytesNoCopy" ||
675 FirstSlot == "initWithCharactersNoCopy")
676 return true;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000677
678 return false;
679}
680
Jordan Rose9fe09f32013-03-09 00:59:10 +0000681static Optional<bool> getFreeWhenDoneArg(const ObjCMethodCall &Call) {
682 Selector S = Call.getSelector();
683
684 // FIXME: We should not rely on fully-constrained symbols being folded.
685 for (unsigned i = 1; i < S.getNumArgs(); ++i)
686 if (S.getNameForSlot(i).equals("freeWhenDone"))
687 return !Call.getArgSVal(i).isZeroConstant();
688
689 return None;
690}
691
Anna Zaks4141e4d2012-11-13 03:18:01 +0000692void MallocChecker::checkPostObjCMessage(const ObjCMethodCall &Call,
693 CheckerContext &C) const {
Anna Zaksc2cca232012-12-11 00:17:53 +0000694 if (C.wasInlined)
695 return;
696
Jordan Rose9fe09f32013-03-09 00:59:10 +0000697 if (!isKnownDeallocObjCMethodName(Call))
698 return;
Anna Zaks4141e4d2012-11-13 03:18:01 +0000699
Jordan Rose9fe09f32013-03-09 00:59:10 +0000700 if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(Call))
701 if (!*FreeWhenDone)
702 return;
703
704 bool ReleasedAllocatedMemory;
705 ProgramStateRef State = FreeMemAux(C, Call.getArgExpr(0),
706 Call.getOriginExpr(), C.getState(),
707 /*Hold=*/true, ReleasedAllocatedMemory,
708 /*RetNullOnFailure=*/true);
709
710 C.addTransition(State);
Anna Zaks5b7aa342012-06-22 02:04:31 +0000711}
712
Anna Zaks87cb5be2012-02-22 19:24:52 +0000713ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
714 const CallExpr *CE,
715 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000716 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000717 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000718
Sean Huntcf807c42010-08-18 23:23:40 +0000719 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000720 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000721 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000722 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000723 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000724}
725
Anna Zaksb319e022012-02-08 20:13:28 +0000726ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000727 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000728 SVal Size, SVal Init,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000729 ProgramStateRef State,
730 AllocationFamily Family) {
Anna Zakse17fdb22012-06-07 03:57:32 +0000731
732 // Bind the return value to the symbolic value from the heap region.
733 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
734 // side effects other than what we model here.
Ted Kremenek66c486f2012-08-22 06:26:15 +0000735 unsigned Count = C.blockCount();
Anna Zakse17fdb22012-06-07 03:57:32 +0000736 SValBuilder &svalBuilder = C.getSValBuilder();
737 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
David Blaikie5251abe2013-02-20 05:52:05 +0000738 DefinedSVal RetVal = svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count)
739 .castAs<DefinedSVal>();
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000740 State = State->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000741
Anna Zaksb16ce452012-02-15 00:11:22 +0000742 // We expect the malloc functions to return a pointer.
David Blaikie5251abe2013-02-20 05:52:05 +0000743 if (!RetVal.getAs<Loc>())
Anna Zaksb16ce452012-02-15 00:11:22 +0000744 return 0;
745
Jordy Rose32f26562010-07-04 00:00:41 +0000746 // Fill the region with the initialization value.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000747 State = State->bindDefault(RetVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000748
Jordy Rose32f26562010-07-04 00:00:41 +0000749 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000750 const SymbolicRegion *R =
Anna Zakse17fdb22012-06-07 03:57:32 +0000751 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000752 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000753 return 0;
David Blaikiedc84cd52013-02-20 22:23:23 +0000754 if (Optional<DefinedOrUnknownSVal> DefinedSize =
David Blaikie5251abe2013-02-20 05:52:05 +0000755 Size.getAs<DefinedOrUnknownSVal>()) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000756 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000757 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000758 DefinedOrUnknownSVal extentMatchesSize =
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000759 svalBuilder.evalEQ(State, Extent, *DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000760
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000761 State = State->assume(extentMatchesSize, true);
762 assert(State);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000763 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000764
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000765 return MallocUpdateRefState(C, CE, State, Family);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000766}
767
768ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
Anton Yartsev2de19ed2013-03-25 01:35:45 +0000769 const Expr *E,
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000770 ProgramStateRef State,
771 AllocationFamily Family) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000772 // Get the return value.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000773 SVal retVal = State->getSVal(E, C.getLocationContext());
Anna Zaks87cb5be2012-02-22 19:24:52 +0000774
775 // We expect the malloc functions to return a pointer.
David Blaikie5251abe2013-02-20 05:52:05 +0000776 if (!retVal.getAs<Loc>())
Anna Zaks87cb5be2012-02-22 19:24:52 +0000777 return 0;
778
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000779 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000780 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000781
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000782 // Set the symbol's state to Allocated.
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000783 return State->set<RegionState>(Sym, RefState::getAllocated(Family, E));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000784}
785
Anna Zaks87cb5be2012-02-22 19:24:52 +0000786ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
787 const CallExpr *CE,
788 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000789 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000790 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000791
Anna Zaksb3d72752012-03-01 22:06:06 +0000792 ProgramStateRef State = C.getState();
Anna Zaks55dd9562012-08-24 02:28:20 +0000793 bool ReleasedAllocated = false;
Anna Zaksb3d72752012-03-01 22:06:06 +0000794
Sean Huntcf807c42010-08-18 23:23:40 +0000795 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
796 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000797 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
Anna Zaks55dd9562012-08-24 02:28:20 +0000798 Att->getOwnKind() == OwnershipAttr::Holds,
799 ReleasedAllocated);
Anna Zaksb3d72752012-03-01 22:06:06 +0000800 if (StateI)
801 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000802 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000803 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000804}
805
Ted Kremenek8bef8232012-01-26 21:29:00 +0000806ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000807 const CallExpr *CE,
808 ProgramStateRef state,
809 unsigned Num,
Anna Zaks55dd9562012-08-24 02:28:20 +0000810 bool Hold,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000811 bool &ReleasedAllocated,
812 bool ReturnsNullOnFailure) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000813 if (CE->getNumArgs() < (Num + 1))
814 return 0;
815
Anna Zaks4141e4d2012-11-13 03:18:01 +0000816 return FreeMemAux(C, CE->getArg(Num), CE, state, Hold,
817 ReleasedAllocated, ReturnsNullOnFailure);
818}
819
Anna Zaks2ccecfa2012-11-13 19:47:40 +0000820/// Checks if the previous call to free on the given symbol failed - if free
821/// failed, returns true. Also, returns the corresponding return value symbol.
Benjamin Kramer4d9f4e52012-11-22 15:02:44 +0000822static bool didPreviousFreeFail(ProgramStateRef State,
823 SymbolRef Sym, SymbolRef &RetStatusSymbol) {
Anna Zaks2ccecfa2012-11-13 19:47:40 +0000824 const SymbolRef *Ret = State->get<FreeReturnValue>(Sym);
Anna Zaks4141e4d2012-11-13 03:18:01 +0000825 if (Ret) {
826 assert(*Ret && "We should not store the null return symbol");
827 ConstraintManager &CMgr = State->getConstraintManager();
828 ConditionTruthVal FreeFailed = CMgr.isNull(State, *Ret);
Anna Zaks2ccecfa2012-11-13 19:47:40 +0000829 RetStatusSymbol = *Ret;
830 return FreeFailed.isConstrainedTrue();
Anna Zaks4141e4d2012-11-13 03:18:01 +0000831 }
Anna Zaks2ccecfa2012-11-13 19:47:40 +0000832 return false;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000833}
834
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000835AllocationFamily MallocChecker::getAllocationFamily(CheckerContext &C,
Anton Yartsev648cb712013-04-04 23:46:29 +0000836 const Stmt *S) const {
837 if (!S)
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000838 return AF_None;
839
Anton Yartsev648cb712013-04-04 23:46:29 +0000840 if (const CallExpr *CE = dyn_cast<CallExpr>(S)) {
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000841 const FunctionDecl *FD = C.getCalleeDecl(CE);
Anton Yartsev648cb712013-04-04 23:46:29 +0000842
843 if (!FD)
844 FD = dyn_cast<FunctionDecl>(CE->getCalleeDecl());
845
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000846 ASTContext &Ctx = C.getASTContext();
847
Anton Yartsev648cb712013-04-04 23:46:29 +0000848 if (isAllocationFunction(FD, Ctx) || isFreeFunction(FD, Ctx))
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000849 return AF_Malloc;
850
851 if (isStandardNewDelete(FD, Ctx)) {
852 OverloadedOperatorKind Kind = FD->getOverloadedOperator();
Anton Yartsev648cb712013-04-04 23:46:29 +0000853 if (Kind == OO_New || Kind == OO_Delete)
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000854 return AF_CXXNew;
Anton Yartsev648cb712013-04-04 23:46:29 +0000855 else if (Kind == OO_Array_New || Kind == OO_Array_Delete)
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000856 return AF_CXXNewArray;
857 }
858
859 return AF_None;
860 }
861
Anton Yartsev648cb712013-04-04 23:46:29 +0000862 if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(S))
863 return NE->isArray() ? AF_CXXNewArray : AF_CXXNew;
864
865 if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(S))
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000866 return DE->isArrayForm() ? AF_CXXNewArray : AF_CXXNew;
867
Anton Yartsev648cb712013-04-04 23:46:29 +0000868 if (isa<ObjCMessageExpr>(S))
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000869 return AF_Malloc;
870
871 return AF_None;
872}
873
874bool MallocChecker::printAllocDeallocName(raw_ostream &os, CheckerContext &C,
875 const Expr *E) const {
876 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
877 // FIXME: This doesn't handle indirect calls.
878 const FunctionDecl *FD = CE->getDirectCallee();
879 if (!FD)
880 return false;
881
882 os << *FD;
883 if (!FD->isOverloadedOperator())
884 os << "()";
885 return true;
886 }
887
888 if (const ObjCMessageExpr *Msg = dyn_cast<ObjCMessageExpr>(E)) {
889 if (Msg->isInstanceMessage())
890 os << "-";
891 else
892 os << "+";
893 os << Msg->getSelector().getAsString();
894 return true;
895 }
896
897 if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(E)) {
898 os << "'"
899 << getOperatorSpelling(NE->getOperatorNew()->getOverloadedOperator())
900 << "'";
901 return true;
902 }
903
904 if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(E)) {
905 os << "'"
906 << getOperatorSpelling(DE->getOperatorDelete()->getOverloadedOperator())
907 << "'";
908 return true;
909 }
910
911 return false;
912}
913
914void MallocChecker::printExpectedAllocName(raw_ostream &os, CheckerContext &C,
915 const Expr *E) const {
916 AllocationFamily Family = getAllocationFamily(C, E);
917
918 switch(Family) {
919 case AF_Malloc: os << "malloc()"; return;
920 case AF_CXXNew: os << "'new'"; return;
921 case AF_CXXNewArray: os << "'new[]'"; return;
922 case AF_None: llvm_unreachable("not a deallocation expression");
923 }
924}
925
926void MallocChecker::printExpectedDeallocName(raw_ostream &os,
927 AllocationFamily Family) const {
928 switch(Family) {
929 case AF_Malloc: os << "free()"; return;
930 case AF_CXXNew: os << "'delete'"; return;
931 case AF_CXXNewArray: os << "'delete[]'"; return;
932 case AF_None: llvm_unreachable("suspicious AF_None argument");
933 }
934}
935
Anna Zaks5b7aa342012-06-22 02:04:31 +0000936ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
937 const Expr *ArgExpr,
938 const Expr *ParentExpr,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000939 ProgramStateRef State,
Anna Zaks55dd9562012-08-24 02:28:20 +0000940 bool Hold,
Anna Zaks4141e4d2012-11-13 03:18:01 +0000941 bool &ReleasedAllocated,
942 bool ReturnsNullOnFailure) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000943
Anna Zaks4141e4d2012-11-13 03:18:01 +0000944 SVal ArgVal = State->getSVal(ArgExpr, C.getLocationContext());
David Blaikie5251abe2013-02-20 05:52:05 +0000945 if (!ArgVal.getAs<DefinedOrUnknownSVal>())
Anna Zakse9ef5622012-02-10 01:11:00 +0000946 return 0;
David Blaikie5251abe2013-02-20 05:52:05 +0000947 DefinedOrUnknownSVal location = ArgVal.castAs<DefinedOrUnknownSVal>();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000948
949 // Check for null dereferences.
David Blaikie5251abe2013-02-20 05:52:05 +0000950 if (!location.getAs<Loc>())
Anna Zaksb319e022012-02-08 20:13:28 +0000951 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000952
Anna Zaksb276bd92012-02-14 00:26:13 +0000953 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000954 ProgramStateRef notNullState, nullState;
Anna Zaks4141e4d2012-11-13 03:18:01 +0000955 llvm::tie(notNullState, nullState) = State->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000956 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000957 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000958
Jordy Rose43859f62010-06-07 19:32:37 +0000959 // Unknown values could easily be okay
960 // Undefined values are handled elsewhere
961 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000962 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000963
Jordy Rose43859f62010-06-07 19:32:37 +0000964 const MemRegion *R = ArgVal.getAsRegion();
965
966 // Nonlocs can't be freed, of course.
967 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
968 if (!R) {
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000969 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Anna Zaksb319e022012-02-08 20:13:28 +0000970 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000971 }
972
973 R = R->StripCasts();
974
975 // Blocks might show up as heap data, but should not be free()d
976 if (isa<BlockDataRegion>(R)) {
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000977 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Anna Zaksb319e022012-02-08 20:13:28 +0000978 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000979 }
980
981 const MemSpaceRegion *MS = R->getMemorySpace();
982
Anton Yartsevbb369952013-03-13 14:39:10 +0000983 // Parameters, locals, statics, globals, and memory returned by alloca()
984 // shouldn't be freed.
Jordy Rose43859f62010-06-07 19:32:37 +0000985 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
986 // FIXME: at the time this code was written, malloc() regions were
987 // represented by conjured symbols, which are all in UnknownSpaceRegion.
988 // This means that there isn't actually anything from HeapSpaceRegion
989 // that should be freed, even though we allow it here.
990 // Of course, free() can work on memory allocated outside the current
991 // function, so UnknownSpaceRegion is always a possibility.
992 // False negatives are better than false positives.
993
Anton Yartsev849c7bf2013-03-28 17:05:19 +0000994 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Anna Zaksb319e022012-02-08 20:13:28 +0000995 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000996 }
Anna Zaks118aa752013-02-07 23:05:47 +0000997
998 const SymbolicRegion *SrBase = dyn_cast<SymbolicRegion>(R->getBaseRegion());
Jordy Rose43859f62010-06-07 19:32:37 +0000999 // Various cases could lead to non-symbol values here.
1000 // For now, ignore them.
Anna Zaks118aa752013-02-07 23:05:47 +00001001 if (!SrBase)
Anna Zaksb319e022012-02-08 20:13:28 +00001002 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +00001003
Anna Zaks118aa752013-02-07 23:05:47 +00001004 SymbolRef SymBase = SrBase->getSymbol();
1005 const RefState *RsBase = State->get<RegionState>(SymBase);
Anna Zaks2ccecfa2012-11-13 19:47:40 +00001006 SymbolRef PreviousRetStatusSymbol = 0;
Zhongxing Xu7e3cda92010-01-18 03:27:34 +00001007
Anton Yartsev648cb712013-04-04 23:46:29 +00001008 if (RsBase) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001009
Anton Yartsev648cb712013-04-04 23:46:29 +00001010 bool DeallocMatchesAlloc =
1011 RsBase->getAllocationFamily() == AF_None ||
1012 RsBase->getAllocationFamily() == getAllocationFamily(C, ParentExpr);
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001013
Anton Yartsev648cb712013-04-04 23:46:29 +00001014 // Check if an expected deallocation function matches the real one.
1015 if (!DeallocMatchesAlloc && RsBase->isAllocated()) {
Anton Yartseva3ae9372013-04-05 11:25:10 +00001016 ReportMismatchedDealloc(C, ArgExpr->getSourceRange(), ParentExpr, RsBase,
1017 SymBase);
Anton Yartsev648cb712013-04-04 23:46:29 +00001018 return 0;
1019 }
1020
1021 // Check double free.
1022 if (DeallocMatchesAlloc &&
1023 (RsBase->isReleased() || RsBase->isRelinquished()) &&
1024 !didPreviousFreeFail(State, SymBase, PreviousRetStatusSymbol)) {
1025 ReportDoubleFree(C, ParentExpr->getSourceRange(), RsBase->isReleased(),
1026 SymBase, PreviousRetStatusSymbol);
1027 return 0;
1028 }
1029
1030 // Check if the memory location being freed is the actual location
1031 // allocated, or an offset.
1032 RegionOffset Offset = R->getAsOffset();
1033 if (RsBase->isAllocated() &&
1034 Offset.isValid() &&
1035 !Offset.hasSymbolicOffset() &&
1036 Offset.getOffset() != 0) {
1037 const Expr *AllocExpr = cast<Expr>(RsBase->getStmt());
1038 ReportOffsetFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr,
1039 AllocExpr);
1040 return 0;
1041 }
Anna Zaks118aa752013-02-07 23:05:47 +00001042 }
1043
1044 ReleasedAllocated = (RsBase != 0);
Anna Zaks55dd9562012-08-24 02:28:20 +00001045
Anna Zaks2ccecfa2012-11-13 19:47:40 +00001046 // Clean out the info on previous call to free return info.
Anna Zaks118aa752013-02-07 23:05:47 +00001047 State = State->remove<FreeReturnValue>(SymBase);
Anna Zaks2ccecfa2012-11-13 19:47:40 +00001048
Anna Zaks4141e4d2012-11-13 03:18:01 +00001049 // Keep track of the return value. If it is NULL, we will know that free
1050 // failed.
1051 if (ReturnsNullOnFailure) {
1052 SVal RetVal = C.getSVal(ParentExpr);
1053 SymbolRef RetStatusSymbol = RetVal.getAsSymbol();
1054 if (RetStatusSymbol) {
Anna Zaks118aa752013-02-07 23:05:47 +00001055 C.getSymbolManager().addSymbolDependency(SymBase, RetStatusSymbol);
1056 State = State->set<FreeReturnValue>(SymBase, RetStatusSymbol);
Anna Zaks4141e4d2012-11-13 03:18:01 +00001057 }
1058 }
1059
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001060 AllocationFamily Family = RsBase ? RsBase->getAllocationFamily() : AF_None;
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001061 // Normal free.
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001062 if (Hold)
Anna Zaks118aa752013-02-07 23:05:47 +00001063 return State->set<RegionState>(SymBase,
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001064 RefState::getRelinquished(Family,
1065 ParentExpr));
1066
1067 return State->set<RegionState>(SymBase,
1068 RefState::getReleased(Family, ParentExpr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001069}
1070
Anton Yartsev648cb712013-04-04 23:46:29 +00001071bool MallocChecker::isTrackedFamily(AllocationFamily Family) const {
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001072 switch (Family) {
1073 case AF_Malloc: {
1074 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic)
1075 return false;
Anton Yartsevc8454312013-04-05 02:12:04 +00001076 return true;
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001077 }
1078 case AF_CXXNew:
1079 case AF_CXXNewArray: {
1080 if (!Filter.CNewDeleteChecker)
1081 return false;
Anton Yartsevc8454312013-04-05 02:12:04 +00001082 return true;
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001083 }
1084 case AF_None: {
1085 return true;
1086 }
Anton Yartsev9c6bbb32013-04-05 00:31:02 +00001087 }
Anton Yartsevc8454312013-04-05 02:12:04 +00001088 llvm_unreachable("unhandled family");
Anton Yartsev648cb712013-04-04 23:46:29 +00001089}
1090
1091bool MallocChecker::isTrackedFamily(CheckerContext &C,
1092 const Stmt *AllocDeallocStmt) const {
1093 return isTrackedFamily(getAllocationFamily(C, AllocDeallocStmt));
1094}
1095
1096bool MallocChecker::isTrackedFamily(CheckerContext &C, SymbolRef Sym) const {
1097 const RefState *RS = C.getState()->get<RegionState>(Sym);
1098
1099 return RS ? isTrackedFamily(RS->getAllocationFamily())
1100 : isTrackedFamily(AF_None);
1101}
1102
Ted Kremenek9c378f72011-08-12 23:37:29 +00001103bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
David Blaikiedc84cd52013-02-20 22:23:23 +00001104 if (Optional<nonloc::ConcreteInt> IntVal = V.getAs<nonloc::ConcreteInt>())
Jordy Rose43859f62010-06-07 19:32:37 +00001105 os << "an integer (" << IntVal->getValue() << ")";
David Blaikiedc84cd52013-02-20 22:23:23 +00001106 else if (Optional<loc::ConcreteInt> ConstAddr = V.getAs<loc::ConcreteInt>())
Jordy Rose43859f62010-06-07 19:32:37 +00001107 os << "a constant address (" << ConstAddr->getValue() << ")";
David Blaikiedc84cd52013-02-20 22:23:23 +00001108 else if (Optional<loc::GotoLabel> Label = V.getAs<loc::GotoLabel>())
Chris Lattner68106302011-02-17 05:38:27 +00001109 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +00001110 else
1111 return false;
1112
1113 return true;
1114}
1115
Ted Kremenek9c378f72011-08-12 23:37:29 +00001116bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +00001117 const MemRegion *MR) {
1118 switch (MR->getKind()) {
1119 case MemRegion::FunctionTextRegionKind: {
Anna Zaks5fc1d0c2012-09-17 19:13:56 +00001120 const NamedDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
Jordy Rose43859f62010-06-07 19:32:37 +00001121 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +00001122 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +00001123 else
1124 os << "the address of a function";
1125 return true;
1126 }
1127 case MemRegion::BlockTextRegionKind:
1128 os << "block text";
1129 return true;
1130 case MemRegion::BlockDataRegionKind:
1131 // FIXME: where the block came from?
1132 os << "a block";
1133 return true;
1134 default: {
1135 const MemSpaceRegion *MS = MR->getMemorySpace();
1136
Anna Zakseb31a762012-01-04 23:54:01 +00001137 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +00001138 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1139 const VarDecl *VD;
1140 if (VR)
1141 VD = VR->getDecl();
1142 else
1143 VD = NULL;
1144
1145 if (VD)
1146 os << "the address of the local variable '" << VD->getName() << "'";
1147 else
1148 os << "the address of a local stack variable";
1149 return true;
1150 }
Anna Zakseb31a762012-01-04 23:54:01 +00001151
1152 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +00001153 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1154 const VarDecl *VD;
1155 if (VR)
1156 VD = VR->getDecl();
1157 else
1158 VD = NULL;
1159
1160 if (VD)
1161 os << "the address of the parameter '" << VD->getName() << "'";
1162 else
1163 os << "the address of a parameter";
1164 return true;
1165 }
Anna Zakseb31a762012-01-04 23:54:01 +00001166
1167 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +00001168 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1169 const VarDecl *VD;
1170 if (VR)
1171 VD = VR->getDecl();
1172 else
1173 VD = NULL;
1174
1175 if (VD) {
1176 if (VD->isStaticLocal())
1177 os << "the address of the static variable '" << VD->getName() << "'";
1178 else
1179 os << "the address of the global variable '" << VD->getName() << "'";
1180 } else
1181 os << "the address of a global variable";
1182 return true;
1183 }
Anna Zakseb31a762012-01-04 23:54:01 +00001184
1185 return false;
Jordy Rose43859f62010-06-07 19:32:37 +00001186 }
1187 }
1188}
1189
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001190void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
1191 SourceRange Range,
1192 const Expr *DeallocExpr) const {
1193
1194 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1195 !Filter.CNewDeleteChecker)
1196 return;
1197
Anton Yartsev648cb712013-04-04 23:46:29 +00001198 if (!isTrackedFamily(C, DeallocExpr))
1199 return;
1200
Ted Kremenekd048c6e2010-12-20 21:19:09 +00001201 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +00001202 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001203 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +00001204
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00001205 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +00001206 llvm::raw_svector_ostream os(buf);
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001207
Jordy Rose43859f62010-06-07 19:32:37 +00001208 const MemRegion *MR = ArgVal.getAsRegion();
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001209 while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR))
1210 MR = ER->getSuperRegion();
1211
1212 if (MR && isa<AllocaRegion>(MR))
1213 os << "Memory allocated by alloca() should not be deallocated";
1214 else {
1215 os << "Argument to ";
1216 if (!printAllocDeallocName(os, C, DeallocExpr))
1217 os << "deallocator";
1218
1219 os << " is ";
1220 bool Summarized = MR ? SummarizeRegion(os, MR)
1221 : SummarizeValue(os, ArgVal);
1222 if (Summarized)
1223 os << ", which is not memory allocated by ";
Jordy Rose43859f62010-06-07 19:32:37 +00001224 else
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001225 os << "not memory allocated by ";
1226
1227 printExpectedAllocName(os, C, DeallocExpr);
Jordy Rose43859f62010-06-07 19:32:37 +00001228 }
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001229
Anna Zakse172e8b2011-08-17 23:00:25 +00001230 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +00001231 R->markInteresting(MR);
Anton Yartsevbb369952013-03-13 14:39:10 +00001232 R->addRange(Range);
Jordan Rose785950e2012-11-02 01:53:40 +00001233 C.emitReport(R);
Jordy Rose43859f62010-06-07 19:32:37 +00001234 }
1235}
1236
Anton Yartsev648cb712013-04-04 23:46:29 +00001237void MallocChecker::ReportMismatchedDealloc(CheckerContext &C,
1238 SourceRange Range,
1239 const Expr *DeallocExpr,
Anton Yartseva3ae9372013-04-05 11:25:10 +00001240 const RefState *RS,
1241 SymbolRef Sym) const {
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001242
1243 if (!Filter.CMismatchedDeallocatorChecker)
1244 return;
1245
1246 if (ExplodedNode *N = C.generateSink()) {
Anton Yartsev648cb712013-04-04 23:46:29 +00001247 if (!BT_MismatchedDealloc)
1248 BT_MismatchedDealloc.reset(new BugType("Bad deallocator",
1249 "Memory Error"));
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001250
1251 SmallString<100> buf;
1252 llvm::raw_svector_ostream os(buf);
1253
1254 const Expr *AllocExpr = cast<Expr>(RS->getStmt());
1255 SmallString<20> AllocBuf;
1256 llvm::raw_svector_ostream AllocOs(AllocBuf);
1257 SmallString<20> DeallocBuf;
1258 llvm::raw_svector_ostream DeallocOs(DeallocBuf);
1259
1260 os << "Memory";
1261 if (printAllocDeallocName(AllocOs, C, AllocExpr))
1262 os << " allocated by " << AllocOs.str();
1263
1264 os << " should be deallocated by ";
1265 printExpectedDeallocName(os, RS->getAllocationFamily());
1266
1267 if (printAllocDeallocName(DeallocOs, C, DeallocExpr))
1268 os << ", not " << DeallocOs.str();
1269
Anton Yartsev648cb712013-04-04 23:46:29 +00001270 BugReport *R = new BugReport(*BT_MismatchedDealloc, os.str(), N);
Anton Yartseva3ae9372013-04-05 11:25:10 +00001271 R->markInteresting(Sym);
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001272 R->addRange(Range);
Anton Yartseva3ae9372013-04-05 11:25:10 +00001273 R->addVisitor(new MallocBugVisitor(Sym));
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001274 C.emitReport(R);
1275 }
1276}
1277
Anna Zaks118aa752013-02-07 23:05:47 +00001278void MallocChecker::ReportOffsetFree(CheckerContext &C, SVal ArgVal,
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001279 SourceRange Range, const Expr *DeallocExpr,
1280 const Expr *AllocExpr) const {
1281
1282 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1283 !Filter.CNewDeleteChecker)
1284 return;
1285
Anton Yartsev648cb712013-04-04 23:46:29 +00001286 if (!isTrackedFamily(C, AllocExpr))
1287 return;
1288
Anna Zaks118aa752013-02-07 23:05:47 +00001289 ExplodedNode *N = C.generateSink();
1290 if (N == NULL)
1291 return;
1292
1293 if (!BT_OffsetFree)
1294 BT_OffsetFree.reset(new BugType("Offset free", "Memory Error"));
1295
1296 SmallString<100> buf;
1297 llvm::raw_svector_ostream os(buf);
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001298 SmallString<20> AllocNameBuf;
1299 llvm::raw_svector_ostream AllocNameOs(AllocNameBuf);
Anna Zaks118aa752013-02-07 23:05:47 +00001300
1301 const MemRegion *MR = ArgVal.getAsRegion();
1302 assert(MR && "Only MemRegion based symbols can have offset free errors");
1303
1304 RegionOffset Offset = MR->getAsOffset();
1305 assert((Offset.isValid() &&
1306 !Offset.hasSymbolicOffset() &&
1307 Offset.getOffset() != 0) &&
1308 "Only symbols with a valid offset can have offset free errors");
1309
1310 int offsetBytes = Offset.getOffset() / C.getASTContext().getCharWidth();
1311
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001312 os << "Argument to ";
1313 if (!printAllocDeallocName(os, C, DeallocExpr))
1314 os << "deallocator";
1315 os << " is offset by "
Anna Zaks118aa752013-02-07 23:05:47 +00001316 << offsetBytes
1317 << " "
1318 << ((abs(offsetBytes) > 1) ? "bytes" : "byte")
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001319 << " from the start of ";
1320 if (AllocExpr && printAllocDeallocName(AllocNameOs, C, AllocExpr))
1321 os << "memory allocated by " << AllocNameOs.str();
1322 else
1323 os << "allocated memory";
Anna Zaks118aa752013-02-07 23:05:47 +00001324
1325 BugReport *R = new BugReport(*BT_OffsetFree, os.str(), N);
1326 R->markInteresting(MR->getBaseRegion());
1327 R->addRange(Range);
1328 C.emitReport(R);
1329}
1330
Anton Yartsevbb369952013-03-13 14:39:10 +00001331void MallocChecker::ReportUseAfterFree(CheckerContext &C, SourceRange Range,
1332 SymbolRef Sym) const {
1333
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001334 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1335 !Filter.CNewDeleteChecker)
1336 return;
1337
Anton Yartsev648cb712013-04-04 23:46:29 +00001338 if (!isTrackedFamily(C, Sym))
1339 return;
1340
Anton Yartsevbb369952013-03-13 14:39:10 +00001341 if (ExplodedNode *N = C.generateSink()) {
1342 if (!BT_UseFree)
1343 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
1344
1345 BugReport *R = new BugReport(*BT_UseFree,
1346 "Use of memory after it is freed", N);
1347
1348 R->markInteresting(Sym);
1349 R->addRange(Range);
1350 R->addVisitor(new MallocBugVisitor(Sym));
1351 C.emitReport(R);
1352 }
1353}
1354
1355void MallocChecker::ReportDoubleFree(CheckerContext &C, SourceRange Range,
1356 bool Released, SymbolRef Sym,
Anton Yartsev3258d4b2013-03-13 17:07:32 +00001357 SymbolRef PrevSym) const {
Anton Yartsevbb369952013-03-13 14:39:10 +00001358
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001359 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1360 !Filter.CNewDeleteChecker)
1361 return;
1362
Anton Yartsev648cb712013-04-04 23:46:29 +00001363 if (!isTrackedFamily(C, Sym))
1364 return;
1365
Anton Yartsevbb369952013-03-13 14:39:10 +00001366 if (ExplodedNode *N = C.generateSink()) {
1367 if (!BT_DoubleFree)
1368 BT_DoubleFree.reset(new BugType("Double free", "Memory Error"));
1369
1370 BugReport *R = new BugReport(*BT_DoubleFree,
1371 (Released ? "Attempt to free released memory"
1372 : "Attempt to free non-owned memory"),
1373 N);
1374 R->addRange(Range);
Anton Yartsev3258d4b2013-03-13 17:07:32 +00001375 R->markInteresting(Sym);
1376 if (PrevSym)
1377 R->markInteresting(PrevSym);
Anton Yartsevbb369952013-03-13 14:39:10 +00001378 R->addVisitor(new MallocBugVisitor(Sym));
1379 C.emitReport(R);
1380 }
1381}
1382
Anna Zaks87cb5be2012-02-22 19:24:52 +00001383ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
1384 const CallExpr *CE,
1385 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +00001386 if (CE->getNumArgs() < 2)
1387 return 0;
1388
Ted Kremenek8bef8232012-01-26 21:29:00 +00001389 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001390 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +00001391 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +00001392 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
David Blaikie5251abe2013-02-20 05:52:05 +00001393 if (!Arg0Val.getAs<DefinedOrUnknownSVal>())
Anna Zaks87cb5be2012-02-22 19:24:52 +00001394 return 0;
David Blaikie5251abe2013-02-20 05:52:05 +00001395 DefinedOrUnknownSVal arg0Val = Arg0Val.castAs<DefinedOrUnknownSVal>();
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001396
Ted Kremenek846eabd2010-12-01 21:28:31 +00001397 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001398
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001399 DefinedOrUnknownSVal PtrEQ =
1400 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001401
Lenny Maiorani4d8d8032011-04-27 14:49:29 +00001402 // Get the size argument. If there is no size arg then give up.
1403 const Expr *Arg1 = CE->getArg(1);
1404 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +00001405 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +00001406
1407 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +00001408 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
David Blaikie5251abe2013-02-20 05:52:05 +00001409 if (!Arg1ValG.getAs<DefinedOrUnknownSVal>())
Anna Zaks87cb5be2012-02-22 19:24:52 +00001410 return 0;
David Blaikie5251abe2013-02-20 05:52:05 +00001411 DefinedOrUnknownSVal Arg1Val = Arg1ValG.castAs<DefinedOrUnknownSVal>();
Lenny Maiorani4d8d8032011-04-27 14:49:29 +00001412
1413 // Compare the size argument to 0.
1414 DefinedOrUnknownSVal SizeZero =
1415 svalBuilder.evalEQ(state, Arg1Val,
1416 svalBuilder.makeIntValWithPtrWidth(0, false));
1417
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001418 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
1419 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
1420 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
1421 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
1422 // We only assume exceptional states if they are definitely true; if the
1423 // state is under-constrained, assume regular realloc behavior.
1424 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
1425 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
1426
Lenny Maiorani4d8d8032011-04-27 14:49:29 +00001427 // If the ptr is NULL and the size is not 0, the call is equivalent to
1428 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001429 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +00001430 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001431 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +00001432 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001433 }
1434
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001435 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +00001436 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001437
Anna Zaks30838b92012-02-13 20:57:07 +00001438 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001439 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +00001440 SymbolRef FromPtr = arg0Val.getAsSymbol();
1441 SVal RetVal = state->getSVal(CE, LCtx);
1442 SymbolRef ToPtr = RetVal.getAsSymbol();
1443 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +00001444 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001445
Anna Zaks55dd9562012-08-24 02:28:20 +00001446 bool ReleasedAllocated = false;
1447
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001448 // If the size is 0, free the memory.
1449 if (SizeIsZero)
Anna Zaks55dd9562012-08-24 02:28:20 +00001450 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0,
1451 false, ReleasedAllocated)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001452 // The semantics of the return value are:
1453 // If size was equal to 0, either NULL or a pointer suitable to be passed
Anna Zaksede875b2012-08-03 18:30:18 +00001454 // to free() is returned. We just free the input pointer and do not add
1455 // any constrains on the output pointer.
Anna Zaks87cb5be2012-02-22 19:24:52 +00001456 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001457 }
1458
1459 // Default behavior.
Anna Zaks55dd9562012-08-24 02:28:20 +00001460 if (ProgramStateRef stateFree =
1461 FreeMemAux(C, CE, state, 0, false, ReleasedAllocated)) {
1462
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001463 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
1464 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +00001465 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +00001466 return 0;
Anna Zaks55dd9562012-08-24 02:28:20 +00001467
Anna Zaks9dc298b2012-09-12 22:57:34 +00001468 ReallocPairKind Kind = RPToBeFreedAfterFailure;
1469 if (FreesOnFail)
1470 Kind = RPIsFreeOnFailure;
1471 else if (!ReleasedAllocated)
1472 Kind = RPDoNotTrackAfterFailure;
1473
Anna Zaks55dd9562012-08-24 02:28:20 +00001474 // Record the info about the reallocated symbol so that we could properly
1475 // process failed reallocation.
Anna Zaks40add292012-02-15 00:11:25 +00001476 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
Anna Zaks9dc298b2012-09-12 22:57:34 +00001477 ReallocPair(FromPtr, Kind));
Anna Zaks55dd9562012-08-24 02:28:20 +00001478 // The reallocated symbol should stay alive for as long as the new symbol.
Anna Zaksb276bd92012-02-14 00:26:13 +00001479 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +00001480 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +00001481 }
Anna Zaks87cb5be2012-02-22 19:24:52 +00001482 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001483}
Zhongxing Xu7b760962009-11-13 07:25:27 +00001484
Anna Zaks87cb5be2012-02-22 19:24:52 +00001485ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +00001486 if (CE->getNumArgs() < 2)
1487 return 0;
1488
Ted Kremenek8bef8232012-01-26 21:29:00 +00001489 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +00001490 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +00001491 const LocationContext *LCtx = C.getLocationContext();
1492 SVal count = state->getSVal(CE->getArg(0), LCtx);
1493 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001494 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
1495 svalBuilder.getContext().getSizeType());
1496 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +00001497
Anna Zaks87cb5be2012-02-22 19:24:52 +00001498 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +00001499}
1500
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001501LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +00001502MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
1503 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +00001504 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +00001505 // Walk the ExplodedGraph backwards and find the first node that referred to
1506 // the tracked symbol.
1507 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001508 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +00001509
1510 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001511 ProgramStateRef State = N->getState();
1512 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +00001513 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001514
1515 // Find the most recent expression bound to the symbol in the current
1516 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001517 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +00001518 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
1519 SVal Val = State->getSVal(MR);
1520 if (Val.getAsLocSymbol() == Sym)
1521 ReferenceRegion = MR;
1522 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001523 }
1524
Anna Zaks7752d292012-02-27 23:40:55 +00001525 // Allocation node, is the last node in the current context in which the
1526 // symbol was tracked.
1527 if (N->getLocationContext() == LeakContext)
1528 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +00001529 N = N->pred_empty() ? NULL : *(N->pred_begin());
1530 }
1531
Anna Zaks97bfb552013-01-08 00:25:29 +00001532 return LeakInfo(AllocNode, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +00001533}
1534
Anna Zaksda046772012-02-11 21:02:40 +00001535void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
1536 CheckerContext &C) const {
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001537
1538 if (!Filter.CMallocOptimistic && !Filter.CMallocPessimistic &&
1539 !Filter.CNewDeleteChecker)
1540 return;
1541
Anton Yartsev418780f2013-04-05 02:25:02 +00001542 if (!isTrackedFamily(C, Sym))
1543 return;
1544
Anna Zaksda046772012-02-11 21:02:40 +00001545 assert(N);
1546 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +00001547 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +00001548 // Leaks should not be reported if they are post-dominated by a sink:
1549 // (1) Sinks are higher importance bugs.
1550 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
1551 // with __noreturn functions such as assert() or exit(). We choose not
1552 // to report leaks on such paths.
1553 BT_Leak->setSuppressOnSink(true);
1554 }
1555
Anna Zaksca8e36e2012-02-23 21:38:21 +00001556 // Most bug reports are cached at the location where they occurred.
1557 // With leaks, we want to unique them by the location where they were
1558 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +00001559 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks97bfb552013-01-08 00:25:29 +00001560 const ExplodedNode *AllocNode = 0;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001561 const MemRegion *Region = 0;
Anna Zaks97bfb552013-01-08 00:25:29 +00001562 llvm::tie(AllocNode, Region) = getAllocationSite(N, Sym, C);
1563
1564 ProgramPoint P = AllocNode->getLocation();
1565 const Stmt *AllocationStmt = 0;
David Blaikie7a95de62013-02-21 22:23:56 +00001566 if (Optional<CallExitEnd> Exit = P.getAs<CallExitEnd>())
Anna Zaks97bfb552013-01-08 00:25:29 +00001567 AllocationStmt = Exit->getCalleeContext()->getCallSite();
David Blaikie7a95de62013-02-21 22:23:56 +00001568 else if (Optional<StmtPoint> SP = P.getAs<StmtPoint>())
Anna Zaks97bfb552013-01-08 00:25:29 +00001569 AllocationStmt = SP->getStmt();
Anton Yartsev418780f2013-04-05 02:25:02 +00001570 if (AllocationStmt)
Anna Zaks97bfb552013-01-08 00:25:29 +00001571 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocationStmt,
1572 C.getSourceManager(),
1573 AllocNode->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +00001574
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001575 SmallString<200> buf;
1576 llvm::raw_svector_ostream os(buf);
1577 os << "Memory is never released; potential leak";
Jordan Rose919e8a12012-08-08 18:23:36 +00001578 if (Region && Region->canPrintPretty()) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001579 os << " of memory pointed to by '";
Jordan Rose919e8a12012-08-08 18:23:36 +00001580 Region->printPretty(os);
Jordan Rose0d53ab42012-08-08 18:23:31 +00001581 os << '\'';
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001582 }
1583
Anna Zaks97bfb552013-01-08 00:25:29 +00001584 BugReport *R = new BugReport(*BT_Leak, os.str(), N,
1585 LocUsedForUniqueing,
1586 AllocNode->getLocationContext()->getDecl());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001587 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +00001588 R->addVisitor(new MallocBugVisitor(Sym, true));
Jordan Rose785950e2012-11-02 01:53:40 +00001589 C.emitReport(R);
Anna Zaksda046772012-02-11 21:02:40 +00001590}
1591
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001592void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1593 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001594{
Zhongxing Xu173ff562010-08-15 08:19:57 +00001595 if (!SymReaper.hasDeadSymbols())
1596 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001597
Ted Kremenek8bef8232012-01-26 21:29:00 +00001598 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001599 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +00001600 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001601
Dmitri Gribenkocfa88f82013-01-12 19:30:44 +00001602 SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +00001603 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1604 if (SymReaper.isDead(I->first)) {
Anna Zaks54458702012-10-29 22:51:54 +00001605 if (I->second.isAllocated())
Anna Zaksf8c17b72012-02-09 06:48:19 +00001606 Errors.push_back(I->first);
Jordy Rose90760142010-08-18 04:33:47 +00001607 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001608 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +00001609
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001610 }
1611 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001612
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001613 // Cleanup the Realloc Pairs Map.
Jordan Rose166d5022012-11-02 01:54:06 +00001614 ReallocPairsTy RP = state->get<ReallocPairs>();
1615 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaks40add292012-02-15 00:11:25 +00001616 if (SymReaper.isDead(I->first) ||
1617 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001618 state = state->remove<ReallocPairs>(I->first);
1619 }
1620 }
1621
Anna Zaks4141e4d2012-11-13 03:18:01 +00001622 // Cleanup the FreeReturnValue Map.
1623 FreeReturnValueTy FR = state->get<FreeReturnValue>();
1624 for (FreeReturnValueTy::iterator I = FR.begin(), E = FR.end(); I != E; ++I) {
1625 if (SymReaper.isDead(I->first) ||
1626 SymReaper.isDead(I->second)) {
1627 state = state->remove<FreeReturnValue>(I->first);
1628 }
1629 }
1630
Anna Zaksca8e36e2012-02-23 21:38:21 +00001631 // Generate leak node.
Anna Zaks54458702012-10-29 22:51:54 +00001632 ExplodedNode *N = C.getPredecessor();
1633 if (!Errors.empty()) {
1634 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
1635 N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Dmitri Gribenkocfa88f82013-01-12 19:30:44 +00001636 for (SmallVector<SymbolRef, 2>::iterator
Anna Zaks54458702012-10-29 22:51:54 +00001637 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
Anna Zaksda046772012-02-11 21:02:40 +00001638 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001639 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001640 }
Anna Zaks54458702012-10-29 22:51:54 +00001641
Anna Zaksca8e36e2012-02-23 21:38:21 +00001642 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +00001643}
Zhongxing Xu243fde92009-11-17 07:54:15 +00001644
Anna Zaks66c40402012-02-14 21:55:24 +00001645void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +00001646 // We will check for double free in the post visit.
Anton Yartsev2de19ed2013-03-25 01:35:45 +00001647 if ((Filter.CMallocOptimistic || Filter.CMallocPessimistic) &&
1648 isFreeFunction(C.getCalleeDecl(CE), C.getASTContext()))
1649 return;
1650
1651 if (Filter.CNewDeleteChecker &&
1652 isStandardNewDelete(C.getCalleeDecl(CE), C.getASTContext()))
Anna Zaks66c40402012-02-14 21:55:24 +00001653 return;
1654
1655 // Check use after free, when a freed pointer is passed to a call.
1656 ProgramStateRef State = C.getState();
1657 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
1658 E = CE->arg_end(); I != E; ++I) {
1659 const Expr *A = *I;
1660 if (A->getType().getTypePtr()->isAnyPointerType()) {
Anton Yartsevbb369952013-03-13 14:39:10 +00001661 SymbolRef Sym = C.getSVal(A).getAsSymbol();
Anna Zaks66c40402012-02-14 21:55:24 +00001662 if (!Sym)
1663 continue;
1664 if (checkUseAfterFree(Sym, C, A))
1665 return;
1666 }
1667 }
1668}
1669
Anna Zaks91c2a112012-02-08 23:16:56 +00001670void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1671 const Expr *E = S->getRetValue();
1672 if (!E)
1673 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001674
1675 // Check if we are returning a symbol.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001676 ProgramStateRef State = C.getState();
1677 SVal RetVal = State->getSVal(E, C.getLocationContext());
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001678 SymbolRef Sym = RetVal.getAsSymbol();
1679 if (!Sym)
1680 // If we are returning a field of the allocated struct or an array element,
1681 // the callee could still free the memory.
1682 // TODO: This logic should be a part of generic symbol escape callback.
1683 if (const MemRegion *MR = RetVal.getAsRegion())
1684 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1685 if (const SymbolicRegion *BMR =
1686 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1687 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001688
Anna Zaks0860cd02012-02-11 21:44:39 +00001689 // Check if we are returning freed memory.
Jordan Rose0d53ab42012-08-08 18:23:31 +00001690 if (Sym)
Jordan Rose65d4bd62012-11-15 19:11:33 +00001691 checkUseAfterFree(Sym, C, E);
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001692}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001693
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001694// TODO: Blocks should be either inlined or should call invalidate regions
1695// upon invocation. After that's in place, special casing here will not be
1696// needed.
1697void MallocChecker::checkPostStmt(const BlockExpr *BE,
1698 CheckerContext &C) const {
1699
1700 // Scan the BlockDecRefExprs for any object the retain count checker
1701 // may be tracking.
1702 if (!BE->getBlockDecl()->hasCaptures())
1703 return;
1704
1705 ProgramStateRef state = C.getState();
1706 const BlockDataRegion *R =
1707 cast<BlockDataRegion>(state->getSVal(BE,
1708 C.getLocationContext()).getAsRegion());
1709
1710 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1711 E = R->referenced_vars_end();
1712
1713 if (I == E)
1714 return;
1715
1716 SmallVector<const MemRegion*, 10> Regions;
1717 const LocationContext *LC = C.getLocationContext();
1718 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1719
1720 for ( ; I != E; ++I) {
Ted Kremeneke3ce2c12012-12-06 07:17:20 +00001721 const VarRegion *VR = I.getCapturedRegion();
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001722 if (VR->getSuperRegion() == R) {
1723 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1724 }
1725 Regions.push_back(VR);
1726 }
1727
1728 state =
1729 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1730 Regions.data() + Regions.size()).getState();
1731 C.addTransition(state);
1732}
1733
Anna Zaks14345182012-05-18 01:16:10 +00001734bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001735 assert(Sym);
1736 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks14345182012-05-18 01:16:10 +00001737 return (RS && RS->isReleased());
1738}
1739
1740bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1741 const Stmt *S) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001742
Anton Yartsevbb369952013-03-13 14:39:10 +00001743 if (isReleased(Sym, C)) {
1744 ReportUseAfterFree(C, S->getSourceRange(), Sym);
1745 return true;
Anna Zaks91c2a112012-02-08 23:16:56 +00001746 }
Anton Yartsevbb369952013-03-13 14:39:10 +00001747
Anna Zaks91c2a112012-02-08 23:16:56 +00001748 return false;
1749}
1750
Zhongxing Xuc8023782010-03-10 04:58:55 +00001751// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001752void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1753 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001754 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001755 if (Sym)
Anna Zaks14345182012-05-18 01:16:10 +00001756 checkUseAfterFree(Sym, C, S);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001757}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001758
Anna Zaks4fb54872012-02-11 21:02:35 +00001759// If a symbolic region is assumed to NULL (or another constant), stop tracking
1760// it - assuming that allocation failed on this path.
1761ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1762 SVal Cond,
1763 bool Assumption) const {
1764 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001765 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001766 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Roseec8d4202012-11-01 00:18:27 +00001767 ConstraintManager &CMgr = state->getConstraintManager();
1768 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
1769 if (AllocFailed.isConstrainedTrue())
Anna Zaks4fb54872012-02-11 21:02:35 +00001770 state = state->remove<RegionState>(I.getKey());
1771 }
1772
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001773 // Realloc returns 0 when reallocation fails, which means that we should
1774 // restore the state of the pointer being reallocated.
Jordan Rose166d5022012-11-02 01:54:06 +00001775 ReallocPairsTy RP = state->get<ReallocPairs>();
1776 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Ted Kremenek47cbd0f2012-09-07 22:31:01 +00001777 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Roseec8d4202012-11-01 00:18:27 +00001778 ConstraintManager &CMgr = state->getConstraintManager();
1779 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
Jordan Rose79a29eb2012-11-01 00:25:15 +00001780 if (!AllocFailed.isConstrainedTrue())
Anna Zaks9dc298b2012-09-12 22:57:34 +00001781 continue;
Jordan Roseec8d4202012-11-01 00:18:27 +00001782
Anna Zaks9dc298b2012-09-12 22:57:34 +00001783 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1784 if (const RefState *RS = state->get<RegionState>(ReallocSym)) {
1785 if (RS->isReleased()) {
1786 if (I.getData().Kind == RPToBeFreedAfterFailure)
Anna Zaks40add292012-02-15 00:11:25 +00001787 state = state->set<RegionState>(ReallocSym,
Anton Yartsev849c7bf2013-03-28 17:05:19 +00001788 RefState::getAllocated(RS->getAllocationFamily(), RS->getStmt()));
Anna Zaks9dc298b2012-09-12 22:57:34 +00001789 else if (I.getData().Kind == RPDoNotTrackAfterFailure)
1790 state = state->remove<RegionState>(ReallocSym);
1791 else
1792 assert(I.getData().Kind == RPIsFreeOnFailure);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001793 }
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001794 }
Anna Zaks9dc298b2012-09-12 22:57:34 +00001795 state = state->remove<ReallocPairs>(I.getKey());
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001796 }
1797
Anna Zaks4fb54872012-02-11 21:02:35 +00001798 return state;
1799}
1800
Jordan Rose9fe09f32013-03-09 00:59:10 +00001801bool MallocChecker::doesNotFreeMemOrInteresting(const CallEvent *Call,
1802 ProgramStateRef State) const {
Jordan Rose85d7e012012-07-02 19:27:51 +00001803 assert(Call);
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001804
1805 // For now, assume that any C++ call can free memory.
1806 // TODO: If we want to be more optimistic here, we'll need to make sure that
1807 // regions escape to C++ containers. They seem to do that even now, but for
1808 // mysterious reasons.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001809 if (!(isa<FunctionCall>(Call) || isa<ObjCMethodCall>(Call)))
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001810 return false;
1811
Jordan Rose740d4902012-07-02 19:27:35 +00001812 // Check Objective-C messages by selector name.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001813 if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) {
Jordan Rose85d7e012012-07-02 19:27:51 +00001814 // If it's not a framework call, or if it takes a callback, assume it
1815 // can free memory.
1816 if (!Call->isInSystemHeader() || Call->hasNonZeroCallbackArg())
Anna Zaks07d39a42012-02-28 01:54:22 +00001817 return false;
1818
Jordan Rose9fe09f32013-03-09 00:59:10 +00001819 // If it's a method we know about, handle it explicitly post-call.
1820 // This should happen before the "freeWhenDone" check below.
1821 if (isKnownDeallocObjCMethodName(*Msg))
1822 return true;
Anna Zaks52a04812012-06-20 23:35:57 +00001823
Jordan Rose9fe09f32013-03-09 00:59:10 +00001824 // If there's a "freeWhenDone" parameter, but the method isn't one we know
1825 // about, we can't be sure that the object will use free() to deallocate the
1826 // memory, so we can't model it explicitly. The best we can do is use it to
1827 // decide whether the pointer escapes.
1828 if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(*Msg))
1829 return !*FreeWhenDone;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001830
Jordan Rose9fe09f32013-03-09 00:59:10 +00001831 // If the first selector piece ends with "NoCopy", and there is no
1832 // "freeWhenDone" parameter set to zero, we know ownership is being
1833 // transferred. Again, though, we can't be sure that the object will use
1834 // free() to deallocate the memory, so we can't model it explicitly.
1835 StringRef FirstSlot = Msg->getSelector().getNameForSlot(0);
Jordan Rose740d4902012-07-02 19:27:35 +00001836 if (FirstSlot.endswith("NoCopy"))
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001837 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001838
Anna Zaks5f757682012-06-19 05:10:32 +00001839 // If the first selector starts with addPointer, insertPointer,
1840 // or replacePointer, assume we are dealing with NSPointerArray or similar.
1841 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose740d4902012-07-02 19:27:35 +00001842 // that the pointers get freed by following the container itself.
1843 if (FirstSlot.startswith("addPointer") ||
1844 FirstSlot.startswith("insertPointer") ||
1845 FirstSlot.startswith("replacePointer")) {
Anna Zaks5f757682012-06-19 05:10:32 +00001846 return false;
1847 }
1848
Jordan Rose740d4902012-07-02 19:27:35 +00001849 // Otherwise, assume that the method does not free memory.
1850 // Most framework methods do not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001851 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001852 }
1853
Jordan Rose740d4902012-07-02 19:27:35 +00001854 // At this point the only thing left to handle is straight function calls.
1855 const FunctionDecl *FD = cast<FunctionCall>(Call)->getDecl();
1856 if (!FD)
1857 return false;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001858
Jordan Rose740d4902012-07-02 19:27:35 +00001859 ASTContext &ASTC = State->getStateManager().getContext();
1860
1861 // If it's one of the allocation functions we can reason about, we model
1862 // its behavior explicitly.
1863 if (isMemFunction(FD, ASTC))
1864 return true;
1865
1866 // If it's not a system call, assume it frees memory.
1867 if (!Call->isInSystemHeader())
1868 return false;
1869
1870 // White list the system functions whose arguments escape.
1871 const IdentifierInfo *II = FD->getIdentifier();
1872 if (!II)
1873 return false;
1874 StringRef FName = II->getName();
1875
Jordan Rose740d4902012-07-02 19:27:35 +00001876 // White list the 'XXXNoCopy' CoreFoundation functions.
Jordan Rose85d7e012012-07-02 19:27:51 +00001877 // We specifically check these before
Jordan Rose740d4902012-07-02 19:27:35 +00001878 if (FName.endswith("NoCopy")) {
1879 // Look for the deallocator argument. We know that the memory ownership
1880 // is not transferred only if the deallocator argument is
1881 // 'kCFAllocatorNull'.
1882 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1883 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
1884 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1885 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1886 if (DeallocatorName == "kCFAllocatorNull")
1887 return true;
1888 }
1889 }
1890 return false;
1891 }
1892
Jordan Rose740d4902012-07-02 19:27:35 +00001893 // Associating streams with malloced buffers. The pointer can escape if
Jordan Rose85d7e012012-07-02 19:27:51 +00001894 // 'closefn' is specified (and if that function does free memory),
1895 // but it will not if closefn is not specified.
Jordan Rose740d4902012-07-02 19:27:35 +00001896 // Currently, we do not inspect the 'closefn' function (PR12101).
1897 if (FName == "funopen")
Jordan Rose85d7e012012-07-02 19:27:51 +00001898 if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0))
1899 return true;
Jordan Rose740d4902012-07-02 19:27:35 +00001900
1901 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1902 // these leaks might be intentional when setting the buffer for stdio.
1903 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1904 if (FName == "setbuf" || FName =="setbuffer" ||
1905 FName == "setlinebuf" || FName == "setvbuf") {
1906 if (Call->getNumArgs() >= 1) {
1907 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
1908 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
1909 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
1910 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
1911 return false;
1912 }
1913 }
1914
1915 // A bunch of other functions which either take ownership of a pointer or
1916 // wrap the result up in a struct or object, meaning it can be freed later.
1917 // (See RetainCountChecker.) Not all the parameters here are invalidated,
1918 // but the Malloc checker cannot differentiate between them. The right way
1919 // of doing this would be to implement a pointer escapes callback.
1920 if (FName == "CGBitmapContextCreate" ||
1921 FName == "CGBitmapContextCreateWithData" ||
1922 FName == "CVPixelBufferCreateWithBytes" ||
1923 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1924 FName == "OSAtomicEnqueue") {
1925 return false;
1926 }
1927
Jordan Rose85d7e012012-07-02 19:27:51 +00001928 // Handle cases where we know a buffer's /address/ can escape.
1929 // Note that the above checks handle some special cases where we know that
1930 // even though the address escapes, it's still our responsibility to free the
1931 // buffer.
1932 if (Call->argumentsMayEscape())
Jordan Rose740d4902012-07-02 19:27:35 +00001933 return false;
1934
1935 // Otherwise, assume that the function does not free memory.
1936 // Most system calls do not free the memory.
1937 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001938}
1939
Anna Zaks41988f32013-03-28 23:15:29 +00001940static bool retTrue(const RefState *RS) {
1941 return true;
1942}
1943
1944static bool checkIfNewOrNewArrayFamily(const RefState *RS) {
1945 return (RS->getAllocationFamily() == AF_CXXNewArray ||
1946 RS->getAllocationFamily() == AF_CXXNew);
1947}
1948
Anna Zaksbf53dfa2012-12-20 00:38:25 +00001949ProgramStateRef MallocChecker::checkPointerEscape(ProgramStateRef State,
1950 const InvalidatedSymbols &Escaped,
Anna Zaks233e26a2013-02-07 23:05:43 +00001951 const CallEvent *Call,
1952 PointerEscapeKind Kind) const {
Anna Zaks41988f32013-03-28 23:15:29 +00001953 return checkPointerEscapeAux(State, Escaped, Call, Kind, &retTrue);
1954}
1955
1956ProgramStateRef MallocChecker::checkConstPointerEscape(ProgramStateRef State,
1957 const InvalidatedSymbols &Escaped,
1958 const CallEvent *Call,
1959 PointerEscapeKind Kind) const {
1960 return checkPointerEscapeAux(State, Escaped, Call, Kind,
1961 &checkIfNewOrNewArrayFamily);
1962}
1963
1964ProgramStateRef MallocChecker::checkPointerEscapeAux(ProgramStateRef State,
1965 const InvalidatedSymbols &Escaped,
1966 const CallEvent *Call,
1967 PointerEscapeKind Kind,
1968 bool(*CheckRefState)(const RefState*)) const {
Jordan Rose9fe09f32013-03-09 00:59:10 +00001969 // If we know that the call does not free memory, or we want to process the
1970 // call later, keep tracking the top level arguments.
Anna Zaks233e26a2013-02-07 23:05:43 +00001971 if ((Kind == PSK_DirectEscapeOnCall ||
1972 Kind == PSK_IndirectEscapeOnCall) &&
Jordan Rose9fe09f32013-03-09 00:59:10 +00001973 doesNotFreeMemOrInteresting(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001974 return State;
Anna Zaks233e26a2013-02-07 23:05:43 +00001975 }
Anna Zaks66c40402012-02-14 21:55:24 +00001976
Anna Zaksbf53dfa2012-12-20 00:38:25 +00001977 for (InvalidatedSymbols::const_iterator I = Escaped.begin(),
Anna Zaks41988f32013-03-28 23:15:29 +00001978 E = Escaped.end();
1979 I != E; ++I) {
Anna Zaks4fb54872012-02-11 21:02:35 +00001980 SymbolRef sym = *I;
Anna Zaksbf53dfa2012-12-20 00:38:25 +00001981
Anna Zaks5b7aa342012-06-22 02:04:31 +00001982 if (const RefState *RS = State->get<RegionState>(sym)) {
Anna Zaks41988f32013-03-28 23:15:29 +00001983 if (RS->isAllocated() && CheckRefState(RS))
Anna Zaks431e35c2012-08-09 00:42:24 +00001984 State = State->remove<RegionState>(sym);
Anna Zaks5b7aa342012-06-22 02:04:31 +00001985 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001986 }
Anna Zaks66c40402012-02-14 21:55:24 +00001987 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001988}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001989
Jordy Rose393f98b2012-03-18 07:43:35 +00001990static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1991 ProgramStateRef prevState) {
Jordan Rose166d5022012-11-02 01:54:06 +00001992 ReallocPairsTy currMap = currState->get<ReallocPairs>();
1993 ReallocPairsTy prevMap = prevState->get<ReallocPairs>();
Jordy Rose393f98b2012-03-18 07:43:35 +00001994
Jordan Rose166d5022012-11-02 01:54:06 +00001995 for (ReallocPairsTy::iterator I = prevMap.begin(), E = prevMap.end();
Jordy Rose393f98b2012-03-18 07:43:35 +00001996 I != E; ++I) {
1997 SymbolRef sym = I.getKey();
1998 if (!currMap.lookup(sym))
1999 return sym;
2000 }
2001
2002 return NULL;
2003}
2004
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002005PathDiagnosticPiece *
2006MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
2007 const ExplodedNode *PrevN,
2008 BugReporterContext &BRC,
2009 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00002010 ProgramStateRef state = N->getState();
2011 ProgramStateRef statePrev = PrevN->getState();
2012
2013 const RefState *RS = state->get<RegionState>(Sym);
2014 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksede875b2012-08-03 18:30:18 +00002015 if (!RS)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002016 return 0;
2017
Anna Zaksfe571602012-02-16 22:26:07 +00002018 const Stmt *S = 0;
2019 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00002020 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00002021
2022 // Retrieve the associated statement.
2023 ProgramPoint ProgLoc = N->getLocation();
David Blaikie7a95de62013-02-21 22:23:56 +00002024 if (Optional<StmtPoint> SP = ProgLoc.getAs<StmtPoint>()) {
Jordan Rose852aa0d2012-07-10 22:07:52 +00002025 S = SP->getStmt();
David Blaikie7a95de62013-02-21 22:23:56 +00002026 } else if (Optional<CallExitEnd> Exit = ProgLoc.getAs<CallExitEnd>()) {
Jordan Rose852aa0d2012-07-10 22:07:52 +00002027 S = Exit->getCalleeContext()->getCallSite();
David Blaikie7a95de62013-02-21 22:23:56 +00002028 } else if (Optional<BlockEdge> Edge = ProgLoc.getAs<BlockEdge>()) {
Ted Kremeneka4a17592013-01-04 19:04:36 +00002029 // If an assumption was made on a branch, it should be caught
2030 // here by looking at the state transition.
2031 S = Edge->getSrc()->getTerminator();
Anna Zaksfe571602012-02-16 22:26:07 +00002032 }
Ted Kremeneka4a17592013-01-04 19:04:36 +00002033
Anna Zaksfe571602012-02-16 22:26:07 +00002034 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002035 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002036
Jordan Rose28038f32012-07-10 22:07:42 +00002037 // FIXME: We will eventually need to handle non-statement-based events
2038 // (__attribute__((cleanup))).
2039
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002040 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00002041 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00002042 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00002043 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00002044 StackHint = new StackHintGeneratorForSymbol(Sym,
2045 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00002046 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00002047 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00002048 StackHint = new StackHintGeneratorForSymbol(Sym,
2049 "Returned released memory");
Anna Zaks5b7aa342012-06-22 02:04:31 +00002050 } else if (isRelinquished(RS, RSPrev, S)) {
2051 Msg = "Memory ownership is transfered";
2052 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks368a0d52012-03-15 21:13:02 +00002053 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00002054 Mode = ReallocationFailed;
2055 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00002056 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00002057 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00002058
Jordy Roseb000fb52012-03-24 03:15:09 +00002059 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
2060 // Is it possible to fail two reallocs WITHOUT testing in between?
2061 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
2062 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00002063 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00002064 FailedReallocSymbol = sym;
2065 }
Anna Zaksfe571602012-02-16 22:26:07 +00002066 }
2067
2068 // We are in a special mode if a reallocation failed later in the path.
2069 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00002070 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00002071
Jordy Roseb000fb52012-03-24 03:15:09 +00002072 // Is this is the first appearance of the reallocated symbol?
2073 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
Jordy Roseb000fb52012-03-24 03:15:09 +00002074 // We're at the reallocation point.
2075 Msg = "Attempt to reallocate memory";
2076 StackHint = new StackHintGeneratorForSymbol(Sym,
2077 "Returned reallocated memory");
2078 FailedReallocSymbol = NULL;
2079 Mode = Normal;
2080 }
Anna Zaksfe571602012-02-16 22:26:07 +00002081 }
2082
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002083 if (!Msg)
2084 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00002085 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002086
2087 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00002088 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002089 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00002090 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002091}
2092
Anna Zaks93c5a242012-05-02 00:05:20 +00002093void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
2094 const char *NL, const char *Sep) const {
2095
2096 RegionStateTy RS = State->get<RegionState>();
2097
Ted Kremenekc37fad62013-01-03 01:30:12 +00002098 if (!RS.isEmpty()) {
2099 Out << Sep << "MallocChecker:" << NL;
2100 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
2101 I.getKey()->dumpToStream(Out);
2102 Out << " : ";
2103 I.getData().dump(Out);
2104 Out << NL;
2105 }
2106 }
Anna Zaks93c5a242012-05-02 00:05:20 +00002107}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00002108
Anna Zaks231361a2012-02-08 23:16:52 +00002109#define REGISTER_CHECKER(name) \
2110void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00002111 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00002112 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00002113}
Anna Zaks231361a2012-02-08 23:16:52 +00002114
2115REGISTER_CHECKER(MallocPessimistic)
2116REGISTER_CHECKER(MallocOptimistic)
Anton Yartsev2de19ed2013-03-25 01:35:45 +00002117REGISTER_CHECKER(NewDeleteChecker)
Anton Yartsev849c7bf2013-03-28 17:05:19 +00002118REGISTER_CHECKER(MismatchedDeallocatorChecker)