commit f1d6a0797b13c1b1c364ab4ee9b500e5455aeeeb
author Brian Behlendorf <behlendorf1@llnl.gov> Wed Mar 21 17:19:55 2007 -0400
committer Theodore Ts'o <tytso@mit.edu> Wed Mar 21 17:19:55 2007 -0400
tree b3b9566d5ee3ef3ebca9f24be3c3cc89cce289dc
parent 5f7fe7fe0e96965b9cb4f6d1e2fa08acc175d7be

[COVERITY] Fix (error case) file handle leak in util/subst program

Need to close old_f before returning since it had been successfully opened
before.

Coverity ID: 19: Resource Leak

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>

util/subst.c

diff --git a/util/subst.c b/util/subst.c
index 445d318..fadf328 100644
--- a/util/subst.c
+++ b/util/subst.c
@@ -279,8 +279,10 @@
 	if (!old_f)
 		return 0;
 	new_f = fopen(newfn, "r");
-	if (!new_f)
+	if (!new_f) {
+		fclose(old_f);
 		return 0;
+	}
 
 	while (1) {
 		oldcp = fgets(oldbuf, sizeof(oldbuf), old_f);