commit 4b159fa61a9c3ed7e00c8135189c184dcc48c69f
author Jens Axboe <axboe@fb.com> Mon Apr 14 08:49:04 2014 -0600
committer Jens Axboe <axboe@fb.com> Mon Apr 14 08:52:33 2014 -0600
tree cd4f02b8d362d8a84d4e6dad5cc46d1b099acedd
parent da27a4bf0f9753fcc9da7b63f1be482fc0349907

net engine: fix potential buffer overrun in socket path

Signed-off-by: Jens Axboe <axboe@fb.com>

engines/net.c

diff --git a/engines/net.c b/engines/net.c
index d036a58..3e26131 100644
--- a/engines/net.c
+++ b/engines/net.c
@@ -945,7 +945,8 @@
 	struct sockaddr_un *soun = &nd->addr_un;
 
 	soun->sun_family = AF_UNIX;
-	strcpy(soun->sun_path, path);
+	memset(soun->sun_path, 0, sizeof(soun->sun_path));
+	strncpy(soun->sun_path, path, sizeof(soun->sun_path) - 1);
 	return 0;
 }
 
@@ -976,7 +977,7 @@
 
 	memset(addr, 0, sizeof(*addr));
 	addr->sun_family = AF_UNIX;
-	strcpy(addr->sun_path, path);
+	strncpy(addr->sun_path, path, sizeof(addr->sun_path) - 1);
 	unlink(path);
 
 	len = sizeof(addr->sun_family) + strlen(path) + 1;