commit 63f29372bc1bd69b66816c96d88b9c0bd8f3d8b9
author Jens Axboe <jens.axboe@oracle.com> Wed Jan 10 13:20:09 2007 +0100
committer Jens Axboe <jens.axboe@oracle.com> Wed Jan 10 13:20:09 2007 +0100
tree 1ab89aaac66c6df10dcdc46d46dc94f01a5bbb03
parent 13335ddb0e304efa0fc96593dd1fd995ec6f68d7

[PATCH] Option minval should be signed

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

parse.c

diff --git a/parse.c b/parse.c
index 1cc55dc..abe0653 100644
--- a/parse.c
+++ b/parse.c
@@ -48,7 +48,7 @@
 /*
  * convert string into decimal value, noting any size suffix
  */
-static int str_to_decimal(const char *str, unsigned long long *val, int kilo)
+static int str_to_decimal(const char *str, long long *val, int kilo)
 {
 	int len;
 
@@ -68,12 +68,12 @@
 	return 0;
 }
 
-static int check_str_bytes(const char *p, unsigned long long *val)
+static int check_str_bytes(const char *p, long long *val)
 {
 	return str_to_decimal(p, val, 1);
 }
 
-static int check_str_time(const char *p, unsigned long long *val)
+static int check_str_time(const char *p, long long *val)
 {
 	return str_to_decimal(p, val, 0);
 }
@@ -96,7 +96,7 @@
 	*(s + 1) = '\0';
 }
 
-static int check_range_bytes(const char *str, unsigned long *val)
+static int check_range_bytes(const char *str, long *val)
 {
 	char suffix;
 
@@ -114,7 +114,7 @@
 	return 1;
 }
 
-static int check_int(const char *p, unsigned int *val)
+static int check_int(const char *p, int *val)
 {
 	if (!strlen(p))
 		return 1;
@@ -148,9 +148,9 @@
 static int __handle_option(struct fio_option *o, const char *ptr, void *data,
 			   int first, int more)
 {
-	unsigned int il, *ilp;
-	unsigned long long ull, *ullp;
-	unsigned long ul1, ul2;
+	int il, *ilp;
+	long long ull, *ullp;
+	long ul1, ul2;
 	char **cp;
 	int ret = 0, is_time = 0;
 
@@ -252,7 +252,7 @@
 		if (ret)
 			break;
 
-		if (o->maxval && il > o->maxval)
+		if (o->maxval && il > (int) o->maxval)
 			il = o->maxval;
 		if (o->minval && il < o->minval)
 			il = o->minval;