commit 6625155407de739e1e857419b7b4fb62f6c6bb2e
author Jens Axboe <jaxboe@fusionio.com> Thu May 12 10:14:57 2011 +0200
committer Jens Axboe <jaxboe@fusionio.com> Thu May 12 10:14:57 2011 +0200
tree afddea7b42e7c60a54d95cbcdf8422b0291b663b
parent 67897036632676ce1bfdb45992df078df87c1a27

Fix crash on specifying bad IO engine on the command line

Signed-off-by: Jens Axboe <jaxboe@fusionio.com>

init.c

diff --git a/init.c b/init.c
index 37e0c48..26e42ef 100644
--- a/init.c
+++ b/init.c
@@ -568,7 +568,7 @@
 	}
 
 	if (profile_td_init(td))
-		return 1;
+		goto err;
 
 	engine = get_engine_name(td->o.ioengine);
 	td->io_ops = load_ioengine(td, engine);
@@ -1222,10 +1222,8 @@
 
 			if (!strncmp(opt, "name", 4) && td) {
 				ret = add_job(td, td->o.name ?: "fio", 0);
-				if (ret) {
-					put_job(td);
+				if (ret)
 					return 0;
-				}
 				td = NULL;
 			}
 			if (!td) {
@@ -1262,8 +1260,6 @@
 	if (td) {
 		if (!ret)
 			ret = add_job(td, td->o.name ?: "fio", 0);
-		if (ret)
-			put_job(td);
 	}
 
 	while (optind < argc) {