When verify fails, dump the good/bad blocks to files
This makes it easy to compare afterwards to see what kind of
corruption was experienced.
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
diff --git a/fio.c b/fio.c
index 9c55670..e475a36 100644
--- a/fio.c
+++ b/fio.c
@@ -865,7 +865,7 @@
* Fill the buffer with the pattern if we are
* going to be doing writes.
*/
- fill_pattern(td, io_u->buf, max_bs, io_u);
+ fill_pattern(td, io_u->buf, max_bs, io_u, 0, 0);
}
}
diff --git a/ioengine.h b/ioengine.h
index 48a042b..c56bd50 100644
--- a/ioengine.h
+++ b/ioengine.h
@@ -49,6 +49,11 @@
unsigned long long offset;
/*
+ * Initial seed for generating the buffer contents
+ */
+ unsigned long rand_seed;
+
+ /*
* IO engine state, may be different from above when we get
* partial transfers / residual data counts
*/
diff --git a/lib/rand.c b/lib/rand.c
index 839a6a9..0681282 100644
--- a/lib/rand.c
+++ b/lib/rand.c
@@ -59,18 +59,25 @@
__rand(state);
}
-void fill_random_buf(void *buf, unsigned int len)
+void __fill_random_buf(void *buf, unsigned int len, unsigned long seed)
{
- unsigned long r = __rand(&__fio_rand_state);
long *ptr = buf;
- if (sizeof(int) != sizeof(*ptr))
+ while ((void *) ptr - buf < len) {
+ *ptr = seed;
+ ptr++;
+ seed *= GOLDEN_RATIO_PRIME;
+ seed >>= 3;
+ }
+}
+
+unsigned long fill_random_buf(void *buf, unsigned int len)
+{
+ unsigned long r = __rand(&__fio_rand_state);
+
+ if (sizeof(int) != sizeof(long *))
r *= (unsigned long) __rand(&__fio_rand_state);
- while ((void *) ptr - buf < len) {
- *ptr = r;
- ptr++;
- r *= GOLDEN_RATIO_PRIME;
- r >>= 3;
- }
+ __fill_random_buf(buf, len, r);
+ return r;
}
diff --git a/lib/rand.h b/lib/rand.h
index 573116c..02e6858 100644
--- a/lib/rand.h
+++ b/lib/rand.h
@@ -19,6 +19,7 @@
}
extern void init_rand(struct frand_state *);
-extern void fill_random_buf(void *buf, unsigned int len);
+extern void __fill_random_buf(void *buf, unsigned int len, unsigned long seed);
+extern unsigned long fill_random_buf(void *buf, unsigned int len);
#endif
diff --git a/verify.c b/verify.c
index dc10708..81b05a9 100644
--- a/verify.c
+++ b/verify.c
@@ -23,12 +23,19 @@
#include "crc/sha512.h"
#include "crc/sha1.h"
-void fill_pattern(struct thread_data *td, void *p, unsigned int len, struct io_u *io_u)
+static void populate_hdr(struct thread_data *td, struct io_u *io_u,
+ struct verify_header *hdr, unsigned int header_num,
+ unsigned int header_len);
+
+void fill_pattern(struct thread_data *td, void *p, unsigned int len, struct io_u *io_u, unsigned long seed, int use_seed)
{
switch (td->o.verify_pattern_bytes) {
case 0:
dprint(FD_VERIFY, "fill random bytes len=%u\n", len);
- fill_random_buf(p, len);
+ if (use_seed)
+ __fill_random_buf(p, len, seed);
+ else
+ io_u->rand_seed = fill_random_buf(p, len);
break;
case 1:
if (io_u->buf_filled_len >= len) {
@@ -156,6 +163,7 @@
*/
struct io_u *io_u;
unsigned int hdr_num;
+ struct thread_data *td;
/*
* Output, only valid in case of error
@@ -166,6 +174,70 @@
unsigned int crc_len;
};
+static void dump_buf(char *buf, unsigned int len, const char *name,
+ unsigned long long offset)
+{
+ char fname[80];
+ int ret, fd;
+
+ sprintf(fname, "%llu.%s", offset, name);
+
+ fd = open(fname, O_CREAT | O_TRUNC | O_WRONLY, 0644);
+ if (fd < 0) {
+ perror("open verify buf file");
+ return;
+ }
+
+ while (len) {
+ ret = write(fd, buf, len);
+ if (!ret)
+ break;
+ else if (ret < 0) {
+ perror("write verify buf file");
+ break;
+ }
+ len -= ret;
+ buf += ret;
+ }
+
+ close(fd);
+ log_err(" %s data dumped as %s\n", name, fname);
+}
+
+static void dump_verify_buffers(struct verify_header *hdr, struct vcont *vc)
+{
+ struct thread_data *td = vc->td;
+ struct io_u *io_u = vc->io_u;
+ unsigned long hdr_offset;
+ unsigned int hdr_inc, header_num;
+ struct io_u dummy;
+ void *buf, *p;
+
+ hdr_offset = vc->hdr_num * hdr->len;
+
+ dump_buf(io_u->buf + hdr_offset, hdr->len, "received",
+ io_u->offset + hdr_offset);
+
+ buf = p = malloc(io_u->buflen);
+ dummy = *io_u;
+ fill_pattern(td, p, io_u->buflen, &dummy, hdr->rand_seed, 1);
+
+ hdr_inc = io_u->buflen;
+ if (td->o.verify_interval)
+ hdr_inc = td->o.verify_interval;
+
+ header_num = 0;
+ for (; p < buf + io_u->buflen; p += hdr_inc) {
+ hdr = p;
+ populate_hdr(td, io_u, hdr, header_num, hdr_inc);
+ header_num++;
+ }
+
+ dump_buf(buf + hdr_offset, hdr->len, "expected",
+ io_u->offset + hdr_offset);
+ free(buf);
+}
+
static void log_verify_failure(struct verify_header *hdr, struct vcont *vc)
{
unsigned long long offset;
@@ -181,6 +253,8 @@
log_err(" Received CRC: ");
hexdump(vc->bad_crc, vc->crc_len);
}
+
+ dump_verify_buffers(hdr, vc);
}
/*
@@ -529,6 +603,7 @@
struct vcont vc = {
.io_u = io_u,
.hdr_num = hdr_num,
+ .td = td,
};
if (ret && td->o.verify_fatal)
@@ -713,6 +788,82 @@
md5_update(&md5_ctx, p, len);
}
+static void populate_hdr(struct thread_data *td, struct io_u *io_u,
+ struct verify_header *hdr, unsigned int header_num,
+ unsigned int header_len)
+{
+ unsigned int data_len;
+ void *data, *p;
+
+ p = (void *) hdr;
+
+ hdr->fio_magic = FIO_HDR_MAGIC;
+ hdr->len = header_len;
+ hdr->verify_type = td->o.verify;
+ hdr->rand_seed = io_u->rand_seed;
+ data_len = header_len - hdr_size(hdr);
+
+ data = p + hdr_size(hdr);
+ switch (td->o.verify) {
+ case VERIFY_MD5:
+ dprint(FD_VERIFY, "fill md5 io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_md5(hdr, data, data_len);
+ break;
+ case VERIFY_CRC64:
+ dprint(FD_VERIFY, "fill crc64 io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_crc64(hdr, data, data_len);
+ break;
+ case VERIFY_CRC32C:
+ case VERIFY_CRC32C_INTEL:
+ dprint(FD_VERIFY, "fill crc32c io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_crc32c(hdr, data, data_len);
+ break;
+ case VERIFY_CRC32:
+ dprint(FD_VERIFY, "fill crc32 io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_crc32(hdr, data, data_len);
+ break;
+ case VERIFY_CRC16:
+ dprint(FD_VERIFY, "fill crc16 io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_crc16(hdr, data, data_len);
+ break;
+ case VERIFY_CRC7:
+ dprint(FD_VERIFY, "fill crc7 io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_crc7(hdr, data, data_len);
+ break;
+ case VERIFY_SHA256:
+ dprint(FD_VERIFY, "fill sha256 io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_sha256(hdr, data, data_len);
+ break;
+ case VERIFY_SHA512:
+ dprint(FD_VERIFY, "fill sha512 io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_sha512(hdr, data, data_len);
+ break;
+ case VERIFY_META:
+ dprint(FD_VERIFY, "fill meta io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_meta(hdr, td, io_u, header_num);
+ break;
+ case VERIFY_SHA1:
+ dprint(FD_VERIFY, "fill sha1 io_u %p, len %u\n",
+ io_u, hdr->len);
+ fill_sha1(hdr, data, data_len);
+ break;
+ default:
+ log_err("fio: bad verify type: %d\n", td->o.verify);
+ assert(0);
+ }
+ if (td->o.verify_offset)
+ memswp(p, p + td->o.verify_offset, hdr_size(hdr));
+}
+
/*
* fill body of io_u->buf with random data and add a header with the
* crc32 or md5 sum of that data.
@@ -720,13 +871,13 @@
void populate_verify_io_u(struct thread_data *td, struct io_u *io_u)
{
struct verify_header *hdr;
- void *p = io_u->buf, *data;
- unsigned int hdr_inc, data_len, header_num = 0;
+ unsigned int hdr_inc, header_num = 0;
+ void *p = io_u->buf;
if (td->o.verify == VERIFY_NULL)
return;
- fill_pattern(td, p, io_u->buflen, io_u);
+ fill_pattern(td, p, io_u->buflen, io_u, 0, 0);
hdr_inc = io_u->buflen;
if (td->o.verify_interval)
@@ -734,71 +885,7 @@
for (; p < io_u->buf + io_u->buflen; p += hdr_inc) {
hdr = p;
-
- hdr->fio_magic = FIO_HDR_MAGIC;
- hdr->verify_type = td->o.verify;
- hdr->len = hdr_inc;
- data_len = hdr_inc - hdr_size(hdr);
-
- data = p + hdr_size(hdr);
- switch (td->o.verify) {
- case VERIFY_MD5:
- dprint(FD_VERIFY, "fill md5 io_u %p, len %u\n",
- io_u, hdr->len);
- fill_md5(hdr, data, data_len);
- break;
- case VERIFY_CRC64:
- dprint(FD_VERIFY, "fill crc64 io_u %p, len %u\n",
- io_u, hdr->len);
- fill_crc64(hdr, data, data_len);
- break;
- case VERIFY_CRC32C:
- case VERIFY_CRC32C_INTEL:
- dprint(FD_VERIFY, "fill crc32c io_u %p, len %u\n",
- io_u, hdr->len);
- fill_crc32c(hdr, data, data_len);
- break;
- case VERIFY_CRC32:
- dprint(FD_VERIFY, "fill crc32 io_u %p, len %u\n",
- io_u, hdr->len);
- fill_crc32(hdr, data, data_len);
- break;
- case VERIFY_CRC16:
- dprint(FD_VERIFY, "fill crc16 io_u %p, len %u\n",
- io_u, hdr->len);
- fill_crc16(hdr, data, data_len);
- break;
- case VERIFY_CRC7:
- dprint(FD_VERIFY, "fill crc7 io_u %p, len %u\n",
- io_u, hdr->len);
- fill_crc7(hdr, data, data_len);
- break;
- case VERIFY_SHA256:
- dprint(FD_VERIFY, "fill sha256 io_u %p, len %u\n",
- io_u, hdr->len);
- fill_sha256(hdr, data, data_len);
- break;
- case VERIFY_SHA512:
- dprint(FD_VERIFY, "fill sha512 io_u %p, len %u\n",
- io_u, hdr->len);
- fill_sha512(hdr, data, data_len);
- break;
- case VERIFY_META:
- dprint(FD_VERIFY, "fill meta io_u %p, len %u\n",
- io_u, hdr->len);
- fill_meta(hdr, td, io_u, header_num);
- break;
- case VERIFY_SHA1:
- dprint(FD_VERIFY, "fill sha1 io_u %p, len %u\n",
- io_u, hdr->len);
- fill_sha1(hdr, data, data_len);
- break;
- default:
- log_err("fio: bad verify type: %d\n", td->o.verify);
- assert(0);
- }
- if (td->o.verify_offset)
- memswp(p, p + td->o.verify_offset, hdr_size(hdr));
+ populate_hdr(td, io_u, hdr, header_num, hdr_inc);
header_num++;
}
}
diff --git a/verify.h b/verify.h
index a6f8974..d5a906e 100644
--- a/verify.h
+++ b/verify.h
@@ -30,6 +30,7 @@
unsigned int fio_magic;
unsigned int len;
unsigned int verify_type;
+ unsigned long rand_seed;
};
struct vhdr_md5 {
@@ -71,7 +72,7 @@
extern int __must_check get_next_verify(struct thread_data *td, struct io_u *);
extern int __must_check verify_io_u(struct thread_data *, struct io_u *);
extern int verify_io_u_async(struct thread_data *, struct io_u *);
-extern void fill_pattern(struct thread_data *td, void *p, unsigned int len, struct io_u *io_u);
+extern void fill_pattern(struct thread_data *td, void *p, unsigned int len, struct io_u *io_u, unsigned long seed, int use_seed);
/*
* Async verify offload