commit afdcad2315c22200d594a29885053d7671881ebb
author Jens Axboe <axboe@fb.com> Mon Apr 14 08:54:09 2014 -0600
committer Jens Axboe <axboe@fb.com> Mon Apr 14 08:54:09 2014 -0600
tree 7673c505ef8b6c54b8b04f5d5b135e1f598dca5b
parent 1cb964148482b2d50b1f82966f96545ebeec6428

server: fix potential buffer overrun in bind string

Signed-off-by: Jens Axboe <axboe@fb.com>

server.c

diff --git a/server.c b/server.c
index c2cf2dd..9442764 100644
--- a/server.c
+++ b/server.c
@@ -1368,6 +1368,8 @@
 	if (sk < 0)
 		return sk;
 
+	memset(bind_str, 0, sizeof(bind_str));
+
 	if (!bind_sock) {
 		char *p, port[16];
 		const void *src;
@@ -1387,9 +1389,9 @@
 		if (p)
 			strcat(p, port);
 		else
-			strcpy(bind_str, port);
+			strncpy(bind_str, port, sizeof(bind_str) - 1);
 	} else
-		strcpy(bind_str, bind_sock);
+		strncpy(bind_str, bind_sock, sizeof(bind_str) - 1);
 
 	log_info("fio: server listening on %s\n", bind_str);