[PATCH] mmap io engine had broken sync
It returned from ->queue() too quickly, it still needs to set the
last event handler.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
diff --git a/engines/fio-engine-mmap.c b/engines/fio-engine-mmap.c
index c85f661..483a704 100644
--- a/engines/fio-engine-mmap.c
+++ b/engines/fio-engine-mmap.c
@@ -50,13 +50,15 @@
memcpy(io_u->buf, f->mmap + real_off, io_u->buflen);
else if (io_u->ddir == DDIR_WRITE)
memcpy(f->mmap + real_off, io_u->buf, io_u->buflen);
- else if (io_u->ddir == DDIR_SYNC)
- return msync(f->mmap, f->file_size, MS_SYNC);
+ else if (io_u->ddir == DDIR_SYNC) {
+ if (msync(f->mmap, f->file_size, MS_SYNC))
+ io_u->error = errno;
+ }
/*
* not really direct, but should drop the pages from the cache
*/
- if (td->odirect) {
+ if (td->odirect && io_u->ddir != DDIR_SYNC) {
if (msync(f->mmap + real_off, io_u->buflen, MS_SYNC) < 0)
io_u->error = errno;
if (madvise(f->mmap + real_off, io_u->buflen, MADV_DONTNEED) < 0)