Gitiles
Code Review Sign In
gerrit-public.fairphone.software / fp2-dev / platform / external / fio / f9633d729f0d2067c3f79b5e82e7129de1e650cd
commitf9633d729f0d2067c3f79b5e82e7129de1e650cd[log] [tgz]
authorJens Axboe <axboe@kernel.dk>Fri Sep 06 09:59:56 2013 -0600
committerJens Axboe <axboe@kernel.dk>Fri Sep 06 09:59:56 2013 -0600
tree6768aea66d85f668cf4743d01fb68f0265285e5b
parenta3c86fc452d1c5e6ec78c6c2617540c34b7d9035 [diff]
Fix problem with --showcmd and callbacks that verify

David reports:

I'm using "fio --showcmd file.job" to convert a script to plain
commandline arguments and this fails if the directory specified in job
file does not exist. While this has to be an error if the job is being
executed, it should not be in context of --showcmd.

To reproduce:
$ cat job.fio
[global]
directory=/x

$ fio --showcmd job.fio
fio: /x is not a directory
fio: failed parsing directory=/x
fio: job global dropped

Expected output:
fio --directory=/x

Signed-off-by: Jens Axboe <axboe@kernel.dk>
3 files changed
tree: 6768aea66d85f668cf4743d01fb68f0265285e5b
  1. arch/
  2. compiler/
  3. crc/
  4. engines/
  5. examples/
  6. lib/
  7. os/
  8. profiles/
  9. t/
  10. tools/
  11. .gitignore
  12. backend.c
  13. blktrace.c
  14. blktrace_api.h
  15. cairo_text_helpers.c
  16. cairo_text_helpers.h
  17. cconv.c
  18. cgroup.c
  19. cgroup.h
  20. client.c
  21. client.h
  22. configure
  23. COPYING
  24. debug.c
  25. debug.h
  26. diskutil.c
  27. diskutil.h
  28. eta.c
  29. fifo.c
  30. fifo.h
  31. file.h
  32. filehash.c
  33. filehash.h
  34. filesetup.c
  35. FIO-VERSION-GEN
  36. fio.1
  37. fio.c
  38. fio.h
  39. flist.h
  40. flow.c
  41. flow.h
  42. gclient.c
  43. gclient.h
  44. gcompat.c
  45. gcompat.h
  46. gerror.c
  47. gerror.h
  48. gettime-thread.c
  49. gettime.c
  50. gettime.h
  51. GFIO-TODO
  52. gfio.c
  53. gfio.h
  54. ghelpers.c
  55. ghelpers.h
  56. goptions.c
  57. goptions.h
  58. graph.c
  59. graph.h
  60. hash.h
  61. helpers.c
  62. helpers.h
  63. HOWTO
  64. idletime.c
  65. idletime.h
  66. init.c
  67. io_ddir.h
  68. io_u.c
  69. io_u_queue.c
  70. io_u_queue.h
  71. ioengine.h
  72. ioengines.c
  73. iolog.c
  74. iolog.h
  75. json.c
  76. json.h
  77. libfio.c
  78. LICENSE
  79. log.c
  80. log.h
  81. Makefile
  82. memalign.c
  83. memalign.h
  84. memory.c
  85. minmax.h
  86. mutex.c
  87. mutex.h
  88. options.c
  89. options.h
  90. parse.c
  91. parse.h
  92. printing.c
  93. printing.h
  94. profile.c
  95. profile.h
  96. README
  97. REPORTING-BUGS
  98. SERVER-TODO
  99. server.c
  100. server.h
  101. smalloc.c
  102. smalloc.h
  103. stat.c
  104. stat.h
  105. td_error.c
  106. td_error.h
  107. thread_options.h
  108. tickmarks.c
  109. tickmarks.h
  110. time.c
  111. time.h
  112. trim.c
  113. trim.h
  114. verify.c
  115. verify.h