commit 0ece52676ccd90f23ad42b72788e4b439a43b31b
author Sean Callanan <scallanan@apple.com> Thu Feb 10 22:17:53 2011 +0000
committer Sean Callanan <scallanan@apple.com> Thu Feb 10 22:17:53 2011 +0000
tree 7fdf75eb326006f4c4c37c457e1e499f5e087e0e
parent c3a38ead9d30e0cab7d0051008bca3b1f4c95714

Fixes for two bugs:

- Objective-C constant strings were being
  NULL-terminated erroneously.

- Empty Objective-C constant strings were not
  being generated correctly.

Also added the template for a test of these
fixes.


git-svn-id: https://llvm.org/svn/llvm-project/llvdb/trunk@125314 91177308-0d34-0410-b5e6-96231b3b80d8

source/Expression/IRForTarget.cpp

diff --git a/source/Expression/IRForTarget.cpp b/source/Expression/IRForTarget.cpp
index 4601a3f..f9ea7e1 100644
--- a/source/Expression/IRForTarget.cpp
+++ b/source/Expression/IRForTarget.cpp
@@ -478,13 +478,18 @@
         m_CFStringCreateWithBytes = ConstantExpr::getIntToPtr(CFSCWB_addr_int, CFSCWB_ptr_ty);
     }
     
-    ConstantArray *string_array = dyn_cast<ConstantArray>(cstr->getInitializer());
+    ConstantArray *string_array;
+    
+    if (cstr)
+        string_array = dyn_cast<ConstantArray>(cstr->getInitializer());
+    else
+        string_array = NULL;
                         
     SmallVector <Value*, 5> CFSCWB_arguments;
     
     Constant *alloc_arg         = Constant::getNullValue(i8_ptr_ty);
-    Constant *bytes_arg         = ConstantExpr::getBitCast(cstr, i8_ptr_ty);
-    Constant *numBytes_arg      = ConstantInt::get(intptr_ty, string_array->getType()->getNumElements(), false);
+    Constant *bytes_arg         = cstr ? ConstantExpr::getBitCast(cstr, i8_ptr_ty) : Constant::getNullValue(i8_ptr_ty);
+    Constant *numBytes_arg      = ConstantInt::get(intptr_ty, cstr ? string_array->getType()->getNumElements() - 1 : 0, false);
     Constant *encoding_arg      = ConstantInt::get(i32_ty, 0x0600, false); /* 0x0600 is kCFStringEncodingASCII */
     Constant *isExternal_arg    = ConstantInt::get(i8_ty, 0x0, false); /* 0x0 is false */
     
@@ -664,9 +669,8 @@
                 
                 return false;
             }
-            
-            ConstantArray *cstr_array = dyn_cast<ConstantArray>(cstr_global->getInitializer());
-            
+                        
+            /*
             if (!cstr_array)
             {
                 if (log)
@@ -688,9 +692,20 @@
                 
                 return false;
             }
+            */
+            
+            ConstantArray *cstr_array = dyn_cast<ConstantArray>(cstr_global->getInitializer());
             
             if (log)
-                log->Printf("Found NSString constant %s, which contains \"%s\"", vi->first(), cstr_array->getAsString().c_str());
+            {
+                if (cstr_array)
+                    log->Printf("Found NSString constant %s, which contains \"%s\"", vi->first(), cstr_array->getAsString().c_str());
+                else
+                    log->Printf("Found NSString constant %s, which contains \"\"", vi->first());
+            }
+            
+            if (!cstr_array)
+                cstr_global = NULL;
             
             if (!RewriteObjCConstString(llvm_module, nsstring_global, cstr_global, FirstEntryInstruction))
             {