commit 21f2e192079b6aa9ddd2d25283e19abdb38eeeb5
author Sean Callanan <scallanan@apple.com> Wed Dec 14 01:13:04 2011 +0000
committer Sean Callanan <scallanan@apple.com> Wed Dec 14 01:13:04 2011 +0000
tree 1dbfe6d6443d3b9f6be194f0813070505612fe20
parent 9a1f001ebdc7745bfc5f4070b5fb6716e8a28856

This commit is the result of a general audit of
the expression parser to locate instances where
dyn_cast<>() and isa<>() are used on types, and
replace them with getAs<>() as appropriate.

The difference is that dyn_cast<>() and isa<>()
are essentially LLVM/Clang's equivalent of RTTI
-- that is, they try to downcast the object and
return NULL if they cannot -- but getAs<>() can
traverse typedefs to perform a semantic cast.


git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@146537 91177308-0d34-0410-b5e6-96231b3b80d8

source/Expression/ClangASTSource.cpp

diff --git a/source/Expression/ClangASTSource.cpp b/source/Expression/ClangASTSource.cpp
index 9831070..1f84185 100644
--- a/source/Expression/ClangASTSource.cpp
+++ b/source/Expression/ClangASTSource.cpp
@@ -220,7 +220,7 @@
                     if (!opaque_type)
                         continue;
                     
-                    const TagType *tag_type = dyn_cast<TagType>(QualType::getFromOpaquePtr(opaque_type).getTypePtr());
+                    const TagType *tag_type = QualType::getFromOpaquePtr(opaque_type)->getAs<TagType>();
                     
                     if (!tag_type)
                         continue;
@@ -258,7 +258,7 @@
                 if (!opaque_type)
                     continue;
                 
-                const TagType *tag_type = dyn_cast<TagType>(QualType::getFromOpaquePtr(opaque_type).getTypePtr());
+                const TagType *tag_type = QualType::getFromOpaquePtr(opaque_type)->getAs<TagType>();
                 
                 if (!tag_type)
                     continue;
@@ -677,7 +677,7 @@
             
             QualType backing_qual_type = QualType::getFromOpaquePtr(backing_type);
             
-            const ObjCInterfaceType *backing_interface_type = dyn_cast<ObjCInterfaceType>(backing_qual_type.getTypePtr());
+            const ObjCInterfaceType *backing_interface_type = backing_qual_type.getTypePtr()->getAs<ObjCInterfaceType>();
             
             if (!backing_interface_type)
                 continue;
@@ -1067,7 +1067,7 @@
     // this, we raid the function's FunctionProtoType for types.
     
     QualType qual_type (QualType::getFromOpaquePtr(type));
-    const FunctionProtoType *func_proto_type = dyn_cast<FunctionProtoType>(qual_type.getTypePtr());
+    const FunctionProtoType *func_proto_type = qual_type.getTypePtr()->getAs<FunctionProtoType>();
     
     if (func_proto_type)
     {        
@@ -1128,7 +1128,7 @@
     {
         QualType qual_type = QualType::getFromOpaquePtr(type);
 
-        if (const TagType *tag_type = dyn_cast<clang::TagType>(qual_type))
+        if (const TagType *tag_type = qual_type->getAs<TagType>())
         {
             TagDecl *tag_decl = tag_type->getDecl();
             
@@ -1136,7 +1136,7 @@
             
             return tag_decl;
         }
-        else if (const ObjCObjectType *objc_object_type = dyn_cast<clang::ObjCObjectType>(qual_type))
+        else if (const ObjCObjectType *objc_object_type = qual_type->getAs<ObjCObjectType>())
         {
             ObjCInterfaceDecl *interface_decl = objc_object_type->getInterface();