commit 3508c387c3f0c9ecc439d98048fd7694d41bab1b
author Greg Clayton <gclayton@apple.com> Fri Feb 24 01:59:29 2012 +0000
committer Greg Clayton <gclayton@apple.com> Fri Feb 24 01:59:29 2012 +0000
tree f4decd99a78aa0fe7aa828b055bc84bd1238a1b1
parent e350394e5b4bd5c32f70951a035a889bfd0194e4

<rdar://problem/10103468>

I started work on being able to add symbol files after a debug session
had started with a new "target symfile add" command and quickly ran into
problems with stale Address objects in breakpoint locations that had 
lldb_private::Section pointers into modules that had been removed or 
replaced. This also let to grabbing stale modules from those sections. 
So I needed to thread harded the Address, Section and related objects.

To do this I modified the ModuleChild class to now require a ModuleSP
on initialization so that a weak reference can created. I also changed
all places that were handing out "Section *" to have them hand out SectionSP.
All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild
so all of the find plug-in, static creation function and constructors now
require ModuleSP references instead of Module *. 

Address objects now have weak references to their sections which can
safely go stale when a module gets destructed. 

This checkin doesn't complete the "target symfile add" command, but it
does get us a lot clioser to being able to do such things without a high
risk of crashing or memory corruption.




git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@151336 91177308-0d34-0410-b5e6-96231b3b80d8

source/API/SBAddress.cpp

diff --git a/source/API/SBAddress.cpp b/source/API/SBAddress.cpp
index 7d7d1d7..a2e5d06 100644
--- a/source/API/SBAddress.cpp
+++ b/source/API/SBAddress.cpp
@@ -32,7 +32,7 @@
         }
 
         AddressImpl (const Address &addr) :
-            m_module_sp (addr.GetModuleSP()),
+            m_module_sp (addr.GetModule()),
             m_address (addr)
         {
         }
@@ -105,7 +105,7 @@
 
 
 SBAddress::SBAddress (lldb::SBSection section, lldb::addr_t offset) :
-    m_opaque_ap(new AddressImpl (Address(section.GetSection(), offset)))
+    m_opaque_ap(new AddressImpl (Address(section.GetSP(), offset)))
 {
 }
 
@@ -151,7 +151,7 @@
 SBAddress::SetAddress (lldb::SBSection section, lldb::addr_t offset)
 {
     Address &addr = ref();
-    addr.SetSection (section.GetSection());
+    addr.SetSection (section.GetSP());
     addr.SetOffset (offset);
 }
 
@@ -241,7 +241,7 @@
 {
     lldb::SBSection sb_section;
     if (m_opaque_ap.get())
-        sb_section.SetSection(m_opaque_ap->GetAddress().GetSection());
+        sb_section.SetSP (m_opaque_ap->GetAddress().GetSection());
     return sb_section;
 }