<rdar://problem/10103468>
I started work on being able to add symbol files after a debug session
had started with a new "target symfile add" command and quickly ran into
problems with stale Address objects in breakpoint locations that had
lldb_private::Section pointers into modules that had been removed or
replaced. This also let to grabbing stale modules from those sections.
So I needed to thread harded the Address, Section and related objects.
To do this I modified the ModuleChild class to now require a ModuleSP
on initialization so that a weak reference can created. I also changed
all places that were handing out "Section *" to have them hand out SectionSP.
All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild
so all of the find plug-in, static creation function and constructors now
require ModuleSP references instead of Module *.
Address objects now have weak references to their sections which can
safely go stale when a module gets destructed.
This checkin doesn't complete the "target symfile add" command, but it
does get us a lot clioser to being able to do such things without a high
risk of crashing or memory corruption.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@151336 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/source/API/SBValue.cpp b/source/API/SBValue.cpp
index 9818eb3..fa2fa77 100644
--- a/source/API/SBValue.cpp
+++ b/source/API/SBValue.cpp
@@ -1221,13 +1221,13 @@
value = value_sp->GetAddressOf(scalar_is_load_address, &addr_type);
if (addr_type == eAddressTypeFile)
{
- Module* module = value_sp->GetModule();
- if (!module)
+ ModuleSP module_sp (value_sp->GetModule());
+ if (!module_sp)
value = LLDB_INVALID_ADDRESS;
else
{
Address addr;
- module->ResolveFileAddress(value, addr);
+ module_sp->ResolveFileAddress(value, addr);
value = addr.GetLoadAddress(target_sp.get());
}
}
@@ -1259,9 +1259,9 @@
value = value_sp->GetAddressOf(scalar_is_load_address, &addr_type);
if (addr_type == eAddressTypeFile)
{
- Module* module = value_sp->GetModule();
- if (module)
- module->ResolveFileAddress(value, addr);
+ ModuleSP module_sp (value_sp->GetModule());
+ if (module_sp)
+ module_sp->ResolveFileAddress(value, addr);
}
else if (addr_type == eAddressTypeLoad)
{