commit 61ba7ec20f616f907473dd501341cef5b47fa3f8
author Caroline Tice <ctice@apple.com> Tue Oct 26 23:49:36 2010 +0000
committer Caroline Tice <ctice@apple.com> Tue Oct 26 23:49:36 2010 +0000
tree 8cbfb029ec3c98825ba6fe0912c49cad3ac538a7
parent 0561f3da5dd365d1f75c0a6888293eaf1695ccd1

Clean up the API logging code:
      - Try to reduce logging to one line per function call instead of tw
      - Put all arguments & their values into log for calls
      - Add 'this' parameter information to function call logging, making it show the appropriate
        internal pointer (this.obj, this.sp, this.ap...)
      - Clean up some return values
      - Remove logging of constructors that construct empty objects
      - Change '==>' to '=>'  for showing result values...
      - Fix various minor bugs
      - Add some protected 'get' functions to help getting the internal pointers for the 'this' arguments...      



git-svn-id: https://llvm.org/svn/llvm-project/llvdb/trunk@117417 91177308-0d34-0410-b5e6-96231b3b80d8

source/API/SBError.cpp

diff --git a/source/API/SBError.cpp b/source/API/SBError.cpp
index 3e91ea0..2f33e7c 100644
--- a/source/API/SBError.cpp
+++ b/source/API/SBError.cpp
@@ -21,16 +21,12 @@
 SBError::SBError () :
     m_opaque_ap ()
 {
-    Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API | LIBLLDB_LOG_VERBOSE);
-
-    if (log)
-        log->Printf ("SBError::SBError () ==> this = %p", this);
 }
 
 SBError::SBError (const SBError &rhs) :
     m_opaque_ap ()
 {
-    Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API | LIBLLDB_LOG_VERBOSE);
+    Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API);
 
     if (rhs.IsValid())
         m_opaque_ap.reset (new Error(*rhs));
@@ -39,8 +35,8 @@
     {
         SBStream sstr;
         GetDescription (sstr);
-        log->Printf ("SBError::SBError (const SBError &rhs) rhs.m_opaque_ap.get() = %p ==> this = %p (%s)",
-                     (rhs.IsValid() ? rhs.m_opaque_ap.get() : NULL), this, sstr.GetData());
+        log->Printf ("SBError::SBError (const SBError rhs.ap=%p) => this.ap = %p (%s)",
+                     (rhs.IsValid() ? rhs.m_opaque_ap.get() : NULL), m_opaque_ap.get(), sstr.GetData());
     }
 }
 
@@ -54,14 +50,6 @@
 {
     Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API);
 
-    if (log)
-    {
-        SBStream sstr;
-        rhs.GetDescription (sstr);
-        log->Printf ("SBError::operator= (const SBError &rhs) rhs.m_opaque_ap.get() = %p (%s)", 
-                     (rhs.IsValid() ? rhs.m_opaque_ap.get() : NULL), sstr.GetData());
-    }
-
     if (rhs.IsValid())
     {
         if (m_opaque_ap.get())
@@ -75,7 +63,12 @@
     }
 
     if (log)
-        log->Printf ("SBError::operator= ==> this = %p", this);
+    {
+        SBStream sstr;
+        GetDescription (sstr);
+        log->Printf ("SBError::operator= (this.ap=%p, rhs.ap=%p) => this (%s)", 
+                     m_opaque_ap.get(), (rhs.IsValid() ? rhs.m_opaque_ap.get() : NULL), sstr.GetData());
+    }
 
     return *this;
 }
@@ -101,15 +94,15 @@
 {
     Log *log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API);
 
-    if (log)
-        log->Printf ("SBError::Fail ()");
+    //if (log)
+    //    log->Printf ("SBError::Fail ()");
 
     bool ret_value = false;
     if (m_opaque_ap.get())
         ret_value = m_opaque_ap->Fail();
 
     if (log)
-        log->Printf ("SBError::Fail ==> %s", (ret_value ? "true" : "false"));
+        log->Printf ("SBError::Fail (this.ap=%p) => '%s'", m_opaque_ap.get(), (ret_value ? "true" : "false"));
 
     return ret_value;
 }