Very large changes that were needed in order to allow multiple connections
to the debugger from GUI windows. Previously there was one global debugger
instance that could be accessed that had its own command interpreter and
current state (current target/process/thread/frame). When a GUI debugger
was attached, if it opened more than one window that each had a console
window, there were issues where the last one to setup the global debugger
object won and got control of the debugger.
To avoid this we now create instances of the lldb_private::Debugger that each
has its own state:
- target list for targets the debugger instance owns
- current process/thread/frame
- its own command interpreter
- its own input, output and error file handles to avoid conflicts
- its own input reader stack
So now clients should call:
SBDebugger::Initialize(); // (static function)
SBDebugger debugger (SBDebugger::Create());
// Use which ever file handles you wish
debugger.SetErrorFileHandle (stderr, false);
debugger.SetOutputFileHandle (stdout, false);
debugger.SetInputFileHandle (stdin, true);
// main loop
SBDebugger::Terminate(); // (static function)
SBDebugger::Initialize() and SBDebugger::Terminate() are ref counted to
ensure nothing gets destroyed too early when multiple clients might be
attached.
Cleaned up the command interpreter and the CommandObject and all subclasses
to take more appropriate arguments.
git-svn-id: https://llvm.org/svn/llvm-project/llvdb/trunk@106615 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/source/API/SBFileSpec.cpp b/source/API/SBFileSpec.cpp
index 48c7511..308e609 100644
--- a/source/API/SBFileSpec.cpp
+++ b/source/API/SBFileSpec.cpp
@@ -16,19 +16,19 @@
SBFileSpec::SBFileSpec () :
- m_lldb_object_ap()
+ m_opaque_ap()
{
}
SBFileSpec::SBFileSpec (const SBFileSpec &rhs) :
- m_lldb_object_ap()
+ m_opaque_ap()
{
- if (rhs.m_lldb_object_ap.get())
- m_lldb_object_ap.reset (new FileSpec (*m_lldb_object_ap));
+ if (rhs.m_opaque_ap.get())
+ m_opaque_ap.reset (new FileSpec (*m_opaque_ap));
}
SBFileSpec::SBFileSpec (const char *path) :
- m_lldb_object_ap(new FileSpec (path))
+ m_opaque_ap(new FileSpec (path))
{
}
@@ -42,7 +42,7 @@
if (this != &rhs)
{
if (rhs.IsValid())
- m_lldb_object_ap.reset (new lldb_private::FileSpec(*rhs.m_lldb_object_ap.get()));
+ m_opaque_ap.reset (new lldb_private::FileSpec(*rhs.m_opaque_ap.get()));
}
return *this;
}
@@ -50,14 +50,14 @@
bool
SBFileSpec::IsValid() const
{
- return m_lldb_object_ap.get() != NULL;
+ return m_opaque_ap.get() != NULL;
}
bool
SBFileSpec::Exists () const
{
- if (m_lldb_object_ap.get())
- return m_lldb_object_ap->Exists();
+ if (m_opaque_ap.get())
+ return m_opaque_ap->Exists();
return false;
}
@@ -71,24 +71,24 @@
const char *
SBFileSpec::GetFileName() const
{
- if (m_lldb_object_ap.get())
- return m_lldb_object_ap->GetFilename().AsCString();
+ if (m_opaque_ap.get())
+ return m_opaque_ap->GetFilename().AsCString();
return NULL;
}
const char *
SBFileSpec::GetDirectory() const
{
- if (m_lldb_object_ap.get())
- return m_lldb_object_ap->GetDirectory().AsCString();
+ if (m_opaque_ap.get())
+ return m_opaque_ap->GetDirectory().AsCString();
return NULL;
}
uint32_t
SBFileSpec::GetPath (char *dst_path, size_t dst_len) const
{
- if (m_lldb_object_ap.get())
- return m_lldb_object_ap->GetPath (dst_path, dst_len);
+ if (m_opaque_ap.get())
+ return m_opaque_ap->GetPath (dst_path, dst_len);
if (dst_path && dst_len)
*dst_path = '\0';
@@ -99,35 +99,35 @@
const lldb_private::FileSpec *
SBFileSpec::operator->() const
{
- return m_lldb_object_ap.get();
+ return m_opaque_ap.get();
}
const lldb_private::FileSpec *
SBFileSpec::get() const
{
- return m_lldb_object_ap.get();
+ return m_opaque_ap.get();
}
const lldb_private::FileSpec &
SBFileSpec::operator*() const
{
- return *m_lldb_object_ap.get();
+ return *m_opaque_ap.get();
}
const lldb_private::FileSpec &
SBFileSpec::ref() const
{
- return *m_lldb_object_ap.get();
+ return *m_opaque_ap.get();
}
void
SBFileSpec::SetFileSpec (const lldb_private::FileSpec& fs)
{
- if (m_lldb_object_ap.get())
- *m_lldb_object_ap = fs;
+ if (m_opaque_ap.get())
+ *m_opaque_ap = fs;
else
- m_lldb_object_ap.reset (new FileSpec (fs));
+ m_opaque_ap.reset (new FileSpec (fs));
}