Made many ConstString functions inlined in the header file.
Changed all of our synthesized "___clang" functions, types and variables
that get used in expressions over to have a prefix of "$_lldb". Now when we
do name lookups we can easily switch off of the first '$' character to know
if we should look through only our internal (when first char is '$') stuff,
or when we should look through program variables, functions and types.
Converted all of the clang expression code over to using "const ConstString&"
values for names instead of "const char *" since there were many places that
were converting the "const char *" names into ConstString names and them
throwing them away. We now avoid making a lot of ConstString conversions and
benefit from the quick comparisons in a few extra spots.
Converted a lot of code from LLVM coding conventions into LLDB coding
conventions.
git-svn-id: https://llvm.org/svn/llvm-project/llvdb/trunk@116634 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/source/Expression/ClangPersistentVariables.cpp b/source/Expression/ClangPersistentVariables.cpp
index 49674a9..4919922 100644
--- a/source/Expression/ClangPersistentVariables.cpp
+++ b/source/Expression/ClangPersistentVariables.cpp
@@ -22,19 +22,16 @@
}
void
-ClangPersistentVariables::GetNextResultName (std::string &name)
+ClangPersistentVariables::GetNextResultName (ConstString &name)
{
- StreamString s;
- s.Printf("$%llu", m_result_counter);
-
- m_result_counter++;
-
- name = s.GetString();
+ char result_name[256];
+ ::snprintf (result_name, sizeof(result_name), "$%llu", m_result_counter++);
+ name.SetCString(result_name);
}
bool
-ClangPersistentVariables::CreatePersistentVariable(const char *name,
- TypeFromUser user_type)
+ClangPersistentVariables::CreatePersistentVariable (const ConstString &name,
+ TypeFromUser user_type)
{
if (GetVariable(name))
return false;