rdar://problem/10998562
lldb crashes under guard malloc

Fix CommandObjectSettingsAppend::ExecuteRawCommandString() so that it does not perform the cmd_args.Shift()
operation after it has got the var_name out of the raw string, since StringRef is manipulating the raw
string later on.


git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@152194 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/source/Commands/CommandObjectSettings.cpp b/source/Commands/CommandObjectSettings.cpp
index 74fdd50..544b43b 100644
--- a/source/Commands/CommandObjectSettings.cpp
+++ b/source/Commands/CommandObjectSettings.cpp
@@ -1143,7 +1143,8 @@
     }
 
     var_name_string = var_name;
-    cmd_args.Shift();
+    // Do not perform cmd_args.Shift() since StringRef is manipulating the
+    // raw character string later on.
 
     // Split the raw command into var_name and value pair.
     llvm::StringRef raw_str(raw_command);