Fix a minor bug where we would go into infinite loops on some constants
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@14638 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp
index fad2730..be1111f 100644
--- a/lib/Transforms/Scalar/InstructionCombining.cpp
+++ b/lib/Transforms/Scalar/InstructionCombining.cpp
@@ -846,7 +846,8 @@
Instruction *InstCombiner::visitRem(BinaryOperator &I) {
if (I.getType()->isSigned())
if (Value *RHSNeg = dyn_castNegVal(I.getOperand(1)))
- if (RHSNeg != I.getOperand(1)) { // Avoid problems with MININT
+ if (!isa<ConstantSInt>(RHSNeg) ||
+ cast<ConstantSInt>(RHSNeg)->getValue() >= 0) {
// X % -Y -> X % Y
AddUsesToWorkList(I);
I.setOperand(1, RHSNeg);