commit 1edf6ca2cbb4b01db44683d5e9479a240cfcf497
author Daniel Dunbar <daniel@zuster.org> Sun Jul 18 22:22:07 2010 +0000
committer Daniel Dunbar <daniel@zuster.org> Sun Jul 18 22:22:07 2010 +0000
tree 25d232634f4b787fd9da793a340251cbaec0ef81
parent 030794bd87d731d736da59681afdb7694131c9f2

MC/AsmParser: Stop playing unsafe member function pointer calls, this isn't
portable enough.
 - Downside is we now double dispatch through a stub function, but this isn't
   performance critical.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@108661 91177308-0d34-0410-b5e6-96231b3b80d8

lib/MC/MCParser/AsmParser.cpp

diff --git a/lib/MC/MCParser/AsmParser.cpp b/lib/MC/MCParser/AsmParser.cpp
index 1e8f05f..66f46a8 100644
--- a/lib/MC/MCParser/AsmParser.cpp
+++ b/lib/MC/MCParser/AsmParser.cpp
@@ -202,6 +202,12 @@
 /// \brief Generic implementations of directive handling, etc. which is shared
 /// (or the default, at least) for all assembler parser.
 class GenericAsmParser : public MCAsmParserExtension {
+  template<bool (GenericAsmParser::*Handler)(StringRef, SMLoc)>
+  void AddDirectiveHandler(StringRef Directive) {
+    getParser().AddDirectiveHandler(this, Directive,
+                                    HandleDirective<GenericAsmParser, Handler>);
+  }
+
 public:
   GenericAsmParser() {}
 
@@ -214,26 +220,18 @@
     this->MCAsmParserExtension::Initialize(Parser);
 
     // Debugging directives.
-    Parser.AddDirectiveHandler(this, ".file", MCAsmParser::DirectiveHandler(
-                                 &GenericAsmParser::ParseDirectiveFile));
-    Parser.AddDirectiveHandler(this, ".line", MCAsmParser::DirectiveHandler(
-                                 &GenericAsmParser::ParseDirectiveLine));
-    Parser.AddDirectiveHandler(this, ".loc", MCAsmParser::DirectiveHandler(
-                                 &GenericAsmParser::ParseDirectiveLoc));
+    AddDirectiveHandler<&GenericAsmParser::ParseDirectiveFile>(".file");
+    AddDirectiveHandler<&GenericAsmParser::ParseDirectiveLine>(".line");
+    AddDirectiveHandler<&GenericAsmParser::ParseDirectiveLoc>(".loc");
 
     // Macro directives.
-    Parser.AddDirectiveHandler(this, ".macros_on",
-                               MCAsmParser::DirectiveHandler(
-                                 &GenericAsmParser::ParseDirectiveMacrosOnOff));
-    Parser.AddDirectiveHandler(this, ".macros_off",
-                               MCAsmParser::DirectiveHandler(
-                                 &GenericAsmParser::ParseDirectiveMacrosOnOff));
-    Parser.AddDirectiveHandler(this, ".macro", MCAsmParser::DirectiveHandler(
-                                 &GenericAsmParser::ParseDirectiveMacro));
-    Parser.AddDirectiveHandler(this, ".endm", MCAsmParser::DirectiveHandler(
-                                 &GenericAsmParser::ParseDirectiveEndMacro));
-    Parser.AddDirectiveHandler(this, ".endmacro", MCAsmParser::DirectiveHandler(
-                                 &GenericAsmParser::ParseDirectiveEndMacro));
+    AddDirectiveHandler<&GenericAsmParser::ParseDirectiveMacrosOnOff>(
+      ".macros_on");
+    AddDirectiveHandler<&GenericAsmParser::ParseDirectiveMacrosOnOff>(
+      ".macros_off");
+    AddDirectiveHandler<&GenericAsmParser::ParseDirectiveMacro>(".macro");
+    AddDirectiveHandler<&GenericAsmParser::ParseDirectiveEndMacro>(".endm");
+    AddDirectiveHandler<&GenericAsmParser::ParseDirectiveEndMacro>(".endmacro");
   }
 
   bool ParseDirectiveFile(StringRef, SMLoc DirectiveLoc);
@@ -875,7 +873,7 @@
     std::pair<MCAsmParserExtension*, DirectiveHandler> Handler =
       DirectiveMap.lookup(IDVal);
     if (Handler.first)
-      return (Handler.first->*Handler.second)(IDVal, IDLoc);
+      return (*Handler.second)(Handler.first, IDVal, IDLoc);
 
     // Target hook for parsing target specific directives.
     if (!getTargetParser().ParseDirective(ID))