commit 2f5eb4e9a55b06cec0516a2e6a371afd46f0fd12
author Chris Lattner <sabre@nondot.org> Thu May 09 03:56:52 2002 +0000
committer Chris Lattner <sabre@nondot.org> Thu May 09 03:56:52 2002 +0000
tree 1e8c880afedafed2533d170cc0c8239ac7d5c089
parent 4440826cae4b22e98105b2e9f69e864e23e3d390

* Remove dead function
* Print C strings correctly
* Expand C escape sequences nicely (ie \n \t, etc get generated instead of hex escapes)


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@2572 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/CBackend/CBackend.cpp

diff --git a/lib/Target/CBackend/CBackend.cpp b/lib/Target/CBackend/CBackend.cpp
index bb5f75d..630abec 100644
--- a/lib/Target/CBackend/CBackend.cpp
+++ b/lib/Target/CBackend/CBackend.cpp
@@ -72,11 +72,6 @@
   return tmp;
 }
 
-static string getConstantName(const Constant *CPV) {
-  return CPV->getName();
-}
-
-
 static std::string getConstArrayStrValue(const Constant* CPV) {
   std::string Result;
   
@@ -94,10 +89,17 @@
         break;
       }
   }
+  if (isString) {
+    // Make sure the last character is a null char, as automatically added by C
+    if (CPV->getNumOperands() == 0 ||
+        !cast<Constant>(*(CPV->op_end()-1))->isNullValue())
+      isString = false;
+  }
   
   if (isString) {
     Result = "\"";
-    for (unsigned i = 0; i < CPV->getNumOperands(); ++i) {
+    // Do not include the last character, which we know is null
+    for (unsigned i = 0, e = CPV->getNumOperands()-1; i != e; ++i) {
       unsigned char C = (ETy == Type::SByteTy) ?
         (unsigned char)cast<ConstantSInt>(CPV->getOperand(i))->getValue() :
         (unsigned char)cast<ConstantUInt>(CPV->getOperand(i))->getValue();
@@ -105,9 +107,18 @@
       if (isprint(C)) {
         Result += C;
       } else {
-        Result += "\\x";
-        Result += ( C/16  < 10) ? ( C/16 +'0') : ( C/16 -10+'A');
-        Result += ((C&15) < 10) ? ((C&15)+'0') : ((C&15)-10+'A');
+        switch (C) {
+        case '\n': Result += "\\n"; break;
+        case '\t': Result += "\\t"; break;
+        case '\r': Result += "\\r"; break;
+        case '\v': Result += "\\v"; break;
+        case '\a': Result += "\\a"; break;
+        default:
+          Result += "\\x";
+          Result += ( C/16  < 10) ? ( C/16 +'0') : ( C/16 -10+'A');
+          Result += ((C&15) < 10) ? ((C&15)+'0') : ((C&15)-10+'A');
+          break;
+        }
       }
     }
     Result += "\"";

lib/Target/CBackend/Writer.cpp

diff --git a/lib/Target/CBackend/Writer.cpp b/lib/Target/CBackend/Writer.cpp
index bb5f75d..630abec 100644
--- a/lib/Target/CBackend/Writer.cpp
+++ b/lib/Target/CBackend/Writer.cpp
@@ -72,11 +72,6 @@
   return tmp;
 }
 
-static string getConstantName(const Constant *CPV) {
-  return CPV->getName();
-}
-
-
 static std::string getConstArrayStrValue(const Constant* CPV) {
   std::string Result;
   
@@ -94,10 +89,17 @@
         break;
       }
   }
+  if (isString) {
+    // Make sure the last character is a null char, as automatically added by C
+    if (CPV->getNumOperands() == 0 ||
+        !cast<Constant>(*(CPV->op_end()-1))->isNullValue())
+      isString = false;
+  }
   
   if (isString) {
     Result = "\"";
-    for (unsigned i = 0; i < CPV->getNumOperands(); ++i) {
+    // Do not include the last character, which we know is null
+    for (unsigned i = 0, e = CPV->getNumOperands()-1; i != e; ++i) {
       unsigned char C = (ETy == Type::SByteTy) ?
         (unsigned char)cast<ConstantSInt>(CPV->getOperand(i))->getValue() :
         (unsigned char)cast<ConstantUInt>(CPV->getOperand(i))->getValue();
@@ -105,9 +107,18 @@
       if (isprint(C)) {
         Result += C;
       } else {
-        Result += "\\x";
-        Result += ( C/16  < 10) ? ( C/16 +'0') : ( C/16 -10+'A');
-        Result += ((C&15) < 10) ? ((C&15)+'0') : ((C&15)-10+'A');
+        switch (C) {
+        case '\n': Result += "\\n"; break;
+        case '\t': Result += "\\t"; break;
+        case '\r': Result += "\\r"; break;
+        case '\v': Result += "\\v"; break;
+        case '\a': Result += "\\a"; break;
+        default:
+          Result += "\\x";
+          Result += ( C/16  < 10) ? ( C/16 +'0') : ( C/16 -10+'A');
+          Result += ((C&15) < 10) ? ((C&15)+'0') : ((C&15)-10+'A');
+          break;
+        }
       }
     }
     Result += "\"";