Don't convert object_error's enum to and from int.
This allows the compiler to see the enum and warn about it. While in here,
fix a switch to not use a default and fix style violations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@184186 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Object/Error.cpp b/lib/Object/Error.cpp
index 2594625..7005a72 100644
--- a/lib/Object/Error.cpp
+++ b/lib/Object/Error.cpp
@@ -31,7 +31,8 @@
}
std::string _object_error_category::message(int ev) const {
- switch (ev) {
+ object_error::Impl E = static_cast<object_error::Impl>(ev);
+ switch (E) {
case object_error::success: return "Success";
case object_error::invalid_file_type:
return "The file was not recognized as a valid object file";
@@ -39,10 +40,9 @@
return "Invalid data was encountered while parsing the file";
case object_error::unexpected_eof:
return "The end of the file was unexpectedly encountered";
- default:
- llvm_unreachable("An enumerator of object_error does not have a message "
- "defined.");
}
+ llvm_unreachable("An enumerator of object_error does not have a message "
+ "defined.");
}
error_condition _object_error_category::default_error_condition(int ev) const {