fix a fixme by sinking various target-specific directives down into
the appropriate subclasses.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@77815 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Target/TargetLoweringObjectFile.cpp b/lib/Target/TargetLoweringObjectFile.cpp
index a26bec2..8424779 100644
--- a/lib/Target/TargetLoweringObjectFile.cpp
+++ b/lib/Target/TargetLoweringObjectFile.cpp
@@ -32,11 +32,8 @@
TargetLoweringObjectFile::TargetLoweringObjectFile() : Ctx(0) {
TextSection = 0;
DataSection = 0;
- BSSSection_ = 0;
+ BSSSection = 0;
ReadOnlySection = 0;
- TLSDataSection = 0;
- TLSBSSSection = 0;
- CStringSection_ = 0;
}
TargetLoweringObjectFile::~TargetLoweringObjectFile() {
@@ -222,8 +219,8 @@
if (Kind.isText())
return getTextSection();
- if (Kind.isBSS() && BSSSection_ != 0)
- return BSSSection_;
+ if (Kind.isBSS() && BSSSection != 0)
+ return BSSSection;
if (Kind.isReadOnly() && ReadOnlySection != 0)
return ReadOnlySection;
@@ -261,16 +258,16 @@
const TargetMachine &TM) {
TargetLoweringObjectFile::Initialize(Ctx, TM);
if (!HasCrazyBSS)
- BSSSection_ = getOrCreateSection("\t.bss", true,
- SectionKind::get(SectionKind::BSS));
+ BSSSection = getOrCreateSection("\t.bss", true,
+ SectionKind::get(SectionKind::BSS));
else
// PPC/Linux doesn't support the .bss directive, it needs .section .bss.
// FIXME: Does .section .bss work everywhere??
// FIXME2: this should just be handle by the section printer. We should get
// away from syntactic view of the sections and MCSection should just be a
// semantic view.
- BSSSection_ = getOrCreateSection("\t.bss", false,
- SectionKind::get(SectionKind::BSS));
+ BSSSection = getOrCreateSection("\t.bss", false,
+ SectionKind::get(SectionKind::BSS));
TextSection = getOrCreateSection("\t.text", true,
@@ -283,7 +280,7 @@
TLSDataSection =
getOrCreateSection("\t.tdata", false,
SectionKind::get(SectionKind::ThreadData));
- CStringSection_ = getOrCreateSection("\t.rodata.str", true,
+ CStringSection = getOrCreateSection("\t.rodata.str", true,
SectionKind::get(SectionKind::MergeableCString));
TLSBSSSection = getOrCreateSection("\t.tbss", false,
@@ -423,7 +420,7 @@
if (Kind.isText()) return TextSection;
if (Kind.isMergeableCString()) {
- assert(CStringSection_ && "Should have string section prefix");
+ assert(CStringSection && "Should have string section prefix");
// We also need alignment here.
// FIXME: this is getting the alignment of the character, not the
@@ -431,7 +428,7 @@
unsigned Align =
TM.getTargetData()->getPreferredAlignment(cast<GlobalVariable>(GV));
- std::string Name = CStringSection_->getName() + "1." + utostr(Align);
+ std::string Name = CStringSection->getName() + "1." + utostr(Align);
return getOrCreateSection(Name.c_str(), false,
SectionKind::get(SectionKind::MergeableCString));
}
@@ -451,7 +448,7 @@
if (Kind.isThreadData()) return TLSDataSection;
if (Kind.isThreadBSS()) return TLSBSSSection;
- if (Kind.isBSS()) return BSSSection_;
+ if (Kind.isBSS()) return BSSSection;
if (Kind.isDataNoRel()) return DataSection;
if (Kind.isDataRelLocal()) return DataRelLocalSection;
@@ -493,7 +490,7 @@
DataSection = getOrCreateSection("\t.data", true,
SectionKind::get(SectionKind::DataRel));
- CStringSection_ = getOrCreateSection("\t.cstring", true,
+ CStringSection = getOrCreateSection("\t.cstring", true,
SectionKind::get(SectionKind::MergeableCString));
FourByteConstantSection = getOrCreateSection("\t.literal4\n", true,
SectionKind::get(SectionKind::MergeableConst4));
@@ -554,7 +551,7 @@
if (Size) {
unsigned Align = TD.getPreferredAlignment(cast<GlobalVariable>(GV));
if (Align <= 32)
- return CStringSection_;
+ return CStringSection;
}
return ReadOnlySection;