The new bytecode format supports emitting strings a special case. This is
intended to save size (and does on small programs), but on big programs it
actually increases the size of the program slightly. The deal is that many
functions end up using the characters that the string contained, and the
characters are no longer in the global constant table, so they have to be
emitted in function specific constant pools.
This pessimization will be fixed in subsequent patches.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@10864 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Bytecode/Writer/WriterInternals.h b/lib/Bytecode/Writer/WriterInternals.h
index 9fb778d..51ec362 100644
--- a/lib/Bytecode/Writer/WriterInternals.h
+++ b/lib/Bytecode/Writer/WriterInternals.h
@@ -33,22 +33,17 @@
public:
BytecodeWriter(std::deque<unsigned char> &o, const Module *M);
-protected:
+private:
void outputConstants(bool isFunction);
+ void outputConstantStrings();
void outputFunction(const Function *F);
void processInstruction(const Instruction &I);
-private :
- inline void outputSignature() {
- static const unsigned char *Sig = (const unsigned char*)"llvm";
- Out.insert(Out.end(), Sig, Sig+4); // output the bytecode signature...
- }
-
void outputModuleInfoBlock(const Module *C);
void outputSymbolTable(const SymbolTable &ST);
void outputConstantsInPlane(const std::vector<const Value*> &Plane,
unsigned StartNo);
- bool outputConstant(const Constant *CPV);
+ void outputConstant(const Constant *CPV);
void outputType(const Type *T);
};