This simplifies the CWriter code, makes the generated code easier to read,
and makes the output work with the intel compiler. Overall, a win.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@9671 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Target/CBackend/Writer.cpp b/lib/Target/CBackend/Writer.cpp
index d778d1e..e32987c 100644
--- a/lib/Target/CBackend/Writer.cpp
+++ b/lib/Target/CBackend/Writer.cpp
@@ -163,11 +163,6 @@
};
}
-// A pointer type should not use parens around *'s alone, e.g., (**)
-inline bool ptrTypeNameNeedsParens(const std::string &NameSoFar) {
- return NameSoFar.find_last_not_of('*') != std::string::npos;
-}
-
// Pass the Type* and the variable name and this prints out the variable
// declaration.
//
@@ -240,12 +235,8 @@
const PointerType *PTy = cast<PointerType>(Ty);
std::string ptrName = "*" + NameSoFar;
- // Do not need parens around "* NameSoFar" if NameSoFar consists only
- // of zero or more '*' chars *and* this is not an unnamed pointer type
- // such as the result type in a cast statement. Otherwise, enclose in ( ).
- if (ptrTypeNameNeedsParens(NameSoFar) ||
- PTy->getElementType()->getPrimitiveID() == Type::ArrayTyID)
- ptrName = "(" + ptrName + ")"; //
+ if (isa<ArrayType>(PTy->getElementType()))
+ ptrName = "(" + ptrName + ")";
return printType(Out, PTy->getElementType(), ptrName);
}