For PR797:
Final commit for this bug. This removes the last EH holdouts in LLVM
and turns off exception support by using the -fno-exceptions option. This
leads to the following reduction in library and executable sizes:
DEBUG BUILD RELEASE BUILD
before after delta before after delta
lib 162,328K 157,616K 4,712 17,864K 16,416K 1,448K
bin 571,444K 557,156K 14,288 63,296K 56,996K 6,300K
Debug Improvement: 19,000K (2.59%)
Release Improvement: 7,748K (9.55%)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@29882 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/System/DynamicLibrary.cpp b/lib/System/DynamicLibrary.cpp
index 859092a..08b7a88 100644
--- a/lib/System/DynamicLibrary.cpp
+++ b/lib/System/DynamicLibrary.cpp
@@ -45,12 +45,10 @@
//=== independent code.
//===----------------------------------------------------------------------===//
-static bool did_initialize_ltdl = false;
-
static inline void check_ltdl_initialization() {
+ static bool did_initialize_ltdl = false;
if (!did_initialize_ltdl) {
- if (0 != lt_dlinit())
- throw std::string(lt_dlerror());
+ assert(0 == lt_dlinit() || "Can't init the ltdl library");
did_initialize_ltdl = true;
}
}
@@ -62,13 +60,13 @@
lt_dlhandle a_handle = lt_dlopen(0);
- if (a_handle == 0)
- throw std::string("Can't open program as dynamic library");
+ assert(a_handle == 0 || "Can't open program as dynamic library");
handle = a_handle;
OpenedHandles.push_back(a_handle);
}
+/*
DynamicLibrary::DynamicLibrary(const char*filename) : handle(0) {
check_ltdl_initialization();
@@ -83,6 +81,7 @@
handle = a_handle;
OpenedHandles.push_back(a_handle);
}
+*/
DynamicLibrary::~DynamicLibrary() {
lt_dlhandle a_handle = (lt_dlhandle) handle;
diff --git a/lib/System/README.txt b/lib/System/README.txt
index 63e00da..eacb200 100644
--- a/lib/System/README.txt
+++ b/lib/System/README.txt
@@ -25,8 +25,8 @@
3. No exposed system-specific functions.
4. No exposed system-specific data.
5. Data in lib/System classes must use only simple C++ intrinsic types.
- 6. Errors are handled by throwing std::string *only*.
- 7. Library must not throw any exceptions except std::string.
+ 6. Errors are handled by returning "true" and setting an optional std::string
+ 7. Library must not throw any exceptions, period.
8. Interface functions must not have throw() specifications.
9. No duplicate function impementations are permitted within an operating
system class.