Add a FIXME
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@34828 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Support/APInt.cpp b/lib/Support/APInt.cpp
index 36f88a2..5ab1644 100644
--- a/lib/Support/APInt.cpp
+++ b/lib/Support/APInt.cpp
@@ -1239,6 +1239,9 @@
}
// Make sure we return the closest approximation
+ // FIXME: This still has an off-by-one error in it. Test case:
+ // 190 bits: sqrt(694114394047834196220892040454508646882614255319893124270) =
+ // 26346050824513229049493703285 (not 26346050824513229049493703284)
APInt square(x_old * x_old);
APInt nextSquare((x_old + 1) * (x_old +1));
if (this->ult(square))