commit b080e2fb1c8164c95e6f8d06754f0c7637eeae7b
author Richard Smith <richard-llvm@metafoo.co.uk> Fri Aug 24 00:01:19 2012 +0000
committer Richard Smith <richard-llvm@metafoo.co.uk> Fri Aug 24 00:01:19 2012 +0000
tree 145515903474dbdde6c1f4aa3147850b0031e7a2
parent 5d04a3ad0e202a50122d6739c9af533575254a80

Fix undefined behavior (signed integer overflow) when Clang parses a hexfloat with an enormous exponent. Caught by an existing unit test + -ftrapv.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162505 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Support/APFloat.cpp

diff --git a/lib/Support/APFloat.cpp b/lib/Support/APFloat.cpp
index ed261a4..f143e6d 100644
--- a/lib/Support/APFloat.cpp
+++ b/lib/Support/APFloat.cpp
@@ -196,8 +196,10 @@
     assert(value < 10U && "Invalid character in exponent");
 
     unsignedExponent = unsignedExponent * 10 + value;
-    if (unsignedExponent > 32767)
+    if (unsignedExponent > 32767) {
       overflow = true;
+      break;
+    }
   }
 
   if (exponentAdjustment > 32767 || exponentAdjustment < -32768)