Simplify code and silence warning
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@15255 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Bytecode/Reader/Reader.cpp b/lib/Bytecode/Reader/Reader.cpp
index 6da38dd..3ebd7c8 100644
--- a/lib/Bytecode/Reader/Reader.cpp
+++ b/lib/Bytecode/Reader/Reader.cpp
@@ -1401,16 +1401,14 @@
// Check to see if we have already read this global variable...
Value *Val = getValue(TypeID, Slot, false);
- GlobalValue *GV;
if (Val) {
- if (!(GV = dyn_cast<GlobalValue>(Val)))
- error("GlobalValue not in ValueTable!");
+ GlobalValue *GV = dyn_cast<GlobalValue>(Val);
+ if (!GV) error("GlobalValue not in ValueTable!");
+ if (Handler) Handler->handleConstantPointer(PT, Slot, GV);
+ return GV;
} else {
error("Forward references are not allowed here.");
}
-
- if (Handler) Handler->handleConstantPointer(PT, Slot, GV );
- return GV;
}
default: