Simplify code by using ConstantInt::getRawValue instead of checking to see
whether the constant is signed or unsigned, then casting
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@7252 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Target/X86/Printer.cpp b/lib/Target/X86/Printer.cpp
index c2f2bb8..08dbb6c 100644
--- a/lib/Target/X86/Printer.cpp
+++ b/lib/Target/X86/Printer.cpp
@@ -293,9 +293,7 @@
const Type *ETy = cast<ArrayType>(CVA->getType())->getElementType();
Result = "\"";
for (unsigned i = 0; i < CVA->getNumOperands(); ++i) {
- unsigned char C = (ETy == Type::SByteTy) ?
- (unsigned char)cast<ConstantSInt>(CVA->getOperand(i))->getValue() :
- (unsigned char)cast<ConstantUInt>(CVA->getOperand(i))->getValue();
+ unsigned char C = cast<ConstantInt>(CVA->getOperand(i))->getRawValue();
if (C == '"') {
Result += "\\\"";
@@ -943,19 +941,14 @@
return false; // success
}
-static const Function *isConstantFunctionPointerRef (const Constant *C) {
- const ConstantPointerRef *R = dyn_cast<ConstantPointerRef>(C);
- if (R) {
- const Function *F = dyn_cast<Function>(R->getValue());
- if (F) {
+static const Function *isConstantFunctionPointerRef(const Constant *C) {
+ if (const ConstantPointerRef *R = dyn_cast<ConstantPointerRef>(C))
+ if (const Function *F = dyn_cast<Function>(R->getValue()))
return F;
- }
- }
- return NULL;
+ return 0;
}
-bool Printer::doFinalization(Module &M)
-{
+bool Printer::doFinalization(Module &M) {
// Print out module-level global variables here.
for (Module::const_giterator I = M.gbegin(), E = M.gend(); I != E; ++I) {
std::string name(getValueName(I));
@@ -989,5 +982,3 @@
MangledGlobals.clear();
return false; // success
}
-
-