Added typedef "SerializedPtrID" to represent the pointer handle written to disk
instead of just using "unsigned". This gives us more flexibility in changing
the definition of the handle later, and is more self-documenting.
Added tracking of block stack in the Deserializer. Now clients can query
if they are still within a block using the methods GetCurrentBlockLocation()
and FinishedBlock().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43903 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Bitcode/Reader/Deserialize.cpp b/lib/Bitcode/Reader/Deserialize.cpp
index 99cb5d2..5d0c724 100644
--- a/lib/Bitcode/Reader/Deserialize.cpp
+++ b/lib/Bitcode/Reader/Deserialize.cpp
@@ -63,15 +63,16 @@
Code = Stream.ReadCode();
if (Code == bitc::ENTER_SUBBLOCK) {
- // No known subblocks, always skip them.
+ BlockLocs.push_back(Stream.GetCurrentBitNo());
unsigned id = Stream.ReadSubBlockID();
Stream.EnterSubBlock(id);
continue;
}
- if (Code == bitc::END_BLOCK) {
+ if (Code == bitc::END_BLOCK) {
bool x = Stream.ReadBlockEnd();
assert (!x && "Error at block end.");
+ BlockLocs.pop_back();
continue;
}
@@ -88,6 +89,26 @@
assert (Record.size() > 0 || Stream.AtEndOfStream());
}
+Deserializer::Location Deserializer::GetCurrentBlockLocation() {
+ if (!inRecord())
+ ReadRecord();
+
+ assert (!BlockLocs.empty());
+ return BlockLocs.back();
+}
+
+bool Deserializer::FinishedBlock(Location BlockLoc) {
+ if (!inRecord())
+ ReadRecord();
+
+ for (llvm::SmallVector<Location,5>::reverse_iterator
+ I=BlockLocs.rbegin(), E=BlockLocs.rend(); I!=E; ++I)
+ if (*I == BlockLoc)
+ return false;
+
+ return true;
+}
+
bool Deserializer::AtEnd() {
if (inRecord())
return false;
@@ -159,7 +180,7 @@
}
void Deserializer::ReadUIntPtr(uintptr_t& PtrRef, bool AllowBackpatch) {
- unsigned PtrId = ReadInt();
+ SerializedPtrID PtrId = ReadPtrID();
if (PtrId == 0) {
PtrRef = 0;
@@ -194,7 +215,7 @@
}
uintptr_t Deserializer::ReadInternalRefPtr() {
- unsigned PtrId = ReadInt();
+ SerializedPtrID PtrId = ReadPtrID();
assert (PtrId != 0 && "References cannot refer the NULL address.");