blob: 9dec22ec78a36de0a7fb8f3abf976815cf035a8a [file] [log] [blame]
Chris Lattner21ab22e2004-07-31 10:01:27 +00001//===-- BranchFolding.cpp - Fold machine code branch instructions ---------===//
Misha Brukmanedf128a2005-04-21 22:36:52 +00002//
Chris Lattner21ab22e2004-07-31 10:01:27 +00003// The LLVM Compiler Infrastructure
4//
Chris Lattner4ee451d2007-12-29 20:36:04 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Misha Brukmanedf128a2005-04-21 22:36:52 +00007//
Chris Lattner21ab22e2004-07-31 10:01:27 +00008//===----------------------------------------------------------------------===//
9//
10// This pass forwards branches to unconditional branches to make them branch
11// directly to the target block. This pass often results in dead MBB's, which
12// it then removes.
13//
14// Note that this pass must be run after register allocation, it cannot handle
15// SSA form.
16//
17//===----------------------------------------------------------------------===//
18
Chris Lattnerf10a56a2006-11-18 21:56:39 +000019#define DEBUG_TYPE "branchfolding"
Evan Cheng030a0a02009-09-04 07:47:40 +000020#include "BranchFolding.h"
Bob Wilson2c04dae2009-10-28 22:10:20 +000021#include "llvm/Function.h"
Chris Lattner21ab22e2004-07-31 10:01:27 +000022#include "llvm/CodeGen/Passes.h"
Jim Laskey44c3b9f2007-01-26 21:22:28 +000023#include "llvm/CodeGen/MachineModuleInfo.h"
Chris Lattner21ab22e2004-07-31 10:01:27 +000024#include "llvm/CodeGen/MachineFunctionPass.h"
Chris Lattnerc50ffcb2006-10-17 17:13:52 +000025#include "llvm/CodeGen/MachineJumpTableInfo.h"
Dale Johannesen69cb9b72007-03-20 21:35:06 +000026#include "llvm/CodeGen/RegisterScavenging.h"
Chris Lattner21ab22e2004-07-31 10:01:27 +000027#include "llvm/Target/TargetInstrInfo.h"
28#include "llvm/Target/TargetMachine.h"
Dan Gohman6f0d0242008-02-10 18:45:23 +000029#include "llvm/Target/TargetRegisterInfo.h"
Chris Lattner12143052006-10-21 00:47:49 +000030#include "llvm/Support/CommandLine.h"
Chris Lattnerf10a56a2006-11-18 21:56:39 +000031#include "llvm/Support/Debug.h"
Torok Edwinc25e7582009-07-11 20:10:48 +000032#include "llvm/Support/ErrorHandling.h"
Bill Wendling3403bcd2009-08-22 20:03:00 +000033#include "llvm/Support/raw_ostream.h"
Evan Cheng80b09fe2008-04-10 02:32:10 +000034#include "llvm/ADT/SmallSet.h"
Dan Gohman2210c0b2009-11-11 19:48:59 +000035#include "llvm/ADT/SetVector.h"
Chris Lattner12143052006-10-21 00:47:49 +000036#include "llvm/ADT/Statistic.h"
Reid Spencer551ccae2004-09-01 22:55:40 +000037#include "llvm/ADT/STLExtras.h"
Jeff Cohend41b30d2006-11-05 19:31:28 +000038#include <algorithm>
Chris Lattner21ab22e2004-07-31 10:01:27 +000039using namespace llvm;
40
Chris Lattnercd3245a2006-12-19 22:41:21 +000041STATISTIC(NumDeadBlocks, "Number of dead blocks removed");
42STATISTIC(NumBranchOpts, "Number of branches optimized");
43STATISTIC(NumTailMerge , "Number of block tails merged");
Bob Wilson7cd5d3e2009-11-18 19:29:37 +000044
Dan Gohman4e3f1252009-11-11 18:38:14 +000045static cl::opt<cl::boolOrDefault> FlagEnableTailMerge("enable-tail-merge",
Dale Johannesen81da02b2007-05-22 17:14:46 +000046 cl::init(cl::BOU_UNSET), cl::Hidden);
Bob Wilson7cd5d3e2009-11-18 19:29:37 +000047
Dan Gohman844731a2008-05-13 00:00:25 +000048// Throttle for huge numbers of predecessors (compile speed problems)
49static cl::opt<unsigned>
Dan Gohman4e3f1252009-11-11 18:38:14 +000050TailMergeThreshold("tail-merge-threshold",
Dan Gohman844731a2008-05-13 00:00:25 +000051 cl::desc("Max number of predecessors to consider tail merging"),
Dale Johannesen622addb2008-10-27 02:10:21 +000052 cl::init(150), cl::Hidden);
Dale Johannesen1a90a5a2007-06-08 01:08:52 +000053
Dan Gohman2210c0b2009-11-11 19:48:59 +000054// Heuristic for tail merging (and, inversely, tail duplication).
55// TODO: This should be replaced with a target query.
56static cl::opt<unsigned>
Bob Wilson3cbc3122009-11-16 17:56:13 +000057TailMergeSize("tail-merge-size",
Dan Gohman2210c0b2009-11-11 19:48:59 +000058 cl::desc("Min number of instructions to consider tail merging"),
59 cl::init(3), cl::Hidden);
Devang Patel794fd752007-05-01 21:15:47 +000060
Dan Gohman72b29902009-11-12 01:59:26 +000061namespace {
62 /// BranchFolderPass - Wrap branch folder in a machine function pass.
63 class BranchFolderPass : public MachineFunctionPass,
64 public BranchFolder {
65 public:
66 static char ID;
67 explicit BranchFolderPass(bool defaultEnableTailMerge)
68 : MachineFunctionPass(&ID), BranchFolder(defaultEnableTailMerge) {}
69
70 virtual bool runOnMachineFunction(MachineFunction &MF);
71 virtual const char *getPassName() const { return "Control Flow Optimizer"; }
72 };
73}
74
Evan Cheng030a0a02009-09-04 07:47:40 +000075char BranchFolderPass::ID = 0;
Chris Lattner21ab22e2004-07-31 10:01:27 +000076
Dan Gohman7cc253e2009-11-11 19:56:05 +000077FunctionPass *llvm::createBranchFoldingPass(bool DefaultEnableTailMerge) {
Bob Wilsona5971032009-10-28 20:46:46 +000078 return new BranchFolderPass(DefaultEnableTailMerge);
Evan Cheng030a0a02009-09-04 07:47:40 +000079}
80
81bool BranchFolderPass::runOnMachineFunction(MachineFunction &MF) {
82 return OptimizeFunction(MF,
83 MF.getTarget().getInstrInfo(),
84 MF.getTarget().getRegisterInfo(),
85 getAnalysisIfAvailable<MachineModuleInfo>());
86}
87
88
Bob Wilsona5971032009-10-28 20:46:46 +000089BranchFolder::BranchFolder(bool defaultEnableTailMerge) {
Evan Cheng030a0a02009-09-04 07:47:40 +000090 switch (FlagEnableTailMerge) {
91 case cl::BOU_UNSET: EnableTailMerge = defaultEnableTailMerge; break;
92 case cl::BOU_TRUE: EnableTailMerge = true; break;
93 case cl::BOU_FALSE: EnableTailMerge = false; break;
94 }
Evan Chengb3c27422009-09-03 23:54:22 +000095}
Chris Lattner21ab22e2004-07-31 10:01:27 +000096
Chris Lattnerc50ffcb2006-10-17 17:13:52 +000097/// RemoveDeadBlock - Remove the specified dead machine basic block from the
98/// function, updating the CFG.
Chris Lattner683747a2006-10-17 23:17:27 +000099void BranchFolder::RemoveDeadBlock(MachineBasicBlock *MBB) {
Jim Laskey033c9712007-02-22 16:39:03 +0000100 assert(MBB->pred_empty() && "MBB must be dead!");
David Greene465e2b92009-12-24 00:34:21 +0000101 DEBUG(dbgs() << "\nRemoving MBB: " << *MBB);
Dan Gohman4e3f1252009-11-11 18:38:14 +0000102
Chris Lattnerc50ffcb2006-10-17 17:13:52 +0000103 MachineFunction *MF = MBB->getParent();
104 // drop all successors.
105 while (!MBB->succ_empty())
106 MBB->removeSuccessor(MBB->succ_end()-1);
Dan Gohman4e3f1252009-11-11 18:38:14 +0000107
Chris Lattnerc50ffcb2006-10-17 17:13:52 +0000108 // Remove the block.
Dan Gohman8e5f2c62008-07-07 23:14:23 +0000109 MF->erase(MBB);
Chris Lattnerc50ffcb2006-10-17 17:13:52 +0000110}
111
Evan Cheng80b09fe2008-04-10 02:32:10 +0000112/// OptimizeImpDefsBlock - If a basic block is just a bunch of implicit_def
113/// followed by terminators, and if the implicitly defined registers are not
114/// used by the terminators, remove those implicit_def's. e.g.
115/// BB1:
116/// r0 = implicit_def
117/// r1 = implicit_def
118/// br
119/// This block can be optimized away later if the implicit instructions are
120/// removed.
121bool BranchFolder::OptimizeImpDefsBlock(MachineBasicBlock *MBB) {
122 SmallSet<unsigned, 4> ImpDefRegs;
123 MachineBasicBlock::iterator I = MBB->begin();
124 while (I != MBB->end()) {
Chris Lattner518bb532010-02-09 19:54:29 +0000125 if (!I->isImplicitDef())
Evan Cheng80b09fe2008-04-10 02:32:10 +0000126 break;
127 unsigned Reg = I->getOperand(0).getReg();
128 ImpDefRegs.insert(Reg);
Evan Cheng030a0a02009-09-04 07:47:40 +0000129 for (const unsigned *SubRegs = TRI->getSubRegisters(Reg);
Evan Cheng80b09fe2008-04-10 02:32:10 +0000130 unsigned SubReg = *SubRegs; ++SubRegs)
131 ImpDefRegs.insert(SubReg);
132 ++I;
133 }
134 if (ImpDefRegs.empty())
135 return false;
136
137 MachineBasicBlock::iterator FirstTerm = I;
138 while (I != MBB->end()) {
139 if (!TII->isUnpredicatedTerminator(I))
140 return false;
141 // See if it uses any of the implicitly defined registers.
142 for (unsigned i = 0, e = I->getNumOperands(); i != e; ++i) {
143 MachineOperand &MO = I->getOperand(i);
Dan Gohmand735b802008-10-03 15:45:36 +0000144 if (!MO.isReg() || !MO.isUse())
Evan Cheng80b09fe2008-04-10 02:32:10 +0000145 continue;
146 unsigned Reg = MO.getReg();
147 if (ImpDefRegs.count(Reg))
148 return false;
149 }
150 ++I;
151 }
152
153 I = MBB->begin();
154 while (I != FirstTerm) {
155 MachineInstr *ImpDefMI = &*I;
156 ++I;
157 MBB->erase(ImpDefMI);
158 }
159
160 return true;
161}
162
Evan Cheng030a0a02009-09-04 07:47:40 +0000163/// OptimizeFunction - Perhaps branch folding, tail merging and other
164/// CFG optimizations on the given function.
165bool BranchFolder::OptimizeFunction(MachineFunction &MF,
166 const TargetInstrInfo *tii,
167 const TargetRegisterInfo *tri,
168 MachineModuleInfo *mmi) {
169 if (!tii) return false;
Chris Lattner7821a8a2006-10-14 00:21:48 +0000170
Evan Cheng030a0a02009-09-04 07:47:40 +0000171 TII = tii;
172 TRI = tri;
173 MMI = mmi;
174
175 RS = TRI->requiresRegisterScavenging(MF) ? new RegScavenger() : NULL;
Evan Cheng80b09fe2008-04-10 02:32:10 +0000176
Dale Johannesen14ba0cc2007-05-15 21:19:17 +0000177 // Fix CFG. The later algorithms expect it to be right.
Evan Cheng030a0a02009-09-04 07:47:40 +0000178 bool MadeChange = false;
Dale Johannesen14ba0cc2007-05-15 21:19:17 +0000179 for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; I++) {
180 MachineBasicBlock *MBB = I, *TBB = 0, *FBB = 0;
Owen Anderson44eb65c2008-08-14 22:49:33 +0000181 SmallVector<MachineOperand, 4> Cond;
Evan Chengdc54d312009-02-09 07:14:22 +0000182 if (!TII->AnalyzeBranch(*MBB, TBB, FBB, Cond, true))
Evan Cheng030a0a02009-09-04 07:47:40 +0000183 MadeChange |= MBB->CorrectExtraCFGEdges(TBB, FBB, !Cond.empty());
184 MadeChange |= OptimizeImpDefsBlock(MBB);
Dale Johannesen14ba0cc2007-05-15 21:19:17 +0000185 }
186
Chris Lattner12143052006-10-21 00:47:49 +0000187 bool MadeChangeThisIteration = true;
188 while (MadeChangeThisIteration) {
189 MadeChangeThisIteration = false;
190 MadeChangeThisIteration |= TailMergeBlocks(MF);
191 MadeChangeThisIteration |= OptimizeBranches(MF);
Evan Cheng030a0a02009-09-04 07:47:40 +0000192 MadeChange |= MadeChangeThisIteration;
Chris Lattner21ab22e2004-07-31 10:01:27 +0000193 }
194
Bob Wilson80d23702010-03-19 19:05:41 +0000195 // See if any jump tables have become dead as the code generator
Chris Lattner6acfe122006-10-28 18:34:47 +0000196 // did its thing.
197 MachineJumpTableInfo *JTI = MF.getJumpTableInfo();
Chris Lattner071c62f2010-01-25 23:26:13 +0000198 if (JTI == 0) {
199 delete RS;
200 return MadeChange;
201 }
202
Bob Wilson80d23702010-03-19 19:05:41 +0000203 // Walk the function to find jump tables that are live.
204 BitVector JTIsLive(JTI->getJumpTables().size());
Chris Lattner071c62f2010-01-25 23:26:13 +0000205 for (MachineFunction::iterator BB = MF.begin(), E = MF.end();
206 BB != E; ++BB) {
207 for (MachineBasicBlock::iterator I = BB->begin(), E = BB->end();
208 I != E; ++I)
209 for (unsigned op = 0, e = I->getNumOperands(); op != e; ++op) {
210 MachineOperand &Op = I->getOperand(op);
211 if (!Op.isJTI()) continue;
Chris Lattner6acfe122006-10-28 18:34:47 +0000212
Chris Lattner071c62f2010-01-25 23:26:13 +0000213 // Remember that this JT is live.
Bob Wilson80d23702010-03-19 19:05:41 +0000214 JTIsLive.set(Op.getIndex());
Chris Lattner6acfe122006-10-28 18:34:47 +0000215 }
216 }
Evan Cheng030a0a02009-09-04 07:47:40 +0000217
Bob Wilson80d23702010-03-19 19:05:41 +0000218 // Finally, remove dead jump tables. This happens when the
219 // indirect jump was unreachable (and thus deleted).
Chris Lattner071c62f2010-01-25 23:26:13 +0000220 for (unsigned i = 0, e = JTIsLive.size(); i != e; ++i)
221 if (!JTIsLive.test(i)) {
222 JTI->RemoveJumpTable(i);
223 MadeChange = true;
224 }
225
Dale Johannesen69cb9b72007-03-20 21:35:06 +0000226 delete RS;
Evan Cheng030a0a02009-09-04 07:47:40 +0000227 return MadeChange;
Chris Lattner21ab22e2004-07-31 10:01:27 +0000228}
229
Chris Lattner12143052006-10-21 00:47:49 +0000230//===----------------------------------------------------------------------===//
231// Tail Merging of Blocks
232//===----------------------------------------------------------------------===//
233
234/// HashMachineInstr - Compute a hash value for MI and its operands.
235static unsigned HashMachineInstr(const MachineInstr *MI) {
236 unsigned Hash = MI->getOpcode();
237 for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
238 const MachineOperand &Op = MI->getOperand(i);
Dan Gohman4e3f1252009-11-11 18:38:14 +0000239
Chris Lattner12143052006-10-21 00:47:49 +0000240 // Merge in bits from the operand if easy.
241 unsigned OperandHash = 0;
242 switch (Op.getType()) {
243 case MachineOperand::MO_Register: OperandHash = Op.getReg(); break;
244 case MachineOperand::MO_Immediate: OperandHash = Op.getImm(); break;
245 case MachineOperand::MO_MachineBasicBlock:
Chris Lattner8aa797a2007-12-30 23:10:15 +0000246 OperandHash = Op.getMBB()->getNumber();
Chris Lattner12143052006-10-21 00:47:49 +0000247 break;
Chris Lattner8aa797a2007-12-30 23:10:15 +0000248 case MachineOperand::MO_FrameIndex:
Chris Lattner12143052006-10-21 00:47:49 +0000249 case MachineOperand::MO_ConstantPoolIndex:
Chris Lattner12143052006-10-21 00:47:49 +0000250 case MachineOperand::MO_JumpTableIndex:
Chris Lattner8aa797a2007-12-30 23:10:15 +0000251 OperandHash = Op.getIndex();
Chris Lattner12143052006-10-21 00:47:49 +0000252 break;
253 case MachineOperand::MO_GlobalAddress:
254 case MachineOperand::MO_ExternalSymbol:
255 // Global address / external symbol are too hard, don't bother, but do
256 // pull in the offset.
257 OperandHash = Op.getOffset();
258 break;
259 default: break;
260 }
Dan Gohman4e3f1252009-11-11 18:38:14 +0000261
Chris Lattner12143052006-10-21 00:47:49 +0000262 Hash += ((OperandHash << 3) | Op.getType()) << (i&31);
263 }
264 return Hash;
265}
266
Dan Gohman30fc5bb2010-05-03 14:35:47 +0000267/// HashEndOfMBB - Hash the last instruction in the MBB.
268static unsigned HashEndOfMBB(const MachineBasicBlock *MBB) {
Chris Lattner12143052006-10-21 00:47:49 +0000269 MachineBasicBlock::const_iterator I = MBB->end();
270 if (I == MBB->begin())
271 return 0; // Empty MBB.
Dan Gohman4e3f1252009-11-11 18:38:14 +0000272
Chris Lattner12143052006-10-21 00:47:49 +0000273 --I;
Dale Johannesen84839da2010-03-08 05:38:13 +0000274 // Skip debug info so it will not affect codegen.
275 while (I->isDebugValue()) {
276 if (I==MBB->begin())
277 return 0; // MBB empty except for debug info.
278 --I;
279 }
Dan Gohman4e3f1252009-11-11 18:38:14 +0000280
Dan Gohman30fc5bb2010-05-03 14:35:47 +0000281 return HashMachineInstr(I);
Chris Lattner12143052006-10-21 00:47:49 +0000282}
283
284/// ComputeCommonTailLength - Given two machine basic blocks, compute the number
285/// of instructions they actually have in common together at their end. Return
286/// iterators for the first shared instruction in each block.
287static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1,
288 MachineBasicBlock *MBB2,
289 MachineBasicBlock::iterator &I1,
290 MachineBasicBlock::iterator &I2) {
291 I1 = MBB1->end();
292 I2 = MBB2->end();
Dan Gohman4e3f1252009-11-11 18:38:14 +0000293
Chris Lattner12143052006-10-21 00:47:49 +0000294 unsigned TailLen = 0;
295 while (I1 != MBB1->begin() && I2 != MBB2->begin()) {
296 --I1; --I2;
Dale Johannesen84839da2010-03-08 05:38:13 +0000297 // Skip debugging pseudos; necessary to avoid changing the code.
298 while (I1->isDebugValue()) {
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000299 if (I1==MBB1->begin()) {
300 while (I2->isDebugValue()) {
301 if (I2==MBB2->begin())
302 // I1==DBG at begin; I2==DBG at begin
303 return TailLen;
304 --I2;
305 }
306 ++I2;
307 // I1==DBG at begin; I2==non-DBG, or first of DBGs not at begin
Dale Johannesen84839da2010-03-08 05:38:13 +0000308 return TailLen;
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000309 }
Dale Johannesen84839da2010-03-08 05:38:13 +0000310 --I1;
311 }
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000312 // I1==first (untested) non-DBG preceding known match
Dale Johannesen84839da2010-03-08 05:38:13 +0000313 while (I2->isDebugValue()) {
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000314 if (I2==MBB2->begin()) {
315 ++I1;
316 // I1==non-DBG, or first of DBGs not at begin; I2==DBG at begin
Dale Johannesen84839da2010-03-08 05:38:13 +0000317 return TailLen;
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000318 }
Dale Johannesen84839da2010-03-08 05:38:13 +0000319 --I2;
320 }
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000321 // I1, I2==first (untested) non-DBGs preceding known match
Dale Johannesen84839da2010-03-08 05:38:13 +0000322 if (!I1->isIdenticalTo(I2) ||
Bill Wendlingda6efc52007-10-25 19:49:32 +0000323 // FIXME: This check is dubious. It's used to get around a problem where
Bill Wendling0713a222007-10-25 18:23:45 +0000324 // people incorrectly expect inline asm directives to remain in the same
325 // relative order. This is untenable because normal compiler
326 // optimizations (like this one) may reorder and/or merge these
327 // directives.
Chris Lattner518bb532010-02-09 19:54:29 +0000328 I1->isInlineAsm()) {
Chris Lattner12143052006-10-21 00:47:49 +0000329 ++I1; ++I2;
330 break;
331 }
332 ++TailLen;
333 }
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000334 // Back past possible debugging pseudos at beginning of block. This matters
335 // when one block differs from the other only by whether debugging pseudos
336 // are present at the beginning. (This way, the various checks later for
337 // I1==MBB1->begin() work as expected.)
338 if (I1 == MBB1->begin() && I2 != MBB2->begin()) {
339 --I2;
340 while (I2->isDebugValue()) {
341 if (I2 == MBB2->begin()) {
342 return TailLen;
343 }
344 --I2;
345 }
346 ++I2;
347 }
348 if (I2 == MBB2->begin() && I1 != MBB1->begin()) {
349 --I1;
350 while (I1->isDebugValue()) {
351 if (I1 == MBB1->begin())
352 return TailLen;
353 --I1;
354 }
355 ++I1;
356 }
Chris Lattner12143052006-10-21 00:47:49 +0000357 return TailLen;
358}
359
360/// ReplaceTailWithBranchTo - Delete the instruction OldInst and everything
Chris Lattner386e2902006-10-21 05:08:28 +0000361/// after it, replacing it with an unconditional branch to NewDest. This
362/// returns true if OldInst's block is modified, false if NewDest is modified.
Chris Lattner12143052006-10-21 00:47:49 +0000363void BranchFolder::ReplaceTailWithBranchTo(MachineBasicBlock::iterator OldInst,
364 MachineBasicBlock *NewDest) {
365 MachineBasicBlock *OldBB = OldInst->getParent();
Dan Gohman4e3f1252009-11-11 18:38:14 +0000366
Chris Lattner12143052006-10-21 00:47:49 +0000367 // Remove all the old successors of OldBB from the CFG.
368 while (!OldBB->succ_empty())
369 OldBB->removeSuccessor(OldBB->succ_begin());
Dan Gohman4e3f1252009-11-11 18:38:14 +0000370
Chris Lattner12143052006-10-21 00:47:49 +0000371 // Remove all the dead instructions from the end of OldBB.
372 OldBB->erase(OldInst, OldBB->end());
373
Chris Lattner386e2902006-10-21 05:08:28 +0000374 // If OldBB isn't immediately before OldBB, insert a branch to it.
375 if (++MachineFunction::iterator(OldBB) != MachineFunction::iterator(NewDest))
Dan Gohman1501cdb2008-08-22 16:07:55 +0000376 TII->InsertBranch(*OldBB, NewDest, 0, SmallVector<MachineOperand, 0>());
Chris Lattner12143052006-10-21 00:47:49 +0000377 OldBB->addSuccessor(NewDest);
378 ++NumTailMerge;
379}
380
Chris Lattner1d08d832006-11-01 01:16:12 +0000381/// SplitMBBAt - Given a machine basic block and an iterator into it, split the
382/// MBB so that the part before the iterator falls into the part starting at the
383/// iterator. This returns the new MBB.
384MachineBasicBlock *BranchFolder::SplitMBBAt(MachineBasicBlock &CurMBB,
385 MachineBasicBlock::iterator BBI1) {
Dan Gohman8e5f2c62008-07-07 23:14:23 +0000386 MachineFunction &MF = *CurMBB.getParent();
387
Chris Lattner1d08d832006-11-01 01:16:12 +0000388 // Create the fall-through block.
389 MachineFunction::iterator MBBI = &CurMBB;
Dan Gohman8e5f2c62008-07-07 23:14:23 +0000390 MachineBasicBlock *NewMBB =MF.CreateMachineBasicBlock(CurMBB.getBasicBlock());
391 CurMBB.getParent()->insert(++MBBI, NewMBB);
Chris Lattner1d08d832006-11-01 01:16:12 +0000392
393 // Move all the successors of this block to the specified block.
Dan Gohman04478e52008-06-19 17:22:29 +0000394 NewMBB->transferSuccessors(&CurMBB);
Dan Gohman4e3f1252009-11-11 18:38:14 +0000395
Chris Lattner1d08d832006-11-01 01:16:12 +0000396 // Add an edge from CurMBB to NewMBB for the fall-through.
397 CurMBB.addSuccessor(NewMBB);
Dan Gohman4e3f1252009-11-11 18:38:14 +0000398
Chris Lattner1d08d832006-11-01 01:16:12 +0000399 // Splice the code over.
400 NewMBB->splice(NewMBB->end(), &CurMBB, BBI1, CurMBB.end());
Dale Johannesen69cb9b72007-03-20 21:35:06 +0000401
402 // For targets that use the register scavenger, we must maintain LiveIns.
403 if (RS) {
404 RS->enterBasicBlock(&CurMBB);
405 if (!CurMBB.empty())
406 RS->forward(prior(CurMBB.end()));
Evan Cheng030a0a02009-09-04 07:47:40 +0000407 BitVector RegsLiveAtExit(TRI->getNumRegs());
Dale Johannesen69cb9b72007-03-20 21:35:06 +0000408 RS->getRegsUsed(RegsLiveAtExit, false);
Dan Gohman8520149d2009-11-12 01:51:28 +0000409 for (unsigned int i = 0, e = TRI->getNumRegs(); i != e; i++)
Dale Johannesen69cb9b72007-03-20 21:35:06 +0000410 if (RegsLiveAtExit[i])
411 NewMBB->addLiveIn(i);
412 }
413
Chris Lattner1d08d832006-11-01 01:16:12 +0000414 return NewMBB;
415}
416
Chris Lattnerd4bf3c22006-11-01 19:36:29 +0000417/// EstimateRuntime - Make a rough estimate for how long it will take to run
418/// the specified code.
419static unsigned EstimateRuntime(MachineBasicBlock::iterator I,
Chris Lattner69244302008-01-07 01:56:04 +0000420 MachineBasicBlock::iterator E) {
Chris Lattnerd4bf3c22006-11-01 19:36:29 +0000421 unsigned Time = 0;
422 for (; I != E; ++I) {
Dale Johannesenb0812f12010-03-05 00:02:59 +0000423 if (I->isDebugValue())
424 continue;
Chris Lattner749c6f62008-01-07 07:27:27 +0000425 const TargetInstrDesc &TID = I->getDesc();
426 if (TID.isCall())
Chris Lattnerd4bf3c22006-11-01 19:36:29 +0000427 Time += 10;
Dan Gohman41474ba2008-12-03 02:30:17 +0000428 else if (TID.mayLoad() || TID.mayStore())
Chris Lattnerd4bf3c22006-11-01 19:36:29 +0000429 Time += 2;
430 else
431 ++Time;
432 }
433 return Time;
434}
435
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000436// CurMBB needs to add an unconditional branch to SuccMBB (we removed these
437// branches temporarily for tail merging). In the case where CurMBB ends
438// with a conditional branch to the next block, optimize by reversing the
439// test and conditionally branching to SuccMBB instead.
Bob Wilsond34f5d92009-11-16 18:08:46 +0000440static void FixTail(MachineBasicBlock *CurMBB, MachineBasicBlock *SuccBB,
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000441 const TargetInstrInfo *TII) {
442 MachineFunction *MF = CurMBB->getParent();
Chris Lattner7896c9f2009-12-03 00:50:42 +0000443 MachineFunction::iterator I = llvm::next(MachineFunction::iterator(CurMBB));
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000444 MachineBasicBlock *TBB = 0, *FBB = 0;
Owen Anderson44eb65c2008-08-14 22:49:33 +0000445 SmallVector<MachineOperand, 4> Cond;
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000446 if (I != MF->end() &&
Evan Chengdc54d312009-02-09 07:14:22 +0000447 !TII->AnalyzeBranch(*CurMBB, TBB, FBB, Cond, true)) {
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000448 MachineBasicBlock *NextBB = I;
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000449 if (TBB == NextBB && !Cond.empty() && !FBB) {
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000450 if (!TII->ReverseBranchCondition(Cond)) {
451 TII->RemoveBranch(*CurMBB);
452 TII->InsertBranch(*CurMBB, SuccBB, NULL, Cond);
453 return;
454 }
455 }
456 }
Dan Gohman1501cdb2008-08-22 16:07:55 +0000457 TII->InsertBranch(*CurMBB, SuccBB, NULL, SmallVector<MachineOperand, 0>());
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000458}
459
Dan Gohmanffe644e2009-11-11 21:57:02 +0000460bool
461BranchFolder::MergePotentialsElt::operator<(const MergePotentialsElt &o) const {
462 if (getHash() < o.getHash())
463 return true;
464 else if (getHash() > o.getHash())
465 return false;
466 else if (getBlock()->getNumber() < o.getBlock()->getNumber())
467 return true;
468 else if (getBlock()->getNumber() > o.getBlock()->getNumber())
469 return false;
470 else {
471 // _GLIBCXX_DEBUG checks strict weak ordering, which involves comparing
472 // an object with itself.
Duncan Sands97b4ac82007-07-11 08:47:55 +0000473#ifndef _GLIBCXX_DEBUG
Dan Gohmanffe644e2009-11-11 21:57:02 +0000474 llvm_unreachable("Predecessor appears twice");
David Greene67fcdf72007-07-10 22:00:30 +0000475#endif
Dan Gohmanffe644e2009-11-11 21:57:02 +0000476 return false;
477 }
Dale Johannesen95ef4062007-05-29 23:47:50 +0000478}
479
Dan Gohman2210c0b2009-11-11 19:48:59 +0000480/// CountTerminators - Count the number of terminators in the given
481/// block and set I to the position of the first non-terminator, if there
482/// is one, or MBB->end() otherwise.
483static unsigned CountTerminators(MachineBasicBlock *MBB,
484 MachineBasicBlock::iterator &I) {
485 I = MBB->end();
486 unsigned NumTerms = 0;
487 for (;;) {
488 if (I == MBB->begin()) {
489 I = MBB->end();
490 break;
491 }
492 --I;
493 if (!I->getDesc().isTerminator()) break;
494 ++NumTerms;
495 }
496 return NumTerms;
497}
498
Bob Wilson7b888b82009-10-29 18:40:06 +0000499/// ProfitableToMerge - Check if two machine basic blocks have a common tail
500/// and decide if it would be profitable to merge those tails. Return the
501/// length of the common tail and iterators to the first common instruction
502/// in each block.
503static bool ProfitableToMerge(MachineBasicBlock *MBB1,
504 MachineBasicBlock *MBB2,
505 unsigned minCommonTailLength,
506 unsigned &CommonTailLen,
507 MachineBasicBlock::iterator &I1,
Dan Gohman2210c0b2009-11-11 19:48:59 +0000508 MachineBasicBlock::iterator &I2,
509 MachineBasicBlock *SuccBB,
510 MachineBasicBlock *PredBB) {
Bob Wilson7b888b82009-10-29 18:40:06 +0000511 CommonTailLen = ComputeCommonTailLength(MBB1, MBB2, I1, I2);
512 MachineFunction *MF = MBB1->getParent();
513
Bob Wilson7b888b82009-10-29 18:40:06 +0000514 if (CommonTailLen == 0)
515 return false;
516
Dan Gohman2210c0b2009-11-11 19:48:59 +0000517 // It's almost always profitable to merge any number of non-terminator
518 // instructions with the block that falls through into the common successor.
519 if (MBB1 == PredBB || MBB2 == PredBB) {
520 MachineBasicBlock::iterator I;
521 unsigned NumTerms = CountTerminators(MBB1 == PredBB ? MBB2 : MBB1, I);
522 if (CommonTailLen > NumTerms)
523 return true;
524 }
525
Dan Gohmanad6af452009-11-12 00:39:10 +0000526 // If one of the blocks can be completely merged and happens to be in
527 // a position where the other could fall through into it, merge any number
528 // of instructions, because it can be done without a branch.
529 // TODO: If the blocks are not adjacent, move one of them so that they are?
530 if (MBB1->isLayoutSuccessor(MBB2) && I2 == MBB2->begin())
531 return true;
532 if (MBB2->isLayoutSuccessor(MBB1) && I1 == MBB1->begin())
533 return true;
534
Dan Gohman2210c0b2009-11-11 19:48:59 +0000535 // If both blocks have an unconditional branch temporarily stripped out,
Dan Gohmanc4c550c2009-11-13 21:02:15 +0000536 // count that as an additional common instruction for the following
537 // heuristics.
538 unsigned EffectiveTailLen = CommonTailLen;
Bob Wilson3cbc3122009-11-16 17:56:13 +0000539 if (SuccBB && MBB1 != PredBB && MBB2 != PredBB &&
Dan Gohman2210c0b2009-11-11 19:48:59 +0000540 !MBB1->back().getDesc().isBarrier() &&
541 !MBB2->back().getDesc().isBarrier())
Dan Gohmanc4c550c2009-11-13 21:02:15 +0000542 ++EffectiveTailLen;
Dan Gohman2210c0b2009-11-11 19:48:59 +0000543
544 // Check if the common tail is long enough to be worthwhile.
Dan Gohmanc4c550c2009-11-13 21:02:15 +0000545 if (EffectiveTailLen >= minCommonTailLength)
Dan Gohman2210c0b2009-11-11 19:48:59 +0000546 return true;
547
Dan Gohmanc4c550c2009-11-13 21:02:15 +0000548 // If we are optimizing for code size, 2 instructions in common is enough if
549 // we don't have to split a block. At worst we will be introducing 1 new
550 // branch instruction, which is likely to be smaller than the 2
551 // instructions that would be deleted in the merge.
552 if (EffectiveTailLen >= 2 &&
553 MF->getFunction()->hasFnAttr(Attribute::OptimizeForSize) &&
Bob Wilson7b888b82009-10-29 18:40:06 +0000554 (I1 == MBB1->begin() || I2 == MBB2->begin()))
555 return true;
556
557 return false;
558}
559
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000560/// ComputeSameTails - Look through all the blocks in MergePotentials that have
Dan Gohman4e3f1252009-11-11 18:38:14 +0000561/// hash CurHash (guaranteed to match the last element). Build the vector
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000562/// SameTails of all those that have the (same) largest number of instructions
563/// in common of any pair of these blocks. SameTails entries contain an
Dan Gohman4e3f1252009-11-11 18:38:14 +0000564/// iterator into MergePotentials (from which the MachineBasicBlock can be
565/// found) and a MachineBasicBlock::iterator into that MBB indicating the
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000566/// instruction where the matching code sequence begins.
567/// Order of elements in SameTails is the reverse of the order in which
568/// those blocks appear in MergePotentials (where they are not necessarily
569/// consecutive).
Dan Gohman4e3f1252009-11-11 18:38:14 +0000570unsigned BranchFolder::ComputeSameTails(unsigned CurHash,
Dan Gohman2210c0b2009-11-11 19:48:59 +0000571 unsigned minCommonTailLength,
572 MachineBasicBlock *SuccBB,
573 MachineBasicBlock *PredBB) {
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000574 unsigned maxCommonTailLength = 0U;
575 SameTails.clear();
576 MachineBasicBlock::iterator TrialBBI1, TrialBBI2;
577 MPIterator HighestMPIter = prior(MergePotentials.end());
578 for (MPIterator CurMPIter = prior(MergePotentials.end()),
Dan Gohman4e3f1252009-11-11 18:38:14 +0000579 B = MergePotentials.begin();
Dan Gohman8520149d2009-11-12 01:51:28 +0000580 CurMPIter != B && CurMPIter->getHash() == CurHash;
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000581 --CurMPIter) {
Dan Gohmanffe644e2009-11-11 21:57:02 +0000582 for (MPIterator I = prior(CurMPIter); I->getHash() == CurHash ; --I) {
Bob Wilson7b888b82009-10-29 18:40:06 +0000583 unsigned CommonTailLen;
Dan Gohmanffe644e2009-11-11 21:57:02 +0000584 if (ProfitableToMerge(CurMPIter->getBlock(), I->getBlock(),
585 minCommonTailLength,
Dan Gohman2210c0b2009-11-11 19:48:59 +0000586 CommonTailLen, TrialBBI1, TrialBBI2,
587 SuccBB, PredBB)) {
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000588 if (CommonTailLen > maxCommonTailLength) {
589 SameTails.clear();
590 maxCommonTailLength = CommonTailLen;
591 HighestMPIter = CurMPIter;
Dan Gohmanffe644e2009-11-11 21:57:02 +0000592 SameTails.push_back(SameTailElt(CurMPIter, TrialBBI1));
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000593 }
594 if (HighestMPIter == CurMPIter &&
595 CommonTailLen == maxCommonTailLength)
Dan Gohmanffe644e2009-11-11 21:57:02 +0000596 SameTails.push_back(SameTailElt(I, TrialBBI2));
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000597 }
Dan Gohman4e3f1252009-11-11 18:38:14 +0000598 if (I == B)
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000599 break;
600 }
601 }
602 return maxCommonTailLength;
603}
604
605/// RemoveBlocksWithHash - Remove all blocks with hash CurHash from
606/// MergePotentials, restoring branches at ends of blocks as appropriate.
Dan Gohman4e3f1252009-11-11 18:38:14 +0000607void BranchFolder::RemoveBlocksWithHash(unsigned CurHash,
Bob Wilsond34f5d92009-11-16 18:08:46 +0000608 MachineBasicBlock *SuccBB,
609 MachineBasicBlock *PredBB) {
Dale Johannesen679860e2008-05-23 17:19:02 +0000610 MPIterator CurMPIter, B;
Dan Gohman4e3f1252009-11-11 18:38:14 +0000611 for (CurMPIter = prior(MergePotentials.end()), B = MergePotentials.begin();
Dan Gohmanffe644e2009-11-11 21:57:02 +0000612 CurMPIter->getHash() == CurHash;
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000613 --CurMPIter) {
614 // Put the unconditional branch back, if we need one.
Dan Gohmanffe644e2009-11-11 21:57:02 +0000615 MachineBasicBlock *CurMBB = CurMPIter->getBlock();
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000616 if (SuccBB && CurMBB != PredBB)
617 FixTail(CurMBB, SuccBB, TII);
Dan Gohman4e3f1252009-11-11 18:38:14 +0000618 if (CurMPIter == B)
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000619 break;
620 }
Dan Gohmanffe644e2009-11-11 21:57:02 +0000621 if (CurMPIter->getHash() != CurHash)
Dale Johannesen679860e2008-05-23 17:19:02 +0000622 CurMPIter++;
623 MergePotentials.erase(CurMPIter, MergePotentials.end());
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000624}
625
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000626/// CreateCommonTailOnlyBlock - None of the blocks to be tail-merged consist
627/// only of the common tail. Create a block that does by splitting one.
628unsigned BranchFolder::CreateCommonTailOnlyBlock(MachineBasicBlock *&PredBB,
629 unsigned maxCommonTailLength) {
Dan Gohman8520149d2009-11-12 01:51:28 +0000630 unsigned commonTailIndex = 0;
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000631 unsigned TimeEstimate = ~0U;
Dan Gohman8520149d2009-11-12 01:51:28 +0000632 for (unsigned i = 0, e = SameTails.size(); i != e; ++i) {
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000633 // Use PredBB if possible; that doesn't require a new branch.
Dan Gohmanffe644e2009-11-11 21:57:02 +0000634 if (SameTails[i].getBlock() == PredBB) {
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000635 commonTailIndex = i;
636 break;
637 }
638 // Otherwise, make a (fairly bogus) choice based on estimate of
639 // how long it will take the various blocks to execute.
Dan Gohmanffe644e2009-11-11 21:57:02 +0000640 unsigned t = EstimateRuntime(SameTails[i].getBlock()->begin(),
641 SameTails[i].getTailStartPos());
Dan Gohman4e3f1252009-11-11 18:38:14 +0000642 if (t <= TimeEstimate) {
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000643 TimeEstimate = t;
644 commonTailIndex = i;
645 }
646 }
647
Dan Gohmanffe644e2009-11-11 21:57:02 +0000648 MachineBasicBlock::iterator BBI =
649 SameTails[commonTailIndex].getTailStartPos();
650 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock();
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000651
Dale Johannesen84839da2010-03-08 05:38:13 +0000652 // If the common tail includes any debug info we will take it pretty
653 // randomly from one of the inputs. Might be better to remove it?
David Greene465e2b92009-12-24 00:34:21 +0000654 DEBUG(dbgs() << "\nSplitting BB#" << MBB->getNumber() << ", size "
Bill Wendling3403bcd2009-08-22 20:03:00 +0000655 << maxCommonTailLength);
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000656
657 MachineBasicBlock *newMBB = SplitMBBAt(*MBB, BBI);
Dan Gohmanffe644e2009-11-11 21:57:02 +0000658 SameTails[commonTailIndex].setBlock(newMBB);
659 SameTails[commonTailIndex].setTailStartPos(newMBB->begin());
Dan Gohman4e3f1252009-11-11 18:38:14 +0000660
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000661 // If we split PredBB, newMBB is the new predecessor.
Dan Gohman4e3f1252009-11-11 18:38:14 +0000662 if (PredBB == MBB)
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000663 PredBB = newMBB;
664
665 return commonTailIndex;
666}
667
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000668// See if any of the blocks in MergePotentials (which all have a common single
669// successor, or all have no successor) can be tail-merged. If there is a
670// successor, any blocks in MergePotentials that are not tail-merged and
671// are not immediately before Succ must have an unconditional branch to
Dan Gohman4e3f1252009-11-11 18:38:14 +0000672// Succ added (but the predecessor/successor lists need no adjustment).
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000673// The lone predecessor of Succ that falls through into Succ,
674// if any, is given in PredBB.
675
Dan Gohman2210c0b2009-11-11 19:48:59 +0000676bool BranchFolder::TryTailMergeBlocks(MachineBasicBlock *SuccBB,
Bob Wilsond34f5d92009-11-16 18:08:46 +0000677 MachineBasicBlock *PredBB) {
Evan Cheng030a0a02009-09-04 07:47:40 +0000678 bool MadeChange = false;
679
Dan Gohman2210c0b2009-11-11 19:48:59 +0000680 // Except for the special cases below, tail-merge if there are at least
681 // this many instructions in common.
682 unsigned minCommonTailLength = TailMergeSize;
Dan Gohman4e3f1252009-11-11 18:38:14 +0000683
David Greene465e2b92009-12-24 00:34:21 +0000684 DEBUG(dbgs() << "\nTryTailMergeBlocks: ";
Dan Gohman2210c0b2009-11-11 19:48:59 +0000685 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i)
David Greene465e2b92009-12-24 00:34:21 +0000686 dbgs() << "BB#" << MergePotentials[i].getBlock()->getNumber()
Dan Gohman2210c0b2009-11-11 19:48:59 +0000687 << (i == e-1 ? "" : ", ");
David Greene465e2b92009-12-24 00:34:21 +0000688 dbgs() << "\n";
Dan Gohman2210c0b2009-11-11 19:48:59 +0000689 if (SuccBB) {
David Greene465e2b92009-12-24 00:34:21 +0000690 dbgs() << " with successor BB#" << SuccBB->getNumber() << '\n';
Dan Gohman2210c0b2009-11-11 19:48:59 +0000691 if (PredBB)
David Greene465e2b92009-12-24 00:34:21 +0000692 dbgs() << " which has fall-through from BB#"
Dan Gohman2210c0b2009-11-11 19:48:59 +0000693 << PredBB->getNumber() << "\n";
694 }
David Greene465e2b92009-12-24 00:34:21 +0000695 dbgs() << "Looking for common tails of at least "
Dan Gohman2210c0b2009-11-11 19:48:59 +0000696 << minCommonTailLength << " instruction"
697 << (minCommonTailLength == 1 ? "" : "s") << '\n';
698 );
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000699
Chris Lattner12143052006-10-21 00:47:49 +0000700 // Sort by hash value so that blocks with identical end sequences sort
701 // together.
Dan Gohmanffe644e2009-11-11 21:57:02 +0000702 std::stable_sort(MergePotentials.begin(), MergePotentials.end());
Chris Lattner12143052006-10-21 00:47:49 +0000703
704 // Walk through equivalence sets looking for actual exact matches.
705 while (MergePotentials.size() > 1) {
Dan Gohmanffe644e2009-11-11 21:57:02 +0000706 unsigned CurHash = MergePotentials.back().getHash();
Dan Gohman4e3f1252009-11-11 18:38:14 +0000707
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000708 // Build SameTails, identifying the set of blocks with this hash code
709 // and with the maximum number of instructions in common.
Dan Gohman4e3f1252009-11-11 18:38:14 +0000710 unsigned maxCommonTailLength = ComputeSameTails(CurHash,
Dan Gohman2210c0b2009-11-11 19:48:59 +0000711 minCommonTailLength,
712 SuccBB, PredBB);
Dale Johannesen7aea8322007-05-23 21:07:20 +0000713
Dan Gohman4e3f1252009-11-11 18:38:14 +0000714 // If we didn't find any pair that has at least minCommonTailLength
Dale Johannesen6ae83fa2008-05-09 21:24:35 +0000715 // instructions in common, remove all blocks with this hash code and retry.
716 if (SameTails.empty()) {
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000717 RemoveBlocksWithHash(CurHash, SuccBB, PredBB);
Dale Johannesen7aea8322007-05-23 21:07:20 +0000718 continue;
Chris Lattner12143052006-10-21 00:47:49 +0000719 }
Chris Lattner1d08d832006-11-01 01:16:12 +0000720
Dale Johannesen6ae83fa2008-05-09 21:24:35 +0000721 // If one of the blocks is the entire common tail (and not the entry
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000722 // block, which we can't jump to), we can treat all blocks with this same
723 // tail at once. Use PredBB if that is one of the possibilities, as that
724 // will not introduce any extra branches.
Dan Gohmanffe644e2009-11-11 21:57:02 +0000725 MachineBasicBlock *EntryBB = MergePotentials.begin()->getBlock()->
726 getParent()->begin();
727 unsigned commonTailIndex = SameTails.size();
Dan Gohmanad6af452009-11-12 00:39:10 +0000728 // If there are two blocks, check to see if one can be made to fall through
729 // into the other.
730 if (SameTails.size() == 2 &&
731 SameTails[0].getBlock()->isLayoutSuccessor(SameTails[1].getBlock()) &&
732 SameTails[1].tailIsWholeBlock())
733 commonTailIndex = 1;
734 else if (SameTails.size() == 2 &&
735 SameTails[1].getBlock()->isLayoutSuccessor(
736 SameTails[0].getBlock()) &&
737 SameTails[0].tailIsWholeBlock())
738 commonTailIndex = 0;
739 else {
740 // Otherwise just pick one, favoring the fall-through predecessor if
741 // there is one.
742 for (unsigned i = 0, e = SameTails.size(); i != e; ++i) {
743 MachineBasicBlock *MBB = SameTails[i].getBlock();
744 if (MBB == EntryBB && SameTails[i].tailIsWholeBlock())
745 continue;
746 if (MBB == PredBB) {
747 commonTailIndex = i;
748 break;
749 }
750 if (SameTails[i].tailIsWholeBlock())
751 commonTailIndex = i;
Dale Johannesen6ae83fa2008-05-09 21:24:35 +0000752 }
Dale Johannesen6ae83fa2008-05-09 21:24:35 +0000753 }
Dale Johannesena5a21172007-06-01 23:02:45 +0000754
Dan Gohman2210c0b2009-11-11 19:48:59 +0000755 if (commonTailIndex == SameTails.size() ||
Dan Gohmanffe644e2009-11-11 21:57:02 +0000756 (SameTails[commonTailIndex].getBlock() == PredBB &&
757 !SameTails[commonTailIndex].tailIsWholeBlock())) {
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000758 // None of the blocks consist entirely of the common tail.
759 // Split a block so that one does.
Dan Gohman2210c0b2009-11-11 19:48:59 +0000760 commonTailIndex = CreateCommonTailOnlyBlock(PredBB, maxCommonTailLength);
Chris Lattner1d08d832006-11-01 01:16:12 +0000761 }
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000762
Dan Gohmanffe644e2009-11-11 21:57:02 +0000763 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock();
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000764 // MBB is common tail. Adjust all other BB's to jump to this one.
765 // Traversal must be forwards so erases work.
David Greene465e2b92009-12-24 00:34:21 +0000766 DEBUG(dbgs() << "\nUsing common tail in BB#" << MBB->getNumber()
Dan Gohman2210c0b2009-11-11 19:48:59 +0000767 << " for ");
768 for (unsigned int i=0, e = SameTails.size(); i != e; ++i) {
Dan Gohman4e3f1252009-11-11 18:38:14 +0000769 if (commonTailIndex == i)
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000770 continue;
David Greene465e2b92009-12-24 00:34:21 +0000771 DEBUG(dbgs() << "BB#" << SameTails[i].getBlock()->getNumber()
Dan Gohman2210c0b2009-11-11 19:48:59 +0000772 << (i == e-1 ? "" : ", "));
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000773 // Hack the end off BB i, making it jump to BB commonTailIndex instead.
Dan Gohmanffe644e2009-11-11 21:57:02 +0000774 ReplaceTailWithBranchTo(SameTails[i].getTailStartPos(), MBB);
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000775 // BB i is no longer a predecessor of SuccBB; remove it from the worklist.
Dan Gohmanffe644e2009-11-11 21:57:02 +0000776 MergePotentials.erase(SameTails[i].getMPIter());
Chris Lattner12143052006-10-21 00:47:49 +0000777 }
David Greene465e2b92009-12-24 00:34:21 +0000778 DEBUG(dbgs() << "\n");
Dale Johannesen51b2b9e2008-05-12 20:33:57 +0000779 // We leave commonTailIndex in the worklist in case there are other blocks
780 // that match it with a smaller number of instructions.
Chris Lattner1d08d832006-11-01 01:16:12 +0000781 MadeChange = true;
Chris Lattner12143052006-10-21 00:47:49 +0000782 }
Chris Lattner12143052006-10-21 00:47:49 +0000783 return MadeChange;
784}
785
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000786bool BranchFolder::TailMergeBlocks(MachineFunction &MF) {
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000787
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000788 if (!EnableTailMerge) return false;
Dan Gohman4e3f1252009-11-11 18:38:14 +0000789
Evan Cheng030a0a02009-09-04 07:47:40 +0000790 bool MadeChange = false;
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000791
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000792 // First find blocks with no successors.
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000793 MergePotentials.clear();
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000794 for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ++I) {
795 if (I->succ_empty())
Dan Gohman30fc5bb2010-05-03 14:35:47 +0000796 MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(I), I));
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000797 }
Dan Gohman4e3f1252009-11-11 18:38:14 +0000798
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000799 // See if we can do any tail merging on those.
Dale Johannesen6ae83fa2008-05-09 21:24:35 +0000800 if (MergePotentials.size() < TailMergeThreshold &&
801 MergePotentials.size() >= 2)
Dan Gohman2210c0b2009-11-11 19:48:59 +0000802 MadeChange |= TryTailMergeBlocks(NULL, NULL);
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000803
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000804 // Look at blocks (IBB) with multiple predecessors (PBB).
805 // We change each predecessor to a canonical form, by
806 // (1) temporarily removing any unconditional branch from the predecessor
807 // to IBB, and
808 // (2) alter conditional branches so they branch to the other block
Dan Gohman4e3f1252009-11-11 18:38:14 +0000809 // not IBB; this may require adding back an unconditional branch to IBB
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000810 // later, where there wasn't one coming in. E.g.
811 // Bcc IBB
812 // fallthrough to QBB
813 // here becomes
814 // Bncc QBB
815 // with a conceptual B to IBB after that, which never actually exists.
816 // With those changes, we see whether the predecessors' tails match,
817 // and merge them if so. We change things out of canonical form and
818 // back to the way they were later in the process. (OptimizeBranches
819 // would undo some of this, but we can't use it, because we'd get into
820 // a compile-time infinite loop repeatedly doing and undoing the same
821 // transformations.)
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000822
Chris Lattner7896c9f2009-12-03 00:50:42 +0000823 for (MachineFunction::iterator I = llvm::next(MF.begin()), E = MF.end();
Dan Gohman2210c0b2009-11-11 19:48:59 +0000824 I != E; ++I) {
Dale Johannesen62bc8a42008-07-01 21:50:14 +0000825 if (I->pred_size() >= 2 && I->pred_size() < TailMergeThreshold) {
Dan Gohmanda658222009-08-18 15:18:18 +0000826 SmallPtrSet<MachineBasicBlock *, 8> UniquePreds;
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000827 MachineBasicBlock *IBB = I;
828 MachineBasicBlock *PredBB = prior(I);
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000829 MergePotentials.clear();
Dan Gohman4e3f1252009-11-11 18:38:14 +0000830 for (MachineBasicBlock::pred_iterator P = I->pred_begin(),
Dale Johannesen1a90a5a2007-06-08 01:08:52 +0000831 E2 = I->pred_end();
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000832 P != E2; ++P) {
Bob Wilsond34f5d92009-11-16 18:08:46 +0000833 MachineBasicBlock *PBB = *P;
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000834 // Skip blocks that loop to themselves, can't tail merge these.
Dan Gohman4e3f1252009-11-11 18:38:14 +0000835 if (PBB == IBB)
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000836 continue;
Dan Gohmanda658222009-08-18 15:18:18 +0000837 // Visit each predecessor only once.
838 if (!UniquePreds.insert(PBB))
839 continue;
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000840 MachineBasicBlock *TBB = 0, *FBB = 0;
Owen Anderson44eb65c2008-08-14 22:49:33 +0000841 SmallVector<MachineOperand, 4> Cond;
Evan Chengdc54d312009-02-09 07:14:22 +0000842 if (!TII->AnalyzeBranch(*PBB, TBB, FBB, Cond, true)) {
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000843 // Failing case: IBB is the target of a cbr, and
844 // we cannot reverse the branch.
Owen Anderson44eb65c2008-08-14 22:49:33 +0000845 SmallVector<MachineOperand, 4> NewCond(Cond);
Dan Gohman4e3f1252009-11-11 18:38:14 +0000846 if (!Cond.empty() && TBB == IBB) {
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000847 if (TII->ReverseBranchCondition(NewCond))
848 continue;
849 // This is the QBB case described above
850 if (!FBB)
Chris Lattner7896c9f2009-12-03 00:50:42 +0000851 FBB = llvm::next(MachineFunction::iterator(PBB));
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000852 }
Dale Johannesenfe7e3972007-06-04 23:52:54 +0000853 // Failing case: the only way IBB can be reached from PBB is via
854 // exception handling. Happens for landing pads. Would be nice
855 // to have a bit in the edge so we didn't have to do all this.
856 if (IBB->isLandingPad()) {
857 MachineFunction::iterator IP = PBB; IP++;
Bob Wilsond34f5d92009-11-16 18:08:46 +0000858 MachineBasicBlock *PredNextBB = NULL;
Dan Gohman8520149d2009-11-12 01:51:28 +0000859 if (IP != MF.end())
Dale Johannesenfe7e3972007-06-04 23:52:54 +0000860 PredNextBB = IP;
Dan Gohman4e3f1252009-11-11 18:38:14 +0000861 if (TBB == NULL) {
Dan Gohman8520149d2009-11-12 01:51:28 +0000862 if (IBB != PredNextBB) // fallthrough
Dale Johannesenfe7e3972007-06-04 23:52:54 +0000863 continue;
864 } else if (FBB) {
Dan Gohman8520149d2009-11-12 01:51:28 +0000865 if (TBB != IBB && FBB != IBB) // cbr then ubr
Dale Johannesenfe7e3972007-06-04 23:52:54 +0000866 continue;
Dan Gohman30359592008-01-29 13:02:09 +0000867 } else if (Cond.empty()) {
Dan Gohman8520149d2009-11-12 01:51:28 +0000868 if (TBB != IBB) // ubr
Dale Johannesenfe7e3972007-06-04 23:52:54 +0000869 continue;
870 } else {
Dan Gohman8520149d2009-11-12 01:51:28 +0000871 if (TBB != IBB && IBB != PredNextBB) // cbr
Dale Johannesenfe7e3972007-06-04 23:52:54 +0000872 continue;
873 }
874 }
Dale Johannesen76b38fc2007-05-10 01:01:49 +0000875 // Remove the unconditional branch at the end, if any.
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000876 if (TBB && (Cond.empty() || FBB)) {
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000877 TII->RemoveBranch(*PBB);
Dale Johannesen6b8583c2008-05-09 23:28:24 +0000878 if (!Cond.empty())
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000879 // reinsert conditional branch only, for now
Dan Gohman4e3f1252009-11-11 18:38:14 +0000880 TII->InsertBranch(*PBB, (TBB == IBB) ? FBB : TBB, 0, NewCond);
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000881 }
Dan Gohman30fc5bb2010-05-03 14:35:47 +0000882 MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(PBB), *P));
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000883 }
884 }
Dan Gohmancdc06ba2009-11-11 18:42:28 +0000885 if (MergePotentials.size() >= 2)
Dan Gohman2210c0b2009-11-11 19:48:59 +0000886 MadeChange |= TryTailMergeBlocks(IBB, PredBB);
Dan Gohmancdc06ba2009-11-11 18:42:28 +0000887 // Reinsert an unconditional branch if needed.
Dan Gohman2210c0b2009-11-11 19:48:59 +0000888 // The 1 below can occur as a result of removing blocks in TryTailMergeBlocks.
889 PredBB = prior(I); // this may have been changed in TryTailMergeBlocks
Dan Gohmancdc06ba2009-11-11 18:42:28 +0000890 if (MergePotentials.size() == 1 &&
Dan Gohmanffe644e2009-11-11 21:57:02 +0000891 MergePotentials.begin()->getBlock() != PredBB)
892 FixTail(MergePotentials.begin()->getBlock(), IBB, TII);
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000893 }
894 }
Dale Johannesen7d33b4c2007-05-07 20:57:21 +0000895 return MadeChange;
896}
Chris Lattner12143052006-10-21 00:47:49 +0000897
898//===----------------------------------------------------------------------===//
899// Branch Optimization
900//===----------------------------------------------------------------------===//
901
902bool BranchFolder::OptimizeBranches(MachineFunction &MF) {
Evan Cheng030a0a02009-09-04 07:47:40 +0000903 bool MadeChange = false;
Dan Gohman4e3f1252009-11-11 18:38:14 +0000904
Dale Johannesen6b896ce2007-02-17 00:44:34 +0000905 // Make sure blocks are numbered in order
906 MF.RenumberBlocks();
907
Chris Lattner12143052006-10-21 00:47:49 +0000908 for (MachineFunction::iterator I = ++MF.begin(), E = MF.end(); I != E; ) {
909 MachineBasicBlock *MBB = I++;
Evan Cheng030a0a02009-09-04 07:47:40 +0000910 MadeChange |= OptimizeBlock(MBB);
Dan Gohman4e3f1252009-11-11 18:38:14 +0000911
Chris Lattner12143052006-10-21 00:47:49 +0000912 // If it is dead, remove it.
Jim Laskey033c9712007-02-22 16:39:03 +0000913 if (MBB->pred_empty()) {
Chris Lattner12143052006-10-21 00:47:49 +0000914 RemoveDeadBlock(MBB);
915 MadeChange = true;
916 ++NumDeadBlocks;
917 }
918 }
919 return MadeChange;
920}
921
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000922// Blocks should be considered empty if they contain only debug info;
923// else the debug info would affect codegen.
924static bool IsEmptyBlock(MachineBasicBlock *MBB) {
925 if (MBB->empty())
926 return true;
927 for (MachineBasicBlock::iterator MBBI = MBB->begin(), MBBE = MBB->end();
928 MBBI!=MBBE; ++MBBI) {
929 if (!MBBI->isDebugValue())
930 return false;
931 }
932 return true;
933}
Chris Lattner12143052006-10-21 00:47:49 +0000934
Dale Johannesen2cd9ffe2010-03-10 19:57:56 +0000935// Blocks with only debug info and branches should be considered the same
936// as blocks with only branches.
937static bool IsBranchOnlyBlock(MachineBasicBlock *MBB) {
938 MachineBasicBlock::iterator MBBI, MBBE;
939 for (MBBI = MBB->begin(), MBBE = MBB->end(); MBBI!=MBBE; ++MBBI) {
940 if (!MBBI->isDebugValue())
941 break;
942 }
943 return (MBBI->getDesc().isBranch());
944}
945
Chris Lattnera7bef4a2006-11-18 20:47:54 +0000946/// IsBetterFallthrough - Return true if it would be clearly better to
947/// fall-through to MBB1 than to fall through into MBB2. This has to return
948/// a strict ordering, returning true for both (MBB1,MBB2) and (MBB2,MBB1) will
949/// result in infinite loops.
Dan Gohman4e3f1252009-11-11 18:38:14 +0000950static bool IsBetterFallthrough(MachineBasicBlock *MBB1,
Chris Lattner69244302008-01-07 01:56:04 +0000951 MachineBasicBlock *MBB2) {
Chris Lattner154e1042006-11-18 21:30:35 +0000952 // Right now, we use a simple heuristic. If MBB2 ends with a call, and
953 // MBB1 doesn't, we prefer to fall through into MBB1. This allows us to
Chris Lattnera7bef4a2006-11-18 20:47:54 +0000954 // optimize branches that branch to either a return block or an assert block
955 // into a fallthrough to the return.
Dale Johannesen93d6a7e2010-04-02 01:38:09 +0000956 if (IsEmptyBlock(MBB1) || IsEmptyBlock(MBB2)) return false;
Dan Gohman4e3f1252009-11-11 18:38:14 +0000957
Christopher Lamb11a4f642007-12-10 07:24:06 +0000958 // If there is a clear successor ordering we make sure that one block
959 // will fall through to the next
960 if (MBB1->isSuccessor(MBB2)) return true;
961 if (MBB2->isSuccessor(MBB1)) return false;
Chris Lattnera7bef4a2006-11-18 20:47:54 +0000962
Dale Johannesen93d6a7e2010-04-02 01:38:09 +0000963 // Neither block consists entirely of debug info (per IsEmptyBlock check),
964 // so we needn't test for falling off the beginning here.
965 MachineBasicBlock::iterator MBB1I = --MBB1->end();
966 while (MBB1I->isDebugValue())
967 --MBB1I;
968 MachineBasicBlock::iterator MBB2I = --MBB2->end();
969 while (MBB2I->isDebugValue())
970 --MBB2I;
Chris Lattner749c6f62008-01-07 07:27:27 +0000971 return MBB2I->getDesc().isCall() && !MBB1I->getDesc().isCall();
Chris Lattnera7bef4a2006-11-18 20:47:54 +0000972}
973
Chris Lattner7821a8a2006-10-14 00:21:48 +0000974/// OptimizeBlock - Analyze and optimize control flow related to the specified
975/// block. This is never called on the entry block.
Evan Cheng030a0a02009-09-04 07:47:40 +0000976bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) {
977 bool MadeChange = false;
Dan Gohmand1944982009-11-11 18:18:34 +0000978 MachineFunction &MF = *MBB->getParent();
Dan Gohman2210c0b2009-11-11 19:48:59 +0000979ReoptimizeBlock:
Evan Cheng030a0a02009-09-04 07:47:40 +0000980
Chris Lattner7d097842006-10-24 01:12:32 +0000981 MachineFunction::iterator FallThrough = MBB;
982 ++FallThrough;
Dan Gohman4e3f1252009-11-11 18:38:14 +0000983
Chris Lattnereb15eee2006-10-13 20:43:10 +0000984 // If this block is empty, make everyone use its fall-through, not the block
Dale Johannesena52dd152007-05-31 21:54:00 +0000985 // explicitly. Landing pads should not do this since the landing-pad table
Dan Gohmanab918102009-10-30 02:13:27 +0000986 // points to this block. Blocks with their addresses taken shouldn't be
987 // optimized away.
Dale Johannesenc5cf2272010-03-10 05:45:47 +0000988 if (IsEmptyBlock(MBB) && !MBB->isLandingPad() && !MBB->hasAddressTaken()) {
Chris Lattner386e2902006-10-21 05:08:28 +0000989 // Dead block? Leave for cleanup later.
Evan Cheng030a0a02009-09-04 07:47:40 +0000990 if (MBB->pred_empty()) return MadeChange;
Dan Gohman4e3f1252009-11-11 18:38:14 +0000991
Dan Gohmand1944982009-11-11 18:18:34 +0000992 if (FallThrough == MF.end()) {
Chris Lattnerc50ffcb2006-10-17 17:13:52 +0000993 // TODO: Simplify preds to not branch here if possible!
994 } else {
995 // Rewrite all predecessors of the old block to go to the fallthrough
996 // instead.
Jim Laskey033c9712007-02-22 16:39:03 +0000997 while (!MBB->pred_empty()) {
Chris Lattner7821a8a2006-10-14 00:21:48 +0000998 MachineBasicBlock *Pred = *(MBB->pred_end()-1);
Evan Cheng0370fad2007-06-04 06:44:01 +0000999 Pred->ReplaceUsesOfBlockWith(MBB, FallThrough);
Chris Lattner7821a8a2006-10-14 00:21:48 +00001000 }
Chris Lattnerc50ffcb2006-10-17 17:13:52 +00001001 // If MBB was the target of a jump table, update jump tables to go to the
1002 // fallthrough instead.
Chris Lattner071c62f2010-01-25 23:26:13 +00001003 if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo())
1004 MJTI->ReplaceMBBInJumpTables(MBB, FallThrough);
Chris Lattner7821a8a2006-10-14 00:21:48 +00001005 MadeChange = true;
Chris Lattner21ab22e2004-07-31 10:01:27 +00001006 }
Evan Cheng030a0a02009-09-04 07:47:40 +00001007 return MadeChange;
Chris Lattner21ab22e2004-07-31 10:01:27 +00001008 }
1009
Chris Lattner7821a8a2006-10-14 00:21:48 +00001010 // Check to see if we can simplify the terminator of the block before this
1011 // one.
Chris Lattner7d097842006-10-24 01:12:32 +00001012 MachineBasicBlock &PrevBB = *prior(MachineFunction::iterator(MBB));
Chris Lattnerffddf6b2006-10-17 18:16:40 +00001013
Chris Lattner7821a8a2006-10-14 00:21:48 +00001014 MachineBasicBlock *PriorTBB = 0, *PriorFBB = 0;
Owen Anderson44eb65c2008-08-14 22:49:33 +00001015 SmallVector<MachineOperand, 4> PriorCond;
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001016 bool PriorUnAnalyzable =
Evan Chengdc54d312009-02-09 07:14:22 +00001017 TII->AnalyzeBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, true);
Chris Lattner386e2902006-10-21 05:08:28 +00001018 if (!PriorUnAnalyzable) {
1019 // If the CFG for the prior block has extra edges, remove them.
Evan Cheng2bdb7d02007-06-18 22:43:58 +00001020 MadeChange |= PrevBB.CorrectExtraCFGEdges(PriorTBB, PriorFBB,
1021 !PriorCond.empty());
Dan Gohman4e3f1252009-11-11 18:38:14 +00001022
Chris Lattner7821a8a2006-10-14 00:21:48 +00001023 // If the previous branch is conditional and both conditions go to the same
Chris Lattner2d47bd92006-10-21 05:43:30 +00001024 // destination, remove the branch, replacing it with an unconditional one or
1025 // a fall-through.
Chris Lattner7821a8a2006-10-14 00:21:48 +00001026 if (PriorTBB && PriorTBB == PriorFBB) {
Chris Lattner386e2902006-10-21 05:08:28 +00001027 TII->RemoveBranch(PrevBB);
Dan Gohman4e3f1252009-11-11 18:38:14 +00001028 PriorCond.clear();
Chris Lattner7d097842006-10-24 01:12:32 +00001029 if (PriorTBB != MBB)
Chris Lattner386e2902006-10-21 05:08:28 +00001030 TII->InsertBranch(PrevBB, PriorTBB, 0, PriorCond);
Chris Lattner7821a8a2006-10-14 00:21:48 +00001031 MadeChange = true;
Chris Lattner12143052006-10-21 00:47:49 +00001032 ++NumBranchOpts;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001033 goto ReoptimizeBlock;
Chris Lattner7821a8a2006-10-14 00:21:48 +00001034 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001035
Dan Gohman2210c0b2009-11-11 19:48:59 +00001036 // If the previous block unconditionally falls through to this block and
1037 // this block has no other predecessors, move the contents of this block
1038 // into the prior block. This doesn't usually happen when SimplifyCFG
Bob Wilson465c8252009-11-17 17:40:31 +00001039 // has been used, but it can happen if tail merging splits a fall-through
1040 // predecessor of a block.
Dan Gohman2210c0b2009-11-11 19:48:59 +00001041 // This has to check PrevBB->succ_size() because EH edges are ignored by
1042 // AnalyzeBranch.
1043 if (PriorCond.empty() && !PriorTBB && MBB->pred_size() == 1 &&
1044 PrevBB.succ_size() == 1 &&
1045 !MBB->hasAddressTaken()) {
David Greene465e2b92009-12-24 00:34:21 +00001046 DEBUG(dbgs() << "\nMerging into block: " << PrevBB
Dan Gohman2210c0b2009-11-11 19:48:59 +00001047 << "From MBB: " << *MBB);
1048 PrevBB.splice(PrevBB.end(), MBB, MBB->begin(), MBB->end());
1049 PrevBB.removeSuccessor(PrevBB.succ_begin());;
1050 assert(PrevBB.succ_empty());
1051 PrevBB.transferSuccessors(MBB);
1052 MadeChange = true;
1053 return MadeChange;
1054 }
Bob Wilson3cbc3122009-11-16 17:56:13 +00001055
Chris Lattner7821a8a2006-10-14 00:21:48 +00001056 // If the previous branch *only* branches to *this* block (conditional or
1057 // not) remove the branch.
Chris Lattner7d097842006-10-24 01:12:32 +00001058 if (PriorTBB == MBB && PriorFBB == 0) {
Chris Lattner386e2902006-10-21 05:08:28 +00001059 TII->RemoveBranch(PrevBB);
Chris Lattner7821a8a2006-10-14 00:21:48 +00001060 MadeChange = true;
Chris Lattner12143052006-10-21 00:47:49 +00001061 ++NumBranchOpts;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001062 goto ReoptimizeBlock;
Chris Lattner7821a8a2006-10-14 00:21:48 +00001063 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001064
Chris Lattner2d47bd92006-10-21 05:43:30 +00001065 // If the prior block branches somewhere else on the condition and here if
1066 // the condition is false, remove the uncond second branch.
Chris Lattner7d097842006-10-24 01:12:32 +00001067 if (PriorFBB == MBB) {
Chris Lattner2d47bd92006-10-21 05:43:30 +00001068 TII->RemoveBranch(PrevBB);
1069 TII->InsertBranch(PrevBB, PriorTBB, 0, PriorCond);
1070 MadeChange = true;
1071 ++NumBranchOpts;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001072 goto ReoptimizeBlock;
Chris Lattner2d47bd92006-10-21 05:43:30 +00001073 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001074
Chris Lattnera2d79952006-10-21 05:54:00 +00001075 // If the prior block branches here on true and somewhere else on false, and
1076 // if the branch condition is reversible, reverse the branch to create a
1077 // fall-through.
Chris Lattner7d097842006-10-24 01:12:32 +00001078 if (PriorTBB == MBB) {
Owen Anderson44eb65c2008-08-14 22:49:33 +00001079 SmallVector<MachineOperand, 4> NewPriorCond(PriorCond);
Chris Lattnera2d79952006-10-21 05:54:00 +00001080 if (!TII->ReverseBranchCondition(NewPriorCond)) {
1081 TII->RemoveBranch(PrevBB);
1082 TII->InsertBranch(PrevBB, PriorFBB, 0, NewPriorCond);
1083 MadeChange = true;
1084 ++NumBranchOpts;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001085 goto ReoptimizeBlock;
Chris Lattnera2d79952006-10-21 05:54:00 +00001086 }
1087 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001088
Dan Gohman6d312682009-10-22 00:03:58 +00001089 // If this block has no successors (e.g. it is a return block or ends with
1090 // a call to a no-return function like abort or __cxa_throw) and if the pred
1091 // falls through into this block, and if it would otherwise fall through
1092 // into the block after this, move this block to the end of the function.
Chris Lattner154e1042006-11-18 21:30:35 +00001093 //
Chris Lattnera7bef4a2006-11-18 20:47:54 +00001094 // We consider it more likely that execution will stay in the function (e.g.
1095 // due to loops) than it is to exit it. This asserts in loops etc, moving
1096 // the assert condition out of the loop body.
Dan Gohman6d312682009-10-22 00:03:58 +00001097 if (MBB->succ_empty() && !PriorCond.empty() && PriorFBB == 0 &&
Chris Lattner154e1042006-11-18 21:30:35 +00001098 MachineFunction::iterator(PriorTBB) == FallThrough &&
Bob Wilson15acadd2009-11-26 00:32:21 +00001099 !MBB->canFallThrough()) {
Chris Lattnerf10a56a2006-11-18 21:56:39 +00001100 bool DoTransform = true;
Dan Gohman4e3f1252009-11-11 18:38:14 +00001101
Chris Lattnera7bef4a2006-11-18 20:47:54 +00001102 // We have to be careful that the succs of PredBB aren't both no-successor
1103 // blocks. If neither have successors and if PredBB is the second from
1104 // last block in the function, we'd just keep swapping the two blocks for
1105 // last. Only do the swap if one is clearly better to fall through than
1106 // the other.
Dan Gohmand1944982009-11-11 18:18:34 +00001107 if (FallThrough == --MF.end() &&
Chris Lattner69244302008-01-07 01:56:04 +00001108 !IsBetterFallthrough(PriorTBB, MBB))
Chris Lattnerf10a56a2006-11-18 21:56:39 +00001109 DoTransform = false;
1110
Chris Lattnerf10a56a2006-11-18 21:56:39 +00001111 if (DoTransform) {
Chris Lattnera7bef4a2006-11-18 20:47:54 +00001112 // Reverse the branch so we will fall through on the previous true cond.
Owen Anderson44eb65c2008-08-14 22:49:33 +00001113 SmallVector<MachineOperand, 4> NewPriorCond(PriorCond);
Chris Lattnera7bef4a2006-11-18 20:47:54 +00001114 if (!TII->ReverseBranchCondition(NewPriorCond)) {
David Greene465e2b92009-12-24 00:34:21 +00001115 DEBUG(dbgs() << "\nMoving MBB: " << *MBB
Bill Wendling3403bcd2009-08-22 20:03:00 +00001116 << "To make fallthrough to: " << *PriorTBB << "\n");
Dan Gohman4e3f1252009-11-11 18:38:14 +00001117
Chris Lattnera7bef4a2006-11-18 20:47:54 +00001118 TII->RemoveBranch(PrevBB);
1119 TII->InsertBranch(PrevBB, MBB, 0, NewPriorCond);
1120
1121 // Move this block to the end of the function.
Dan Gohmand1944982009-11-11 18:18:34 +00001122 MBB->moveAfter(--MF.end());
Chris Lattnera7bef4a2006-11-18 20:47:54 +00001123 MadeChange = true;
1124 ++NumBranchOpts;
Evan Cheng030a0a02009-09-04 07:47:40 +00001125 return MadeChange;
Chris Lattnera7bef4a2006-11-18 20:47:54 +00001126 }
1127 }
1128 }
Chris Lattner7821a8a2006-10-14 00:21:48 +00001129 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001130
Chris Lattner386e2902006-10-21 05:08:28 +00001131 // Analyze the branch in the current block.
1132 MachineBasicBlock *CurTBB = 0, *CurFBB = 0;
Owen Anderson44eb65c2008-08-14 22:49:33 +00001133 SmallVector<MachineOperand, 4> CurCond;
Evan Chengdc54d312009-02-09 07:14:22 +00001134 bool CurUnAnalyzable= TII->AnalyzeBranch(*MBB, CurTBB, CurFBB, CurCond, true);
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001135 if (!CurUnAnalyzable) {
Chris Lattner386e2902006-10-21 05:08:28 +00001136 // If the CFG for the prior block has extra edges, remove them.
Evan Cheng2bdb7d02007-06-18 22:43:58 +00001137 MadeChange |= MBB->CorrectExtraCFGEdges(CurTBB, CurFBB, !CurCond.empty());
Chris Lattnereb15eee2006-10-13 20:43:10 +00001138
Dan Gohman4e3f1252009-11-11 18:38:14 +00001139 // If this is a two-way branch, and the FBB branches to this block, reverse
Chris Lattner5d056952006-11-08 01:03:21 +00001140 // the condition so the single-basic-block loop is faster. Instead of:
1141 // Loop: xxx; jcc Out; jmp Loop
1142 // we want:
1143 // Loop: xxx; jncc Loop; jmp Out
1144 if (CurTBB && CurFBB && CurFBB == MBB && CurTBB != MBB) {
Owen Anderson44eb65c2008-08-14 22:49:33 +00001145 SmallVector<MachineOperand, 4> NewCond(CurCond);
Chris Lattner5d056952006-11-08 01:03:21 +00001146 if (!TII->ReverseBranchCondition(NewCond)) {
1147 TII->RemoveBranch(*MBB);
1148 TII->InsertBranch(*MBB, CurFBB, CurTBB, NewCond);
1149 MadeChange = true;
1150 ++NumBranchOpts;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001151 goto ReoptimizeBlock;
Chris Lattner5d056952006-11-08 01:03:21 +00001152 }
1153 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001154
Chris Lattner386e2902006-10-21 05:08:28 +00001155 // If this branch is the only thing in its block, see if we can forward
1156 // other blocks across it.
Dan Gohman4e3f1252009-11-11 18:38:14 +00001157 if (CurTBB && CurCond.empty() && CurFBB == 0 &&
Dale Johannesen2cd9ffe2010-03-10 19:57:56 +00001158 IsBranchOnlyBlock(MBB) && CurTBB != MBB &&
Bob Wilson888acc32009-11-03 23:44:31 +00001159 !MBB->hasAddressTaken()) {
Chris Lattner386e2902006-10-21 05:08:28 +00001160 // This block may contain just an unconditional branch. Because there can
1161 // be 'non-branch terminators' in the block, try removing the branch and
1162 // then seeing if the block is empty.
1163 TII->RemoveBranch(*MBB);
Dale Johannesenc5cf2272010-03-10 05:45:47 +00001164 // If the only things remaining in the block are debug info, remove these
1165 // as well, so this will behave the same as an empty block in non-debug
1166 // mode.
1167 if (!MBB->empty()) {
1168 bool NonDebugInfoFound = false;
1169 for (MachineBasicBlock::iterator I = MBB->begin(), E = MBB->end();
1170 I != E; ++I) {
1171 if (!I->isDebugValue()) {
1172 NonDebugInfoFound = true;
1173 break;
1174 }
1175 }
1176 if (!NonDebugInfoFound)
1177 // Make the block empty, losing the debug info (we could probably
1178 // improve this in some cases.)
1179 MBB->erase(MBB->begin(), MBB->end());
1180 }
Chris Lattner386e2902006-10-21 05:08:28 +00001181 // If this block is just an unconditional branch to CurTBB, we can
1182 // usually completely eliminate the block. The only case we cannot
1183 // completely eliminate the block is when the block before this one
1184 // falls through into MBB and we can't understand the prior block's branch
1185 // condition.
Chris Lattnercf420cc2006-10-28 17:32:47 +00001186 if (MBB->empty()) {
Dan Gohman864e2ef2009-12-05 00:44:40 +00001187 bool PredHasNoFallThrough = !PrevBB.canFallThrough();
Chris Lattnercf420cc2006-10-28 17:32:47 +00001188 if (PredHasNoFallThrough || !PriorUnAnalyzable ||
1189 !PrevBB.isSuccessor(MBB)) {
1190 // If the prior block falls through into us, turn it into an
1191 // explicit branch to us to make updates simpler.
Dan Gohman4e3f1252009-11-11 18:38:14 +00001192 if (!PredHasNoFallThrough && PrevBB.isSuccessor(MBB) &&
Chris Lattnercf420cc2006-10-28 17:32:47 +00001193 PriorTBB != MBB && PriorFBB != MBB) {
1194 if (PriorTBB == 0) {
Chris Lattner6acfe122006-10-28 18:34:47 +00001195 assert(PriorCond.empty() && PriorFBB == 0 &&
1196 "Bad branch analysis");
Chris Lattnercf420cc2006-10-28 17:32:47 +00001197 PriorTBB = MBB;
1198 } else {
1199 assert(PriorFBB == 0 && "Machine CFG out of date!");
1200 PriorFBB = MBB;
1201 }
1202 TII->RemoveBranch(PrevBB);
1203 TII->InsertBranch(PrevBB, PriorTBB, PriorFBB, PriorCond);
Chris Lattner386e2902006-10-21 05:08:28 +00001204 }
Chris Lattner386e2902006-10-21 05:08:28 +00001205
Chris Lattnercf420cc2006-10-28 17:32:47 +00001206 // Iterate through all the predecessors, revectoring each in-turn.
David Greene8a46d342007-06-29 02:45:24 +00001207 size_t PI = 0;
Chris Lattnercf420cc2006-10-28 17:32:47 +00001208 bool DidChange = false;
1209 bool HasBranchToSelf = false;
David Greene8a46d342007-06-29 02:45:24 +00001210 while(PI != MBB->pred_size()) {
1211 MachineBasicBlock *PMBB = *(MBB->pred_begin() + PI);
1212 if (PMBB == MBB) {
Chris Lattnercf420cc2006-10-28 17:32:47 +00001213 // If this block has an uncond branch to itself, leave it.
1214 ++PI;
1215 HasBranchToSelf = true;
1216 } else {
1217 DidChange = true;
David Greene8a46d342007-06-29 02:45:24 +00001218 PMBB->ReplaceUsesOfBlockWith(MBB, CurTBB);
Dale Johannesenbf06f6a2009-05-11 21:54:13 +00001219 // If this change resulted in PMBB ending in a conditional
1220 // branch where both conditions go to the same destination,
1221 // change this to an unconditional branch (and fix the CFG).
1222 MachineBasicBlock *NewCurTBB = 0, *NewCurFBB = 0;
1223 SmallVector<MachineOperand, 4> NewCurCond;
1224 bool NewCurUnAnalyzable = TII->AnalyzeBranch(*PMBB, NewCurTBB,
1225 NewCurFBB, NewCurCond, true);
1226 if (!NewCurUnAnalyzable && NewCurTBB && NewCurTBB == NewCurFBB) {
1227 TII->RemoveBranch(*PMBB);
Dan Gohman4e3f1252009-11-11 18:38:14 +00001228 NewCurCond.clear();
Dale Johannesenbf06f6a2009-05-11 21:54:13 +00001229 TII->InsertBranch(*PMBB, NewCurTBB, 0, NewCurCond);
1230 MadeChange = true;
1231 ++NumBranchOpts;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001232 PMBB->CorrectExtraCFGEdges(NewCurTBB, 0, false);
Dale Johannesenbf06f6a2009-05-11 21:54:13 +00001233 }
Chris Lattnercf420cc2006-10-28 17:32:47 +00001234 }
Chris Lattner4bc135e2006-10-21 06:11:43 +00001235 }
Chris Lattner386e2902006-10-21 05:08:28 +00001236
Chris Lattnercf420cc2006-10-28 17:32:47 +00001237 // Change any jumptables to go to the new MBB.
Chris Lattner071c62f2010-01-25 23:26:13 +00001238 if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo())
1239 MJTI->ReplaceMBBInJumpTables(MBB, CurTBB);
Chris Lattnercf420cc2006-10-28 17:32:47 +00001240 if (DidChange) {
1241 ++NumBranchOpts;
1242 MadeChange = true;
Evan Cheng030a0a02009-09-04 07:47:40 +00001243 if (!HasBranchToSelf) return MadeChange;
Chris Lattnercf420cc2006-10-28 17:32:47 +00001244 }
Chris Lattner4bc135e2006-10-21 06:11:43 +00001245 }
Chris Lattnereb15eee2006-10-13 20:43:10 +00001246 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001247
Chris Lattner386e2902006-10-21 05:08:28 +00001248 // Add the branch back if the block is more than just an uncond branch.
1249 TII->InsertBranch(*MBB, CurTBB, 0, CurCond);
Chris Lattner21ab22e2004-07-31 10:01:27 +00001250 }
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001251 }
1252
Bill Wendling43cf6c32009-12-15 00:39:24 +00001253 // If the prior block doesn't fall through into this block, and if this
1254 // block doesn't fall through into some other block, see if we can find a
1255 // place to move this block where a fall-through will happen.
1256 if (!PrevBB.canFallThrough()) {
1257
Bob Wilson56ea69c2009-11-17 17:06:18 +00001258 // Now we know that there was no fall-through into this block, check to
1259 // see if it has a fall-through into its successor.
Bob Wilson15acadd2009-11-26 00:32:21 +00001260 bool CurFallsThru = MBB->canFallThrough();
Bob Wilson56ea69c2009-11-17 17:06:18 +00001261
Jim Laskey02b3f5e2007-02-21 22:42:20 +00001262 if (!MBB->isLandingPad()) {
1263 // Check all the predecessors of this block. If one of them has no fall
1264 // throughs, move this block right after it.
1265 for (MachineBasicBlock::pred_iterator PI = MBB->pred_begin(),
1266 E = MBB->pred_end(); PI != E; ++PI) {
1267 // Analyze the branch at the end of the pred.
1268 MachineBasicBlock *PredBB = *PI;
Bill Wendling43cf6c32009-12-15 00:39:24 +00001269 MachineFunction::iterator PredFallthrough = PredBB; ++PredFallthrough;
Bill Wendling408e9d12009-12-16 00:00:18 +00001270 MachineBasicBlock *PredTBB = 0, *PredFBB = 0;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001271 SmallVector<MachineOperand, 4> PredCond;
Bill Wendling43cf6c32009-12-15 00:39:24 +00001272 if (PredBB != MBB && !PredBB->canFallThrough() &&
1273 !TII->AnalyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true)
Dale Johannesen76b38fc2007-05-10 01:01:49 +00001274 && (!CurFallsThru || !CurTBB || !CurFBB)
Jim Laskey02b3f5e2007-02-21 22:42:20 +00001275 && (!CurFallsThru || MBB->getNumber() >= PredBB->getNumber())) {
Bill Wendling43cf6c32009-12-15 00:39:24 +00001276 // If the current block doesn't fall through, just move it.
1277 // If the current block can fall through and does not end with a
1278 // conditional branch, we need to append an unconditional jump to
1279 // the (current) next block. To avoid a possible compile-time
1280 // infinite loop, move blocks only backward in this case.
1281 // Also, if there are already 2 branches here, we cannot add a third;
1282 // this means we have the case
1283 // Bcc next
1284 // B elsewhere
1285 // next:
Jim Laskey02b3f5e2007-02-21 22:42:20 +00001286 if (CurFallsThru) {
Bill Wendling43cf6c32009-12-15 00:39:24 +00001287 MachineBasicBlock *NextBB = llvm::next(MachineFunction::iterator(MBB));
Jim Laskey02b3f5e2007-02-21 22:42:20 +00001288 CurCond.clear();
1289 TII->InsertBranch(*MBB, NextBB, 0, CurCond);
1290 }
1291 MBB->moveAfter(PredBB);
1292 MadeChange = true;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001293 goto ReoptimizeBlock;
Chris Lattner7d097842006-10-24 01:12:32 +00001294 }
1295 }
Dale Johannesen6b896ce2007-02-17 00:44:34 +00001296 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001297
Dale Johannesen6b896ce2007-02-17 00:44:34 +00001298 if (!CurFallsThru) {
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001299 // Check all successors to see if we can move this block before it.
1300 for (MachineBasicBlock::succ_iterator SI = MBB->succ_begin(),
1301 E = MBB->succ_end(); SI != E; ++SI) {
1302 // Analyze the branch at the end of the block before the succ.
1303 MachineBasicBlock *SuccBB = *SI;
1304 MachineFunction::iterator SuccPrev = SuccBB; --SuccPrev;
Dan Gohman4e3f1252009-11-11 18:38:14 +00001305
Chris Lattner77edc4b2007-04-30 23:35:00 +00001306 // If this block doesn't already fall-through to that successor, and if
1307 // the succ doesn't already have a block that can fall through into it,
1308 // and if the successor isn't an EH destination, we can arrange for the
1309 // fallthrough to happen.
Dan Gohman2210c0b2009-11-11 19:48:59 +00001310 if (SuccBB != MBB && &*SuccPrev != MBB &&
Bob Wilson15acadd2009-11-26 00:32:21 +00001311 !SuccPrev->canFallThrough() && !CurUnAnalyzable &&
Chris Lattner77edc4b2007-04-30 23:35:00 +00001312 !SuccBB->isLandingPad()) {
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001313 MBB->moveBefore(SuccBB);
1314 MadeChange = true;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001315 goto ReoptimizeBlock;
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001316 }
1317 }
Dan Gohman4e3f1252009-11-11 18:38:14 +00001318
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001319 // Okay, there is no really great place to put this block. If, however,
1320 // the block before this one would be a fall-through if this block were
1321 // removed, move this block to the end of the function.
Bill Wendlingfe586b32009-12-16 00:01:27 +00001322 MachineBasicBlock *PrevTBB = 0, *PrevFBB = 0;
Dan Gohman2210c0b2009-11-11 19:48:59 +00001323 SmallVector<MachineOperand, 4> PrevCond;
Dan Gohmand1944982009-11-11 18:18:34 +00001324 if (FallThrough != MF.end() &&
Dan Gohman2210c0b2009-11-11 19:48:59 +00001325 !TII->AnalyzeBranch(PrevBB, PrevTBB, PrevFBB, PrevCond, true) &&
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001326 PrevBB.isSuccessor(FallThrough)) {
Dan Gohmand1944982009-11-11 18:18:34 +00001327 MBB->moveAfter(--MF.end());
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001328 MadeChange = true;
Evan Cheng030a0a02009-09-04 07:47:40 +00001329 return MadeChange;
Chris Lattner6b0e3f82006-10-29 21:05:41 +00001330 }
Chris Lattner7d097842006-10-24 01:12:32 +00001331 }
Chris Lattner21ab22e2004-07-31 10:01:27 +00001332 }
Evan Cheng030a0a02009-09-04 07:47:40 +00001333
1334 return MadeChange;
Chris Lattner21ab22e2004-07-31 10:01:27 +00001335}