Jia Liu | 31d157a | 2012-02-18 12:03:15 +0000 | [diff] [blame^] | 1 | //===-- Thumb2ITBlockPass.cpp - Insert Thumb-2 IT blocks ------------------===// |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | |
| 10 | #define DEBUG_TYPE "thumb2-it" |
| 11 | #include "ARM.h" |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 12 | #include "ARMMachineFunctionInfo.h" |
Evan Cheng | ed338e8 | 2009-07-11 07:26:20 +0000 | [diff] [blame] | 13 | #include "Thumb2InstrInfo.h" |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 14 | #include "llvm/CodeGen/MachineInstr.h" |
| 15 | #include "llvm/CodeGen/MachineInstrBuilder.h" |
Evan Cheng | ddfd137 | 2011-12-14 02:11:42 +0000 | [diff] [blame] | 16 | #include "llvm/CodeGen/MachineInstrBundle.h" |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 17 | #include "llvm/CodeGen/MachineFunctionPass.h" |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 18 | #include "llvm/ADT/SmallSet.h" |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 19 | #include "llvm/ADT/Statistic.h" |
| 20 | using namespace llvm; |
| 21 | |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 22 | STATISTIC(NumITs, "Number of IT blocks inserted"); |
| 23 | STATISTIC(NumMovedInsts, "Number of predicated instructions moved"); |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 24 | |
| 25 | namespace { |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 26 | class Thumb2ITBlockPass : public MachineFunctionPass { |
| 27 | bool PreRegAlloc; |
| 28 | |
| 29 | public: |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 30 | static char ID; |
Owen Anderson | 90c579d | 2010-08-06 18:33:48 +0000 | [diff] [blame] | 31 | Thumb2ITBlockPass() : MachineFunctionPass(ID) {} |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 32 | |
Evan Cheng | ed338e8 | 2009-07-11 07:26:20 +0000 | [diff] [blame] | 33 | const Thumb2InstrInfo *TII; |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 34 | const TargetRegisterInfo *TRI; |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 35 | ARMFunctionInfo *AFI; |
| 36 | |
| 37 | virtual bool runOnMachineFunction(MachineFunction &Fn); |
| 38 | |
| 39 | virtual const char *getPassName() const { |
| 40 | return "Thumb IT blocks insertion pass"; |
| 41 | } |
| 42 | |
| 43 | private: |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 44 | bool MoveCopyOutOfITBlock(MachineInstr *MI, |
| 45 | ARMCC::CondCodes CC, ARMCC::CondCodes OCC, |
| 46 | SmallSet<unsigned, 4> &Defs, |
| 47 | SmallSet<unsigned, 4> &Uses); |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 48 | bool InsertITInstructions(MachineBasicBlock &MBB); |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 49 | }; |
| 50 | char Thumb2ITBlockPass::ID = 0; |
| 51 | } |
| 52 | |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 53 | /// TrackDefUses - Tracking what registers are being defined and used by |
| 54 | /// instructions in the IT block. This also tracks "dependencies", i.e. uses |
| 55 | /// in the IT block that are defined before the IT instruction. |
| 56 | static void TrackDefUses(MachineInstr *MI, |
| 57 | SmallSet<unsigned, 4> &Defs, |
| 58 | SmallSet<unsigned, 4> &Uses, |
| 59 | const TargetRegisterInfo *TRI) { |
| 60 | SmallVector<unsigned, 4> LocalDefs; |
| 61 | SmallVector<unsigned, 4> LocalUses; |
| 62 | |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 63 | for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) { |
| 64 | MachineOperand &MO = MI->getOperand(i); |
| 65 | if (!MO.isReg()) |
| 66 | continue; |
| 67 | unsigned Reg = MO.getReg(); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 68 | if (!Reg || Reg == ARM::ITSTATE || Reg == ARM::SP) |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 69 | continue; |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 70 | if (MO.isUse()) |
| 71 | LocalUses.push_back(Reg); |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 72 | else |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 73 | LocalDefs.push_back(Reg); |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 74 | } |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 75 | |
| 76 | for (unsigned i = 0, e = LocalUses.size(); i != e; ++i) { |
| 77 | unsigned Reg = LocalUses[i]; |
| 78 | Uses.insert(Reg); |
| 79 | for (const unsigned *Subreg = TRI->getSubRegisters(Reg); |
| 80 | *Subreg; ++Subreg) |
| 81 | Uses.insert(*Subreg); |
| 82 | } |
| 83 | |
| 84 | for (unsigned i = 0, e = LocalDefs.size(); i != e; ++i) { |
| 85 | unsigned Reg = LocalDefs[i]; |
| 86 | Defs.insert(Reg); |
| 87 | for (const unsigned *Subreg = TRI->getSubRegisters(Reg); |
| 88 | *Subreg; ++Subreg) |
| 89 | Defs.insert(*Subreg); |
| 90 | if (Reg == ARM::CPSR) |
| 91 | continue; |
| 92 | } |
| 93 | } |
| 94 | |
Jakob Stoklund Olesen | c66756b | 2010-07-16 22:35:32 +0000 | [diff] [blame] | 95 | static bool isCopy(MachineInstr *MI) { |
| 96 | switch (MI->getOpcode()) { |
| 97 | default: |
| 98 | return false; |
| 99 | case ARM::MOVr: |
| 100 | case ARM::MOVr_TC: |
| 101 | case ARM::tMOVr: |
Jakob Stoklund Olesen | c66756b | 2010-07-16 22:35:32 +0000 | [diff] [blame] | 102 | case ARM::t2MOVr: |
| 103 | return true; |
| 104 | } |
| 105 | } |
| 106 | |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 107 | bool |
| 108 | Thumb2ITBlockPass::MoveCopyOutOfITBlock(MachineInstr *MI, |
| 109 | ARMCC::CondCodes CC, ARMCC::CondCodes OCC, |
| 110 | SmallSet<unsigned, 4> &Defs, |
| 111 | SmallSet<unsigned, 4> &Uses) { |
Jakob Stoklund Olesen | c66756b | 2010-07-16 22:35:32 +0000 | [diff] [blame] | 112 | if (!isCopy(MI)) |
| 113 | return false; |
| 114 | // llvm models select's as two-address instructions. That means a copy |
| 115 | // is inserted before a t2MOVccr, etc. If the copy is scheduled in |
| 116 | // between selects we would end up creating multiple IT blocks. |
| 117 | assert(MI->getOperand(0).getSubReg() == 0 && |
| 118 | MI->getOperand(1).getSubReg() == 0 && |
| 119 | "Sub-register indices still around?"); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 120 | |
Jakob Stoklund Olesen | c66756b | 2010-07-16 22:35:32 +0000 | [diff] [blame] | 121 | unsigned DstReg = MI->getOperand(0).getReg(); |
| 122 | unsigned SrcReg = MI->getOperand(1).getReg(); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 123 | |
Jakob Stoklund Olesen | c66756b | 2010-07-16 22:35:32 +0000 | [diff] [blame] | 124 | // First check if it's safe to move it. |
| 125 | if (Uses.count(DstReg) || Defs.count(SrcReg)) |
| 126 | return false; |
| 127 | |
Bill Wendling | 721e1d2 | 2011-10-10 22:52:53 +0000 | [diff] [blame] | 128 | // If the CPSR is defined by this copy, then we don't want to move it. E.g., |
| 129 | // if we have: |
| 130 | // |
| 131 | // movs r1, r1 |
| 132 | // rsb r1, 0 |
| 133 | // movs r2, r2 |
| 134 | // rsb r2, 0 |
| 135 | // |
| 136 | // we don't want this to be converted to: |
| 137 | // |
| 138 | // movs r1, r1 |
| 139 | // movs r2, r2 |
| 140 | // itt mi |
| 141 | // rsb r1, 0 |
| 142 | // rsb r2, 0 |
| 143 | // |
Bill Wendling | 3f56d4b | 2011-10-11 00:10:41 +0000 | [diff] [blame] | 144 | const MCInstrDesc &MCID = MI->getDesc(); |
Evan Cheng | 5a96b3d | 2011-12-07 07:15:52 +0000 | [diff] [blame] | 145 | if (MI->hasOptionalDef() && |
Bill Wendling | 3f56d4b | 2011-10-11 00:10:41 +0000 | [diff] [blame] | 146 | MI->getOperand(MCID.getNumOperands() - 1).getReg() == ARM::CPSR) |
| 147 | return false; |
Bill Wendling | 721e1d2 | 2011-10-10 22:52:53 +0000 | [diff] [blame] | 148 | |
Jakob Stoklund Olesen | c66756b | 2010-07-16 22:35:32 +0000 | [diff] [blame] | 149 | // Then peek at the next instruction to see if it's predicated on CC or OCC. |
| 150 | // If not, then there is nothing to be gained by moving the copy. |
| 151 | MachineBasicBlock::iterator I = MI; ++I; |
| 152 | MachineBasicBlock::iterator E = MI->getParent()->end(); |
| 153 | while (I != E && I->isDebugValue()) |
| 154 | ++I; |
| 155 | if (I != E) { |
| 156 | unsigned NPredReg = 0; |
| 157 | ARMCC::CondCodes NCC = llvm::getITInstrPredicate(I, NPredReg); |
| 158 | if (NCC == CC || NCC == OCC) |
| 159 | return true; |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 160 | } |
| 161 | return false; |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 162 | } |
| 163 | |
| 164 | bool Thumb2ITBlockPass::InsertITInstructions(MachineBasicBlock &MBB) { |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 165 | bool Modified = false; |
| 166 | |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 167 | SmallSet<unsigned, 4> Defs; |
| 168 | SmallSet<unsigned, 4> Uses; |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 169 | MachineBasicBlock::iterator MBBI = MBB.begin(), E = MBB.end(); |
| 170 | while (MBBI != E) { |
| 171 | MachineInstr *MI = &*MBBI; |
Evan Cheng | 5adb66a | 2009-09-28 09:14:39 +0000 | [diff] [blame] | 172 | DebugLoc dl = MI->getDebugLoc(); |
| 173 | unsigned PredReg = 0; |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 174 | ARMCC::CondCodes CC = llvm::getITInstrPredicate(MI, PredReg); |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 175 | if (CC == ARMCC::AL) { |
| 176 | ++MBBI; |
| 177 | continue; |
| 178 | } |
| 179 | |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 180 | Defs.clear(); |
| 181 | Uses.clear(); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 182 | TrackDefUses(MI, Defs, Uses, TRI); |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 183 | |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 184 | // Insert an IT instruction. |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 185 | MachineInstrBuilder MIB = BuildMI(MBB, MBBI, dl, TII->get(ARM::t2IT)) |
| 186 | .addImm(CC); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 187 | |
| 188 | // Add implicit use of ITSTATE to IT block instructions. |
| 189 | MI->addOperand(MachineOperand::CreateReg(ARM::ITSTATE, false/*ifDef*/, |
| 190 | true/*isImp*/, false/*isKill*/)); |
| 191 | |
| 192 | MachineInstr *LastITMI = MI; |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 193 | MachineBasicBlock::iterator InsertPos = MIB; |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 194 | ++MBBI; |
| 195 | |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 196 | // Form IT block. |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 197 | ARMCC::CondCodes OCC = ARMCC::getOppositeCondition(CC); |
Evan Cheng | bc9b754 | 2009-08-15 07:59:10 +0000 | [diff] [blame] | 198 | unsigned Mask = 0, Pos = 3; |
Sandeep Patel | 452b54a | 2009-10-15 22:25:32 +0000 | [diff] [blame] | 199 | // Branches, including tricky ones like LDM_RET, need to end an IT |
| 200 | // block so check the instruction we just put in the block. |
Jim Grosbach | 8077e76 | 2010-06-07 21:48:47 +0000 | [diff] [blame] | 201 | for (; MBBI != E && Pos && |
Evan Cheng | 5a96b3d | 2011-12-07 07:15:52 +0000 | [diff] [blame] | 202 | (!MI->isBranch() && !MI->isReturn()) ; ++MBBI) { |
Jim Grosbach | 8077e76 | 2010-06-07 21:48:47 +0000 | [diff] [blame] | 203 | if (MBBI->isDebugValue()) |
| 204 | continue; |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 205 | |
Evan Cheng | fd84711 | 2009-09-28 20:47:15 +0000 | [diff] [blame] | 206 | MachineInstr *NMI = &*MBBI; |
Sandeep Patel | 452b54a | 2009-10-15 22:25:32 +0000 | [diff] [blame] | 207 | MI = NMI; |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 208 | |
Evan Cheng | fd84711 | 2009-09-28 20:47:15 +0000 | [diff] [blame] | 209 | unsigned NPredReg = 0; |
Evan Cheng | 4d54e5b | 2010-06-22 01:18:16 +0000 | [diff] [blame] | 210 | ARMCC::CondCodes NCC = llvm::getITInstrPredicate(NMI, NPredReg); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 211 | if (NCC == CC || NCC == OCC) { |
Johnny Chen | b675e25 | 2010-03-17 23:14:23 +0000 | [diff] [blame] | 212 | Mask |= (NCC & 1) << Pos; |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 213 | // Add implicit use of ITSTATE. |
| 214 | NMI->addOperand(MachineOperand::CreateReg(ARM::ITSTATE, false/*ifDef*/, |
Jim Grosbach | e9e3f20 | 2010-06-28 04:27:01 +0000 | [diff] [blame] | 215 | true/*isImp*/, false/*isKill*/)); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 216 | LastITMI = NMI; |
| 217 | } else { |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 218 | if (NCC == ARMCC::AL && |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 219 | MoveCopyOutOfITBlock(NMI, CC, OCC, Defs, Uses)) { |
| 220 | --MBBI; |
| 221 | MBB.remove(NMI); |
| 222 | MBB.insert(InsertPos, NMI); |
| 223 | ++NumMovedInsts; |
| 224 | continue; |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 225 | } |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 226 | break; |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 227 | } |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 228 | TrackDefUses(NMI, Defs, Uses, TRI); |
Evan Cheng | bc9b754 | 2009-08-15 07:59:10 +0000 | [diff] [blame] | 229 | --Pos; |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 230 | } |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 231 | |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 232 | // Finalize IT mask. |
Evan Cheng | bc9b754 | 2009-08-15 07:59:10 +0000 | [diff] [blame] | 233 | Mask |= (1 << Pos); |
Johnny Chen | b675e25 | 2010-03-17 23:14:23 +0000 | [diff] [blame] | 234 | // Tag along (firstcond[0] << 4) with the mask. |
| 235 | Mask |= (CC & 1) << 4; |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 236 | MIB.addImm(Mask); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 237 | |
| 238 | // Last instruction in IT block kills ITSTATE. |
| 239 | LastITMI->findRegisterUseOperand(ARM::ITSTATE)->setIsKill(); |
| 240 | |
Evan Cheng | ddfd137 | 2011-12-14 02:11:42 +0000 | [diff] [blame] | 241 | // Finalize the bundle. |
Evan Cheng | bca15f9 | 2012-01-19 00:46:06 +0000 | [diff] [blame] | 242 | MachineBasicBlock::instr_iterator LI = LastITMI; |
| 243 | finalizeBundle(MBB, InsertPos.getInstrIterator(), llvm::next(LI)); |
Evan Cheng | ddfd137 | 2011-12-14 02:11:42 +0000 | [diff] [blame] | 244 | |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 245 | Modified = true; |
| 246 | ++NumITs; |
| 247 | } |
| 248 | |
| 249 | return Modified; |
| 250 | } |
| 251 | |
| 252 | bool Thumb2ITBlockPass::runOnMachineFunction(MachineFunction &Fn) { |
| 253 | const TargetMachine &TM = Fn.getTarget(); |
| 254 | AFI = Fn.getInfo<ARMFunctionInfo>(); |
Evan Cheng | ed338e8 | 2009-07-11 07:26:20 +0000 | [diff] [blame] | 255 | TII = static_cast<const Thumb2InstrInfo*>(TM.getInstrInfo()); |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 256 | TRI = TM.getRegisterInfo(); |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 257 | |
| 258 | if (!AFI->isThumbFunction()) |
| 259 | return false; |
| 260 | |
| 261 | bool Modified = false; |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 262 | for (MachineFunction::iterator MFI = Fn.begin(), E = Fn.end(); MFI != E; ) { |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 263 | MachineBasicBlock &MBB = *MFI; |
Evan Cheng | d847124 | 2010-06-09 01:46:50 +0000 | [diff] [blame] | 264 | ++MFI; |
Evan Cheng | dca6539 | 2010-07-02 21:07:09 +0000 | [diff] [blame] | 265 | Modified |= InsertITInstructions(MBB); |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 266 | } |
| 267 | |
Evan Cheng | dca6539 | 2010-07-02 21:07:09 +0000 | [diff] [blame] | 268 | if (Modified) |
Evan Cheng | 86050dc | 2010-06-18 23:09:54 +0000 | [diff] [blame] | 269 | AFI->setHasITBlocks(true); |
| 270 | |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 271 | return Modified; |
| 272 | } |
| 273 | |
Evan Cheng | 34f8a02 | 2009-08-08 02:54:37 +0000 | [diff] [blame] | 274 | /// createThumb2ITBlockPass - Returns an instance of the Thumb2 IT blocks |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 275 | /// insertion pass. |
Evan Cheng | dca6539 | 2010-07-02 21:07:09 +0000 | [diff] [blame] | 276 | FunctionPass *llvm::createThumb2ITBlockPass() { |
| 277 | return new Thumb2ITBlockPass(); |
Evan Cheng | 06e1658 | 2009-07-10 01:54:42 +0000 | [diff] [blame] | 278 | } |