Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 1 | //===-- Lint.cpp - Check for common errors in LLVM IR ---------------------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This pass statically checks for common and easily-identified constructs |
| 11 | // which produce undefined or likely unintended behavior in LLVM IR. |
| 12 | // |
| 13 | // It is not a guarantee of correctness, in two ways. First, it isn't |
| 14 | // comprehensive. There are checks which could be done statically which are |
| 15 | // not yet implemented. Some of these are indicated by TODO comments, but |
| 16 | // those aren't comprehensive either. Second, many conditions cannot be |
| 17 | // checked statically. This pass does no dynamic instrumentation, so it |
| 18 | // can't check for all possible problems. |
| 19 | // |
| 20 | // Another limitation is that it assumes all code will be executed. A store |
| 21 | // through a null pointer in a basic block which is never reached is harmless, |
Dan Gohman | d3b6e41 | 2010-07-06 15:21:57 +0000 | [diff] [blame] | 22 | // but this pass will warn about it anyway. This is the main reason why most |
| 23 | // of these checks live here instead of in the Verifier pass. |
Dan Gohman | 0883355 | 2010-04-22 01:30:05 +0000 | [diff] [blame] | 24 | // |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 25 | // Optimization passes may make conditions that this pass checks for more or |
| 26 | // less obvious. If an optimization pass appears to be introducing a warning, |
| 27 | // it may be that the optimization pass is merely exposing an existing |
| 28 | // condition in the code. |
| 29 | // |
| 30 | // This code may be run before instcombine. In many cases, instcombine checks |
| 31 | // for the same kinds of things and turns instructions with undefined behavior |
| 32 | // into unreachable (or equivalent). Because of this, this pass makes some |
| 33 | // effort to look through bitcasts and so on. |
| 34 | // |
| 35 | //===----------------------------------------------------------------------===// |
| 36 | |
| 37 | #include "llvm/Analysis/Passes.h" |
| 38 | #include "llvm/Analysis/AliasAnalysis.h" |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 39 | #include "llvm/Analysis/InstructionSimplify.h" |
| 40 | #include "llvm/Analysis/ConstantFolding.h" |
| 41 | #include "llvm/Analysis/Dominators.h" |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 42 | #include "llvm/Analysis/Lint.h" |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 43 | #include "llvm/Analysis/Loads.h" |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 44 | #include "llvm/Analysis/ValueTracking.h" |
| 45 | #include "llvm/Assembly/Writer.h" |
Micah Villmow | 3574eca | 2012-10-08 16:38:25 +0000 | [diff] [blame] | 46 | #include "llvm/DataLayout.h" |
Chad Rosier | 618c1db | 2011-12-01 03:08:23 +0000 | [diff] [blame] | 47 | #include "llvm/Target/TargetLibraryInfo.h" |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 48 | #include "llvm/Pass.h" |
| 49 | #include "llvm/PassManager.h" |
| 50 | #include "llvm/IntrinsicInst.h" |
| 51 | #include "llvm/Function.h" |
| 52 | #include "llvm/Support/CallSite.h" |
| 53 | #include "llvm/Support/Debug.h" |
| 54 | #include "llvm/Support/InstVisitor.h" |
| 55 | #include "llvm/Support/raw_ostream.h" |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 56 | #include "llvm/ADT/STLExtras.h" |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 57 | using namespace llvm; |
| 58 | |
| 59 | namespace { |
Dan Gohman | 5b61b38 | 2010-04-30 19:05:00 +0000 | [diff] [blame] | 60 | namespace MemRef { |
| 61 | static unsigned Read = 1; |
| 62 | static unsigned Write = 2; |
| 63 | static unsigned Callee = 4; |
| 64 | static unsigned Branchee = 8; |
| 65 | } |
| 66 | |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 67 | class Lint : public FunctionPass, public InstVisitor<Lint> { |
| 68 | friend class InstVisitor<Lint>; |
| 69 | |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 70 | void visitFunction(Function &F); |
| 71 | |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 72 | void visitCallSite(CallSite CS); |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 73 | void visitMemoryReference(Instruction &I, Value *Ptr, |
Dan Gohman | 3da848b | 2010-10-19 22:54:46 +0000 | [diff] [blame] | 74 | uint64_t Size, unsigned Align, |
Chris Lattner | db125cf | 2011-07-18 04:54:35 +0000 | [diff] [blame] | 75 | Type *Ty, unsigned Flags); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 76 | |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 77 | void visitCallInst(CallInst &I); |
| 78 | void visitInvokeInst(InvokeInst &I); |
| 79 | void visitReturnInst(ReturnInst &I); |
| 80 | void visitLoadInst(LoadInst &I); |
| 81 | void visitStoreInst(StoreInst &I); |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 82 | void visitXor(BinaryOperator &I); |
| 83 | void visitSub(BinaryOperator &I); |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 84 | void visitLShr(BinaryOperator &I); |
| 85 | void visitAShr(BinaryOperator &I); |
| 86 | void visitShl(BinaryOperator &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 87 | void visitSDiv(BinaryOperator &I); |
| 88 | void visitUDiv(BinaryOperator &I); |
| 89 | void visitSRem(BinaryOperator &I); |
| 90 | void visitURem(BinaryOperator &I); |
| 91 | void visitAllocaInst(AllocaInst &I); |
| 92 | void visitVAArgInst(VAArgInst &I); |
| 93 | void visitIndirectBrInst(IndirectBrInst &I); |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 94 | void visitExtractElementInst(ExtractElementInst &I); |
| 95 | void visitInsertElementInst(InsertElementInst &I); |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 96 | void visitUnreachableInst(UnreachableInst &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 97 | |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 98 | Value *findValue(Value *V, bool OffsetOk) const; |
Dan Gohman | 17d9596 | 2010-05-28 16:45:33 +0000 | [diff] [blame] | 99 | Value *findValueImpl(Value *V, bool OffsetOk, |
| 100 | SmallPtrSet<Value *, 4> &Visited) const; |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 101 | |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 102 | public: |
| 103 | Module *Mod; |
| 104 | AliasAnalysis *AA; |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 105 | DominatorTree *DT; |
Micah Villmow | 3574eca | 2012-10-08 16:38:25 +0000 | [diff] [blame] | 106 | DataLayout *TD; |
Chad Rosier | 618c1db | 2011-12-01 03:08:23 +0000 | [diff] [blame] | 107 | TargetLibraryInfo *TLI; |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 108 | |
| 109 | std::string Messages; |
| 110 | raw_string_ostream MessagesStr; |
| 111 | |
| 112 | static char ID; // Pass identification, replacement for typeid |
Owen Anderson | 081c34b | 2010-10-19 17:21:58 +0000 | [diff] [blame] | 113 | Lint() : FunctionPass(ID), MessagesStr(Messages) { |
| 114 | initializeLintPass(*PassRegistry::getPassRegistry()); |
| 115 | } |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 116 | |
| 117 | virtual bool runOnFunction(Function &F); |
| 118 | |
| 119 | virtual void getAnalysisUsage(AnalysisUsage &AU) const { |
| 120 | AU.setPreservesAll(); |
| 121 | AU.addRequired<AliasAnalysis>(); |
Chad Rosier | 618c1db | 2011-12-01 03:08:23 +0000 | [diff] [blame] | 122 | AU.addRequired<TargetLibraryInfo>(); |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 123 | AU.addRequired<DominatorTree>(); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 124 | } |
| 125 | virtual void print(raw_ostream &O, const Module *M) const {} |
| 126 | |
| 127 | void WriteValue(const Value *V) { |
| 128 | if (!V) return; |
| 129 | if (isa<Instruction>(V)) { |
| 130 | MessagesStr << *V << '\n'; |
| 131 | } else { |
| 132 | WriteAsOperand(MessagesStr, V, true, Mod); |
| 133 | MessagesStr << '\n'; |
| 134 | } |
| 135 | } |
| 136 | |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 137 | // CheckFailed - A check failed, so print out the condition and the message |
| 138 | // that failed. This provides a nice place to put a breakpoint if you want |
| 139 | // to see why something is not correct. |
| 140 | void CheckFailed(const Twine &Message, |
| 141 | const Value *V1 = 0, const Value *V2 = 0, |
| 142 | const Value *V3 = 0, const Value *V4 = 0) { |
| 143 | MessagesStr << Message.str() << "\n"; |
| 144 | WriteValue(V1); |
| 145 | WriteValue(V2); |
| 146 | WriteValue(V3); |
| 147 | WriteValue(V4); |
| 148 | } |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 149 | }; |
| 150 | } |
| 151 | |
| 152 | char Lint::ID = 0; |
Owen Anderson | 2ab36d3 | 2010-10-12 19:48:12 +0000 | [diff] [blame] | 153 | INITIALIZE_PASS_BEGIN(Lint, "lint", "Statically lint-checks LLVM IR", |
| 154 | false, true) |
Chad Rosier | 618c1db | 2011-12-01 03:08:23 +0000 | [diff] [blame] | 155 | INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfo) |
Owen Anderson | 2ab36d3 | 2010-10-12 19:48:12 +0000 | [diff] [blame] | 156 | INITIALIZE_PASS_DEPENDENCY(DominatorTree) |
| 157 | INITIALIZE_AG_DEPENDENCY(AliasAnalysis) |
| 158 | INITIALIZE_PASS_END(Lint, "lint", "Statically lint-checks LLVM IR", |
| 159 | false, true) |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 160 | |
| 161 | // Assert - We know that cond should be true, if not print an error message. |
| 162 | #define Assert(C, M) \ |
| 163 | do { if (!(C)) { CheckFailed(M); return; } } while (0) |
| 164 | #define Assert1(C, M, V1) \ |
| 165 | do { if (!(C)) { CheckFailed(M, V1); return; } } while (0) |
| 166 | #define Assert2(C, M, V1, V2) \ |
| 167 | do { if (!(C)) { CheckFailed(M, V1, V2); return; } } while (0) |
| 168 | #define Assert3(C, M, V1, V2, V3) \ |
| 169 | do { if (!(C)) { CheckFailed(M, V1, V2, V3); return; } } while (0) |
| 170 | #define Assert4(C, M, V1, V2, V3, V4) \ |
| 171 | do { if (!(C)) { CheckFailed(M, V1, V2, V3, V4); return; } } while (0) |
| 172 | |
| 173 | // Lint::run - This is the main Analysis entry point for a |
| 174 | // function. |
| 175 | // |
| 176 | bool Lint::runOnFunction(Function &F) { |
| 177 | Mod = F.getParent(); |
| 178 | AA = &getAnalysis<AliasAnalysis>(); |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 179 | DT = &getAnalysis<DominatorTree>(); |
Micah Villmow | 3574eca | 2012-10-08 16:38:25 +0000 | [diff] [blame] | 180 | TD = getAnalysisIfAvailable<DataLayout>(); |
Chad Rosier | 618c1db | 2011-12-01 03:08:23 +0000 | [diff] [blame] | 181 | TLI = &getAnalysis<TargetLibraryInfo>(); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 182 | visit(F); |
| 183 | dbgs() << MessagesStr.str(); |
Dan Gohman | a0f7ff3 | 2010-05-26 22:28:53 +0000 | [diff] [blame] | 184 | Messages.clear(); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 185 | return false; |
| 186 | } |
| 187 | |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 188 | void Lint::visitFunction(Function &F) { |
| 189 | // This isn't undefined behavior, it's just a little unusual, and it's a |
| 190 | // fairly common mistake to neglect to name a function. |
| 191 | Assert1(F.hasName() || F.hasLocalLinkage(), |
| 192 | "Unusual: Unnamed function with non-local linkage", &F); |
Dan Gohman | 0ce2499 | 2010-07-06 15:23:00 +0000 | [diff] [blame] | 193 | |
| 194 | // TODO: Check for irreducible control flow. |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 195 | } |
| 196 | |
| 197 | void Lint::visitCallSite(CallSite CS) { |
| 198 | Instruction &I = *CS.getInstruction(); |
| 199 | Value *Callee = CS.getCalledValue(); |
| 200 | |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 201 | visitMemoryReference(I, Callee, AliasAnalysis::UnknownSize, |
| 202 | 0, 0, MemRef::Callee); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 203 | |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 204 | if (Function *F = dyn_cast<Function>(findValue(Callee, /*OffsetOk=*/false))) { |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 205 | Assert1(CS.getCallingConv() == F->getCallingConv(), |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 206 | "Undefined behavior: Caller and callee calling convention differ", |
| 207 | &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 208 | |
Chris Lattner | db125cf | 2011-07-18 04:54:35 +0000 | [diff] [blame] | 209 | FunctionType *FT = F->getFunctionType(); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 210 | unsigned NumActualArgs = unsigned(CS.arg_end()-CS.arg_begin()); |
| 211 | |
| 212 | Assert1(FT->isVarArg() ? |
| 213 | FT->getNumParams() <= NumActualArgs : |
| 214 | FT->getNumParams() == NumActualArgs, |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 215 | "Undefined behavior: Call argument count mismatches callee " |
| 216 | "argument count", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 217 | |
Dan Gohman | 545d006 | 2010-07-12 18:02:04 +0000 | [diff] [blame] | 218 | Assert1(FT->getReturnType() == I.getType(), |
| 219 | "Undefined behavior: Call return type mismatches " |
| 220 | "callee return type", &I); |
| 221 | |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 222 | // Check argument types (in case the callee was casted) and attributes. |
Dan Gohman | 0ce2499 | 2010-07-06 15:23:00 +0000 | [diff] [blame] | 223 | // TODO: Verify that caller and callee attributes are compatible. |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 224 | Function::arg_iterator PI = F->arg_begin(), PE = F->arg_end(); |
| 225 | CallSite::arg_iterator AI = CS.arg_begin(), AE = CS.arg_end(); |
| 226 | for (; AI != AE; ++AI) { |
| 227 | Value *Actual = *AI; |
| 228 | if (PI != PE) { |
| 229 | Argument *Formal = PI++; |
| 230 | Assert1(Formal->getType() == Actual->getType(), |
| 231 | "Undefined behavior: Call argument type mismatches " |
| 232 | "callee parameter type", &I); |
Dan Gohman | 10e7726 | 2010-06-01 20:51:40 +0000 | [diff] [blame] | 233 | |
Dan Gohman | c1f1efd | 2010-12-13 22:53:18 +0000 | [diff] [blame] | 234 | // Check that noalias arguments don't alias other arguments. This is |
| 235 | // not fully precise because we don't know the sizes of the dereferenced |
| 236 | // memory regions. |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 237 | if (Formal->hasNoAliasAttr() && Actual->getType()->isPointerTy()) |
Dan Gohman | f3b8c76 | 2010-11-11 19:23:51 +0000 | [diff] [blame] | 238 | for (CallSite::arg_iterator BI = CS.arg_begin(); BI != AE; ++BI) |
Dan Gohman | 4a2a3ea | 2010-12-10 20:04:06 +0000 | [diff] [blame] | 239 | if (AI != BI && (*BI)->getType()->isPointerTy()) { |
| 240 | AliasAnalysis::AliasResult Result = AA->alias(*AI, *BI); |
| 241 | Assert1(Result != AliasAnalysis::MustAlias && |
| 242 | Result != AliasAnalysis::PartialAlias, |
| 243 | "Unusual: noalias argument aliases another argument", &I); |
| 244 | } |
Dan Gohman | 10e7726 | 2010-06-01 20:51:40 +0000 | [diff] [blame] | 245 | |
| 246 | // Check that an sret argument points to valid memory. |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 247 | if (Formal->hasStructRetAttr() && Actual->getType()->isPointerTy()) { |
Chris Lattner | db125cf | 2011-07-18 04:54:35 +0000 | [diff] [blame] | 248 | Type *Ty = |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 249 | cast<PointerType>(Formal->getType())->getElementType(); |
| 250 | visitMemoryReference(I, Actual, AA->getTypeStoreSize(Ty), |
| 251 | TD ? TD->getABITypeAlignment(Ty) : 0, |
| 252 | Ty, MemRef::Read | MemRef::Write); |
| 253 | } |
| 254 | } |
| 255 | } |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 256 | } |
| 257 | |
Dan Gohman | 113b3e2 | 2010-05-26 21:46:36 +0000 | [diff] [blame] | 258 | if (CS.isCall() && cast<CallInst>(CS.getInstruction())->isTailCall()) |
| 259 | for (CallSite::arg_iterator AI = CS.arg_begin(), AE = CS.arg_end(); |
| 260 | AI != AE; ++AI) { |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 261 | Value *Obj = findValue(*AI, /*OffsetOk=*/true); |
Dan Gohman | 078f859 | 2010-05-28 16:34:49 +0000 | [diff] [blame] | 262 | Assert1(!isa<AllocaInst>(Obj), |
Dan Gohman | 113b3e2 | 2010-05-26 21:46:36 +0000 | [diff] [blame] | 263 | "Undefined behavior: Call with \"tail\" keyword references " |
Dan Gohman | 078f859 | 2010-05-28 16:34:49 +0000 | [diff] [blame] | 264 | "alloca", &I); |
Dan Gohman | 113b3e2 | 2010-05-26 21:46:36 +0000 | [diff] [blame] | 265 | } |
| 266 | |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 267 | |
| 268 | if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(&I)) |
| 269 | switch (II->getIntrinsicID()) { |
| 270 | default: break; |
| 271 | |
| 272 | // TODO: Check more intrinsics |
| 273 | |
| 274 | case Intrinsic::memcpy: { |
| 275 | MemCpyInst *MCI = cast<MemCpyInst>(&I); |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 276 | // TODO: If the size is known, use it. |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 277 | visitMemoryReference(I, MCI->getDest(), AliasAnalysis::UnknownSize, |
| 278 | MCI->getAlignment(), 0, |
Dan Gohman | 13ec30b | 2010-05-28 17:44:00 +0000 | [diff] [blame] | 279 | MemRef::Write); |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 280 | visitMemoryReference(I, MCI->getSource(), AliasAnalysis::UnknownSize, |
| 281 | MCI->getAlignment(), 0, |
Dan Gohman | 5b61b38 | 2010-04-30 19:05:00 +0000 | [diff] [blame] | 282 | MemRef::Read); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 283 | |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 284 | // Check that the memcpy arguments don't overlap. The AliasAnalysis API |
| 285 | // isn't expressive enough for what we really want to do. Known partial |
| 286 | // overlap is not distinguished from the case where nothing is known. |
Dan Gohman | 3da848b | 2010-10-19 22:54:46 +0000 | [diff] [blame] | 287 | uint64_t Size = 0; |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 288 | if (const ConstantInt *Len = |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 289 | dyn_cast<ConstantInt>(findValue(MCI->getLength(), |
| 290 | /*OffsetOk=*/false))) |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 291 | if (Len->getValue().isIntN(32)) |
| 292 | Size = Len->getValue().getZExtValue(); |
| 293 | Assert1(AA->alias(MCI->getSource(), Size, MCI->getDest(), Size) != |
| 294 | AliasAnalysis::MustAlias, |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 295 | "Undefined behavior: memcpy source and destination overlap", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 296 | break; |
| 297 | } |
| 298 | case Intrinsic::memmove: { |
| 299 | MemMoveInst *MMI = cast<MemMoveInst>(&I); |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 300 | // TODO: If the size is known, use it. |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 301 | visitMemoryReference(I, MMI->getDest(), AliasAnalysis::UnknownSize, |
| 302 | MMI->getAlignment(), 0, |
Dan Gohman | 13ec30b | 2010-05-28 17:44:00 +0000 | [diff] [blame] | 303 | MemRef::Write); |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 304 | visitMemoryReference(I, MMI->getSource(), AliasAnalysis::UnknownSize, |
| 305 | MMI->getAlignment(), 0, |
Dan Gohman | 5b61b38 | 2010-04-30 19:05:00 +0000 | [diff] [blame] | 306 | MemRef::Read); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 307 | break; |
| 308 | } |
| 309 | case Intrinsic::memset: { |
| 310 | MemSetInst *MSI = cast<MemSetInst>(&I); |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 311 | // TODO: If the size is known, use it. |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 312 | visitMemoryReference(I, MSI->getDest(), AliasAnalysis::UnknownSize, |
| 313 | MSI->getAlignment(), 0, |
Dan Gohman | 5b61b38 | 2010-04-30 19:05:00 +0000 | [diff] [blame] | 314 | MemRef::Write); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 315 | break; |
| 316 | } |
| 317 | |
| 318 | case Intrinsic::vastart: |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 319 | Assert1(I.getParent()->getParent()->isVarArg(), |
| 320 | "Undefined behavior: va_start called in a non-varargs function", |
| 321 | &I); |
| 322 | |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 323 | visitMemoryReference(I, CS.getArgument(0), AliasAnalysis::UnknownSize, |
| 324 | 0, 0, MemRef::Read | MemRef::Write); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 325 | break; |
| 326 | case Intrinsic::vacopy: |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 327 | visitMemoryReference(I, CS.getArgument(0), AliasAnalysis::UnknownSize, |
| 328 | 0, 0, MemRef::Write); |
| 329 | visitMemoryReference(I, CS.getArgument(1), AliasAnalysis::UnknownSize, |
| 330 | 0, 0, MemRef::Read); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 331 | break; |
| 332 | case Intrinsic::vaend: |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 333 | visitMemoryReference(I, CS.getArgument(0), AliasAnalysis::UnknownSize, |
| 334 | 0, 0, MemRef::Read | MemRef::Write); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 335 | break; |
Dan Gohman | 882ddb4 | 2010-05-26 22:21:25 +0000 | [diff] [blame] | 336 | |
| 337 | case Intrinsic::stackrestore: |
| 338 | // Stackrestore doesn't read or write memory, but it sets the |
| 339 | // stack pointer, which the compiler may read from or write to |
| 340 | // at any time, so check it for both readability and writeability. |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 341 | visitMemoryReference(I, CS.getArgument(0), AliasAnalysis::UnknownSize, |
| 342 | 0, 0, MemRef::Read | MemRef::Write); |
Dan Gohman | 882ddb4 | 2010-05-26 22:21:25 +0000 | [diff] [blame] | 343 | break; |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 344 | } |
| 345 | } |
| 346 | |
| 347 | void Lint::visitCallInst(CallInst &I) { |
| 348 | return visitCallSite(&I); |
| 349 | } |
| 350 | |
| 351 | void Lint::visitInvokeInst(InvokeInst &I) { |
| 352 | return visitCallSite(&I); |
| 353 | } |
| 354 | |
| 355 | void Lint::visitReturnInst(ReturnInst &I) { |
| 356 | Function *F = I.getParent()->getParent(); |
| 357 | Assert1(!F->doesNotReturn(), |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 358 | "Unusual: Return statement in function with noreturn attribute", |
| 359 | &I); |
Dan Gohman | 292fc87 | 2010-05-28 04:33:42 +0000 | [diff] [blame] | 360 | |
| 361 | if (Value *V = I.getReturnValue()) { |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 362 | Value *Obj = findValue(V, /*OffsetOk=*/true); |
Dan Gohman | 078f859 | 2010-05-28 16:34:49 +0000 | [diff] [blame] | 363 | Assert1(!isa<AllocaInst>(Obj), |
| 364 | "Unusual: Returning alloca value", &I); |
Dan Gohman | 292fc87 | 2010-05-28 04:33:42 +0000 | [diff] [blame] | 365 | } |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 366 | } |
| 367 | |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 368 | // TODO: Check that the reference is in bounds. |
Dan Gohman | 0ce2499 | 2010-07-06 15:23:00 +0000 | [diff] [blame] | 369 | // TODO: Check readnone/readonly function attributes. |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 370 | void Lint::visitMemoryReference(Instruction &I, |
Dan Gohman | 3da848b | 2010-10-19 22:54:46 +0000 | [diff] [blame] | 371 | Value *Ptr, uint64_t Size, unsigned Align, |
Chris Lattner | db125cf | 2011-07-18 04:54:35 +0000 | [diff] [blame] | 372 | Type *Ty, unsigned Flags) { |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 373 | // If no memory is being referenced, it doesn't matter if the pointer |
| 374 | // is valid. |
| 375 | if (Size == 0) |
| 376 | return; |
| 377 | |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 378 | Value *UnderlyingObject = findValue(Ptr, /*OffsetOk=*/true); |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 379 | Assert1(!isa<ConstantPointerNull>(UnderlyingObject), |
| 380 | "Undefined behavior: Null pointer dereference", &I); |
| 381 | Assert1(!isa<UndefValue>(UnderlyingObject), |
| 382 | "Undefined behavior: Undef pointer dereference", &I); |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 383 | Assert1(!isa<ConstantInt>(UnderlyingObject) || |
| 384 | !cast<ConstantInt>(UnderlyingObject)->isAllOnesValue(), |
| 385 | "Unusual: All-ones pointer dereference", &I); |
| 386 | Assert1(!isa<ConstantInt>(UnderlyingObject) || |
| 387 | !cast<ConstantInt>(UnderlyingObject)->isOne(), |
| 388 | "Unusual: Address one pointer dereference", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 389 | |
Dan Gohman | 5b61b38 | 2010-04-30 19:05:00 +0000 | [diff] [blame] | 390 | if (Flags & MemRef::Write) { |
| 391 | if (const GlobalVariable *GV = dyn_cast<GlobalVariable>(UnderlyingObject)) |
| 392 | Assert1(!GV->isConstant(), |
| 393 | "Undefined behavior: Write to read-only memory", &I); |
| 394 | Assert1(!isa<Function>(UnderlyingObject) && |
| 395 | !isa<BlockAddress>(UnderlyingObject), |
| 396 | "Undefined behavior: Write to text section", &I); |
| 397 | } |
| 398 | if (Flags & MemRef::Read) { |
| 399 | Assert1(!isa<Function>(UnderlyingObject), |
| 400 | "Unusual: Load from function body", &I); |
| 401 | Assert1(!isa<BlockAddress>(UnderlyingObject), |
| 402 | "Undefined behavior: Load from block address", &I); |
| 403 | } |
| 404 | if (Flags & MemRef::Callee) { |
| 405 | Assert1(!isa<BlockAddress>(UnderlyingObject), |
| 406 | "Undefined behavior: Call to block address", &I); |
| 407 | } |
| 408 | if (Flags & MemRef::Branchee) { |
| 409 | Assert1(!isa<Constant>(UnderlyingObject) || |
| 410 | isa<BlockAddress>(UnderlyingObject), |
| 411 | "Undefined behavior: Branch to non-blockaddress", &I); |
| 412 | } |
| 413 | |
Duncan Sands | c7c42f7 | 2012-09-26 07:45:36 +0000 | [diff] [blame] | 414 | // Check for buffer overflows and misalignment. |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 415 | if (TD) { |
Duncan Sands | c7c42f7 | 2012-09-26 07:45:36 +0000 | [diff] [blame] | 416 | // Only handles memory references that read/write something simple like an |
| 417 | // alloca instruction or a global variable. |
| 418 | int64_t Offset = 0; |
| 419 | if (Value *Base = GetPointerBaseWithConstantOffset(Ptr, Offset, *TD)) { |
| 420 | // OK, so the access is to a constant offset from Ptr. Check that Ptr is |
| 421 | // something we can handle and if so extract the size of this base object |
| 422 | // along with its alignment. |
| 423 | uint64_t BaseSize = AliasAnalysis::UnknownSize; |
| 424 | unsigned BaseAlign = 0; |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 425 | |
Duncan Sands | c7c42f7 | 2012-09-26 07:45:36 +0000 | [diff] [blame] | 426 | if (AllocaInst *AI = dyn_cast<AllocaInst>(Base)) { |
| 427 | Type *ATy = AI->getAllocatedType(); |
| 428 | if (!AI->isArrayAllocation() && ATy->isSized()) |
| 429 | BaseSize = TD->getTypeAllocSize(ATy); |
| 430 | BaseAlign = AI->getAlignment(); |
| 431 | if (BaseAlign == 0 && ATy->isSized()) |
| 432 | BaseAlign = TD->getABITypeAlignment(ATy); |
Duncan Sands | b620469 | 2012-09-30 07:30:10 +0000 | [diff] [blame] | 433 | } else if (GlobalVariable *GV = dyn_cast<GlobalVariable>(Base)) { |
| 434 | // If the global may be defined differently in another compilation unit |
| 435 | // then don't warn about funky memory accesses. |
| 436 | if (GV->hasDefinitiveInitializer()) { |
| 437 | Type *GTy = GV->getType()->getElementType(); |
| 438 | if (GTy->isSized()) |
| 439 | BaseSize = TD->getTypeAllocSize(GTy); |
| 440 | BaseAlign = GV->getAlignment(); |
| 441 | if (BaseAlign == 0 && GTy->isSized()) |
| 442 | BaseAlign = TD->getABITypeAlignment(GTy); |
| 443 | } |
Duncan Sands | 00edf4c | 2012-09-25 10:00:49 +0000 | [diff] [blame] | 444 | } |
Duncan Sands | c7c42f7 | 2012-09-26 07:45:36 +0000 | [diff] [blame] | 445 | |
| 446 | // Accesses from before the start or after the end of the object are not |
| 447 | // defined. |
| 448 | Assert1(Size == AliasAnalysis::UnknownSize || |
| 449 | BaseSize == AliasAnalysis::UnknownSize || |
| 450 | (Offset >= 0 && Offset + Size <= BaseSize), |
| 451 | "Undefined behavior: Buffer overflow", &I); |
| 452 | |
| 453 | // Accesses that say that the memory is more aligned than it is are not |
| 454 | // defined. |
| 455 | if (Align == 0 && Ty && Ty->isSized()) |
| 456 | Align = TD->getABITypeAlignment(Ty); |
| 457 | Assert1(!BaseAlign || Align <= MinAlign(BaseAlign, Offset), |
| 458 | "Undefined behavior: Memory reference address is misaligned", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 459 | } |
| 460 | } |
| 461 | } |
| 462 | |
| 463 | void Lint::visitLoadInst(LoadInst &I) { |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 464 | visitMemoryReference(I, I.getPointerOperand(), |
| 465 | AA->getTypeStoreSize(I.getType()), I.getAlignment(), |
| 466 | I.getType(), MemRef::Read); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 467 | } |
| 468 | |
| 469 | void Lint::visitStoreInst(StoreInst &I) { |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 470 | visitMemoryReference(I, I.getPointerOperand(), |
| 471 | AA->getTypeStoreSize(I.getOperand(0)->getType()), |
| 472 | I.getAlignment(), |
| 473 | I.getOperand(0)->getType(), MemRef::Write); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 474 | } |
| 475 | |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 476 | void Lint::visitXor(BinaryOperator &I) { |
| 477 | Assert1(!isa<UndefValue>(I.getOperand(0)) || |
| 478 | !isa<UndefValue>(I.getOperand(1)), |
| 479 | "Undefined result: xor(undef, undef)", &I); |
| 480 | } |
| 481 | |
| 482 | void Lint::visitSub(BinaryOperator &I) { |
| 483 | Assert1(!isa<UndefValue>(I.getOperand(0)) || |
| 484 | !isa<UndefValue>(I.getOperand(1)), |
| 485 | "Undefined result: sub(undef, undef)", &I); |
| 486 | } |
| 487 | |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 488 | void Lint::visitLShr(BinaryOperator &I) { |
| 489 | if (ConstantInt *CI = |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 490 | dyn_cast<ConstantInt>(findValue(I.getOperand(1), /*OffsetOk=*/false))) |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 491 | Assert1(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()), |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 492 | "Undefined result: Shift count out of range", &I); |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 493 | } |
| 494 | |
| 495 | void Lint::visitAShr(BinaryOperator &I) { |
| 496 | if (ConstantInt *CI = |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 497 | dyn_cast<ConstantInt>(findValue(I.getOperand(1), /*OffsetOk=*/false))) |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 498 | Assert1(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()), |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 499 | "Undefined result: Shift count out of range", &I); |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 500 | } |
| 501 | |
| 502 | void Lint::visitShl(BinaryOperator &I) { |
| 503 | if (ConstantInt *CI = |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 504 | dyn_cast<ConstantInt>(findValue(I.getOperand(1), /*OffsetOk=*/false))) |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 505 | Assert1(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()), |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 506 | "Undefined result: Shift count out of range", &I); |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 507 | } |
| 508 | |
Micah Villmow | 3574eca | 2012-10-08 16:38:25 +0000 | [diff] [blame] | 509 | static bool isZero(Value *V, DataLayout *TD) { |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 510 | // Assume undef could be zero. |
| 511 | if (isa<UndefValue>(V)) return true; |
| 512 | |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 513 | unsigned BitWidth = cast<IntegerType>(V->getType())->getBitWidth(); |
Rafael Espindola | 26c8dcc | 2012-04-04 12:51:34 +0000 | [diff] [blame] | 514 | APInt KnownZero(BitWidth, 0), KnownOne(BitWidth, 0); |
| 515 | ComputeMaskedBits(V, KnownZero, KnownOne, TD); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 516 | return KnownZero.isAllOnesValue(); |
| 517 | } |
| 518 | |
| 519 | void Lint::visitSDiv(BinaryOperator &I) { |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 520 | Assert1(!isZero(I.getOperand(1), TD), |
| 521 | "Undefined behavior: Division by zero", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 522 | } |
| 523 | |
| 524 | void Lint::visitUDiv(BinaryOperator &I) { |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 525 | Assert1(!isZero(I.getOperand(1), TD), |
| 526 | "Undefined behavior: Division by zero", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 527 | } |
| 528 | |
| 529 | void Lint::visitSRem(BinaryOperator &I) { |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 530 | Assert1(!isZero(I.getOperand(1), TD), |
| 531 | "Undefined behavior: Division by zero", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 532 | } |
| 533 | |
| 534 | void Lint::visitURem(BinaryOperator &I) { |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 535 | Assert1(!isZero(I.getOperand(1), TD), |
| 536 | "Undefined behavior: Division by zero", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 537 | } |
| 538 | |
| 539 | void Lint::visitAllocaInst(AllocaInst &I) { |
| 540 | if (isa<ConstantInt>(I.getArraySize())) |
| 541 | // This isn't undefined behavior, it's just an obvious pessimization. |
| 542 | Assert1(&I.getParent()->getParent()->getEntryBlock() == I.getParent(), |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 543 | "Pessimization: Static alloca outside of entry block", &I); |
Dan Gohman | 0ce2499 | 2010-07-06 15:23:00 +0000 | [diff] [blame] | 544 | |
| 545 | // TODO: Check for an unusual size (MSB set?) |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 546 | } |
| 547 | |
| 548 | void Lint::visitVAArgInst(VAArgInst &I) { |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 549 | visitMemoryReference(I, I.getOperand(0), AliasAnalysis::UnknownSize, 0, 0, |
Dan Gohman | 5b61b38 | 2010-04-30 19:05:00 +0000 | [diff] [blame] | 550 | MemRef::Read | MemRef::Write); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 551 | } |
| 552 | |
| 553 | void Lint::visitIndirectBrInst(IndirectBrInst &I) { |
Dan Gohman | f3a925d | 2010-10-19 17:06:23 +0000 | [diff] [blame] | 554 | visitMemoryReference(I, I.getAddress(), AliasAnalysis::UnknownSize, 0, 0, |
| 555 | MemRef::Branchee); |
Dan Gohman | a8afb2a | 2010-08-02 23:06:43 +0000 | [diff] [blame] | 556 | |
| 557 | Assert1(I.getNumDestinations() != 0, |
| 558 | "Undefined behavior: indirectbr with no destinations", &I); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 559 | } |
| 560 | |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 561 | void Lint::visitExtractElementInst(ExtractElementInst &I) { |
| 562 | if (ConstantInt *CI = |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 563 | dyn_cast<ConstantInt>(findValue(I.getIndexOperand(), |
| 564 | /*OffsetOk=*/false))) |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 565 | Assert1(CI->getValue().ult(I.getVectorOperandType()->getNumElements()), |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 566 | "Undefined result: extractelement index out of range", &I); |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 567 | } |
| 568 | |
| 569 | void Lint::visitInsertElementInst(InsertElementInst &I) { |
| 570 | if (ConstantInt *CI = |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 571 | dyn_cast<ConstantInt>(findValue(I.getOperand(2), |
| 572 | /*OffsetOk=*/false))) |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 573 | Assert1(CI->getValue().ult(I.getType()->getNumElements()), |
Dan Gohman | be02b20 | 2010-04-09 01:39:53 +0000 | [diff] [blame] | 574 | "Undefined result: insertelement index out of range", &I); |
| 575 | } |
| 576 | |
| 577 | void Lint::visitUnreachableInst(UnreachableInst &I) { |
| 578 | // This isn't undefined behavior, it's merely suspicious. |
| 579 | Assert1(&I == I.getParent()->begin() || |
| 580 | prior(BasicBlock::iterator(&I))->mayHaveSideEffects(), |
| 581 | "Unusual: unreachable immediately preceded by instruction without " |
| 582 | "side effects", &I); |
Dan Gohman | dd98c4d | 2010-04-08 23:05:57 +0000 | [diff] [blame] | 583 | } |
| 584 | |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 585 | /// findValue - Look through bitcasts and simple memory reference patterns |
| 586 | /// to identify an equivalent, but more informative, value. If OffsetOk |
| 587 | /// is true, look through getelementptrs with non-zero offsets too. |
| 588 | /// |
| 589 | /// Most analysis passes don't require this logic, because instcombine |
| 590 | /// will simplify most of these kinds of things away. But it's a goal of |
| 591 | /// this Lint pass to be useful even on non-optimized IR. |
| 592 | Value *Lint::findValue(Value *V, bool OffsetOk) const { |
Dan Gohman | 17d9596 | 2010-05-28 16:45:33 +0000 | [diff] [blame] | 593 | SmallPtrSet<Value *, 4> Visited; |
| 594 | return findValueImpl(V, OffsetOk, Visited); |
| 595 | } |
| 596 | |
| 597 | /// findValueImpl - Implementation helper for findValue. |
| 598 | Value *Lint::findValueImpl(Value *V, bool OffsetOk, |
| 599 | SmallPtrSet<Value *, 4> &Visited) const { |
| 600 | // Detect self-referential values. |
| 601 | if (!Visited.insert(V)) |
| 602 | return UndefValue::get(V->getType()); |
| 603 | |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 604 | // TODO: Look through sext or zext cast, when the result is known to |
| 605 | // be interpreted as signed or unsigned, respectively. |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 606 | // TODO: Look through eliminable cast pairs. |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 607 | // TODO: Look through calls with unique return values. |
| 608 | // TODO: Look through vector insert/extract/shuffle. |
Dan Gohman | bd1801b | 2011-01-24 18:53:32 +0000 | [diff] [blame] | 609 | V = OffsetOk ? GetUnderlyingObject(V, TD) : V->stripPointerCasts(); |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 610 | if (LoadInst *L = dyn_cast<LoadInst>(V)) { |
| 611 | BasicBlock::iterator BBI = L; |
| 612 | BasicBlock *BB = L->getParent(); |
Dan Gohman | 13ec30b | 2010-05-28 17:44:00 +0000 | [diff] [blame] | 613 | SmallPtrSet<BasicBlock *, 4> VisitedBlocks; |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 614 | for (;;) { |
Dan Gohman | 13ec30b | 2010-05-28 17:44:00 +0000 | [diff] [blame] | 615 | if (!VisitedBlocks.insert(BB)) break; |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 616 | if (Value *U = FindAvailableLoadedValue(L->getPointerOperand(), |
| 617 | BB, BBI, 6, AA)) |
Dan Gohman | 17d9596 | 2010-05-28 16:45:33 +0000 | [diff] [blame] | 618 | return findValueImpl(U, OffsetOk, Visited); |
Dan Gohman | 13ec30b | 2010-05-28 17:44:00 +0000 | [diff] [blame] | 619 | if (BBI != BB->begin()) break; |
| 620 | BB = BB->getUniquePredecessor(); |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 621 | if (!BB) break; |
| 622 | BBI = BB->end(); |
| 623 | } |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 624 | } else if (PHINode *PN = dyn_cast<PHINode>(V)) { |
Duncan Sands | ff10341 | 2010-11-17 04:30:22 +0000 | [diff] [blame] | 625 | if (Value *W = PN->hasConstantValue()) |
Duncan Sands | 23a1957 | 2010-11-17 10:23:23 +0000 | [diff] [blame] | 626 | if (W != V) |
| 627 | return findValueImpl(W, OffsetOk, Visited); |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 628 | } else if (CastInst *CI = dyn_cast<CastInst>(V)) { |
| 629 | if (CI->isNoopCast(TD ? TD->getIntPtrType(V->getContext()) : |
| 630 | Type::getInt64Ty(V->getContext()))) |
Dan Gohman | 17d9596 | 2010-05-28 16:45:33 +0000 | [diff] [blame] | 631 | return findValueImpl(CI->getOperand(0), OffsetOk, Visited); |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 632 | } else if (ExtractValueInst *Ex = dyn_cast<ExtractValueInst>(V)) { |
| 633 | if (Value *W = FindInsertedValue(Ex->getAggregateOperand(), |
Jay Foad | fc6d3a4 | 2011-07-13 10:26:04 +0000 | [diff] [blame] | 634 | Ex->getIndices())) |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 635 | if (W != V) |
Dan Gohman | 17d9596 | 2010-05-28 16:45:33 +0000 | [diff] [blame] | 636 | return findValueImpl(W, OffsetOk, Visited); |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 637 | } else if (ConstantExpr *CE = dyn_cast<ConstantExpr>(V)) { |
| 638 | // Same as above, but for ConstantExpr instead of Instruction. |
| 639 | if (Instruction::isCast(CE->getOpcode())) { |
| 640 | if (CastInst::isNoopCast(Instruction::CastOps(CE->getOpcode()), |
| 641 | CE->getOperand(0)->getType(), |
| 642 | CE->getType(), |
| 643 | TD ? TD->getIntPtrType(V->getContext()) : |
| 644 | Type::getInt64Ty(V->getContext()))) |
| 645 | return findValueImpl(CE->getOperand(0), OffsetOk, Visited); |
| 646 | } else if (CE->getOpcode() == Instruction::ExtractValue) { |
Jay Foad | d30aa5a | 2011-04-13 15:22:40 +0000 | [diff] [blame] | 647 | ArrayRef<unsigned> Indices = CE->getIndices(); |
Jay Foad | fc6d3a4 | 2011-07-13 10:26:04 +0000 | [diff] [blame] | 648 | if (Value *W = FindInsertedValue(CE->getOperand(0), Indices)) |
Dan Gohman | aec2a0d | 2010-05-28 21:43:57 +0000 | [diff] [blame] | 649 | if (W != V) |
| 650 | return findValueImpl(W, OffsetOk, Visited); |
| 651 | } |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 652 | } |
| 653 | |
| 654 | // As a last resort, try SimplifyInstruction or constant folding. |
| 655 | if (Instruction *Inst = dyn_cast<Instruction>(V)) { |
Chad Rosier | 618c1db | 2011-12-01 03:08:23 +0000 | [diff] [blame] | 656 | if (Value *W = SimplifyInstruction(Inst, TD, TLI, DT)) |
Duncan Sands | d261dc6 | 2010-11-17 08:35:29 +0000 | [diff] [blame] | 657 | return findValueImpl(W, OffsetOk, Visited); |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 658 | } else if (ConstantExpr *CE = dyn_cast<ConstantExpr>(V)) { |
Chad Rosier | aab8e28 | 2011-12-02 01:26:24 +0000 | [diff] [blame] | 659 | if (Value *W = ConstantFoldConstantExpression(CE, TD, TLI)) |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 660 | if (W != V) |
Dan Gohman | 17d9596 | 2010-05-28 16:45:33 +0000 | [diff] [blame] | 661 | return findValueImpl(W, OffsetOk, Visited); |
Dan Gohman | ff26d4e | 2010-05-28 16:21:24 +0000 | [diff] [blame] | 662 | } |
| 663 | |
| 664 | return V; |
| 665 | } |
| 666 | |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 667 | //===----------------------------------------------------------------------===// |
| 668 | // Implement the public interfaces to this file... |
| 669 | //===----------------------------------------------------------------------===// |
| 670 | |
| 671 | FunctionPass *llvm::createLintPass() { |
| 672 | return new Lint(); |
| 673 | } |
| 674 | |
| 675 | /// lintFunction - Check a function for errors, printing messages on stderr. |
| 676 | /// |
| 677 | void llvm::lintFunction(const Function &f) { |
| 678 | Function &F = const_cast<Function&>(f); |
| 679 | assert(!F.isDeclaration() && "Cannot lint external functions"); |
| 680 | |
| 681 | FunctionPassManager FPM(F.getParent()); |
| 682 | Lint *V = new Lint(); |
| 683 | FPM.add(V); |
| 684 | FPM.run(F); |
| 685 | } |
| 686 | |
| 687 | /// lintModule - Check a module for errors, printing messages on stderr. |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 688 | /// |
Dan Gohman | a0f7ff3 | 2010-05-26 22:28:53 +0000 | [diff] [blame] | 689 | void llvm::lintModule(const Module &M) { |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 690 | PassManager PM; |
| 691 | Lint *V = new Lint(); |
| 692 | PM.add(V); |
| 693 | PM.run(const_cast<Module&>(M)); |
Dan Gohman | 113902e | 2010-04-08 18:47:09 +0000 | [diff] [blame] | 694 | } |