blob: fdfe2cb30020e84cdc269bb1749faf8dcf538ba6 [file] [log] [blame]
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +00001//===-- MachineVerifier.cpp - Machine Code Verifier -------------*- C++ -*-===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// Pass to verify generated machine code. The following is checked:
11//
12// Operand counts: All explicit operands must be present.
13//
14// Register classes: All physical and virtual register operands must be
15// compatible with the register class required by the instruction descriptor.
16//
17// Register live intervals: Registers must be defined only once, and must be
18// defined before use.
19//
20// The machine code verifier is enabled from LLVMTargetMachine.cpp with the
21// command-line option -verify-machineinstrs, or by defining the environment
22// variable LLVM_VERIFY_MACHINEINSTRS to the name of a file that will receive
23// the verifier errors.
24//===----------------------------------------------------------------------===//
25
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000026#include "llvm/Function.h"
27#include "llvm/CodeGen/LiveVariables.h"
28#include "llvm/CodeGen/MachineFunctionPass.h"
Jakob Stoklund Olesena6b677d2009-08-13 16:19:51 +000029#include "llvm/CodeGen/MachineFrameInfo.h"
Dan Gohman2dbc4c82009-10-07 17:36:00 +000030#include "llvm/CodeGen/MachineMemOperand.h"
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000031#include "llvm/CodeGen/MachineRegisterInfo.h"
32#include "llvm/CodeGen/Passes.h"
33#include "llvm/Target/TargetMachine.h"
34#include "llvm/Target/TargetRegisterInfo.h"
35#include "llvm/Target/TargetInstrInfo.h"
Chris Lattnercf143a42009-08-23 03:13:20 +000036#include "llvm/ADT/DenseSet.h"
37#include "llvm/ADT/SetOperations.h"
38#include "llvm/ADT/SmallVector.h"
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000039#include "llvm/Support/Debug.h"
Torok Edwin7d696d82009-07-11 13:10:19 +000040#include "llvm/Support/ErrorHandling.h"
41#include "llvm/Support/raw_ostream.h"
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000042using namespace llvm;
43
44namespace {
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +000045 struct MachineVerifier {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000046
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +000047 MachineVerifier(Pass *pass, bool allowDoubleDefs) :
48 PASS(pass),
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000049 allowVirtDoubleDefs(allowDoubleDefs),
Jakob Stoklund Olesen1b2c7612010-05-14 20:28:32 +000050 allowPhysDoubleDefs(true),
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000051 OutFileName(getenv("LLVM_VERIFY_MACHINEINSTRS"))
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +000052 {}
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000053
54 bool runOnMachineFunction(MachineFunction &MF);
55
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +000056 Pass *const PASS;
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000057 const bool allowVirtDoubleDefs;
58 const bool allowPhysDoubleDefs;
59
60 const char *const OutFileName;
Chris Lattner17e9edc2009-08-23 02:51:22 +000061 raw_ostream *OS;
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000062 const MachineFunction *MF;
63 const TargetMachine *TM;
64 const TargetRegisterInfo *TRI;
65 const MachineRegisterInfo *MRI;
66
67 unsigned foundErrors;
68
69 typedef SmallVector<unsigned, 16> RegVector;
70 typedef DenseSet<unsigned> RegSet;
71 typedef DenseMap<unsigned, const MachineInstr*> RegMap;
72
73 BitVector regsReserved;
74 RegSet regsLive;
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +000075 RegVector regsDefined, regsDead, regsKilled;
76 RegSet regsLiveInButUnused;
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000077
78 // Add Reg and any sub-registers to RV
79 void addRegWithSubRegs(RegVector &RV, unsigned Reg) {
80 RV.push_back(Reg);
81 if (TargetRegisterInfo::isPhysicalRegister(Reg))
82 for (const unsigned *R = TRI->getSubRegisters(Reg); *R; R++)
83 RV.push_back(*R);
84 }
85
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +000086 struct BBInfo {
87 // Is this MBB reachable from the MF entry point?
88 bool reachable;
89
90 // Vregs that must be live in because they are used without being
91 // defined. Map value is the user.
92 RegMap vregsLiveIn;
93
94 // Vregs that must be dead in because they are defined without being
95 // killed first. Map value is the defining instruction.
96 RegMap vregsDeadIn;
97
98 // Regs killed in MBB. They may be defined again, and will then be in both
99 // regsKilled and regsLiveOut.
100 RegSet regsKilled;
101
102 // Regs defined in MBB and live out. Note that vregs passing through may
103 // be live out without being mentioned here.
104 RegSet regsLiveOut;
105
106 // Vregs that pass through MBB untouched. This set is disjoint from
107 // regsKilled and regsLiveOut.
108 RegSet vregsPassed;
109
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000110 // Vregs that must pass through MBB because they are needed by a successor
111 // block. This set is disjoint from regsLiveOut.
112 RegSet vregsRequired;
113
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000114 BBInfo() : reachable(false) {}
115
116 // Add register to vregsPassed if it belongs there. Return true if
117 // anything changed.
118 bool addPassed(unsigned Reg) {
119 if (!TargetRegisterInfo::isVirtualRegister(Reg))
120 return false;
121 if (regsKilled.count(Reg) || regsLiveOut.count(Reg))
122 return false;
123 return vregsPassed.insert(Reg).second;
124 }
125
126 // Same for a full set.
127 bool addPassed(const RegSet &RS) {
128 bool changed = false;
129 for (RegSet::const_iterator I = RS.begin(), E = RS.end(); I != E; ++I)
130 if (addPassed(*I))
131 changed = true;
132 return changed;
133 }
134
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000135 // Add register to vregsRequired if it belongs there. Return true if
136 // anything changed.
137 bool addRequired(unsigned Reg) {
138 if (!TargetRegisterInfo::isVirtualRegister(Reg))
139 return false;
140 if (regsLiveOut.count(Reg))
141 return false;
142 return vregsRequired.insert(Reg).second;
143 }
144
145 // Same for a full set.
146 bool addRequired(const RegSet &RS) {
147 bool changed = false;
148 for (RegSet::const_iterator I = RS.begin(), E = RS.end(); I != E; ++I)
149 if (addRequired(*I))
150 changed = true;
151 return changed;
152 }
153
154 // Same for a full map.
155 bool addRequired(const RegMap &RM) {
156 bool changed = false;
157 for (RegMap::const_iterator I = RM.begin(), E = RM.end(); I != E; ++I)
158 if (addRequired(I->first))
159 changed = true;
160 return changed;
161 }
162
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000163 // Live-out registers are either in regsLiveOut or vregsPassed.
164 bool isLiveOut(unsigned Reg) const {
165 return regsLiveOut.count(Reg) || vregsPassed.count(Reg);
166 }
167 };
168
169 // Extra register info per MBB.
170 DenseMap<const MachineBasicBlock*, BBInfo> MBBInfoMap;
171
172 bool isReserved(unsigned Reg) {
Jakob Stoklund Olesend37bc5a2009-08-04 19:18:01 +0000173 return Reg < regsReserved.size() && regsReserved.test(Reg);
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000174 }
175
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000176 // Analysis information if available
177 LiveVariables *LiveVars;
178
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000179 void visitMachineFunctionBefore();
180 void visitMachineBasicBlockBefore(const MachineBasicBlock *MBB);
181 void visitMachineInstrBefore(const MachineInstr *MI);
182 void visitMachineOperand(const MachineOperand *MO, unsigned MONum);
183 void visitMachineInstrAfter(const MachineInstr *MI);
184 void visitMachineBasicBlockAfter(const MachineBasicBlock *MBB);
185 void visitMachineFunctionAfter();
186
187 void report(const char *msg, const MachineFunction *MF);
188 void report(const char *msg, const MachineBasicBlock *MBB);
189 void report(const char *msg, const MachineInstr *MI);
190 void report(const char *msg, const MachineOperand *MO, unsigned MONum);
191
192 void markReachable(const MachineBasicBlock *MBB);
Jakob Stoklund Olesenb31defe2010-01-05 20:59:36 +0000193 void calcRegsPassed();
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000194 void checkPHIOps(const MachineBasicBlock *MBB);
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000195
196 void calcRegsRequired();
197 void verifyLiveVariables();
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000198 };
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000199
200 struct MachineVerifierPass : public MachineFunctionPass {
201 static char ID; // Pass ID, replacement for typeid
202 bool AllowDoubleDefs;
203
204 explicit MachineVerifierPass(bool allowDoubleDefs = false)
205 : MachineFunctionPass(&ID),
206 AllowDoubleDefs(allowDoubleDefs) {}
207
208 void getAnalysisUsage(AnalysisUsage &AU) const {
209 AU.setPreservesAll();
210 MachineFunctionPass::getAnalysisUsage(AU);
211 }
212
213 bool runOnMachineFunction(MachineFunction &MF) {
214 MF.verify(this, AllowDoubleDefs);
215 return false;
216 }
217 };
218
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000219}
220
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000221char MachineVerifierPass::ID = 0;
222static RegisterPass<MachineVerifierPass>
Jakob Stoklund Olesende67a512009-05-17 19:37:14 +0000223MachineVer("machineverifier", "Verify generated machine code");
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000224static const PassInfo *const MachineVerifyID = &MachineVer;
225
Chris Lattner17e9edc2009-08-23 02:51:22 +0000226FunctionPass *llvm::createMachineVerifierPass(bool allowPhysDoubleDefs) {
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000227 return new MachineVerifierPass(allowPhysDoubleDefs);
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000228}
229
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000230void MachineFunction::verify(Pass *p, bool allowDoubleDefs) const {
231 MachineVerifier(p, allowDoubleDefs)
232 .runOnMachineFunction(const_cast<MachineFunction&>(*this));
Jakob Stoklund Olesence727d02009-11-13 21:56:09 +0000233}
234
Chris Lattner17e9edc2009-08-23 02:51:22 +0000235bool MachineVerifier::runOnMachineFunction(MachineFunction &MF) {
236 raw_ostream *OutFile = 0;
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000237 if (OutFileName) {
Chris Lattner17e9edc2009-08-23 02:51:22 +0000238 std::string ErrorInfo;
239 OutFile = new raw_fd_ostream(OutFileName, ErrorInfo,
240 raw_fd_ostream::F_Append);
241 if (!ErrorInfo.empty()) {
242 errs() << "Error opening '" << OutFileName << "': " << ErrorInfo << '\n';
243 exit(1);
244 }
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000245
Chris Lattner17e9edc2009-08-23 02:51:22 +0000246 OS = OutFile;
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000247 } else {
Chris Lattner17e9edc2009-08-23 02:51:22 +0000248 OS = &errs();
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000249 }
250
251 foundErrors = 0;
252
253 this->MF = &MF;
254 TM = &MF.getTarget();
255 TRI = TM->getRegisterInfo();
256 MRI = &MF.getRegInfo();
257
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000258 if (PASS) {
259 LiveVars = PASS->getAnalysisIfAvailable<LiveVariables>();
260 } else {
261 LiveVars = NULL;
262 }
263
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000264 visitMachineFunctionBefore();
265 for (MachineFunction::const_iterator MFI = MF.begin(), MFE = MF.end();
266 MFI!=MFE; ++MFI) {
267 visitMachineBasicBlockBefore(MFI);
268 for (MachineBasicBlock::const_iterator MBBI = MFI->begin(),
269 MBBE = MFI->end(); MBBI != MBBE; ++MBBI) {
270 visitMachineInstrBefore(MBBI);
271 for (unsigned I = 0, E = MBBI->getNumOperands(); I != E; ++I)
272 visitMachineOperand(&MBBI->getOperand(I), I);
273 visitMachineInstrAfter(MBBI);
274 }
275 visitMachineBasicBlockAfter(MFI);
276 }
277 visitMachineFunctionAfter();
278
Chris Lattner17e9edc2009-08-23 02:51:22 +0000279 if (OutFile)
280 delete OutFile;
281 else if (foundErrors)
Chris Lattner75361b62010-04-07 22:58:41 +0000282 report_fatal_error("Found "+Twine(foundErrors)+" machine code errors.");
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000283
Jakob Stoklund Olesen63496682009-08-08 15:34:50 +0000284 // Clean up.
285 regsLive.clear();
286 regsDefined.clear();
287 regsDead.clear();
288 regsKilled.clear();
289 regsLiveInButUnused.clear();
290 MBBInfoMap.clear();
291
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000292 return false; // no changes
293}
294
Chris Lattner372fefe2009-08-23 01:03:30 +0000295void MachineVerifier::report(const char *msg, const MachineFunction *MF) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000296 assert(MF);
Chris Lattner17e9edc2009-08-23 02:51:22 +0000297 *OS << '\n';
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000298 if (!foundErrors++)
Chris Lattner372fefe2009-08-23 01:03:30 +0000299 MF->print(*OS);
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000300 *OS << "*** Bad machine code: " << msg << " ***\n"
Daniel Dunbarce63ffb2009-07-25 00:23:56 +0000301 << "- function: " << MF->getFunction()->getNameStr() << "\n";
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000302}
303
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000304void MachineVerifier::report(const char *msg, const MachineBasicBlock *MBB) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000305 assert(MBB);
306 report(msg, MBB->getParent());
Jakob Stoklund Olesen324da762009-11-20 01:17:03 +0000307 *OS << "- basic block: " << MBB->getName()
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000308 << " " << (void*)MBB
Dan Gohman0ba90f32009-10-31 20:19:03 +0000309 << " (BB#" << MBB->getNumber() << ")\n";
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000310}
311
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000312void MachineVerifier::report(const char *msg, const MachineInstr *MI) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000313 assert(MI);
314 report(msg, MI->getParent());
315 *OS << "- instruction: ";
Chris Lattner705e07f2009-08-23 03:41:05 +0000316 MI->print(*OS, TM);
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000317}
318
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000319void MachineVerifier::report(const char *msg,
320 const MachineOperand *MO, unsigned MONum) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000321 assert(MO);
322 report(msg, MO->getParent());
323 *OS << "- operand " << MONum << ": ";
324 MO->print(*OS, TM);
325 *OS << "\n";
326}
327
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000328void MachineVerifier::markReachable(const MachineBasicBlock *MBB) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000329 BBInfo &MInfo = MBBInfoMap[MBB];
330 if (!MInfo.reachable) {
331 MInfo.reachable = true;
332 for (MachineBasicBlock::const_succ_iterator SuI = MBB->succ_begin(),
333 SuE = MBB->succ_end(); SuI != SuE; ++SuI)
334 markReachable(*SuI);
335 }
336}
337
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000338void MachineVerifier::visitMachineFunctionBefore() {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000339 regsReserved = TRI->getReservedRegs(*MF);
Jakob Stoklund Olesend37bc5a2009-08-04 19:18:01 +0000340
341 // A sub-register of a reserved register is also reserved
342 for (int Reg = regsReserved.find_first(); Reg>=0;
343 Reg = regsReserved.find_next(Reg)) {
344 for (const unsigned *Sub = TRI->getSubRegisters(Reg); *Sub; ++Sub) {
345 // FIXME: This should probably be:
346 // assert(regsReserved.test(*Sub) && "Non-reserved sub-register");
347 regsReserved.set(*Sub);
348 }
349 }
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000350 markReachable(&MF->front());
351}
352
Jakob Stoklund Olesen1dc0fcb2009-11-13 21:55:54 +0000353// Does iterator point to a and b as the first two elements?
Dan Gohmanb3579832010-04-15 17:08:50 +0000354static bool matchPair(MachineBasicBlock::const_succ_iterator i,
355 const MachineBasicBlock *a, const MachineBasicBlock *b) {
Jakob Stoklund Olesen1dc0fcb2009-11-13 21:55:54 +0000356 if (*i == a)
357 return *++i == b;
358 if (*i == b)
359 return *++i == a;
360 return false;
361}
362
363void
364MachineVerifier::visitMachineBasicBlockBefore(const MachineBasicBlock *MBB) {
Dan Gohman27920592009-08-27 02:43:49 +0000365 const TargetInstrInfo *TII = MF->getTarget().getInstrInfo();
366
Dan Gohman27920592009-08-27 02:43:49 +0000367 // Call AnalyzeBranch. If it succeeds, there several more conditions to check.
368 MachineBasicBlock *TBB = 0, *FBB = 0;
369 SmallVector<MachineOperand, 4> Cond;
370 if (!TII->AnalyzeBranch(*const_cast<MachineBasicBlock *>(MBB),
371 TBB, FBB, Cond)) {
372 // Ok, AnalyzeBranch thinks it knows what's going on with this block. Let's
373 // check whether its answers match up with reality.
374 if (!TBB && !FBB) {
375 // Block falls through to its successor.
376 MachineFunction::const_iterator MBBI = MBB;
377 ++MBBI;
378 if (MBBI == MF->end()) {
Dan Gohmana01a80f2009-08-27 18:14:26 +0000379 // It's possible that the block legitimately ends with a noreturn
380 // call or an unreachable, in which case it won't actually fall
381 // out the bottom of the function.
382 } else if (MBB->succ_empty()) {
383 // It's possible that the block legitimately ends with a noreturn
384 // call or an unreachable, in which case it won't actuall fall
385 // out of the block.
Dan Gohman27920592009-08-27 02:43:49 +0000386 } else if (MBB->succ_size() != 1) {
387 report("MBB exits via unconditional fall-through but doesn't have "
388 "exactly one CFG successor!", MBB);
389 } else if (MBB->succ_begin()[0] != MBBI) {
390 report("MBB exits via unconditional fall-through but its successor "
391 "differs from its CFG successor!", MBB);
392 }
393 if (!MBB->empty() && MBB->back().getDesc().isBarrier()) {
394 report("MBB exits via unconditional fall-through but ends with a "
395 "barrier instruction!", MBB);
396 }
397 if (!Cond.empty()) {
398 report("MBB exits via unconditional fall-through but has a condition!",
399 MBB);
400 }
401 } else if (TBB && !FBB && Cond.empty()) {
402 // Block unconditionally branches somewhere.
403 if (MBB->succ_size() != 1) {
404 report("MBB exits via unconditional branch but doesn't have "
405 "exactly one CFG successor!", MBB);
406 } else if (MBB->succ_begin()[0] != TBB) {
407 report("MBB exits via unconditional branch but the CFG "
408 "successor doesn't match the actual successor!", MBB);
409 }
410 if (MBB->empty()) {
411 report("MBB exits via unconditional branch but doesn't contain "
412 "any instructions!", MBB);
413 } else if (!MBB->back().getDesc().isBarrier()) {
414 report("MBB exits via unconditional branch but doesn't end with a "
415 "barrier instruction!", MBB);
416 } else if (!MBB->back().getDesc().isTerminator()) {
417 report("MBB exits via unconditional branch but the branch isn't a "
418 "terminator instruction!", MBB);
419 }
420 } else if (TBB && !FBB && !Cond.empty()) {
421 // Block conditionally branches somewhere, otherwise falls through.
422 MachineFunction::const_iterator MBBI = MBB;
423 ++MBBI;
424 if (MBBI == MF->end()) {
425 report("MBB conditionally falls through out of function!", MBB);
426 } if (MBB->succ_size() != 2) {
427 report("MBB exits via conditional branch/fall-through but doesn't have "
428 "exactly two CFG successors!", MBB);
Jakob Stoklund Olesen1dc0fcb2009-11-13 21:55:54 +0000429 } else if (!matchPair(MBB->succ_begin(), TBB, MBBI)) {
Dan Gohman27920592009-08-27 02:43:49 +0000430 report("MBB exits via conditional branch/fall-through but the CFG "
431 "successors don't match the actual successors!", MBB);
432 }
433 if (MBB->empty()) {
434 report("MBB exits via conditional branch/fall-through but doesn't "
435 "contain any instructions!", MBB);
436 } else if (MBB->back().getDesc().isBarrier()) {
437 report("MBB exits via conditional branch/fall-through but ends with a "
438 "barrier instruction!", MBB);
439 } else if (!MBB->back().getDesc().isTerminator()) {
440 report("MBB exits via conditional branch/fall-through but the branch "
441 "isn't a terminator instruction!", MBB);
442 }
443 } else if (TBB && FBB) {
444 // Block conditionally branches somewhere, otherwise branches
445 // somewhere else.
446 if (MBB->succ_size() != 2) {
447 report("MBB exits via conditional branch/branch but doesn't have "
448 "exactly two CFG successors!", MBB);
Jakob Stoklund Olesen1dc0fcb2009-11-13 21:55:54 +0000449 } else if (!matchPair(MBB->succ_begin(), TBB, FBB)) {
Dan Gohman27920592009-08-27 02:43:49 +0000450 report("MBB exits via conditional branch/branch but the CFG "
451 "successors don't match the actual successors!", MBB);
452 }
453 if (MBB->empty()) {
454 report("MBB exits via conditional branch/branch but doesn't "
455 "contain any instructions!", MBB);
456 } else if (!MBB->back().getDesc().isBarrier()) {
457 report("MBB exits via conditional branch/branch but doesn't end with a "
458 "barrier instruction!", MBB);
459 } else if (!MBB->back().getDesc().isTerminator()) {
460 report("MBB exits via conditional branch/branch but the branch "
461 "isn't a terminator instruction!", MBB);
462 }
463 if (Cond.empty()) {
464 report("MBB exits via conditinal branch/branch but there's no "
465 "condition!", MBB);
466 }
467 } else {
468 report("AnalyzeBranch returned invalid data!", MBB);
469 }
470 }
471
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000472 regsLive.clear();
Dan Gohman81bf03e2010-04-13 16:57:55 +0000473 for (MachineBasicBlock::livein_iterator I = MBB->livein_begin(),
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000474 E = MBB->livein_end(); I != E; ++I) {
475 if (!TargetRegisterInfo::isPhysicalRegister(*I)) {
476 report("MBB live-in list contains non-physical register", MBB);
477 continue;
478 }
479 regsLive.insert(*I);
480 for (const unsigned *R = TRI->getSubRegisters(*I); *R; R++)
481 regsLive.insert(*R);
482 }
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +0000483 regsLiveInButUnused = regsLive;
Jakob Stoklund Olesena6b677d2009-08-13 16:19:51 +0000484
485 const MachineFrameInfo *MFI = MF->getFrameInfo();
486 assert(MFI && "Function has no frame info");
487 BitVector PR = MFI->getPristineRegs(MBB);
488 for (int I = PR.find_first(); I>0; I = PR.find_next(I)) {
489 regsLive.insert(I);
490 for (const unsigned *R = TRI->getSubRegisters(I); *R; R++)
491 regsLive.insert(*R);
492 }
493
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000494 regsKilled.clear();
495 regsDefined.clear();
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000496}
497
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000498void MachineVerifier::visitMachineInstrBefore(const MachineInstr *MI) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000499 const TargetInstrDesc &TI = MI->getDesc();
Jakob Stoklund Olesen39523e22009-09-23 20:57:55 +0000500 if (MI->getNumOperands() < TI.getNumOperands()) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000501 report("Too few operands", MI);
502 *OS << TI.getNumOperands() << " operands expected, but "
503 << MI->getNumExplicitOperands() << " given.\n";
504 }
Dan Gohman2dbc4c82009-10-07 17:36:00 +0000505
506 // Check the MachineMemOperands for basic consistency.
507 for (MachineInstr::mmo_iterator I = MI->memoperands_begin(),
508 E = MI->memoperands_end(); I != E; ++I) {
509 if ((*I)->isLoad() && !TI.mayLoad())
510 report("Missing mayLoad flag", MI);
511 if ((*I)->isStore() && !TI.mayStore())
512 report("Missing mayStore flag", MI);
513 }
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000514}
515
516void
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000517MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000518 const MachineInstr *MI = MO->getParent();
Jakob Stoklund Olesen44b27e52009-05-16 07:25:20 +0000519 const TargetInstrDesc &TI = MI->getDesc();
520
521 // The first TI.NumDefs operands must be explicit register defines
522 if (MONum < TI.getNumDefs()) {
523 if (!MO->isReg())
524 report("Explicit definition must be a register", MO, MONum);
525 else if (!MO->isDef())
526 report("Explicit definition marked as use", MO, MONum);
527 else if (MO->isImplicit())
528 report("Explicit definition marked as implicit", MO, MONum);
Jakob Stoklund Olesen39523e22009-09-23 20:57:55 +0000529 } else if (MONum < TI.getNumOperands()) {
530 if (MO->isReg()) {
531 if (MO->isDef())
532 report("Explicit operand marked as def", MO, MONum);
533 if (MO->isImplicit())
534 report("Explicit operand marked as implicit", MO, MONum);
535 }
536 } else {
Jakob Stoklund Olesen57115642009-12-22 21:48:20 +0000537 // ARM adds %reg0 operands to indicate predicates. We'll allow that.
538 if (MO->isReg() && !MO->isImplicit() && !TI.isVariadic() && MO->getReg())
Jakob Stoklund Olesen39523e22009-09-23 20:57:55 +0000539 report("Extra explicit operand on non-variadic instruction", MO, MONum);
Jakob Stoklund Olesen44b27e52009-05-16 07:25:20 +0000540 }
541
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000542 switch (MO->getType()) {
543 case MachineOperand::MO_Register: {
544 const unsigned Reg = MO->getReg();
545 if (!Reg)
546 return;
547
548 // Check Live Variables.
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +0000549 if (MO->isUndef()) {
550 // An <undef> doesn't refer to any register, so just skip it.
551 } else if (MO->isUse()) {
552 regsLiveInButUnused.erase(Reg);
553
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000554 bool isKill = false;
Jakob Stoklund Olesen1b2c7612010-05-14 20:28:32 +0000555 unsigned defIdx;
556 if (MI->isRegTiedToDefOperand(MONum, &defIdx)) {
557 // A two-addr use counts as a kill if use and def are the same.
558 unsigned DefReg = MI->getOperand(defIdx).getReg();
559 if (Reg == DefReg) {
560 isKill = true;
561 // ANd in that case an explicit kill flag is not allowed.
562 if (MO->isKill())
Jakob Stoklund Olesenf7d3e692009-07-15 23:37:26 +0000563 report("Illegal kill flag on two-address instruction operand",
564 MO, MONum);
Jakob Stoklund Olesen1b2c7612010-05-14 20:28:32 +0000565 } else if (TargetRegisterInfo::isPhysicalRegister(Reg)) {
566 report("Two-address instruction operands must be identical",
567 MO, MONum);
568 }
569 } else
570 isKill = MO->isKill();
571
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000572 if (isKill) {
573 addRegWithSubRegs(regsKilled, Reg);
574
575 // Check that LiveVars knows this kill
576 if (LiveVars && TargetRegisterInfo::isVirtualRegister(Reg)) {
577 LiveVariables::VarInfo &VI = LiveVars->getVarInfo(Reg);
578 if (std::find(VI.Kills.begin(),
579 VI.Kills.end(), MI) == VI.Kills.end())
580 report("Kill missing from LiveVariables", MO, MONum);
581 }
582 }
583
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +0000584 // Use of a dead register.
585 if (!regsLive.count(Reg)) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000586 if (TargetRegisterInfo::isPhysicalRegister(Reg)) {
587 // Reserved registers may be used even when 'dead'.
588 if (!isReserved(Reg))
589 report("Using an undefined physical register", MO, MONum);
590 } else {
591 BBInfo &MInfo = MBBInfoMap[MI->getParent()];
592 // We don't know which virtual registers are live in, so only complain
593 // if vreg was killed in this MBB. Otherwise keep track of vregs that
594 // must be live in. PHI instructions are handled separately.
595 if (MInfo.regsKilled.count(Reg))
596 report("Using a killed virtual register", MO, MONum);
Chris Lattner518bb532010-02-09 19:54:29 +0000597 else if (!MI->isPHI())
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000598 MInfo.vregsLiveIn.insert(std::make_pair(Reg, MI));
599 }
Duncan Sandse5567202009-05-16 03:28:54 +0000600 }
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000601 } else {
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +0000602 assert(MO->isDef());
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000603 // Register defined.
604 // TODO: verify that earlyclobber ops are not used.
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000605 if (MO->isDead())
606 addRegWithSubRegs(regsDead, Reg);
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +0000607 else
608 addRegWithSubRegs(regsDefined, Reg);
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000609 }
610
611 // Check register classes.
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000612 if (MONum < TI.getNumOperands() && !MO->isImplicit()) {
613 const TargetOperandInfo &TOI = TI.OpInfo[MONum];
614 unsigned SubIdx = MO->getSubReg();
615
616 if (TargetRegisterInfo::isPhysicalRegister(Reg)) {
617 unsigned sr = Reg;
618 if (SubIdx) {
619 unsigned s = TRI->getSubReg(Reg, SubIdx);
620 if (!s) {
621 report("Invalid subregister index for physical register",
622 MO, MONum);
623 return;
624 }
625 sr = s;
626 }
Chris Lattnercb778a82009-07-29 21:10:12 +0000627 if (const TargetRegisterClass *DRC = TOI.getRegClass(TRI)) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000628 if (!DRC->contains(sr)) {
629 report("Illegal physical register for instruction", MO, MONum);
630 *OS << TRI->getName(sr) << " is not a "
631 << DRC->getName() << " register.\n";
632 }
633 }
634 } else {
635 // Virtual register.
636 const TargetRegisterClass *RC = MRI->getRegClass(Reg);
637 if (SubIdx) {
638 if (RC->subregclasses_begin()+SubIdx >= RC->subregclasses_end()) {
639 report("Invalid subregister index for virtual register", MO, MONum);
640 return;
641 }
642 RC = *(RC->subregclasses_begin()+SubIdx);
643 }
Chris Lattnercb778a82009-07-29 21:10:12 +0000644 if (const TargetRegisterClass *DRC = TOI.getRegClass(TRI)) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000645 if (RC != DRC && !RC->hasSuperClass(DRC)) {
646 report("Illegal virtual register for instruction", MO, MONum);
647 *OS << "Expected a " << DRC->getName() << " register, but got a "
648 << RC->getName() << " register\n";
649 }
650 }
651 }
652 }
653 break;
654 }
Jakob Stoklund Olesena5ba07c2009-09-21 07:19:08 +0000655
656 case MachineOperand::MO_MachineBasicBlock:
Chris Lattner518bb532010-02-09 19:54:29 +0000657 if (MI->isPHI() && !MO->getMBB()->isSuccessor(MI->getParent()))
658 report("PHI operand is not in the CFG", MO, MONum);
Jakob Stoklund Olesena5ba07c2009-09-21 07:19:08 +0000659 break;
660
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000661 default:
662 break;
663 }
664}
665
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000666void MachineVerifier::visitMachineInstrAfter(const MachineInstr *MI) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000667 BBInfo &MInfo = MBBInfoMap[MI->getParent()];
668 set_union(MInfo.regsKilled, regsKilled);
669 set_subtract(regsLive, regsKilled);
670 regsKilled.clear();
671
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +0000672 // Verify that both <def> and <def,dead> operands refer to dead registers.
673 RegVector defs(regsDefined);
674 defs.append(regsDead.begin(), regsDead.end());
675
676 for (RegVector::const_iterator I = defs.begin(), E = defs.end();
677 I != E; ++I) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000678 if (regsLive.count(*I)) {
679 if (TargetRegisterInfo::isPhysicalRegister(*I)) {
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +0000680 if (!allowPhysDoubleDefs && !isReserved(*I) &&
681 !regsLiveInButUnused.count(*I)) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000682 report("Redefining a live physical register", MI);
683 *OS << "Register " << TRI->getName(*I)
684 << " was defined but already live.\n";
685 }
686 } else {
687 if (!allowVirtDoubleDefs) {
688 report("Redefining a live virtual register", MI);
689 *OS << "Virtual register %reg" << *I
690 << " was defined but already live.\n";
691 }
692 }
693 } else if (TargetRegisterInfo::isVirtualRegister(*I) &&
694 !MInfo.regsKilled.count(*I)) {
695 // Virtual register defined without being killed first must be dead on
696 // entry.
697 MInfo.vregsDeadIn.insert(std::make_pair(*I, MI));
698 }
699 }
700
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000701 set_subtract(regsLive, regsDead); regsDead.clear();
Jakob Stoklund Olesen710b13b2009-08-08 13:19:25 +0000702 set_union(regsLive, regsDefined); regsDefined.clear();
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000703}
704
705void
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000706MachineVerifier::visitMachineBasicBlockAfter(const MachineBasicBlock *MBB) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000707 MBBInfoMap[MBB].regsLiveOut = regsLive;
708 regsLive.clear();
709}
710
711// Calculate the largest possible vregsPassed sets. These are the registers that
712// can pass through an MBB live, but may not be live every time. It is assumed
713// that all vregsPassed sets are empty before the call.
Jakob Stoklund Olesenb31defe2010-01-05 20:59:36 +0000714void MachineVerifier::calcRegsPassed() {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000715 // First push live-out regs to successors' vregsPassed. Remember the MBBs that
716 // have any vregsPassed.
717 DenseSet<const MachineBasicBlock*> todo;
718 for (MachineFunction::const_iterator MFI = MF->begin(), MFE = MF->end();
719 MFI != MFE; ++MFI) {
720 const MachineBasicBlock &MBB(*MFI);
721 BBInfo &MInfo = MBBInfoMap[&MBB];
722 if (!MInfo.reachable)
723 continue;
724 for (MachineBasicBlock::const_succ_iterator SuI = MBB.succ_begin(),
725 SuE = MBB.succ_end(); SuI != SuE; ++SuI) {
726 BBInfo &SInfo = MBBInfoMap[*SuI];
727 if (SInfo.addPassed(MInfo.regsLiveOut))
728 todo.insert(*SuI);
729 }
730 }
731
732 // Iteratively push vregsPassed to successors. This will converge to the same
733 // final state regardless of DenseSet iteration order.
734 while (!todo.empty()) {
735 const MachineBasicBlock *MBB = *todo.begin();
736 todo.erase(MBB);
737 BBInfo &MInfo = MBBInfoMap[MBB];
738 for (MachineBasicBlock::const_succ_iterator SuI = MBB->succ_begin(),
739 SuE = MBB->succ_end(); SuI != SuE; ++SuI) {
740 if (*SuI == MBB)
741 continue;
742 BBInfo &SInfo = MBBInfoMap[*SuI];
743 if (SInfo.addPassed(MInfo.vregsPassed))
744 todo.insert(*SuI);
745 }
746 }
747}
748
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000749// Calculate the set of virtual registers that must be passed through each basic
750// block in order to satisfy the requirements of successor blocks. This is very
Jakob Stoklund Olesenb31defe2010-01-05 20:59:36 +0000751// similar to calcRegsPassed, only backwards.
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000752void MachineVerifier::calcRegsRequired() {
753 // First push live-in regs to predecessors' vregsRequired.
754 DenseSet<const MachineBasicBlock*> todo;
755 for (MachineFunction::const_iterator MFI = MF->begin(), MFE = MF->end();
756 MFI != MFE; ++MFI) {
757 const MachineBasicBlock &MBB(*MFI);
758 BBInfo &MInfo = MBBInfoMap[&MBB];
759 for (MachineBasicBlock::const_pred_iterator PrI = MBB.pred_begin(),
760 PrE = MBB.pred_end(); PrI != PrE; ++PrI) {
761 BBInfo &PInfo = MBBInfoMap[*PrI];
762 if (PInfo.addRequired(MInfo.vregsLiveIn))
763 todo.insert(*PrI);
764 }
765 }
766
767 // Iteratively push vregsRequired to predecessors. This will converge to the
768 // same final state regardless of DenseSet iteration order.
769 while (!todo.empty()) {
770 const MachineBasicBlock *MBB = *todo.begin();
771 todo.erase(MBB);
772 BBInfo &MInfo = MBBInfoMap[MBB];
773 for (MachineBasicBlock::const_pred_iterator PrI = MBB->pred_begin(),
774 PrE = MBB->pred_end(); PrI != PrE; ++PrI) {
775 if (*PrI == MBB)
776 continue;
777 BBInfo &SInfo = MBBInfoMap[*PrI];
778 if (SInfo.addRequired(MInfo.vregsRequired))
779 todo.insert(*PrI);
780 }
781 }
782}
783
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000784// Check PHI instructions at the beginning of MBB. It is assumed that
Jakob Stoklund Olesenb31defe2010-01-05 20:59:36 +0000785// calcRegsPassed has been run so BBInfo::isLiveOut is valid.
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000786void MachineVerifier::checkPHIOps(const MachineBasicBlock *MBB) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000787 for (MachineBasicBlock::const_iterator BBI = MBB->begin(), BBE = MBB->end();
Chris Lattner518bb532010-02-09 19:54:29 +0000788 BBI != BBE && BBI->isPHI(); ++BBI) {
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000789 DenseSet<const MachineBasicBlock*> seen;
790
791 for (unsigned i = 1, e = BBI->getNumOperands(); i != e; i += 2) {
792 unsigned Reg = BBI->getOperand(i).getReg();
793 const MachineBasicBlock *Pre = BBI->getOperand(i + 1).getMBB();
794 if (!Pre->isSuccessor(MBB))
795 continue;
796 seen.insert(Pre);
797 BBInfo &PrInfo = MBBInfoMap[Pre];
798 if (PrInfo.reachable && !PrInfo.isLiveOut(Reg))
799 report("PHI operand is not live-out from predecessor",
800 &BBI->getOperand(i), i);
801 }
802
803 // Did we see all predecessors?
804 for (MachineBasicBlock::const_pred_iterator PrI = MBB->pred_begin(),
805 PrE = MBB->pred_end(); PrI != PrE; ++PrI) {
806 if (!seen.count(*PrI)) {
807 report("Missing PHI operand", BBI);
Dan Gohman0ba90f32009-10-31 20:19:03 +0000808 *OS << "BB#" << (*PrI)->getNumber()
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000809 << " is a predecessor according to the CFG.\n";
810 }
811 }
812 }
813}
814
Jakob Stoklund Olesenb44fad72009-10-04 18:18:39 +0000815void MachineVerifier::visitMachineFunctionAfter() {
Jakob Stoklund Olesenb31defe2010-01-05 20:59:36 +0000816 calcRegsPassed();
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000817
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000818 for (MachineFunction::const_iterator MFI = MF->begin(), MFE = MF->end();
819 MFI != MFE; ++MFI) {
820 BBInfo &MInfo = MBBInfoMap[MFI];
821
822 // Skip unreachable MBBs.
823 if (!MInfo.reachable)
824 continue;
825
826 checkPHIOps(MFI);
827
Jakob Stoklund Olesenb31defe2010-01-05 20:59:36 +0000828 // Verify dead-in virtual registers.
829 if (!allowVirtDoubleDefs) {
830 for (MachineBasicBlock::const_pred_iterator PrI = MFI->pred_begin(),
831 PrE = MFI->pred_end(); PrI != PrE; ++PrI) {
832 BBInfo &PrInfo = MBBInfoMap[*PrI];
833 if (!PrInfo.reachable)
834 continue;
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000835
Jakob Stoklund Olesenb31defe2010-01-05 20:59:36 +0000836 for (RegMap::iterator I = MInfo.vregsDeadIn.begin(),
837 E = MInfo.vregsDeadIn.end(); I != E; ++I) {
838 // DeadIn register must be in neither regsLiveOut or vregsPassed of
839 // any predecessor.
840 if (PrInfo.isLiveOut(I->first)) {
841 report("Live-in virtual register redefined", I->second);
842 *OS << "Register %reg" << I->first
843 << " was live-out from predecessor MBB #"
844 << (*PrI)->getNumber() << ".\n";
845 }
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000846 }
847 }
848 }
849 }
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000850
851 // Now check LiveVariables info if available
852 if (LiveVars) {
853 calcRegsRequired();
854 verifyLiveVariables();
855 }
Jakob Stoklund Olesen48872e02009-05-16 00:33:53 +0000856}
Jakob Stoklund Olesen8f16e022009-11-18 20:36:57 +0000857
858void MachineVerifier::verifyLiveVariables() {
859 assert(LiveVars && "Don't call verifyLiveVariables without LiveVars");
860 for (unsigned Reg = TargetRegisterInfo::FirstVirtualRegister,
861 RegE = MRI->getLastVirtReg()-1; Reg != RegE; ++Reg) {
862 LiveVariables::VarInfo &VI = LiveVars->getVarInfo(Reg);
863 for (MachineFunction::const_iterator MFI = MF->begin(), MFE = MF->end();
864 MFI != MFE; ++MFI) {
865 BBInfo &MInfo = MBBInfoMap[MFI];
866
867 // Our vregsRequired should be identical to LiveVariables' AliveBlocks
868 if (MInfo.vregsRequired.count(Reg)) {
869 if (!VI.AliveBlocks.test(MFI->getNumber())) {
870 report("LiveVariables: Block missing from AliveBlocks", MFI);
871 *OS << "Virtual register %reg" << Reg
872 << " must be live through the block.\n";
873 }
874 } else {
875 if (VI.AliveBlocks.test(MFI->getNumber())) {
876 report("LiveVariables: Block should not be in AliveBlocks", MFI);
877 *OS << "Virtual register %reg" << Reg
878 << " is not needed live through the block.\n";
879 }
880 }
881 }
882 }
883}
884
885