blob: c27e0d4ed6b032ab3497c3de1727f0f0edbf9a8b [file] [log] [blame]
Bob Wilson15acadd2009-11-26 00:32:21 +00001//===-- TailDuplication.cpp - Duplicate blocks into predecessors' tails ---===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This pass duplicates basic blocks ending in unconditional branches into
11// the tails of their predecessors.
12//
13//===----------------------------------------------------------------------===//
14
15#define DEBUG_TYPE "tailduplication"
16#include "llvm/Function.h"
17#include "llvm/CodeGen/Passes.h"
18#include "llvm/CodeGen/MachineModuleInfo.h"
19#include "llvm/CodeGen/MachineFunctionPass.h"
Jakob Stoklund Olesen1e1098c2010-07-10 22:42:59 +000020#include "llvm/CodeGen/MachineInstrBuilder.h"
Evan Cheng111e7622009-12-03 08:43:53 +000021#include "llvm/CodeGen/MachineRegisterInfo.h"
22#include "llvm/CodeGen/MachineSSAUpdater.h"
Bob Wilson15acadd2009-11-26 00:32:21 +000023#include "llvm/Target/TargetInstrInfo.h"
24#include "llvm/Support/CommandLine.h"
25#include "llvm/Support/Debug.h"
Evan Cheng75eb5352009-12-07 10:15:19 +000026#include "llvm/Support/ErrorHandling.h"
Bob Wilson15acadd2009-11-26 00:32:21 +000027#include "llvm/Support/raw_ostream.h"
28#include "llvm/ADT/SmallSet.h"
29#include "llvm/ADT/SetVector.h"
30#include "llvm/ADT/Statistic.h"
31using namespace llvm;
32
Evan Cheng75eb5352009-12-07 10:15:19 +000033STATISTIC(NumTails , "Number of tails duplicated");
Bob Wilson15acadd2009-11-26 00:32:21 +000034STATISTIC(NumTailDups , "Number of tail duplicated blocks");
35STATISTIC(NumInstrDups , "Additional instructions due to tail duplication");
36STATISTIC(NumDeadBlocks, "Number of dead blocks removed");
Rafael Espindola0cdca082011-06-08 14:13:31 +000037STATISTIC(NumAddedPHIs , "Number of phis added");
Bob Wilson15acadd2009-11-26 00:32:21 +000038
39// Heuristic for tail duplication.
40static cl::opt<unsigned>
41TailDuplicateSize("tail-dup-size",
42 cl::desc("Maximum instructions to consider tail duplicating"),
43 cl::init(2), cl::Hidden);
44
Evan Cheng75eb5352009-12-07 10:15:19 +000045static cl::opt<bool>
46TailDupVerify("tail-dup-verify",
47 cl::desc("Verify sanity of PHI instructions during taildup"),
48 cl::init(false), cl::Hidden);
49
50static cl::opt<unsigned>
51TailDupLimit("tail-dup-limit", cl::init(~0U), cl::Hidden);
52
Evan Cheng11572ba2009-12-04 19:09:10 +000053typedef std::vector<std::pair<MachineBasicBlock*,unsigned> > AvailableValsTy;
Evan Cheng111e7622009-12-03 08:43:53 +000054
Bob Wilson15acadd2009-11-26 00:32:21 +000055namespace {
Bob Wilson2d521e52009-11-26 21:38:41 +000056 /// TailDuplicatePass - Perform tail duplication.
57 class TailDuplicatePass : public MachineFunctionPass {
Evan Cheng79fc6f42009-12-04 09:42:45 +000058 bool PreRegAlloc;
Bob Wilson15acadd2009-11-26 00:32:21 +000059 const TargetInstrInfo *TII;
60 MachineModuleInfo *MMI;
Evan Cheng111e7622009-12-03 08:43:53 +000061 MachineRegisterInfo *MRI;
62
63 // SSAUpdateVRs - A list of virtual registers for which to update SSA form.
64 SmallVector<unsigned, 16> SSAUpdateVRs;
65
66 // SSAUpdateVals - For each virtual register in SSAUpdateVals keep a list of
67 // source virtual registers.
68 DenseMap<unsigned, AvailableValsTy> SSAUpdateVals;
Bob Wilson15acadd2009-11-26 00:32:21 +000069
70 public:
71 static char ID;
Evan Cheng79fc6f42009-12-04 09:42:45 +000072 explicit TailDuplicatePass(bool PreRA) :
Owen Anderson90c579d2010-08-06 18:33:48 +000073 MachineFunctionPass(ID), PreRegAlloc(PreRA) {}
Bob Wilson15acadd2009-11-26 00:32:21 +000074
75 virtual bool runOnMachineFunction(MachineFunction &MF);
76 virtual const char *getPassName() const { return "Tail Duplication"; }
77
78 private:
Evan Cheng11572ba2009-12-04 19:09:10 +000079 void AddSSAUpdateEntry(unsigned OrigReg, unsigned NewReg,
80 MachineBasicBlock *BB);
Evan Cheng79fc6f42009-12-04 09:42:45 +000081 void ProcessPHI(MachineInstr *MI, MachineBasicBlock *TailBB,
82 MachineBasicBlock *PredBB,
Evan Cheng75eb5352009-12-07 10:15:19 +000083 DenseMap<unsigned, unsigned> &LocalVRMap,
Rafael Espindola0f28c3f2011-06-09 22:53:47 +000084 SmallVector<std::pair<unsigned,unsigned>, 4> &Copies,
Rafael Espindola689d7d52011-06-09 23:22:56 +000085 const DenseSet<unsigned> &UsedByPhi,
86 bool Remove);
Evan Cheng79fc6f42009-12-04 09:42:45 +000087 void DuplicateInstruction(MachineInstr *MI,
88 MachineBasicBlock *TailBB,
89 MachineBasicBlock *PredBB,
90 MachineFunction &MF,
Rafael Espindola0f28c3f2011-06-09 22:53:47 +000091 DenseMap<unsigned, unsigned> &LocalVRMap,
92 const DenseSet<unsigned> &UsedByPhi);
Evan Cheng75eb5352009-12-07 10:15:19 +000093 void UpdateSuccessorsPHIs(MachineBasicBlock *FromBB, bool isDead,
94 SmallVector<MachineBasicBlock*, 8> &TDBBs,
95 SmallSetVector<MachineBasicBlock*, 8> &Succs);
Bob Wilson15acadd2009-11-26 00:32:21 +000096 bool TailDuplicateBlocks(MachineFunction &MF);
Rafael Espindola54c25622011-06-09 19:54:42 +000097 bool shouldTailDuplicate(const MachineFunction &MF,
98 MachineBasicBlock &TailBB);
Evan Cheng75eb5352009-12-07 10:15:19 +000099 bool TailDuplicate(MachineBasicBlock *TailBB, MachineFunction &MF,
Evan Cheng3466f132009-12-15 01:44:10 +0000100 SmallVector<MachineBasicBlock*, 8> &TDBBs,
101 SmallVector<MachineInstr*, 16> &Copies);
Bob Wilson15acadd2009-11-26 00:32:21 +0000102 void RemoveDeadBlock(MachineBasicBlock *MBB);
103 };
104
Bob Wilson2d521e52009-11-26 21:38:41 +0000105 char TailDuplicatePass::ID = 0;
Bob Wilson15acadd2009-11-26 00:32:21 +0000106}
107
Evan Cheng79fc6f42009-12-04 09:42:45 +0000108FunctionPass *llvm::createTailDuplicatePass(bool PreRegAlloc) {
109 return new TailDuplicatePass(PreRegAlloc);
Bob Wilson15acadd2009-11-26 00:32:21 +0000110}
111
Bob Wilson2d521e52009-11-26 21:38:41 +0000112bool TailDuplicatePass::runOnMachineFunction(MachineFunction &MF) {
Bob Wilson15acadd2009-11-26 00:32:21 +0000113 TII = MF.getTarget().getInstrInfo();
Evan Cheng111e7622009-12-03 08:43:53 +0000114 MRI = &MF.getRegInfo();
Bob Wilson15acadd2009-11-26 00:32:21 +0000115 MMI = getAnalysisIfAvailable<MachineModuleInfo>();
116
117 bool MadeChange = false;
Jakob Stoklund Olesen057d5392010-01-15 19:59:57 +0000118 while (TailDuplicateBlocks(MF))
119 MadeChange = true;
Bob Wilson15acadd2009-11-26 00:32:21 +0000120
121 return MadeChange;
122}
123
Evan Cheng75eb5352009-12-07 10:15:19 +0000124static void VerifyPHIs(MachineFunction &MF, bool CheckExtra) {
125 for (MachineFunction::iterator I = ++MF.begin(), E = MF.end(); I != E; ++I) {
126 MachineBasicBlock *MBB = I;
127 SmallSetVector<MachineBasicBlock*, 8> Preds(MBB->pred_begin(),
128 MBB->pred_end());
129 MachineBasicBlock::iterator MI = MBB->begin();
130 while (MI != MBB->end()) {
Chris Lattner518bb532010-02-09 19:54:29 +0000131 if (!MI->isPHI())
Evan Cheng75eb5352009-12-07 10:15:19 +0000132 break;
133 for (SmallSetVector<MachineBasicBlock *, 8>::iterator PI = Preds.begin(),
134 PE = Preds.end(); PI != PE; ++PI) {
135 MachineBasicBlock *PredBB = *PI;
136 bool Found = false;
137 for (unsigned i = 1, e = MI->getNumOperands(); i != e; i += 2) {
138 MachineBasicBlock *PHIBB = MI->getOperand(i+1).getMBB();
139 if (PHIBB == PredBB) {
140 Found = true;
141 break;
142 }
143 }
144 if (!Found) {
David Greene00dec1b2010-01-05 01:25:15 +0000145 dbgs() << "Malformed PHI in BB#" << MBB->getNumber() << ": " << *MI;
146 dbgs() << " missing input from predecessor BB#"
Evan Cheng75eb5352009-12-07 10:15:19 +0000147 << PredBB->getNumber() << '\n';
148 llvm_unreachable(0);
149 }
150 }
151
152 for (unsigned i = 1, e = MI->getNumOperands(); i != e; i += 2) {
153 MachineBasicBlock *PHIBB = MI->getOperand(i+1).getMBB();
154 if (CheckExtra && !Preds.count(PHIBB)) {
David Greene00dec1b2010-01-05 01:25:15 +0000155 dbgs() << "Warning: malformed PHI in BB#" << MBB->getNumber()
Evan Cheng75eb5352009-12-07 10:15:19 +0000156 << ": " << *MI;
David Greene00dec1b2010-01-05 01:25:15 +0000157 dbgs() << " extra input from predecessor BB#"
Evan Cheng75eb5352009-12-07 10:15:19 +0000158 << PHIBB->getNumber() << '\n';
Rafael Espindolad3f4eea2011-06-09 23:55:56 +0000159 llvm_unreachable(0);
Evan Cheng75eb5352009-12-07 10:15:19 +0000160 }
161 if (PHIBB->getNumber() < 0) {
David Greene00dec1b2010-01-05 01:25:15 +0000162 dbgs() << "Malformed PHI in BB#" << MBB->getNumber() << ": " << *MI;
163 dbgs() << " non-existing BB#" << PHIBB->getNumber() << '\n';
Evan Cheng75eb5352009-12-07 10:15:19 +0000164 llvm_unreachable(0);
165 }
166 }
167 ++MI;
168 }
169 }
170}
171
Bob Wilson15acadd2009-11-26 00:32:21 +0000172/// TailDuplicateBlocks - Look for small blocks that are unconditionally
173/// branched to and do not fall through. Tail-duplicate their instructions
174/// into their predecessors to eliminate (dynamic) branches.
Bob Wilson2d521e52009-11-26 21:38:41 +0000175bool TailDuplicatePass::TailDuplicateBlocks(MachineFunction &MF) {
Bob Wilson15acadd2009-11-26 00:32:21 +0000176 bool MadeChange = false;
177
Evan Cheng75eb5352009-12-07 10:15:19 +0000178 if (PreRegAlloc && TailDupVerify) {
David Greene00dec1b2010-01-05 01:25:15 +0000179 DEBUG(dbgs() << "\n*** Before tail-duplicating\n");
Evan Cheng75eb5352009-12-07 10:15:19 +0000180 VerifyPHIs(MF, true);
181 }
182
183 SmallVector<MachineInstr*, 8> NewPHIs;
184 MachineSSAUpdater SSAUpdate(MF, &NewPHIs);
185
Bob Wilson15acadd2009-11-26 00:32:21 +0000186 for (MachineFunction::iterator I = ++MF.begin(), E = MF.end(); I != E; ) {
187 MachineBasicBlock *MBB = I++;
188
Evan Cheng75eb5352009-12-07 10:15:19 +0000189 if (NumTails == TailDupLimit)
190 break;
191
Evan Cheng75eb5352009-12-07 10:15:19 +0000192 // Save the successors list.
193 SmallSetVector<MachineBasicBlock*, 8> Succs(MBB->succ_begin(),
194 MBB->succ_end());
Bob Wilson15acadd2009-11-26 00:32:21 +0000195
Evan Cheng75eb5352009-12-07 10:15:19 +0000196 SmallVector<MachineBasicBlock*, 8> TDBBs;
Evan Cheng3466f132009-12-15 01:44:10 +0000197 SmallVector<MachineInstr*, 16> Copies;
198 if (TailDuplicate(MBB, MF, TDBBs, Copies)) {
Evan Cheng75eb5352009-12-07 10:15:19 +0000199 ++NumTails;
200
201 // TailBB's immediate successors are now successors of those predecessors
202 // which duplicated TailBB. Add the predecessors as sources to the PHI
203 // instructions.
204 bool isDead = MBB->pred_empty();
205 if (PreRegAlloc)
206 UpdateSuccessorsPHIs(MBB, isDead, TDBBs, Succs);
207
208 // If it is dead, remove it.
209 if (isDead) {
210 NumInstrDups -= MBB->size();
211 RemoveDeadBlock(MBB);
212 ++NumDeadBlocks;
213 }
214
215 // Update SSA form.
216 if (!SSAUpdateVRs.empty()) {
217 for (unsigned i = 0, e = SSAUpdateVRs.size(); i != e; ++i) {
218 unsigned VReg = SSAUpdateVRs[i];
219 SSAUpdate.Initialize(VReg);
220
221 // If the original definition is still around, add it as an available
222 // value.
223 MachineInstr *DefMI = MRI->getVRegDef(VReg);
224 MachineBasicBlock *DefBB = 0;
225 if (DefMI) {
226 DefBB = DefMI->getParent();
227 SSAUpdate.AddAvailableValue(DefBB, VReg);
228 }
229
230 // Add the new vregs as available values.
231 DenseMap<unsigned, AvailableValsTy>::iterator LI =
232 SSAUpdateVals.find(VReg);
233 for (unsigned j = 0, ee = LI->second.size(); j != ee; ++j) {
234 MachineBasicBlock *SrcBB = LI->second[j].first;
235 unsigned SrcReg = LI->second[j].second;
236 SSAUpdate.AddAvailableValue(SrcBB, SrcReg);
237 }
238
239 // Rewrite uses that are outside of the original def's block.
240 MachineRegisterInfo::use_iterator UI = MRI->use_begin(VReg);
241 while (UI != MRI->use_end()) {
242 MachineOperand &UseMO = UI.getOperand();
243 MachineInstr *UseMI = &*UI;
244 ++UI;
Rafael Espindoladb3983b2011-06-17 13:59:43 +0000245 if (UseMI->isDebugValue()) {
246 // SSAUpdate can replace the use with an undef. That creates
247 // a debug instruction that is a kill.
248 // FIXME: Should it SSAUpdate job to delete debug instructions
249 // instead of replacing the use with undef?
250 UseMI->eraseFromParent();
251 continue;
252 }
Rafael Espindolac2e9a502011-06-09 20:55:41 +0000253 if (UseMI->getParent() == DefBB && !UseMI->isPHI())
Evan Cheng75eb5352009-12-07 10:15:19 +0000254 continue;
255 SSAUpdate.RewriteUse(UseMO);
Evan Cheng75eb5352009-12-07 10:15:19 +0000256 }
257 }
258
259 SSAUpdateVRs.clear();
260 SSAUpdateVals.clear();
261 }
262
Bob Wilsonbfdcf3b2010-01-15 06:29:17 +0000263 // Eliminate some of the copies inserted by tail duplication to maintain
Evan Cheng3466f132009-12-15 01:44:10 +0000264 // SSA form.
265 for (unsigned i = 0, e = Copies.size(); i != e; ++i) {
266 MachineInstr *Copy = Copies[i];
Jakob Stoklund Olesen04c528a2010-07-16 04:45:42 +0000267 if (!Copy->isCopy())
268 continue;
269 unsigned Dst = Copy->getOperand(0).getReg();
270 unsigned Src = Copy->getOperand(1).getReg();
271 MachineRegisterInfo::use_iterator UI = MRI->use_begin(Src);
272 if (++UI == MRI->use_end()) {
273 // Copy is the only use. Do trivial copy propagation here.
274 MRI->replaceRegWith(Dst, Src);
275 Copy->eraseFromParent();
Evan Cheng3466f132009-12-15 01:44:10 +0000276 }
277 }
278
Evan Cheng75eb5352009-12-07 10:15:19 +0000279 if (PreRegAlloc && TailDupVerify)
280 VerifyPHIs(MF, false);
Bob Wilson15acadd2009-11-26 00:32:21 +0000281 MadeChange = true;
Bob Wilson15acadd2009-11-26 00:32:21 +0000282 }
283 }
Rafael Espindolad69f85e2011-06-08 14:23:19 +0000284 NumAddedPHIs += NewPHIs.size();
Evan Cheng111e7622009-12-03 08:43:53 +0000285
Bob Wilson15acadd2009-11-26 00:32:21 +0000286 return MadeChange;
287}
288
Evan Cheng111e7622009-12-03 08:43:53 +0000289static bool isDefLiveOut(unsigned Reg, MachineBasicBlock *BB,
290 const MachineRegisterInfo *MRI) {
291 for (MachineRegisterInfo::use_iterator UI = MRI->use_begin(Reg),
292 UE = MRI->use_end(); UI != UE; ++UI) {
293 MachineInstr *UseMI = &*UI;
Rafael Espindoladb3983b2011-06-17 13:59:43 +0000294 if (UseMI->isDebugValue())
295 continue;
Evan Cheng111e7622009-12-03 08:43:53 +0000296 if (UseMI->getParent() != BB)
297 return true;
298 }
299 return false;
300}
301
302static unsigned getPHISrcRegOpIdx(MachineInstr *MI, MachineBasicBlock *SrcBB) {
303 for (unsigned i = 1, e = MI->getNumOperands(); i != e; i += 2)
304 if (MI->getOperand(i+1).getMBB() == SrcBB)
305 return i;
306 return 0;
307}
308
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000309
310// Remember which registers are used by phis in this block. This is
311// used to determine which registers are liveout while modifying the
312// block (which is why we need to copy the information).
313static void getRegsUsedByPHIs(const MachineBasicBlock &BB,
Rafael Espindola33b46582011-06-10 21:01:53 +0000314 DenseSet<unsigned> *UsedByPhi) {
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000315 for(MachineBasicBlock::const_iterator I = BB.begin(), E = BB.end();
316 I != E; ++I) {
317 const MachineInstr &MI = *I;
318 if (!MI.isPHI())
319 break;
320 for (unsigned i = 1, e = MI.getNumOperands(); i != e; i += 2) {
321 unsigned SrcReg = MI.getOperand(i).getReg();
322 UsedByPhi->insert(SrcReg);
323 }
324 }
325}
326
Evan Cheng111e7622009-12-03 08:43:53 +0000327/// AddSSAUpdateEntry - Add a definition and source virtual registers pair for
328/// SSA update.
Evan Cheng11572ba2009-12-04 19:09:10 +0000329void TailDuplicatePass::AddSSAUpdateEntry(unsigned OrigReg, unsigned NewReg,
330 MachineBasicBlock *BB) {
331 DenseMap<unsigned, AvailableValsTy>::iterator LI= SSAUpdateVals.find(OrigReg);
Evan Cheng111e7622009-12-03 08:43:53 +0000332 if (LI != SSAUpdateVals.end())
Evan Cheng11572ba2009-12-04 19:09:10 +0000333 LI->second.push_back(std::make_pair(BB, NewReg));
Evan Cheng111e7622009-12-03 08:43:53 +0000334 else {
335 AvailableValsTy Vals;
Evan Cheng11572ba2009-12-04 19:09:10 +0000336 Vals.push_back(std::make_pair(BB, NewReg));
Evan Cheng111e7622009-12-03 08:43:53 +0000337 SSAUpdateVals.insert(std::make_pair(OrigReg, Vals));
338 SSAUpdateVRs.push_back(OrigReg);
339 }
340}
341
Evan Cheng75eb5352009-12-07 10:15:19 +0000342/// ProcessPHI - Process PHI node in TailBB by turning it into a copy in PredBB.
343/// Remember the source register that's contributed by PredBB and update SSA
344/// update map.
Evan Cheng79fc6f42009-12-04 09:42:45 +0000345void TailDuplicatePass::ProcessPHI(MachineInstr *MI,
346 MachineBasicBlock *TailBB,
347 MachineBasicBlock *PredBB,
Evan Cheng75eb5352009-12-07 10:15:19 +0000348 DenseMap<unsigned, unsigned> &LocalVRMap,
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000349 SmallVector<std::pair<unsigned,unsigned>, 4> &Copies,
Rafael Espindola33b46582011-06-10 21:01:53 +0000350 const DenseSet<unsigned> &RegsUsedByPhi,
Rafael Espindola689d7d52011-06-09 23:22:56 +0000351 bool Remove) {
Evan Cheng79fc6f42009-12-04 09:42:45 +0000352 unsigned DefReg = MI->getOperand(0).getReg();
353 unsigned SrcOpIdx = getPHISrcRegOpIdx(MI, PredBB);
354 assert(SrcOpIdx && "Unable to find matching PHI source?");
355 unsigned SrcReg = MI->getOperand(SrcOpIdx).getReg();
Evan Cheng75eb5352009-12-07 10:15:19 +0000356 const TargetRegisterClass *RC = MRI->getRegClass(DefReg);
Evan Cheng79fc6f42009-12-04 09:42:45 +0000357 LocalVRMap.insert(std::make_pair(DefReg, SrcReg));
Evan Cheng75eb5352009-12-07 10:15:19 +0000358
359 // Insert a copy from source to the end of the block. The def register is the
360 // available value liveout of the block.
361 unsigned NewDef = MRI->createVirtualRegister(RC);
362 Copies.push_back(std::make_pair(NewDef, SrcReg));
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000363 if (isDefLiveOut(DefReg, TailBB, MRI) || RegsUsedByPhi.count(DefReg))
Evan Cheng75eb5352009-12-07 10:15:19 +0000364 AddSSAUpdateEntry(DefReg, NewDef, PredBB);
Evan Cheng79fc6f42009-12-04 09:42:45 +0000365
Rafael Espindola689d7d52011-06-09 23:22:56 +0000366 if (!Remove)
367 return;
368
Evan Cheng79fc6f42009-12-04 09:42:45 +0000369 // Remove PredBB from the PHI node.
370 MI->RemoveOperand(SrcOpIdx+1);
371 MI->RemoveOperand(SrcOpIdx);
372 if (MI->getNumOperands() == 1)
373 MI->eraseFromParent();
374}
375
376/// DuplicateInstruction - Duplicate a TailBB instruction to PredBB and update
377/// the source operands due to earlier PHI translation.
378void TailDuplicatePass::DuplicateInstruction(MachineInstr *MI,
379 MachineBasicBlock *TailBB,
380 MachineBasicBlock *PredBB,
381 MachineFunction &MF,
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000382 DenseMap<unsigned, unsigned> &LocalVRMap,
383 const DenseSet<unsigned> &UsedByPhi) {
Jakob Stoklund Olesen30ac0462010-01-06 23:47:07 +0000384 MachineInstr *NewMI = TII->duplicate(MI, MF);
Evan Cheng79fc6f42009-12-04 09:42:45 +0000385 for (unsigned i = 0, e = NewMI->getNumOperands(); i != e; ++i) {
386 MachineOperand &MO = NewMI->getOperand(i);
387 if (!MO.isReg())
388 continue;
389 unsigned Reg = MO.getReg();
Jakob Stoklund Olesenc9df0252011-01-10 02:58:51 +0000390 if (!TargetRegisterInfo::isVirtualRegister(Reg))
Evan Cheng79fc6f42009-12-04 09:42:45 +0000391 continue;
392 if (MO.isDef()) {
393 const TargetRegisterClass *RC = MRI->getRegClass(Reg);
394 unsigned NewReg = MRI->createVirtualRegister(RC);
395 MO.setReg(NewReg);
396 LocalVRMap.insert(std::make_pair(Reg, NewReg));
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000397 if (isDefLiveOut(Reg, TailBB, MRI) || UsedByPhi.count(Reg))
Evan Cheng11572ba2009-12-04 19:09:10 +0000398 AddSSAUpdateEntry(Reg, NewReg, PredBB);
Evan Cheng79fc6f42009-12-04 09:42:45 +0000399 } else {
400 DenseMap<unsigned, unsigned>::iterator VI = LocalVRMap.find(Reg);
401 if (VI != LocalVRMap.end())
402 MO.setReg(VI->second);
403 }
404 }
405 PredBB->insert(PredBB->end(), NewMI);
406}
407
408/// UpdateSuccessorsPHIs - After FromBB is tail duplicated into its predecessor
409/// blocks, the successors have gained new predecessors. Update the PHI
410/// instructions in them accordingly.
Evan Cheng75eb5352009-12-07 10:15:19 +0000411void
412TailDuplicatePass::UpdateSuccessorsPHIs(MachineBasicBlock *FromBB, bool isDead,
413 SmallVector<MachineBasicBlock*, 8> &TDBBs,
Evan Cheng79fc6f42009-12-04 09:42:45 +0000414 SmallSetVector<MachineBasicBlock*,8> &Succs) {
415 for (SmallSetVector<MachineBasicBlock*, 8>::iterator SI = Succs.begin(),
416 SE = Succs.end(); SI != SE; ++SI) {
417 MachineBasicBlock *SuccBB = *SI;
418 for (MachineBasicBlock::iterator II = SuccBB->begin(), EE = SuccBB->end();
419 II != EE; ++II) {
Chris Lattner518bb532010-02-09 19:54:29 +0000420 if (!II->isPHI())
Evan Cheng79fc6f42009-12-04 09:42:45 +0000421 break;
Evan Cheng75eb5352009-12-07 10:15:19 +0000422 unsigned Idx = 0;
Evan Cheng79fc6f42009-12-04 09:42:45 +0000423 for (unsigned i = 1, e = II->getNumOperands(); i != e; i += 2) {
Evan Cheng75eb5352009-12-07 10:15:19 +0000424 MachineOperand &MO = II->getOperand(i+1);
425 if (MO.getMBB() == FromBB) {
426 Idx = i;
Evan Cheng79fc6f42009-12-04 09:42:45 +0000427 break;
Evan Cheng75eb5352009-12-07 10:15:19 +0000428 }
429 }
430
431 assert(Idx != 0);
432 MachineOperand &MO0 = II->getOperand(Idx);
433 unsigned Reg = MO0.getReg();
434 if (isDead) {
435 // Folded into the previous BB.
436 // There could be duplicate phi source entries. FIXME: Should sdisel
437 // or earlier pass fixed this?
438 for (unsigned i = II->getNumOperands()-2; i != Idx; i -= 2) {
439 MachineOperand &MO = II->getOperand(i+1);
440 if (MO.getMBB() == FromBB) {
441 II->RemoveOperand(i+1);
442 II->RemoveOperand(i);
443 }
444 }
Jakob Stoklund Olesen09eeac92010-02-11 00:34:33 +0000445 } else
446 Idx = 0;
447
448 // If Idx is set, the operands at Idx and Idx+1 must be removed.
449 // We reuse the location to avoid expensive RemoveOperand calls.
450
Evan Cheng75eb5352009-12-07 10:15:19 +0000451 DenseMap<unsigned,AvailableValsTy>::iterator LI=SSAUpdateVals.find(Reg);
452 if (LI != SSAUpdateVals.end()) {
453 // This register is defined in the tail block.
Evan Cheng79fc6f42009-12-04 09:42:45 +0000454 for (unsigned j = 0, ee = LI->second.size(); j != ee; ++j) {
Evan Cheng11572ba2009-12-04 19:09:10 +0000455 MachineBasicBlock *SrcBB = LI->second[j].first;
Rafael Espindolad3f4eea2011-06-09 23:55:56 +0000456 // If we didn't duplicate a bb into a particular predecessor, we
457 // might still have added an entry to SSAUpdateVals to correcly
458 // recompute SSA. If that case, avoid adding a dummy extra argument
459 // this PHI.
460 if (!SrcBB->isSuccessor(SuccBB))
461 continue;
462
Evan Cheng11572ba2009-12-04 19:09:10 +0000463 unsigned SrcReg = LI->second[j].second;
Jakob Stoklund Olesen09eeac92010-02-11 00:34:33 +0000464 if (Idx != 0) {
465 II->getOperand(Idx).setReg(SrcReg);
466 II->getOperand(Idx+1).setMBB(SrcBB);
467 Idx = 0;
468 } else {
469 II->addOperand(MachineOperand::CreateReg(SrcReg, false));
470 II->addOperand(MachineOperand::CreateMBB(SrcBB));
471 }
Evan Cheng79fc6f42009-12-04 09:42:45 +0000472 }
Evan Cheng75eb5352009-12-07 10:15:19 +0000473 } else {
474 // Live in tail block, must also be live in predecessors.
475 for (unsigned j = 0, ee = TDBBs.size(); j != ee; ++j) {
476 MachineBasicBlock *SrcBB = TDBBs[j];
Jakob Stoklund Olesen09eeac92010-02-11 00:34:33 +0000477 if (Idx != 0) {
478 II->getOperand(Idx).setReg(Reg);
479 II->getOperand(Idx+1).setMBB(SrcBB);
480 Idx = 0;
481 } else {
482 II->addOperand(MachineOperand::CreateReg(Reg, false));
483 II->addOperand(MachineOperand::CreateMBB(SrcBB));
484 }
Evan Cheng75eb5352009-12-07 10:15:19 +0000485 }
Evan Cheng79fc6f42009-12-04 09:42:45 +0000486 }
Jakob Stoklund Olesen09eeac92010-02-11 00:34:33 +0000487 if (Idx != 0) {
488 II->RemoveOperand(Idx+1);
489 II->RemoveOperand(Idx);
490 }
Evan Cheng79fc6f42009-12-04 09:42:45 +0000491 }
492 }
493}
494
Rafael Espindola54c25622011-06-09 19:54:42 +0000495/// shouldTailDuplicate - Determine if it is profitable to duplicate this block.
Evan Cheng75eb5352009-12-07 10:15:19 +0000496bool
Rafael Espindola54c25622011-06-09 19:54:42 +0000497TailDuplicatePass::shouldTailDuplicate(const MachineFunction &MF,
498 MachineBasicBlock &TailBB) {
499 // Only duplicate blocks that end with unconditional branches.
500 if (TailBB.canFallThrough())
501 return false;
502
Rafael Espindolaec324e52011-06-17 05:54:50 +0000503 // Don't try to tail-duplicate single-block loops.
504 if (TailBB.isSuccessor(&TailBB))
505 return false;
506
Rafael Espindola54c25622011-06-09 19:54:42 +0000507 // Set the limit on the cost to duplicate. When optimizing for size,
Bob Wilson15acadd2009-11-26 00:32:21 +0000508 // duplicate only one, because one branch instruction can be eliminated to
509 // compensate for the duplication.
510 unsigned MaxDuplicateCount;
Jakob Stoklund Olesen83520622011-01-30 20:38:12 +0000511 if (TailDuplicateSize.getNumOccurrences() == 0 &&
512 MF.getFunction()->hasFnAttr(Attribute::OptimizeForSize))
Bob Wilson38582252009-11-30 18:56:45 +0000513 MaxDuplicateCount = 1;
Bob Wilson15acadd2009-11-26 00:32:21 +0000514 else
515 MaxDuplicateCount = TailDuplicateSize;
516
Rafael Espindolaec324e52011-06-17 05:54:50 +0000517 // If the target has hardware branch prediction that can handle indirect
518 // branches, duplicating them can often make them predictable when there
519 // are common paths through the code. The limit needs to be high enough
520 // to allow undoing the effects of tail merging and other optimizations
521 // that rearrange the predecessors of the indirect branch.
Bob Wilsoncb44b282010-01-16 00:42:25 +0000522
Rafael Espindolaec324e52011-06-17 05:54:50 +0000523 if (PreRegAlloc && !TailBB.empty()) {
524 const TargetInstrDesc &TID = TailBB.back().getDesc();
525 if (TID.isIndirectBranch())
526 MaxDuplicateCount = 20;
527 }
Bob Wilsonbfdcf3b2010-01-15 06:29:17 +0000528
Bob Wilson15acadd2009-11-26 00:32:21 +0000529 // Check the instructions in the block to determine whether tail-duplication
530 // is invalid or unlikely to be profitable.
Bob Wilsonf1e01dc2009-12-02 17:15:24 +0000531 unsigned InstrCount = 0;
Rafael Espindola54c25622011-06-09 19:54:42 +0000532 for (MachineBasicBlock::const_iterator I = TailBB.begin(); I != TailBB.end();
533 ++I) {
Bob Wilson15acadd2009-11-26 00:32:21 +0000534 // Non-duplicable things shouldn't be tail-duplicated.
Rafael Espindolaec324e52011-06-17 05:54:50 +0000535 if (I->getDesc().isNotDuplicable())
536 return false;
537
Evan Cheng79fc6f42009-12-04 09:42:45 +0000538 // Do not duplicate 'return' instructions if this is a pre-regalloc run.
539 // A return may expand into a lot more instructions (e.g. reload of callee
540 // saved registers) after PEI.
Rafael Espindolaec324e52011-06-17 05:54:50 +0000541 if (PreRegAlloc && I->getDesc().isReturn())
542 return false;
543
544 // Avoid duplicating calls before register allocation. Calls presents a
545 // barrier to register allocation so duplicating them may end up increasing
546 // spills.
547 if (PreRegAlloc && I->getDesc().isCall())
548 return false;
549
Devang Patelcbe1e312010-03-16 21:02:07 +0000550 if (!I->isPHI() && !I->isDebugValue())
Bob Wilsonf1e01dc2009-12-02 17:15:24 +0000551 InstrCount += 1;
Rafael Espindolaec324e52011-06-17 05:54:50 +0000552
553 if (InstrCount > MaxDuplicateCount)
554 return false;
Bob Wilson15acadd2009-11-26 00:32:21 +0000555 }
Bob Wilson15acadd2009-11-26 00:32:21 +0000556
Rafael Espindola54c25622011-06-09 19:54:42 +0000557 return true;
558}
559
560/// TailDuplicate - If it is profitable, duplicate TailBB's contents in each
561/// of its predecessors.
562bool
563TailDuplicatePass::TailDuplicate(MachineBasicBlock *TailBB, MachineFunction &MF,
564 SmallVector<MachineBasicBlock*, 8> &TDBBs,
565 SmallVector<MachineInstr*, 16> &Copies) {
566 if (!shouldTailDuplicate(MF, *TailBB))
567 return false;
568
David Greene00dec1b2010-01-05 01:25:15 +0000569 DEBUG(dbgs() << "\n*** Tail-duplicating BB#" << TailBB->getNumber() << '\n');
Evan Cheng75eb5352009-12-07 10:15:19 +0000570
Bob Wilson15acadd2009-11-26 00:32:21 +0000571 // Iterate through all the unique predecessors and tail-duplicate this
572 // block into them, if possible. Copying the list ahead of time also
573 // avoids trouble with the predecessor list reallocating.
574 bool Changed = false;
Evan Cheng79fc6f42009-12-04 09:42:45 +0000575 SmallSetVector<MachineBasicBlock*, 8> Preds(TailBB->pred_begin(),
576 TailBB->pred_end());
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000577 DenseSet<unsigned> UsedByPhi;
578 getRegsUsedByPHIs(*TailBB, &UsedByPhi);
Bob Wilson15acadd2009-11-26 00:32:21 +0000579 for (SmallSetVector<MachineBasicBlock *, 8>::iterator PI = Preds.begin(),
580 PE = Preds.end(); PI != PE; ++PI) {
581 MachineBasicBlock *PredBB = *PI;
582
583 assert(TailBB != PredBB &&
584 "Single-block loop should have been rejected earlier!");
Rafael Espindola9a9a3a52011-06-10 20:08:23 +0000585 // EH edges are ignored by AnalyzeBranch.
586 if (PredBB->succ_size() > 1)
587 continue;
Bob Wilson15acadd2009-11-26 00:32:21 +0000588
589 MachineBasicBlock *PredTBB, *PredFBB;
590 SmallVector<MachineOperand, 4> PredCond;
591 if (TII->AnalyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true))
592 continue;
593 if (!PredCond.empty())
594 continue;
Bob Wilson15acadd2009-11-26 00:32:21 +0000595 // Don't duplicate into a fall-through predecessor (at least for now).
596 if (PredBB->isLayoutSuccessor(TailBB) && PredBB->canFallThrough())
597 continue;
598
David Greene00dec1b2010-01-05 01:25:15 +0000599 DEBUG(dbgs() << "\nTail-duplicating into PredBB: " << *PredBB
Bob Wilson15acadd2009-11-26 00:32:21 +0000600 << "From Succ: " << *TailBB);
601
Evan Cheng75eb5352009-12-07 10:15:19 +0000602 TDBBs.push_back(PredBB);
603
Bob Wilson15acadd2009-11-26 00:32:21 +0000604 // Remove PredBB's unconditional branch.
605 TII->RemoveBranch(*PredBB);
Evan Cheng111e7622009-12-03 08:43:53 +0000606
Bob Wilson15acadd2009-11-26 00:32:21 +0000607 // Clone the contents of TailBB into PredBB.
Evan Cheng111e7622009-12-03 08:43:53 +0000608 DenseMap<unsigned, unsigned> LocalVRMap;
Evan Cheng3466f132009-12-15 01:44:10 +0000609 SmallVector<std::pair<unsigned,unsigned>, 4> CopyInfos;
Evan Cheng111e7622009-12-03 08:43:53 +0000610 MachineBasicBlock::iterator I = TailBB->begin();
Evan Cheng79fc6f42009-12-04 09:42:45 +0000611 while (I != TailBB->end()) {
612 MachineInstr *MI = &*I;
613 ++I;
Chris Lattner518bb532010-02-09 19:54:29 +0000614 if (MI->isPHI()) {
Evan Cheng111e7622009-12-03 08:43:53 +0000615 // Replace the uses of the def of the PHI with the register coming
616 // from PredBB.
Rafael Espindola689d7d52011-06-09 23:22:56 +0000617 ProcessPHI(MI, TailBB, PredBB, LocalVRMap, CopyInfos, UsedByPhi, true);
Evan Cheng79fc6f42009-12-04 09:42:45 +0000618 } else {
619 // Replace def of virtual registers with new registers, and update
620 // uses with PHI source register or the new registers.
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000621 DuplicateInstruction(MI, TailBB, PredBB, MF, LocalVRMap, UsedByPhi);
Evan Cheng111e7622009-12-03 08:43:53 +0000622 }
Bob Wilson15acadd2009-11-26 00:32:21 +0000623 }
Evan Cheng75eb5352009-12-07 10:15:19 +0000624 MachineBasicBlock::iterator Loc = PredBB->getFirstTerminator();
Evan Cheng3466f132009-12-15 01:44:10 +0000625 for (unsigned i = 0, e = CopyInfos.size(); i != e; ++i) {
Jakob Stoklund Olesen1e1098c2010-07-10 22:42:59 +0000626 Copies.push_back(BuildMI(*PredBB, Loc, DebugLoc(),
627 TII->get(TargetOpcode::COPY),
628 CopyInfos[i].first).addReg(CopyInfos[i].second));
Evan Cheng75eb5352009-12-07 10:15:19 +0000629 }
Rafael Espindolaec324e52011-06-17 05:54:50 +0000630
631 // Simplify
632 TII->AnalyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true);
633
Bob Wilson15acadd2009-11-26 00:32:21 +0000634 NumInstrDups += TailBB->size() - 1; // subtract one for removed branch
635
636 // Update the CFG.
637 PredBB->removeSuccessor(PredBB->succ_begin());
638 assert(PredBB->succ_empty() &&
639 "TailDuplicate called on block with multiple successors!");
640 for (MachineBasicBlock::succ_iterator I = TailBB->succ_begin(),
Evan Cheng79fc6f42009-12-04 09:42:45 +0000641 E = TailBB->succ_end(); I != E; ++I)
642 PredBB->addSuccessor(*I);
Bob Wilson15acadd2009-11-26 00:32:21 +0000643
644 Changed = true;
645 ++NumTailDups;
646 }
647
648 // If TailBB was duplicated into all its predecessors except for the prior
649 // block, which falls through unconditionally, move the contents of this
650 // block into the prior block.
Evan Cheng79fc6f42009-12-04 09:42:45 +0000651 MachineBasicBlock *PrevBB = prior(MachineFunction::iterator(TailBB));
Bob Wilson15acadd2009-11-26 00:32:21 +0000652 MachineBasicBlock *PriorTBB = 0, *PriorFBB = 0;
653 SmallVector<MachineOperand, 4> PriorCond;
Bob Wilson15acadd2009-11-26 00:32:21 +0000654 // This has to check PrevBB->succ_size() because EH edges are ignored by
655 // AnalyzeBranch.
Rafael Espindolaa899b222011-06-09 21:43:25 +0000656 if (PrevBB->succ_size() == 1 &&
657 !TII->AnalyzeBranch(*PrevBB, PriorTBB, PriorFBB, PriorCond, true) &&
658 PriorCond.empty() && !PriorTBB && TailBB->pred_size() == 1 &&
Bob Wilson15acadd2009-11-26 00:32:21 +0000659 !TailBB->hasAddressTaken()) {
David Greene00dec1b2010-01-05 01:25:15 +0000660 DEBUG(dbgs() << "\nMerging into block: " << *PrevBB
Bob Wilson15acadd2009-11-26 00:32:21 +0000661 << "From MBB: " << *TailBB);
Evan Cheng79fc6f42009-12-04 09:42:45 +0000662 if (PreRegAlloc) {
663 DenseMap<unsigned, unsigned> LocalVRMap;
Evan Cheng3466f132009-12-15 01:44:10 +0000664 SmallVector<std::pair<unsigned,unsigned>, 4> CopyInfos;
Evan Cheng79fc6f42009-12-04 09:42:45 +0000665 MachineBasicBlock::iterator I = TailBB->begin();
666 // Process PHI instructions first.
Chris Lattner518bb532010-02-09 19:54:29 +0000667 while (I != TailBB->end() && I->isPHI()) {
Evan Cheng79fc6f42009-12-04 09:42:45 +0000668 // Replace the uses of the def of the PHI with the register coming
669 // from PredBB.
670 MachineInstr *MI = &*I++;
Rafael Espindola689d7d52011-06-09 23:22:56 +0000671 ProcessPHI(MI, TailBB, PrevBB, LocalVRMap, CopyInfos, UsedByPhi, true);
Evan Cheng79fc6f42009-12-04 09:42:45 +0000672 if (MI->getParent())
673 MI->eraseFromParent();
674 }
675
676 // Now copy the non-PHI instructions.
677 while (I != TailBB->end()) {
678 // Replace def of virtual registers with new registers, and update
679 // uses with PHI source register or the new registers.
680 MachineInstr *MI = &*I++;
Rafael Espindola0f28c3f2011-06-09 22:53:47 +0000681 DuplicateInstruction(MI, TailBB, PrevBB, MF, LocalVRMap, UsedByPhi);
Evan Cheng79fc6f42009-12-04 09:42:45 +0000682 MI->eraseFromParent();
683 }
Evan Cheng75eb5352009-12-07 10:15:19 +0000684 MachineBasicBlock::iterator Loc = PrevBB->getFirstTerminator();
Evan Cheng3466f132009-12-15 01:44:10 +0000685 for (unsigned i = 0, e = CopyInfos.size(); i != e; ++i) {
Jakob Stoklund Olesen1e1098c2010-07-10 22:42:59 +0000686 Copies.push_back(BuildMI(*PrevBB, Loc, DebugLoc(),
687 TII->get(TargetOpcode::COPY),
688 CopyInfos[i].first)
689 .addReg(CopyInfos[i].second));
Evan Cheng75eb5352009-12-07 10:15:19 +0000690 }
Evan Cheng79fc6f42009-12-04 09:42:45 +0000691 } else {
692 // No PHIs to worry about, just splice the instructions over.
693 PrevBB->splice(PrevBB->end(), TailBB, TailBB->begin(), TailBB->end());
694 }
695 PrevBB->removeSuccessor(PrevBB->succ_begin());
696 assert(PrevBB->succ_empty());
697 PrevBB->transferSuccessors(TailBB);
Evan Cheng75eb5352009-12-07 10:15:19 +0000698 TDBBs.push_back(PrevBB);
Bob Wilson15acadd2009-11-26 00:32:21 +0000699 Changed = true;
700 }
701
Rafael Espindola689d7d52011-06-09 23:22:56 +0000702 // If this is after register allocation, there are no phis to fix.
703 if (!PreRegAlloc)
704 return Changed;
705
706 // If we made no changes so far, we are safe.
707 if (!Changed)
708 return Changed;
709
710
711 // Handle the nasty case in that we duplicated a block that is part of a loop
712 // into some but not all of its predecessors. For example:
Rafael Espindola4d7b4572011-06-09 23:51:45 +0000713 // 1 -> 2 <-> 3 |
714 // \ |
715 // \---> rest |
Rafael Espindola689d7d52011-06-09 23:22:56 +0000716 // if we duplicate 2 into 1 but not into 3, we end up with
Rafael Espindola4d7b4572011-06-09 23:51:45 +0000717 // 12 -> 3 <-> 2 -> rest |
718 // \ / |
719 // \----->-----/ |
Rafael Espindola689d7d52011-06-09 23:22:56 +0000720 // If there was a "var = phi(1, 3)" in 2, it has to be ultimately replaced
721 // with a phi in 3 (which now dominates 2).
722 // What we do here is introduce a copy in 3 of the register defined by the
723 // phi, just like when we are duplicating 2 into 3, but we don't copy any
724 // real instructions or remove the 3 -> 2 edge from the phi in 2.
725 for (SmallSetVector<MachineBasicBlock *, 8>::iterator PI = Preds.begin(),
726 PE = Preds.end(); PI != PE; ++PI) {
727 MachineBasicBlock *PredBB = *PI;
728 if (std::find(TDBBs.begin(), TDBBs.end(), PredBB) != TDBBs.end())
729 continue;
730
731 // EH edges
732 if (PredBB->succ_size() != 1)
733 continue;
734
735 DenseMap<unsigned, unsigned> LocalVRMap;
736 SmallVector<std::pair<unsigned,unsigned>, 4> CopyInfos;
737 MachineBasicBlock::iterator I = TailBB->begin();
738 // Process PHI instructions first.
739 while (I != TailBB->end() && I->isPHI()) {
740 // Replace the uses of the def of the PHI with the register coming
741 // from PredBB.
742 MachineInstr *MI = &*I++;
743 ProcessPHI(MI, TailBB, PredBB, LocalVRMap, CopyInfos, UsedByPhi, false);
744 }
745 MachineBasicBlock::iterator Loc = PredBB->getFirstTerminator();
746 for (unsigned i = 0, e = CopyInfos.size(); i != e; ++i) {
747 Copies.push_back(BuildMI(*PredBB, Loc, DebugLoc(),
748 TII->get(TargetOpcode::COPY),
749 CopyInfos[i].first).addReg(CopyInfos[i].second));
750 }
751 }
752
Bob Wilson15acadd2009-11-26 00:32:21 +0000753 return Changed;
754}
755
756/// RemoveDeadBlock - Remove the specified dead machine basic block from the
757/// function, updating the CFG.
Bob Wilson2d521e52009-11-26 21:38:41 +0000758void TailDuplicatePass::RemoveDeadBlock(MachineBasicBlock *MBB) {
Bob Wilson15acadd2009-11-26 00:32:21 +0000759 assert(MBB->pred_empty() && "MBB must be dead!");
David Greene00dec1b2010-01-05 01:25:15 +0000760 DEBUG(dbgs() << "\nRemoving MBB: " << *MBB);
Bob Wilson15acadd2009-11-26 00:32:21 +0000761
762 // Remove all successors.
763 while (!MBB->succ_empty())
764 MBB->removeSuccessor(MBB->succ_end()-1);
765
Bob Wilson15acadd2009-11-26 00:32:21 +0000766 // Remove the block.
767 MBB->eraseFromParent();
768}