blob: 8ff08fbf036e53b1ac893318307047d34b83cdfc [file] [log] [blame]
Chris Lattner086c0142006-02-03 06:21:43 +00001Target Independent Opportunities:
2
Chris Lattnerf308ea02006-09-28 06:01:17 +00003//===---------------------------------------------------------------------===//
4
Chris Lattner9b62b452006-11-14 01:57:53 +00005With the recent changes to make the implicit def/use set explicit in
6machineinstrs, we should change the target descriptions for 'call' instructions
7so that the .td files don't list all the call-clobbered registers as implicit
8defs. Instead, these should be added by the code generator (e.g. on the dag).
9
10This has a number of uses:
11
121. PPC32/64 and X86 32/64 can avoid having multiple copies of call instructions
13 for their different impdef sets.
142. Targets with multiple calling convs (e.g. x86) which have different clobber
15 sets don't need copies of call instructions.
163. 'Interprocedural register allocation' can be done to reduce the clobber sets
17 of calls.
18
19//===---------------------------------------------------------------------===//
20
Nate Begeman81e80972006-03-17 01:40:33 +000021Make the PPC branch selector target independant
22
23//===---------------------------------------------------------------------===//
Chris Lattner086c0142006-02-03 06:21:43 +000024
25Get the C front-end to expand hypot(x,y) -> llvm.sqrt(x*x+y*y) when errno and
Chris Lattner2dae65d2008-12-10 01:30:48 +000026precision don't matter (ffastmath). Misc/mandel will like this. :) This isn't
27safe in general, even on darwin. See the libm implementation of hypot for
28examples (which special case when x/y are exactly zero to get signed zeros etc
29right).
Chris Lattner086c0142006-02-03 06:21:43 +000030
Chris Lattner086c0142006-02-03 06:21:43 +000031//===---------------------------------------------------------------------===//
32
33Solve this DAG isel folding deficiency:
34
35int X, Y;
36
37void fn1(void)
38{
39 X = X | (Y << 3);
40}
41
42compiles to
43
44fn1:
45 movl Y, %eax
46 shll $3, %eax
47 orl X, %eax
48 movl %eax, X
49 ret
50
51The problem is the store's chain operand is not the load X but rather
52a TokenFactor of the load X and load Y, which prevents the folding.
53
54There are two ways to fix this:
55
561. The dag combiner can start using alias analysis to realize that y/x
57 don't alias, making the store to X not dependent on the load from Y.
582. The generated isel could be made smarter in the case it can't
59 disambiguate the pointers.
60
61Number 1 is the preferred solution.
62
Evan Chenge617b082006-03-13 23:19:10 +000063This has been "fixed" by a TableGen hack. But that is a short term workaround
64which will be removed once the proper fix is made.
65
Chris Lattner086c0142006-02-03 06:21:43 +000066//===---------------------------------------------------------------------===//
67
Chris Lattnerb27b69f2006-03-04 01:19:34 +000068On targets with expensive 64-bit multiply, we could LSR this:
69
70for (i = ...; ++i) {
71 x = 1ULL << i;
72
73into:
74 long long tmp = 1;
75 for (i = ...; ++i, tmp+=tmp)
76 x = tmp;
77
78This would be a win on ppc32, but not x86 or ppc64.
79
Chris Lattnerad019932006-03-04 08:44:51 +000080//===---------------------------------------------------------------------===//
Chris Lattner5b0fe7d2006-03-05 20:00:08 +000081
82Shrink: (setlt (loadi32 P), 0) -> (setlt (loadi8 Phi), 0)
83
84//===---------------------------------------------------------------------===//
Chris Lattner549f27d22006-03-07 02:46:26 +000085
Chris Lattnerc20995e2006-03-11 20:17:08 +000086Reassociate should turn: X*X*X*X -> t=(X*X) (t*t) to eliminate a multiply.
87
88//===---------------------------------------------------------------------===//
89
Chris Lattner74cfb7d2006-03-11 20:20:40 +000090Interesting? testcase for add/shift/mul reassoc:
91
92int bar(int x, int y) {
93 return x*x*x+y+x*x*x*x*x*y*y*y*y;
94}
95int foo(int z, int n) {
96 return bar(z, n) + bar(2*z, 2*n);
97}
98
Chris Lattner5e14b0d2007-05-05 22:29:06 +000099Reassociate should handle the example in GCC PR16157.
100
Chris Lattner74cfb7d2006-03-11 20:20:40 +0000101//===---------------------------------------------------------------------===//
102
Chris Lattner82c78b22006-03-09 20:13:21 +0000103These two functions should generate the same code on big-endian systems:
104
105int g(int *j,int *l) { return memcmp(j,l,4); }
106int h(int *j, int *l) { return *j - *l; }
107
108this could be done in SelectionDAGISel.cpp, along with other special cases,
109for 1,2,4,8 bytes.
110
111//===---------------------------------------------------------------------===//
112
Chris Lattnerc04b4232006-03-22 07:33:46 +0000113It would be nice to revert this patch:
114http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20060213/031986.html
115
116And teach the dag combiner enough to simplify the code expanded before
117legalize. It seems plausible that this knowledge would let it simplify other
118stuff too.
119
Chris Lattnere6cd96d2006-03-24 19:59:17 +0000120//===---------------------------------------------------------------------===//
121
Reid Spencerac9dcb92007-02-15 03:39:18 +0000122For vector types, TargetData.cpp::getTypeInfo() returns alignment that is equal
Evan Cheng67d3d4c2006-03-31 22:35:14 +0000123to the type size. It works but can be overly conservative as the alignment of
Reid Spencerac9dcb92007-02-15 03:39:18 +0000124specific vector types are target dependent.
Chris Lattnereaa7c062006-04-01 04:08:29 +0000125
126//===---------------------------------------------------------------------===//
127
Dan Gohman1f3be1a2009-05-11 18:51:16 +0000128We should produce an unaligned load from code like this:
Chris Lattnereaa7c062006-04-01 04:08:29 +0000129
130v4sf example(float *P) {
131 return (v4sf){P[0], P[1], P[2], P[3] };
132}
133
134//===---------------------------------------------------------------------===//
135
Chris Lattner16abfdf2006-05-18 18:26:13 +0000136Add support for conditional increments, and other related patterns. Instead
137of:
138
139 movl 136(%esp), %eax
140 cmpl $0, %eax
141 je LBB16_2 #cond_next
142LBB16_1: #cond_true
143 incl _foo
144LBB16_2: #cond_next
145
146emit:
147 movl _foo, %eax
148 cmpl $1, %edi
149 sbbl $-1, %eax
150 movl %eax, _foo
151
152//===---------------------------------------------------------------------===//
Chris Lattner870cf1b2006-05-19 20:45:08 +0000153
154Combine: a = sin(x), b = cos(x) into a,b = sincos(x).
155
156Expand these to calls of sin/cos and stores:
157 double sincos(double x, double *sin, double *cos);
158 float sincosf(float x, float *sin, float *cos);
159 long double sincosl(long double x, long double *sin, long double *cos);
160
161Doing so could allow SROA of the destination pointers. See also:
162http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687
163
Chris Lattner2dae65d2008-12-10 01:30:48 +0000164This is now easily doable with MRVs. We could even make an intrinsic for this
165if anyone cared enough about sincos.
166
Chris Lattner870cf1b2006-05-19 20:45:08 +0000167//===---------------------------------------------------------------------===//
Chris Lattnerf00f68a2006-05-19 21:01:38 +0000168
Chris Lattnere8263e62006-05-21 03:57:07 +0000169Turn this into a single byte store with no load (the other 3 bytes are
170unmodified):
171
Dan Gohman5c8274b2009-05-11 18:04:52 +0000172define void @test(i32* %P) {
173 %tmp = load i32* %P
174 %tmp14 = or i32 %tmp, 3305111552
175 %tmp15 = and i32 %tmp14, 3321888767
176 store i32 %tmp15, i32* %P
Chris Lattnere8263e62006-05-21 03:57:07 +0000177 ret void
178}
179
Chris Lattner9e18ef52006-05-30 21:29:15 +0000180//===---------------------------------------------------------------------===//
181
182dag/inst combine "clz(x)>>5 -> x==0" for 32-bit x.
183
184Compile:
185
186int bar(int x)
187{
188 int t = __builtin_clz(x);
189 return -(t>>5);
190}
191
192to:
193
194_bar: addic r3,r3,-1
195 subfe r3,r3,r3
196 blr
197
Chris Lattnercbce2f62006-09-15 20:31:36 +0000198//===---------------------------------------------------------------------===//
199
Chris Lattner7ed96ab2006-09-16 23:57:51 +0000200quantum_sigma_x in 462.libquantum contains the following loop:
201
202 for(i=0; i<reg->size; i++)
203 {
204 /* Flip the target bit of each basis state */
205 reg->node[i].state ^= ((MAX_UNSIGNED) 1 << target);
206 }
207
208Where MAX_UNSIGNED/state is a 64-bit int. On a 32-bit platform it would be just
209so cool to turn it into something like:
210
Chris Lattnerb33a42a2006-09-18 04:54:35 +0000211 long long Res = ((MAX_UNSIGNED) 1 << target);
Chris Lattner7ed96ab2006-09-16 23:57:51 +0000212 if (target < 32) {
213 for(i=0; i<reg->size; i++)
Chris Lattnerb33a42a2006-09-18 04:54:35 +0000214 reg->node[i].state ^= Res & 0xFFFFFFFFULL;
Chris Lattner7ed96ab2006-09-16 23:57:51 +0000215 } else {
216 for(i=0; i<reg->size; i++)
Chris Lattnerb33a42a2006-09-18 04:54:35 +0000217 reg->node[i].state ^= Res & 0xFFFFFFFF00000000ULL
Chris Lattner7ed96ab2006-09-16 23:57:51 +0000218 }
219
220... which would only do one 32-bit XOR per loop iteration instead of two.
221
222It would also be nice to recognize the reg->size doesn't alias reg->node[i], but
223alas...
224
225//===---------------------------------------------------------------------===//
Chris Lattnerfb981f32006-09-25 17:12:14 +0000226
Chris Lattnerb1ac7692008-10-05 02:16:12 +0000227This isn't recognized as bswap by instcombine (yes, it really is bswap):
Chris Lattnerf9bae432006-12-08 02:01:32 +0000228
229unsigned long reverse(unsigned v) {
230 unsigned t;
231 t = v ^ ((v << 16) | (v >> 16));
232 t &= ~0xff0000;
233 v = (v << 24) | (v >> 8);
234 return v ^ (t >> 8);
235}
236
Chris Lattnerfb981f32006-09-25 17:12:14 +0000237//===---------------------------------------------------------------------===//
238
Chris Lattnerf4fee2a2008-10-15 16:02:15 +0000239These idioms should be recognized as popcount (see PR1488):
240
241unsigned countbits_slow(unsigned v) {
242 unsigned c;
243 for (c = 0; v; v >>= 1)
244 c += v & 1;
245 return c;
246}
247unsigned countbits_fast(unsigned v){
248 unsigned c;
249 for (c = 0; v; c++)
250 v &= v - 1; // clear the least significant bit set
251 return c;
252}
253
254BITBOARD = unsigned long long
255int PopCnt(register BITBOARD a) {
256 register int c=0;
257 while(a) {
258 c++;
259 a &= a - 1;
260 }
261 return c;
262}
263unsigned int popcount(unsigned int input) {
264 unsigned int count = 0;
265 for (unsigned int i = 0; i < 4 * 8; i++)
266 count += (input >> i) & i;
267 return count;
268}
269
270//===---------------------------------------------------------------------===//
271
Chris Lattnerfb981f32006-09-25 17:12:14 +0000272These should turn into single 16-bit (unaligned?) loads on little/big endian
273processors.
274
275unsigned short read_16_le(const unsigned char *adr) {
276 return adr[0] | (adr[1] << 8);
277}
278unsigned short read_16_be(const unsigned char *adr) {
279 return (adr[0] << 8) | adr[1];
280}
281
282//===---------------------------------------------------------------------===//
Chris Lattnercf103912006-10-24 16:12:47 +0000283
Reid Spencer1628cec2006-10-26 06:15:43 +0000284-instcombine should handle this transform:
Reid Spencere4d87aa2006-12-23 06:05:41 +0000285 icmp pred (sdiv X / C1 ), C2
Reid Spencer1628cec2006-10-26 06:15:43 +0000286when X, C1, and C2 are unsigned. Similarly for udiv and signed operands.
287
288Currently InstCombine avoids this transform but will do it when the signs of
289the operands and the sign of the divide match. See the FIXME in
290InstructionCombining.cpp in the visitSetCondInst method after the switch case
291for Instruction::UDiv (around line 4447) for more details.
292
293The SingleSource/Benchmarks/Shootout-C++/hash and hash2 tests have examples of
294this construct.
Chris Lattnerd7c628d2006-11-03 22:27:39 +0000295
296//===---------------------------------------------------------------------===//
297
Chris Lattner578d2df2006-11-10 00:23:26 +0000298viterbi speeds up *significantly* if the various "history" related copy loops
299are turned into memcpy calls at the source level. We need a "loops to memcpy"
300pass.
301
302//===---------------------------------------------------------------------===//
Nick Lewyckybf637342006-11-13 00:23:28 +0000303
Chris Lattner03a6d962007-01-16 06:39:48 +0000304Consider:
305
306typedef unsigned U32;
307typedef unsigned long long U64;
308int test (U32 *inst, U64 *regs) {
309 U64 effective_addr2;
310 U32 temp = *inst;
311 int r1 = (temp >> 20) & 0xf;
312 int b2 = (temp >> 16) & 0xf;
313 effective_addr2 = temp & 0xfff;
314 if (b2) effective_addr2 += regs[b2];
315 b2 = (temp >> 12) & 0xf;
316 if (b2) effective_addr2 += regs[b2];
317 effective_addr2 &= regs[4];
318 if ((effective_addr2 & 3) == 0)
319 return 1;
320 return 0;
321}
322
323Note that only the low 2 bits of effective_addr2 are used. On 32-bit systems,
324we don't eliminate the computation of the top half of effective_addr2 because
325we don't have whole-function selection dags. On x86, this means we use one
326extra register for the function when effective_addr2 is declared as U64 than
327when it is declared U32.
328
329//===---------------------------------------------------------------------===//
330
Chris Lattner1a77a552007-03-24 06:01:32 +0000331LSR should know what GPR types a target has. This code:
332
333volatile short X, Y; // globals
334
335void foo(int N) {
336 int i;
337 for (i = 0; i < N; i++) { X = i; Y = i*4; }
338}
339
Chris Lattnerc1491f32009-09-20 17:37:38 +0000340produces two near identical IV's (after promotion) on PPC/ARM:
Chris Lattner1a77a552007-03-24 06:01:32 +0000341
Chris Lattnerc1491f32009-09-20 17:37:38 +0000342LBB1_2:
343 ldr r3, LCPI1_0
344 ldr r3, [r3]
345 strh r2, [r3]
346 ldr r3, LCPI1_1
347 ldr r3, [r3]
348 strh r1, [r3]
349 add r1, r1, #4
350 add r2, r2, #1 <- [0,+,1]
351 sub r0, r0, #1 <- [0,-,1]
352 cmp r0, #0
353 bne LBB1_2
354
355LSR should reuse the "+" IV for the exit test.
Chris Lattner1a77a552007-03-24 06:01:32 +0000356
357
358//===---------------------------------------------------------------------===//
359
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000360Tail call elim should be more aggressive, checking to see if the call is
361followed by an uncond branch to an exit block.
362
363; This testcase is due to tail-duplication not wanting to copy the return
364; instruction into the terminating blocks because there was other code
365; optimized out of the function after the taildup happened.
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000366; RUN: llvm-as < %s | opt -tailcallelim | llvm-dis | not grep call
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000367
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000368define i32 @t4(i32 %a) {
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000369entry:
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000370 %tmp.1 = and i32 %a, 1 ; <i32> [#uses=1]
371 %tmp.2 = icmp ne i32 %tmp.1, 0 ; <i1> [#uses=1]
372 br i1 %tmp.2, label %then.0, label %else.0
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000373
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000374then.0: ; preds = %entry
375 %tmp.5 = add i32 %a, -1 ; <i32> [#uses=1]
376 %tmp.3 = call i32 @t4( i32 %tmp.5 ) ; <i32> [#uses=1]
377 br label %return
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000378
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000379else.0: ; preds = %entry
380 %tmp.7 = icmp ne i32 %a, 0 ; <i1> [#uses=1]
381 br i1 %tmp.7, label %then.1, label %return
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000382
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000383then.1: ; preds = %else.0
384 %tmp.11 = add i32 %a, -2 ; <i32> [#uses=1]
385 %tmp.9 = call i32 @t4( i32 %tmp.11 ) ; <i32> [#uses=1]
386 br label %return
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000387
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000388return: ; preds = %then.1, %else.0, %then.0
389 %result.0 = phi i32 [ 0, %else.0 ], [ %tmp.3, %then.0 ],
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000390 [ %tmp.9, %then.1 ]
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000391 ret i32 %result.0
Chris Lattner5e14b0d2007-05-05 22:29:06 +0000392}
Chris Lattnerf110a2b2007-05-05 22:44:08 +0000393
394//===---------------------------------------------------------------------===//
395
Chris Lattnere1bb6ab2007-10-03 06:10:59 +0000396Tail recursion elimination is not transforming this function, because it is
397returning n, which fails the isDynamicConstant check in the accumulator
398recursion checks.
399
400long long fib(const long long n) {
401 switch(n) {
402 case 0:
403 case 1:
404 return n;
405 default:
406 return fib(n-1) + fib(n-2);
407 }
408}
409
410//===---------------------------------------------------------------------===//
411
Chris Lattnerc90b8662008-08-10 00:47:21 +0000412Tail recursion elimination should handle:
413
414int pow2m1(int n) {
415 if (n == 0)
416 return 0;
417 return 2 * pow2m1 (n - 1) + 1;
418}
419
420Also, multiplies can be turned into SHL's, so they should be handled as if
421they were associative. "return foo() << 1" can be tail recursion eliminated.
422
423//===---------------------------------------------------------------------===//
424
Chris Lattnerf110a2b2007-05-05 22:44:08 +0000425Argument promotion should promote arguments for recursive functions, like
426this:
427
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000428; RUN: llvm-as < %s | opt -argpromotion | llvm-dis | grep x.val
Chris Lattnerf110a2b2007-05-05 22:44:08 +0000429
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000430define internal i32 @foo(i32* %x) {
Chris Lattnerf110a2b2007-05-05 22:44:08 +0000431entry:
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000432 %tmp = load i32* %x ; <i32> [#uses=0]
433 %tmp.foo = call i32 @foo( i32* %x ) ; <i32> [#uses=1]
434 ret i32 %tmp.foo
Chris Lattnerf110a2b2007-05-05 22:44:08 +0000435}
436
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000437define i32 @bar(i32* %x) {
Chris Lattnerf110a2b2007-05-05 22:44:08 +0000438entry:
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000439 %tmp3 = call i32 @foo( i32* %x ) ; <i32> [#uses=1]
440 ret i32 %tmp3
Chris Lattnerf110a2b2007-05-05 22:44:08 +0000441}
442
Chris Lattner81f2d712007-12-05 23:05:06 +0000443//===---------------------------------------------------------------------===//
Chris Lattner166a2682007-12-28 04:42:05 +0000444
445"basicaa" should know how to look through "or" instructions that act like add
446instructions. For example in this code, the x*4+1 is turned into x*4 | 1, and
447basicaa can't analyze the array subscript, leading to duplicated loads in the
448generated code:
449
450void test(int X, int Y, int a[]) {
451int i;
452 for (i=2; i<1000; i+=4) {
453 a[i+0] = a[i-1+0]*a[i-2+0];
454 a[i+1] = a[i-1+1]*a[i-2+1];
455 a[i+2] = a[i-1+2]*a[i-2+2];
456 a[i+3] = a[i-1+3]*a[i-2+3];
457 }
458}
459
Chris Lattner2dae65d2008-12-10 01:30:48 +0000460BasicAA also doesn't do this for add. It needs to know that &A[i+1] != &A[i].
461
Chris Lattnera1643ba2007-12-28 22:30:05 +0000462//===---------------------------------------------------------------------===//
Chris Lattner166a2682007-12-28 04:42:05 +0000463
Chris Lattnera1643ba2007-12-28 22:30:05 +0000464We should investigate an instruction sinking pass. Consider this silly
465example in pic mode:
466
467#include <assert.h>
468void foo(int x) {
469 assert(x);
470 //...
471}
472
473we compile this to:
474_foo:
475 subl $28, %esp
476 call "L1$pb"
477"L1$pb":
478 popl %eax
479 cmpl $0, 32(%esp)
480 je LBB1_2 # cond_true
481LBB1_1: # return
482 # ...
483 addl $28, %esp
484 ret
485LBB1_2: # cond_true
486...
487
488The PIC base computation (call+popl) is only used on one path through the
489code, but is currently always computed in the entry block. It would be
490better to sink the picbase computation down into the block for the
491assertion, as it is the only one that uses it. This happens for a lot of
492code with early outs.
493
Chris Lattner92c06a02007-12-29 01:05:01 +0000494Another example is loads of arguments, which are usually emitted into the
495entry block on targets like x86. If not used in all paths through a
496function, they should be sunk into the ones that do.
497
Chris Lattnera1643ba2007-12-28 22:30:05 +0000498In this case, whole-function-isel would also handle this.
Chris Lattner166a2682007-12-28 04:42:05 +0000499
500//===---------------------------------------------------------------------===//
Chris Lattnerb3041942008-01-07 21:38:14 +0000501
502Investigate lowering of sparse switch statements into perfect hash tables:
503http://burtleburtle.net/bob/hash/perfect.html
504
505//===---------------------------------------------------------------------===//
Chris Lattnerf61b63e2008-01-09 00:17:57 +0000506
507We should turn things like "load+fabs+store" and "load+fneg+store" into the
508corresponding integer operations. On a yonah, this loop:
509
510double a[256];
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000511void foo() {
512 int i, b;
513 for (b = 0; b < 10000000; b++)
514 for (i = 0; i < 256; i++)
515 a[i] = -a[i];
516}
Chris Lattnerf61b63e2008-01-09 00:17:57 +0000517
518is twice as slow as this loop:
519
520long long a[256];
Chris Lattner7c4e9a42008-02-18 18:46:39 +0000521void foo() {
522 int i, b;
523 for (b = 0; b < 10000000; b++)
524 for (i = 0; i < 256; i++)
525 a[i] ^= (1ULL << 63);
526}
Chris Lattnerf61b63e2008-01-09 00:17:57 +0000527
528and I suspect other processors are similar. On X86 in particular this is a
529big win because doing this with integers allows the use of read/modify/write
530instructions.
531
532//===---------------------------------------------------------------------===//
Chris Lattner83726012008-01-10 18:25:41 +0000533
534DAG Combiner should try to combine small loads into larger loads when
535profitable. For example, we compile this C++ example:
536
537struct THotKey { short Key; bool Control; bool Shift; bool Alt; };
538extern THotKey m_HotKey;
539THotKey GetHotKey () { return m_HotKey; }
540
541into (-O3 -fno-exceptions -static -fomit-frame-pointer):
542
543__Z9GetHotKeyv:
544 pushl %esi
545 movl 8(%esp), %eax
546 movb _m_HotKey+3, %cl
547 movb _m_HotKey+4, %dl
548 movb _m_HotKey+2, %ch
549 movw _m_HotKey, %si
550 movw %si, (%eax)
551 movb %ch, 2(%eax)
552 movb %cl, 3(%eax)
553 movb %dl, 4(%eax)
554 popl %esi
555 ret $4
556
557GCC produces:
558
559__Z9GetHotKeyv:
560 movl _m_HotKey, %edx
561 movl 4(%esp), %eax
562 movl %edx, (%eax)
563 movzwl _m_HotKey+4, %edx
564 movw %dx, 4(%eax)
565 ret $4
566
567The LLVM IR contains the needed alignment info, so we should be able to
568merge the loads and stores into 4-byte loads:
569
570 %struct.THotKey = type { i16, i8, i8, i8 }
571define void @_Z9GetHotKeyv(%struct.THotKey* sret %agg.result) nounwind {
572...
573 %tmp2 = load i16* getelementptr (@m_HotKey, i32 0, i32 0), align 8
574 %tmp5 = load i8* getelementptr (@m_HotKey, i32 0, i32 1), align 2
575 %tmp8 = load i8* getelementptr (@m_HotKey, i32 0, i32 2), align 1
576 %tmp11 = load i8* getelementptr (@m_HotKey, i32 0, i32 3), align 2
577
578Alternatively, we should use a small amount of base-offset alias analysis
579to make it so the scheduler doesn't need to hold all the loads in regs at
580once.
581
582//===---------------------------------------------------------------------===//
Chris Lattner497b7e92008-01-11 06:17:47 +0000583
Nate Begemane9fe65c2008-02-18 18:39:23 +0000584We should add an FRINT node to the DAG to model targets that have legal
585implementations of ceil/floor/rint.
Chris Lattner48840f82008-02-28 05:34:27 +0000586
587//===---------------------------------------------------------------------===//
588
589Consider:
590
591int test() {
592 long long input[8] = {1,1,1,1,1,1,1,1};
593 foo(input);
594}
595
596We currently compile this into a memcpy from a global array since the
597initializer is fairly large and not memset'able. This is good, but the memcpy
598gets lowered to load/stores in the code generator. This is also ok, except
599that the codegen lowering for memcpy doesn't handle the case when the source
600is a constant global. This gives us atrocious code like this:
601
602 call "L1$pb"
603"L1$pb":
604 popl %eax
605 movl _C.0.1444-"L1$pb"+32(%eax), %ecx
606 movl %ecx, 40(%esp)
607 movl _C.0.1444-"L1$pb"+20(%eax), %ecx
608 movl %ecx, 28(%esp)
609 movl _C.0.1444-"L1$pb"+36(%eax), %ecx
610 movl %ecx, 44(%esp)
611 movl _C.0.1444-"L1$pb"+44(%eax), %ecx
612 movl %ecx, 52(%esp)
613 movl _C.0.1444-"L1$pb"+40(%eax), %ecx
614 movl %ecx, 48(%esp)
615 movl _C.0.1444-"L1$pb"+12(%eax), %ecx
616 movl %ecx, 20(%esp)
617 movl _C.0.1444-"L1$pb"+4(%eax), %ecx
618...
619
620instead of:
621 movl $1, 16(%esp)
622 movl $0, 20(%esp)
623 movl $1, 24(%esp)
624 movl $0, 28(%esp)
625 movl $1, 32(%esp)
626 movl $0, 36(%esp)
627 ...
628
629//===---------------------------------------------------------------------===//
Chris Lattnera11deb02008-03-02 02:51:40 +0000630
631http://llvm.org/PR717:
632
633The following code should compile into "ret int undef". Instead, LLVM
634produces "ret int 0":
635
636int f() {
637 int x = 4;
638 int y;
639 if (x == 3) y = 0;
640 return y;
641}
642
643//===---------------------------------------------------------------------===//
Chris Lattner53b72772008-03-02 19:29:42 +0000644
645The loop unroller should partially unroll loops (instead of peeling them)
646when code growth isn't too bad and when an unroll count allows simplification
647of some code within the loop. One trivial example is:
648
649#include <stdio.h>
650int main() {
651 int nRet = 17;
652 int nLoop;
653 for ( nLoop = 0; nLoop < 1000; nLoop++ ) {
654 if ( nLoop & 1 )
655 nRet += 2;
656 else
657 nRet -= 1;
658 }
659 return nRet;
660}
661
662Unrolling by 2 would eliminate the '&1' in both copies, leading to a net
663reduction in code size. The resultant code would then also be suitable for
664exit value computation.
665
666//===---------------------------------------------------------------------===//
Chris Lattner349155b2008-03-17 01:47:51 +0000667
668We miss a bunch of rotate opportunities on various targets, including ppc, x86,
669etc. On X86, we miss a bunch of 'rotate by variable' cases because the rotate
670matching code in dag combine doesn't look through truncates aggressively
671enough. Here are some testcases reduces from GCC PR17886:
672
673unsigned long long f(unsigned long long x, int y) {
674 return (x << y) | (x >> 64-y);
675}
676unsigned f2(unsigned x, int y){
677 return (x << y) | (x >> 32-y);
678}
679unsigned long long f3(unsigned long long x){
680 int y = 9;
681 return (x << y) | (x >> 64-y);
682}
683unsigned f4(unsigned x){
684 int y = 10;
685 return (x << y) | (x >> 32-y);
686}
687unsigned long long f5(unsigned long long x, unsigned long long y) {
688 return (x << 8) | ((y >> 48) & 0xffull);
689}
690unsigned long long f6(unsigned long long x, unsigned long long y, int z) {
691 switch(z) {
692 case 1:
693 return (x << 8) | ((y >> 48) & 0xffull);
694 case 2:
695 return (x << 16) | ((y >> 40) & 0xffffull);
696 case 3:
697 return (x << 24) | ((y >> 32) & 0xffffffull);
698 case 4:
699 return (x << 32) | ((y >> 24) & 0xffffffffull);
700 default:
701 return (x << 40) | ((y >> 16) & 0xffffffffffull);
702 }
703}
704
Dan Gohmancb747c52008-10-17 21:39:27 +0000705On X86-64, we only handle f2/f3/f4 right. On x86-32, a few of these
Chris Lattner349155b2008-03-17 01:47:51 +0000706generate truly horrible code, instead of using shld and friends. On
707ARM, we end up with calls to L___lshrdi3/L___ashldi3 in f, which is
708badness. PPC64 misses f, f5 and f6. CellSPU aborts in isel.
709
710//===---------------------------------------------------------------------===//
Chris Lattnerf70107f2008-03-20 04:46:13 +0000711
712We do a number of simplifications in simplify libcalls to strength reduce
713standard library functions, but we don't currently merge them together. For
714example, it is useful to merge memcpy(a,b,strlen(b)) -> strcpy. This can only
715be done safely if "b" isn't modified between the strlen and memcpy of course.
716
717//===---------------------------------------------------------------------===//
718
Chris Lattner10c5d362008-07-14 00:19:59 +0000719Reassociate should turn things like:
720
721int factorial(int X) {
722 return X*X*X*X*X*X*X*X;
723}
724
725into llvm.powi calls, allowing the code generator to produce balanced
726multiplication trees.
727
728//===---------------------------------------------------------------------===//
729
Chris Lattner26e150f2008-08-10 01:14:08 +0000730We generate a horrible libcall for llvm.powi. For example, we compile:
731
732#include <cmath>
733double f(double a) { return std::pow(a, 4); }
734
735into:
736
737__Z1fd:
738 subl $12, %esp
739 movsd 16(%esp), %xmm0
740 movsd %xmm0, (%esp)
741 movl $4, 8(%esp)
742 call L___powidf2$stub
743 addl $12, %esp
744 ret
745
746GCC produces:
747
748__Z1fd:
749 subl $12, %esp
750 movsd 16(%esp), %xmm0
751 mulsd %xmm0, %xmm0
752 mulsd %xmm0, %xmm0
753 movsd %xmm0, (%esp)
754 fldl (%esp)
755 addl $12, %esp
756 ret
757
758//===---------------------------------------------------------------------===//
759
760We compile this program: (from GCC PR11680)
761http://gcc.gnu.org/bugzilla/attachment.cgi?id=4487
762
763Into code that runs the same speed in fast/slow modes, but both modes run 2x
764slower than when compile with GCC (either 4.0 or 4.2):
765
766$ llvm-g++ perf.cpp -O3 -fno-exceptions
767$ time ./a.out fast
7681.821u 0.003s 0:01.82 100.0% 0+0k 0+0io 0pf+0w
769
770$ g++ perf.cpp -O3 -fno-exceptions
771$ time ./a.out fast
7720.821u 0.001s 0:00.82 100.0% 0+0k 0+0io 0pf+0w
773
774It looks like we are making the same inlining decisions, so this may be raw
775codegen badness or something else (haven't investigated).
776
777//===---------------------------------------------------------------------===//
778
779We miss some instcombines for stuff like this:
780void bar (void);
781void foo (unsigned int a) {
782 /* This one is equivalent to a >= (3 << 2). */
783 if ((a >> 2) >= 3)
784 bar ();
785}
786
787A few other related ones are in GCC PR14753.
788
789//===---------------------------------------------------------------------===//
790
791Divisibility by constant can be simplified (according to GCC PR12849) from
792being a mulhi to being a mul lo (cheaper). Testcase:
793
794void bar(unsigned n) {
795 if (n % 3 == 0)
796 true();
797}
798
799I think this basically amounts to a dag combine to simplify comparisons against
800multiply hi's into a comparison against the mullo.
801
802//===---------------------------------------------------------------------===//
Chris Lattner23f35bc2008-08-19 06:22:16 +0000803
Chris Lattnerdb039832008-10-15 16:06:03 +0000804Better mod/ref analysis for scanf would allow us to eliminate the vtable and a
805bunch of other stuff from this example (see PR1604):
806
807#include <cstdio>
808struct test {
809 int val;
810 virtual ~test() {}
811};
812
813int main() {
814 test t;
815 std::scanf("%d", &t.val);
816 std::printf("%d\n", t.val);
817}
818
819//===---------------------------------------------------------------------===//
820
Chris Lattner3b364cb2008-10-15 16:33:52 +0000821Instcombine will merge comparisons like (x >= 10) && (x < 20) by producing (x -
82210) u< 10, but only when the comparisons have matching sign.
823
824This could be converted with a similiar technique. (PR1941)
825
826define i1 @test(i8 %x) {
827 %A = icmp uge i8 %x, 5
828 %B = icmp slt i8 %x, 20
829 %C = and i1 %A, %B
830 ret i1 %C
831}
832
833//===---------------------------------------------------------------------===//
Nick Lewyckydf563ca2008-11-27 22:12:22 +0000834
Nick Lewyckyd2f0db12008-11-27 22:41:45 +0000835These functions perform the same computation, but produce different assembly.
Nick Lewyckydf563ca2008-11-27 22:12:22 +0000836
837define i8 @select(i8 %x) readnone nounwind {
838 %A = icmp ult i8 %x, 250
839 %B = select i1 %A, i8 0, i8 1
840 ret i8 %B
841}
842
843define i8 @addshr(i8 %x) readnone nounwind {
844 %A = zext i8 %x to i9
845 %B = add i9 %A, 6 ;; 256 - 250 == 6
846 %C = lshr i9 %B, 8
847 %D = trunc i9 %C to i8
848 ret i8 %D
849}
850
851//===---------------------------------------------------------------------===//
Eli Friedman4e16b292008-11-30 07:36:04 +0000852
853From gcc bug 24696:
854int
855f (unsigned long a, unsigned long b, unsigned long c)
856{
857 return ((a & (c - 1)) != 0) || ((b & (c - 1)) != 0);
858}
859int
860f (unsigned long a, unsigned long b, unsigned long c)
861{
862 return ((a & (c - 1)) != 0) | ((b & (c - 1)) != 0);
863}
864Both should combine to ((a|b) & (c-1)) != 0. Currently not optimized with
865"clang -emit-llvm-bc | opt -std-compile-opts".
866
867//===---------------------------------------------------------------------===//
868
869From GCC Bug 20192:
870#define PMD_MASK (~((1UL << 23) - 1))
871void clear_pmd_range(unsigned long start, unsigned long end)
872{
873 if (!(start & ~PMD_MASK) && !(end & ~PMD_MASK))
874 f();
875}
876The expression should optimize to something like
877"!((start|end)&~PMD_MASK). Currently not optimized with "clang
878-emit-llvm-bc | opt -std-compile-opts".
879
880//===---------------------------------------------------------------------===//
881
882From GCC Bug 15241:
883unsigned int
884foo (unsigned int a, unsigned int b)
885{
886 if (a <= 7 && b <= 7)
887 baz ();
888}
889Should combine to "(a|b) <= 7". Currently not optimized with "clang
890-emit-llvm-bc | opt -std-compile-opts".
891
892//===---------------------------------------------------------------------===//
893
894From GCC Bug 3756:
895int
896pn (int n)
897{
898 return (n >= 0 ? 1 : -1);
899}
900Should combine to (n >> 31) | 1. Currently not optimized with "clang
901-emit-llvm-bc | opt -std-compile-opts | llc".
902
903//===---------------------------------------------------------------------===//
904
905From GCC Bug 28685:
906int test(int a, int b)
907{
908 int lt = a < b;
909 int eq = a == b;
910
911 return (lt || eq);
912}
913Should combine to "a <= b". Currently not optimized with "clang
914-emit-llvm-bc | opt -std-compile-opts | llc".
915
916//===---------------------------------------------------------------------===//
917
918void a(int variable)
919{
920 if (variable == 4 || variable == 6)
921 bar();
922}
923This should optimize to "if ((variable | 2) == 6)". Currently not
924optimized with "clang -emit-llvm-bc | opt -std-compile-opts | llc".
925
926//===---------------------------------------------------------------------===//
927
928unsigned int f(unsigned int i, unsigned int n) {++i; if (i == n) ++i; return
929i;}
930unsigned int f2(unsigned int i, unsigned int n) {++i; i += i == n; return i;}
931These should combine to the same thing. Currently, the first function
932produces better code on X86.
933
934//===---------------------------------------------------------------------===//
935
Eli Friedman4e16b292008-11-30 07:36:04 +0000936From GCC Bug 15784:
937#define abs(x) x>0?x:-x
938int f(int x, int y)
939{
940 return (abs(x)) >= 0;
941}
942This should optimize to x == INT_MIN. (With -fwrapv.) Currently not
943optimized with "clang -emit-llvm-bc | opt -std-compile-opts".
944
945//===---------------------------------------------------------------------===//
946
947From GCC Bug 14753:
948void
949rotate_cst (unsigned int a)
950{
951 a = (a << 10) | (a >> 22);
952 if (a == 123)
953 bar ();
954}
955void
956minus_cst (unsigned int a)
957{
958 unsigned int tem;
959
960 tem = 20 - a;
961 if (tem == 5)
962 bar ();
963}
964void
965mask_gt (unsigned int a)
966{
967 /* This is equivalent to a > 15. */
968 if ((a & ~7) > 8)
969 bar ();
970}
971void
972rshift_gt (unsigned int a)
973{
974 /* This is equivalent to a > 23. */
975 if ((a >> 2) > 5)
976 bar ();
977}
978All should simplify to a single comparison. All of these are
979currently not optimized with "clang -emit-llvm-bc | opt
980-std-compile-opts".
981
982//===---------------------------------------------------------------------===//
983
984From GCC Bug 32605:
985int c(int* x) {return (char*)x+2 == (char*)x;}
986Should combine to 0. Currently not optimized with "clang
987-emit-llvm-bc | opt -std-compile-opts" (although llc can optimize it).
988
989//===---------------------------------------------------------------------===//
990
991int a(unsigned char* b) {return *b > 99;}
992There's an unnecessary zext in the generated code with "clang
993-emit-llvm-bc | opt -std-compile-opts".
994
995//===---------------------------------------------------------------------===//
996
Eli Friedman4e16b292008-11-30 07:36:04 +0000997int a(unsigned b) {return ((b << 31) | (b << 30)) >> 31;}
998Should be combined to "((b >> 1) | b) & 1". Currently not optimized
999with "clang -emit-llvm-bc | opt -std-compile-opts".
1000
1001//===---------------------------------------------------------------------===//
1002
1003unsigned a(unsigned x, unsigned y) { return x | (y & 1) | (y & 2);}
1004Should combine to "x | (y & 3)". Currently not optimized with "clang
1005-emit-llvm-bc | opt -std-compile-opts".
1006
1007//===---------------------------------------------------------------------===//
1008
1009unsigned a(unsigned a) {return ((a | 1) & 3) | (a & -4);}
1010Should combine to "a | 1". Currently not optimized with "clang
1011-emit-llvm-bc | opt -std-compile-opts".
1012
1013//===---------------------------------------------------------------------===//
1014
Eli Friedman4e16b292008-11-30 07:36:04 +00001015int a(int a, int b, int c) {return (~a & c) | ((c|a) & b);}
1016Should fold to "(~a & c) | (a & b)". Currently not optimized with
1017"clang -emit-llvm-bc | opt -std-compile-opts".
1018
1019//===---------------------------------------------------------------------===//
1020
1021int a(int a,int b) {return (~(a|b))|a;}
1022Should fold to "a|~b". Currently not optimized with "clang
1023-emit-llvm-bc | opt -std-compile-opts".
1024
1025//===---------------------------------------------------------------------===//
1026
1027int a(int a, int b) {return (a&&b) || (a&&!b);}
1028Should fold to "a". Currently not optimized with "clang -emit-llvm-bc
1029| opt -std-compile-opts".
1030
1031//===---------------------------------------------------------------------===//
1032
1033int a(int a, int b, int c) {return (a&&b) || (!a&&c);}
1034Should fold to "a ? b : c", or at least something sane. Currently not
1035optimized with "clang -emit-llvm-bc | opt -std-compile-opts".
1036
1037//===---------------------------------------------------------------------===//
1038
1039int a(int a, int b, int c) {return (a&&b) || (a&&c) || (a&&b&&c);}
1040Should fold to a && (b || c). Currently not optimized with "clang
1041-emit-llvm-bc | opt -std-compile-opts".
1042
1043//===---------------------------------------------------------------------===//
1044
1045int a(int x) {return x | ((x & 8) ^ 8);}
1046Should combine to x | 8. Currently not optimized with "clang
1047-emit-llvm-bc | opt -std-compile-opts".
1048
1049//===---------------------------------------------------------------------===//
1050
1051int a(int x) {return x ^ ((x & 8) ^ 8);}
1052Should also combine to x | 8. Currently not optimized with "clang
1053-emit-llvm-bc | opt -std-compile-opts".
1054
1055//===---------------------------------------------------------------------===//
1056
1057int a(int x) {return (x & 8) == 0 ? -1 : -9;}
1058Should combine to (x | -9) ^ 8. Currently not optimized with "clang
1059-emit-llvm-bc | opt -std-compile-opts".
1060
1061//===---------------------------------------------------------------------===//
1062
1063int a(int x) {return (x & 8) == 0 ? -9 : -1;}
1064Should combine to x | -9. Currently not optimized with "clang
1065-emit-llvm-bc | opt -std-compile-opts".
1066
1067//===---------------------------------------------------------------------===//
1068
1069int a(int x) {return ((x | -9) ^ 8) & x;}
1070Should combine to x & -9. Currently not optimized with "clang
1071-emit-llvm-bc | opt -std-compile-opts".
1072
1073//===---------------------------------------------------------------------===//
1074
1075unsigned a(unsigned a) {return a * 0x11111111 >> 28 & 1;}
1076Should combine to "a * 0x88888888 >> 31". Currently not optimized
1077with "clang -emit-llvm-bc | opt -std-compile-opts".
1078
1079//===---------------------------------------------------------------------===//
1080
1081unsigned a(char* x) {if ((*x & 32) == 0) return b();}
1082There's an unnecessary zext in the generated code with "clang
1083-emit-llvm-bc | opt -std-compile-opts".
1084
1085//===---------------------------------------------------------------------===//
1086
1087unsigned a(unsigned long long x) {return 40 * (x >> 1);}
1088Should combine to "20 * (((unsigned)x) & -2)". Currently not
1089optimized with "clang -emit-llvm-bc | opt -std-compile-opts".
1090
1091//===---------------------------------------------------------------------===//
Bill Wendling3bdcda82008-12-02 05:12:47 +00001092
Chris Lattner88d84b22008-12-02 06:32:34 +00001093This was noticed in the entryblock for grokdeclarator in 403.gcc:
1094
1095 %tmp = icmp eq i32 %decl_context, 4
1096 %decl_context_addr.0 = select i1 %tmp, i32 3, i32 %decl_context
1097 %tmp1 = icmp eq i32 %decl_context_addr.0, 1
1098 %decl_context_addr.1 = select i1 %tmp1, i32 0, i32 %decl_context_addr.0
1099
1100tmp1 should be simplified to something like:
1101 (!tmp || decl_context == 1)
1102
1103This allows recursive simplifications, tmp1 is used all over the place in
1104the function, e.g. by:
1105
1106 %tmp23 = icmp eq i32 %decl_context_addr.1, 0 ; <i1> [#uses=1]
1107 %tmp24 = xor i1 %tmp1, true ; <i1> [#uses=1]
1108 %or.cond8 = and i1 %tmp23, %tmp24 ; <i1> [#uses=1]
1109
1110later.
1111
Chris Lattner78a7e7c2008-12-06 19:28:22 +00001112//===---------------------------------------------------------------------===//
1113
1114Store sinking: This code:
1115
1116void f (int n, int *cond, int *res) {
1117 int i;
1118 *res = 0;
1119 for (i = 0; i < n; i++)
1120 if (*cond)
1121 *res ^= 234; /* (*) */
1122}
1123
1124On this function GVN hoists the fully redundant value of *res, but nothing
1125moves the store out. This gives us this code:
1126
1127bb: ; preds = %bb2, %entry
1128 %.rle = phi i32 [ 0, %entry ], [ %.rle6, %bb2 ]
1129 %i.05 = phi i32 [ 0, %entry ], [ %indvar.next, %bb2 ]
1130 %1 = load i32* %cond, align 4
1131 %2 = icmp eq i32 %1, 0
1132 br i1 %2, label %bb2, label %bb1
1133
1134bb1: ; preds = %bb
1135 %3 = xor i32 %.rle, 234
1136 store i32 %3, i32* %res, align 4
1137 br label %bb2
1138
1139bb2: ; preds = %bb, %bb1
1140 %.rle6 = phi i32 [ %3, %bb1 ], [ %.rle, %bb ]
1141 %indvar.next = add i32 %i.05, 1
1142 %exitcond = icmp eq i32 %indvar.next, %n
1143 br i1 %exitcond, label %return, label %bb
1144
1145DSE should sink partially dead stores to get the store out of the loop.
1146
Chris Lattner6a09a742008-12-06 22:52:12 +00001147Here's another partial dead case:
1148http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12395
1149
Chris Lattner78a7e7c2008-12-06 19:28:22 +00001150//===---------------------------------------------------------------------===//
1151
1152Scalar PRE hoists the mul in the common block up to the else:
1153
1154int test (int a, int b, int c, int g) {
1155 int d, e;
1156 if (a)
1157 d = b * c;
1158 else
1159 d = b - c;
1160 e = b * c + g;
1161 return d + e;
1162}
1163
1164It would be better to do the mul once to reduce codesize above the if.
1165This is GCC PR38204.
1166
1167//===---------------------------------------------------------------------===//
1168
1169GCC PR37810 is an interesting case where we should sink load/store reload
1170into the if block and outside the loop, so we don't reload/store it on the
1171non-call path.
1172
1173for () {
1174 *P += 1;
1175 if ()
1176 call();
1177 else
1178 ...
1179->
1180tmp = *P
1181for () {
1182 tmp += 1;
1183 if () {
1184 *P = tmp;
1185 call();
1186 tmp = *P;
1187 } else ...
1188}
1189*P = tmp;
1190
Chris Lattner8f416f32008-12-15 07:49:24 +00001191We now hoist the reload after the call (Transforms/GVN/lpre-call-wrap.ll), but
1192we don't sink the store. We need partially dead store sinking.
1193
Chris Lattner78a7e7c2008-12-06 19:28:22 +00001194//===---------------------------------------------------------------------===//
1195
Chris Lattner8f416f32008-12-15 07:49:24 +00001196[PHI TRANSLATE GEPs]
1197
Chris Lattner78a7e7c2008-12-06 19:28:22 +00001198GCC PR37166: Sinking of loads prevents SROA'ing the "g" struct on the stack
1199leading to excess stack traffic. This could be handled by GVN with some crazy
1200symbolic phi translation. The code we get looks like (g is on the stack):
1201
1202bb2: ; preds = %bb1
1203..
1204 %9 = getelementptr %struct.f* %g, i32 0, i32 0
1205 store i32 %8, i32* %9, align bel %bb3
1206
1207bb3: ; preds = %bb1, %bb2, %bb
1208 %c_addr.0 = phi %struct.f* [ %g, %bb2 ], [ %c, %bb ], [ %c, %bb1 ]
1209 %b_addr.0 = phi %struct.f* [ %b, %bb2 ], [ %g, %bb ], [ %b, %bb1 ]
1210 %10 = getelementptr %struct.f* %c_addr.0, i32 0, i32 0
1211 %11 = load i32* %10, align 4
1212
1213%11 is fully redundant, an in BB2 it should have the value %8.
1214
Chris Lattner6a09a742008-12-06 22:52:12 +00001215GCC PR33344 is a similar case.
1216
Chris Lattner78a7e7c2008-12-06 19:28:22 +00001217//===---------------------------------------------------------------------===//
1218
Chris Lattner6a09a742008-12-06 22:52:12 +00001219There are many load PRE testcases in testsuite/gcc.dg/tree-ssa/loadpre* in the
1220GCC testsuite. There are many pre testcases as ssa-pre-*.c
1221
Chris Lattner582048d2008-12-15 08:32:28 +00001222//===---------------------------------------------------------------------===//
1223
1224There are some interesting cases in testsuite/gcc.dg/tree-ssa/pred-comm* in the
1225GCC testsuite. For example, predcom-1.c is:
1226
1227 for (i = 2; i < 1000; i++)
1228 fib[i] = (fib[i-1] + fib[i - 2]) & 0xffff;
1229
1230which compiles into:
1231
1232bb1: ; preds = %bb1, %bb1.thread
1233 %indvar = phi i32 [ 0, %bb1.thread ], [ %0, %bb1 ]
1234 %i.0.reg2mem.0 = add i32 %indvar, 2
1235 %0 = add i32 %indvar, 1 ; <i32> [#uses=3]
1236 %1 = getelementptr [1000 x i32]* @fib, i32 0, i32 %0
1237 %2 = load i32* %1, align 4 ; <i32> [#uses=1]
1238 %3 = getelementptr [1000 x i32]* @fib, i32 0, i32 %indvar
1239 %4 = load i32* %3, align 4 ; <i32> [#uses=1]
1240 %5 = add i32 %4, %2 ; <i32> [#uses=1]
1241 %6 = and i32 %5, 65535 ; <i32> [#uses=1]
1242 %7 = getelementptr [1000 x i32]* @fib, i32 0, i32 %i.0.reg2mem.0
1243 store i32 %6, i32* %7, align 4
1244 %exitcond = icmp eq i32 %0, 998 ; <i1> [#uses=1]
1245 br i1 %exitcond, label %return, label %bb1
1246
1247This is basically:
1248 LOAD fib[i+1]
1249 LOAD fib[i]
1250 STORE fib[i+2]
1251
1252instead of handling this as a loop or other xform, all we'd need to do is teach
1253load PRE to phi translate the %0 add (i+1) into the predecessor as (i'+1+1) =
1254(i'+2) (where i' is the previous iteration of i). This would find the store
1255which feeds it.
1256
1257predcom-2.c is apparently the same as predcom-1.c
1258predcom-3.c is very similar but needs loads feeding each other instead of
1259store->load.
1260predcom-4.c seems the same as the rest.
1261
1262
1263//===---------------------------------------------------------------------===//
1264
Chris Lattner6a09a742008-12-06 22:52:12 +00001265Other simple load PRE cases:
Chris Lattner8f416f32008-12-15 07:49:24 +00001266http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35287 [LPRE crit edge splitting]
1267
1268http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34677 (licm does this, LPRE crit edge)
1269 llvm-gcc t2.c -S -o - -O0 -emit-llvm | llvm-as | opt -mem2reg -simplifycfg -gvn | llvm-dis
1270
Chris Lattner93c6c772009-09-21 02:53:57 +00001271http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16799 [BITCAST PHI TRANS]
1272
Chris Lattner582048d2008-12-15 08:32:28 +00001273//===---------------------------------------------------------------------===//
1274
1275Type based alias analysis:
Chris Lattner6a09a742008-12-06 22:52:12 +00001276http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14705
1277
1278//===---------------------------------------------------------------------===//
1279
Chris Lattner6a09a742008-12-06 22:52:12 +00001280A/B get pinned to the stack because we turn an if/then into a select instead
1281of PRE'ing the load/store. This may be fixable in instcombine:
1282http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37892
1283
Chris Lattner93c6c772009-09-21 02:53:57 +00001284struct X { int i; };
1285int foo (int x) {
1286 struct X a;
1287 struct X b;
1288 struct X *p;
1289 a.i = 1;
1290 b.i = 2;
1291 if (x)
1292 p = &a;
1293 else
1294 p = &b;
1295 return p->i;
1296}
Chris Lattner582048d2008-12-15 08:32:28 +00001297
Chris Lattner93c6c772009-09-21 02:53:57 +00001298//===---------------------------------------------------------------------===//
Chris Lattner582048d2008-12-15 08:32:28 +00001299
Chris Lattner6a09a742008-12-06 22:52:12 +00001300Interesting missed case because of control flow flattening (should be 2 loads):
1301http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26629
Chris Lattner582048d2008-12-15 08:32:28 +00001302With: llvm-gcc t2.c -S -o - -O0 -emit-llvm | llvm-as |
1303 opt -mem2reg -gvn -instcombine | llvm-dis
1304we miss it because we need 1) GEP PHI TRAN, 2) CRIT EDGE 3) MULTIPLE DIFFERENT
1305VALS PRODUCED BY ONE BLOCK OVER DIFFERENT PATHS
Chris Lattner6a09a742008-12-06 22:52:12 +00001306
1307//===---------------------------------------------------------------------===//
1308
1309http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19633
1310We could eliminate the branch condition here, loading from null is undefined:
1311
1312struct S { int w, x, y, z; };
1313struct T { int r; struct S s; };
1314void bar (struct S, int);
1315void foo (int a, struct T b)
1316{
1317 struct S *c = 0;
1318 if (a)
1319 c = &b.s;
1320 bar (*c, a);
1321}
1322
1323//===---------------------------------------------------------------------===//
Chris Lattner88d84b22008-12-02 06:32:34 +00001324
Chris Lattner9cf8ef62008-12-23 20:52:52 +00001325simplifylibcalls should do several optimizations for strspn/strcspn:
1326
1327strcspn(x, "") -> strlen(x)
1328strcspn("", x) -> 0
1329strspn("", x) -> 0
1330strspn(x, "") -> strlen(x)
1331strspn(x, "a") -> strchr(x, 'a')-x
1332
1333strcspn(x, "a") -> inlined loop for up to 3 letters (similarly for strspn):
1334
1335size_t __strcspn_c3 (__const char *__s, int __reject1, int __reject2,
1336 int __reject3) {
1337 register size_t __result = 0;
1338 while (__s[__result] != '\0' && __s[__result] != __reject1 &&
1339 __s[__result] != __reject2 && __s[__result] != __reject3)
1340 ++__result;
1341 return __result;
1342}
1343
1344This should turn into a switch on the character. See PR3253 for some notes on
1345codegen.
1346
1347456.hmmer apparently uses strcspn and strspn a lot. 471.omnetpp uses strspn.
1348
1349//===---------------------------------------------------------------------===//
Chris Lattnerd23b7992008-12-31 00:54:13 +00001350
1351"gas" uses this idiom:
1352 else if (strchr ("+-/*%|&^:[]()~", *intel_parser.op_string))
1353..
1354 else if (strchr ("<>", *intel_parser.op_string)
1355
1356Those should be turned into a switch.
1357
1358//===---------------------------------------------------------------------===//
Chris Lattnerffb08f52009-01-08 06:52:57 +00001359
1360252.eon contains this interesting code:
1361
1362 %3072 = getelementptr [100 x i8]* %tempString, i32 0, i32 0
1363 %3073 = call i8* @strcpy(i8* %3072, i8* %3071) nounwind
1364 %strlen = call i32 @strlen(i8* %3072) ; uses = 1
1365 %endptr = getelementptr [100 x i8]* %tempString, i32 0, i32 %strlen
1366 call void @llvm.memcpy.i32(i8* %endptr,
1367 i8* getelementptr ([5 x i8]* @"\01LC42", i32 0, i32 0), i32 5, i32 1)
1368 %3074 = call i32 @strlen(i8* %endptr) nounwind readonly
1369
1370This is interesting for a couple reasons. First, in this:
1371
1372 %3073 = call i8* @strcpy(i8* %3072, i8* %3071) nounwind
1373 %strlen = call i32 @strlen(i8* %3072)
1374
1375The strlen could be replaced with: %strlen = sub %3072, %3073, because the
1376strcpy call returns a pointer to the end of the string. Based on that, the
1377endptr GEP just becomes equal to 3073, which eliminates a strlen call and GEP.
1378
1379Second, the memcpy+strlen strlen can be replaced with:
1380
1381 %3074 = call i32 @strlen([5 x i8]* @"\01LC42") nounwind readonly
1382
1383Because the destination was just copied into the specified memory buffer. This,
1384in turn, can be constant folded to "4".
1385
1386In other code, it contains:
1387
1388 %endptr6978 = bitcast i8* %endptr69 to i32*
1389 store i32 7107374, i32* %endptr6978, align 1
1390 %3167 = call i32 @strlen(i8* %endptr69) nounwind readonly
1391
1392Which could also be constant folded. Whatever is producing this should probably
1393be fixed to leave this as a memcpy from a string.
1394
1395Further, eon also has an interesting partially redundant strlen call:
1396
1397bb8: ; preds = %_ZN18eonImageCalculatorC1Ev.exit
1398 %682 = getelementptr i8** %argv, i32 6 ; <i8**> [#uses=2]
1399 %683 = load i8** %682, align 4 ; <i8*> [#uses=4]
1400 %684 = load i8* %683, align 1 ; <i8> [#uses=1]
1401 %685 = icmp eq i8 %684, 0 ; <i1> [#uses=1]
1402 br i1 %685, label %bb10, label %bb9
1403
1404bb9: ; preds = %bb8
1405 %686 = call i32 @strlen(i8* %683) nounwind readonly
1406 %687 = icmp ugt i32 %686, 254 ; <i1> [#uses=1]
1407 br i1 %687, label %bb10, label %bb11
1408
1409bb10: ; preds = %bb9, %bb8
1410 %688 = call i32 @strlen(i8* %683) nounwind readonly
1411
1412This could be eliminated by doing the strlen once in bb8, saving code size and
1413improving perf on the bb8->9->10 path.
1414
1415//===---------------------------------------------------------------------===//
Chris Lattner9fee08f2009-01-08 07:34:55 +00001416
1417I see an interesting fully redundant call to strlen left in 186.crafty:InputMove
1418which looks like:
1419 %movetext11 = getelementptr [128 x i8]* %movetext, i32 0, i32 0
1420
1421
1422bb62: ; preds = %bb55, %bb53
1423 %promote.0 = phi i32 [ %169, %bb55 ], [ 0, %bb53 ]
1424 %171 = call i32 @strlen(i8* %movetext11) nounwind readonly align 1
1425 %172 = add i32 %171, -1 ; <i32> [#uses=1]
1426 %173 = getelementptr [128 x i8]* %movetext, i32 0, i32 %172
1427
1428... no stores ...
1429 br i1 %or.cond, label %bb65, label %bb72
1430
1431bb65: ; preds = %bb62
1432 store i8 0, i8* %173, align 1
1433 br label %bb72
1434
1435bb72: ; preds = %bb65, %bb62
1436 %trank.1 = phi i32 [ %176, %bb65 ], [ -1, %bb62 ]
1437 %177 = call i32 @strlen(i8* %movetext11) nounwind readonly align 1
1438
1439Note that on the bb62->bb72 path, that the %177 strlen call is partially
1440redundant with the %171 call. At worst, we could shove the %177 strlen call
1441up into the bb65 block moving it out of the bb62->bb72 path. However, note
1442that bb65 stores to the string, zeroing out the last byte. This means that on
1443that path the value of %177 is actually just %171-1. A sub is cheaper than a
1444strlen!
1445
1446This pattern repeats several times, basically doing:
1447
1448 A = strlen(P);
1449 P[A-1] = 0;
1450 B = strlen(P);
1451 where it is "obvious" that B = A-1.
1452
1453//===---------------------------------------------------------------------===//
1454
1455186.crafty contains this interesting pattern:
1456
1457%77 = call i8* @strstr(i8* getelementptr ([6 x i8]* @"\01LC5", i32 0, i32 0),
1458 i8* %30)
1459%phitmp648 = icmp eq i8* %77, getelementptr ([6 x i8]* @"\01LC5", i32 0, i32 0)
1460br i1 %phitmp648, label %bb70, label %bb76
1461
1462bb70: ; preds = %OptionMatch.exit91, %bb69
1463 %78 = call i32 @strlen(i8* %30) nounwind readonly align 1 ; <i32> [#uses=1]
1464
1465This is basically:
1466 cststr = "abcdef";
1467 if (strstr(cststr, P) == cststr) {
1468 x = strlen(P);
1469 ...
1470
1471The strstr call would be significantly cheaper written as:
1472
1473cststr = "abcdef";
1474if (memcmp(P, str, strlen(P)))
1475 x = strlen(P);
1476
1477This is memcmp+strlen instead of strstr. This also makes the strlen fully
1478redundant.
1479
1480//===---------------------------------------------------------------------===//
1481
1482186.crafty also contains this code:
1483
1484%1906 = call i32 @strlen(i8* getelementptr ([32 x i8]* @pgn_event, i32 0,i32 0))
1485%1907 = getelementptr [32 x i8]* @pgn_event, i32 0, i32 %1906
1486%1908 = call i8* @strcpy(i8* %1907, i8* %1905) nounwind align 1
1487%1909 = call i32 @strlen(i8* getelementptr ([32 x i8]* @pgn_event, i32 0,i32 0))
1488%1910 = getelementptr [32 x i8]* @pgn_event, i32 0, i32 %1909
1489
1490The last strlen is computable as 1908-@pgn_event, which means 1910=1908.
1491
1492//===---------------------------------------------------------------------===//
1493
1494186.crafty has this interesting pattern with the "out.4543" variable:
1495
1496call void @llvm.memcpy.i32(
1497 i8* getelementptr ([10 x i8]* @out.4543, i32 0, i32 0),
1498 i8* getelementptr ([7 x i8]* @"\01LC28700", i32 0, i32 0), i32 7, i32 1)
1499%101 = call@printf(i8* ... @out.4543, i32 0, i32 0)) nounwind
1500
1501It is basically doing:
1502
1503 memcpy(globalarray, "string");
1504 printf(..., globalarray);
1505
1506Anyway, by knowing that printf just reads the memory and forward substituting
1507the string directly into the printf, this eliminates reads from globalarray.
1508Since this pattern occurs frequently in crafty (due to the "DisplayTime" and
1509other similar functions) there are many stores to "out". Once all the printfs
1510stop using "out", all that is left is the memcpy's into it. This should allow
1511globalopt to remove the "stored only" global.
1512
1513//===---------------------------------------------------------------------===//
1514
Dan Gohman8289b052009-01-20 01:07:33 +00001515This code:
1516
1517define inreg i32 @foo(i8* inreg %p) nounwind {
1518 %tmp0 = load i8* %p
1519 %tmp1 = ashr i8 %tmp0, 5
1520 %tmp2 = sext i8 %tmp1 to i32
1521 ret i32 %tmp2
1522}
1523
1524could be dagcombine'd to a sign-extending load with a shift.
1525For example, on x86 this currently gets this:
1526
1527 movb (%eax), %al
1528 sarb $5, %al
1529 movsbl %al, %eax
1530
1531while it could get this:
1532
1533 movsbl (%eax), %eax
1534 sarl $5, %eax
1535
1536//===---------------------------------------------------------------------===//
Chris Lattner256baa42009-01-22 07:16:03 +00001537
1538GCC PR31029:
1539
1540int test(int x) { return 1-x == x; } // --> return false
1541int test2(int x) { return 2-x == x; } // --> return x == 1 ?
1542
1543Always foldable for odd constants, what is the rule for even?
1544
1545//===---------------------------------------------------------------------===//
1546
Torok Edwine46a6862009-01-24 19:30:25 +00001547PR 3381: GEP to field of size 0 inside a struct could be turned into GEP
1548for next field in struct (which is at same address).
1549
1550For example: store of float into { {{}}, float } could be turned into a store to
1551the float directly.
1552
Torok Edwin474479f2009-02-20 18:42:06 +00001553//===---------------------------------------------------------------------===//
Nick Lewycky20babb12009-02-25 06:52:48 +00001554
Torok Edwin474479f2009-02-20 18:42:06 +00001555#include <math.h>
1556double foo(double a) { return sin(a); }
1557
1558This compiles into this on x86-64 Linux:
1559foo:
1560 subq $8, %rsp
1561 call sin
1562 addq $8, %rsp
1563 ret
1564vs:
1565
1566foo:
1567 jmp sin
1568
Nick Lewycky20babb12009-02-25 06:52:48 +00001569//===---------------------------------------------------------------------===//
1570
Chris Lattner32c5f172009-05-11 17:41:40 +00001571The arg promotion pass should make use of nocapture to make its alias analysis
1572stuff much more precise.
1573
1574//===---------------------------------------------------------------------===//
1575
1576The following functions should be optimized to use a select instead of a
1577branch (from gcc PR40072):
1578
1579char char_int(int m) {if(m>7) return 0; return m;}
1580int int_char(char m) {if(m>7) return 0; return m;}
1581
1582//===---------------------------------------------------------------------===//
1583
Nick Lewycky20babb12009-02-25 06:52:48 +00001584Instcombine should replace the load with a constant in:
1585
1586 static const char x[4] = {'a', 'b', 'c', 'd'};
1587
1588 unsigned int y(void) {
1589 return *(unsigned int *)x;
1590 }
1591
1592It currently only does this transformation when the size of the constant
1593is the same as the size of the integer (so, try x[5]) and the last byte
1594is a null (making it a C string). There's no need for these restrictions.
1595
1596//===---------------------------------------------------------------------===//
1597
Chris Lattnerd919a8b2009-05-11 17:36:33 +00001598InstCombine's "turn load from constant into constant" optimization should be
1599more aggressive in the presence of bitcasts. For example, because of unions,
1600this code:
1601
1602union vec2d {
1603 double e[2];
1604 double v __attribute__((vector_size(16)));
1605};
1606typedef union vec2d vec2d;
1607
1608static vec2d a={{1,2}}, b={{3,4}};
1609
1610vec2d foo () {
1611 return (vec2d){ .v = a.v + b.v * (vec2d){{5,5}}.v };
1612}
1613
1614Compiles into:
1615
1616@a = internal constant %0 { [2 x double]
1617 [double 1.000000e+00, double 2.000000e+00] }, align 16
1618@b = internal constant %0 { [2 x double]
1619 [double 3.000000e+00, double 4.000000e+00] }, align 16
1620...
1621define void @foo(%struct.vec2d* noalias nocapture sret %agg.result) nounwind {
1622entry:
1623 %0 = load <2 x double>* getelementptr (%struct.vec2d*
1624 bitcast (%0* @a to %struct.vec2d*), i32 0, i32 0), align 16
1625 %1 = load <2 x double>* getelementptr (%struct.vec2d*
1626 bitcast (%0* @b to %struct.vec2d*), i32 0, i32 0), align 16
1627
1628
1629Instcombine should be able to optimize away the loads (and thus the globals).
1630
Chris Lattnerc2b0d482009-09-14 16:49:26 +00001631See also PR4973
Chris Lattnerd919a8b2009-05-11 17:36:33 +00001632
1633//===---------------------------------------------------------------------===//