commit 0b7cd6c0d6af071951a86810d2600d155fa53b05
author David 'Digit' Turner <digit@google.com> Fri Jul 10 00:54:05 2009 +0200
committer David 'Digit' Turner <digit@google.com> Fri Jul 10 00:54:05 2009 +0200
tree b8de0eba2c27ee62fa45e7b8bad079d8a66b25fe
parent c5b127050f2dbed015d6b01703a33062d6910d4a

Fix bad zero-termination bug in the socket string formatter.

This created, among other things, malformed CONNECT proxy requests,
depending on the state of the stack

sockets.c

diff --git a/sockets.c b/sockets.c
index 2e61d9a..338b176 100644
--- a/sockets.c
+++ b/sockets.c
@@ -255,11 +255,14 @@
 static char*
 format_char( char*  buf, char*  end, int  c )
 {
-    if (buf >= end)
-        return buf;
-    if (buf+1 == end)
-        c = 0;
-    *buf++ = (char) c;
+    if (buf < end) {
+        if (buf+1 == end) {
+            *buf++ = 0;
+        } else {
+            *buf++ = (char) c;
+            *buf    = 0;
+        }
+    }
     return buf;
 }
 
@@ -350,7 +353,7 @@
 sock_address_to_string( const SockAddress*  a )
 {
     static char buf0[MAX_PATH];
-    char       *buf = buf0, *end = buf + sizeof(buf0);
+    char *buf = buf0, *end = buf + sizeof(buf0);
 
     switch (a->family) {
     case SOCKET_INET: