eliminate all warnings in non-thirdparty code on mac
Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.
Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.
Lots of unused variables removed, and one nasty const issue handled.
There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch. I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.
BUG=
Review URL: https://codereview.appspot.com/7067044
git-svn-id: http://skia.googlecode.com/svn/trunk@7051 2bbb7eff-a529-9590-31e7-b0007b416f81
diff --git a/tests/DrawPathTest.cpp b/tests/DrawPathTest.cpp
index e8cfa54..370559e 100644
--- a/tests/DrawPathTest.cpp
+++ b/tests/DrawPathTest.cpp
@@ -46,6 +46,9 @@
//
// http://code.google.com/p/chromium/issues/detail?id=131181
//
+
+// we're not calling this test anymore; is that for a reason?
+
static void test_crbug131181(skiatest::Reporter*) {
/*
fX = 18.8943768,
@@ -269,7 +272,8 @@
test_crbug_140642(reporter);
test_crbug_140803(reporter);
test_inversepathwithclip(reporter);
-// test_crbug131181(reporter);
+ // why?
+ if (false) test_crbug131181(reporter);
test_infinite_dash(reporter);
test_crbug_165432(reporter);
}