commit 52e9d63f7110ac691609660342cdab32082a4235
author bsalomon <bsalomon@google.com> Fri Sep 05 12:23:12 2014 -0700
committer Commit bot <commit-bot@chromium.org> Fri Sep 05 12:23:12 2014 -0700
tree fa7bf3b7a534588d99bf049fb3b8cc4d20cd15ff
parent 5a80be22418176a2d15b0d3bd33215e28b516b24

Don't take a ref on GP in AutoEffectRestore.

BUG=skia:2889
R=joshualitt@chromium.org, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/546043002

src/gpu/GrDrawState.cpp

diff --git a/src/gpu/GrDrawState.cpp b/src/gpu/GrDrawState.cpp
index 6acc202..f2028ea 100644
--- a/src/gpu/GrDrawState.cpp
+++ b/src/gpu/GrDrawState.cpp
@@ -300,12 +300,12 @@
 void GrDrawState::AutoRestoreEffects::set(GrDrawState* ds) {
     if (NULL != fDrawState) {
         // See the big comment on the class definition about GPs.
-        if (NULL != fOriginalGP) {
-            SkASSERT(fDrawState->getGeometryProcessor()->getEffect() == fOriginalGP);
-            fOriginalGP->unref();
-            fOriginalGP = NULL;
-        } else {
+        if (SK_InvalidUniqueID == fOriginalGPID) {
             fDrawState->fGeometryProcessor.reset(NULL);
+        } else {
+            SkASSERT(fDrawState->getGeometryProcessor()->getEffect()->getUniqueID() ==
+                     fOriginalGPID);
+            fOriginalGPID = SK_InvalidUniqueID;
         }
 
         int m = fDrawState->numColorStages() - fColorEffectCnt;
@@ -322,9 +322,9 @@
     }
     fDrawState = ds;
     if (NULL != ds) {
-        SkASSERT(NULL == fOriginalGP);
+        SkASSERT(SK_InvalidUniqueID == fOriginalGPID);
         if (NULL != ds->getGeometryProcessor()) {
-            fOriginalGP = SkRef(ds->getGeometryProcessor()->getEffect());
+            fOriginalGPID = ds->getGeometryProcessor()->getEffect()->getUniqueID();
         }
         fColorEffectCnt = ds->numColorStages();
         fCoverageEffectCnt = ds->numCoverageStages();

src/gpu/GrDrawState.h

diff --git a/src/gpu/GrDrawState.h b/src/gpu/GrDrawState.h
index 7b5f150..6223f53 100644
--- a/src/gpu/GrDrawState.h
+++ b/src/gpu/GrDrawState.h
@@ -256,13 +256,13 @@
     public:
         AutoRestoreEffects() 
             : fDrawState(NULL)
-            , fOriginalGP(NULL)
+            , fOriginalGPID(SK_InvalidUniqueID)
             , fColorEffectCnt(0)
             , fCoverageEffectCnt(0) {}
 
         AutoRestoreEffects(GrDrawState* ds)
             : fDrawState(NULL)
-            , fOriginalGP(NULL)
+            , fOriginalGPID(SK_InvalidUniqueID)
             , fColorEffectCnt(0)
             , fCoverageEffectCnt(0) {
             this->set(ds);
@@ -276,7 +276,7 @@
 
     private:
         GrDrawState*    fDrawState;
-        const GrEffect* fOriginalGP;
+        uint32_t        fOriginalGPID;
         int             fColorEffectCnt;
         int             fCoverageEffectCnt;
     };

src/gpu/GrProgramElement.cpp

diff --git a/src/gpu/GrProgramElement.cpp b/src/gpu/GrProgramElement.cpp
index 70d5339..20a957f 100644
--- a/src/gpu/GrProgramElement.cpp
+++ b/src/gpu/GrProgramElement.cpp
@@ -8,6 +8,15 @@
 #include "GrProgramElement.h"
 #include "GrProgramResource.h"
 
+uint32_t GrProgramElement::CreateUniqueID() {
+    static int32_t gUniqueID = SK_InvalidUniqueID;
+    uint32_t id;
+    do {
+        id = static_cast<uint32_t>(sk_atomic_inc(&gUniqueID) + 1);
+    } while (id == SK_InvalidUniqueID);
+    return id;
+}
+
 void GrProgramElement::convertRefToPendingExecution() const {
     // This function makes it so that all the GrProgramResources own a single ref to their
     // underlying GrGpuResource if there are any refs to the GrProgramElement and a single