Two cleanups: tcb table expansion failure is not really a survivable
event, we do not have any viable way to continue. No wonder most
places where that is detected have FIXMEs.
It's way simpler to treat as fatal failure, and handle it inside
tcb table expansion finctions.
Second cleanup: tidy up haphazard locations of a few externs.
* defs.h: Change return type of expand_tcbtab() to void.
Declare change_syscall().
* process.c: Change all callsites of alloctcb(), alloc_tcb() and
fork_tcb(), removing now-redundant error checks.
(fork_tcb): Change return type to void - it can't fail now.
* strace.c: Move extern declarations out of function bodies.
Change all callsites of alloctcb(), alloc_tcb() and
fork_tcb(), removing now-redundant error checks.
(expand_tcbtab): Change return type to void - it can't fail now.
On failure to expand, print a message, clean up, and exit.
(alloc_tcb): On failure to expand, print a message, clean up, and exit.
* util.c (setbpt): Remove extern declaration from function body.
diff --git a/util.c b/util.c
index 763ae84..affb167 100644
--- a/util.c
+++ b/util.c
@@ -1593,11 +1593,9 @@
#endif
int
-setbpt(tcp)
-struct tcb *tcp;
+setbpt(struct tcb *tcp)
{
static int clone_scno[SUPPORTED_PERSONALITIES] = { SYS_clone };
- extern int change_syscall(struct tcb *, int);
arg_setup_state state;
if (tcp->flags & TCB_BPTSET) {