Simple optimization in get_error
* defs.h: Define SCNO_IN_RANGE(scno) macro.
* syscall.c (get_error): Change return type to void.
Use SCNO_IN_RANGE instead of SCNO_IS_VALID.
(trace_syscall_exiting): Stop checking get_error() return value.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
diff --git a/defs.h b/defs.h
index f641e0d..3d5f300 100644
--- a/defs.h
+++ b/defs.h
@@ -753,5 +753,12 @@
extern const char *const *signalent;
extern unsigned nsignals;
+/*
+ * If you need non-NULL sysent[scno].sys_func and sysent[scno].sys_name
+ */
#define SCNO_IS_VALID(scno) \
- ((unsigned long)(scno) < nsyscalls && sysent[scno].sys_func)
+ ((unsigned long)(scno) < nsyscalls && sysent[scno].sys_func)
+
+/* Only ensures that sysent[scno] isn't out of range */
+#define SCNO_IN_RANGE(scno) \
+ ((unsigned long)(scno) < nsyscalls)