tree bf70ad84930fdf5d665745569374901ef087a4cf
parent 8aa87ab9b4ee68eec75af26d550fbcfb732d660f
author Rob Landley <rob@landley.net> 1410637717 -0500
committer Rob Landley <rob@landley.net> 1410637717 -0500

Bug report from luckboy: rm -f on a broken symlink didn't work because our "does it exist" test (to avoid errors on rm -f of nonexistent files) said it didn't.

The fix: replace the access() with unlink(), which produces the same "does not
exist" errno and has the added bonus of acting as a fastpath for rm -f on
non-directories. (And since it produces a different error on directories,
falls through to the old behavior there.)

Most of this commit is comment updates explaining being subtle. :)