Upgrade V8 to version 4.9.385.28
https://chromium.googlesource.com/v8/v8/+/4.9.385.28
FPIIM-449
Change-Id: I4b2e74289d4bf3667f2f3dc8aa2e541f63e26eb4
diff --git a/tools/try_perf.py b/tools/try_perf.py
index fcd1ddc..2403f7d 100755
--- a/tools/try_perf.py
+++ b/tools/try_perf.py
@@ -3,42 +3,94 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import find_depot_tools
+import argparse
+import os
+import subprocess
import sys
-find_depot_tools.add_depot_tools_to_path()
+BOTS = {
+ '--arm32': 'v8_arm32_perf_try',
+ '--linux32': 'v8_linux32_perf_try',
+ '--linux64': 'v8_linux64_perf_try',
+ '--linux64_atom': 'v8_linux64_atom_perf_try',
+ '--linux64_haswell': 'v8_linux64_haswell_perf_try',
+ '--nexus5': 'v8_nexus5_perf_try',
+ '--nexus7': 'v8_nexus7_perf_try',
+ '--nexus9': 'v8_nexus9_perf_try',
+ '--nexus10': 'v8_nexus10_perf_try',
+}
-from git_cl import Changelist
-
-BOTS = [
+DEFAULT_BOTS = [
+ 'v8_arm32_perf_try',
'v8_linux32_perf_try',
- 'v8_linux64_perf_try',
+ 'v8_linux64_haswell_perf_try',
+ 'v8_nexus10_perf_try',
]
-def main(tests):
- cl = Changelist()
- if not cl.GetIssue():
- print 'Need to upload first'
- return 1
+PUBLIC_BENCHMARKS = [
+ 'arewefastyet',
+ 'embenchen',
+ 'emscripten',
+ 'compile',
+ 'jetstream',
+ 'jsbench',
+ 'jstests',
+ 'kraken_orig',
+ 'massive',
+ 'memory',
+ 'octane',
+ 'octane-pr',
+ 'octane-tf',
+ 'octane-tf-pr',
+ 'simdjs',
+ 'sunspider',
+]
- props = cl.GetIssueProperties()
- if props.get('closed'):
- print 'Cannot send tryjobs for a closed CL'
- return 1
+V8_BASE = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
- if props.get('private'):
- print 'Cannot use trybots with private issue'
- return 1
+def main():
+ parser = argparse.ArgumentParser(description='')
+ parser.add_argument('benchmarks', nargs='+', help='The benchmarks to run.')
+ parser.add_argument('--extra-flags', default='',
+ help='Extra flags to be passed to the executable.')
+ for option in sorted(BOTS):
+ parser.add_argument(
+ option, dest='bots', action='append_const', const=BOTS[option],
+ help='Add %s trybot.' % BOTS[option])
+ options = parser.parse_args()
+ if not options.bots:
+ print 'No trybots specified. Using default %s.' % ','.join(DEFAULT_BOTS)
+ options.bots = DEFAULT_BOTS
- if not tests:
+ if not options.benchmarks:
print 'Please specify the benchmarks to run as arguments.'
return 1
- masters = {'internal.client.v8': dict((b, tests) for b in BOTS)}
- cl.RpcServer().trigger_distributed_try_jobs(
- cl.GetIssue(), cl.GetMostRecentPatchset(), cl.GetBranch(),
- False, None, masters)
- return 0
+ for benchmark in options.benchmarks:
+ if benchmark not in PUBLIC_BENCHMARKS:
+ print ('%s not found in our benchmark list. The respective trybot might '
+ 'fail, unless you run something this script isn\'t aware of. '
+ 'Available public benchmarks: %s' % (benchmark, PUBLIC_BENCHMARKS))
+ print 'Proceed anyways? [Y/n] ',
+ answer = sys.stdin.readline().strip()
+ if answer != "" and answer != "Y" and answer != "y":
+ return 1
-if __name__ == "__main__": # pragma: no cover
- sys.exit(main(sys.argv[1:]))
+ assert '"' not in options.extra_flags and '\'' not in options.extra_flags, (
+ 'Invalid flag specification.')
+
+ # Ensure depot_tools are updated.
+ subprocess.check_output(
+ 'gclient', shell=True, stderr=subprocess.STDOUT, cwd=V8_BASE)
+
+ cmd = ['git cl try -m internal.client.v8']
+ cmd += ['-b %s' % bot for bot in options.bots]
+ benchmarks = ['"%s"' % benchmark for benchmark in options.benchmarks]
+ cmd += ['-p \'testfilter=[%s]\'' % ','.join(benchmarks)]
+ if options.extra_flags:
+ cmd += ['-p \'extra_flags="%s"\'' % options.extra_flags]
+ subprocess.check_call(' '.join(cmd), shell=True, cwd=V8_BASE)
+
+
+if __name__ == '__main__': # pragma: no cover
+ sys.exit(main())