Roll V8 back to 3.6
Roll back to V8 3.6 to fix x86 build, we don't have ucontext.h.
This reverts commits:
5d4cdbf7a67d3662fa0bee4efdb7edd8daec9b0b
c7cc028aaeedbbfa11c11d0b7b243b3d9e837ed9
592a9fc1d8ea420377a2e7efd0600e20b058be2b
Bug: 5688872
Change-Id: Ic961bb5e65b778e98bbfb71cce71d99fa949e995
diff --git a/tools/presubmit.py b/tools/presubmit.py
index a5f4c61..fda7ba9 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -1,6 +1,6 @@
#!/usr/bin/env python
#
-# Copyright 2012 the V8 project authors. All rights reserved.
+# Copyright 2011 the V8 project authors. All rights reserved.
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
@@ -42,7 +42,6 @@
import re
import sys
import subprocess
-import multiprocessing
from subprocess import PIPE
# Disabled LINT rules and reason.
@@ -102,33 +101,6 @@
""".split()
-LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing')
-
-
-def CppLintWorker(command):
- try:
- process = subprocess.Popen(command, stderr=subprocess.PIPE)
- process.wait()
- out_lines = ""
- error_count = -1
- while True:
- out_line = process.stderr.readline()
- if out_line == '' and process.poll() != None:
- break
- m = LINT_OUTPUT_PATTERN.match(out_line)
- if m:
- out_lines += out_line
- error_count += 1
- sys.stderr.write(out_lines)
- return error_count
- except KeyboardInterrupt:
- process.kill()
- except:
- print('Error running cpplint.py. Please make sure you have depot_tools' +
- ' in your $PATH. Lint check skipped.')
- process.kill()
-
-
class FileContentsCache(object):
def __init__(self, sums_file_name):
@@ -234,28 +206,24 @@
return True
filt = '-,' + ",".join(['+' + n for n in ENABLED_LINT_RULES])
- command = ['cpplint.py', '--filter', filt]
+ command = ['cpplint.py', '--filter', filt] + join(files)
local_cpplint = join(path, "tools", "cpplint.py")
if exists(local_cpplint):
- command = ['python', local_cpplint, '--filter', filt]
+ command = ['python', local_cpplint, '--filter', filt] + join(files)
- commands = join([command + [file] for file in files])
- count = multiprocessing.cpu_count()
- pool = multiprocessing.Pool(count)
- try:
- results = pool.map_async(CppLintWorker, commands).get(999999)
- except KeyboardInterrupt:
- print "\nCaught KeyboardInterrupt, terminating workers."
- sys.exit(1)
+ process = subprocess.Popen(command, stderr=subprocess.PIPE)
+ LINT_ERROR_PATTERN = re.compile(r'^(.+)[:(]\d+[:)]')
+ while True:
+ out_line = process.stderr.readline()
+ if out_line == '' and process.poll() != None:
+ break
+ sys.stderr.write(out_line)
+ m = LINT_ERROR_PATTERN.match(out_line)
+ if m:
+ good_files_cache.RemoveFile(m.group(1))
- for i in range(len(files)):
- if results[i] > 0:
- good_files_cache.RemoveFile(files[i])
-
- total_errors = sum(results)
- print "Total errors found: %d" % total_errors
good_files_cache.Save()
- return total_errors == 0
+ return process.returncode == 0
COPYRIGHT_HEADER_PATTERN = re.compile(