Ben Murdoch | c561043 | 2016-08-08 18:44:38 +0100 | [diff] [blame^] | 1 | // Copyright 2016 the V8 project authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "src/v8.h" |
| 6 | |
| 7 | #include "src/factory.h" |
| 8 | #include "src/interpreter/bytecode-peephole-optimizer.h" |
| 9 | #include "src/interpreter/constant-array-builder.h" |
| 10 | #include "src/objects-inl.h" |
| 11 | #include "src/objects.h" |
| 12 | #include "test/unittests/test-utils.h" |
| 13 | |
| 14 | namespace v8 { |
| 15 | namespace internal { |
| 16 | namespace interpreter { |
| 17 | |
| 18 | class BytecodePeepholeOptimizerTest : public BytecodePipelineStage, |
| 19 | public TestWithIsolateAndZone { |
| 20 | public: |
| 21 | BytecodePeepholeOptimizerTest() |
| 22 | : constant_array_builder_(isolate(), zone()), |
| 23 | peephole_optimizer_(&constant_array_builder_, this) {} |
| 24 | ~BytecodePeepholeOptimizerTest() override {} |
| 25 | |
| 26 | size_t FlushForOffset() override { |
| 27 | flush_for_offset_count_++; |
| 28 | return 0; |
| 29 | }; |
| 30 | |
| 31 | void FlushBasicBlock() override { flush_basic_block_count_++; } |
| 32 | |
| 33 | void Write(BytecodeNode* node) override { |
| 34 | write_count_++; |
| 35 | last_written_.Clone(node); |
| 36 | } |
| 37 | |
| 38 | BytecodePeepholeOptimizer* optimizer() { return &peephole_optimizer_; } |
| 39 | ConstantArrayBuilder* constant_array() { return &constant_array_builder_; } |
| 40 | |
| 41 | int flush_for_offset_count() const { return flush_for_offset_count_; } |
| 42 | int flush_basic_block_count() const { return flush_basic_block_count_; } |
| 43 | int write_count() const { return write_count_; } |
| 44 | const BytecodeNode& last_written() const { return last_written_; } |
| 45 | |
| 46 | private: |
| 47 | ConstantArrayBuilder constant_array_builder_; |
| 48 | BytecodePeepholeOptimizer peephole_optimizer_; |
| 49 | |
| 50 | int flush_for_offset_count_ = 0; |
| 51 | int flush_basic_block_count_ = 0; |
| 52 | int write_count_ = 0; |
| 53 | BytecodeNode last_written_; |
| 54 | }; |
| 55 | |
| 56 | // Sanity tests. |
| 57 | |
| 58 | TEST_F(BytecodePeepholeOptimizerTest, FlushForOffsetPassThrough) { |
| 59 | CHECK_EQ(flush_for_offset_count(), 0); |
| 60 | CHECK_EQ(optimizer()->FlushForOffset(), 0); |
| 61 | CHECK_EQ(flush_for_offset_count(), 1); |
| 62 | } |
| 63 | |
| 64 | TEST_F(BytecodePeepholeOptimizerTest, FlushForOffsetRightSize) { |
| 65 | BytecodeNode node(Bytecode::kAdd, Register(0).ToOperand(), |
| 66 | OperandScale::kQuadruple); |
| 67 | optimizer()->Write(&node); |
| 68 | CHECK_EQ(optimizer()->FlushForOffset(), node.Size()); |
| 69 | CHECK_EQ(flush_for_offset_count(), 1); |
| 70 | CHECK_EQ(write_count(), 0); |
| 71 | } |
| 72 | |
| 73 | TEST_F(BytecodePeepholeOptimizerTest, FlushForOffsetNop) { |
| 74 | BytecodeNode node(Bytecode::kNop); |
| 75 | optimizer()->Write(&node); |
| 76 | CHECK_EQ(optimizer()->FlushForOffset(), 0); |
| 77 | CHECK_EQ(flush_for_offset_count(), 1); |
| 78 | CHECK_EQ(write_count(), 0); |
| 79 | } |
| 80 | |
| 81 | TEST_F(BytecodePeepholeOptimizerTest, FlushForOffsetNopExpression) { |
| 82 | BytecodeNode node(Bytecode::kNop); |
| 83 | node.source_info().Update({3, false}); |
| 84 | optimizer()->Write(&node); |
| 85 | CHECK_EQ(optimizer()->FlushForOffset(), 0); |
| 86 | CHECK_EQ(flush_for_offset_count(), 1); |
| 87 | CHECK_EQ(write_count(), 0); |
| 88 | } |
| 89 | |
| 90 | TEST_F(BytecodePeepholeOptimizerTest, FlushForOffsetNopStatement) { |
| 91 | BytecodeNode node(Bytecode::kNop); |
| 92 | node.source_info().Update({3, true}); |
| 93 | optimizer()->Write(&node); |
| 94 | CHECK_EQ(optimizer()->FlushForOffset(), node.Size()); |
| 95 | CHECK_EQ(flush_for_offset_count(), 1); |
| 96 | CHECK_EQ(write_count(), 0); |
| 97 | } |
| 98 | |
| 99 | TEST_F(BytecodePeepholeOptimizerTest, FlushBasicBlockPassThrough) { |
| 100 | CHECK_EQ(flush_basic_block_count(), 0); |
| 101 | optimizer()->FlushBasicBlock(); |
| 102 | CHECK_EQ(flush_basic_block_count(), 1); |
| 103 | CHECK_EQ(write_count(), 0); |
| 104 | } |
| 105 | |
| 106 | TEST_F(BytecodePeepholeOptimizerTest, WriteOneFlushBasicBlock) { |
| 107 | BytecodeNode node(Bytecode::kAdd, Register(0).ToOperand(), |
| 108 | OperandScale::kQuadruple); |
| 109 | optimizer()->Write(&node); |
| 110 | CHECK_EQ(write_count(), 0); |
| 111 | optimizer()->FlushBasicBlock(); |
| 112 | CHECK_EQ(write_count(), 1); |
| 113 | CHECK_EQ(node, last_written()); |
| 114 | } |
| 115 | |
| 116 | // Tests covering BytecodePeepholeOptimizer::UpdateCurrentBytecode(). |
| 117 | |
| 118 | TEST_F(BytecodePeepholeOptimizerTest, KeepJumpIfToBooleanTrue) { |
| 119 | BytecodeNode first(Bytecode::kLdaNull); |
| 120 | BytecodeNode second(Bytecode::kJumpIfToBooleanTrue, 3, OperandScale::kSingle); |
| 121 | optimizer()->Write(&first); |
| 122 | CHECK_EQ(write_count(), 0); |
| 123 | optimizer()->Write(&second); |
| 124 | CHECK_EQ(write_count(), 1); |
| 125 | CHECK_EQ(last_written(), first); |
| 126 | optimizer()->FlushBasicBlock(); |
| 127 | CHECK_EQ(write_count(), 2); |
| 128 | CHECK_EQ(last_written(), second); |
| 129 | } |
| 130 | |
| 131 | TEST_F(BytecodePeepholeOptimizerTest, ElideJumpIfToBooleanTrue) { |
| 132 | BytecodeNode first(Bytecode::kLdaTrue); |
| 133 | BytecodeNode second(Bytecode::kJumpIfToBooleanTrue, 3, OperandScale::kSingle); |
| 134 | optimizer()->Write(&first); |
| 135 | CHECK_EQ(write_count(), 0); |
| 136 | optimizer()->Write(&second); |
| 137 | CHECK_EQ(write_count(), 1); |
| 138 | CHECK_EQ(last_written(), first); |
| 139 | optimizer()->FlushBasicBlock(); |
| 140 | CHECK_EQ(write_count(), 2); |
| 141 | CHECK_EQ(last_written().bytecode(), Bytecode::kJumpIfTrue); |
| 142 | CHECK_EQ(last_written().operand(0), second.operand(0)); |
| 143 | } |
| 144 | |
| 145 | TEST_F(BytecodePeepholeOptimizerTest, KeepToBooleanLogicalNot) { |
| 146 | BytecodeNode first(Bytecode::kLdaNull); |
| 147 | BytecodeNode second(Bytecode::kToBooleanLogicalNot); |
| 148 | optimizer()->Write(&first); |
| 149 | CHECK_EQ(write_count(), 0); |
| 150 | optimizer()->Write(&second); |
| 151 | CHECK_EQ(write_count(), 1); |
| 152 | CHECK_EQ(last_written(), first); |
| 153 | optimizer()->FlushBasicBlock(); |
| 154 | CHECK_EQ(write_count(), 2); |
| 155 | CHECK_EQ(last_written(), second); |
| 156 | } |
| 157 | |
| 158 | TEST_F(BytecodePeepholeOptimizerTest, ElideToBooleanLogicalNot) { |
| 159 | BytecodeNode first(Bytecode::kLdaTrue); |
| 160 | BytecodeNode second(Bytecode::kToBooleanLogicalNot); |
| 161 | optimizer()->Write(&first); |
| 162 | CHECK_EQ(write_count(), 0); |
| 163 | optimizer()->Write(&second); |
| 164 | CHECK_EQ(write_count(), 1); |
| 165 | CHECK_EQ(last_written(), first); |
| 166 | optimizer()->FlushBasicBlock(); |
| 167 | CHECK_EQ(write_count(), 2); |
| 168 | CHECK_EQ(last_written().bytecode(), Bytecode::kLogicalNot); |
| 169 | } |
| 170 | |
| 171 | // Tests covering BytecodePeepholeOptimizer::CanElideCurrent(). |
| 172 | |
| 173 | TEST_F(BytecodePeepholeOptimizerTest, LdarRxLdarRy) { |
| 174 | BytecodeNode first(Bytecode::kLdar, Register(0).ToOperand(), |
| 175 | OperandScale::kSingle); |
| 176 | BytecodeNode second(Bytecode::kLdar, Register(1).ToOperand(), |
| 177 | OperandScale::kSingle); |
| 178 | optimizer()->Write(&first); |
| 179 | optimizer()->FlushForOffset(); // Prevent CanElideLast removing |first|. |
| 180 | CHECK_EQ(write_count(), 0); |
| 181 | optimizer()->Write(&second); |
| 182 | CHECK_EQ(write_count(), 1); |
| 183 | CHECK_EQ(last_written(), first); |
| 184 | optimizer()->FlushBasicBlock(); |
| 185 | CHECK_EQ(write_count(), 2); |
| 186 | CHECK_EQ(last_written(), second); |
| 187 | } |
| 188 | |
| 189 | TEST_F(BytecodePeepholeOptimizerTest, LdarRxLdarRx) { |
| 190 | BytecodeNode first(Bytecode::kLdar, Register(0).ToOperand(), |
| 191 | OperandScale::kSingle); |
| 192 | BytecodeNode second(Bytecode::kLdar, Register(0).ToOperand(), |
| 193 | OperandScale::kSingle); |
| 194 | optimizer()->Write(&first); |
| 195 | CHECK_EQ(write_count(), 0); |
| 196 | optimizer()->FlushForOffset(); // Prevent CanElideLast removing |first|. |
| 197 | optimizer()->Write(&second); |
| 198 | CHECK_EQ(write_count(), 1); |
| 199 | CHECK_EQ(last_written(), first); |
| 200 | optimizer()->FlushBasicBlock(); |
| 201 | CHECK_EQ(write_count(), 1); |
| 202 | } |
| 203 | |
| 204 | TEST_F(BytecodePeepholeOptimizerTest, LdarRxLdarRxStatement) { |
| 205 | BytecodeNode first(Bytecode::kLdar, Register(0).ToOperand(), |
| 206 | OperandScale::kSingle); |
| 207 | BytecodeNode second(Bytecode::kLdar, Register(0).ToOperand(), |
| 208 | OperandScale::kSingle); |
| 209 | second.source_info().Update({0, true}); |
| 210 | optimizer()->Write(&first); |
| 211 | CHECK_EQ(write_count(), 0); |
| 212 | optimizer()->FlushForOffset(); // Prevent CanElideLast removing |first|. |
| 213 | optimizer()->Write(&second); |
| 214 | CHECK_EQ(write_count(), 1); |
| 215 | CHECK_EQ(last_written(), first); |
| 216 | optimizer()->FlushBasicBlock(); |
| 217 | CHECK_EQ(write_count(), 2); |
| 218 | CHECK_EQ(last_written().bytecode(), Bytecode::kNop); |
| 219 | CHECK_EQ(last_written().source_info(), second.source_info()); |
| 220 | } |
| 221 | |
| 222 | TEST_F(BytecodePeepholeOptimizerTest, LdarRxLdarRxStatementStarRy) { |
| 223 | BytecodeNode first(Bytecode::kLdar, Register(0).ToOperand(), |
| 224 | OperandScale::kSingle); |
| 225 | BytecodeNode second(Bytecode::kLdar, Register(0).ToOperand(), |
| 226 | OperandScale::kSingle); |
| 227 | BytecodeNode third(Bytecode::kStar, Register(3).ToOperand(), |
| 228 | OperandScale::kSingle); |
| 229 | second.source_info().Update({0, true}); |
| 230 | optimizer()->Write(&first); |
| 231 | CHECK_EQ(write_count(), 0); |
| 232 | optimizer()->FlushForOffset(); // Prevent CanElideLast removing |first|. |
| 233 | optimizer()->Write(&second); |
| 234 | CHECK_EQ(write_count(), 1); |
| 235 | CHECK_EQ(last_written(), first); |
| 236 | optimizer()->Write(&third); |
| 237 | CHECK_EQ(write_count(), 1); |
| 238 | optimizer()->FlushBasicBlock(); |
| 239 | CHECK_EQ(write_count(), 2); |
| 240 | // Source position should move |second| to |third| when |second| is elided. |
| 241 | third.source_info().Update(second.source_info()); |
| 242 | CHECK_EQ(last_written(), third); |
| 243 | } |
| 244 | |
| 245 | TEST_F(BytecodePeepholeOptimizerTest, LdarToName) { |
| 246 | BytecodeNode first(Bytecode::kLdar, Register(0).ToOperand(), |
| 247 | OperandScale::kSingle); |
| 248 | BytecodeNode second(Bytecode::kToName); |
| 249 | optimizer()->Write(&first); |
| 250 | CHECK_EQ(write_count(), 0); |
| 251 | optimizer()->Write(&second); |
| 252 | CHECK_EQ(write_count(), 1); |
| 253 | CHECK_EQ(last_written(), first); |
| 254 | optimizer()->FlushBasicBlock(); |
| 255 | CHECK_EQ(write_count(), 2); |
| 256 | CHECK_EQ(last_written(), second); |
| 257 | } |
| 258 | |
| 259 | TEST_F(BytecodePeepholeOptimizerTest, ToNameToName) { |
| 260 | BytecodeNode first(Bytecode::kToName); |
| 261 | BytecodeNode second(Bytecode::kToName); |
| 262 | optimizer()->Write(&first); |
| 263 | CHECK_EQ(write_count(), 0); |
| 264 | optimizer()->Write(&second); |
| 265 | CHECK_EQ(write_count(), 1); |
| 266 | CHECK_EQ(last_written(), first); |
| 267 | optimizer()->FlushBasicBlock(); |
| 268 | CHECK_EQ(write_count(), 1); |
| 269 | } |
| 270 | |
| 271 | TEST_F(BytecodePeepholeOptimizerTest, TypeOfToName) { |
| 272 | BytecodeNode first(Bytecode::kTypeOf); |
| 273 | BytecodeNode second(Bytecode::kToName); |
| 274 | optimizer()->Write(&first); |
| 275 | CHECK_EQ(write_count(), 0); |
| 276 | optimizer()->Write(&second); |
| 277 | CHECK_EQ(write_count(), 1); |
| 278 | CHECK_EQ(last_written(), first); |
| 279 | optimizer()->FlushBasicBlock(); |
| 280 | CHECK_EQ(write_count(), 1); |
| 281 | } |
| 282 | |
| 283 | TEST_F(BytecodePeepholeOptimizerTest, LdaConstantStringToName) { |
| 284 | Handle<Object> word = |
| 285 | isolate()->factory()->NewStringFromStaticChars("optimizing"); |
| 286 | size_t index = constant_array()->Insert(word); |
| 287 | BytecodeNode first(Bytecode::kLdaConstant, static_cast<uint32_t>(index), |
| 288 | OperandScale::kSingle); |
| 289 | BytecodeNode second(Bytecode::kToName); |
| 290 | optimizer()->Write(&first); |
| 291 | CHECK_EQ(write_count(), 0); |
| 292 | optimizer()->Write(&second); |
| 293 | CHECK_EQ(write_count(), 1); |
| 294 | CHECK_EQ(last_written(), first); |
| 295 | optimizer()->FlushBasicBlock(); |
| 296 | CHECK_EQ(write_count(), 1); |
| 297 | } |
| 298 | |
| 299 | TEST_F(BytecodePeepholeOptimizerTest, LdaConstantNumberToName) { |
| 300 | Handle<Object> word = isolate()->factory()->NewNumber(0.380); |
| 301 | size_t index = constant_array()->Insert(word); |
| 302 | BytecodeNode first(Bytecode::kLdaConstant, static_cast<uint32_t>(index), |
| 303 | OperandScale::kSingle); |
| 304 | BytecodeNode second(Bytecode::kToName); |
| 305 | optimizer()->Write(&first); |
| 306 | CHECK_EQ(write_count(), 0); |
| 307 | optimizer()->Write(&second); |
| 308 | CHECK_EQ(write_count(), 1); |
| 309 | CHECK_EQ(last_written(), first); |
| 310 | optimizer()->FlushBasicBlock(); |
| 311 | CHECK_EQ(write_count(), 2); |
| 312 | CHECK_EQ(last_written(), second); |
| 313 | } |
| 314 | |
| 315 | // Tests covering BytecodePeepholeOptimizer::CanElideLast(). |
| 316 | |
| 317 | TEST_F(BytecodePeepholeOptimizerTest, LdaTrueLdaFalseNotDiscardable) { |
| 318 | BytecodeNode first(Bytecode::kLdaTrue); |
| 319 | BytecodeNode second(Bytecode::kLdaFalse); |
| 320 | optimizer()->Write(&first); |
| 321 | optimizer()->FlushForOffset(); // Prevent discarding of |first|. |
| 322 | CHECK_EQ(write_count(), 0); |
| 323 | optimizer()->Write(&second); |
| 324 | CHECK_EQ(write_count(), 1); |
| 325 | CHECK_EQ(last_written(), first); |
| 326 | optimizer()->FlushBasicBlock(); |
| 327 | CHECK_EQ(write_count(), 2); |
| 328 | CHECK_EQ(last_written(), second); |
| 329 | } |
| 330 | |
| 331 | TEST_F(BytecodePeepholeOptimizerTest, LdaTrueLdaFalse) { |
| 332 | BytecodeNode first(Bytecode::kLdaTrue); |
| 333 | BytecodeNode second(Bytecode::kLdaFalse); |
| 334 | optimizer()->Write(&first); |
| 335 | CHECK_EQ(write_count(), 0); |
| 336 | optimizer()->Write(&second); |
| 337 | CHECK_EQ(write_count(), 0); |
| 338 | optimizer()->FlushBasicBlock(); |
| 339 | CHECK_EQ(write_count(), 1); |
| 340 | CHECK_EQ(last_written(), second); |
| 341 | } |
| 342 | |
| 343 | TEST_F(BytecodePeepholeOptimizerTest, LdaTrueStatementLdaFalse) { |
| 344 | BytecodeNode first(Bytecode::kLdaTrue); |
| 345 | first.source_info().Update({3, false}); |
| 346 | BytecodeNode second(Bytecode::kLdaFalse); |
| 347 | optimizer()->Write(&first); |
| 348 | CHECK_EQ(write_count(), 0); |
| 349 | optimizer()->Write(&second); |
| 350 | CHECK_EQ(write_count(), 0); |
| 351 | optimizer()->FlushBasicBlock(); |
| 352 | CHECK_EQ(write_count(), 1); |
| 353 | second.source_info().Update(first.source_info()); |
| 354 | CHECK_EQ(last_written(), second); |
| 355 | } |
| 356 | |
| 357 | TEST_F(BytecodePeepholeOptimizerTest, NopStackCheck) { |
| 358 | BytecodeNode first(Bytecode::kNop); |
| 359 | BytecodeNode second(Bytecode::kStackCheck); |
| 360 | optimizer()->Write(&first); |
| 361 | CHECK_EQ(write_count(), 0); |
| 362 | optimizer()->Write(&second); |
| 363 | CHECK_EQ(write_count(), 0); |
| 364 | optimizer()->FlushBasicBlock(); |
| 365 | CHECK_EQ(write_count(), 1); |
| 366 | CHECK_EQ(last_written(), second); |
| 367 | } |
| 368 | |
| 369 | TEST_F(BytecodePeepholeOptimizerTest, NopStatementStackCheck) { |
| 370 | BytecodeNode first(Bytecode::kNop); |
| 371 | first.source_info().Update({3, false}); |
| 372 | BytecodeNode second(Bytecode::kStackCheck); |
| 373 | optimizer()->Write(&first); |
| 374 | CHECK_EQ(write_count(), 0); |
| 375 | optimizer()->Write(&second); |
| 376 | CHECK_EQ(write_count(), 0); |
| 377 | optimizer()->FlushBasicBlock(); |
| 378 | CHECK_EQ(write_count(), 1); |
| 379 | second.source_info().Update(first.source_info()); |
| 380 | CHECK_EQ(last_written(), second); |
| 381 | } |
| 382 | |
| 383 | } // namespace interpreter |
| 384 | } // namespace internal |
| 385 | } // namespace v8 |