In accordance with "build one to throw away, you will anyway (tm)",
throw away the old signals simulation and more or less start again
from scratch. vg_signals.c is nearly a complete rewrite. In fact
this is now the third generation of the signals simulation.
The purpose of this is to properly support signals in threads -- a
nightmare combination. pthread_sigmask, pthread_kill and sigwait
are now alledged to work as POSIX requires.
In the process, throw away confusing and conceptually muddled old
implementation and replace with something which is more verbose but
conceptually cleaner, simpler and easier to argue is correct.
* When the client does sigaction/sigprocmask et al, the resulting
changes are stored verbatim in SCSS -- the Static Client Signal State.
So SCSS is the state the client believes the kernel is in.
* Every time SCSS changes, we recalculate the state the kernel
*should* be in so that our signal simulation works. This is the
SKSS -- Static Kernel Signal State. The kernel state is then
updated accordingly. By diffing the new and old SKSSs, the
number of real system calls made is minimised.
* The dynamic state of the client's signals is stored in DCSS
-- Dynamic Client Signal State. This just records which signals
are pending for which threads.
The big advantage of this scheme over the previous is that the SCSS ->
SKSS mapping is made explicit and gathered all in one place, rather
than spread out in a confusing way and done implicitly. That makes it
all lot easier to decide if the mapping, which is really the heart of
the signals simulation, is correct or not.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@271 a5019735-40e9-0310-863c-91ae7b9d1cf9
diff --git a/coregrind/vg_main.c b/coregrind/vg_main.c
index 0d965a6..a7e41b2 100644
--- a/coregrind/vg_main.c
+++ b/coregrind/vg_main.c
@@ -995,9 +995,16 @@
/* Process Valgrind's command-line opts (from env var VG_OPTS). */
process_cmd_line_options();
- /* Initialise the signal handling subsystem. */
+ /* Initialise the scheduler, and copy the client's state from
+ baseBlock into VG_(threads)[1]. This has to come before signal
+ initialisations. */
+ VG_(scheduler_init)();
+
+ /* Initialise the signal handling subsystem, temporarily parking
+ the saved blocking-mask in saved_sigmask. */
VG_(sigstartup_actions)();
+ /* Perhaps we're profiling Valgrind? */
# ifdef VG_PROFILE
VGP_(init_profiling)();
# endif
@@ -1051,8 +1058,8 @@
VG_(bbs_to_go) = VG_(clo_stop_after);
+ /* Run! */
VGP_PUSHCC(VgpSched);
- VG_(scheduler_init)();
src = VG_(scheduler)();
VGP_POPCC;
@@ -1118,7 +1125,7 @@
case VgSrc_ExitSyscall: /* the normal way out */
vg_assert(VG_(last_run_tid) > 0
&& VG_(last_run_tid) < VG_N_THREADS);
- tst = VG_(get_thread_state)(VG_(last_run_tid));
+ tst = & VG_(threads)[VG_(last_run_tid)];
vg_assert(tst->status == VgTs_Runnable);
/* The thread's %EBX will hold the arg to exit(), so we just
do exit with that arg. */